summaryrefslogtreecommitdiff
path: root/sw/source/ui/misc
AgeCommit message (Collapse)Author
2014-07-23convert SfxItemState constants to a proper enumNoel Grandin
and while we're at it - use the enum type all over the place instead of passing around sal_uInt16 - don't use bitwise logic on enum values - use enum values instead of numeric constants Change-Id: I7f24cb4d242e1c00703e7bbcf1a00c18ef1e9fd4
2014-07-22sal_uInt16 to size_tMatteo Casalin
Change-Id: Ia36a8d833b697dad4f6bbc611b703efcda4b220c
2014-07-03this string is in svxCaolán McNamara
we shouldn't be in this condition, but seeing as we are fix the string source. Change-Id: Ia746a24db3daae7952f4b5dbd94a315a4e79cf12
2014-06-24new compilerplugin returnbyrefNoel Grandin
Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-16turn the no-space edit widgets into a editwidget featureCaolán McNamara
especially because most of them don't handle intercepting text getting *pasted* into them right, so start with the one which does that right. Change-Id: If6770798872ed3c72c469656ebf0d4fd76d2171d
2014-06-13loplugin:staticcallStephan Bergmann
Change-Id: I26e1e0f66dad5ed4e8351fc7509449b312559166
2014-06-11Change SfxTabPage ctor SfxItemSet param from ref to pointerStephan Bergmann
...and also corresponding param of CreateTabPage function type and corresponding Craete functions. There were some call sites that passed undefined "null pointer references" and SfxTabPage internally uses a pointer member pSet that is checked for null anyway. Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
2014-06-11Change SfxTabPage::Reset param from ref to pointerStephan Bergmann
...there was a call site that passed undefined "null pointer reference" (apparently in a case where the passed argument was actually unused) Change-Id: I663d4264b7a84f44ca69c732f3bc502f614b2b2a
2014-06-10Change SfxTabPage::FillItemSet param from ref to pointerStephan Bergmann
...there were a number of call sites that passed undefined "null pointer references" (apparently in cases where the passed argument was actually unused) Change-Id: I19799e90f0cd8e98367782441a5ea9df27b59830
2014-06-05Avoid possible memory leaks in case of exceptionsTakeshi Abe
Change-Id: Iaf672463cf51d596148822d9b5effe5ab40f70d4
2014-06-04Avoid possible memory leaks in case of exceptionsTakeshi Abe
Change-Id: I45929aae52fa106b5f5c0199f8ce8b60c0ac5438
2014-05-27Remove ASCII art and useless comments from sw moduleChris Laplante
Change-Id: I3ba4ac78fd4810e006b1034bbe7c28b1803895d2 Reviewed-on: https://gerrit.libreoffice.org/9494 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-23Resolves: #i124204# make fields empty on the auto text dialog...Tsutomu Uchino
when parent node is selected (cherry picked from commit 3e285da1115b83bfd168567d561615fb3ee3e6c9) Conflicts: sw/source/ui/misc/glossary.cxx Change-Id: I9ef8b28e55a27d4b48432b50678e1a8bc19e0935
2014-05-11coverity#736863 Dereference before null checkCaolán McNamara
Change-Id: If719ed8411ee65c6b81452434810a21ac1da7e58
2014-05-08use new VCL IsValueChangedFromSaved methodNoel Grandin
follow to commit ff1a7a59434f5f793d4044aad615bcf78148e963 "RFC: add IsValueChangedFromSaved to VCL button and listbox" Change-Id: If2e6d9e7c18590dc4abbc90362d7897ca2557dd6
2014-05-01coverity#738912 Uninitialized scalar fieldCaolán McNamara
Change-Id: Id9b60bb33a1200f5fa6264d0801121ac9e12dc23
2014-05-01coverity#738911 Uninitialized pointer fieldCaolán McNamara
Change-Id: I89c9a17a7ea8dde3475826d03bdeef9e94da322c
2014-05-01coverity#738910 Uninitialized scalar fieldCaolán McNamara
Change-Id: I69583731182c09ffb995a2e86b46e0192544950c
2014-04-30coverity#738909 Uninitialized scalar fieldCaolán McNamara
Change-Id: I332d57bd7a82a734e509afe24c0c716ce8a4e455
2014-04-30sw: sal_Bool->boolNoel Grandin
Change-Id: I324a0ffde2ddcca105451c19e7aadcfad15211d8
2014-04-29coverity#1210183 Uninitialized pointer fieldCaolán McNamara
Change-Id: I9a86030d988473ac56ee1c6c1325b1eede2ba010
2014-04-27constLuboš Luňák
Change-Id: I0ce6965f191d1455bcc7a793025282e20b7433a5
2014-04-22remove unused hrc filesThomas Arnhold
Change-Id: I7ce04c206250db40076bed699bee892bdfbf19b6
2014-04-22clean up hrc filesThomas Arnhold
and remove some unused stuff Change-Id: Iea6177c3d2f9d0668187e66155b62688ae2ecb04
2014-04-15sw: clean up inter-module includesThomas Arnhold
Change-Id: I812842e76ae0b7bc252530d2b4aaa2b452c2babf
2014-04-08use TriState instead of sal_Bool as there's three possibilitiesCaolán McNamara
Change-Id: If24d4cec9ef4369f20419fe70de7392614a35316
2014-04-07untangle the bFmt == 2 hackCaolán McNamara
Firstly, IsFormat is unused so there's no "escape" of bFmt back into the outside world. Then bFmt has two purposes. Purpose 1 is 'not be a format dialog, be a format dialog, be a format dialog but hide standard button' so, lets just add an explicit "Hide standard button" method and call it in the (apparently) one place where it's necessary. Purpose 2 is to flag that "BaseFmtHdl" was called from clicking the "Standard" button at which point its set to 2. SfxTabDialog::Init_Impl had... " // bFmt = temporary Flag passed on in the Constructor(), // if bFmt == 2, then also sal_True, // additional suppression of the standard button, // after the Initializing set to sal_True again if ( bFmtFlag != 2 ) m_pBaseFmtBtn->Show(); else bFmtFlag = sal_True; " but the variable acted on is bFmtFlag a copy of bFmt, and is never read again after that line, so setting it to sal_True is meaningless. The comment suggests that the intent is to reset bFmt to true if it was 2 during initialization, which fits with the later use of bFmt == 2 to indicate that the standard button was clicked, i.e. reset bFmt back to its standard value. So make bFmt a simple toggle of dialog as a format dialog or not, add a way to remove the standard button and add a second variable to indicate the standard button got pressed. Change-Id: I98a441f5f314845abe243e05b6d92fd71d7b0b04
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01Bin pointless INET_PATH_TOKENTor Lillqvist
There is nothing mnemonic in the name 'INET_PATH_TOKEN' that would tell the code reader that it simply means '/'. Change-Id: I89ce72e8be5cf0ef2c66b23ad6e721ad49105648
2014-03-30coverity#1194912 Overflowed return valueCaolán McNamara
Change-Id: Ia32931ddb122e31bcd1cb18ecca694ae562d5d7f
2014-03-28Remove remaining DBG_NAME* usesStephan Bergmann
...that had been used for DBG_CTOR, DBG_PROF, etc. Change-Id: I8eac38e24b7110511feb7813aaf5a20ab82bdbe0
2014-03-27Second batch of adding SAL_OVERRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27sfx2: sal_Bool->boolNoel Grandin
Change-Id: I1fd02cc148fd9a54d2092dad1e548f51a0813a14
2014-03-25svtools: sal_Bool->boolNoel Grandin
Change-Id: Ifd3e643dbc6755839ad4af73ae141fd115ddb4f4
2014-03-24sal_uInt16 to sal_Int32 and remove a temporary OUStringMatteo Casalin
Change-Id: Ia305ad3b1e04129e172f0f2fe3428f84e4654576
2014-03-24Constify and reduce scopeMatteo Casalin
Change-Id: If80b842a79d476e5e90eeedc4520fc952c8f8f2a
2014-03-24Remove some OUString concatenated appends and some temporariesMatteo Casalin
Change-Id: I9f92a57644239b11941236a1cee5302eca993a7b
2014-03-24Result of expression is unused, remove that codeMatteo Casalin
This code has been there at least since 2000-09-18, so removing it seems to be safer than adding the evaluated token to the sMsg OUString, as the surrounding code would suggest. Change-Id: Ie9b2446b80a7bf79efbf6963b3a5e40548d4154c
2014-03-24sal_uInt16 to sal_uLong and remove unneeded castMatteo Casalin
Change-Id: I45152c575720e0720139d8a6d973333b105e1fa5
2014-03-24sal_uInt16 to sal_Int32Matteo Casalin
Change-Id: I9d92d5866be5f579a2d645d9039f9fb939e6e61e
2014-03-24Group common expressionMatteo Casalin
Change-Id: Id286b57ccba1edb35490c374740a58128ce7f0c4
2014-03-24sal_uInt16 to sal_Int32 and removed some unneeded castsMatteo Casalin
Change-Id: I122af4ed8a2504242f527cf98b26c9e1599497ea
2014-03-24sal_uInt16 to long in NumberingPreview::Paint and its helpersMatteo Casalin
Change-Id: I52f3365a00f05bf1ff34f5a01cb0c0dbdf2fda11
2014-03-24sal_uInt16 to long and constify loop boundMatteo Casalin
Change-Id: Iad9498676994cd60521f251fd84dcc2b90b54e88
2014-03-24Improved integer type consistence + some optimizationsMatteo Casalin
Change-Id: I5e2a6ef9c3f744997e9e473e9431d590ba6f9d04
2014-03-19Resolves: #i124371# When changing the numbering or bullet styling...Oliver-Rainer Wittmann
of a set of paragraph which have more than one different List Style applied create a new List Style and put the paragraphs into a new list. (cherry picked from commit 0087ca89e3905009ed947c651f3dc70f3d61ea93) Conflicts: sw/inc/doc.hxx sw/inc/docsh.hxx sw/inc/editsh.hxx sw/source/core/doc/docnum.cxx sw/source/core/docnode/ndcopy.cxx sw/source/core/edit/autofmt.cxx sw/source/core/edit/ednumber.cxx sw/source/core/uibase/app/docst.cxx sw/source/core/uibase/docvw/edtwin.cxx sw/source/core/uibase/inc/textsh.hxx sw/source/core/uibase/shells/listsh.cxx sw/source/core/uibase/shells/textsh1.cxx sw/source/core/uibase/shells/txtnum.cxx sw/source/core/uibase/uiview/formatclipboard.cxx sw/source/core/uibase/uiview/view2.cxx sw/source/core/uibase/wrtsh/wrtsh1.cxx sw/source/core/undo/unnum.cxx sw/source/core/unocore/unocrsrhelper.cxx sw/source/filter/ww1/fltshell.cxx sw/source/ui/misc/num.cxx Change-Id: Iadb5b386cada296d90d96aa75574024baac7ae3e
2014-03-18convert select multi paths dialogs to .uiCaolán McNamara
Change-Id: Iecb6dbee9e7af0600b8355db038ec597cab61d1a
2014-03-14make glossary edit categories a little tallerCaolán McNamara
Change-Id: Id5625b94bef8f580f3d895d302b4e1af18c0ed38
2014-03-11svx: sal_Bool->boolNoel Grandin
Change-Id: I5a6a57f708a3a5ce1f065e341ae9da24e0c91499
2014-03-11svx: sal_Bool->boolNoel Grandin
Change-Id: Ifd9279e7ccc671395caa1e6f3723e86062d2fb08
generated by cgit (git 2.34.1) at 2024-07-08 06:04:49 +0000