summaryrefslogtreecommitdiff
path: root/sw/source/ui/misc
AgeCommit message (Collapse)Author
8 daysloplugin:ostr in variousNoel Grandin
Change-Id: I7aa8ed716998a185996482dc561219b398a1c919 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169080 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-05loplugin:ostr in sw/.../miscNoel Grandin
Change-Id: Id64ac6bdebe93af6364ccf39d4ae8df333e775d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168425 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-31tdf#160984 sw continuous endnotes: hide not functional UI in this modeMiklos Vajna
Previous commits bug have fixed cases where opening a Word document rendered a different foot/endnote separator than expected for Word. The followings were modified: - distance between body text and separator, between separator and first note - the vertical position of the line - the length of the line Now ODT files keep the original feature set and Word files look as expected, but a couple of UI controls are ignored by the layout, hide these as they intentionally don't do anything while we're in Word compat mode. Change-Id: I72a3dde637d3e224038886a79550fa069253a4f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168295 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-05-09WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: I37166c03ffd0f8f76ddc03ce556b6e6341a02b48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167355 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-10tdf#146619 Drop unused 'using namespace' in: sw/Gabor Kelemen
Change-Id: I56463130ab617b0e11e237718cb8456913373818 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165696 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-03-27cool#8456 : Convert bookmark rename dialog to asyncAntony
* Changed bookmark rename dialog from synchronous to asynchronous execution. * Removed the reference operator from variables m_xNamed and m_xNameAccess declared in swrenamexnameddlg.hxx to prevent use-after-free Change-Id: I2e4e777c5c56137504b646bdbe82e265ef73b2ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164803 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 1222d98eaad463e35286f215b3bdeb909ea155bf) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165323 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-20related tdf#150197: ensure HasListFormatJustin Luth
Steps to reproduce 1.) tools - Heading numbering - set "Number" to non-NONE (e.g. 1, 2, 3) 2.) set a paragraph to "Heading 1" style (to ensure we export style) 3.) export to assert.docx hits commit 727c5ed30f68abc28bb04531b25a1df30810760f assert(false && "deprecated format still exists and is unhandled. Inform Vasily or Justin"); Not reproduced with "Bullets and numbering" Change-Id: I99395f8905075dc0ec6ae04a0fd7a28b64da06af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165036 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-02-18ITEM: Rename for more control over SlotID usagesArmin Le Grand (allotropia)
Change-Id: I51585f1c15984a066262023184f668662853d20f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163556 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-01-31move CharMap out of cuiCaolán McNamara
remove CUI_DLLPUBLIC from stuff which is not exported then drop the cui/include dir which is then empty and the places we link to cui where we now don't need to and restore cui back to a lib containing stuff that doesn't need to be explictly linked to in keeping with original #i106421# idea Change-Id: I21894e6f8529dd3306df345fb52dbf5009015f3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162798 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-01-30make sorting dialog asyncNoel Grandin
Change-Id: I9773ec07e13144662a06307452b17f9e96527e89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162759 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-01-30make glossary dialog asyncNoel Grandin
Change-Id: I7ed5da9e06656bc658728b8e61b02f767ddd6bb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162750 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-01-23make event config dialog asyncNoel Grandin
Change-Id: Ibbfbc5024fb2be4906d0c312577310f28dde212d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162434 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-01-22make charmap dialog asyncNoel Grandin
Change-Id: I222240dc1715604ad1e82e1062b34d116b2840f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162367 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-01-04tdf#155649: EDITING Writer some position parameters cannot go beyond 17 mmJulien Nabet
Change-Id: I70a80527dcc1c714fbe8783d1c4594bcc26b0624 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161528 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-11-25loplugin:fieldcast in SwOneExampleFrameNoel Grandin
Change-Id: Ic00ad388b2c18d90075db8e8d0d6b114ed13841a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159948 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-20c++20: use std::erase(_if) instead of std::remove(_if)+erase (sw)Julien Nabet
Change-Id: I67c231441b56f05da001beab5b893bc6a6a6a392 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159704 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-11-19Extended loplugin:ostr: swStephan Bergmann
Change-Id: I210f61f6d90776b086b7058fb1a831d235699fb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159670 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-11-13don't need this in the endCaolán McNamara
Change-Id: Iebb5131209c289bd797682c8f79d925449b551e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159350 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-12tdf#158171: fix crash when double-clicking DeepL translation dialog OK buttonJulien Nabet
Change-Id: I4954357c59c7134d882fb19e9949ecbd5d60345a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159322 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-14Re-enable Bullets and Numbering → CustomizeSkyler Grey
- Revert change If0f7b953a40ca1d5f469087cb8f362a949c39b37 - Enable jsdialog for the customize page - Fix numbering not being selected when switching level - Fix start at field not having a default when changing level type to one that can use it - Disable types that rely on supporting graphics in LOK as we cannot provide them Change-Id: I2517289b553b8a3e9ed62c64b6514c6aab3702b6 Signed-off-by: Skyler Grey <skyler.grey@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153806 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 6b9415005fee130e9d9b4b005a56975794a47934) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157957 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-16itemset is always passed, so can use a referenceCaolán McNamara
Change-Id: Id238066861ee21a9a69f40d1c136bd5b5bd0f804 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155735 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-07jsdialog: enable Insert Title Page dialogSzymon Kłos
we need to weld also RB_INSERT_NEW_PAGES so when we check it - JSDialog executor will make it active and RB_USE_EXISTING_PAGES inactive Change-Id: I0abc5b6610e301abb1d24ecea680f63358dc5584 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153189 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153987 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-06-26new loplugin:constexprliteralNoel Grandin
OUStringLiteral should be declared constexpr, to enforce that it is initialised at compile-time and not runtime. This seems to make a different at least on Visual Studio Change-Id: I1698f5fa22ddb480347c2f4d444530c2e0e88d92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153499 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-14Remove hardcoded values in pagenumberdlgParis Oplopoios
Removed hardcoded text width/heights and margins in pagenumberdlg to create the preview image and also added a different text preview for IncludePageTotal mode Change-Id: Ib4f4f9ba702f87babf13c1435dc3845add1f43cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153030 Tested-by: Jenkins Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
2023-06-05tdf#152431 Fix line count resets to zero after 65535Bogdan B
GetLineCount was a sal_uInt16 value, that allows only 65535 lines to be counted. This is changed to sal_Int32 and also the underlying data type for the lines number is changed from sal_uLong to sal_Int32, but not for pages number. With this change, the maximum possible line number is now increased to 2^31-1 = 2,147,483,647. Change-Id: Ibee2d24e638204133f0ef085564016543f73d351 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143173 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-05-30tdf#145538,tdf#147021: sw/source: range based loopsDr. David Alan Gilbert
A bunch of range based loop changes in sw/source that also take out SAL_N_ELEMENTS usages Change-Id: I28b929d2ecbe40c1b257454f21b5d2ff51d617e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152251 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-02tdf#86630 sw page number wizard: add page totalJustin Luth
1 - 3 is the format of the output. Not totally clear, but it is at least not in English, and I'm fairly certain I've seen this format used numerous times. At least everything is there, and all the user needs to do is modify the - to be whatever they want. I checked to see if by some miracle localedata had a specification for "X of Y" but it doesn't. Change-Id: Iae1e74e612ec449f72086b3f5a5e32713fee4d27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151173 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-28tdf#86630 sw page number wizard: mirror right/leftJustin Luth
If the user puts the page numbers on the left or right side of the page, they usually want that mirrored on even and odd pages. This got rather tricky, but in the end I have enough safeguards that it seems to work logically and stablely. So I think it is ready to be submitted. Change-Id: I321e575cd9f6718579ffee99f1258bffe26581f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151152 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2023-04-27cid#1528191 Uninitialized scalar fieldCaolán McNamara
Change-Id: I0d57f541fb110af295db6b56c32e7ee32168b463 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151097 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-26tdf#86630 sw page number wizard: set page style numbering typeJustin Luth
Giving the user the opportunity to change the number type is rather important. Well, maybe not too critical since I assume that the default page number style is relatively accurate for each locale, and at least for English we always just use numbers for the page style. However, a wizard is the perfect place to expose such a setting, otherwise it is buried in page style settings - far from where anyone would look when inserting a page number. Change-Id: I9053504fa55d16ebf5424946b480cb044b79988c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151005 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-26tdf#86630 sw page number wizard: default to center of pageJustin Luth
Defaulting to one side of the page only makes sense if the footer is mirrored. [Well, mirrored isn't the best word here because it only refers to margin spacing.] The only way to get mirrored footers is to have separate left and right pages. It would be nice to add mirroring to the wizard, but that can be done separately. First, lets just get a better default value in place. Change-Id: I314c6a34414a696c6f2e27bb2b0747fdb86f3b22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150998 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
2023-04-19loplugin::unusedmethodsNoel Grandin
Change-Id: I6a07860edb13588b83345babeb53675aedc43f7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150607 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-03tdf#146312 - Chapter numbering dialog: show paragraph style [None] in previewAndreas Heinisch
Change-Id: Icb576df2f0de255aba9fdfddad81b654a48c6c36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149948 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-04-02Avoid conversions between OUString and OString in VCLMike Kaganski
Standardize on OUString, which is the main internal string class. Convert from/to OUString only when communicating with respective external APIs. Removes about 200 conversions from the code. Change-Id: I96ecee7c6fd271bb76639220e96d69d2964bed26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149930 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-29loplugin:stringadd in swNoel Grandin
when applying my upcoming patch to also consider O[U]StringBuffer Change-Id: I0999a0b04236c276d49c541bbbe3932ba3e5e05d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149678 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-23cid#1524497 Uninitialized pointer fieldCaolán McNamara
Change-Id: Ic3f347b9a588bda459411f917be47cbfa442d3e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149459 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-22sw: check GetActiveView()Xisco Fauli
See https://crashreport.libreoffice.org/stats/signature/SwView::GetDocShell() Change-Id: I90ebbff5082f1f9cae7fa3b940cbb9796d6c6dd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149223 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-16De-static-izing colors in SwViewOptionParis Oplopoios
The view colors in SwViewOption were static which means that two separate views couldn't have different colors Change-Id: Id595b00ba56bdb210ad1a784cf76e99ead0d6014 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148481 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-03-15Use officecfg instead of SvxDeeplOptionsNoel Grandin
Change-Id: I977d9be45fa17b960cccb0915c5f2762bf11288f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148885 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-14tdf#154179: fix pre-selection of the current outline levelMike Kaganski
This seems to always be the intention, and never worked. The pre-selection made in SwOutlineSettingsTabPage::SetWrtShell was overridden later in the SwOutlineSettingsTabPage::ActivatePage, because SwOutlineTabDialog::s_nNumLevel wasn't updated to the wanted value. Additionally, it only could potentially work when the dialog opened the SwOutlineSettingsTabPage, not the other page (which would happen when it was active the last time when the dialog closed). And the active document level value must be sanitized. Change-Id: Iefefcdcde9da0e54e3acaffb981e057367a27197 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148837 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-14language list in SwTranslateLangSelectDlg can be staticNoel Grandin
Change-Id: Ica911ec651e536e399491c0c28765aeb9e021548 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148843 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-27tdf#151548 sw content controls: add UI for Id and TabIndexJustin Luth
This is my first go at adding anything to the UI. (I've done some fixing of other people's design, but never created anything new myself.) I took all my inspiration from Miklos' add110bad816fadeb96e7af0d4689389c04c263e. In the first iteration I did a fancy "same as id" scenario. But ID-as-unsigned, securing unique IDs, and English-only number recognition sadly made me decide to drop the fancy features. Now, both are simple, stand-alone spinbuttons that depend on tooltips to guide user input, not fancy comboboxes. It is important for the ID to display as unsigned, since that is how it is used as a "name" in VBA. It should be copy-pasteable for use in VBA programming. It is useful for the TABINDEX to display as signed, since it allows entering a -1 to disable tab navigation to the control. make UITest_sw_ui_misc Change-Id: Ia7c99888e60c33ac39616b24c7c1715604c3ec69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147591 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-02-21sw: check GetWrtShellPtr()Xisco Fauli
Change-Id: I8d99e9108f6163eafb7576603826f8d02a0ff416 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147336 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-17use a reference here to flag its never nullCaolán McNamara
Change-Id: Ib57be7f076f4ec720d9d153034d00915a82e9ae7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147215 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-17SfxViewFrame* arg of SfxRequest ctor always dereferencedCaolán McNamara
change it to take a reference Change-Id: Ib9349f4c2660d297d93ee81256e7fa9873728ba3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147163 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-16HasMacroRecorder can take a reference, never passed nullCaolán McNamara
Change-Id: I213f2d93e49f03e88a5357af8fead32b97b2c37b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147149 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-16SfxViewShell::GetViewFrame never returns null, change to a referenceCaolán McNamara
various null checks can be seen to be redundant and removed Change-Id: Icf49c1de4b0302795d2769a370af3abceaad0221 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147147 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-11tdf#124088 - Propose AutoText and shortcut name based on selected textAndreas Heinisch
Change-Id: I55ab9b41a32d7a4e41465f375179997a5c8dd06a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145175 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-01-06tdf#86630 sw: Add one-step page number insertion wizardofftkp
Add a one-step wizard for easy insertion of the page number to the header/footer. Change-Id: Idb33c92d594e04d9256460fe414e4b10e5166af5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144683 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-12-05sw: prefix members of SwFootNotePage, SwFormatTablePage, ...Miklos Vajna
... SwOutlineTabDialog and SwTextFlowPage See tdf#94879 for motivation. Change-Id: Ie863c244d0fa5b885e1be1949f997410e27f80d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143661 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2024-06-26 13:33:03 +0000