summaryrefslogtreecommitdiff
path: root/sw/source/ui
AgeCommit message (Collapse)Author
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-19allow generated, unique frame name to be savedJustin Luth
The document in tdf#77122 shows that frames can exist without a name. Going to frame properties showed "Frame1" as the name for each frame, and pressing OK didn't "set" this suggested name - the name remained blank. An alternative fix is removing "pNameED->SaveValue();". However, this approach seems safer. Change-Id: I1ed9d67442d55f2c481e6e4b35a876721a835522 Reviewed-on: https://gerrit.libreoffice.org/14548 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-17tdf#89085 Edit page break does not open proper tabRishabh Kumar
Current Behavior : opens a random tab Expected behavior : open Text Flow tab Change-Id: I4bbd9dcf2bbbb237d5d70ef07b88f40be9681e7a Reviewed-on: https://gerrit.libreoffice.org/14486 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-16add GetSelectEntryData to ListBox and ComboBoxNoel Grandin
to reduce code clutter like pLbSelect->GetEntryData(pLbSelect->GetSelectEntryPos()) since this is a fairly frequent operation. Change-Id: I41daf30fdeda2442ad1ac829e12f553233bae184 Reviewed-on: https://gerrit.libreoffice.org/14472 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-09Resolves: fdo#88933 Labeling of images impossible without categoryCaolán McNamara
Change-Id: I8b618d5cd6b3e9d5e42e04e215592a7b748dbb9f
2015-02-06shared_ptr<T>(new T(args)) -> make_shared<T>(args)Caolán McNamara
and boost:make_shared->std::make_shared Change-Id: Ic1e187c52c856a7b27817967b2caa8920f23a98d
2015-02-04Resolves: fdo#68137 crash in traversing script fieldsCaolán McNamara
use the same guards as the SwFldEditDlg does Change-Id: I7d135cf969d9925cec57a90ef0fba8fe40f664eb
2015-02-04tdf#88854 crash on opening drop capsCaolán McNamara
Change-Id: I3ab56e4909d2a20dc8f0bafe0273e81065296f17
2015-02-03Typo: selction/slection -> selectionJulien Nabet
Change-Id: I3f405d9525d3afb6534166fd733cabf7779a2846
2015-02-03Use offapi constants instead of hardcoded magic constantMichael Stahl
Change-Id: I53b86e3baebbcca7cb0a72aa072db3da0f84fd4f Reviewed-on: https://gerrit.libreoffice.org/14303 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-02-03tdf#77241: sw: fix creation of field data source stringMichael Stahl
SwChangeDBDlg::UpdateFlds() depends on undefined behaviour in constructing sTemp, because the call to GetDBName initializes local variables that are already used in other sub-expressions of the statement. (regression from 8a7a9992906ba59d575ca9e4441b3e84fea5fae0) Change-Id: Ibf8c0091da672e133d7a35bc61c059eaf65a3bc2 Reviewed-on: https://gerrit.libreoffice.org/14302 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-02-02tdf#68183 sw: config option for disabling the creation of automatic RSID marksMiklos Vajna
It was a problem since the initial commit 062eaeffe7cb986255063bb9b0a5f3fb3fc8e34c (sw: Improved document comparison based on RSIDs., 2011-12-22) that this new feature -- which is annoying for some use-cases -- could not be disabled, let's allow that. Change-Id: I33fa77382919586fb00198246f737caa68dcbd85 Reviewed-on: https://gerrit.libreoffice.org/14277 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-28Resolves: fdo#50640 make sure we don't move away from the current fieldCaolán McNamara
by accident by trying to select the entire field if its inside an invisible area where WrtShell::Right will skip automatically to the next visible area Change-Id: Iafe9ebd1430db8e6022fec89729d0abb62dad0bb
2015-01-28fdo#86984: UI Line numbering works only for EN_USMuthu Subramanian
Change-Id: I0fadb6f5f96cccd4056a164a6b0f3b2fdd68a40b Reviewed-on: https://gerrit.libreoffice.org/14168 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-01-27Revert "merge these two selection changing hunks of code"Caolán McNamara
This reverts commit bef9cc01c7da9fd75393bfa1818e07f484306829.
2015-01-27merge these two selection changing hunks of codeCaolán McNamara
Change-Id: I4113a38a3a15cd2173f9a2530dc2e7278b8713b2
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-22Resolves: fdo#88378 flipping by reversing co-ord system no longer worksCaolán McNamara
not entirely sure when this stopped working, but our contempory code is riddled with asserts and throws for negative sizes so rework this to explicitly mirror the preview rather than try the no longer working technique Change-Id: Ie90283cad2797ab1c37848469b007dc01a2c9d75
2015-01-22Some more loplugin:cstylecast: swStephan Bergmann
note the two TODOs about suspicious casts Change-Id: I324fa05b30a5c8aa1d9e9a6d488a1e295226e788
2015-01-20Drop unused comphelper::service_decl::component_getFactoryHelper paramsStephan Bergmann
Change-Id: Ia47c0bc3539ddf8f925cd053a2431c742c46d337
2015-01-19fdo#39440 sw: reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: I0de4e6278fb564c299722a9e23eb67d0999c4e31 Reviewed-on: https://gerrit.libreoffice.org/13966 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-12radio check top/center/bottom alignment for table cellsCaolán McNamara
Change-Id: I30b51510ac5fbfb3c1dd09e0f86a246a8b516f1e
2015-01-12convert SETTINGS_ #defines to 'enum class'Noel Grandin
and dump the ones that nothing is listening to Change-Id: I253ef284df785812a439dd160edba1b07fdbaac4
2015-01-12fdo#84938: replace DATACHANGED_ constants with 'enum class'Noel Grandin
and drop DATACHANGED_DATETIME because no-one is using it Change-Id: Id5ac9a7fbba0e35501ed82e5252f66858621f7ff
2015-01-09fdo#84938: convert FRMTYPE_ #defines to 'enum class'Noel Grandin
and consequently fix bug in SwPageFrm::PreparePage where it was comparing against the wrong #define's Change-Id: I681f7e9f3f9bbe1ddf2613814ed36cfe0955825f
2015-01-07Resolves: fdo#87612 don't overwrite users input if the value is unchangedCaolán McNamara
so you can enter values without them getting auto-expanded to their canonical form as you're typing them and having the insertion point jump to the start causing real confusion. But retain the improvement of fdo#61704 where the value is set when modified so clicking "ok" without leaving the field works as expected Change-Id: I786b53c2717e232b36e7cc95d99c98aa1f2cd44e
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-04cppcheck: Possible inefficient checking for <var> emptinessJulien Nabet
Change-Id: I6ca0e477a4429e762c48c721951b9876db3a5c6c
2015-01-04changes sidebar: Use images instead of texts for types of changes in Writer.Jan Holesovsky
This is a Writer-only change because: 1) Calc does not have the changes sidebar yet. 2) The redlines in Calc have more complex descriptions (like 'Deleted column'), so postponing that for now until I have a good list of the possible values there so that I can ask for the icons. Change-Id: I2d9860261d0b690012c3c11cdd97a140f48842bf
2015-01-03boost::unordered_map->std::unordered_mapCaolán McNamara
Change-Id: I2c65709cda6f10810452dfb8aa1a247cb3a5564f
2015-01-02Remove unnecessary comphelper::string::getTokenStephan Bergmann
Change-Id: I49192637121441b9a1980350b9bb32cd995d4386
2014-12-28fdo#83565 addition of wrap left and wrap right to context menuYousuf Philips
Change-Id: I8eb75b736a559c56960864bd0255b96982b9858a Reviewed-on: https://gerrit.libreoffice.org/13677 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2014-12-26fdo#87185 rearrange image context menu and add icons to a few entriesYousuf Philips
Change-Id: I7d28aea1059ec87cbc72ccea40dc000f51e6560b Reviewed-on: https://gerrit.libreoffice.org/13662 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2014-12-23coverity#1260296 Unchecked dynamic_castCaolán McNamara
Change-Id: Ib19609c3f4c83ae8baef83bcdadee79e69743df5
2014-12-23fdo#87185 add verbs before entries in image context menuYousuf Philips
Change-Id: I902c40d2d88857eec4fd30c36af19ca3af0c2d98 Reviewed-on: https://gerrit.libreoffice.org/13616 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2014-12-22fix buildCaolán McNamara
Change-Id: I354db780cef6f9a653f5eb9a734b7edf258c191e
2014-12-22fdo#87185 reorganize the image context menuYousuf Philips
Change-Id: I31e8f713f65b05e0a17fa79785bed6834dc973b4 Reviewed-on: https://gerrit.libreoffice.org/13570 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2014-12-20Typo: paremeter/paramater=>parameterJulien Nabet
Change-Id: I26993b9cf01408803e0353e93079e56d1f57f589
2014-12-19changes sidebar: Manage Changes (Redlining) panel instead of the dialog box.Jan Holesovsky
Change-Id: I4fd415845e2732ee8ef0567b8c58b878bb52fac8
2014-12-18sw: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I9c3e03324c69beb5af4c43da208086600876f875
2014-12-17Introduce rtl::OUStringLiteral1Stephan Bergmann
...to use single ASCII character literals "more directly" in the OUString API (instead of having to go via an intermediary OUString ctor call). Especially useful for character literals that are defined as const variables or via macros ("direct" uses of character literals in the OUString API can often simply be replaced with single-character string literals, for improved readability). (The functions overloaded for OUStringLiteral1 are those that are actually used by the existing LO code; more could potentially be added. The asymmetry in the operator ==/!= parameter types is by design, though---writing code like 'x' == s is an abomination that shall not be abetted.) Change-Id: Ic5264714be7439eed56b5dfca6ccaee277306f1f
2014-12-15sw: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I559d1e44d9096a2583af8e05468b3743ac210c6c
2014-12-11-Werror,-Wunused-variableStephan Bergmann
Change-Id: I7afbcb0fb24406e9331cbfb104f0625e6e8fe14e
2014-12-10Use Any specializations for bool, instead of SetValueMatteo Casalin
Change-Id: I7a5babe494bdb09a71164ea74d7be3f6bf985ff6 Reviewed-on: https://gerrit.libreoffice.org/13215 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-12-09fdo#86619 removal of less used table context menu itemsYousuf Philips
Change-Id: I0a1a329945958080aa8d41e5bf6257471f8ebf84 Reviewed-on: https://gerrit.libreoffice.org/13394 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2014-12-09changed timer to idleTobias Madl
Change-Id: I58bcbf7f7f2d1f7237561d5abf8e73d46d0726de
2014-12-09changed some timer to idleTobias Madl
Change-Id: Ibd3a4f66cec6fde4fadc064f27ac44901d005b15
2014-12-07loplugin:cstylecast, involving pointer to incomplete typeStephan Bergmann
Change-Id: Ida681fd1c36219c1ccbdb4bb54196cf737c88b4b
2014-12-07loplugin:cstylecast, involving pointer to incomplete typeStephan Bergmann
Change-Id: Ie681e2a6408286e0b2f49d68f6cf8fa37c145318
generated by cgit (git 2.34.1) at 2024-07-18 11:10:31 +0000