summaryrefslogtreecommitdiff
path: root/sw/source/ui
AgeCommit message (Collapse)Author
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-03loplugin:countusersofdefaultparams in sw..vclNoel Grandin
Change-Id: I152df55f5a30e073c66cfd3a64d5090a20cb232d Reviewed-on: https://gerrit.libreoffice.org/29471 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-03Fix typosAndrea Gelmini
Change-Id: Ie75beb4e282a4d1b784a5847262e39cf9c851527 Reviewed-on: https://gerrit.libreoffice.org/29440 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-29Page margin popup converted to use outside sidebarSzymon Kłos
Change-Id: I3c4cc20fc8f2818677a77f848a1566bb56ceb7c6 Reviewed-on: https://gerrit.libreoffice.org/29363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-21tdf#101359 handle less bookmarks then expectedJan-Marek Glogowski
Change-Id: Iaa4a54aecbe894296609f462db451c2ed94b1213
2016-09-20loplugin:defaultparamsTor Lillqvist
Change-Id: Ic314f620e711f8e16980c568c28b7cc361c5c1a8
2016-09-20tdf#101359 Really walk the document mark listJan-Marek Glogowski
In both functions we want to walk the current mark list and act on the MarkType::BOOKMARK, so mimic the behaviour of PopulateTable in HaveBookmarksChanged. My previous commit 96454829f7dc6480f9ddd4262bc03d5ccabadea4 is broken and just works out of luck... Change-Id: I2f53b775208cad7e83992d1ae4fb67a41588cb92
2016-09-20tdf#101164 sw: Insert Database Columns dialog: expect selectionMichael Stahl
... as bookmarks, not raw row indexes. Bookmarks is what FmXGridPeer::getSelection() / FmGridControl::getSelectionBookmarks() always produce, and it's unclear to me if there even is a case where something other than a bookmark ends up pasted into Writer. The only case where dbaccess creates a selection that doesn't contain bookmarks is in SbaGridControl::implTransferSelectedRows() if no rows are selected but i haven't figured out how to reach that state. (regression in OOo 3.3) Change-Id: Ib45787bc002447338df775102790843f2cb1dd3b
2016-09-20tdf#101164 sw: Insert Database Columns dialog: ensure one of ...Michael Stahl
... the radio buttons is active by default, in case there's no configuration to read the state from yet. Change-Id: If1c0462eb5cb9ea5177f1d5a8953b34fabd0829c
2016-09-16tdf#101359 Just advance list box for BOOKMARKsJan-Marek Glogowski
Since the list box just contains MarkType::BOOKMARK, just advance the list box position for marks of this type. Change-Id: I7b8743abb1ffb2fda2242c5e7301b3ff15ae355b
2016-09-16tdf#56907 extend dot leader character list in ToC for typographyLászló Németh
Add ONE DOT LEADER, TWO DOT LEADER and HORIZONTAL ELLIPSIS characters to the "Fill character" list of tab stop entries in Table of Contents formatting. These characters give typographically better dot leaders, than the default dense FULL STOP dot leader. See also http://scripts.sil.org/CharStories_2024 Change-Id: I1d10c8bf59b2722c3ec78d59063a25534570129b Reviewed-on: https://gerrit.libreoffice.org/28937 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2016-09-13loplugin:dllprivateStephan Bergmann
Change-Id: I1fe70a39c50aba8b84c117653185fc37dbbfeab0
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-12Page size popup converted to use outside sidebarSzymon Kłos
Change-Id: Ia9c4c03a9780dca146adda8f1a126197d3e38643 Reviewed-on: https://gerrit.libreoffice.org/28816 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-09handle read-only state of wordcount settingsAndras Timar
Change-Id: I1ece8611bbc2d3635abf7270418cefe2834b797b Reviewed-on: https://gerrit.libreoffice.org/28762 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-09loplugin:constantparam in svtoolsNoel Grandin
Change-Id: I04caae0c9ae621c55e16d3bdc014a4729617feb3 Reviewed-on: https://gerrit.libreoffice.org/28757 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-08loplugin:constantparam in swNoel Grandin
Change-Id: Ibae4cac28e6ff52298c804519f683017729c07a5
2016-09-08loplugin:constantparam in swNoel Grandin
Change-Id: Ic49d1c3c7b57fb213964ddc21b0f774c762aad94
2016-09-07Page column popup converted to use outside the sidebarSzymon Kłos
Change-Id: Iedb239eba5d74d10cef68276c2a03028f8cf81bf Reviewed-on: https://gerrit.libreoffice.org/28703 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-07loplugin:constantparam in swNoel Grandin
Change-Id: I16badc615e98202668b1b201035b5137cb94c10c
2016-09-05sw: prefix members of SwEntryBrowseBoxMiklos Vajna
Change-Id: If6e368a5d3bd1dfddb58556cbd9c249f9ced32fe Reviewed-on: https://gerrit.libreoffice.org/28671 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-09-05Page orientation popup converted to use outside sidebarSzymon Kłos
* popup converted to .ui file * added .uno:Orientation * label & icon for .uno:Orientation * control inserted to the notebookbar.ui (Page layout tab) Change-Id: I93f35a65c4461635d0cfd1afd4546a9d2a8c4d04 Reviewed-on: https://gerrit.libreoffice.org/28405 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-03cppcheck: variableScopeZolnai Tamás
Change-Id: Id290ca5e53c75b2c27dda6a6bb228a380084b115
2016-08-31Resolves: tdf#100094 hyperlink tabpage put hyperlink name in wrong fieldCaolán McNamara
mismerge of commit 74593273655e475017bb2bd45aba3c6b132e372d Date: Thu Jan 9 12:59:28 2014 +0000 Resolves: #i123988# assure that hyperlink attribute... Change-Id: I45391b112666a07a0edfa49b2a8682c446a92cf4
2016-08-31convert LB_ constants to typed_flagsNoel Grandin
Change-Id: I2293b0120bff73f51ed7ea4d12d5ef3eb1bcba81
2016-08-31convert MOVE_ITEM constants to typed_flagsNoel Grandin
Change-Id: I9be9226cbe9bf6b76df3132d1ed3f08ea65bf273
2016-08-31inline some get-function-pointer-collection functionsNoel Grandin
no need to have two different ways of getting to the SwMoveFnCollection structs, they are already exposed and used as global constants Change-Id: Iec6e1ee2d9cd2edb8237f24d72024652271a9d5e
2016-08-31Get rid of a pointless indirect function pointer variableNoel Grandin
Change-Id: I81055c6973247e226dc9dc3fda072aef94fa8966
2016-08-31Get rid of a pointless indirect function pointer variableNoel Grandin
Change-Id: I542a5fb00a5c972230c072d72a745fddb095f708
2016-08-31convert FindRanges to o3tl::typed_flags_setNoel Grandin
Change-Id: I745b2f469e44b79a06a18bc5264aae75b096835c
2016-08-31convert SwDocPositions to scoped enumNoel Grandin
Change-Id: Idd9414b4a10398130337e474fb8fd4063e3bd4f8
2016-08-31remove the SwMoveFnCollection* typedefsNoel Grandin
which were just obscuring the code, and pass it around by const& Change-Id: I4fce5ef4bf616867c46a145f660a8e90d3c94462
2016-08-30rework for coverity#1371269 Missing move assignment operatorCaolán McNamara
Change-Id: I10f9ed448854b4ece61fd84b8aa49674d0828cac
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (sw)Stephan Bergmann
Change-Id: Ifa1a6bafd3628b48ebceb09f8cd864361848e81c
2016-08-30Let OUStringLiteral1 take its arg as ctor arg, not template argStephan Bergmann
...which makes it more flexible, can now also be used on non-const arguments. The drawback of the argument no longer being a compile-time constant is remedied by making the ctor constexpr. Change-Id: Ia4903a2cc86791fece92eac0cb8406b6659dd19d
2016-08-29Adapt loplugin:stringconstant to improved OUStringLiteral1Stephan Bergmann
Change-Id: Ibc5128df8bcf8cb5f2f09551c0de6dfdb46bdee0 Reviewed-on: https://gerrit.libreoffice.org/28447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-26convert SV_ITEM_ID_LBOX defines to scoped enumJochen Nitschke
and remove unused SV_ITEM_ID_EXTENDRLBOXSTRING Change-Id: Ic84d9341d0225b01b9ef46814483c66b1af307b5 Reviewed-on: https://gerrit.libreoffice.org/28397 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-25loplugin:countusersofdefaultparamsNoel Grandin
Change-Id: I7150494a56abc6ec9c7fba39cefe3967a475f073
2016-08-23Remaining clang-tidy misc-move-constructor-initStephan Bergmann
...by turning the relevant ctor parameters into "const &" (following 8f30da6386fa414b9fe4c704b294a978df77347b "Some clang-tidy misc-move-constructor-init"). Change-Id: I6686dabe2f05156d6ecd49aa76a3a1166ccac045
2016-08-22Avoid illegal cast of SwDropDownFieldType to SwSetExpFieldTypeStephan Bergmann
...once the loop reaches an SwDropDownFieldType (whose GetName() is empty), and m_pCategoryBox->GetText() is empty (which it appears is always the case here in the constructor?), as e.g. happens when opening Writer's "Tools - Options... - LibreOffice Writer - AutoCaption". Change-Id: I11128981f32691158e1d5de74117c1b1a9d5fea4
2016-08-19coverity#1371115 Unchecked return valueCaolán McNamara
Change-Id: I71749199bdfc7f00acc955038e519e790bd9c373
2016-08-19Resolves: coverity#705366 Mixing enum typesCaolán McNamara
and coverity#705367 Mixing enum types coverity#705371 Mixing enum types coverity#982694 Mixing enum types coverity#1027717 Mixing enum types coverity#1371228 Mixing enum types coverity#1371242 Mixing enum types coverity#1371280 Mixing enum types coverity#1371310 Mixing enum types MapUnit and SfxMapUnit share the same values and are freely cast from one to the other. Now that commit d30a4298bdb5ba53cd1fe659f2b742f218a2e527 Date: Thu Aug 11 15:02:19 2016 +0200 loplugin:unusedenumconstants in package..svtools removed the SfxMapUnit entries that were directly unused, they don't match anymore and casting from one to the other is dangerous. Why there was two of these anyway escapes me, get rid of SfxMapUnit and just use MapUnit universally Change-Id: I4db5dcd04b59be2f85b62b728f96c90afe00c57e Reviewed-on: https://gerrit.libreoffice.org/28234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-19loplugin:countusersofdefaultparams in swNoel Grandin
Change-Id: I668bfe93d77b06385544651583bcf71f6b5df2fc
2016-08-17convert SvxTabAdjust to scoped enumNoel Grandin
Change-Id: I29a33b8ea5daaa4b9059d024ffa4a99ca924f7ef
2016-08-17convert SvxBreak to scoped enumNoel Grandin
Change-Id: If8b79ed617e5662550bd73bd1506d047217f2313
2016-08-15Related: tdf#87686 on refresh from selection, only consider the edit updatedCaolán McNamara
not the category list, which re-guesses the keys. So user input keys remain the same on resync Change-Id: I75a069bb3e828f8d5910f36996c6538c4cde4431
2016-08-15convert SvxCompareMode to scoped enumNoel Grandin
and move it to SW since it is only used there Change-Id: I9cc7869564e24a8ce733f30ef453751a854cf7e0
2016-08-15tdf#100782 have XPropertyList hold unique_ptrJochen Nitschke
Change-Id: I928f297e1be76b965898d83cb3dd2e79b23b7974 Reviewed-on: https://gerrit.libreoffice.org/28095 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-12Resolves: tdf#87686 don't refresh index entry from selection on regain focusCaolán McNamara
Remain populating it from the initial selection on popup, but on losing focus and regaining it, leave the contents alone. Provide a refresh button to provide access to optionally updating the contents from the document selection. Change-Id: Ifcde5fac341655f1219f4d2a7057e788d3bb0b18
generated by cgit (git 2.34.1) at 2025-02-13 06:18:58 +0000