Age | Commit message (Collapse) | Author |
|
ItemType is useful and faster than RTTI. Until now it was
implemented by a 16-bit member in the base class, plus
(potentially) all constructors having to hand a value
in at item construction type (of type SfxItemType) to
get that member set correctly.
This works, but there is no reliable way to guarantee
coverage, and there have already been cases with missing
SfxItemType - these fallback to '0' and thus all Items
with ItemType() == 0 are assumed equal and might be
static_cast'ed to the wrong classes. Note that I
identified *35* Items that had no correct ItemType
set/implemented actually. It also uses 16-bit per
incarnated Item at runtime.
I thought and realized now a more systematic approach
to do that with a pure virtual function at the Item
itself. That can also be secured by a clang compiler
plugin in the future to keep it working. It uses one
virtual function per derived class, no longer space
in incarnated Items. Also the constructors will get
more simple again.
But the main aspect is security - we cannot afford
Items potentially being held as equal if they are not.
Unfortunately C++ does not offer something like a
'strict pure virtual function' that would force to
be overloaded in every derivation, but the used
methotology and adding a clang test is reasonably
safe.
Have now done the cleanup of previous method.
Change-Id: I04768285f1e9b73d64b0bb87df401944b5d35678
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180017
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
|
|
Change-Id: I9ba49ff8df463519631e698ce5916f0126c5d7b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178934
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I92f57f9ea8a0ea109fbec9e18665adeb3c6d2837
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178931
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I5190155eb0edb4639b09983cc58101a5a8c82f31
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178929
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: Id86edc48c304d2ab35a5cb01a20d9dac20e04280
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178926
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: Ia653759378913758f0b2750c9d072b76523fa034
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178924
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: Iaca646e1a36b20adb29b5ff25649d08fc7055e24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178951
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: Ibe57036e31c704b8866de49934a58b0fa6c47496
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178935
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
SwGridConfig ConfigItem didn't listen to the config changes.
Note that after this, while toggling e.g. VisibleGrid on/off in expert
settings doesn't initially appear to do a whole pile, it does affect
newly created documents, while before this change it does not.
Existing documents don't update to use that config. Toggling this
on/off via the explicit Show Grid ends up in
SwModule::ApplyUsrPref(const SwViewOption &rUsrPref, SwView* pActView)
with something of a bodge to determine the current SwView in order
to affect the document the setting dialog is launched from, which
is why it changes the current document, and new documents, but not
any other open documents.
Change-Id: Ic57e89e3aa9765ad3c4374ddf02ed718382cf518
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177349
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
so this one doesn't need another explicit Load called
Change-Id: If1ff686655a90ed81be97bf0821518b2e82bdd57
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177369
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
* Boundary toggles removed from app colors
* Object boundaries completely removed (color replaced with
DOCBOUNDARIES; Impress placeholder on/off now an expert option)
* Toggle options added under formatting aids
* Individual UNO commands marked deprecated
* New command added to show all boundaries
* Frames follow sections now in state and color
* Kind of wrapping doesn't matter anmymore
Change-Id: I7bbec20831dcb95abef6523884d84b05a1a7df0a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176242
Tested-by: Jenkins
Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
|
|
we can just take a "const &".
(found by running clang-tidy with the
performance-unnecessary-copy-initialization warning)
Change-Id: I20fd208c65303da78170b1ac06c638fdf3aa094b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176267
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
* Default is Crop Marks now
* Settings are persistent
Change-Id: If5304c874706345fa943a106044155152c86bc0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176131
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
New option introduced under Formatting Aids to switch between full
and crop marks, which was done before via NPC
Change-Id: I920f68b571da740e47ae367ba1e8d28e03a131e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175828
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
since:
commit 4855bbfa4d0cbc6376ab2a40151886f84fafac40
CommitDate: Tue Sep 17 03:44:46 2024 +0200
tdf#132274 add zoom defaults to Writer options
Change-Id: Ie7dae9add87fe14c87b53d9b86d77a84ce0c2a7a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173587
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Zoom value is sometimes stored at documents. But users
might prefer local zoom settings over stored values.
Users are now able to set preferred values in Writer's
option dialog.
Change-Id: Ia1c3926aac3dd236f15f84d8dc535d8aa3758238
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171482
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
/<<PKGBUILDDIR>>/sw/source/uibase/config/usrpref.cxx: In member function ‘com::sun::star::uno::Sequence<rtl::OUString> SwContentViewConfig::GetPropertyNames() const’:
/<<PKGBUILDDIR>>/sw/source/uibase/config/usrpref.cxx:120:24: error: ‘strcmp’ is not a member of ‘std’; did you mean ‘strcmp’?
120 | static_assert(std::strcmp("Update/Link", aPropNames[g_UpdateLinkIndex]) == 0);
| ^~~~~~
In file included from /<<PKGBUILDDIR>>/include/rtl/string.hxx:36,
from /<<PKGBUILDDIR>>/include/rtl/ustring.hxx:45,
from /<<PKGBUILDDIR>>/include/com/sun/star/uno/Any.h:30,
from /<<PKGBUILDDIR>>/include/com/sun/star/uno/Any.hxx:35,
from /<<PKGBUILDDIR>>/include/o3tl/any.hxx:21,
from /<<PKGBUILDDIR>>/sw/source/uibase/config/usrpref.cxx:23:
/usr/include/string.h:156:12: note: ‘strcmp’ declared here
156 | extern int strcmp (const char *__s1, const char *__s2)
| ^~~~~~
/<<PKGBUILDDIR>>/sw/source/uibase/config/usrpref.cxx:121:24: error: ‘strcmp’ is not a member of ‘std’; did you mean ‘strcmp’?
121 | static_assert(std::strcmp("Display/DefaultAnchor", aPropNames[g_DefaultAnchor]) == 0);
| ^~~~~~
/usr/include/string.h:156:12: note: ‘strcmp’ declared here
156 | extern int strcmp (const char *__s1, const char *__s2)
| ^~~~~~
make[2]: *** [/<<PKGBUILDDIR>>/solenv/gbuild/LinkTarget.mk:338: /<<PKGBUILDDIR>>/workdir/CxxObject/sw/source/uibase/config/usrpref.o] Error 1
Change-Id: Ie6c89500c554e0027d9b14c082baca519a454c10
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172860
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit f20592f7baf1b07f1b60c1625e69cee6e2e9be88)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172891
|
|
Change-Id: I82783a49d3a1c2096dcfa7c97a3fce14c555c988
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171814
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Change-Id: I7aa8ed716998a185996482dc561219b398a1c919
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169080
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
The SfxPoolItem has a new member SfxItemType m_eItemType to
compare types based on enums instead of typeinfo() which
consumes a lot of time e.g. while AutoFormat is running
Change-Id: I033ce67bc9a28ee4790f162380314de85fb4154e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166452
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
|
|
Change-Id: I4f4284b55d481caa006743688e6d83cc3c713b5c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168601
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I9179b55eb27f1bf2f28c2c86f1e67f2a4daf4819
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168341
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: Id1a6f3babc1ca63375361c88b8af40d9915d1d2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167112
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I9c40c4e4f58d45e5c3195cab6dbb40c47b0326d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167113
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ib0a72355972662c6b902bca9a527be91fb3e1d17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164930
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This patch implements a new setting in Tools -> Options -> Writer ->
Formatting Aids -> Autocomplete -> Enclose with characters.
When this option is enabled (default), selected text is enclosed
with parentheses, square brackets, curly braces or quotation marks,
depending on which character is pressed.
For example, if the selected text is "abcd", the option is enabled and
the button for the character '(' is hit, the text is replaced with
"(abcd)".
Change-Id: Ibc5b7be3cc96f00217dd068971e7c07e68439700
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162583
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
|
|
and add a counter-reason test.
When we have multiple views of a document, whether in LOKit or in
desktop via "Window, New Window" then we have just one layout and render
that layout in each view. So with default settings: View, Formatting
Marks, we can correctly render the Pilcows in one view but not in the
another even though we share a single layout.
If "Show Hidden Characters" is enabled, then when "view formatting" is
also enabled then hidden characters are shown when view formatting is
enabled, and not when it is disabled.
But if "show hidden characters" are enabled, then if formatting marks
are enabled in one view and and not another then the hidden characters
will be either shown in both views or hidden in both views, depending on
whether the shared layout is done with "show/hide hidden characters". So
we currently can't show/hide the hidden characters per-view.
revert:
commit 7a6b80995f69304149e0ab7a8e1fa92a15b20d07
Date: Wed Oct 4 10:04:42 2023 -0400
LOKit: always display hidden chars when showing formatting marks
This arises from noting that in kit then on turning on formatting marks
in one view, then the other view rendering options changed, which isn't
wanted. But on attempting to keep the other ViewShell settings
unaffected it turns out to be futile given the shared layout.
Change-Id: I210b86fae84bc8137af415cb9c93dacdeab7d448
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162579
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Justin Luth <jluth@mail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit 5234435a552d3d4cc421ba5c8600d8215f9f8f4b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162549
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Because that influences the layout, and sometimes it's far from trivial
that it gets disabled, e.g. during printing/PDF export.
Change-Id: Icb6accf3cb8bacd02f7267d55fbf56a4b10550bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162591
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
no change intended here
Change-Id: I67e7279d27e9cea31c9c26d1775f8dd28bd74e48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162561
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I1da86b0be73713b506044c969930912b58b4d514
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161435
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
and try something a bit more generic
Change-Id: I1d8256576cd02f0a589df350ba7b53059dd586a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161250
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
just use the wrapped officecfg methods instead of:
GetIsAllowAnimatedGraphics
GetIsAllowAnimatedText
GetIsAutomaticFontColor
IsSelectionInReadonly
Change-Id: I74de75fc9ff2f9a36ef376255e937bb373055587
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161236
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
|
|
Change-Id: I8b4597dbafc78e881fe556de8ce8221e50a673bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160777
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
Change-Id: I95f81f166ab9d75622c83672101925894b2f2e7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160774
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
"for now it was decided that tables should always be printed"
-> make this decision from 2015 permanent
Change-Id: Ica5958a74ec6766040ab59f2c91224b75df4d807
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160766
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
This is handled by the print dialog directly
Change-Id: Ieb4221d97444216f332501da9a3aba7dc6b8500a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160762
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
since:
commit 8bf614179f5664d7cdd49db41ef462073cc8608d
Date: Thu Nov 9 16:00:10 2023 +0100
tdf#135266 - Remember last used entry level depending on the index type
Change-Id: I298e7afa59874c0718b42de622b817d201d986e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159436
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I4fe9342c28fc9135b73286e67464b16a1d910a9f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159217
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
|
|
Change-Id: I49d2d1a00928c4cea68164e8c91fd9a6bb4b3b94
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150875
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I85fff7ed6932c5fc196e18f24fa01074ba4837e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158241
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
This is related to the request in tdf#107658 to do the same for core.
However, this is something fairly easily doable with an extension
in core, so I'm not in favour of forcing one user's opinion over top
of status quo.
Doing this only for Online.
make CppunitTest_sw_tiledrendering \
CPPUNIT_TEST_NAME=testShowHiddenCharsWhenShowFormatting
Change-Id: I34bbe50dd4bbff92577b18f8a05d2f8dd67ea771
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157562
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I6dc6c3fdf1924e0cd012dab1ece0adbb0c405335
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157354
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
... accidentally broken by commit 4ed26badfd6fd9190cb6e54078b41eb38cb37dca.
Change-Id: I407e1eab47277dd8fa00c123b32596557fd5f2a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154032
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Korean word processors(HWP & MS Word) default font size is 10pt.
So, I set to 10pt on LibreOffice Writer.
Change-Id: Ic31332e37b3b450589ded6df243aae6961fdf394
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153324
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Change-Id: I8d3402a69237b665462e04440ad73fe29e2133db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153807
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ia530086fe35e64379e55135d392020304b466325
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152649
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This reverts commit 5e68d6cfade45f40b1ad46025a81afe4cb8dd337.
Reason for revert: Seems like outside users have been using this API
Change-Id: I8814cf1eb4f000eeb4cbbb5db9c282d001465993
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152441
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
There is no need for it to be an UNO interface anymore (ever since
we started supporting dynamic_cast on UNO objects).
Which means that XImportFilter2 also needs become a C++ interface.
Change-Id: Ice2db0f098271bba32b199bd083b08cb8410ce93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152388
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
as in initializeForTiledRendering we don't want field shadings
Change-Id: Ie1ea2c365bcd78cdfd554646474c4ef05a19fcda
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152425
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
make this actually do nothing to test a point
Change-Id: I353dc2bbbcd9229518f6527fe1589a901a9adfd1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151833
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|