summaryrefslogtreecommitdiff
path: root/sw/source/uibase/utlui
AgeCommit message (Collapse)Author
7 dayscid#1615138 Use of auto that causes a copyCaolán McNamara
Change-Id: I5752fa3aa4bd67401194dc88aa8bf7b8d8e485c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171055 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
10 daysrelated tdf#160817 SwNavigator: update content functions toolbarJim Raykowski
on right-click selection of entry to show context menu for Change-Id: I045bd02103a37c94d6eb3fc1885ab19de79685c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170885 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
11 daysno need to dynamic_cast when using GetItemSurrogatesNoel Grandin
since the items returned are guaranteed to be of the right type Change-Id: I7912c0ec171b4617a7ac393786f553a1f0b6c78e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170836 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
11 dayscid#1608424 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1607592 COPY_INSTEAD_OF_MOVE cid#1607487 COPY_INSTEAD_OF_MOVE cid#1607480 COPY_INSTEAD_OF_MOVE cid#1607444 COPY_INSTEAD_OF_MOVE cid#1607369 COPY_INSTEAD_OF_MOVE cid#1607356 COPY_INSTEAD_OF_MOVE cid#1607342 COPY_INSTEAD_OF_MOVE cid#1607329 COPY_INSTEAD_OF_MOVE cid#1607327 COPY_INSTEAD_OF_MOVE cid#1607303 COPY_INSTEAD_OF_MOVE cid#1607284 COPY_INSTEAD_OF_MOVE Change-Id: Ia2d5d4e2de8ca96a9557df5266754e52efa4f60e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170826 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
13 dayscid#1607830 Use of auto that causes a copyCaolán McNamara
and cid#1607722 Use of auto that causes a copy cid#1557606 Use of auto that causes a copy cid#1557569 Use of auto that causes a copy cid#1556239 Use of auto that causes a copy cid#1556043 Use of auto that causes a copy cid#1554961 Use of auto that causes a copy cid#1554818 Use of auto that causes a copy Change-Id: I9f74c7bc4da2c6b1df80d0fb4504dd4d03eb1053 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170784 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-01tdf#160817 SwNavigator expose main functions for selected entryJim Raykowski
Replaces the headings/outline move action buttons in the tools area with a toolbar to expose the main functions for the selected entry in the content tree. Change-Id: Iedb5b53375088a159d640fb986bfcf9376fa2072 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168174 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-07-01SwNavigator: Add a function to delete all content of a content typeJim Raykowski
and use it to delete all footnote/endnote content Done in preparation of following patches that provide the ability to delete all content of a content type. Change-Id: Ie329e60033ea10e936049d70c4654f4c6473e55e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168173 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-06-18loplugin:ostr in variousNoel Grandin
Change-Id: I7aa8ed716998a185996482dc561219b398a1c919 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169080 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-18Add SfxItemType to SfxPoolItemOliver Specht
The SfxPoolItem has a new member SfxItemType m_eItemType to compare types based on enums instead of typeinfo() which consumes a lot of time e.g. while AutoFormat is running Change-Id: I033ce67bc9a28ee4790f162380314de85fb4154e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166452 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-06-14tdf#147864 Replace 'Show All' and 'Hide All' in the Comments categorySujatro Bhadra
context menu of Writer Navigator with togglable commands 'Show Comments' and 'Show Resolved Comments' Change-Id: I7ac00c5366327f8d245ca49595eca2fd1fac472c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166539 Reviewed-by: Jim Raykowski <raykowj@gmail.com> Tested-by: Jenkins
2024-06-13Let LinkManager::UpdateAllLinks honor isUntrustedRefererStephan Bergmann
Change-Id: I3714061376afaf1186e4f7cfe5b28bfb54aa7a99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168789 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-06-06loplugin:ostr in sw/../utluiNoel Grandin
Change-Id: I542c3ab519f1b154e606943e867794127ec279c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168488 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-31tdf#160984 sw continuous endnotes: hide not functional UI in this modeMiklos Vajna
Previous commits bug have fixed cases where opening a Word document rendered a different foot/endnote separator than expected for Word. The followings were modified: - distance between body text and separator, between separator and first note - the vertical position of the line - the length of the line Now ODT files keep the original feature set and Word files look as expected, but a couple of UI controls are ignored by the layout, hide these as they intentionally don't do anything while we're in Word compat mode. Change-Id: I72a3dde637d3e224038886a79550fa069253a4f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168295 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-05-30GetMarkedObjectByIndex -> GetMarkedObjectList().GetMark()->GetMarkedSdrObj()Xisco Fauli
In order to reduce number of calls to GetMarkedObjectList() later on Change-Id: I57ab7d2d8edd98da5175bd1066dfab0fa2cc888e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168220 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-30SwNavigator: simplify table deleteJim Raykowski
Change-Id: Ic26712972e3465eba10dbaba9cfce20365c5644a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168172 Reviewed-by: Jim Raykowski <raykowj@gmail.com> Tested-by: Jenkins
2024-05-29GetMarkedObjectCount() -> GetMarkedObjectList().GetMarkCount()Xisco Fauli
In order to reduce number of calls to GetMarkedObjectList() later on Change-Id: Id94f66545950f0fdf124ba7b985a5215a01d63fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168213 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-28no need to dynamic_cast hereNoel Grandin
Change-Id: Ib2e08e58fc2f09161eda0cd32bf7ba2704387070 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168124 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-28SwNavigator: Improve Indexes context menuJim Raykowski
* Removes "Remove Index" menu item in favor of the repeated function "Delete index" menu item. * Hides the "Update", "Delete Index", and "Rename..." menu items when the document or index is set read-only. Change-Id: Ie907c33e2fe991ba6c02ad987193db481f375116 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167913 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-05-23sw: warning C6011: Dereferencing NULL pointerXisco Fauli
Change-Id: I612ec139354345f48fb5d3b41bdb10c37ad85ff7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167983 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-05-23sw: warning C6011: Dereferencing NULL pointerXisco Fauli
Change-Id: Ia4b7f98525e07c5a58b752d7e68d89705f87ac9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167969 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-10sw: Navigator: don't show virtual drawing objectsMichael Stahl
These can return a non-empty name now, so exclude them explicitly. (regression from commit ae132145ff42a95dc24fb124847c04af4b8c8dab) Change-Id: Ia7f7b9fd7abe67f3302e95b38e3b9fa30b769b5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167349 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2024-05-09WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: I37166c03ffd0f8f76ddc03ce556b6e6341a02b48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167355 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-07tdf#160598 follow up to make delete key workJim Raykowski
Adds delete key handling for delete all footnotes/endnotes from the Navigator. Change-Id: Ic1d49377631344ac5e6fdc81c07eebde0470a6be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167180 Reviewed-by: Jim Raykowski <raykowj@gmail.com> Tested-by: Jenkins
2024-05-04tdf#160657 Improve Writer Navigator Headings displayJim Raykowski
when alphabetically sorted Make the Headings content display flat (no parent-child hierarchy, no outline-level indentation) when set to alphabetical sort order. Change-Id: I0d215c76462fdc2ff1fafcfd8b8d5b15be17b405 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166068 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-05-04SwNavigator: improve when outline move controls/menu-items areJim Raykowski
active/visible Makes the outline content context menu not show the up/down/promote/ demote menu items when outline content is set to display by alphabetical sort. With intent to improve code readablility, reworks the SwContentTree::Select function used to set the sensitive state of the up/down/promote/demote buttons. The buttons are disabled for any of the following conditions; the Navigator is in "Zoom" mode, the document is in read-only mode, the selected entry is not an outline content entry, or the outline content is displayed by alphabetical sort. The patch also makes the alphabetical sort setting independent among the floating and sidebar versions. Change-Id: I6ff8fab2ce2fb6f68163ed3860b0440fba875fb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166067 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-04-29sw: fixed crash on GetCreateView() returning nullptrVasily Melenchuk
Change-Id: Id0cb44ac7d805a1736fa8170aaffb97b54211707 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166617 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2024-04-25Fix typoAndrea Gelmini
Change-Id: I8ab3728b0b5cf414582849e9efe36a3c9df43f45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166646 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2024-04-25tdf#160598 SwNavigator enhancement to delete footnotes/endnotesJim Raykowski
m_bDocHasChanged is checked first in the tooltip and mouse move handlers to prevent crashes/asserts that happen when SfxPoolItemHolder m_aAttr references a delete poolitem or poolitem data. Without this check the following types of crashes/asserts can happen: ---- Unspecified Application Error Fatal exception: Signal 6 Stack: 0 sal::backtrace_get(unsigned int) at /home/lo/Dev/LO1/core/sal/osl/ unx/backtraceapi.cxx:42 (discriminator 3) 1 (anonymous namespace)::printStack(int) at /home/lo/Dev/LO1/core/sal/ osl/unx/signal.cxx:289 2 (anonymous namespace)::callSystemHandler(int, siginfo_t*, void*) at / home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:330 3 (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*) at /home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:427 4 __restore_rt at libc_sigaction.c:? 5 __pthread_kill_implementation at ./nptl/pthread_kill.c:44 6 __GI_raise at ./signal/../sysdeps/posix/raise.c:27 7 __GI_abort at ./stdlib/abort.c:81 (discriminator 21) 8 SalAbort(rtl::OUString const&, bool) at /home/lo/Dev/LO1/core/vcl/ source/app/salplug.cxx:412 9 Application::Abort(rtl::OUString const&) at /home/lo/Dev/LO1/core/ vcl/source/app/svapp.cxx:316 10 desktop::Desktop::Exception(ExceptionCategory) at /home/lo/Dev/LO1/ core/desktop/source/app/app.cxx:1203 (discriminator 2) 11 VCLExceptionSignal_impl(void*, oslSignalInfo*) at /home/lo/Dev/LO1/ core/vcl/source/app/svmain.cxx:176 12 callSignalHandler(oslSignalInfo*) at /home/lo/Dev/LO1/core/sal/osl/ all/signalshared.cxx:47 13 (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*) at /home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:423 14 __restore_rt at libc_sigaction.c:? 15 SfxPoolItem::Which() const at /home/lo/Dev/LO1/core/include/svl/ poolitem.hxx:225 16 SfxPoolItemHolder::Which() const at /home/lo/Dev/LO1/core/include/ svl/itemset.hxx:74 (discriminator 1) 17 SwTextAttr::GetFootnote() const at /home/lo/Dev/LO1/core/sw/inc/ txatbase.hxx:223 (discriminator 1) 18 SwContentTree::QueryTooltipHdl(weld::TreeIter const&) at /home/lo/ Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4974 19 SwContentTree::LinkStubQueryTooltipHdl(void*, weld::TreeIter const&) at /home/lo/Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4895 20 Link<weld::TreeIter const&, rtl::OUString>::Call(weld::TreeIter const&) const at /home/lo/Dev/LO1/core/include/tools/link.hxx:111 21 weld::TreeView::signal_query_tooltip(weld::TreeIter const&) at / home/lo/Dev/LO1/core/include/vcl/weld.hxx:977 22 SalInstanceTreeView::TooltipHdl(SvTreeListEntry*) at /home/lo/Dev/ LO1/core/vcl/source/app/salvtables.cxx:5154 23 SalInstanceTreeView::LinkStubTooltipHdl(void*, SvTreeListEntry*) at /home/lo/Dev/LO1/core/vcl/source/app/salvtables.cxx:5151 24 Link<SvTreeListEntry*, rtl::OUString>::Call(SvTreeListEntry*) const at /home/lo/Dev/LO1/core/include/tools/link.hxx:111 25 SvTreeListBox::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/ core/vcl/source/treelist/treelistbox.cxx:3284 26 ImplHandleMouseHelpRequest(vcl::Window*, Point const&) at /home/lo/ Dev/LO1/core/vcl/source/window/winproc.cxx:186 27 ImplHandleMouseEvent(VclPtr<vcl::Window> const&, NotifyEventType, bool, long, long, unsigned long, unsigned short, MouseEventModifiers) at /home/lo/Dev/LO1/core/vcl/source/window/winproc.cxx:740 28 ImplHandleSalMouseMove(vcl::Window*, SalMouseEvent const*) at /home/ lo/Dev/LO1/core/vcl/source/window/winproc.cxx:2332 29 ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) at /home/ lo/Dev/LO1/core/vcl/source/window/winproc.cxx:2665 (discriminator 1) 30 SalFrame::CallCallback(SalEvent, void const*) const at /home/lo/Dev/ LO1/core/vcl/inc/salframe.hxx:312 (discriminator 1) 31 QtFrame::CallCallback(SalEvent, void const*) const at /home/lo/Dev/ LO1/core/vcl/inc/qt5/QtFrame.hxx:228 32 QtWidget::mouseMoveEvent(QMouseEvent*) at /home/lo/Dev/LO1/core/vcl/ qt5/QtWidget.cxx:202 33 QWidget::event(QEvent*) in /lib/x86_64-linux-gnu/libQt5Widgets.so.5 34 QtWidget::event(QEvent*) at /home/lo/Dev/LO1/core/vcl/qt5/ QtWidget.cxx:738 (discriminator 2) 35 QApplicationPrivate::notify_helper(QObject*, QEvent*) in /lib/ x86_64-linux-gnu/libQt5Widgets.so.5 36 QApplication::notify(QObject*, QEvent*) in /lib/x86_64-linux-gnu/ libQt5Widgets.so.5 37 QCoreApplication::notifyInternal2(QObject*, QEvent*) in /lib/x86_64- linux-gnu/libQt5Core.so.5 38 QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool, bool) in /lib/ x86_64-linux-gnu/libQt5Widgets.so.5 39 QDesktopWidget::qt_metacall(QMetaObject::Call, int, void**) in /lib/ x86_64-linux-gnu/libQt5Widgets.so.5 40 QDesktopWidget::qt_metacall(QMetaObject::Call, int, void**) in /lib/ x86_64-linux-gnu/libQt5Widgets.so.5 41 QApplicationPrivate::notify_helper(QObject*, QEvent*) in /lib/ x86_64-linux-gnu/libQt5Widgets.so.5 42 QCoreApplication::notifyInternal2(QObject*, QEvent*) in /lib/x86_64- linux-gnu/libQt5Core.so.5 43 QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) in /lib/x86_64-linux-gnu/libQt5Gui.so.5 44 QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) in /lib/x86_64-linux-gnu/libQt5Gui.so.5 45 QXcbNativeInterface::dumpNativeWindows(unsigned long long) const in /lib/x86_64-linux-gnu/libQt5XcbQpa.so.5 46 g_main_context_dispatch in /lib/x86_64-linux-gnu/libglib-2.0.so.0 48 g_main_context_iteration in /lib/x86_64-linux-gnu/libglib-2.0.so.0 49 QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) in /lib/x86_64-linux-gnu/libQt5Core.so.5 50 QtInstance::ImplYield(bool, bool) at /home/lo/Dev/LO1/core/vcl/qt5/ QtInstance.cxx:453 51 QtInstance::DoYield(bool, bool) at /home/lo/Dev/LO1/core/vcl/qt5/ QtInstance.cxx:464 52 ImplYield(bool, bool) at /home/lo/Dev/LO1/core/vcl/source/app/ svapp.cxx:395 53 Application::Yield() at /home/lo/Dev/LO1/core/vcl/source/app/ svapp.cxx:483 54 Application::Execute() at /home/lo/Dev/LO1/core/vcl/source/app/ svapp.cxx:370 55 desktop::Desktop::Main() at /home/lo/Dev/LO1/core/desktop/source/ app/app.cxx:1617 56 ImplSVMain() at /home/lo/Dev/LO1/core/vcl/source/app/svmain.cxx:229 57 SVMain() at /home/lo/Dev/LO1/core/vcl/source/app/svmain.cxx:262 58 soffice_main at /home/lo/Dev/LO1/core/desktop/source/app/ sofficemain.cxx:93 59 sal_main at /home/lo/Dev/LO1/core/desktop/source/app/main.c:51 60 main at /home/lo/Dev/LO1/core/desktop/source/app/main.c:49 61 __libc_start_call_main at ./csu/../sysdeps/nptl/ libc_start_call_main.h:58 62 call_init at ./csu/../csu/libc-start.c:128 63 _start in /home/lo/Dev/LO1/core/instdir/program/soffice.bin ---- soffice.bin: /home/lo/Dev/LO1/core/sw/inc/txatbase.hxx:223: const SwFormatFootnote& SwTextAttr::GetFootnote() const: Assertion `m_aAttr && m_aAttr.Which() == RES_TXTATR_FTN' failed. Fatal exception: Signal 6 Stack: 0 sal::backtrace_get(unsigned int) at /home/lo/Dev/LO1/core/sal/osl/ unx/backtraceapi.cxx:42 (discriminator 3) 1 (anonymous namespace)::printStack(int) at /home/lo/Dev/LO1/core/sal/ osl/unx/signal.cxx:289 2 (anonymous namespace)::callSystemHandler(int, siginfo_t*, void*) at / home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:330 3 (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*) at /home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:427 4 __restore_rt at libc_sigaction.c:? 5 __pthread_kill_implementation at ./nptl/pthread_kill.c:44 6 __GI_raise at ./signal/../sysdeps/posix/raise.c:27 7 __GI_abort at ./stdlib/abort.c:81 (discriminator 21) 8 _nl_load_domain at ./intl/loadmsgcat.c:1177 9 __GI___assert_fail at :? 10 SwTextAttr::GetFootnote() const at /home/lo/Dev/LO1/core/sw/inc/ txatbase.hxx:224 11 SwContentTree::QueryTooltipHdl(weld::TreeIter const&) at /home/lo/ Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4974 12 SwContentTree::LinkStubQueryTooltipHdl(void*, weld::TreeIter const&) at /home/lo/Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4895 13 Link<weld::TreeIter const&, rtl::OUString>::Call(weld::TreeIter const&) const at /home/lo/Dev/LO1/core/include/tools/link.hxx:111 14 weld::TreeView::signal_query_tooltip(weld::TreeIter const&) at / home/lo/Dev/LO1/core/include/vcl/weld.hxx:977 15 (anonymous namespace)::GtkInstanceTreeView::signalQueryTooltip(_GtkWidget*, int, int, int, _GtkTooltip*, void*) at /home/lo/Dev/LO1/core/vcl/unx/gtk3/ gtkinst.cxx:14701 (discriminator 2) 16 gtk_socket_add_id in /lib/x86_64-linux-gnu/libgtk-3.so.0 17 g_closure_invoke in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 18 g_signal_handlers_destroy in /lib/x86_64-linux-gnu/ libgobject-2.0.so.0 19 g_signal_emit_valist in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 20 g_signal_emit in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 21 gtk_tooltip_set_icon_from_gicon in /lib/x86_64-linux-gnu/ libgtk-3.so.0 22 gtk_tooltip_set_icon_from_gicon in /lib/x86_64-linux-gnu/ libgtk-3.so.0 23 gtk_main_do_event in /lib/x86_64-linux-gnu/libgtk-3.so.0 24 gdk_drawing_context_get_clip in /lib/x86_64-linux-gnu/libgdk-3.so.0 25 gdk_x11_drag_context_get_type in /lib/x86_64-linux-gnu/libgdk-3.so.0 26 g_main_context_dispatch in /lib/x86_64-linux-gnu/libglib-2.0.so.0 27 g_io_channel_new_file in /lib/x86_64-linux-gnu/libglib-2.0.so.0 28 g_main_loop_run in /lib/x86_64-linux-gnu/libglib-2.0.so.0 29 main_loop_run(_GMainLoop*) at /home/lo/Dev/LO1/core/vcl/inc/unx/gtk/ gtkdata.hxx:63 30 (anonymous namespace)::DialogRunner::run() at /home/lo/Dev/LO1/core/ vcl/unx/gtk3/gtkinst.cxx:6747 (discriminator 13) 31 (anonymous namespace)::GtkInstanceDialog::run() at /home/lo/Dev/LO1/ core/vcl/unx/gtk3/gtkinst.cxx:10046 32 weld::DialogController::run() at /home/lo/Dev/LO1/core/include/vcl/ weld.hxx:2669 33 (anonymous namespace)::RecoveryUI::impl_doEmergencySave() at /home/ lo/Dev/LO1/core/svx/source/unodraw/recoveryui.cxx:258 (discriminator 1) 34 (anonymous namespace)::RecoveryUI::dispatchWithReturnValue(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at /home/lo/Dev/LO1/core/svx/source/unodraw/recoveryui.cxx:148 35 desktop::(anonymous namespace)::impl_callRecoveryUI(bool, bool) at / home/lo/Dev/LO1/core/desktop/source/app/app.cxx:1022 (discriminator 5) 36 desktop::Desktop::Exception(ExceptionCategory) at /home/lo/Dev/LO1/ core/desktop/source/app/app.cxx:1177 37 VCLExceptionSignal_impl(void*, oslSignalInfo*) at /home/lo/Dev/LO1/ core/vcl/source/app/svmain.cxx:176 38 callSignalHandler(oslSignalInfo*) at /home/lo/Dev/LO1/core/sal/osl/ all/signalshared.cxx:47 39 (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*) at /home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:423 40 __restore_rt at libc_sigaction.c:? 41 SfxPoolItem::Which() const at /home/lo/Dev/LO1/core/include/svl/ poolitem.hxx:225 42 SfxPoolItemHolder::Which() const at /home/lo/Dev/LO1/core/include/ svl/itemset.hxx:74 (discriminator 1) 43 SwTextAttr::GetFootnote() const at /home/lo/Dev/LO1/core/sw/inc/ txatbase.hxx:223 (discriminator 1) 44 SwContentTree::QueryTooltipHdl(weld::TreeIter const&) at /home/lo/ Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4974 45 SwContentTree::LinkStubQueryTooltipHdl(void*, weld::TreeIter const&) at /home/lo/Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4895 46 Link<weld::TreeIter const&, rtl::OUString>::Call(weld::TreeIter const&) const at /home/lo/Dev/LO1/core/include/tools/link.hxx:111 47 weld::TreeView::signal_query_tooltip(weld::TreeIter const&) at / home/lo/Dev/LO1/core/include/vcl/weld.hxx:977 48 (anonymous namespace)::GtkInstanceTreeView::signalQueryTooltip(_GtkWidget*, int, int, int, _GtkTooltip*, void*) at /home/lo/Dev/LO1/core/vcl/unx/gtk3/ gtkinst.cxx:14701 (discriminator 2) 49 gtk_socket_add_id in /lib/x86_64-linux-gnu/libgtk-3.so.0 50 g_closure_invoke in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 51 g_signal_handlers_destroy in /lib/x86_64-linux-gnu/ libgobject-2.0.so.0 52 g_signal_emit_valist in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 53 g_signal_emit in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 54 gtk_tooltip_set_icon_from_gicon in /lib/x86_64-linux-gnu/ libgtk-3.so.0 55 gtk_tooltip_set_icon_from_gicon in /lib/x86_64-linux-gnu/ libgtk-3.so.0 56 gtk_tooltip_trigger_tooltip_query in /lib/x86_64-linux-gnu/ libgtk-3.so.0 57 GtkSalFrame::ShowTooltip(rtl::OUString const&, tools::Rectangle const&) at /home/lo/Dev/LO1/core/vcl/unx/gtk3/gtkframe.cxx:3154 58 ImplShowHelpWindow(vcl::Window*, unsigned short, QuickHelpFlags, rtl::OUString const&, Point const&, tools::Rectangle const&) at /home/ lo/Dev/LO1/core/vcl/source/app/help.cxx:492 59 Help::ShowQuickHelp(vcl::Window*, tools::Rectangle const&, rtl::OUString const&, QuickHelpFlags) at /home/lo/Dev/LO1/core/vcl/ source/app/help.cxx:191 (discriminator 5) 60 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 61 ImplBorderWindow::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/ core/vcl/source/window/brdwin.cxx:1673 62 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 63 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 64 ImplBorderWindow::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/ core/vcl/source/window/brdwin.cxx:1673 65 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 66 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 67 SplitWindow::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/splitwin.cxx:2117 68 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 69 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 70 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 71 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 72 ImplHandleMouseHelpRequest(vcl::Window*, Point const&) at /home/lo/ Dev/LO1/core/vcl/source/window/winproc.cxx:186 73 ImplHandleMouseEvent(VclPtr<vcl::Window> const&, NotifyEventType, bool, long, long, unsigned long, unsigned short, MouseEventModifiers) at /home/lo/Dev/LO1/core/vcl/source/window/winproc.cxx:740 74 ImplHandleSalMouseMove(vcl::Window*, SalMouseEvent const*) at /home/ lo/Dev/LO1/core/vcl/source/window/winproc.cxx:2332 75 ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) at /home/ lo/Dev/LO1/core/vcl/source/window/winproc.cxx:2665 (discriminator 1) 76 SalFrame::CallCallback(SalEvent, void const*) const at /home/lo/Dev/ LO1/core/vcl/inc/salframe.hxx:312 (discriminator 1) 77 GtkSalFrame::CallCallbackExc(SalEvent, void const*) const at /home/ lo/Dev/LO1/core/vcl/unx/gtk3/gtkframe.cxx:6388 78 GtkSalFrame::DrawingAreaMotion(int, int, unsigned int, unsigned int) at /home/lo/Dev/LO1/core/vcl/unx/gtk3/gtkframe.cxx:3719 79 GtkSalFrame::signalMotion(_GtkWidget*, _GdkEventMotion*, void*) at / home/lo/Dev/LO1/core/vcl/unx/gtk3/gtkframe.cxx:3756 80 gtk_socket_add_id in /lib/x86_64-linux-gnu/libgtk-3.so.0 81 g_closure_invoke in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 82 g_signal_handlers_destroy in /lib/x86_64-linux-gnu/ libgobject-2.0.so.0 83 g_signal_emit_valist in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 84 g_signal_emit in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 85 gtk_widget_init_template in /lib/x86_64-linux-gnu/libgtk-3.so.0 86 gtk_grab_remove in /lib/x86_64-linux-gnu/libgtk-3.so.0 87 gtk_main_do_event in /lib/x86_64-linux-gnu/libgtk-3.so.0 88 gdk_drawing_context_get_clip in /lib/x86_64-linux-gnu/libgdk-3.so.0 89 gdk_x11_drag_context_get_type in /lib/x86_64-linux-gnu/libgdk-3.so.0 90 g_main_context_dispatch in /lib/x86_64-linux-gnu/libglib-2.0.so.0 91 g_io_channel_new_file in /lib/x86_64-linux-gnu/libglib-2.0.so.0 92 g_main_context_iteration in /lib/x86_64-linux-gnu/libglib-2.0.so.0 93 GtkSalData::Yield(bool, bool) at /home/lo/Dev/LO1/core/vcl/unx/gtk3/ gtkdata.cxx:405 (discriminator 6) 94 GtkInstance::DoYield(bool, bool) at /home/lo/Dev/LO1/core/vcl/unx/ gtk3/gtkinst.cxx:436 95 ImplYield(bool, bool) at /home/lo/Dev/LO1/core/vcl/source/app/ svapp.cxx:395 96 Application::Yield() at /home/lo/Dev/LO1/core/vcl/source/app/ svapp.cxx:483 97 Application::Execute() at /home/lo/Dev/LO1/core/vcl/source/app/ svapp.cxx:370 98 desktop::Desktop::Main() at /home/lo/Dev/LO1/core/desktop/source/ app/app.cxx:1617 99 ImplSVMain() at /home/lo/Dev/LO1/core/vcl/source/app/svmain.cxx:229 100 SVMain() at /home/lo/Dev/LO1/core/vcl/source/app/svmain.cxx:262 101 soffice_main at /home/lo/Dev/LO1/core/desktop/source/app/ sofficemain.cxx:93 102 sal_main at /home/lo/Dev/LO1/core/desktop/source/app/main.c:51 103 main at /home/lo/Dev/LO1/core/desktop/source/app/main.c:49 104 __libc_start_call_main at ./csu/../sysdeps/nptl/ libc_start_call_main.h:58 105 call_init at ./csu/../csu/libc-start.c:128 106 _start in /home/lo/Dev/LO1/core/instdir/program/soffice.bin Change-Id: Id2bad55221a8603a1e12f870bdc1479e7709ee58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166414 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-04-24SwContentTree: Don't show 'Delete' menu item when read-onlyJim Raykowski
Change-Id: Ib3a1ec5635937b2dcb26144f621ee0bf4a0101d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166413 Reviewed-by: Jim Raykowski <raykowj@gmail.com> Tested-by: Jenkins
2024-04-24Rework SwContentTree context menu item 'Rename' inclusionJim Raykowski
Change-Id: Ice211a3026d07a21b1b6e47ee1c16086401714d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166412 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-04-20loplugin:constantparam in swNoel Grandin
Change-Id: Ia3e1b50954354973ffef701821f661cf782687db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166311 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-14SwContentTree: remove repeated pointer assignmentJim Raykowski
The selected entry does not change within the CommandHdl function therefore assignment of the pointer to the selected entry SwContentType does not need to be repeated elsewhere in the function. Change-Id: I025ecb9259e2ee46a64d55c75d0c3f3c8cc625ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166018 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-04-10tdf#146619 Drop unused 'using namespace' in: sw/Gabor Kelemen
Change-Id: I56463130ab617b0e11e237718cb8456913373818 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165696 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-04improve usability of variable fieldsOliver Specht
The value field of the Variables page of the field dialog is changed into a scrollable field to enhance usability in combination with longer values of variable or user fields Change-Id: Ib268cf22ff54604214fb090c3c93b7d145a9c9a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165750 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-03-24fix CppunitTest_sc_subsequent_filters_test4 intermittent failureCaolán McNamara
Change-Id: Ieb532183fd07915f8e0f2ec0cc3983a390024522 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165257 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-22Related: tdf#160056 refactor SvNumberFormatterCaolán McNamara
to split it into two constituent parts SvNFFormatData which is the data store for number formats it generally operates on. SvNFLanguageData for data around the current language in use. and then a SvNFEngine which implements the interaction between those parts SvNFEngine has two policies, the typical RW mode and a new RO mode where the SvNFFormatData doesn't change, all formats needed in this mode must already exist. Change-Id: I56b070ccd2e556a0cb1fe609a2fae28e18277c8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165146 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-22Related: tdf#160056 these methods can be constCaolán McNamara
Change-Id: Icf52f1665561eef0aa10febc9ca2f946e89b689b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165141 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-02-25tdf#159875 SwNavigator: improve toggle master view visibility handlingJim Raykowski
This patch sets the visibility of the toolbar container that contains the 'Toggle Master View' toolbutton in the first row of the Navigator's toolbox tools as opposed to the current method of setting the toolbutton item visibility. In this way extra space is not given to the toolbar when it is not visible. Change-Id: I6f2ff97728698b3de4812bb9524b2489beac24ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163898 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-02-22tdf#141728 Revamp sw navigator go to page spin controlJim Raykowski
- makes the go to page spin control visible only when Navigate By is set to Page and hides Previous/Next navigation buttons during this time - makes the go to page control track the page number in the document view - reduces the preferred width of the Navigate By control to help reduce the width of sidebar Navigator Change-Id: I8d876a919ac18e69cf62381310389c00671d8596 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163723 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-02-20tdf#153196 writerfilter: fix page style for even/odd section breakMichael Stahl
This is a bit of a special case, where the first section starts with an evenPage break (\sbkeven), which causes a Left-only page style to be created. In completeCopyHeaderFooter(), the HeaderTextFirst and FooterTextFirst are copied from the source style to the Left-only page style, but then they also need to be deleted from the source style, because the Left-only page style is the one that is used for the first page of the section, and the source style is used for the subsequent pages. Additionally, when there is *only* a "first" header/footer, and no previous section has one to inherit, Word will not display a header/footer at all on subsequent pages; a PageStyle will always have a header/footer if it has a HeaderTextFirst/FooterTextFirst. In this case, delete the header/footer from the source style. Unfortunately exporting this doesn't work ideally, a spurious evenPage footer will be created, both due to the FooterShare being automatically reset for no obvious reason in ItemSetToPageDesc(), and setProperty("FooterIsShared", true) "stashing" the left footer since commit b802ab694a8a7357d4657f3e11b571144fa7c7bf. (presumably regression from commit b32881b6723072c8d1a652ea147d12e75766d504) Change-Id: Ie4f9c49605df690e9705e14777c0e4bcb0dfad8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163668 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-02-17Generalize search algorithms in sorted_vectorMike Kaganski
This allows to simplify the code somewhat, and also to relax requirements to the arguments, e.g. allowing to pass const objects to search in vector containing non-const objects. Change-Id: Id34911a8694bbdec275d22b51ca4a0845c9fa4c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163519 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-02-16Deduplicate and unify SwNodes::Go(Next|Prev)(Section)Mike Kaganski
The "Next" methods are made static, just as "Prev" ones. Overloads taking SwNodeIndex and SwPosition are implemented using a common implementation function, to avoid code duplication. Change-Id: I4035188b5c29d19824cd6d031e05d668d5cf1e86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163443 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-02-12tdf#145538 use range based for loopsKeldin Maldonado (KNM)
using range based for loops instead of index based to increase readability in codebase Change-Id: Ib8c3ec3796fce9228cee1d90beb924128b0dea3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162950 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2024-02-10tdf#159372 svx: Add goto dialogAkshayWarrier
Adds a goto page/slide dialog for Impress and Draw similar to Writer. To avoid duplicating code and ui, the dialog is created in svx/ and used in other modules. The old goto dialog in Writer has now been replaced with this dialog. Change-Id: I28f819f0d0734fb2bb08a7b99a628217ef66dba9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162913 Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-02-05tdf#159428 Prefer heading over bookmarks in NavigatorSamuel Mehrbrodt
When a bookmark is in a heading, highlighting the heading is more important than highlighting the bookmark. Change-Id: I6348e42b14ece226a25961bd3145193645972e79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162694 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-02-01tdf#159493: hold solar mutex in TimerUpdateMike Kaganski
Several functions called from here check that the mutex is held, specifically: === call stack 1 === tllo.dll!DbgTestSolarMutex() at C:\lo\core\tools\source\debug\debug.cxx(55) swlo.dll!SwTextBoxHelper::isTextBox(const SwFrameFormat * pFormat, unsigned short nType, const SdrObject * pObject) at C:\lo\core\sw\source\core\doc\textboxhelper.cxx(300) swlo.dll!SwDoc::GetFlyCount(FlyCntType eType, bool bIgnoreTextBoxes) at C:\lo\core\sw\source\core\doc\docfly.cxx(76) swlo.dll!SwFEShell::GetFlyCount(FlyCntType eType, bool bIgnoreTextBoxes) at C:\lo\core\sw\source\core\frmedt\feshview.cxx(2557) swlo.dll!SwContentType::FillMemberList(bool * pbContentChanged) at C:\lo\core\sw\source\uibase\utlui\content.cxx(585) swlo.dll!SwContentTree::HasContentChanged() at C:\lo\core\sw\source\uibase\utlui\content.cxx(3431) swlo.dll!SwContentTree::TimerUpdate(Timer * __formal) at C:\lo\core\sw\source\uibase\utlui\content.cxx(4174) ... === call stack 2 === tllo.dll!DbgTestSolarMutex() at C:\lo\core\tools\source\debug\debug.cxx(55) vcllo.dll!OutputDevice::SetDeviceClipRegion(const vcl::Region * pRegion) at C:\lo\core\vcl\source\outdev\clipping.cxx(205) vcllo.dll!OutputDevice::SetClipRegion(const vcl::Region & rRegion) at C:\lo\core\vcl\source\outdev\clipping.cxx(66) vcllo.dll!SvImpLBox::ShowCursor(bool bShow) at C:\lo\core\vcl\source\treelist\svimpbox.cxx(654) vcllo.dll!SvImpLBox::UpdateAll() at C:\lo\core\vcl\source\treelist\svimpbox.cxx(680) vcllo.dll!SvImpLBox::SetUpdateMode(bool bMode) at C:\lo\core\vcl\source\treelist\svimpbox.cxx(2996) vcllo.dll!SvTreeListBox::SetUpdateMode(bool bUpdate) at C:\lo\core\vcl\source\treelist\treelistbox.cxx(2306) vcllo.dll!SalInstanceTreeView::thaw() at C:\lo\core\vcl\source\app\salvtables.cxx(3938) swlo.dll!SwContentTree::clear() at C:\lo\core\sw\source\uibase\utlui\content.cxx(3018) swlo.dll!SwContentTree::Display(bool bActive) at C:\lo\core\sw\source\uibase\utlui\content.cxx(2853) swlo.dll!SwContentTree::TimerUpdate(Timer * __formal) at C:\lo\core\sw\source\uibase\utlui\content.cxx(4181) ... Change-Id: I643f5984d4678f8062f20bf341bfad6e8462526b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162865 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-01-29Fix typoAndrea Gelmini
Change-Id: Iabeea87e6ebeb6102c06caf00bb2d8abbaea1906 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162677 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-01-28tdf#36310 Insert cross reference from Navigator by DnDJim Raykowski
This enhancement provides the ability to insert cross-references by drag and drop from the Navigator. It replaces the 'drag mode' way of inserting a hyperlink, section link, and section copy with a popup menu on drop that shows insert-as kinds available for the dragged content type. There is an oddity with X11 that on drop the mouse pointer does not change from a drag pointer to a menu item select pointer for approximately 5 seconds and during that time the popup menu items can't be selected. Change-Id: Id72cbdbd81106fc0e70784fcba7f1dd3a43ad81e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161575 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-01-24SwNavigator: status array no moreJim Raykowski
What REGIONMODE_ARY has to do with the active, inactive, and hidden status of documents shown in the document list box is beyond me. This patch removes this strangeness and fixes the 'Active Window' entry so when selected the content tree shows the content of the document entry appended with (active), which is always the document in the view afaik. My guess at the idea for the 'Active Window' entry is to not have to search for the entry marked 'active'. Change-Id: I27a8183fb430e9d5ef465dae323319cdb397fc4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161510 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-01-19tdf#159147 followupJim Raykowski
Avoid unnecessary looping by immediate return from the function after bringing content to attention. Change-Id: I670dc5d0991d96e7ce2872d329e969f9c341d163 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162291 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
generated by cgit (git 2.34.1) at 2024-08-02 20:08:48 +0000