summaryrefslogtreecommitdiff
path: root/sw/source
AgeCommit message (Collapse)Author
2013-11-22Improve exception messagesStephan Bergmann
Change-Id: I95b8d1bfcba66ba5670345e9159f0dca11e6d967
2013-11-22remove unnecessary RTL_CONSTASCII_STRINGPARAMNoel Grandin
A final pass through the code, converting code to use the new OUString and OString methods that can detect string literals. Change-Id: Ifa6382335e5650a1c67e52006b26354e0692c710
2013-11-21Related: rhbz#1033108 how did pAnchoredObj end up as NULLCaolán McNamara
Change-Id: If7d442567d9cea4e3f4d3d68689d11fad0dc930b
2013-11-21longparas: nTxtBreak is really a xub_StrLenCaolán McNamara
Change-Id: If8c3b366bfdf1e626823aca0d7026e877e21c63b
2013-11-21Resolves: fdo#67263 CRASH when deleting applied bulleted paragraph styleJulien Nabet
Change-Id: I70dc18363480e6c07577a93279ddd083631f6cc3 Reviewed-on: https://gerrit.libreoffice.org/6702 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-21longparas: these are really xub_StrLensCaolán McNamara
Change-Id: Ia754de347f277a07479e4056b7c9a03534a3dab4
2013-11-21longparas: this should be xub_StrlenCaolán McNamara
Change-Id: I018104df6fcae8bf1474db1479742238d1cb4cd2
2013-11-21longparas: these are really xub_StrLensCaolán McNamara
Change-Id: I512bf822fcccd158bbe57184ea85a9a72724ca8c
2013-11-21longparas: ditch unused argumentCaolán McNamara
Change-Id: I023a4bee6bf92acc21f0b4821f45b0a47b2da78f
2013-11-21longparas: safe xub_Strlen->sal_Int32Caolán McNamara
Change-Id: Id1425d80908aca5c44f028ccc79e597afa175b00
2013-11-21remove unnecessary RTL_CONSTASCII_STRINGPARAM in OUString::equalsLNoel Grandin
Convert code like this: if (aStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem"))) to: if (aStr == "rem") which compiles down to the same code. Change-Id: I2dfa0f0a457c465948ecf720daaa45ff29d69de9
2013-11-21remove unnecessary use of OUString::createFromAsciiNoel Grandin
Convert code like this: OUString aStrSpacing(OUString::createFromAscii("spacing")); to: OUString aStrSpacing("spacing"); Change-Id: Ia2b7d6b42f35d33cfe587a0d6668030f3537fa6d
2013-11-21Appears SwView::SetMoveType no longer really does anythingStephan Bergmann
...after 3e8fe4d8e19be2ccd8f5bb898530e2f615a90321 "Remove the Navigator buttons below the scrollbar in Writer." Change-Id: Iafef7e3ae1bd1c272c25759cf5abcaf96d6aeb94
2013-11-21Remove the Navigator buttons below the scrollbar in WriterSamuel Mehrbrodt
Discussion was here: http://nabble.documentfoundation.org/Libreoffice-ux-advise-Remove-the-Navigator-button-below-the-scrollbar-in-Writer-td4083097.html Change-Id: I04b33a8e992c87b8e7519dc62c208e6dc116f8e1 Reviewed-on: https://gerrit.libreoffice.org/6045 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2013-11-20Clean up SwXTextDocument::createStephan Bergmann
Change-Id: I78a190176b7a4070442036772d244ea008dd34c1
2013-11-20Freeze layout / page format normalization.Jan-Marek Glogowski
For single-file mail merge this skips the page format normalization, which would be run during each document / page append. Instead the normalization / checks are run for the whole document at the end of the generation, changing this code from O(n2) to O(n). This way each mail merge generated document uses the same time, because the target document isn't completely traversed for each page change. With my test document this produces the same output, save some changed internal document IDs. This fixes fdo#56355. Change-Id: Ia779705cfb107383341f946542d28434c986591a Reviewed-on: https://gerrit.libreoffice.org/6733 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2013-11-20Resolves: #i123578# adjust table layout algorithm to avoid layout loopsOliver-Rainer Wittmann
--> no shrink of master table, when follow table current is layouting its lower table row (cherry picked from commit c037ec6acc66efdeee738f057acee7c52ab979f3) Conflicts: sw/source/core/inc/tabfrm.hxx sw/source/core/layout/tabfrm.cxx Change-Id: Ic1366b20e421d582977d44c6dd7dae3865f53ec4
2013-11-20Revert "remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL calls"Noel Grandin
This reverts commit acebbee971136e6ee0a7bc75bd57d937d6e1c295. I mistakenly converted OUString::equalsL calls to OUString::startsWith calls.
2013-11-20avmedia: Implement "block untrusted referer links" featureStephan Bergmann
See f0a9ca24fd4bf79cac908bf0d6fdb8905dc504db "rhbz#887420 Implement 'block untrusted referer links' feature" for details. This adds some further /*TODO?*/ comments, and one known problem (marked /*TODO!*/) is that movies/sounds are not blocked during a slideshow presentation. Change-Id: Ib2d0c7e4f7b02c4bdec0d8a90cee5e7e1bee8325
2013-11-20fdo#71740 AutoCorrection Border emphasis differencesLaurent Balland-Poirier
AutoCorrection of === create a so thin border that it is almost invisible. This patch increases width of borders to get differences more visible Change-Id: Ifb34e52410b37fe74059721386cbfa49df590ace Reviewed-on: https://gerrit.libreoffice.org/6710 Reviewed-by: Thorsten Behrens <thb@documentfoundation.org> Tested-by: Thorsten Behrens <thb@documentfoundation.org>
2013-11-20bnc#837302: Allow insertion of redlines with an empty author.Jan Holesovsky
No idea why that was not allowed (since the initial import in 2000), we need it for interoperability. Change-Id: I475fa63f9a4a3219a2b898b6f7d81e0603d32c18
2013-11-20Highlight fade in SwCommentRulerRodolfo Ribeiro Gomes
It was not implemented, though designed. No delay was used before start fading. I don't think it flickers. https://wiki.documentfoundation.org/Design/Whiteboards/Comments_Ruler_Control#Behavior Change-Id: I419220aac0a9cbfae328874cf6015d9530b93784 Signed-off-by: Rodolfo Ribeiro Gomes <rodolforg@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/6706 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-20remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL callsNoel Grandin
Convert code like: if (aByteStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem"))) to: if (aByteStr.startsWith("rem")) Change-Id: I09e40b3fdc87d59a8176c2a5f39cc6aa5cf5a576
2013-11-20remove RTL_CONSTASCII_STRINGPARAM in OStringBuffer constructorNoel Grandin
Convert code like: OStringBuffer aKeyName(RTL_CONSTASCII_STRINGPARAM("NDX")); to: OStringBuffer aKeyName("NDX"); which compiles down to the same code Change-Id: If9c96a290bc18cc8285fb733f27be58c6958b63c
2013-11-20Remove now useless RTL code-comment on SwCommentRulerRodolfo Ribeiro Gomes
RTL work was done by someone else. Change-Id: I8b8b923ff3e336427a2dadeccab7c7176d51b2fe Signed-off-by: Rodolfo Ribeiro Gomes <rodolforg@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/6716 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-20Writer : Fix fdo#71694 by clearing old anchor frame before setting newArnaud Versini
Needed as otherwise AnchoredObjects can be in more than one SwLayoutFrm. See also 7eae50f9ff5877ef880be9a85d3f7e52b1fec49f ( Access by AnchoredObject of a deleted SwLayoutFrm ). Change-Id: I54582d6f9fb8b6f853352af27706faabe610874b Reviewed-on: https://gerrit.libreoffice.org/6720 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-20remove unnecessary RTL_CONSTASCII_STRINGPARAM in OString::appendNoel Grandin
Convert code like: aOStringBuf.append( RTL_CONSTASCII_STRINGPARAM( " is missing )") ); to: aOStringBuf.append( " is missing )" ); which compiles down to the same code. Change-Id: I3d8ed0cbf96a881686524a167412d5f303c06b71
2013-11-20convert equalsAsciiL calls to startsWith callsNoel Grandin
Convert code like: aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) ) to aStr.startsWith( "ActiveConnection" ) which compiles down to the same machine code. Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
2013-11-20fdo#71645 remove footnote numbers in cross-referencesLászló Németh
Change-Id: Ic3780e4389e450d8c7a69d2f0f2a6a7f81b8906e
2013-11-19Disambiguate std::max callStephan Bergmann
Change-Id: Ie389d52f5914f49dcd61d5543ed9413ab82101f9
2013-11-19don't panic on clicking inside input fieldCaolán McNamara
Change-Id: I52b53da16784cc5650d362c3884d93ed16979ca2
2013-11-19Resolves: #i33737# enable in-place editing of Input FieldsOliver-Rainer Wittmann
(cherry picked from commit c2afeb1c3f11e8f420b59f3786eb8626c99ff595) Conflicts: sw/inc/IDocumentContentOperations.hxx sw/inc/crsrsh.hxx sw/inc/doc.hxx sw/inc/editsh.hxx sw/inc/expfld.hxx sw/inc/fldbas.hxx sw/inc/fmtfld.hxx sw/inc/hintids.hxx sw/inc/ndtxt.hxx sw/inc/txatbase.hxx sw/inc/txtfld.hxx sw/inc/txtrfmrk.hxx sw/inc/txttxmrk.hxx sw/inc/viscrs.hxx sw/source/core/bastyp/init.cxx sw/source/core/crsr/crsrsh.cxx sw/source/core/crsr/crstrvl.cxx sw/source/core/crsr/findattr.cxx sw/source/core/crsr/findtxt.cxx sw/source/core/crsr/swcrsr.cxx sw/source/core/crsr/viscrs.cxx sw/source/core/doc/dbgoutsw.cxx sw/source/core/doc/doc.cxx sw/source/core/doc/docfld.cxx sw/source/core/doc/docfmt.cxx sw/source/core/doc/docnum.cxx sw/source/core/doc/docredln.cxx sw/source/core/doc/docruby.cxx sw/source/core/doc/doctxm.cxx sw/source/core/doc/visiturl.cxx sw/source/core/docnode/nodes.cxx sw/source/core/edit/edatmisc.cxx sw/source/core/edit/edattr.cxx sw/source/core/edit/edfld.cxx sw/source/core/edit/edfldexp.cxx sw/source/core/edit/editsh.cxx sw/source/core/edit/edlingu.cxx sw/source/core/edit/ednumber.cxx sw/source/core/fields/expfld.cxx sw/source/core/fields/fldbas.cxx sw/source/core/fields/reffld.cxx sw/source/core/frmedt/fefly1.cxx sw/source/core/inc/docfld.hxx sw/source/core/inc/rolbck.hxx sw/source/core/inc/swfont.hxx sw/source/core/layout/flycnt.cxx sw/source/core/layout/laycache.cxx sw/source/core/layout/trvlfrm.cxx sw/source/core/text/atrhndl.hxx sw/source/core/text/atrstck.cxx sw/source/core/text/inftxt.cxx sw/source/core/text/porfld.cxx sw/source/core/text/porfld.hxx sw/source/core/text/txtfld.cxx sw/source/core/tox/tox.cxx sw/source/core/tox/txmsrt.cxx sw/source/core/txtnode/atrfld.cxx sw/source/core/txtnode/ndhints.cxx sw/source/core/txtnode/ndtxt.cxx sw/source/core/txtnode/thints.cxx sw/source/core/txtnode/txatbase.cxx sw/source/core/txtnode/txatritr.cxx sw/source/core/txtnode/txtedt.cxx sw/source/core/undo/SwUndoField.cxx sw/source/core/undo/rolbck.cxx sw/source/core/undo/unsect.cxx sw/source/core/undo/untbl.cxx sw/source/core/unocore/unocrsrhelper.cxx sw/source/core/unocore/unofield.cxx sw/source/core/unocore/unoframe.cxx sw/source/core/unocore/unorefmk.cxx sw/source/core/view/vprint.cxx sw/source/filter/ascii/ascatr.cxx sw/source/filter/html/htmlatr.cxx sw/source/filter/rtf/rtffly.cxx sw/source/filter/ww1/fltshell.cxx sw/source/filter/ww1/w1filter.cxx sw/source/filter/ww8/wrtw8esh.cxx sw/source/filter/ww8/wrtw8nds.cxx sw/source/filter/ww8/ww8atr.cxx sw/source/filter/ww8/ww8par.cxx sw/source/filter/ww8/ww8par3.cxx sw/source/filter/ww8/ww8par5.cxx sw/source/ui/app/applab.cxx sw/source/ui/docvw/edtwin.cxx sw/source/ui/docvw/edtwin2.cxx sw/source/ui/envelp/envfmt.cxx sw/source/ui/fldui/fldedt.cxx sw/source/ui/fldui/fldmgr.cxx sw/source/ui/inc/wrtsh.hxx sw/source/ui/lingu/hhcwrp.cxx sw/source/ui/shells/basesh.cxx sw/source/ui/shells/drwtxtex.cxx sw/source/ui/shells/grfsh.cxx sw/source/ui/shells/tabsh.cxx sw/source/ui/shells/textfld.cxx sw/source/ui/shells/textidx.cxx sw/source/ui/shells/textsh.cxx sw/source/ui/shells/textsh1.cxx sw/source/ui/shells/txtattr.cxx sw/source/ui/uiview/formatclipboard.cxx sw/source/ui/uiview/view.cxx sw/source/ui/uiview/view2.cxx sw/source/ui/uiview/viewsrch.cxx sw/source/ui/uiview/viewstat.cxx sw/source/ui/uiview/viewtab.cxx sw/source/ui/wrtsh/wrtsh1.cxx sw/source/ui/wrtsh/wrtsh2.cxx Change-Id: I6758d6719e1fd523797cc6ee2648ffcb47d52595
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19remove most use of RTL_CONSTASCII_USTRINGPARAM macroNoel Grandin
This is largely unnecessary when working with OUString Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-18cp#1000018 RTF export: avoid additional paragraph at footnote endMiklos Vajna
Change-Id: I430a7d705208f197050a7d521c9c20b267c33f26
2013-11-17The new default Writer templateAhmad H. Al Harthi
New headings, better paragraph and lines spacing.
2013-11-17Make the tiled rendering code compile for Android againTor Lillqvist
I just ifdeffed out iOS-specific code, no actual Android-specific code added. And if at some stage we have need and resources to really make the tiled rendering stuff saner and cross-platform, a lot will change of course. Change-Id: If45d98f301413e26372c611f8ffecf229061174d
2013-11-17bugs.freedesktop.org -> bugs.libreoffice.orgAndras Timar
Change-Id: I56c1190c93333636981acf2dd271515170a8a904
2013-11-17sal_Bool to boolTakeshi Abe
Change-Id: I0b01f904f78ec1a3d1aebd2af2ae8f55588a504f
2013-11-15[docx] activeX reference files (.bin) saved in InteropGrabBag and exported.sushil_shinde
The XInputStream for activeX.bin files is stored as the PropertyValue "OOXActiveXBin" into the "InteropGraBag" Added mxActiveXBinList object which holds XInputStreams for each activeX.bin from activeX folder. Added .bin files entry to respective acivex.xml's .rels file. Added Unit Test to test all .bin files are stores properly. Reviewed on: https://gerrit.libreoffice.org/6679 Change-Id: I3a0e9462a6cc53d8cbb9c7d59ed24631d77d4d30
2013-11-15Fixed for spacing between lines having lineRule "auto" is getting preservedPriyankaGaikwad
Problem Desciption: In "w:spacing" value of "w:lineRule" attribute value is not getting is preserved. Conflicts: sw/qa/extras/ooxmlexport/ooxmlexport.cxx Reviewed on: https://gerrit.libreoffice.org/6675 Change-Id: Ie9c99864bd5a198af94c1d251666bcb3427d955a
2013-11-15LibreOffice Corrupts DOCX files containing Footnotes after RoundtripPallavi Jadhav
Issue : 1] Extra data was getting written into document.xml after </w:document> This includes : 1) <sectPr> tag 2) Paragraph tag of <w:footnote w:id="2"> from footnotes.xml 2] This is leading to document corruption Implementation : 1] Enabled a flag inside DocxAttributeOutput::FootnotesEndnotes 2] Check value of flag to decide whehter to write section properties or not Conflicts: sw/qa/extras/ooxmlexport/ooxmlexport.cxx sw/source/filter/ww8/docxattributeoutput.cxx Reviewed on: https://gerrit.libreoffice.org/6644 Change-Id: Iae53fd6bf12bcbac84846bd36823bc08f21f9edf
2013-11-15Save Image-Crop information for GIF in docxPallavi Jadhav
Issue:- 1] When MS Office docx file containing cropped image is round tripped with LibreOffice 4.2, image looses its cropping effect. Implementation:- 1] Converted MAP unit, MAP_PIXEL to MAP_100TH_MM using PixelToLogic function. As for calculating EMU values for XML, we need Original Height and Width of an image in 100thMM(HMM) format. 2] Written Export Unit Test (GIF) to verify cropping parameters. Conflicts: sw/qa/extras/ooxmlexport/ooxmlexport.cxx Reviewed on: https://gerrit.libreoffice.org/6595 Change-Id: I54d7b08c96608a0cfca3c2f8833684c09848351c
2013-11-15DOCX export: fixes for para auto spacing roundtripMiklos Vajna
- m_bParaBeforeAutoSpacing / m_bParaBeforeAutoSpacing was never set to false - m_iParaBeforeSpacing / m_iParaAfterSpacing was uninitialized Change-Id: I5c8ebd8e4f4c151059916397bc45e0c0ebcf5040
2013-11-15Resolved: Preservation of para before and after auto spacing.Nikhil Walvekar
During import a flag and fixed value is stored in InteropGrabBag and during export we check for fixed value and value available in para spacing object. Write autospacing only if para spacing values are not modified during edit. Reviewed on: https://gerrit.libreoffice.org/6575 Change-Id: If34c5b61c3180b01e68dfe83862784c3d6f33981
2013-11-15Tiled rendering: Move the common code to the right place - PaintTile().Jan Holesovsky
Change-Id: Id0502c4e0dd48dce8d1a239b5d156ff290314954
2013-11-15Tiled rendering: Make the tiled rendering work together with normal render.Jan Holesovsky
Not an ideal solution, but cleaning up the amount of output devices we have around would take me quite some time, and would be not too safe just before the feature freeze, so let's live with mbTiledRendering flag for now. Change-Id: I93616df18c790d8ce1251194b0c8b09442f5a265
2013-11-15release BitmapReadAccess after use to fix 1 mb per render mem leakPtyl Dragon
Change-Id: I4d9a580132eb9a8d618c1165f962b47be4e80695
2013-11-15removed use of envvars in touch_lo_draw_tilePtyl Dragon
Change-Id: Id9ee6e616fe417023d0ce011263659056e80a5a2
2013-11-15Do use scaling after allTor Lillqvist
It is needed because we want to be able to render different zoom levels of tiles of course. But invert the scale from how it was previously. Increasing what is here called "tile size" (i.e. the size in document coordinates of the rectangle to be rendered) should mean the rendered text gets smaller, not larger. Also, use the same units (twips) in numerator and denominator. Change-Id: I461f887461247777af1a9402de112d42c8423293