summaryrefslogtreecommitdiff
path: root/sw/source
AgeCommit message (Collapse)Author
2016-06-15tdf#100275 sw: fix target node of bookmark copyMichael Stahl
Replaces the defensive programming band-aid of 5c1a1d1c66aff497702abc20df5832fa348f1008 with a real fix. The problem is that lcl_NonCopyCount() has some special case code to ignore the first node in the target document, which erroneously is executed for every bookmark, which results in the 2 bookmarks in the bugdoc being created with nDelCount 1 and 2 so they land on the same node, which is not allowed for cross-reference marks. Extract the adjustment into a separate function that is called once. (regression from 689962feae2054f965a7378c3408b0ccfad2bbd5) Change-Id: Ie14c650f7fdb259c13cb9048226da30971d2ab3c
2016-06-14/org.openoffice.Office.Writer/FormLetter/MailingOutput/Format is xs:intStephan Bergmann
...i.e., sal_Int32 Change-Id: Ib6adcfc40ee509f383fbd62093affe73ab92d61d
2016-06-14crashtesting: fix ~SwIndexReg assert on exporting tdf46441-2.odt to .docCaolán McNamara
Change-Id: I770c1f5ed4ebfb216810e30de83eb053606c2f8d
2016-06-14the __RSC hack is only needed in src files and things included from src filesCaolán McNamara
Change-Id: I50c122426030ba5b508dcd6ac33464ecab154981
2016-06-14tdf#83830: Moved margin preset control to Format PanelSusobhan Ghosh
Added new margin presets. Change-Id: I65927ebfaf61515cedd76bb85e0a6d543fc16b89 Reviewed-on: https://gerrit.libreoffice.org/25520 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-13tdf#83830: Removal of Page Margin PanelSusobhan Ghosh
Change-Id: I05c0b2ba42cf395a2b30ce658e1f1d034e95f21f Reviewed-on: https://gerrit.libreoffice.org/26217 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-13sw comments: implement per-view LOK_CALLBACK_INVALIDATE_TILESMiklos Vajna
After registration and invalidation is handled per-view, the scrollbar and the text control of the comments is rendered correctly. Change-Id: I5cfa8b43fdc3a2ce7a008269b0283ee25d141440 Reviewed-on: https://gerrit.libreoffice.org/26218 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-13tdf#42949: clean up includes in include/vbahelper with iwyuJorenz Paragas
Change-Id: Iaf93ff58229e9362b03b3e810611e969ef8baf38 Reviewed-on: https://gerrit.libreoffice.org/26206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-13GSoC Table Styles, CellStyleJakub Trzebiatowski
- insertByName - replaceByName - removeByName Change-Id: I964aa0dc2e7f5a5be9eaec719b8944e847eb9d6a Reviewed-on: https://gerrit.libreoffice.org/26037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-13sw: prefix members of SwCacheAccessMiklos Vajna
Change-Id: Ia18ad7e283898418118237c1997a6ee72c468341 Reviewed-on: https://gerrit.libreoffice.org/26209 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-11coverity#1362687 Uninitialized pointer fieldCaolán McNamara
and coverity#1362688 Uninitialized pointer field Change-Id: Ie9711dc7131ee41e4acd9d0a628d63272bf2a0c6
2016-06-10Clean up uses of Any::getValue() in swStephan Bergmann
Change-Id: Ifaa239ab3e285e8cf998339456ece5ce99008af9
2016-06-10All WinWord/* props in Writer.xcs are oor:type="xs:long"Stephan Bergmann
...i.e., sal_Int64, so cannot be read by casting the Any's value to sal_uInt32. (SwFilterOptions::GetValues is apparently only used from SwWW8ImplReader::LoadDoc.) Change-Id: Ib2efa34093318fc3f55bbc2a93c2379990b1b791
2016-06-10Resolves: tdf#100275 makeMark may return null under some circumstancesCaolán McNamara
Change-Id: If3b83413c028c6cd1c055e632b6f050ec7f2475d
2016-06-10Move accessibility relations to .ui files, Part 8: tdf#87026Muhammet Kara
By removing unnecessary variables/strings/function calls, and making proper changes in the related .ui files. Change-Id: I04244b360b4bb32ccbbe5bde4756a9166ae1fcaf Reviewed-on: https://gerrit.libreoffice.org/26018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-10sw: implement per-view LOK_CALLBACK_SEARCH_RESULT_SELECTIONMiklos Vajna
This way searching in one view does not affect the search state of an other view. Change-Id: I6d873b1609a8f6cb3cfe07e1f2fa92024c3545d9 Reviewed-on: https://gerrit.libreoffice.org/26161 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-10sw: implement per-view LOK_CALLBACK_HYPERLINK_CLICKEDMiklos Vajna
So that the view that initiated the mouse click gets the hyperlink value. Change-Id: Ibef1c5df3f27f782ce6e24c9650f92c96b8b79e3 Reviewed-on: https://gerrit.libreoffice.org/26156 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-10sw: restore the useful bug referencesMichael Stahl
Change-Id: I8cc8ee1c1c9195846397f734c42e019f0c27fd49
2016-06-10sw: implement per-view LOK_CALLBACK_DOCUMENT_SIZE_CHANGEDMiklos Vajna
This is interesting for all views, but given we invoke the callback in SwViewShell, it's only necessary to notify the matching LOK view callback and still all views are updated. Change-Id: Idc59b2bba1a944a9ad1dd0acd934a85130b32993 Reviewed-on: https://gerrit.libreoffice.org/26154 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-10Convert SvxPraVertAlignItem::Align to scoped enumNoel Grandin
Change-Id: I2f73a200b04322dd65e0758f4238347bfea832fb
2016-06-10tdf#42949: clean up includes in include/oox/vml with iwyuJorenz Paragas
Change-Id: I753880ce146fef6523561290b8e13310d9f7219c Reviewed-on: https://gerrit.libreoffice.org/26142 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-10tdf#90834 Turn in-line version control history commentsapurvapriyadarshi
cleanup in sw/source/core/view/vnew.cxx Change-Id: Ifc53ad8a195835291aa7fb4c2a2db1a8e468117b Reviewed-on: https://gerrit.libreoffice.org/25595 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-10sw: -Werror=unused-variableMichael Stahl
Change-Id: Id0f3e7a8048953894a8b9a2deeed1284d38d709f
2016-06-10remove bBreakAfter& param from SwLayHelper constructorNoel Grandin
the constructor is only called from one spot, which does not care about the output value of bBreakAfter Change-Id: I184091d3862265f0718b52c2cd82cad861274c1c Reviewed-on: https://gerrit.libreoffice.org/26110 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-09sw: implement per-view LOK_CALLBACK_SET_PARTMiklos Vajna
Used when e.g. jumping from page 1 to page 2 in a document, and the page number widget should be updated in gtktiledviewer. Change-Id: If5359ffbfd215c71785ab51f8dcd18cc8bf017ee Reviewed-on: https://gerrit.libreoffice.org/26115 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-09tdf#96089 sw: fix scope of bBreakAfter in InsertCnt_()Michael Stahl
The problem is that bBreakAfter is passed by reference to SwLayHelper and stored as a reference member there, so it has to live at least as long as pPageMaker. (Unfortunately C++ can't statically check that.) This then somehow caused the number of pages created after initial load to be 812 instead of the correct 396 determined from the layout-cache in the bugdoc, and that then caused Drawing objects to move backward during the following re-pagination, and then SwDrawContact::Changed_() calls SetFlyFrmAttr() and that sets the document to modified, which triggers the AutoSave that was reported in the bug. (regression from b4b7703e4335460cf48bfd6440f116359994c8ff) Change-Id: I14dc4644c2e127b3c3ff0e6876eedcc534e1a68e
2016-06-08Let loplugin:passstuffbyref also look at fn defn not preceded by any declStephan Bergmann
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
2016-06-08tdf#97103 sw: fix restoring of SetRedlineMode on DOCX/RTF exportMichael Stahl
In order to prevent ~SwIndexReg asserts, this was changed to restore the redline mode not in MSWordExportBase::ExportDocument() but in SwWriter::Write(). Unfortunately only the DOC export actually uses SwWriter::Write(), so fix the original problem differently by moving the cursors onto a EndNode. The m_pCurPam will be deleted anyway, and the m_pOrigPam usually also will be, and in the case it isn't deleted i hope it's not important :) (regression from 0b037361b890a83a735186b98d5a3cef124027f4) Change-Id: Ib3d0cc32862256fdc4363b6035c190cbbcfe5df3
2016-06-08tdf#96099 Remove various smart pointer typedefsMark Page
Change-Id: I76843139e43ca1c158a977e24d210d5af93e4d0f Reviewed-on: https://gerrit.libreoffice.org/26014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08sfx2 classification: use auto where it improves code readabilityMiklos Vajna
std::map<OUString, basegfx::BColor>::iterator itColor = aColors.find(aLevel); vs auto itColor = aColors.find(aLevel); and so on. (And do the same at two other places as well.) Change-Id: I538998c8b8afdf18a7eb139fa4d469205c561370 Reviewed-on: https://gerrit.libreoffice.org/26046 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-08remove "object is disposed" warning in OBroadcastHelperVar::removeListenerNoel Grandin
doesn't add anything of value. Change-Id: Ie2dea7c43570640284771c992d0072ab61de425e Reviewed-on: https://gerrit.libreoffice.org/25871 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08sw SwXTextCellStyle fix possible nullptr dereferenceJakub Trzebiatowski
Change-Id: Id6303afdbd294066332c1806699a47086331e9ef Reviewed-on: https://gerrit.libreoffice.org/26038 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jakub Trzebiatowski <ubap.dev@gmail.com> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-07sw UNO Cell Style family, SwXTextCellStyleJakub Trzebiatowski
Cell Family :: getByName Cell Family :: getElementNames Cell Family :: getCount Change-Id: I37d567ee284054f847c704d9fce370d174a0c48c Reviewed-on: https://gerrit.libreoffice.org/25896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-07Move accessibility relations to .ui files, Part 7: tdf#87026Muhammet Kara
By removing unnecessary variables/strings/funciton calls, and making proper changes in the related .ui files. Change-Id: I059bf02bc6ea29bf1b92d21f5a10a76548ecd1fc Reviewed-on: https://gerrit.libreoffice.org/25973 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-06sw: simplify identical branches in WW8AttributeOutput::DefaultStyleMichael Stahl
Change-Id: I0d500ecbcd0bc0d6b9f772304345acd4ddb5df11
2016-06-06tools: rename SvStream::Read/Write to ReadBytes/WriteBytesMichael Stahl
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a Reviewed-on: https://gerrit.libreoffice.org/25972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-06sw: prefix members of SwCacheMiklos Vajna
Change-Id: I2896dffca4d13dd95612fa463c66eb5a769d5650 Reviewed-on: https://gerrit.libreoffice.org/25952 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-06Revert "Revert "Simplify sfx2 removing SfxModuleArr_Impl and dummy SfxModule ↵Noel Grandin
flag"" This reverts commit abde31a2bc68302e1afafe1fcc3f5d85369010f8. Since my analysis was completely incorrect, and the bug was elsewhere.
2016-06-06SwXDispatchProviderInterceptor: implement frame::XInterceptorInfoMiklos Vajna
With this, framework::InterceptionHelper can make a better decision what interceptor to call: it can avoid calling SwXDispatchProviderInterceptor when the sw code would just call the previous interceptor anyway. Change-Id: I92897f2c8baa264dc9ccbc11b63f415da30a910d Reviewed-on: https://gerrit.libreoffice.org/25961 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-06loplugin:sallogareasStephan Bergmann
Change-Id: I76a1ca53ea51488f1338276042e1e435ed34f602
2016-06-06tdf#83830: Page Format PanelSusobhan Ghosh
Change-Id: I16d263f07eb49eaa32a161958b48f4059fffafdf Reviewed-on: https://gerrit.libreoffice.org/25530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-06Revert "Simplify sfx2 removing SfxModuleArr_Impl and dummy SfxModule flag"Noel Grandin
This reverts commit e319ef1171dab61fff2201f5c1470ca09894c395. Apparently, at some point, someone added a 'bool bDummy' param to SfxModule, but only updated 2 of the 5 callsites. Since we're passing in pointers here, at the other call sites, the bDummy param evaluated to 'true'.
2016-06-06fdo47267 fix import crashJakub Trzebiatowski
fixed import crash introduced in d4188f643db050c962a937547d19a9a08bd2235d Change-Id: I0bf76fd345438e3cd303ee85c770aa0515c056df Reviewed-on: https://gerrit.libreoffice.org/25887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-06Simplify sfx2 removing SfxModuleArr_Impl and dummy SfxModule flagMark Page
The SfxModuleArr_Impl is a static container of SfxModule, since this is private to the SfxModule class it does not require wrapping. The bDummy flag is unused, and complicates the class Change-Id: Ib03b215543a0c37d4edf20b2d0fc141a783e115e Reviewed-on: https://gerrit.libreoffice.org/25859 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06Convert DeactivePage return code to scoped enumNoel Grandin
Change-Id: Idd5372ad20fc6676864b31b3796f8b9bc0ad73dd Reviewed-on: https://gerrit.libreoffice.org/25918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06remove unused constants in HRC filesNoel Grandin
Change-Id: Ia034fb16ce75caeb69fd746d4a602cd5fcfef6d1 Reviewed-on: https://gerrit.libreoffice.org/25817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-04tdf#96099 Remove sfx std::shared_ptr typedefsMark Page
Removed SfxItemSet_Pointer_t and SfxStyleSheetIteratorPtr Change-Id: Ibfa6a79809fdbbe2648dacc02625e620ceaf9bf0 Reviewed-on: https://gerrit.libreoffice.org/25851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03Convert ComplexTextLayoutMode to scoped enumNoel Grandin
Change-Id: I257f8e15fec92f0701235a6fe4b6a2272498c4f1 Reviewed-on: https://gerrit.libreoffice.org/25667 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03sw: replace some OSL_ENSURE with assertMichael Stahl
... and delete a couple that are obviously dead. Change-Id: I2cef18371cc57f5fd82500d0ab6d74030004a761
2016-06-03sw: convert some OSL_FAIL to assertMichael Stahl
Change-Id: Ia5244d58b8975a371c2d74809021c2332ffa496b
generated by cgit (git 2.34.1) at 2024-07-30 19:19:53 +0000