summaryrefslogtreecommitdiff
path: root/sw/source
AgeCommit message (Collapse)Author
2014-06-05fdo#79535 :LO writer crash while Opening some document.Tushar Bende
Problem Description : While setting ExtraData for Redline LO calls SwRangeRedline::SetExtraData() with argument of type SwRedlineExtraData_FormattingChanges* which contains SfxItemSet* In function SwRedlineExtraData_FormattingChanges() without Null checking SfxItemSet*, LO was trying to get rCpy.pSet->Count() which was the reason for segmentation fault while opening some documents in LO. Added Null check before accessing a pointer. Change-Id: I33299d2be2777ab6a8af0621595c9453145f1069 Reviewed-on: https://gerrit.libreoffice.org/9647 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-05Avoid possible memory leaks in case of exceptionsTakeshi Abe
Change-Id: Ia8bc0e24a76dd953000b73806ac21f21db4c4ca3
2014-06-05Avoid possible memory leaks in case of exceptionsTakeshi Abe
Change-Id: Iaf672463cf51d596148822d9b5effe5ab40f70d4
2014-06-05various: remove SAL_THROW macroNoel Grandin
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-06-04Export fieldmark check boxes as HTML checkboxes.Kohei Yoshida
Change-Id: Ida4572f43ad2c797bb71607b37237bd7630d0d58
2014-06-04Corrected GetDrawBackgrdColor to return a value, not a referenceArmin Le Grand
(cherry picked from commit a8a2653568d31a2fb76aeb3183e128e3304452bd) Conflicts: sw/source/core/layout/paintfrm.cxx Change-Id: I1e0a5a255d67d130f85a8c5c739c4e5cd4ce03c5
2014-06-04coverity#705316 Missing break in switchCaolán McNamara
Change-Id: I4f730b66e9a0ce2ce32857d5c19ed2dffeeeaf45
2014-06-04compareTo -> equalsNoel Grandin
convert OUString::compareTo usage to equals to startsWith where it is more appropriate Change-Id: I6f5b5b7942429c0099ad082ba4984fd18e422121
2014-06-04compareToAscii -> equalsAsciiNoel Grandin
convert places using compareToAscii that should be using equalsAscii Change-Id: I97b4da7f6e867c3967b2f65b70d6886f83b4a4e5
2014-06-04fdo#78907 : File crashed while saving.PriyankaGaikwad
- There is pagebreak in file and footer has nested table. - While exporting LO write section break instead of PAGE_BREAK. - Due to this it was writing two sections in file and same footer for both sections. - This was causing wrong table depth values due to this it was crashing while writing table. - So in MSWordExportBase::OutputSectionBreaks if next node has RES_BREAK(page break) then bNewPageDesc value should be false. Change-Id: I2ccc4e48a26253716253a7280a244f06e172770a Reviewed-on: https://gerrit.libreoffice.org/9568 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-06-04avoid problems with poppler's and vcl's FontInfo during runtimeMarkus Mohrhard
Change-Id: I1dbd256812cccae1e6ed0ad8bb34ce427e5e5be8
2014-06-04Avoid possible memory leaks in case of exceptionsTakeshi Abe
Change-Id: I45929aae52fa106b5f5c0199f8ce8b60c0ac5438
2014-06-04Drop an unused fileTakeshi Abe
Change-Id: I8ad19f77c199bac6890f2917b16588579ea12eae
2014-06-03Finished rebasing to master.Valentin Kettner
I forgot some lines while rebasing and had to fix this here. Change-Id: I6a29497aa779d2b104db685161d89ae7c27805b3
2014-06-03sw: fix some assertions that still use removed SwDoc methodsMichael Stahl
Change-Id: Ia33dff51cdb58030ec11ec499ee5c518fba31641
2014-06-03Moved SwDoc's get<Interface> methods from docnew to doc.cxxValentin Kettner
To have them all in the same place. Change-Id: I8fd0f7fa0c88b5b17596998810d505deb14a8c06
2014-06-03Split out IDocumentDrawModelAccess from SwDoc.Valentin Kettner
To the new class DocumentDrawModelManager. All moved methods and members have the same in thew new class. Change-Id: I89ad0e0c4a42885d5810e834983ea8e8e6c0a2d2
2014-06-03Changed DocumentDeviceManager includes to IDocumentDeviceAccess.Valentin Kettner
In places other than sw/core/ Change-Id: Ie1b67f58cf7777240d9db6a867cd33a7a1cbbcaf
2014-06-03Added IDocumentSettingAccess& getIDocumentSettingAccess() to SwDocValentin Kettner
Which returns the DocumentSettingManager as its interface. Change-Id: I7d2c2d28a28fbcf19176ab5dda6940ce6d9b17cb
2014-06-03Fixed a typo in IDocumentSettingAccess.hxxValentin Kettner
Compatability -> Compatibility Change-Id: Ia80e6db589a74d2aa8d1276195bc30ddb8d251fd
2014-06-03Removed IDocumentDeviceAccess.hxx include in SwDoc.hxxValentin Kettner
Because it is not needed there anymore in that class. I added it as an include in all files that need it. Change-Id: I3eb2e1da9d153017968b286e1a0250f145ca7cfe
2014-06-03Removed IDocumentSettingAccess.hxx include in SwDoc.hxxValentin Kettner
Because it is not needed there anymore with IDocumentSettingManager. Change-Id: Iad5e0a03f2628c9d26698d23e691b3e6228eee0b
2014-06-03Removed DocumentSettingManager methods from SwDoc.Valentin Kettner
And moved all calls to those methods to GetDocumentSettingManager(). Change-Id: I9b6cc8c3aa9b57bbc0c39f39499dfb4f5f254ad9
2014-06-03Added 32DummyCompatabilityOptions to DocumentSettingManangerValentin Kettner
And corresponding getter and setter which had to be made part of IDocumentSettingAccess so their symbols get correclty exported. Change-Id: Ia33244767110364174b115eaca5d733462be61ca
2014-06-03Work on DocumentSettingManager for SwDoc.Valentin Kettner
Moved mn32DummyCompatabilityOptions1 from SwDoc to DocumentSettingManager and moved a comment from SwDoc to it. Change-Id: I4abd5cd9596d23dc3ac12460ee9b38345d0bf0a7
2014-06-03Made SwDoc::getDocumentDeviceAccess return a reference.Valentin Kettner
Also overloaded SwDoc::getDocumentDeviceAccess with its const version. Change-Id: I3272be3ee067aa2e0174663ede3c98190ecf2b09
2014-06-03Finished cleaning up of IDocumentDeviceAccess methods in SwDoc.Valentin Kettner
Moved all SwDoc::getPrintData and SwDoc::setPrintData calls to their appropriate interface methods (SwDoc::getIDocumentDeviceAccess::"). Change-Id: I5671b365238abae6d94f125fb7a99481d81392f9
2014-06-03Cleaning up of IDocumentDeviceAccess methods in SwDoc.Valentin Kettner
Moved all SwDoc::getJobSetup and SwDoc::setJobSetup calls to their appropriate interface methods (SwDoc::getIDocumentDeviceAccess::"). Change-Id: I155a0341363ec42eaad3290d2e6feb8c7d73bbb1
2014-06-03Cleaning up of IDocumentDeviceAccess methods in SwDoc.Valentin Kettner
Moved all SwDoc::getReferenceDevice and SwDoc::setReferenceDevice calls to their appropriate interface methods (SwDoc::getIDocumentDeviceAccess::"). Change-Id: I2a1b488500fa4f0bfbb7ebadccde2c94b70efd85
2014-06-03Removed getVirtualDevice and setVirtualDevice from SwDoc.Valentin Kettner
Nothing else had to be chaned because they werent call from anywhere else. Change-Id: I708b54b909c5a1814bcec858dd356e17e5c6c473
2014-06-03Started cleaning up of IDocumentDeviceAccess methods in SwDoc.Valentin Kettner
Moved all SwDoc::getPrinter and SwDoc::setPrinter calls to their appropriate interface methods (SwDoc::getIDocumenterDeviceAccess::"). Change-Id: Icbe5369ba03a05d9e2afb1300a9c67b0a0a20c60
2014-06-03SwTextBoxHelper::queryInterface: handle css::text::XTextRange as wellMiklos Vajna
Change-Id: If56d7cab269a76062ee75bb1a9484f154b72c4d7
2014-06-03SwXFrame::setPropertyValue: ignore setting ZOrder on TextBoxesMiklos Vajna
The ZOrder of a TextBox should be the ZOrder of the shape + 1, don't allow setting it to something custom. Change-Id: I17439aa9e494ae62ab80e178a8c5d90cea030351
2014-06-03sw: let layout not mark embedded object as modifiedMiklos Vajna
The problem was that right after the import, the document wasn't marked as modified, but as layout settled, it got marked as modified. Given that we already have code to avoid modification when updating the replacement image, do something similar here: when setting the view area, make sure the embedded object's component is not marked as modified. Change-Id: I88a42829ec48db54178553661863a571cd2a268b
2014-06-03sw: fix include guardsThomas Arnhold
after the latest file move Change-Id: I105eb04ad98d1bf71eddec4528657c248fcc4348
2014-06-02coverity#735904 Unchecked dynamic_castMiklos Vajna
Change-Id: I784fa73c69a25ccf5d750b92c6aa8815385df0a9
2014-06-02coverity#704885 Unchecked dynamic_castCaolán McNamara
Change-Id: I748a73523b6b1908d89663e90f7cab378920110d
2014-06-02coverity#1219786 Dereference after null checkCaolán McNamara
Change-Id: I95608ce08b9fffada10bc1a1f6903b50aa78fe9a
2014-06-02Avoid possible memory leaks in case of exceptionsTakeshi Abe
Change-Id: If1057871aa7c9e7079ed051e6854c77c81f12292
2014-06-02SwTextBoxHelper: take care of position after a CustomShapeGeometry changeMiklos Vajna
This is required by the ODF import, as that sets the CustomShapeGeometry after setting other properties (like Transformation, which includes the position/size). Change-Id: I299a1b302d55b3753a0a6b2142ea173f5f134b39
2014-06-02fdo#76934 : DOCX: Preservation: AutoSpacing property not getting preserved.Pallavi Jadhav
Issue : - In styles.xml, beforeAutospacing property was set to true. - In code LO grab bags AustoSpacing property using "ParaInteropGrabBag". - But ParaInteropGrabBag had only an entry for direct paragraph properties, not paragraph styles. - Hence while importing AustoSpacing property from styles.xml, LO was throwing exception as "Some style properties could not be set: Unknown property: ParaInteropGrabBag". Implementation : - Added "ParaInteropGarbBag" entry for Paragraph styles in sw/source/core/unocore/unomap.cxx - Removed code from StyleSheetTable::ApplyStyleSheets() as it was previously added to "Ignore" the AutoSpacing property. The code was previously added beacuse due to AutpSpacing in styles.xml, LO was throwing an exception and this was causing unhandling of properties after AutoSpacing. So to prevent unhandling of other properties due to AutoSpacing property, a check was added to "Ignore" AutoSpacing, thus enabling handling of properties after AutoSpacing. Please refer to : https://gerrit.libreoffice.org/#/c/8902/ But as now we have to "Preserve AutoSpacing" this check needs to be removed in order to set it in StyelSheetTable.cxx. - Added Export Unit test case Change-Id: I6748f97befcdf40643e75388766e05740290306b Reviewed-on: https://gerrit.libreoffice.org/9561 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-06-01sal_uInt16 to size_tMatteo Casalin
Change-Id: Ia8795223224a6d2772f12ad41d7691517db80714
2014-06-01Avoid temporary OUStringsMatteo Casalin
Change-Id: I02f26228f0f9068ce7f497913fb36ac8945e785b
2014-06-01sal_uInt16 to size_t, constifyMatteo Casalin
Change-Id: Ie864814c71a31aaf2b139641bac9bb720143abfe
2014-06-01OUString: avoid temporaries and simplifyMatteo Casalin
Change-Id: I1e131913991f0b28e55e54e8cc64ce37135be946
2014-06-01sal_uInt16 to more proper types + minor optimizationsMatteo Casalin
Change-Id: I8873a1ec910024b6fc25490891dc2e2c8d20d5d1
2014-06-01Group common codeMatteo Casalin
Change-Id: I857366ca2fb6e0e0cb43ff12b161310eab5015f6
2014-06-01OUString: simplify, constify, remove temporariesMatteo Casalin
Change-Id: I7dbba6bfe9f44b28cdf62b1eb4da05eda696d0dd
2014-06-01sal_uInt16 to more proper types, constifyMatteo Casalin
Change-Id: Ic7d9f18e04429c5ccb7b0fad28f3e83aa199897c
2014-06-01Don't re-iterate over string to get consecutive tokensMatteo Casalin
Change-Id: I502cc43c7419301ba0937e495172bc21b609f71a