summaryrefslogtreecommitdiff
path: root/sw/source
AgeCommit message (Collapse)Author
2024-07-30related tdf#160621: request extra height for field value entryOliver Specht
With this, both edit and add fields dialog should look near-identical at this spot (seems extra rows are needed for native dialogs like gtk, while Windows wants the extra height-request). Change-Id: Iafee3d60d33c9eee6020e9ef49aaac900222a0e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170835 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-07-29tdf#161846 use unordered_map in SfxItemPropertyMapNoel Grandin
with large property maps, even a binary search starts showing up, but we can do a O(1) search here by using a map Change-Id: Ie7916076073e6dd393f0a1fb5a0db1b973999408 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171173 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-29use more GetItemSurrogatesForItemNoel Grandin
since it is considerably more efficient Change-Id: I224ff890f6dd52481621b46f912f1e8dbf65126c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171182 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-29tdf#162205 sw: Fix incorrect baseline adjust for vertical bidi portionsJonathan Clark
Bidi portion rendering was performing baseline adjustment twice. This caused vertical left-to-right bidi portions to be rendered to the left of their proper position. Change-Id: Ic5258f58d8c8260194ec5ea0921d72f8dd738556 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171071 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-07-29tdf#158504: fix 'applied' for page stylesBjoern Michaelsen
Here is how checking for a used page style used to work before 140079362502408c75ceee67e86d779f61c0ac1b: - SwDocStyleSheet::IsUsed called SwDoc::IsUsed on the page style - ... that used to call GetInfo on the SwPageDesc - ... which then called GetInfo on Master, Left, ... (SwFrameFormats) - ... which then ends up in a SwPageFrame which confirms the page style to be in use To get this to work again after 140079362502408c75ceee67e86d779f61c0ac1b, one would need to reimplement the forwarding in SwFrameFormat (and the other intermediates). However, instead of replicating that encapsulation breaking maintenance nightmare, we instead: - introduce a properly named SwPageDesc::IsUsed - which directly calls SwFrameFormat::IsUsed - use that in SwDocStyleSheet::IsUsed - and then assert in SwDoc::IsUsed if called on random types (as essentially most of Writer derives from sw::BroadcastingModify in some way) Change-Id: I4ca300af61a1f2af383ef2b7ded32ddbee6ec975 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171088 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-07-28ofz: Null-dereference READCaolán McNamara
Change-Id: I872cd2b0c32f88a5ac09ea3082f05b7d3c41feb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171141 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-07-28cid#1556624 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1556622 COPY_INSTEAD_OF_MOVE cid#1556629 COPY_INSTEAD_OF_MOVE cid#1556632 COPY_INSTEAD_OF_MOVE cid#1556634 COPY_INSTEAD_OF_MOVE cid#1556642 COPY_INSTEAD_OF_MOVE cid#1556644 COPY_INSTEAD_OF_MOVE cid#1556663 COPY_INSTEAD_OF_MOVE cid#1556674 COPY_INSTEAD_OF_MOVE cid#1556682 COPY_INSTEAD_OF_MOVE cid#1556683 COPY_INSTEAD_OF_MOVE cid#1556685 COPY_INSTEAD_OF_MOVE cid#1556694 COPY_INSTEAD_OF_MOVE cid#1556708 COPY_INSTEAD_OF_MOVE cid#1556711 COPY_INSTEAD_OF_MOVE cid#1556712 COPY_INSTEAD_OF_MOVE cid#1556714 COPY_INSTEAD_OF_MOVE cid#1556719 COPY_INSTEAD_OF_MOVE cid#1556727 COPY_INSTEAD_OF_MOVE cid#1556744 COPY_INSTEAD_OF_MOVE cid#1556757 COPY_INSTEAD_OF_MOVE cid#1556782 COPY_INSTEAD_OF_MOVE cid#1556784 COPY_INSTEAD_OF_MOVE Change-Id: I5d5bc884cd7351a81c18b35aaf4e304256242988 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171128 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-07-27Change some string types to avoid unnecessary allocationsMike Kaganski
Change-Id: I45a12adb0d04ea2e048816203a6439692c2372b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171093 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-27HTML/ReqIF export: introduce RelativeOwnObjectURL filter optionMike Kaganski
When the use cases require use of absolute URLs at export (Options-> Load/Save->General, Save URLs relative to file system and Save URLs relative to internet), the fles generated from the document itself (e.g., images that aren't embedded into HTML/ReqIF itself) may still need to be referenced relatively. This introduces the export filter option, named RelativeOwnObjectURL, that overrides the general export settings specifically for these self-generated objects. Change-Id: I09aeb931db5712271a40c683370316783507775a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171083 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-26HTML/ReqIF export: make sure to close input tagsMike Kaganski
Change-Id: If550cb3765f6f3eb6fbf7425061c1cec90f5470f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171082 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-26ofz: ww2 "ClusterFuzz Unreproducible" resetCaolán McNamara
so reenable this and bump up min fuzz length Change-Id: Ic493e1a55899761f6bc88dc7f4b598a82dd00411 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-26sw: use SAL_RET_MAYBENULL in GetTableBox()Xisco Fauli
This could have caught tdf#162180 Change-Id: I71e86b402ae0c603d1c7ace209d55f5808b9ebe2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171054 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-07-26cid#1557746 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1557751 COPY_INSTEAD_OF_MOVE cid#1557771 COPY_INSTEAD_OF_MOVE cid#1557775 COPY_INSTEAD_OF_MOVE cid#1557786 COPY_INSTEAD_OF_MOVE cid#1557787 COPY_INSTEAD_OF_MOVE cid#1557790 COPY_INSTEAD_OF_MOVE cid#1557793 COPY_INSTEAD_OF_MOVE cid#1557794 COPY_INSTEAD_OF_MOVE Change-Id: I1b02b6eca303b1a08975ea8aae7c9dbefbada47f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171061 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-26ofz#70674 Null-dereference READCaolán McNamara
xCursorTunnel.get() is a SvxUnoTextCursor in this case Change-Id: Iaa50a4895923bc1635dc69325203de7bfb77886b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171064 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-26cid#1615138 Use of auto that causes a copyCaolán McNamara
Change-Id: I5752fa3aa4bd67401194dc88aa8bf7b8d8e485c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171055 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-07-25tdf#162180: GetTableBox might return nullptrXisco Fauli
Change-Id: I31091b5bd06ba30a2e9bbddad66c5c597b22a6fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171007 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-07-25tdf#157233 - A11y: Add global Accessibility check options forBalazs Varga
managing which a11y issue should be checked. In default mode all the a11y issues are checked. Change-Id: Ib01e7d76e74b0b9cc9df259295edbee135b1c8a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170324 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-07-25sw: C6011: Dereferencing NULL pointer 'pVSh'Xisco Fauli
Change-Id: Ife344c9d88a68abb784b094152c4c3f9d8ce271d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171016 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-07-25workaround clang-14 bugChristian Lohmaier
affects both macOS XCode 14 as well as the em++ / emsdk clang 14 used by the wasm builder Change-Id: Id3e9a923b7f18ca8d18fd4bc2fd5de83ab3c591f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169031 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2024-07-25tdf#157829 sw: Implemented line break underflow for bidi portionsJonathan Clark
Previously, bidi portions did not handle underflow in word wrapping. This caused bidi portions to break at format changes during wrapping, instead of backtracking to a valid break opportunity. Change-Id: Ib86effe2642a9d133242c28538026d9b4a7e90e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171006 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-07-25force max len for some oss-fuzz fuzzersCaolán McNamara
on a temp basis to reset auto-reporting state Change-Id: I2af7bc6b1e6c2d92ce58f548a28dc76fb0584432 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171002 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-07-25O[U]String overloads that return view for rest parameterNoel Grandin
Add new overloads to OUString methods that have a "OUString* rest" style parameter. Instead return a view, which does not require allocation. To avoid overload ambiguity, split the methods into different variants that do not use default parameters. Change-Id: I1aa366115750f1f7ea4fe665804195f59f7c4b69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167632 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-25tdf#85677: Add support for Windows touch gestures (panning,zooming)Tibor Nagy
Change-Id: Ib0243889621663ddb9b6789ede7643d54f06041e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170988 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2024-07-25tdf#162018 Unexpected loss in focus in the "Manage Changes" windowJim Raykowski
when adding a change in the document (Track changes mode), round 4 Addresses "situation 4" when a new change makes a change to an entire previous change or to multiple previously tracked changes. Change-Id: I02175db6c7bc1258f8e7c05835b05ff79b7d7b83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170984 Reviewed-by: Jim Raykowski <raykowj@gmail.com> Tested-by: Jenkins
2024-07-25related tdf#161717 Use a better approach to determine RedlinDataJim Raykowski
::pData type Casting a void* RedlineData::pDate to either a SwRedlineDataParent* or SwRedlineDataChild* works because of the order and variable types declared in the SwRedlineDataChild and SwRedlineDataParent classes match until an OUString is declared in SwRedlineDataParent. That explains why the non-patched code behaves as expected even though testing if the entry has children to determine which cast to do is flawed. Better is to test the iterator depth which is what this patch does. Change-Id: I24ca0990a4edbd50a7e3dc5d0be4c5312c240921 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170860 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-07-25tdf#160163 reset placeholder in Text field when emptyJuergen Funk
for all the Text field made a global define of the NonBreakSpaces mask Change-Id: I7107f941ee9008415325aefe5487555d91dbf1ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170596 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-07-24cid#1556131 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1556135 COPY_INSTEAD_OF_MOVE cid#1556146 COPY_INSTEAD_OF_MOVE cid#1556164 COPY_INSTEAD_OF_MOVE cid#1556171 COPY_INSTEAD_OF_MOVE cid#1556177 COPY_INSTEAD_OF_MOVE cid#1556181 COPY_INSTEAD_OF_MOVE cid#1556182 COPY_INSTEAD_OF_MOVE cid#1556183 COPY_INSTEAD_OF_MOVE cid#1556192 COPY_INSTEAD_OF_MOVE cid#1556201 COPY_INSTEAD_OF_MOVE cid#1556208 COPY_INSTEAD_OF_MOVE cid#1556215 COPY_INSTEAD_OF_MOVE cid#1556224 COPY_INSTEAD_OF_MOVE cid#1556227 COPY_INSTEAD_OF_MOVE cid#1556228 COPY_INSTEAD_OF_MOVE cid#1556238 COPY_INSTEAD_OF_MOVE cid#1556246 COPY_INSTEAD_OF_MOVE cid#1556247 COPY_INSTEAD_OF_MOVE cid#1556288 COPY_INSTEAD_OF_MOVE cid#1556293 COPY_INSTEAD_OF_MOVE cid#1556305 COPY_INSTEAD_OF_MOVE cid#1556310 COPY_INSTEAD_OF_MOVE cid#1556317 COPY_INSTEAD_OF_MOVE cid#1556321 COPY_INSTEAD_OF_MOVE cid#1556322 COPY_INSTEAD_OF_MOVE cid#1556331 COPY_INSTEAD_OF_MOVE cid#1556339 COPY_INSTEAD_OF_MOVE cid#1556342 COPY_INSTEAD_OF_MOVE cid#1556351 COPY_INSTEAD_OF_MOVE cid#1556358 COPY_INSTEAD_OF_MOVE cid#1556370 COPY_INSTEAD_OF_MOVE cid#1556379 COPY_INSTEAD_OF_MOVE cid#1556390 COPY_INSTEAD_OF_MOVE cid#1556423 COPY_INSTEAD_OF_MOVE cid#1556532 COPY_INSTEAD_OF_MOVE cid#1556561 COPY_INSTEAD_OF_MOVE cid#1556662 COPY_INSTEAD_OF_MOVE cid#1556704 COPY_INSTEAD_OF_MOVE cid#1556730 COPY_INSTEAD_OF_MOVE cid#1556988 COPY_INSTEAD_OF_MOVE cid#1557071 COPY_INSTEAD_OF_MOVE cid#1557081 COPY_INSTEAD_OF_MOVE cid#1557177 COPY_INSTEAD_OF_MOVE Change-Id: I2c723f0fe9a4eefa62a68f47049ed690d06eb0ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170932 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-24tdf#157952 sw content controls, drop-down: remove when obsoleteJustin Luth
One place that was missed was when moving from one content control to another (for example, using the tab key). Change-Id: I62a3af2a5a7036aaac605d592c244a58f5b65a12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170967 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2024-07-24tdf#138093 tdf#131722 docx import: sdt lost first date character #2Justin Luth
While GetIsDummyParaAddedForTableInSection() is true for the entire section, it should only be used against GetIsFirstParagraphInSection() where the dummy para exists. make CppunitTest_sw_ooxmlexport19 CPPUNIT_TEST_NAME=testTdf138093B Change-Id: I457c0aa25eb7bd086c5c15bd889d9cd89c51db95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170921 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2024-07-24tdf#158661 docx import plaintext sdt: remove unnecessary goRightJustin Luth
This fixes a 24.2 regression from commit 5082d50d24c3fec4487c724a15eb0d54a82ecd0d writerfilter: use content controls for text in block SDTs which was made even worse with 24.2 commit 7c4dba1deffd81f647a4a3be7a79f68f3bf9f1ba. Initially, the starting mark was made as soon as SdtContent was seen. After that, you could get a w:tbl, or a w:tc which could trigger the start of a table, and potentially add a dummy paragraph which needed to be jumped over (at least for the first SDT, but not for subsequent SDTs). In the second patch, the starting mark was made just before the text was appended, so all of the cell/table creation has already been completed, so there is no more need to jump over any dummy paragraphs, even for the first table. Affected unit tests were - table-start-2-sdt.docx - sdt-company-multipara.docx - paragraph-sdt.docx make CppunitTest_sw_ooxmlfieldexport CPPUNIT_TEST_NAME=testParagraphSdt make CppunitTest_sw_ooxmlfieldexport \ CPPUNIT_TEST_NAME=testTdf158661_blockSDT Change-Id: I4a8359cec27f88f6a2fc0464aa240b523a279e42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170920 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-07-23cid#1555167 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1555172 COPY_INSTEAD_OF_MOVE cid#1555184 COPY_INSTEAD_OF_MOVE cid#1555188 COPY_INSTEAD_OF_MOVE cid#1555197 COPY_INSTEAD_OF_MOVE cid#1555209 COPY_INSTEAD_OF_MOVE cid#1555211 COPY_INSTEAD_OF_MOVE cid#1555215 COPY_INSTEAD_OF_MOVE cid#1555216 COPY_INSTEAD_OF_MOVE cid#1555217 COPY_INSTEAD_OF_MOVE cid#1555218 COPY_INSTEAD_OF_MOVE cid#1555222 COPY_INSTEAD_OF_MOVE cid#1556674 COPY_INSTEAD_OF_MOVE cid#1555229 COPY_INSTEAD_OF_MOVE cid#1555233 COPY_INSTEAD_OF_MOVE cid#1555234 COPY_INSTEAD_OF_MOVE cid#1555242 COPY_INSTEAD_OF_MOVE cid#1555250 COPY_INSTEAD_OF_MOVE cid#1555251 COPY_INSTEAD_OF_MOVE cid#1555254 COPY_INSTEAD_OF_MOVE cid#1555304 COPY_INSTEAD_OF_MOVE cid#1555307 COPY_INSTEAD_OF_MOVE cid#1555317 COPY_INSTEAD_OF_MOVE cid#1555329 COPY_INSTEAD_OF_MOVE cid#1555340 COPY_INSTEAD_OF_MOVE cid#1555347 COPY_INSTEAD_OF_MOVE cid#1555352 COPY_INSTEAD_OF_MOVE cid#1555358 COPY_INSTEAD_OF_MOVE cid#1555363 COPY_INSTEAD_OF_MOVE cid#1555365 COPY_INSTEAD_OF_MOVE cid#1555367 COPY_INSTEAD_OF_MOVE cid#1555374 COPY_INSTEAD_OF_MOVE cid#1555380 COPY_INSTEAD_OF_MOVE Change-Id: I343194c10749488a1143e2517ee0638ab19da218 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170888 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-23related tdf#160817 SwNavigator: update content functions toolbarJim Raykowski
on right-click selection of entry to show context menu for Change-Id: I045bd02103a37c94d6eb3fc1885ab19de79685c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170885 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-07-23Resolves tdf#162018 Unexpected loss in focus in the "Manage Changes"Jim Raykowski
window when adding a change in the document (Track changes mode), round 3 Done to address loss of selection when an entry is added to the beginning of the changes list. The patch reworks round 1 and 2 to handle any entry insert position. It also keeps the selected entry selected after a sort by document order. Change-Id: Icb6f6b6b80ad9ddc5d008a00d195ceb7c1d6dc3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170828 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-07-23cid#1555070 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1555069 COPY_INSTEAD_OF_MOVE cid#1555128 COPY_INSTEAD_OF_MOVE cid#1555131 COPY_INSTEAD_OF_MOVE cid#1555137 COPY_INSTEAD_OF_MOVE cid#1555142 COPY_INSTEAD_OF_MOVE cid#1555152 COPY_INSTEAD_OF_MOVE cid#1555154 COPY_INSTEAD_OF_MOVE cid#1555161 COPY_INSTEAD_OF_MOVE cid#1555163 COPY_INSTEAD_OF_MOVE Change-Id: I86a5b7049ac8f31ca703add11381f5293233d9d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170863 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-22crashtesting tdf135164-3.docxNoel Grandin
./instdir/program/soffice --headless --convert-to odt ~/Downloads/tdf135164-3.docx fails after commit f98f684d22e6323185104ca9c082241c53dfc2b3 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Sat Jul 13 18:50:34 2024 +0200 remove RecalcObjOrdNums in DoTextBoxZOrderCorrection add a check to catch this case and flatten the method to make it more readable Change-Id: I7827807c77f51b28f16b1042b77b8211ab5416ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170839 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-22no need to dynamic_cast when using GetItemSurrogatesNoel Grandin
since the items returned are guaranteed to be of the right type Change-Id: I7912c0ec171b4617a7ac393786f553a1f0b6c78e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170836 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-22speed up O(n^2) loop in UpdateFieldContentsNoel Grandin
Change-Id: I53af2d1af22ed58acd384d33396e517d8a395f17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170834 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-22Revert "improve perf of lcl_GetUniqueFlyName"Noel Grandin
This reverts commit a61128c95e324b096bf26fec5ad78e67567e0f82. Reason for revert: Causes trouble with UITests because the names of some objects are not predictable Change-Id: I6320efd694849542ae79f0dc67c15d35eedfb750 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170742 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-22Resolves tdf#159541 - Fix font color must not change depending on backgroundHeiko Tietze
Change-Id: I954c9e3f8502a5243c664ed0bf066fb4c4cb4ccc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169991 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-22add a static_assert for sizes of m_nFieldTagAlways and m_nFieldTagBadCaolán McNamara
Change-Id: I4d847c74d8d069c76f874a19e6fbc99425757a44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170837 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-22Improve the perf for pool item scanning..Noel Grandin
for large complex documents with lots of shapes. When that happens, we spend a lot of time scanning the std::unordered_set inside DefaultItemInstanceManager. Since most of our items are already capable of being hashed, and thus avoiding the scanning cost, make it so we can use the HashableItemInstanceManager most of the time. Change-Id: I43f4c04e956d316c976bea67d1941529d2d91182 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170813 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Tested-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-22cid#1608424 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1607592 COPY_INSTEAD_OF_MOVE cid#1607487 COPY_INSTEAD_OF_MOVE cid#1607480 COPY_INSTEAD_OF_MOVE cid#1607444 COPY_INSTEAD_OF_MOVE cid#1607369 COPY_INSTEAD_OF_MOVE cid#1607356 COPY_INSTEAD_OF_MOVE cid#1607342 COPY_INSTEAD_OF_MOVE cid#1607329 COPY_INSTEAD_OF_MOVE cid#1607327 COPY_INSTEAD_OF_MOVE cid#1607303 COPY_INSTEAD_OF_MOVE cid#1607284 COPY_INSTEAD_OF_MOVE Change-Id: Ia2d5d4e2de8ca96a9557df5266754e52efa4f60e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170826 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-22drawpage::getCount is expensiveNoel Grandin
so only call it once at the start of the loop. Shaves 1% off the cost of loading complex documents with lots of shapes. Change-Id: Ieb985b2523f6b4db3313eb000cf64e9c689e65c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170820 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-21cid#1556239 Use of auto that causes a copyCaolán McNamara
and cid#1557287 Use of auto that causes a copy cid#1558003 Use of auto that causes a copy cid#1557568 Use of auto that causes a copy cid#1556546 Use of auto that causes a copy cid#1557377 Use of auto that causes a copy cid#1608325 Use of auto that causes a copy Change-Id: I84e59d2b14bb1e5856f9cac521ad6542b1784243 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170821 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-07-21cid#1606961 silence Overflowed array index readCaolán McNamara
and cid#1606751 Overflowed array index read Change-Id: If9681a61b14b68e6d1f12b0d4907ab23180972f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170819 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-21improve perf of lcl_GetUniqueFlyNameNoel Grandin
reduces the load time of a complex document from 18s to 16s Change-Id: I5382e27bf1b6beaf7276ef46f10d43d5bf9822d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170795 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-20cid#1554791 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1554819 COPY_INSTEAD_OF_MOVE cid#1554837 COPY_INSTEAD_OF_MOVE cid#1554881 COPY_INSTEAD_OF_MOVE cid#1554882 COPY_INSTEAD_OF_MOVE cid#1554884 COPY_INSTEAD_OF_MOVE cid#1554891 COPY_INSTEAD_OF_MOVE cid#1554892 COPY_INSTEAD_OF_MOVE cid#1554897 COPY_INSTEAD_OF_MOVE cid#1554904 COPY_INSTEAD_OF_MOVE cid#1554918 COPY_INSTEAD_OF_MOVE cid#1554928 COPY_INSTEAD_OF_MOVE cid#1554931 COPY_INSTEAD_OF_MOVE cid#1554944 COPY_INSTEAD_OF_MOVE cid#1554945 COPY_INSTEAD_OF_MOVE cid#1554959 COPY_INSTEAD_OF_MOVE cid#1554960 COPY_INSTEAD_OF_MOVE cid#1554963 COPY_INSTEAD_OF_MOVE cid#1554966 COPY_INSTEAD_OF_MOVE cid#1554969 COPY_INSTEAD_OF_MOVE cid#1554973 COPY_INSTEAD_OF_MOVE cid#1555011 COPY_INSTEAD_OF_MOVE cid#1555012 COPY_INSTEAD_OF_MOVE cid#1555015 COPY_INSTEAD_OF_MOVE cid#1555044 COPY_INSTEAD_OF_MOVE cid#1555051 COPY_INSTEAD_OF_MOVE cid#1555055 COPY_INSTEAD_OF_MOVE cid#1555063 COPY_INSTEAD_OF_MOVE cid#1555068 COPY_INSTEAD_OF_MOVE cid#1555073 COPY_INSTEAD_OF_MOVE cid#1555074 COPY_INSTEAD_OF_MOVE cid#1555078 COPY_INSTEAD_OF_MOVE cid#1555080 COPY_INSTEAD_OF_MOVE cid#1555091 COPY_INSTEAD_OF_MOVE cid#1555099 COPY_INSTEAD_OF_MOVE cid#1555101 COPY_INSTEAD_OF_MOVE cid#1555121 COPY_INSTEAD_OF_MOVE cid#1610739 COPY_INSTEAD_OF_MOVE cid#1608424 COPY_INSTEAD_OF_MOVE cid#1608059 COPY_INSTEAD_OF_MOVE cid#1607952 COPY_INSTEAD_OF_MOVE cid#1607653 COPY_INSTEAD_OF_MOVE cid#1607614 COPY_INSTEAD_OF_MOVE cid#1607592 COPY_INSTEAD_OF_MOVE Change-Id: Ie9f922a9fe1b8001dfab31e2741fe8bd5558e442 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170802 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-20cid#1610739 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: I618fbda65c66985c3179578d1fa106514c5aef30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170800 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-07-20Resolves tdf#162018 Unexpected loss in focus in the "Manage Changes"Jim Raykowski
window when adding a change in the document (Track changes mode), round 2 Addresses two situations where the list still jumps to the top: Situation 1: When an entry is added to the end of the changes list. Situation 2: After editing a comment for a change list entry with the 'Comment' dialog. Change-Id: I4a75e6bcba13fb9cc735cf78756fe736b9d4665d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170598 Reviewed-by: Jim Raykowski <raykowj@gmail.com> Tested-by: Jenkins
2024-07-20cid#1607830 Use of auto that causes a copyCaolán McNamara
and cid#1607722 Use of auto that causes a copy cid#1557606 Use of auto that causes a copy cid#1557569 Use of auto that causes a copy cid#1556239 Use of auto that causes a copy cid#1556043 Use of auto that causes a copy cid#1554961 Use of auto that causes a copy cid#1554818 Use of auto that causes a copy Change-Id: I9f74c7bc4da2c6b1df80d0fb4504dd4d03eb1053 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170784 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-11 06:51:33 +0000