summaryrefslogtreecommitdiff
path: root/sw/source
AgeCommit message (Collapse)Author
2017-11-22Missing GraphicObject destruction, memory leakStephan Bergmann
...causes e.g. a leftover temp file like _anonymous_namespace___WpftWriterFilterTest__test_9m9gdo.tmp in $TMPDIR during CppunitTest_writerperfect_writer's processing of writerperfect/qa/unit/data/writer/libwps/Write_3.1.wri. The code lacking the delete was originally introduced with e3911a61e60610d32d4f41ab0361ff495bbf3f95 "INTEGRATION: CWS fwk59: #i63867# let the replacement image be imported", then heavily modified with ec8258f3b78f6bc00a108fe0bef7656b86812b7d "INTEGRATION: CWS xmlfilter06". Change-Id: Ie0830d5f358e6d81efe0bb9ef04d6a206bd27201 Reviewed-on: https://gerrit.libreoffice.org/45059 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-22RTF filter: drop now redundant astyle.optionsMiklos Vajna
I (tried to) keep the RTF filter style consistent locally with astyle in the past, but now that's redundant when we have an enforcing clang-format mechanism in place. So drop the astyle config and switch to clang-format in the RTF filter case. To minimize backport pain, do this shortly before the libreoffice-6-0 branch-off. Change-Id: I708dbeb0b5ad2afacc90029ee5abba9495f4601f
2017-11-22tdf#86087 fix relative link open on linuxSzymon Kłos
Change-Id: I6bf2d6bd50b9f1ed7a2c3f66fc18598aa7ffe3d6 Reviewed-on: https://gerrit.libreoffice.org/45053 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-22Fix typoAndrea Gelmini
Change-Id: I591214b246f7702e52f71b95cdc2255bc296224b Reviewed-on: https://gerrit.libreoffice.org/45063 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-22TypedWhichId for SDRATTR* constants (3)Noel Grandin
Change-Id: Iea72cb3a4bbf693096de46269f58259b5952eedb Reviewed-on: https://gerrit.libreoffice.org/45024 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22loplugin:simplifybool re-activate the !! warningNoel Grandin
Change-Id: Iac7d82a1c228734177be536e9a6c41803c03637b Reviewed-on: https://gerrit.libreoffice.org/45035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-21coverity warningsCaolán McNamara
Change-Id: I456210188ab96e6be03e65c94eedb348cc93a8e1 Reviewed-on: https://gerrit.libreoffice.org/45023 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-21another expected exception in initial corpusCaolán McNamara
Change-Id: I5f804cd6dd844bc82d4afadc4bb835ca0d77a53e
2017-11-21don't abort on expected exceptionCaolán McNamara
oxymoronic I know Change-Id: Ie51c3e8995c53eaaac0a3a4f6e3582c7b38da823 Reviewed-on: https://gerrit.libreoffice.org/45041 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-21add docx support to fftesterCaolán McNamara
Change-Id: Ia761e23c011c53f8f786ac336efd4b9e94fc6e35 Reviewed-on: https://gerrit.libreoffice.org/45033 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-21ofz#4306 Infinite-LoopCaolán McNamara
Change-Id: Ie52fdbe8d4a6b0432ed8e4d083a718f225e4e326 Reviewed-on: https://gerrit.libreoffice.org/45025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-21tdf#106988 Change default numbering list stylesYousuf Philips
Change-Id: I0b69c2cb7bbf169e208d7a3d15c93b4c3cf9716b Reviewed-on: https://gerrit.libreoffice.org/37742 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-11-21loplugin:flatten in swNoel Grandin
Change-Id: I64176f48d90303f078e326c8838da9eb2daf8126 Reviewed-on: https://gerrit.libreoffice.org/44937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-21coverity#1422233 Unchecked return valueCaolán McNamara
Change-Id: I85699e57b5e59231d9568db8a56244f41f5359aa
2017-11-21tdf#86087 don't decode linksSzymon Kłos
Example of link causing problems: "file:///foo#bar" Change-Id: Ifb781c27c3b9726ba262f10cf07c13cfd889dcd3 Reviewed-on: https://gerrit.libreoffice.org/45010 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-21Fix typosAndrea Gelmini
Change-Id: I40b3a46d46f0586d086bdbe41876c088f8c1cb58 Reviewed-on: https://gerrit.libreoffice.org/45007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-21Avoid static_cast on dead SwVirtFlyDrawObj object for nowStephan Bergmann
...in SwFlyFrame::GetVirtDrawObj (sw/source/core/layout/fly.cxx) after 487ac20ecd73cf3d98071ba30cf5597d957017f7 "RotateFlyFrame3: add support for AutoContour" added this code, which causes at least UBSan (e.g., during CppunitTest_sw_rtfimport) to produce errors (starting with <https://ci.libreoffice.org/job/lo_ubsan/733/console>). There appear to be no negative consequences across 'make check' with this code disabled, so do that for now to unblock UBSan builds, until a real fix is provided. The backtrace of the bad static_cast on dead SwVirtFlyDrawObj is > SwFlyFrame::GetVirtDrawObj() (/sw/source/core/layout/fly.cxx:2599) > SwFlyFreeFrame::~SwFlyFreeFrame() (/sw/source/core/layout/flylay.cxx:93) > SwFlyAtContentFrame::~SwFlyAtContentFrame() (/sw/source/core/inc/flyfrms.hxx:161) > SwFlyAtContentFrame::~SwFlyAtContentFrame() (/sw/source/core/inc/flyfrms.hxx:161) > SwFrame::DestroyFrame(SwFrame*) (/sw/source/core/layout/ssfrm.cxx:431) > SwLayoutFrame::DestroyImpl() (/sw/source/core/layout/ssfrm.cxx:517) > SwFrame::DestroyFrame(SwFrame*) (/sw/source/core/layout/ssfrm.cxx:429) > SwLayoutFrame::DestroyImpl() (/sw/source/core/layout/ssfrm.cxx:540) > SwPageFrame::DestroyImpl() (/sw/source/core/layout/pagechg.cxx:295) > SwFrame::DestroyFrame(SwFrame*) (/sw/source/core/layout/ssfrm.cxx:429) > SwLayoutFrame::DestroyImpl() (/sw/source/core/layout/ssfrm.cxx:540) > SwRootFrame::DestroyImpl() (/sw/source/core/layout/newfrm.cxx:621) > SwFrame::DestroyFrame(SwFrame*) (/sw/source/core/layout/ssfrm.cxx:429) > std::_Sp_counted_deleter<SwRootFrame*, void (*)(SwFrame*), std::allocator<void>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() (/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:470) > std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() (/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:154) > std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count() (/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:684) > std::__shared_ptr<SwRootFrame, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr() (/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:1123) > std::shared_ptr<SwRootFrame>::~shared_ptr() (/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr.h:93) > SwViewShell::~SwViewShell() (/sw/source/core/view/vnew.cxx:364) > SwCursorShell::~SwCursorShell() (/sw/source/core/crsr/crsrsh.cxx:2743) > SwEditShell::~SwEditShell() (/sw/source/core/edit/edws.cxx:64) > SwFEShell::~SwFEShell() (/sw/source/core/frmedt/fews.cxx:700) > SwWrtShell::~SwWrtShell() (/sw/source/uibase/wrtsh/wrtsh1.cxx:1662) > SwWrtShell::~SwWrtShell() (/sw/source/uibase/wrtsh/wrtsh1.cxx:1655) > SwView::~SwView() (/sw/source/uibase/uiview/view.cxx:1045) > SwView::~SwView() (/sw/source/uibase/uiview/view.cxx:1011) > SfxViewFrame::ReleaseObjectShell_Impl() (/sfx2/source/view/viewfrm.cxx:992) > SfxViewFrame::~SfxViewFrame() (/sfx2/source/view/viewfrm.cxx:1363) > SfxViewFrame::~SfxViewFrame() (/sfx2/source/view/viewfrm.cxx:1357) > SfxViewFrame::Close() (/sfx2/source/view/viewfrm.cxx:1044) > SfxFrame::DoClose_Impl() (/sfx2/source/view/frame.cxx:155) > SfxBaseController::dispose() (/sfx2/source/view/sfxbasecontroller.cxx:1003) > (anonymous namespace)::Frame::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) (/framework/source/services/frame.cxx:1474) > (anonymous namespace)::Frame::close(unsigned char) (/framework/source/services/frame.cxx:1681) > SfxFrame::DoClose() (/sfx2/source/view/frame.cxx:121) > SfxViewFrame::Notify(SfxBroadcaster&, SfxHint const&) (/sfx2/source/view/viewfrm.cxx:1251) > SfxBroadcaster::Broadcast(SfxHint const&) (/svl/source/notify/SfxBroadcaster.cxx:49) > SfxModelListener_Impl::notifyClosing(com::sun::star::lang::EventObject const&) (/sfx2/source/doc/objxtor.cxx:167) > SfxBaseModel::close(unsigned char) (/sfx2/source/doc/sfxbasemodel.cxx:1348) > SwXTextDocument::close(unsigned char) (/sw/source/uibase/uno/unotxdoc.cxx:623) > SfxBaseModel::dispose() (/sfx2/source/doc/sfxbasemodel.cxx:722) > SwXTextDocument::dispose() (/sw/source/uibase/uno/unotxdoc.cxx:615) > SwModelTestBase::tearDown() (/sw/qa/extras/inc/swmodeltestbase.hxx:206) > CppUnit::TestCaller<testN695479>::tearDown() (/workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:185) > CppUnit::TestCaseMethodFunctor::operator()() const (/workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32) > (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (/test/source/vclbootstrapprotector.cxx:39) > CppUnit::ProtectorChain::ProtectFunctor::operator()() const (/workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20) > (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (/unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89) > CppUnit::ProtectorChain::ProtectFunctor::operator()() const (/workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20) > (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (/unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63) and the backtrace of the destruction of that SwVirtFlyDrawObj object is > operator delete(void*) (/builddir/build/BUILD/valgrind-3.13.0/coregrind/m_replacemalloc/vg_replace_malloc.c:576) > SwVirtFlyDrawObj::~SwVirtFlyDrawObj() (/sw/source/core/draw/dflyobj.cxx:433) > SwFlyFrame::FinitDrawObj() (/sw/source/core/layout/fly.cxx:379) > SwFlyFrame::DestroyImpl() (/sw/source/core/layout/fly.cxx:277) > SwFlyFreeFrame::DestroyImpl() (/sw/source/core/layout/flylay.cxx:87) > SwFrame::DestroyFrame(SwFrame*) (/sw/source/core/layout/ssfrm.cxx:429) > SwLayoutFrame::DestroyImpl() (/sw/source/core/layout/ssfrm.cxx:517) > SwFrame::DestroyFrame(SwFrame*) (/sw/source/core/layout/ssfrm.cxx:429) > SwLayoutFrame::DestroyImpl() (/sw/source/core/layout/ssfrm.cxx:540) > SwPageFrame::DestroyImpl() (/sw/source/core/layout/pagechg.cxx:295) > SwFrame::DestroyFrame(SwFrame*) (/sw/source/core/layout/ssfrm.cxx:429) > SwLayoutFrame::DestroyImpl() (/sw/source/core/layout/ssfrm.cxx:540) > SwRootFrame::DestroyImpl() (/sw/source/core/layout/newfrm.cxx:621) > SwFrame::DestroyFrame(SwFrame*) (/sw/source/core/layout/ssfrm.cxx:429) > std::_Sp_counted_deleter<SwRootFrame*, void (*)(SwFrame*), std::allocator<void>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() (/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:470) > std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() (/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:154) > std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count() (/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:684) > std::__shared_ptr<SwRootFrame, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr() (/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:1123) > std::shared_ptr<SwRootFrame>::~shared_ptr() (/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr.h:93) > SwViewShell::~SwViewShell() (/sw/source/core/view/vnew.cxx:364) > SwCursorShell::~SwCursorShell() (/sw/source/core/crsr/crsrsh.cxx:2743) > SwEditShell::~SwEditShell() (/sw/source/core/edit/edws.cxx:64) > SwFEShell::~SwFEShell() (/sw/source/core/frmedt/fews.cxx:700) > SwWrtShell::~SwWrtShell() (/sw/source/uibase/wrtsh/wrtsh1.cxx:1662) > SwWrtShell::~SwWrtShell() (/sw/source/uibase/wrtsh/wrtsh1.cxx:1655) > SwView::~SwView() (/sw/source/uibase/uiview/view.cxx:1045) > SwView::~SwView() (/sw/source/uibase/uiview/view.cxx:1011) > SfxViewFrame::ReleaseObjectShell_Impl() (/sfx2/source/view/viewfrm.cxx:992) > SfxViewFrame::~SfxViewFrame() (/sfx2/source/view/viewfrm.cxx:1363) > SfxViewFrame::~SfxViewFrame() (/sfx2/source/view/viewfrm.cxx:1357) > SfxViewFrame::Close() (/sfx2/source/view/viewfrm.cxx:1044) > SfxFrame::DoClose_Impl() (/sfx2/source/view/frame.cxx:155) > SfxBaseController::dispose() (/sfx2/source/view/sfxbasecontroller.cxx:1003) > (anonymous namespace)::Frame::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) (/framework/source/services/frame.cxx:1474) > (anonymous namespace)::Frame::close(unsigned char) (/framework/source/services/frame.cxx:1681) > SfxFrame::DoClose() (/sfx2/source/view/frame.cxx:121) > SfxViewFrame::Notify(SfxBroadcaster&, SfxHint const&) (/sfx2/source/view/viewfrm.cxx:1251) > SfxBroadcaster::Broadcast(SfxHint const&) (/svl/source/notify/SfxBroadcaster.cxx:49) > SfxModelListener_Impl::notifyClosing(com::sun::star::lang::EventObject const&) (/sfx2/source/doc/objxtor.cxx:167) > SfxBaseModel::close(unsigned char) (/sfx2/source/doc/sfxbasemodel.cxx:1348) > SwXTextDocument::close(unsigned char) (/sw/source/uibase/uno/unotxdoc.cxx:623) > SfxBaseModel::dispose() (/sfx2/source/doc/sfxbasemodel.cxx:722) > SwXTextDocument::dispose() (/sw/source/uibase/uno/unotxdoc.cxx:615) > SwModelTestBase::tearDown() (/sw/qa/extras/inc/swmodeltestbase.hxx:206) > CppUnit::TestCaller<testN695479>::tearDown() (/workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:185) > CppUnit::TestCaseMethodFunctor::operator()() const (/workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32) > (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (/test/source/vclbootstrapprotector.cxx:39) > CppUnit::ProtectorChain::ProtectFunctor::operator()() const (/workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20) > (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (/unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89) > CppUnit::ProtectorChain::ProtectFunctor::operator()() const (/workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20) Change-Id: Ida6e66c3bc8f85c9cbe60a33aaf40f5e83f16212 Reviewed-on: https://gerrit.libreoffice.org/44976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-21TypedWhichId for SDRATTR* constants (2)Noel Grandin
Change-Id: I9926d55568f8b5bbc67f448bbf7fb660e74505fd Reviewed-on: https://gerrit.libreoffice.org/44964 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-21Fix typosAndrea Gelmini
Change-Id: Ifd95ada4477d7d21ffbadd355226f91f2a2371e1 Reviewed-on: https://gerrit.libreoffice.org/45004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-20SwDBManager: move implementation details from interfaceMike Kaganski
Change-Id: I738e8306f2f9af7f284cc236d55f5e184e632323 Reviewed-on: https://gerrit.libreoffice.org/44951 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-20Disabled slot with Put leaks entry (StateFormatPaintbrush/sw)Julien Nabet
Same as https://cgit.freedesktop.org/libreoffice/core/commit/?id=21dde7a09e2cfe7b48d2fec1edc7a94fa94af5c3 Change-Id: I670c01eb5e5e747ceb77995ad855ee448faa054f Reviewed-on: https://gerrit.libreoffice.org/44931 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-20ofz#4327 Integer-overflowCaolán McNamara
Change-Id: I1a656c106b5944578c6c74b9e475349259865049 Reviewed-on: https://gerrit.libreoffice.org/44948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-20cosmetics: Drop duplicate semicolonTakeshi Abe
Change-Id: I96d2ffb903f9ed15070572552c9564b5089df12f Reviewed-on: https://gerrit.libreoffice.org/44914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-20look for =() in loplugin:unnecessaryparenNoel Grandin
Change-Id: I4f9b71ff7767e90987bb40358fc46ed5d1d571d0 Reviewed-on: https://gerrit.libreoffice.org/44944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-20TypedWhichId for SDRATTR* constants (1)Noel Grandin
Change-Id: I29bd18fea4dea531ae84ebc024d2aa87a5c7004d Reviewed-on: https://gerrit.libreoffice.org/44943 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-20sw: prefix members of SwFieldMgrMiklos Vajna
Change-Id: I330ec974d1f469f4068bf0fc4dba33c99c5894db Reviewed-on: https://gerrit.libreoffice.org/44942 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-20TypedWhichId for XATTR* constantsNoel Grandin
Change-Id: Ie9d637d701b77a549de3b00956f9c74ee8bd08c1 Reviewed-on: https://gerrit.libreoffice.org/44830 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-19Typo "Rigth_" -> "Right_"Julien Nabet
Change-Id: Ibe981b178f8282ebf481411c7b2b3473b72cb69b Reviewed-on: https://gerrit.libreoffice.org/44934 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-19Fix typosAndrea Gelmini
Change-Id: I964528cf4f3b81230c683011e1878b28378b0014 Reviewed-on: https://gerrit.libreoffice.org/44915 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-19tdf#86087 Save relative links in DOCXSzymon Kłos
Save links depending on preferences set Options -> Load/Save -> General -> Save URLs relative to ... Change-Id: I96d06cfdc405d1e1254515106926374aee279f6c Reviewed-on: https://gerrit.libreoffice.org/44785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-19Typos about "bottom"Julien Nabet
Change-Id: I8fec1f12d5f8330cd54da3e219268bf4e0b4c213 Reviewed-on: https://gerrit.libreoffice.org/44932 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-19clang-tidy modernize-use-equals-default in sw/source/uibaseJochen Nitschke
removing unused assignment operators for SwDocDisplayItem, SwElemItem and SwShadowCursorItem, which are implicitly deleted now. Change-Id: I25200c3c61b77c5dedf7cf9de3edabc9d1e68730 Reviewed-on: https://gerrit.libreoffice.org/44928 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-19tdf#86087 Open relative links in WriterSzymon Kłos
Change-Id: I3f6caad559d92ec559b8ae1c66e7fea13f52cb76 Reviewed-on: https://gerrit.libreoffice.org/44734 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-19Reuse already existing valueMike Kaganski
Change-Id: I996cd76b55265e783f51573b6d67b0c0187427c8 Reviewed-on: https://gerrit.libreoffice.org/44924 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-18silence some coverity warningsCaolán McNamara
Change-Id: I5a530e37156b5cd36e8a07ac20851880a46f520d Reviewed-on: https://gerrit.libreoffice.org/44875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-18One more proper construction of vnd.sun.star.pkg URLMike Kaganski
Change-Id: I4b1bfc9c9b158506424ec0b5e2fd71c6ccb7d3ec Reviewed-on: https://gerrit.libreoffice.org/44917 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-18RotateFlyFrame3: Corrected wrong static_castArmin Le Grand
Change-Id: Ia3e0748d0b4ba11ec84a85e823472cdac9bf987a
2017-11-18RotateFlyFrame3: add support for AutoContourArmin Le Grand
For transformed FlyFrames with no Border and no Padding it would be nice to immediately start using AutoContour, added first implementation to do so. Added several conditions for AutoContour, need to work on reaction on changes to these. Corrected needed transform adaptions to Contour(s) Change-Id: Ia3d7845fd5d50c8a413d592ae07ce2041ccc91b9
2017-11-18RotateFlyFrame3: Corrected Contour when rotatedArmin Le Grand
When rotated, the contour has to be adapted to that state and also needs to be calculated in untransformed state, added needed code. Also need to add a ClipRegion set at the target OutputDevice (e.g. from Contour) to the prepared GraphicPrimitive. It was sometimes used due to a VCL_Based PrimitiveRenderer being used, but that is just a coincidence. Change-Id: I1888ecd0468243bf2f41233b0cb3f99a50ac9805
2017-11-18RotateFlyFrame3: Corrected interactive CropArmin Le Grand
To correct interactive Crop in transformed states, I had to rework some stuff involved that anyways was in a non optimal state. Added functionality to translate the object to make Crop seem to work more seamlessly. Some mapping was needed to make the Cropped, transformed object to be in the correct relative position to the uncropped, untransfomed one. Restructured TransformableSwFrame to directly re-create last non-transformed SwFrame(s) from the SwFrameAreaDefinition from the current Transformations, offering the untransformed SwRect(s) now for usage. Identified and corrected error when FlyFrame was translated using keyboard, the accessing method needed to adapt position in the transformed case. Started to look at Contour stuff, adapted a set contour to be correctly used by adapting it as needed in the transformed case. Change-Id: I0d5f14958bcd6f826b9abd53f1f47b7d0bc5a0e2
2017-11-18RotateFlyFrame3: Made interactions work properlyArmin Le Grand
Have now created working interactive Rotation, Scale, Move and Crop. Using as much of the old code as possible since it does corrections based on BorderWidth/s stuff and similar. To do so, need to back-transform and execute in unrotated/ untransformed state as much as possible. Had some problems with SwVirtFlyDrawObj::NbcMove usages and hacks there, had to restructure some of these. Change-Id: Ibedf6d834f96b2f8e9c1ace2a0c984aa26cedc74
2017-11-18RotateFlyFrame3: Restructured TransformableSwFrameArmin Le Grand
No longer derive a SwFrame that needs Transformation support from TransformableSwFrame, but keep it as a member (in a std::unique_ptr). Adapted all usages, also added reset of local SwRect(s) in local SwFrameAreaDefinition during layouting. That makes PrintPreview work correctly. Change-Id: I2e7720e67b57d4d29c0feb065878e246192a8a4c
2017-11-18RotateFlyFrame3: Added basic transformation supportArmin Le Grand
In lcl_MoveAllLowers SwFrame(s) were directly modified, not even by calling any member method what makes it hard to react on changes to geometric definition(s). Added logic to Transform a SwFrame, currently basic by using e.g. SwFrame::Ltransform_translate, may be later unified to general Transformation usage with a homogen Matrix Change-Id: I7582fbd1472e12e481adacedda2e65cc0c282eac
2017-11-18RotateFlyFrame3: Isolated functionality and automationsArmin Le Grand
Isolated tooling stuff for SwFrames that support Transformations to TransformableSwFrame, adapted all usages. Developed functionality to reset temporarily the already adapted SwFrame of the outer frame to non-rotated to mate the layouting work. Made the outer frame being layouted always first. Change-Id: Ia60a971b8eaa28859d0f2a5243eabf68fe949846
2017-11-18RotateFlyFrame3: Late-Updating of AreasArmin Le Grand
When Layouting the update of the Areas is needed, but during layout needs to be stable on the unrotated values. Hard to find the right spot to do this, decided to use the inner/outer frame, layout both, and trigger the updates when the inner frame is layouted to non- rotated Areas for inner and outer frame. Still not sure if this will be correct, but is close to working well. Some repaints/updates missing Change-Id: I3d7dcbf624f3f32392e5e98420cb348d11d7d322
2017-11-18RotateFlyFrame3: Added transformation support to SwFrameArmin Le Grand
The layout element SwFrame now has methods to get linear transformations for the geometry-defining FrameAreaDefinitions. These return by default the SwRect (without being relative for the FramePrintArea to make things easier), but are replaced by the now two SwFrame derivates that support rotation. The layout will now use the BoundRects of the transformations, thus supporting a future that will allow all kinds of free transformations (including mirror, rotation and shear) Change-Id: I18b85f5ddc2970a1b8c137d30b0c2ee49bb8df72
2017-11-18RotateFlyFrame3: Initial support addedArmin Le Grand
First steps to get a rotated FlyFrame and content that only uses layouted sizes/positions and does not change the model data (except rotation). This works with persistence, after reload the rotation can be resetted with going back to the original FrameSize. Lot of stuff not yet working, experimental state. Change-Id: Ie29d501fe2e618a1cb4457d600ce97575ed372d0
2017-11-18Remove redundant checkMike Kaganski
Change-Id: If925aef0109a023d5760a7f83ab570a1f0312cb6 Reviewed-on: https://gerrit.libreoffice.org/44903 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-17Fix typosAndrea Gelmini
Change-Id: Idc648e4673cca1b1dec8c1f009d52cfa290508ff Reviewed-on: https://gerrit.libreoffice.org/44895 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-17ofz: Integer-overflowCaolán McNamara
Change-Id: I8a1a8c4b4d5f32a1f2b8a2e03225f6ac6b747232 Reviewed-on: https://gerrit.libreoffice.org/44889 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-12-26 21:15:54 +0000