Age | Commit message (Collapse) | Author |
|
Change-Id: I842357000f3282521aa927921a5598fddaef5dee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176686
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
so we can move this inside the other conditional
Change-Id: I63259598d5165e3aafbf0c1cfef70ccb1b16bb38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176685
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I27cca1b737c441a9f31ed6aa0fc462190ca818da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176682
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I63510464b74e72f8fc73899e963e20891cdf0f12
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176644
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
V547 Expression '!"unknown reference mark type"' is always false.
Change-Id: I7f984c0e008924b23e3a2384c2e36390bf76cfec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175252
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
V1037 Two or more case-branches perform the same actions. Check lines: 931, 941
Change-Id: Id5be5973b9b3141576d82f64e5fc46acd926b81e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175228
Reviewed-by: David Gilbert <freedesktop@treblig.org>
Tested-by: Jenkins
|
|
Execute getCommandValues('Signature') on the same document twice, you
get different hashes, because the content includes a timestamp, which
changes, so it's not possible to know if the hash is stable or not.
Also, working with a provided timestamp will needed for
<https://docs.eideasy.com/electronic-signatures/api-flow-with-file-hashes-pdf.html#_4-add-the-signature-to-the-pdf-file>
anyway.
Fix the problem by adding a signatureTime parameter and this way we can
have a test that makes sure we get the same hash if the time is
provided.
With this, the hash extraction part is meant to be ~complete.
Change-Id: If5e1e5bcf84c3b777f26b2ded24dcca48ea9ad94
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176601
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
V668 There is no sense in testing the 'pUndo' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
Change-Id: I3eeff673f5c0862e0b3c7f0a5338ddb0882ab31d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176594
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
and
cid#1634639 Missing move assignment operator
Change-Id: Icfc8f958dccae87fd646404c3a5a3772362bcc13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176573
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: If8de961277c3f1a29d2f2ab58261abd8145d4316
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176572
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
V560 A part of conditional expression is always false: pTable == nullptr.
Change-Id: Id6f9a8ff3943fecbe77a4d339b3ca76e27a86605
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176585
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
V560 A part of conditional expression is always true: pFlyFormat.
Change-Id: I9cc68a314dcdf98857eaf39aacf613d6fa67b720
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176584
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
V560 A part of conditional expression is always false: pPap.
V560 A part of conditional expression is always false: pSty.
Change-Id: I37a2cce02f303b9a3944c232d57f89b9087375ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176586
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
|
|
Since
commit 9cddf9da7fb256418e1bc3b4719abb55e3b0604c
Author: Vladimir Glazounov <vg@openoffice.org>
Date: Tue May 22 15:33:44 2007 +0000
INTEGRATION: CWS chart2mst3 (1.1.2); FILE ADDED
V560 A part of conditional expression is always false: (!(pTableFormat && pUnoCursor)).
V560 A part of conditional expression is always true: pTableFormat.
V560 A part of conditional expression is always true: pUnoCursor.
Change-Id: Id690161e2a64a82f94530142879bf291bd8df743
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176583
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
V560 A part of conditional expression is always true: pFormatItem.
Change-Id: I82009191496573e7f9dd1a6ab7f19df2243a30b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176582
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
This would have caught the issue discussed in
709b1f3ddb87303a2dec6155dbe0106369c151ed "Make sure VCLXPopupMenu has unique
RTTI". (The commit message talks about RTTI there, while what Clang actually
compared for an optimized implementation of a dynamic_cast to a final class is
vtable pointers, but the overall picture remains the same. Both RTTI and
vtables are emitted along the key function, and if that is missing or inline,
they are emitted for each dynamic library individually, and as internal symbols
on macOS.)
This commit also addresses all the issues found by the improved
loplugin:dyncastvisibility on Linux. See the newly added TODO in
compilerplugins/clang/dyncastvisibility.cxx and
86b86ac87ea0cc90249f156494c98c3c93e4f3fc "Give DocumentEventHolder (aka
EventHolder<DocumentEvent>) a key function" for an issue with key functions for
class template instantiations.
Change-Id: Ia19155efb1d23692c92b9c97ff17f18ae7a1f3ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176576
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
|
|
The intent of this patch is to address an issue with the Writer
Navigator page change control reported at https://
ask.libreoffice.org/t/writer-display-single-page/111050
"I have selected View > Normal and View > Whitespace and View> Zoom>
Entire Page. On the bottom right, I’ve chosen the single page icon."
... "It is odd that the page number displayed as you click the
[Navigator Page control spin button] up and down arrows does not
change.."
The patch changes the function used by the page control to determine
the page number of the page in the view to that used by the status
bar page control. It also disables page tracking by the control when
the view is set to Multiple-page view or Book view.
Change-Id: I439bb4493061528f87eaeca3c08a33095adb8192
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173888
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
Since
commit 1847211c00612b4d0c0cb0700aeecd4881a0e01b
Author: Sander Vesik <svesik@openoffice.org>
Date: Wed Apr 21 11:25:53 2004 +0000
INTEGRATION: CWS loadenv01 (1.27.22); FILE MERGED
V1048 The 'm_bViewCreated' variable was assigned the same value.
Change-Id: I2c5fe19dcbc0524f6a4bf9baf774cc5ef0c2e793
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176545
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
|
|
V1048 The 'm_bDelete' variable was assigned the same value.
Change-Id: Ib324ee9473de6b8ce8d4e6e073265580c8a3ba68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176546
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
|
|
Since
commit 49ab7533eb32de671088e2ff5294c2365fb8a756
Author: Jens-Heiner Rechtien <hr@openoffice.org>
Date: Thu Sep 27 07:43:57 2007 +0000
INTEGRATION: CWS swwarnings (1.15.222); FILE MERGED
V1048 The 'm_bUndoIdInitialized' variable was assigned the same value.
Change-Id: Iccc66213efa98c8fc9108294515ec174b45cc08e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176537
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: Jenkins
|
|
Since
commit 85a47bbb8340e65a19dc1ceaac768902a771ee77
Author: László Németh <nemeth@numbertext.org>
Date: Fri May 12 17:03:57 2023 +0200
tdf#155328 sw tracked table column: add DOCX export/import
V501 There are identical sub-expressions 'pRedline->GetRedlineData().GetType()' to the left and to the right of the '==' operator.
Change-Id: Ib53d20f102e64cd716245d558d6fd7754f62d9a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175403
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
This change extends layout for font-relative paragraph first-line
indentation into Edit Engine.
Change-Id: I5906f493b91fbcb87ded165709fb132b33ce1906
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176487
Tested-by: Jenkins
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
|
|
Change-Id: I467a2734fa34c4b8daaefc38754c697c2c2803cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176531
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
look for places where we are taking a reference (i.e. "&") to a
temporary object, which is misleading.
Change-Id: Id0eb4dce3f1ca559f86e02edcbea3ca17bea8e76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175978
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
Text frames formatted with Inline Heading style and anchored as
characters were converted to unacceptably low resolution images in
the HTML export. Now the HTML export contains normal h1–h6 elements
with display:inline; CSS setting to get text-based/searchable inline
headings, fixing also the rendering quality.
Follow-up to commit 7a35f3dc7419d833b8f47069c4df63e900ccb880
"tdf#48459 sw inline heading: apply it on the selected words",
commit d87cf67f8f3346a1e380383917a3a4552fd9248e
"tdf#131728 sw inline heading: fix missing/broken DOCX export",
commit a1dcbd1d1ce6071d48bb5df26d7839aeb21b75a8
"tdf48459 sw inline heading: add Inline Heading frame style"
and commit 984f0e49d35ba87c105310f27d945147a23d1198
"tdf#163874 sw inline heading: fix XHTML export".
Change-Id: I02f7af8a39314e78d670b4db9a76897e931b3a47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176512
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Since
commit c617be8307033394bde4255c05b72dbd01ae0056
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date: Tue Nov 27 22:58:50 2012 -0600
remove legacy String svl's Put*Entry family of function and convert users
V1001 The 'sParams' variable is assigned but is not used by the end of the function.
Change-Id: I90e32de620be23b22c4ab4ee4973433455d844b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176522
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
This change implements layout for font-relative paragraph first-line
indentation in Writer.
Change-Id: Ie8f386bcc13a43ab92d5c15654c24bfdfc62bd69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176216
Tested-by: Jenkins
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
|
|
so downgrade to SAL_INFO
Change-Id: I143eea443e7b41307d80d17b44ac980c73854388
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176491
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
through use of context menu entries in the Writer Navigator Footnotes
and Endnotes content types
Change-Id: I2c7b6d01013023702f9272e222b76a83710ca6f1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176495
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
Change-Id: I370d18643b0c83c60846a0b6f051440a043c647a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176486
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Converted #define to enum class
Change-Id: I16195a439643bcf0111c591a829272b5bf70179d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175027
Reviewed-by: Hossein <hossein@libreoffice.org>
Tested-by: Jenkins
|
|
similar to
commit c796878e6af0fc7c886e813a0010d9402312eb5c
Author: Xisco Fauli <xiscofauli@libreoffice.org>
Date: Mon Oct 21 15:56:25 2024 +0200
tdf#163543: check GetDocShell()
Change-Id: I4b489c59b7596466aea6b5c7b78248d82f193a0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175628
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
|
|
Change-Id: Ia35a09b2c5e230136a3d3a238c9753cdb268a6e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176462
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I64342ae8c10738e276702e8ab2c0c0954be25752
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176441
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
The final goal of this API is to give time & hash information about the
PDF signature, so once a 3rd-party produces the PKCS#7 signature, that
can be added to the document and the actual PDF sign can be re-run with
the same parameters.
This commit continues the replacement of XCertificate with
svl::crypto::SigningContext up to the point that the timestamp used in
svl/ can be exposed on the LOK API.
This is done by updating DocumentSignatureManager::add(),
PDFSignatureHelper::SetX509Certificate(),
vcl::filter::PDFDocument::Sign() and finally the svl::crypto::Signing
ctor to work with the signing context instead of an XCertificate
directly.
Time reporting works now, so add a test for that. The digest part still
needs doing.
Change-Id: I83f1274cd420b67194b7caf12b1027e623d4f7fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176404
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Trying to move the current cursor, which may actually be a selection,
to find next/prev footnore, may try to expand the selection across a
table boundary (from outside to inside), which would fail. This was
incorrectly treated as "there's no next/prev footnote, the cursor is
unchanged" case, and the cursor wasn't restored.
Use a separate local cursor object for testing; and make it at least
somewhat useful, to detect the case when there's no more footnotes
in the document, so the prev/next buttons would get disabled.
Change-Id: I7db100dfdd290fe01b3eebe17f1dec2784315243
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176399
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
and
cid#1607919 Overflowed constant
Change-Id: Ifad54a4aa6863e23ee9432d4faacf2a61b4d93e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176379
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Since
commit 2a2c4dddf51c0d6ab726a8854123887bbfa7792a
Author: Andreas Heinisch <andreas.heinisch@yahoo.de>
Date: Tue Oct 29 12:11:41 2024 +0100
tdf#153636 - Search for outline node only if index is for the current chapter
Change-Id: If969db7c4eee4c542ff99f9d405aa7f1d2a8f414
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176403
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
|
|
and
cid#1607622 Overflowed constant
Change-Id: I596708e75118a281fcd8166caf89f2aa741ab605
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176323
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: If68fa2c871472a21d9404370351828753db37ee4
V1037: Two or more case-branches perform the same actions. Check lines: 727, 731
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175159
Tested-by: Jenkins
Reviewed-by: David Gilbert <freedesktop@treblig.org>
|
|
so make this less confusing
Change-Id: Icc4d4c43f0d35963bb71cdcd64bdd78b00ed9632
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176324
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I890ec73e30d3cc6b210903ecee29431f3cb5f635
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175979
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Changes to the background fill were not being updated
in Writer's sidebar, ever since the introduction in 5.3.
Each of these invalidations can be observed to be necessary
in the corresponding fill type and fill choice listboxes.
It already worked in Draw, and I don't see anywhere
this would be needed in Calc
Change-Id: I42f94ee99036761ff69293bcbb44aeda61e1b321
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176300
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
|
|
- Added a new `LevelHdlImpl` method with a `bool bGrabFocus` argument.
- Refactored `LevelHdl` to call `LevelHdlImpl` with `true`.
- Adjusted `SwTokenWindow::SetActiveControl` and `SwTokenWindow::SetForm` to skip `GrabFocus` when the argument is `false`.
- Ensured focus behavior remains unchanged except for the initial "ActivatePage".
Change-Id: If2f43e43f94c3762acd93974550ff0d2d66c6c21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174423
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
(cherry picked from commit dbb054045fae8605794c17aae052a9d588fe33fc)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175996
Tested-by: Jenkins
|
|
and
cid#1556766 COPY_INSTEAD_OF_MOVE
Change-Id: Ie11d0279ec775034ee8e5a14b0e57eaed110fda6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176265
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
we can just take a "const &".
(found by running clang-tidy with the
performance-unnecessary-copy-initialization warning)
Change-Id: I20fd208c65303da78170b1ac06c638fdf3aa094b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176267
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
* Default is Crop Marks now
* Settings are persistent
Change-Id: If5304c874706345fa943a106044155152c86bc0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176131
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Change-Id: Ic883c3a9fd8eb87469aec6b6570a39aadf575c3e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176184
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I618b0f8bcb2e8032ee12367c73e1136685f66b3e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176183
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Hyphen length wasn't calculated in single portion lines at shrinking,
because the width of the overhanging line without the hyphen overwrote
the calculated correct line width. This resulted less shrinking, than
needed, also lost hyphen in the PDF export.
Regression from commit 22eac3145ca62d15b47d95f4df60ce38d4f5aa46
"tdf#162220 sw smart justify: fix shrinking for single portion lines".
Follow-up to commit 17eaebee279772b6062ae3448012133897fc71bb
"tdf#119908 sw smart justify: fix justification by shrinking".
Change-Id: I512e7f1f86f80ff6ea3d0b6a0b0db8255f5d0a60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176207
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|