summaryrefslogtreecommitdiff
path: root/sw/source
AgeCommit message (Collapse)Author
2019-04-10tdf#124646 Don't paste hidden rows of Calc sheets into Writer tablesLászló Németh
The fix for tdf#37223 creates native text tables from the RTF clipboard data to insert them cell by cell in Writer tables instead of OLE embedding. Unfortunately, using Calc RTF clipboard data inserts also the cells of the hidden rows (tdf#118676). This improvement uses the HTML clipboard data to paste only the visible rows. Note: first the original patch 1) converted the clipboard data to a temporary nested text table at the cursor position, and 2) copied its already native table content to the clipboard, and inserts it into the original target table. This doesn't work with the HTML format (that inserts plain text data within a text table cell instead of a nested table). As a workaround, the patch removes the target text table with the insertion point temporarily, creating the native text table from the HTML clipboard data at the place of the removed text table. After copying the converted native text table data to the clipboard, the removed table is restored, and the native clipboard data is inserted at the original cursor position. Change-Id: Iee5bb4027729ca1eab373029f176eeadc59388a8 Reviewed-on: https://gerrit.libreoffice.org/70425 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-04-10clang-tidy: Silence warnings from WIP unhandled-self-assignment checkTamás Zolnai
Where it can be done by removing useless / duplicate code. For XFListStyle I removed the copy operator entirely, because it was bugous and it seems not to be used anyway. Change-Id: Iba0eb0d5c45b42f0e78be466c617acdc1216eb22 Reviewed-on: https://gerrit.libreoffice.org/70482 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-04-10constify some which range arraysNoel Grandin
Change-Id: I1c94090c4846e232bd6bb9c86a0c94b750ccbf5c Reviewed-on: https://gerrit.libreoffice.org/70499 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-10tdf#124469 sw_redlinehide: fix PDF export of links to sequence fieldsMichael Stahl
Missed one call where the return value must be forwarded. (regression from 7d481f7ac1971be622520258a4b13ada29282844 and 943d9be770e550d20ca72274fa5e914d1f61e605) Change-Id: Ic405b29a1dce982bfdd81eeb5d678ceb79690bfc Reviewed-on: https://gerrit.libreoffice.org/70469 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-04-10tdf#124586 sw_redlinehide: fix crash in SwTextNode::NumRuleChgd()Michael Stahl
(regression from c180c9447256588fe5e7991e06642883574760ae) Change-Id: Ie3c935ee5dd42187ca8ad2b28406b80e63c0d1e3 Reviewed-on: https://gerrit.libreoffice.org/70467 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2019-04-10clang-tidy: Fix suspicious catches of WIP unhandled-self-assignment checkTamás Zolnai
Change-Id: I1cb16b180f4cc5bf4d65485f03c44a06414d3580 Reviewed-on: https://gerrit.libreoffice.org/70481 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-04-09drop some unneeded includesCaolán McNamara
Change-Id: I8e41e28313a22148033c566edce50f5bfa58d065 Reviewed-on: https://gerrit.libreoffice.org/70452 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-08tdf#123968 sw: use inline editing for input fields for variablesMichael Stahl
* set these to RES_TXTATR_INPUTFIELD so they get a SwTextInputField * only for string fields, the numeric ones break when editing * SwCursorShell::CursorInsideInputField() must check type of the hint, not type of the field * DocumentFieldsManager::UpdateExpFieldsImpl() is called with one field when it is inserted, and must expand the field into the SwTextNode then, and it's called when the user edits inside the field, and must *not* expand the field into the SwTextNode then * SwDocUpdateField::MakeFieldList_() must iterate RES_TXTATR_INPUTFIELD * SwEditWin::MouseButtonDown() must still pop up the edit dialog on double-click * SetFieldsDirty() should check RES_TXTATR_INPUTFIELD because SwGetExp may depend on them * a very odd API design: SwSetExpField::PutValue() allows to change the "InputFlag", which is actually used by the ODF import! This needs some alchemy to convert between SwTextField and SwTextInputField hints, see SwXTextField::TransmuteLeadToInputField(). * etc. Change-Id: I45c471703f102ebcb04b8567f9d76c17d5a063e7 Co-authored-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-on: https://gerrit.libreoffice.org/69414 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-04-08tdf#42949 Fix IWYU warnings in include/sfx2/[t-z]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib3252828385d1dc8faf48a428b1593199647a679 Reviewed-on: https://gerrit.libreoffice.org/70383 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-08sw: prefix members of SwGlossaryDlgMiklos Vajna
Change-Id: Ia76c1108ea1db64a178c920be1d73400a364b22d Reviewed-on: https://gerrit.libreoffice.org/70403 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-04-08PPTX export: save SmartArt as diagram instead of group of shapesGrzegorz Araminowicz
preserving SmartArt allows editing it in PowerPoint after saving as pptx file * moved common parts for docx and pptx export to oox/drawingml * fixed export tests that expected shapes on output Change-Id: I3e70a9f4177bebf5e1671232f4cd0ef0e7212626 Reviewed-on: https://gerrit.libreoffice.org/69598 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-08Fix typosAndrea Gelmini
Change-Id: Ie541b51ebd0e14c2bd6429e9bfcd9532e02c2b50 Reviewed-on: https://gerrit.libreoffice.org/70396 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-08Use osl_atomic_increment/osl_atomic_decrement to change m_refCountMike Kaganski
Change-Id: Ia24441d3671102fdeeb797547396c25ee2a6ffd3 Reviewed-on: https://gerrit.libreoffice.org/70382 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-07tdf#120703 PVS: Silence V522 warningsMike Kaganski
V522 There might be dereferencing of a potential null pointer. Change-Id: I680f1628133216de6336ac5ffa846447ffd55a41 Reviewed-on: https://gerrit.libreoffice.org/70352 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-07tdf#118375, tdf#70838 correct position of rotated shape in docRegina Henschel
Word relates the position to the unrotated shape in legacy doc format. Writer uses the rotated shape. The patch corrects the difference on import and export. Change-Id: I25537123656e62d6ffae5118ee8d621a4b5c5be0 Reviewed-on: https://gerrit.libreoffice.org/70152 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-04-06tdf#114801: Cannot use the highlight 'bucket' function with docx fileTamás Zolnai
Change-Id: I00df0022a20e83d76484d7c6e7b903ecd3c54aa0 Reviewed-on: https://gerrit.libreoffice.org/70347 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-04-06weld OTableSubscriptionPageCaolán McNamara
Change-Id: I55c23448480384c9a7d78cd55550bb4812ebde72 Reviewed-on: https://gerrit.libreoffice.org/70314 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-06respect read-only config item: MSCompatibleFormsMenuTamás Zolnai
Change-Id: I4eacbe8ad2025a54c13f4c0fa06e30e5ab59b721 Reviewed-on: https://gerrit.libreoffice.org/70344 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-04-06SwXTextField::Impl FieldTypeClient: SwClient no moreBjoern Michaelsen
Change-Id: I745ebae5a58df9b3a7dcb96448099f6803b7b1a2 Reviewed-on: https://gerrit.libreoffice.org/70326 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-04-05FIX: DOCX export: use all updated attributes during table exportPatrick Jaap
In a previous commit only x/y coordinate were considered. For better overview make use of the OOXML converter for orients and relations. Change-Id: I9792ccfbc2ebb58fd768c14278cdfd9b54efe62f Reviewed-on: https://gerrit.libreoffice.org/69523 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-05sw btlr writing mode: implement RTF exportMiklos Vajna
Note that we can't work with the table box (and frame format) of pTableTextNodeInfoInner in RtfAttributeOutput::TableVerticalCell(). This is because cell definitions are written in RtfAttributeOutput::TableDefinition(), and the loop only calls setCell(), i.e. the cell index is updated in the node info, but the table box is not. Import was already working as-is. Change-Id: Ia089c42b3a49f1a8f012a8cadaa8bcad16128c3e Reviewed-on: https://gerrit.libreoffice.org/70269 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-05tdf#120703: partially revert commit 85456fae54029edd26df2277a9eec5e2fe3d9739Mike Kaganski
... to take into account possible differences of results of dynamic_cast vs static_cast; the change casts dynamically, as before the commit, and only adds asserts on the result of the cast. Thanks to sberg for pointing my mistake out! Change-Id: Ib77d443e5a858e744f369f58542de603f948fd1c Reviewed-on: https://gerrit.libreoffice.org/70274 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-05respect read-only config item: AutoFunction/Text/ShowToolTipAndras Timar
Change-Id: Ib808e35d3cc3c2895993193ac6ed05d556c1857d Reviewed-on: https://gerrit.libreoffice.org/70275 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-04-04Get rid of USS macroMike Kaganski
The helper marco is used in export code to convert UTF-16 internal string representation to UTF-8 used in XML encoding. I suppose that all strings here should be already valid UTF-16 (an invalid input should have been validated at import/input stage). An invalid string at this stage means a programming error in another part of code that breaks this precondition, and should not be handled at export stage. (See also commit 0267a2326b5282023e8b08a147eca178c5db1980.) This effectively changes flags used in conversion from UTF-16 to UTF-8, so that now RTL_UNICODETOTEXT_FLAGS_INVALID_ERROR is used instead of RTL_UNICODETOTEXT_FLAGS_INVALID_DEFAULT, so that the result would be truncated on invalid bytes instead of inserting U+FFFD, and would fail assertion in debug builds. Other changed flags don't affect UTF-16-to-UTF-8 conversion. Change-Id: I12b2cc5378208904c3266924187d6402700ed6f3 Reviewed-on: https://gerrit.libreoffice.org/69801 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-04weld ClassificationDialogCaolán McNamara
with the extra problem of hosting an EditView/EditEngine within a weld::DrawingArea Change-Id: Id48a57ed0dfd2d92217209c43f752edd9cf8e1bd Reviewed-on: https://gerrit.libreoffice.org/70219 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04Fix typoAndrea Gelmini
Change-Id: I5a9bb201377ab3b65ab5f896f986126644352969 Reviewed-on: https://gerrit.libreoffice.org/70225 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-03DocumentIndex::Impl: SwClient no moreBjoern Michaelsen
Change-Id: I552acba206a3f35a450fc5331e3853e23a46cc10 Reviewed-on: https://gerrit.libreoffice.org/70166 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-04-03Fix in convertToOOXMLHoriOrient: values of VertOrient were takenPatrick Jaap
Change-Id: I47093292aeed5c0579dd4b365561ee86935632e4 Reviewed-on: https://gerrit.libreoffice.org/70197 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-03Revert "add more append methods to *StringBuffer"Noel Grandin
This reverts commit 8cfa7f4dc00f3dd37e57917ef25c806b0e9e6e73. comment from sberg: we already have 70519a43e0d89a6b5d89859a6851f8c757c6b0c7 "Replace OUStringBuffer::appendCopy with append(std::u16string_view)" (which can be extended to OStringBuffer if needed) Change-Id: Ifcc550a8cf26ef38ad49fde8b067f53c999c9276 Reviewed-on: https://gerrit.libreoffice.org/70178 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-03tdf#124500: convert short path names from drag-n-drop to long namesMike Kaganski
... otherwise link URLs with short names like 2E23~1.PNG would be inaccessible from the network, or after copy to a different directory or system, where the autogenerated short name might be different. Change-Id: Ice0b2fa205a25aba232e960cad2615a527cba05a Reviewed-on: https://gerrit.libreoffice.org/70145 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-03add more append methods to *StringBufferNoel Grandin
which performs the append without needing the creation of a temporary *String Change-Id: If9ad3222275f26659db2e7df8d34f068977c4d17 Reviewed-on: https://gerrit.libreoffice.org/69826 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-03Fix typosJens Carl
Change indefinite article "an" to "a" before the word unique and some variants. Change-Id: Ia14a6f3b9ec6b257ad8bed3b089faa9b6f07d44f Reviewed-on: https://gerrit.libreoffice.org/70174 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-03Fix typoAndrea Gelmini
Change-Id: Ib4895ce8c0d56b89260ea71734687734298d7c92 Reviewed-on: https://gerrit.libreoffice.org/70168 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-02tdf#124272 use ClipRegion's geometry if not a rectangleArmin Le Grand
By error the ClipRegion's geometry was replaced by it's BoundRect expanded to PixelBounds. If the ClipRegion is not a rectangle, this will create wrong results. To do both - extend to PixelBounds and have the original geometry included - use the PolyPolygon topology as needed (see comment in code for details) Change-Id: If3f75223144eba8eb23909a7c701ad544346099b Reviewed-on: https://gerrit.libreoffice.org/70146 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2019-04-02Resolves: tdf#124485 [none] is at index 0Caolán McNamara
rather than the meaning of nothing-selected which is -1 Change-Id: I3be01fa8d6b57f61aa660be5912f479e79cff2b2 Reviewed-on: https://gerrit.libreoffice.org/70142 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-02drop some unneeded includesCaolán McNamara
Change-Id: I78b9682968acea7564554fb589d2759b6c8e67d0 Reviewed-on: https://gerrit.libreoffice.org/70126 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-02sw_redlinehide: remove WrongListIterator::MergedOrSame assertsMichael Stahl
There is a surprising recursion with 2 SwTextSlot on the stack, with 2 consecutive fields, and then the m_pOldGrammarCheckList is not the SwTextNode's but a SubList of that, so the assert triggers spuriously. SwExpandPortion::Paint(SwTextPaintInfo const&) const (this=0x7d61cc0, rInf=...) at sw/source/core/text/porexp.cxx:66 SwFieldPortion::Paint(SwTextPaintInfo const&) const (this=0x7d61cc0, rInf=...) at sw/source/core/text/porfld.cxx:437 SwLinePortion::PrePaint(SwTextPaintInfo const&, SwLinePortion const*) const (this=0x7d61cc0, rInf=..., pLast=0x6fa49d0) at sw/source/core/text/porlin.cxx:138 SwExpandPortion::Paint(SwTextPaintInfo const&) const (this=0x6fa49d0, rInf=...) at sw/source/core/text/porexp.cxx:78 Change-Id: I915f31ce6de57b6a4a051598428441ae6c86d264 Reviewed-on: https://gerrit.libreoffice.org/70131 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-04-02tdf#122926: Use o3tl::sorted_vector in other similar placesXisco Fauli
it doesn't give any win to the attached document, but seeing we get a 2 secs win with 9634f5ee73e57e8cef75461316d5d45b06ee104f, we can use the same logic in two similar places hoping other documents will get benefited Change-Id: Ie1e76a4317d5b2274335479037b248fe7b1e2a61 Reviewed-on: https://gerrit.libreoffice.org/70092 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-04-02tdf#124261 sw btlr writing mode render: fix invalidation rectangleMiklos Vajna
SwTextFrame::SwitchHorizontalToVertical(SwRect) did not handle the non-swapped case, also the text frame took the tblr codepath when determining the invalidation rectangle of the layout frame, but that special-case is not needed for the btlr direction. Typing into the cell of the bugdoc now determines the paint rectangle correctly, so the typed letters show up right after typing. Change-Id: I48c75603963868591d72bf4d0e8dbba679f3b5e9 Reviewed-on: https://gerrit.libreoffice.org/70087 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-04-02tdf#122926 FILEOPEN ODT Slower compared to the past (part2)Noel Grandin
Further improvement: on my machine, this takes the time from 8.9s to 5.7s Change-Id: Ic7f7c46b10fbb671ff5bbf9d0a6a0195696741bc Reviewed-on: https://gerrit.libreoffice.org/70112 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-01tdf#122926 FILEOPEN ODT Slower compared to the pastNoel Grandin
on my machine, this takes the time from 12.3s to 8.9s Change-Id: Ibdc7e3c34d1acb0d1f7f784720552fa6c7977fa5 Reviewed-on: https://gerrit.libreoffice.org/70074 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-01use drawing area font for previewCaolán McNamara
Change-Id: Ibebf128c1db3a3bfb59c47624e16e6bf2d47b652 Reviewed-on: https://gerrit.libreoffice.org/70051 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-01weld SwAssignFieldsDialogCaolán McNamara
Change-Id: I1242f89b4a2809c730b9bc7c2b6b7207edabd47f Reviewed-on: https://gerrit.libreoffice.org/70015 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-01tdf#42949 Fix IWYU warnings in include/sfx2/[sS]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I4a3baffa8944b522b16b50975185759081662020 Reviewed-on: https://gerrit.libreoffice.org/69945 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-01sw: prefix members of SwMultiPortionMiklos Vajna
Change-Id: I00625ac33876d541117592cfb385d3bbd981a9a6 Reviewed-on: https://gerrit.libreoffice.org/70045 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-04-01tdf#120703 PVS: Silence V522 warningsMike Kaganski
V522 There might be dereferencing of a potential null pointer. Change-Id: Ie617b41a8f8d334022cf5313b242a236baedba48 Reviewed-on: https://gerrit.libreoffice.org/70017 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-30tdf#123912 ww8 export: re-protect implicit sectionJustin Luth
Sections should retain their protected on/off status regardless of the value of PROTECT_FORM. However, if there ARE no sections, then the implicit section should use the document settings. The same is true for the pseudo -1 section which I believe can only be the last section (the fragment of the implicit section that follows the last real section). This is basically a revert of LO 6.2 commit fa667b6dc410f3af57ef436cc117352c829f95e7, restoring the previous behaviour in the case of the implicit section. Change-Id: If0b473445e0add017504a3cb61b63116f92be5ce Reviewed-on: https://gerrit.libreoffice.org/69957 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-03-29tdf#42949 Fix IWYU warnings in include/sfx2/[n-r]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia2bea9bd4775f4ed5ef0133971106a6c0bfdd1c0 Reviewed-on: https://gerrit.libreoffice.org/69896 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-29sw btlr writing mode: implement DOC filterMiklos Vajna
Replace WW8TabDesc::Start/EndMiserableHackForUnsupportedDirection() added in commit 69ba46df8be261e665214390cd57a141ad65c210 (INTEGRATION: CWS vertcell (1.95.32); FILE MERGED, 2004-04-21) with the usage of the new writing direction. Adapt export accordingly. Change-Id: Ic85b69c806fbd1c1b4eb21cff3ee46dd5da497e8 Reviewed-on: https://gerrit.libreoffice.org/69901 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-29tdf#84635 quadratic slowdown on loading large tablesNoel Grandin
skip the re-registration scan in SwTableBox::ChgFrameFormat, which we don't need since we are creating this table for the first time On my machine, loading the 69 page file goes from 40.9s to 30.4s loading the 128 page file goes from 79.1s to 45.1s Change-Id: Id9e48256556e19eca34a892b29beff7eab9f51f1 Reviewed-on: https://gerrit.libreoffice.org/69885 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>