Age | Commit message (Collapse) | Author |
|
Change-Id: I8e2c89f2c897535013d64720b6c2c5bbac602b14
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108551
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
|
|
Operator >>= from any does not guarantee initialization, so compiler warns you.
Value defaluted at 0.
Change-Id: Icecc765be73bb653f0167958e319a1417df6ac86
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108485
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I78f837a1340be0ca5c49097f543a481b7b43a632
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108367
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I346da72b15d21f09440f65f2c4f832115267c5e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108552
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I544cc42845d346eb0901ca86621a563d1173e2b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108550
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
|
|
Change-Id: I50bd9648584a60feccc115b4e58dff896e1284be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108499
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Also, make the uitest output a bit more explicit.
Change-Id: I41fa08a6fc02d95ad3337129eb93f8a569cf3cbd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108491
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
|
|
the fragile tests depending on specific order of objects any a bit
unfortunate ...
Change-Id: Ib74ec2a69c95e6ca859d7c75796081ac889ac32d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107647
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
|
|
ReadImpGraphic and WriteImpGraphic have been reimplemented in the
TypeSerializer some time ago, but the code has not yet been moved
to use that class. This commits does that and changes all the code
using those 2 methods and removes them. With this implemented in
the TypeSerializer, it is easier to handle
In addition it also removes ImplExportNative (and the method on
the Graphic interface). This was really used only in one method,
and it could be implemented in the mthod itself.
Change-Id: I0982429d1c1d5ed7ef07627d87ed9a08df43f040
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108256
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: Ief235e98f3de02350b6403a1ea8ecf6361571789
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108285
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
as a precursor to introducing a strong_int type for hundredths
of a degree
Change-Id: I766f1c2f8c6d31ec1ea2f064293d70b30da0bc56
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108431
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I044dd21b63d7eb03224675584fa143009c6b6008
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108418
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
This Format -> Title Pages dialog is completely broken,
so I threw in lots of FIXME notes.
At least for the case of just using the existing pages
and setting them up as title/follow page, fix:
1.) the ability to round-trip page number restart if a
numbering restart without a page style already existed.
(Yes, this likely is an odd case of someone messing around.
In any case, a page number restart REQUIRES a page style)
make UITest_writer_tests5 UITEST_TEST_NAME=\
titlePageWizard.tdf138907.test_tdf138907
Change-Id: I544145e9f749f471b54fa6686242e93bc98f50be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108322
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
and EndRuby(). Ruby is implemented as EQ field in RTF.
The original run text become the ruby base text in this
case. Calling EndRun() in StartRuby() might cause the
run completed early and text attributes that hasn't be
processed mistakenly applied to next run. This patch
close the in EQ field command in EndRun, in case StartRuby
has already inserted EQ field command.
Change-Id: I3a755f235b79d11b7897f85ae3989cc3ac73b06a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108194
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
|
|
Apparently, there is a discrepancy in how the
various help manuals describe this.
What was actually happening was that the same
amount was being changed on each column
instead of the same percentage. That is really
bad if there are small columns, and a large one is reduced.
Plus it seemed like there were implementation problems anyway,
especially when growing a column too much.
This patch sets it to how the guide describes it.
"Adjust columns proportionally results in all columns changing
their widths by the same percentage when one is changed.
For example, if you reduce by half the size of a column,
the sizes of all the other columns will be halved."
(July 2018 LibreOffice Writer Guide 6.0 page 282)
Online help since 2013 simply says.
"Adjust columns proportionally:
If possible, change in column width will be equal for each column."
https://bugs.documentfoundation.org/show_bug.cgi?id=42023
One situation I noticed but don't think it needs dealing with
is if "from left" contains a value, then perhaps the table
should not be allowed to take up the full width?
It could grow to spill out past the edge of the page.
(Problem already existed with previous solution.)
Also, merged cells might cause some unexpected results,
but that becomes a user problem to fix I say.
I didn't think it would matter if I grew the table
a couple of Twips larger than full width. If it is,
then probably just reduce maxWidth by a twip for every
two columns - or truncate instead of round.
(And then I also need to account for theoretical columns
that are "increased" to MINLAY size too.)
Note that the table will NOT grow beyond
100% text width. However, if a table is already
larger than 100% (which the UI makes difficult to do)
at least an attempt to grow the columns will not cause
them to shrink. They will just stay the same sime.
make UITest_sw_table UITEST_TEST_NAME=\
tdf134881_colProportionalAdjust.tdf134881.test_tdf134881
Change-Id: Id57d80d9658b9ac1938189c75da0cbf309fc321a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107604
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
pWrtShell was nullptr. This crash was triggered by
an collaborative editing use case.
Change-Id: Id64298b424f5ac4d96df97581c6fe3067e799eb3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108417
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
(*) Fix SwRotationGrf::GetPresentation to return a more accurate string
(*) Add utility functions
sal_Int32 toDegree100(Degree10)
double toRadians(Degree10)
(*) Fix SwVirtFlyDrawObj::GetRotateAngle to return the angle in the units
that svx expects (deg100)
which was introduced in
commit c2e30949e0fb7c6a73742450f646e0d8d59d5e4f
Date: Wed Apr 10 15:13:53 2019 +0200
lok: writer: svg export transformed images
and consequently we can remove the kludge from that commit in
SdrMarkView::SetMarkHandlesForLOKit
Change-Id: I1a8c5f3a417f887f85b92ae5464578e9ee251619
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108406
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
as a precursor to introdcing a strong_int type for hundredths
of a degree
Change-Id: Ie2d7ad3b48d01defb43bf2e11e6494c4b999de0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108378
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I2d99a13822b07d98e03d7e7de91ca44ab4f8599d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108266
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I6be3fd88ea092309de63389d64c25d7a28195d3d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108270
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
In practice, it works fine to look at all of them, regardless of actual argument
types.
Change-Id: Ifc49cbcd6003c8837c1b3f81d432c59fb0657bf1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108366
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I37bbab5f22f91faad65be8ef79734ce1ee6355d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108249
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
DDE_TXT_ENCODING is just an alias since 2008
commit a190965485508c4493ee33228dae68e12cd858f9 and
commit cc141699cc6b2fa38b0b0003bff27751e23ae8e4
Change-Id: I2ca32871c13bd3837f173e5f9f959f364857de52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108330
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Id4034a57580f37fd71f841deec9edfe9b7c26a67
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108286
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Rework of offending code that changes the mouse pointer to a hand icon
when outline content visibility feature is active.
Change-Id: Ia30a8f951b341a4f44f8b900cc756c205f6a273d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108275
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
commit 797915bf0bc0ed82c3cf58b7bd03c42d3335ca18 prevents focus from
returning to the edit window when Navigate by previous or next buttons
in the Navigator tool box are pressed. This may be nice for activation
of the button by keyboard as it keeps focus on the button, but it
doesn't allow for cursor indication of the navigated position in the
edit window.
Change-Id: I0067ee7d80aa94a510c83a52c22f788ba4a03dc6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108276
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
See the comment at the top of compilerplugins/clang/stringliteralvar.cxx for
details.
(Turned some affected variables in included files into inline variables, to
avoid GCC warnings about unused variables.)
Change-Id: Ie77219e6adfdaaceaa8b4e590b08971f2f04c83a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108239
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
It caused issues on Windows with an upcoming change that introduces more static
OUStringLiterals, and apparently one from msword ended up in the data structures
of editeng's SvxForbiddenCharactersTable, which in turn is owned by theEditDLL
singleton, which was destryoed at exit after the msword library had already been
unloaded, so an OUString referenced the dangling OUStringLiteral data.
Change-Id: I873f0b4e879a5820d1e8a1cda3b1b1fd49f809db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108321
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ic3758d8eeeb1818e3be3ca5d815fa601a34e8dd9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108279
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Ic283206b318e4367e5d88475bdc2abac48e79f62
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108271
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Id13869138a622e62d9ffebf2c89bddccda6aff01
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108238
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I49acd246a9675a0749e056178dec43d0d73c488e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106450
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Also included in this patch:
- Modifications to make all outline content visible during move
operations.
- Removal of code intended to redraw buttons when layout is changed that
seems not to work as intended.
- Function IsOutlineContentFolded changed to IsOutlineContentVisible
- Change of delay before button is shown to half of what it was.
Change-Id: I0dde555ccd0693ca382c1f15326edfdc2fc44a93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107815
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
Change-Id: I1536f2f03da9ec64627bd1e2e1776cf130717aff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108143
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I66d016a22158f9f9ef68a80842e95e45516f0b4e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108228
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I70156d8492afbab2c5993e1627a024ef8e07c492
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108195
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
emscripten clang fails with:
sc/source/core/data/attarray.cxx:378:44: \
error: call to member function 'erase' is ambiguous
aNewCondFormatData.erase(nIndex);
~~~~~~~~~~~~~~~~~~~^~~~~
include/o3tl/sorted_vector.hxx:86:15: note: candidate function
size_type erase( const Value& x )
^
include/o3tl/sorted_vector.hxx:97:10: note: candidate function
void erase( size_t index )
This looks like a compiler error, but if the vector contained
size_t values, this would also be ambiguous to begin with. So
this just renames erase(size_t) to erase_at.
And instead of a 2nd find in the failing code, after copying
the vector, it mow uses std::distance to remove the item.
Change-Id: I7d03ff32352a1890cc01ca241452c0f00d6a9302
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108212
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
...which makes the OK/Cancel buttons invisible under small displays.
This commit changed the height of these widgets. Also I did some tweats to the UI file
and the width so that the edit dialog of these fields looks nicer (at least on my display).
Change-Id: I9f39727afd566d75db525c5a5cafe2eabb66d7ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107965
Tested-by: Jenkins
Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
When you click on the blue dashed line indicating a page break,
that delete should remove both that page's break-before,
and the previous paragraph's break-after.
Also, edit should detect if a break comes from a PageAfter.
Prior to this commit, multiple things were wrong:
-the previous paragraph wasn't checked, so PageAfter
breaks were not deleted.
-edit looked at the wrong para if break was PageAfter.
-the current paragraph's PageAfter was deleted - deleting
the NEXT page break, and not THIS one.
I hope only tables are the exception to the rule.
It doesn't seem to matter which table pNd is set with the
NONE'd break. In theory, I could edit the real GetBreakItem
functions to add in that code, but that seems very
dangerous at this low of a level.
Prior commit d7dfae214384f37901b532618e4d3ef117bd0285
flattened this function and did other minor cleanup.
Change-Id: I9944c25853ec206f9febb6ea9f4e34c13c770ebb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108072
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
and bad "$2" redline text in ChangesInMargin mode.
Also in the default "changes-in-text" mode, Undo didn't
remove this empty redline added for tdf#119571 in the
case of associated redline ExtraData (i.e. joining
paragraphs with different styles), see also
commit 66b39ca79b36da8d5e151deab17a0fb7690eebe6
(tdf#131147 don't store redline ExtraData during Undo).
Change-Id: I7faa7c3acd8f8a0312339087072453a15751dd81
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108126
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Commit 8c9a4ff511a3b1d84a7a6d08a1b153c07f164abb (throw exception in
SvStream when reading past end of file, 2020-11-16) changed the "read
past the end of the stream" behavior to throw, and this broke
online.git's unit-password-protected test.
Fix the problem by not attempting to read if we know the remaining size
is too small, even if the stream is good.
Change-Id: I62f1532fc87a14c9f1f5e681e3ad67e4d575e8a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108152
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
since it has two completely different paths of control
Change-Id: I89b739d318d52245208a4bda1230f69d19f3ae0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108104
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
The document in question has a landscape page, the last paragraph has an
image where the width is 100% and the height is set to keep the ratio
(which 1:1). This means that SwFlyFreeFrame::CheckClip() will scale the
image down, so the image fits the page (and give up that 100% width was
requested).
The next problem is that this image has a wrap type set to none, so not
only the total height of the page is taken, but also no content is
allowed on the left/right side, effectively taking the entire body
frame. Combine this with a previous paragraph, which is a heading, so
keep-with-next is set for it. Layout loops because keep-with-next and
take-the-entire-page are conflicting requirements and we used to have no
explicit code to relax one of them when both are present:
SwFlowFrame::MoveBwd: frame is 4, old upper is 10, new upper is 2
SwFlowFrame::MoveFwd: frame is 4, old upper is 2, new upper is 10
SwFlowFrame::MoveBwd: frame is 4, old upper is 10, new upper is 2
SwFlowFrame::MoveFwd: frame is 4, old upper is 2, new upper is 10
SwFlowFrame::MoveBwd: loop control, frame is 4, old upper is 10, new upper would be 2, but not moving there
Fix the problem by giving up keep-with-next to stop the loop, mostly
because we have to give up one of the requirements and Word resolves the
conflict this way.
Change-Id: I7da1ebcff9302cd144887f63efb94e0b2b2be8fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108119
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
The LinkedDisplayName could be empty what caused an assert.
tdf#138986 regression from commit: bda05ba17362222b74727872579b65b3fa14e3d8
(tdf#41466 DOCX import: fix VML v:shape/v:textbox)
Change-Id: I166a7e4c1defc201d0563a961b28ecb6c6be500c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108077
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
This reverts commit 25ca25ee25278536c56a2ac4a63af91100ce4d2e.
cd sw; make -sr CppunitTest_sw_uiwriter3 CPPUNIT_TEST_NAME="testTdf130805"
breaks with this one, it just went in due to an old baseline.
Change-Id: Ie68f2847b936aefba3198ddd915316a204210d4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108105
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Cleanup:
-everything uses the same pCnt, so do that once and share it.
-use FindFirstBodyContent to consolidate a lot of ugliness.
-make pNd into a reference, since it is used unconditionally.
-had to switch to IsInTab since we only have content frames now.
Change-Id: I0ce66e98ea915152ef534e7719100da7cd6ca2db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108071
Tested-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
... SwXMLTextBlockParContext and SwXMLTextBlockTextContext
See tdf#94879 for motivation.
Change-Id: I85fb65a140381b258d51c2f35c5a8cf27d6dfa4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108074
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I1194441063047637adc20c8e37bb717fdb787714
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108073
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
First paragraph of the document lost its formatting
from commit 056933bc55608d0ca061539ae124d7b9386cdb62.
(tdf#137802 sw: fix crash on deleting last paragraph).
This reverts commit 056933bc55608d0ca061539ae124d7b9386cdb62.
Change-Id: I7d42c9a22b456ce3faa9cf08c6c73a2878636c8f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107427
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
...after 46c5de832868d2812448b2caace3eeaa9237b9f6 "make *String(string_view)
constructors explicit"
Change-Id: I6e884c762a2fc91f5dd6fbb197a596fd60f17cae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108043
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|