summaryrefslogtreecommitdiff
path: root/sw/source
AgeCommit message (Collapse)Author
4 hoursuse more concrete UNO classes in writerfilter (SwXTextEmbeddedObject)Noel Grandin
Change-Id: I410bdf51539b2752e95e3dafe8a1513b7bb19626 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166809 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
6 hoursSwModify::Add/Remove always derefs argCaolán McNamara
an effort to remove C6011 Dereferencing NULL pointer 'pDepend' Change-Id: If9e7b7be25ece3df60ada09e5c83d03aebe9c535 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166865 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
7 hourstdf#159683 sw content controls, plain text: fix crash with the clipboard docMiklos Vajna
Regression from commit c804c5354855188b5a37219cfe11dc079dc235f4 (sw content control: fix lost properties on copy&paste, 2023-03-10), select a plain text content control, copy it to the clipboard, quit: assertion fails during shutdown because the doc's "placeholder text" char style is still referenced by a client. What happens here is that the SwContentControl copy ctor copies the plain text flag, and that flag is only read in SwTextNode::InsertHint(), so that causes the problem. Note how that code is inconsistent: we avoid the creation of dummy characters in the copy case, but we still try to adjust the start/end of the content control attribute in the copy case, which makes not much sense. Fix the problem by not adjusting the content control attribute boundaries in the copy case, since the original intention was to do thees corrections only at a UI level, during interactive edit. It's not clear why this inconsistency had an influence on the clients of the char style, though. Change-Id: I86b0516464f24fc453dcd97588dafb8afd010a9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166882 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
7 hourstdf#160833 sw DoNotMirrorRtlDrawObjs: add layoutMiklos Vajna
In case this flag is active (intended for DOCX files), then don't automatically mirror the position of drawing objects, just because they are anchored in an RTL text node. Change-Id: Ie743d94ecb511d7de89e8e1e8303896370ce58c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166883 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
7 hoursuse more concrete UNO classes in writerfilter (SwXFootnote)Noel Grandin
Change-Id: I9d212348edfa1897ad139fbb9f633fbd5a09566d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166808 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
11 hoursDrop some uses of css::uno::Sequence::getConstArray ...Mike Kaganski
where it was obsoleted by commits 2484de6728bd11bb7949003d112f1ece2223c7a1 (Remove non-const Sequence::begin()/end() in internal code, 2021-10-15) and fb3c04bd1930eedacd406874e1a285d62bbf27d9 (Drop non-const Sequence::operator[] in internal code 2021-11-05). Change-Id: I4ccc647bb794515c8c11f8dfd9a26563f4aa094b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166819 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
20 hoursfutile to null check here if we deref afterwards anywayCaolán McNamara
Change-Id: I994b276ad39b09547cb1dbd3710daf519c5f5c66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166864 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
20 hourstdf#160833 sw: add a DoNotMirrorRtlDrawObjs compat flagMiklos Vajna
The DOCX bugdoc has a circle shape anchored inside an RTL paragraph: this shows up on the right hand side in Word, but on the left hand side in Writer. What happens is that Writer implicitly mirrors draw objects anchored in RTL paragraphs, while Word doesn't do this. Start fixing the problem by adding a new layout compatibility flag that can be used by the DOCX import in the future, to leave the behavior unchanged for new & existing ODT documents. An alternative would be to do something similar to the DOC import's SwWW8ImplReader::MiserableRTLGraphicsHack(), but 1) we don't have the page margins by the time we import the shape and 2) as its name says, it doesn't feel like a clean solution, it's better to handle this difference at a layout level. Change-Id: I2ec067d86c7fbdbe57e4cd9547015fe25a9a56b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166820 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
25 hoursFix UBSan failureXisco Fauli
Introduced by 495b5db74f0db59395ff68bacc8d8ca67595b66e "sw: check GetUserCall" https://ci.libreoffice.org/job/lo_ubsan/3154/consoleFull#-1571115798d893063f-7f3d-4b7e-b56f-4e0f225817cd Change-Id: Ifc80312890f2e6b82dcc9419b5b7e8bfcd5340a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166824 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
25 hoursuse more concrete UNO classes in writerfilter (SwXContentControl)Noel Grandin
Change-Id: I84a4c82176681eb55e90240a2db7001123605c1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166807 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
28 hoursUBSan needs SwXBookmark RTTI nowStephan Bergmann
...presumably since 6a11bf9f7bd209a082254c861d5a04c7f5729d68 "use more concrete UNO classes in writerfilter (SwXBookmark)", failing sw_writerfilter_misc with > DynamicLibraryManagerException: "Failed to load dynamic library: workdir/LinkTarget/CppunitTest/libtest_sw_writerfilter_misc.so > instdir/program/libsw_writerfilterlo.so: undefined symbol: _ZTI11SwXBookmark" Change-Id: I9f839ca0f6986723cd2c4add5eaef3ac8ab8d841 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166821 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
29 hourssw: fixed crash on GetCreateView() returning nullptrVasily Melenchuk
Change-Id: Id0cb44ac7d805a1736fa8170aaffb97b54211707 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166617 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
41 hourstdf#160836 sw: resize rows at images cropped by row heightLászló Németh
Fixed row height can crop cell content, including images anchored as character. Resizing the row height with mouse was not possible there, because selection of the cropped image avoided to drag & drop the horizontal cell border. Change-Id: I6dde79e77563468059794548b6c058cad61586a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166795 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins
41 hourstdf#160842 sw: select cell content instead of cropped part of imageLászló Németh
It was not possible to select and edit the content of the bottom cell, if an image cropped by the fixed row height "covered" it, i.e. the image was in the previous row, anchored as character. Note: table cells with fixed row height are usable to crop images easily, with a single drag & drop, according to the requirement of the text layout, while the cell above or bottom of the cell with image is for the caption of the image. This is very useful to adjust a book layout with sections with multiple columns and illustrations. Change-Id: I8683b4066db6ce43549ec3aa69b0e639a59e3681 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166794 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
41 hourstdf#44773 sw: allow resizing table rows, if cursor outside the tableLászló Németh
If the cursor wasn't in the table, only column width of text tables was resizeable by dragging the horizontal cell borders: It was possible to drag the horizontal border, showing its preview, but the drop cancelled the operation instead of resizing the table row according to the selected position. Now it's possible to resize the height of the table rows without moving the text cursor inside the table. Note: This is important for floating tables containing images: here it's not possible to put the cursor inside the table, if the image is cropped only by the cell borders: so it was not possible to resize the row height. Change-Id: I181d79a28cdeefabb796b7b978ee1368a9378888 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166793 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
43 hoursuse more concrete UNO classes in writerfilter (SwXStyle)Noel Grandin
Change-Id: I12b41369ee65f46e08494acda0435f767e28f290 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166804 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
43 hoursuse more explicit UNO types in writerfilterNoel Grandin
Change-Id: Icf26a78679398746a6c51453ae2de64615de088e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166803 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
43 hoursuse more concrete UNO classes in writerfilter (SwXTextGraphicObject)Noel Grandin
Change-Id: I27c96bd3c18d24398f773319fa41bed8a8da9eee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166802 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
43 hoursuse more concrete UNO classes in writerfilter (SwXTextFrame)Noel Grandin
Change-Id: Ic00730c49c0feb7ab7e649c7d6e5d3ff1cb79b27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166801 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
43 hoursuse more concrete UNO classes in writerfilter (field annotation)Noel Grandin
Change-Id: I39e2c1d7d3c49017795d1365895ef8bd8d1e0e87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166800 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
46 hoursuse more concrete UNO classes in writerfilter (SwXTextSection)Noel Grandin
Change-Id: I407d165ccdfcb23e2b922701dc9753c72c439cc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166788 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
46 hoursuse more concrete UNO classes in writerfilter (SwXFieldmark)Noel Grandin
Change-Id: Ifa90331eadc08e0949c28d09be92d5aed4c8a70f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166787 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2 daysuse more concrete UNO classes in writerfilter (SwXBookmark)Noel Grandin
Change-Id: I8a0e9a83ef2bad7920067d108443b7b682f0660e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166786 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2 days-Werror,-Wunused-variableStephan Bergmann
...after 87e0feafd3690a9b58890cc28f8ba0c521bfb557 "use more concrete UNO classes in writerfilter (SwXDocumentSettings)" Change-Id: I4f57ef975dbee32b6f9ff6654b66483c8f1083a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166791 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
3 daysuse more concrete UNO classes in writerfilter (SwXTextDefaults)Noel Grandin
Change-Id: I44eb8d4561798980ff7008d843bf076fc29582c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166769 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
3 daysuse more concrete UNO classes in writerfilter (SwXDocumentSettings)Noel Grandin
Change-Id: Id668946233d55d641199634d7ceda2607107e76b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166694 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
4 daysMake sure that collecting redline autostyles succeedsMike Kaganski
This step was called separately in SwXMLExport::ExportAutoStyles_, after collectAutoStyles. collectTextAutoStylesAndNodeExportOrder (which is called from collectAutoStyles) sets mbCollected to true, and then all the code checking mbCollected/isAutoStylesCollected stops collecting autostyles. This moves exportTrackedChanges call to the place where all auto- styles are collected. Change-Id: I3f4bd0e0ff906a35b69c052e34adb6d66ef80d48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166735 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
4 daysuse more concrete UNO in writerfilterNoel Grandin
elimate the TextFactory stuff, since it is the same object as the TextDocument Change-Id: I10577f2ac9ffa4d079b96052f7879a83e38f1cf6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166693 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
4 daystdf#154581 tdf#157411 tdf#158549 sw: HTML import: fix SfxItemIter reuseMichael Stahl
This is obviously wrong, as ALG just pointed out: the aIter is at the end after the 1st loop, so the 2nd loop does nothing. Thx Gabor for checking all the reported bugs. (regression from commit db115bec9254417ef7a3faf687478fe5424ab378) Change-Id: Iae37b9ab5c630d0ee774f42c84d5e76349b92a90 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166643 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
4 dayssw: check GetUserCallXisco Fauli
It might return nullptr See https://crashreport.libreoffice.org/stats/signature/SwFEShell::ShouldObjectBeSelected(Point%20const%20&) Change-Id: Ia0ed355a7eb9084b9f57163ffbfe6b549c8bdb3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166642 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
5 daysFix typoAndrea Gelmini
Change-Id: I8ab3728b0b5cf414582849e9efe36a3c9df43f45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166646 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
5 daysuse more concrete UNO classes in writerfilterNoel Grandin
starting with SwXTextDocument. Replace some UNO_QUERY_THROW with if (!foo) throw uno::RuntimeException() because rtl::Reference does not have UNO_QUERY_THROW constructors Change-Id: I98e34f2faa6e94d0afbdfbd4e9e92a43b0a921f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166565 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
5 daystdf#76005 add TabsRelativeToIndent, TabOverMargin compat option to dialogMohit Marathe
Change-Id: I17703c2fe388f485462bd82982664f0b4a14d537 Signed-off-by: Mohit Marathe <mohitmarathe@proton.me> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166040 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
5 daystdf#160598 SwNavigator enhancement to delete footnotes/endnotesJim Raykowski
m_bDocHasChanged is checked first in the tooltip and mouse move handlers to prevent crashes/asserts that happen when SfxPoolItemHolder m_aAttr references a delete poolitem or poolitem data. Without this check the following types of crashes/asserts can happen: ---- Unspecified Application Error Fatal exception: Signal 6 Stack: 0 sal::backtrace_get(unsigned int) at /home/lo/Dev/LO1/core/sal/osl/ unx/backtraceapi.cxx:42 (discriminator 3) 1 (anonymous namespace)::printStack(int) at /home/lo/Dev/LO1/core/sal/ osl/unx/signal.cxx:289 2 (anonymous namespace)::callSystemHandler(int, siginfo_t*, void*) at / home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:330 3 (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*) at /home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:427 4 __restore_rt at libc_sigaction.c:? 5 __pthread_kill_implementation at ./nptl/pthread_kill.c:44 6 __GI_raise at ./signal/../sysdeps/posix/raise.c:27 7 __GI_abort at ./stdlib/abort.c:81 (discriminator 21) 8 SalAbort(rtl::OUString const&, bool) at /home/lo/Dev/LO1/core/vcl/ source/app/salplug.cxx:412 9 Application::Abort(rtl::OUString const&) at /home/lo/Dev/LO1/core/ vcl/source/app/svapp.cxx:316 10 desktop::Desktop::Exception(ExceptionCategory) at /home/lo/Dev/LO1/ core/desktop/source/app/app.cxx:1203 (discriminator 2) 11 VCLExceptionSignal_impl(void*, oslSignalInfo*) at /home/lo/Dev/LO1/ core/vcl/source/app/svmain.cxx:176 12 callSignalHandler(oslSignalInfo*) at /home/lo/Dev/LO1/core/sal/osl/ all/signalshared.cxx:47 13 (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*) at /home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:423 14 __restore_rt at libc_sigaction.c:? 15 SfxPoolItem::Which() const at /home/lo/Dev/LO1/core/include/svl/ poolitem.hxx:225 16 SfxPoolItemHolder::Which() const at /home/lo/Dev/LO1/core/include/ svl/itemset.hxx:74 (discriminator 1) 17 SwTextAttr::GetFootnote() const at /home/lo/Dev/LO1/core/sw/inc/ txatbase.hxx:223 (discriminator 1) 18 SwContentTree::QueryTooltipHdl(weld::TreeIter const&) at /home/lo/ Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4974 19 SwContentTree::LinkStubQueryTooltipHdl(void*, weld::TreeIter const&) at /home/lo/Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4895 20 Link<weld::TreeIter const&, rtl::OUString>::Call(weld::TreeIter const&) const at /home/lo/Dev/LO1/core/include/tools/link.hxx:111 21 weld::TreeView::signal_query_tooltip(weld::TreeIter const&) at / home/lo/Dev/LO1/core/include/vcl/weld.hxx:977 22 SalInstanceTreeView::TooltipHdl(SvTreeListEntry*) at /home/lo/Dev/ LO1/core/vcl/source/app/salvtables.cxx:5154 23 SalInstanceTreeView::LinkStubTooltipHdl(void*, SvTreeListEntry*) at /home/lo/Dev/LO1/core/vcl/source/app/salvtables.cxx:5151 24 Link<SvTreeListEntry*, rtl::OUString>::Call(SvTreeListEntry*) const at /home/lo/Dev/LO1/core/include/tools/link.hxx:111 25 SvTreeListBox::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/ core/vcl/source/treelist/treelistbox.cxx:3284 26 ImplHandleMouseHelpRequest(vcl::Window*, Point const&) at /home/lo/ Dev/LO1/core/vcl/source/window/winproc.cxx:186 27 ImplHandleMouseEvent(VclPtr<vcl::Window> const&, NotifyEventType, bool, long, long, unsigned long, unsigned short, MouseEventModifiers) at /home/lo/Dev/LO1/core/vcl/source/window/winproc.cxx:740 28 ImplHandleSalMouseMove(vcl::Window*, SalMouseEvent const*) at /home/ lo/Dev/LO1/core/vcl/source/window/winproc.cxx:2332 29 ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) at /home/ lo/Dev/LO1/core/vcl/source/window/winproc.cxx:2665 (discriminator 1) 30 SalFrame::CallCallback(SalEvent, void const*) const at /home/lo/Dev/ LO1/core/vcl/inc/salframe.hxx:312 (discriminator 1) 31 QtFrame::CallCallback(SalEvent, void const*) const at /home/lo/Dev/ LO1/core/vcl/inc/qt5/QtFrame.hxx:228 32 QtWidget::mouseMoveEvent(QMouseEvent*) at /home/lo/Dev/LO1/core/vcl/ qt5/QtWidget.cxx:202 33 QWidget::event(QEvent*) in /lib/x86_64-linux-gnu/libQt5Widgets.so.5 34 QtWidget::event(QEvent*) at /home/lo/Dev/LO1/core/vcl/qt5/ QtWidget.cxx:738 (discriminator 2) 35 QApplicationPrivate::notify_helper(QObject*, QEvent*) in /lib/ x86_64-linux-gnu/libQt5Widgets.so.5 36 QApplication::notify(QObject*, QEvent*) in /lib/x86_64-linux-gnu/ libQt5Widgets.so.5 37 QCoreApplication::notifyInternal2(QObject*, QEvent*) in /lib/x86_64- linux-gnu/libQt5Core.so.5 38 QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool, bool) in /lib/ x86_64-linux-gnu/libQt5Widgets.so.5 39 QDesktopWidget::qt_metacall(QMetaObject::Call, int, void**) in /lib/ x86_64-linux-gnu/libQt5Widgets.so.5 40 QDesktopWidget::qt_metacall(QMetaObject::Call, int, void**) in /lib/ x86_64-linux-gnu/libQt5Widgets.so.5 41 QApplicationPrivate::notify_helper(QObject*, QEvent*) in /lib/ x86_64-linux-gnu/libQt5Widgets.so.5 42 QCoreApplication::notifyInternal2(QObject*, QEvent*) in /lib/x86_64- linux-gnu/libQt5Core.so.5 43 QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) in /lib/x86_64-linux-gnu/libQt5Gui.so.5 44 QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) in /lib/x86_64-linux-gnu/libQt5Gui.so.5 45 QXcbNativeInterface::dumpNativeWindows(unsigned long long) const in /lib/x86_64-linux-gnu/libQt5XcbQpa.so.5 46 g_main_context_dispatch in /lib/x86_64-linux-gnu/libglib-2.0.so.0 48 g_main_context_iteration in /lib/x86_64-linux-gnu/libglib-2.0.so.0 49 QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) in /lib/x86_64-linux-gnu/libQt5Core.so.5 50 QtInstance::ImplYield(bool, bool) at /home/lo/Dev/LO1/core/vcl/qt5/ QtInstance.cxx:453 51 QtInstance::DoYield(bool, bool) at /home/lo/Dev/LO1/core/vcl/qt5/ QtInstance.cxx:464 52 ImplYield(bool, bool) at /home/lo/Dev/LO1/core/vcl/source/app/ svapp.cxx:395 53 Application::Yield() at /home/lo/Dev/LO1/core/vcl/source/app/ svapp.cxx:483 54 Application::Execute() at /home/lo/Dev/LO1/core/vcl/source/app/ svapp.cxx:370 55 desktop::Desktop::Main() at /home/lo/Dev/LO1/core/desktop/source/ app/app.cxx:1617 56 ImplSVMain() at /home/lo/Dev/LO1/core/vcl/source/app/svmain.cxx:229 57 SVMain() at /home/lo/Dev/LO1/core/vcl/source/app/svmain.cxx:262 58 soffice_main at /home/lo/Dev/LO1/core/desktop/source/app/ sofficemain.cxx:93 59 sal_main at /home/lo/Dev/LO1/core/desktop/source/app/main.c:51 60 main at /home/lo/Dev/LO1/core/desktop/source/app/main.c:49 61 __libc_start_call_main at ./csu/../sysdeps/nptl/ libc_start_call_main.h:58 62 call_init at ./csu/../csu/libc-start.c:128 63 _start in /home/lo/Dev/LO1/core/instdir/program/soffice.bin ---- soffice.bin: /home/lo/Dev/LO1/core/sw/inc/txatbase.hxx:223: const SwFormatFootnote& SwTextAttr::GetFootnote() const: Assertion `m_aAttr && m_aAttr.Which() == RES_TXTATR_FTN' failed. Fatal exception: Signal 6 Stack: 0 sal::backtrace_get(unsigned int) at /home/lo/Dev/LO1/core/sal/osl/ unx/backtraceapi.cxx:42 (discriminator 3) 1 (anonymous namespace)::printStack(int) at /home/lo/Dev/LO1/core/sal/ osl/unx/signal.cxx:289 2 (anonymous namespace)::callSystemHandler(int, siginfo_t*, void*) at / home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:330 3 (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*) at /home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:427 4 __restore_rt at libc_sigaction.c:? 5 __pthread_kill_implementation at ./nptl/pthread_kill.c:44 6 __GI_raise at ./signal/../sysdeps/posix/raise.c:27 7 __GI_abort at ./stdlib/abort.c:81 (discriminator 21) 8 _nl_load_domain at ./intl/loadmsgcat.c:1177 9 __GI___assert_fail at :? 10 SwTextAttr::GetFootnote() const at /home/lo/Dev/LO1/core/sw/inc/ txatbase.hxx:224 11 SwContentTree::QueryTooltipHdl(weld::TreeIter const&) at /home/lo/ Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4974 12 SwContentTree::LinkStubQueryTooltipHdl(void*, weld::TreeIter const&) at /home/lo/Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4895 13 Link<weld::TreeIter const&, rtl::OUString>::Call(weld::TreeIter const&) const at /home/lo/Dev/LO1/core/include/tools/link.hxx:111 14 weld::TreeView::signal_query_tooltip(weld::TreeIter const&) at / home/lo/Dev/LO1/core/include/vcl/weld.hxx:977 15 (anonymous namespace)::GtkInstanceTreeView::signalQueryTooltip(_GtkWidget*, int, int, int, _GtkTooltip*, void*) at /home/lo/Dev/LO1/core/vcl/unx/gtk3/ gtkinst.cxx:14701 (discriminator 2) 16 gtk_socket_add_id in /lib/x86_64-linux-gnu/libgtk-3.so.0 17 g_closure_invoke in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 18 g_signal_handlers_destroy in /lib/x86_64-linux-gnu/ libgobject-2.0.so.0 19 g_signal_emit_valist in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 20 g_signal_emit in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 21 gtk_tooltip_set_icon_from_gicon in /lib/x86_64-linux-gnu/ libgtk-3.so.0 22 gtk_tooltip_set_icon_from_gicon in /lib/x86_64-linux-gnu/ libgtk-3.so.0 23 gtk_main_do_event in /lib/x86_64-linux-gnu/libgtk-3.so.0 24 gdk_drawing_context_get_clip in /lib/x86_64-linux-gnu/libgdk-3.so.0 25 gdk_x11_drag_context_get_type in /lib/x86_64-linux-gnu/libgdk-3.so.0 26 g_main_context_dispatch in /lib/x86_64-linux-gnu/libglib-2.0.so.0 27 g_io_channel_new_file in /lib/x86_64-linux-gnu/libglib-2.0.so.0 28 g_main_loop_run in /lib/x86_64-linux-gnu/libglib-2.0.so.0 29 main_loop_run(_GMainLoop*) at /home/lo/Dev/LO1/core/vcl/inc/unx/gtk/ gtkdata.hxx:63 30 (anonymous namespace)::DialogRunner::run() at /home/lo/Dev/LO1/core/ vcl/unx/gtk3/gtkinst.cxx:6747 (discriminator 13) 31 (anonymous namespace)::GtkInstanceDialog::run() at /home/lo/Dev/LO1/ core/vcl/unx/gtk3/gtkinst.cxx:10046 32 weld::DialogController::run() at /home/lo/Dev/LO1/core/include/vcl/ weld.hxx:2669 33 (anonymous namespace)::RecoveryUI::impl_doEmergencySave() at /home/ lo/Dev/LO1/core/svx/source/unodraw/recoveryui.cxx:258 (discriminator 1) 34 (anonymous namespace)::RecoveryUI::dispatchWithReturnValue(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at /home/lo/Dev/LO1/core/svx/source/unodraw/recoveryui.cxx:148 35 desktop::(anonymous namespace)::impl_callRecoveryUI(bool, bool) at / home/lo/Dev/LO1/core/desktop/source/app/app.cxx:1022 (discriminator 5) 36 desktop::Desktop::Exception(ExceptionCategory) at /home/lo/Dev/LO1/ core/desktop/source/app/app.cxx:1177 37 VCLExceptionSignal_impl(void*, oslSignalInfo*) at /home/lo/Dev/LO1/ core/vcl/source/app/svmain.cxx:176 38 callSignalHandler(oslSignalInfo*) at /home/lo/Dev/LO1/core/sal/osl/ all/signalshared.cxx:47 39 (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*) at /home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:423 40 __restore_rt at libc_sigaction.c:? 41 SfxPoolItem::Which() const at /home/lo/Dev/LO1/core/include/svl/ poolitem.hxx:225 42 SfxPoolItemHolder::Which() const at /home/lo/Dev/LO1/core/include/ svl/itemset.hxx:74 (discriminator 1) 43 SwTextAttr::GetFootnote() const at /home/lo/Dev/LO1/core/sw/inc/ txatbase.hxx:223 (discriminator 1) 44 SwContentTree::QueryTooltipHdl(weld::TreeIter const&) at /home/lo/ Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4974 45 SwContentTree::LinkStubQueryTooltipHdl(void*, weld::TreeIter const&) at /home/lo/Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4895 46 Link<weld::TreeIter const&, rtl::OUString>::Call(weld::TreeIter const&) const at /home/lo/Dev/LO1/core/include/tools/link.hxx:111 47 weld::TreeView::signal_query_tooltip(weld::TreeIter const&) at / home/lo/Dev/LO1/core/include/vcl/weld.hxx:977 48 (anonymous namespace)::GtkInstanceTreeView::signalQueryTooltip(_GtkWidget*, int, int, int, _GtkTooltip*, void*) at /home/lo/Dev/LO1/core/vcl/unx/gtk3/ gtkinst.cxx:14701 (discriminator 2) 49 gtk_socket_add_id in /lib/x86_64-linux-gnu/libgtk-3.so.0 50 g_closure_invoke in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 51 g_signal_handlers_destroy in /lib/x86_64-linux-gnu/ libgobject-2.0.so.0 52 g_signal_emit_valist in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 53 g_signal_emit in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 54 gtk_tooltip_set_icon_from_gicon in /lib/x86_64-linux-gnu/ libgtk-3.so.0 55 gtk_tooltip_set_icon_from_gicon in /lib/x86_64-linux-gnu/ libgtk-3.so.0 56 gtk_tooltip_trigger_tooltip_query in /lib/x86_64-linux-gnu/ libgtk-3.so.0 57 GtkSalFrame::ShowTooltip(rtl::OUString const&, tools::Rectangle const&) at /home/lo/Dev/LO1/core/vcl/unx/gtk3/gtkframe.cxx:3154 58 ImplShowHelpWindow(vcl::Window*, unsigned short, QuickHelpFlags, rtl::OUString const&, Point const&, tools::Rectangle const&) at /home/ lo/Dev/LO1/core/vcl/source/app/help.cxx:492 59 Help::ShowQuickHelp(vcl::Window*, tools::Rectangle const&, rtl::OUString const&, QuickHelpFlags) at /home/lo/Dev/LO1/core/vcl/ source/app/help.cxx:191 (discriminator 5) 60 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 61 ImplBorderWindow::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/ core/vcl/source/window/brdwin.cxx:1673 62 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 63 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 64 ImplBorderWindow::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/ core/vcl/source/window/brdwin.cxx:1673 65 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 66 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 67 SplitWindow::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/splitwin.cxx:2117 68 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 69 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 70 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 71 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/ vcl/source/window/window.cxx:1928 72 ImplHandleMouseHelpRequest(vcl::Window*, Point const&) at /home/lo/ Dev/LO1/core/vcl/source/window/winproc.cxx:186 73 ImplHandleMouseEvent(VclPtr<vcl::Window> const&, NotifyEventType, bool, long, long, unsigned long, unsigned short, MouseEventModifiers) at /home/lo/Dev/LO1/core/vcl/source/window/winproc.cxx:740 74 ImplHandleSalMouseMove(vcl::Window*, SalMouseEvent const*) at /home/ lo/Dev/LO1/core/vcl/source/window/winproc.cxx:2332 75 ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) at /home/ lo/Dev/LO1/core/vcl/source/window/winproc.cxx:2665 (discriminator 1) 76 SalFrame::CallCallback(SalEvent, void const*) const at /home/lo/Dev/ LO1/core/vcl/inc/salframe.hxx:312 (discriminator 1) 77 GtkSalFrame::CallCallbackExc(SalEvent, void const*) const at /home/ lo/Dev/LO1/core/vcl/unx/gtk3/gtkframe.cxx:6388 78 GtkSalFrame::DrawingAreaMotion(int, int, unsigned int, unsigned int) at /home/lo/Dev/LO1/core/vcl/unx/gtk3/gtkframe.cxx:3719 79 GtkSalFrame::signalMotion(_GtkWidget*, _GdkEventMotion*, void*) at / home/lo/Dev/LO1/core/vcl/unx/gtk3/gtkframe.cxx:3756 80 gtk_socket_add_id in /lib/x86_64-linux-gnu/libgtk-3.so.0 81 g_closure_invoke in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 82 g_signal_handlers_destroy in /lib/x86_64-linux-gnu/ libgobject-2.0.so.0 83 g_signal_emit_valist in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 84 g_signal_emit in /lib/x86_64-linux-gnu/libgobject-2.0.so.0 85 gtk_widget_init_template in /lib/x86_64-linux-gnu/libgtk-3.so.0 86 gtk_grab_remove in /lib/x86_64-linux-gnu/libgtk-3.so.0 87 gtk_main_do_event in /lib/x86_64-linux-gnu/libgtk-3.so.0 88 gdk_drawing_context_get_clip in /lib/x86_64-linux-gnu/libgdk-3.so.0 89 gdk_x11_drag_context_get_type in /lib/x86_64-linux-gnu/libgdk-3.so.0 90 g_main_context_dispatch in /lib/x86_64-linux-gnu/libglib-2.0.so.0 91 g_io_channel_new_file in /lib/x86_64-linux-gnu/libglib-2.0.so.0 92 g_main_context_iteration in /lib/x86_64-linux-gnu/libglib-2.0.so.0 93 GtkSalData::Yield(bool, bool) at /home/lo/Dev/LO1/core/vcl/unx/gtk3/ gtkdata.cxx:405 (discriminator 6) 94 GtkInstance::DoYield(bool, bool) at /home/lo/Dev/LO1/core/vcl/unx/ gtk3/gtkinst.cxx:436 95 ImplYield(bool, bool) at /home/lo/Dev/LO1/core/vcl/source/app/ svapp.cxx:395 96 Application::Yield() at /home/lo/Dev/LO1/core/vcl/source/app/ svapp.cxx:483 97 Application::Execute() at /home/lo/Dev/LO1/core/vcl/source/app/ svapp.cxx:370 98 desktop::Desktop::Main() at /home/lo/Dev/LO1/core/desktop/source/ app/app.cxx:1617 99 ImplSVMain() at /home/lo/Dev/LO1/core/vcl/source/app/svmain.cxx:229 100 SVMain() at /home/lo/Dev/LO1/core/vcl/source/app/svmain.cxx:262 101 soffice_main at /home/lo/Dev/LO1/core/desktop/source/app/ sofficemain.cxx:93 102 sal_main at /home/lo/Dev/LO1/core/desktop/source/app/main.c:51 103 main at /home/lo/Dev/LO1/core/desktop/source/app/main.c:49 104 __libc_start_call_main at ./csu/../sysdeps/nptl/ libc_start_call_main.h:58 105 call_init at ./csu/../csu/libc-start.c:128 106 _start in /home/lo/Dev/LO1/core/instdir/program/soffice.bin Change-Id: Id2bad55221a8603a1e12f870bdc1479e7709ee58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166414 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
6 days[API CHANGE] a11y: Use XAccessible for relation targetsMichael Weghorn
Use a Sequence of XAccessible rather than its base interface XInterface for AccessibleRelation's TargetSet. As the targets are accessible objects as well, anything other than XAccessible doesn't make much sense. Using XAccessible right away makes that clearer and avoids the need to query the XAccessible interface. (The winaccessibility bridge was already using `static_cast`, relying on the fact that the objects are XAccessibles.) The a11y UNO API is not published, so an API change should be unproblematic. Change-Id: I7f08e98d1ec303d5343d9a7954187cdd71495ebc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166586 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
6 daysSwContentTree: Don't show 'Delete' menu item when read-onlyJim Raykowski
Change-Id: Ib3a1ec5635937b2dcb26144f621ee0bf4a0101d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166413 Reviewed-by: Jim Raykowski <raykowj@gmail.com> Tested-by: Jenkins
6 daysRework SwContentTree context menu item 'Rename' inclusionJim Raykowski
Change-Id: Ice211a3026d07a21b1b6e47ee1c16086401714d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166412 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
6 daysResolves tdf#132253 - Remove hyperlink tab from character dialogHeiko Tietze
Change-Id: Idb7fa74dbe196262cea64946452043f7de6fa20c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166553 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
6 daystdf#160253: fix list identifier export decision codeMike Kaganski
Commits 8f48f91009caa86d896f247059874242ed18bf39 (ODT export: omit unreferenced <text:list xml:id="...">, 2022-03-10) and 82bbf63582bdf28e7918e58ebf6657a9144bc9f3 (tdf#155823: Improve the check if the list id is not required, 2023-06-14) tried to improve deterministic ODF output, by omitting the list identifiers in case when those identifiers were unreferenced. The latter of these used document model node numbers to check if other lists appeared after the last occurrence of the list that is continuing in the current node. But it turned out, that this isn't robust. Consider this ODF: <text:list xml:id="list1" text:style-name="L1"> <text:list-item> <text:p>a</text:p> </text:list-item> </text:list> <text:p>b<text:note text:id="ftn1" text:note-class="endnote"><text:note-citation>i</text:note-citation><text:note-body> <text:list text:style-name="L2"> <text:list-item> <text:p>x</text:p> </text:list-item> </text:list></text:note-body></text:note></text:p> <text:list text:continue-list="list1" text:style-name="L1"> <text:list-item> <text:p>c</text:p> </text:list-item> </text:list> The paragraphs a, b, and c are all in the main document body, and have sequential document model node numbers (say, 15, 16, 17). If these numbers are checked, there is no node between node 15 ("a") and node 17 ("c") with a different list (both 15 and 17 belong to a list with style "L1" and identifier "list1", and node 16 doesn't belong to any lists). That suggests that the list identifier isn't needed in this case. Bug when the actual output of node 16 is done, it includes a node from an endnote ("x"), which is located in a different place in the document model, and has a node number like 7 (so not between 15 and 17). The paragraph "x" belongs to another list with style "L2", and is output to ODF between paragraphs "a" and "c". Here, we must refer from paragraph "c" to the list of the paragraph "a" using the list id, but this is not obvious when only considering node numbers, and requires the prior knowledge of the actual order of appearance of lists in the ODF. Unless we build a DOM, this is only possible, if we do a two-pass output, and collect the nodes order in the first pass. The output already does that in a "collect autostyles" pass. The problem here is that the "collect autostyles" pass used an optimized function, XMLTextParagraphExport::collectTextAutoStylesOptimized, introduced in commit 8195d7061ed52ebb98f46d35fe5929762c71e4b3 (INTEGRATION: CWS swautomatic01 (1.126.4); FILE MERGED, 2006-12-01) for #i65476# and which used style::XAutoStylesSupplier for optimization to get the autostyles. This drops XMLTextParagraphExport::collectTextAutoStylesOptimized, and reverts to use of collectTextAutoStyles, which handles nodes in the same order as when writing to ODF. There, we build a vector of the node numbers sequence, used later to sort DocumentListNodes. This uncovered an omission from the work on paragraph mark (commit 1a88efa8e02a6d765dab13c7110443bb9e6acecf tdf#155238: Reimplement how ListAutoFormat is stored to ODF, 2023-05-11). Turns out, that the code in SwTextFormatter::NewNumberPortion introduced in commit cb0e1b52d68aa6d5b505f91cb4ce577f7f3b2a8f (sw, numbering portion format: consider full-para char formats as well, 2022-10-20) was left behind when re-implementing paragraph marks to use dedicated property; empty trailing spans still affected how the lists were rendered, and that allowed to overlook import defects, where the paragraph mark properties weren't properly set. In ODF import (XMLParaContext::endFastElement), for compatibility, this treats empty trailing spans as defining paragraph mark (when the paragraph mark wasn't set explicitly). This way, the trailing spans get converted to the paragraph mark. In WW8 import, last cell paragraphs didn't call the code handling the paragraph marks. This is also fixed now. The changes result in slightly different numbering of autostyles in the ODF. It seems, that the new numbering more closely follows the order of appearance of the autostyles in the output; and some cases of autostyles that were written, but unreferenced, are now eliminated. The unit tests were updated accordingly. I hope that the performance impact on the export time would not be too large. It is unclear why outline numbering exports a list element at all. Fixing that to not emit the list element is a separate task / TODO. Change-Id: I5c99f8d48be77c4454ffac6ffa9f5babfe0d4909 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166572 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
7 daysloplugin:singlevalfieldsNoel Grandin
Change-Id: I4d7b38c90d73a00f4dbc8ad7318fe4573328ed46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166503 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
7 daystdf#159379 sw: fix crash on dropping multiple as-char imagesMiklos Vajna
Have an empty Writer document, set preferences so images created via drag&drop are anchored as-char, drop 2 images from a file manager, crash. The root of the problem is that the first image gets dropped fine, but the second one would be anchored to the currently selected graphic node, since commit 651527b4efe9700c8c8dff58ce5aa86ad5681f16 (sw: fix double-click opening frame dialog, not graphic dialog on images, 2022-04-26). The new SwTextCursor::GetModelPositionForViewPoint() returning a graphic node for a point inside the image looks correct, so fix the problem by extending SwFEShell::Insert() to take the anchor position as the anchor for the new image, in case a graphic node is selected. The original use-case would use SwEditWin::ExecuteDrop(), but keep the test simple and invoke the underlying SwFEShell::Insert() instead, that also triggers the problem. Change-Id: Ibba57aa28d0616ded16b4abb314f04974f1b8f9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166499 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
8 daysResolves tdf#160731 Navigate by recency does not work under gtk3 +Jim Raykowski
wayland I think the lines of code removed by this patch were meant to allow recency to remember the cursor position before being moved to a start/ end/previous/next word or sentence position by an UNO dispatch command. These are already taken care of in the slot execute function void SwTextShell::ExecMoveLingu. Change-Id: I8bf231ea4cbb03125f54332a41c5544f9094b768 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166350 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
9 daysResolves tdf#58434 - Show formatting marks independently from fieldsHeiko Tietze
Field Shading / .uno:Marks toggles now only fields, footnotes, tox etc. and Tab, SoftHyphen, Blank, as well as ControlChar depends now on Formatting Marks / .uno:ControlCodes. Field Shading also does not toggle HardBlank and SoftHyphen, and what control character is shown respect the options under Formatting Aids Change-Id: I63c826e7fdc09ec95f17aee9735d4f5de9a1b897 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166033 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
10 daystdf#81956 vml import: put groupshape in foreground if positive z-indexJustin Luth
no interesting unit tests found, but this one at least lets you add text to the body and visibly see the effect of foreground/background. make CppunitTest_sw_ooxmlimport CPPUNIT_TEST_NAME=testN751077 Change-Id: Ib03e6b429ad4ec6a38d1119f3720bc56a70b98eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166345 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
10 daystdf#146190 Fix move to next drawing object using the tab keyJim Raykowski
after double click on a drawing obect in the Navigator doesn't move to the next/previous drawing object when there is a number rule at the current current cursor position and the current cursor position is at the start of a paragraph. This patch reworks the SwWrtShell::GotoDrawingObject function so the document cursor position gets moved to the position of the drawing object when the object is selected. Another way to get expected results is to leave the GotoDrawingObject function as is and move: else if (rSh.GetSelectionType() & (SelectionType::Graphic | SelectionType::Frame | SelectionType::Ole | SelectionType::DrawObject | SelectionType::DbForm)) above the: else if( rSh.GetNumRuleAtCurrCursorPos() && rSh.IsSttOfPara() && !rSh.HasReadonlySel() ) in the SwEditWin::KeyInput function case KEY_TAB: block. SwWrtShell::GotoDrawingObject is made SW_DLLPUBIC by this patch to able to be used by the included unit test. Change-Id: I047b416ae94a9284d304798924e0c5f2be526f85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166089 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
10 daysloplugin:constantparam in swNoel Grandin
Change-Id: Ibb4d4d1cca59ece6bcd28e887f84d657dedee756 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166314 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
10 daysloplugin:constantparam in swNoel Grandin
Change-Id: Ia1379762ba957097a1a2134c5d206f254e22683b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166313 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
10 daysloplugin:constantparam in swNoel Grandin
Change-Id: Idf7d3abd464b7be87d109d14adf94357a5d49dd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166312 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
10 daysloplugin:constantparam in swNoel Grandin
Change-Id: Ia3e1b50954354973ffef701821f661cf782687db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166311 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
11 daystdf#140616 ApplyParagraphMarkFormatToNumbering: including highlightJustin Luth
I was concerned that I might override highlights set in numbering.xml but in that case pFormat && pFormat->hasItem(RES_CHRATR_HIGHLIGHT) so pCleanSet no longer hasItem. (see num3n.docx and TestDoc_highlight2.docx) Note: must use Word 2010+ to see numbering.xml highlights!! This is strictly a visual thing. Unit testing has traditionally used magic tile rendering x,y positions to check the color, which seems completely untrustworthy. Change-Id: I026252f127107e4782d08f72bfd5e2a412142111 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166303 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
generated by cgit (git 2.34.1) at 2024-04-30 14:57:28 +0000