summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2016-03-09Resolves: tdf#82781 avoid dereferencing invalid iteratorsCaolán McNamara
when using print preview with cursor on 2nd page which consists solely of hidden text with show hiddle text enabled. inner mrParentViewShell.Paint can invalidate iterators, as later detected with the mbNewLayoutDuringPaint flag but we dereference for the purposes of drawing the shadow before we get there. easiest thing seems to be to just grab the bits of info we want before the inner paint occurs. Change-Id: I09c9b06449db440b7beba7de9e71c239ee64f6ca
2016-03-09Move classified copy/paste strings from sw to sfx2Miklos Vajna
So that other modules can use them as well. The RTF import in writerfilter is one potential user. Change-Id: Ib009e1be2aff14d0fcac643c0c6000d2895515b0
2016-03-09RTF export: write user-defined document propertiesMiklos Vajna
Change-Id: I07dfd626f7d248e264fd1724f6f2bd1241be39d0
2016-03-09RTF import: handle \staticvalMiklos Vajna
With this, user-defined document properties are imported from RTF. Change-Id: I8dfb8e802bd26906827620550d6f5d88f047d364
2016-03-09CppunitTest_sw_uiwriter: add classification copy/paste testcaseMiklos Vajna
Change-Id: Ic3ac02fe28bee0ea3189fb2c9d3548f5ca13fe5c
2016-03-09Move copy/paste classification check from sw to sfx2Miklos Vajna
So that it's easy to unit test it and other apps can use it as well in the future. Change-Id: I38d601924b7fbb17615ff6e9c031a71b40777c4c
2016-03-09loplugin:defaultparamsStephan Bergmann
Change-Id: I2024819c7c9e582e6c3dbf431964a730a2f3fc5e
2016-03-09loplugin:defaultparamsStephan Bergmann
Change-Id: Ief616bc74965b2938834ac9ffd66a03c6433d259
2016-03-09remove unused NOT_POOLABLE enum valueNoel Grandin
and simplify the resulting SfxItemInfo field down to a single bool Change-Id: I73e24e83d39afc7660ac85872ba96bc790713cb2 Reviewed-on: https://gerrit.libreoffice.org/23058 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-09loplugin:defaultparamsStephan Bergmann
Change-Id: I3e48d61607dd54bc0d0f35308e388037283267ad
2016-03-09Indentation fixesMiklos Vajna
Change-Id: I536ab12cfedb6dae605af2f29a7a9b34fad06ba0
2016-03-09sw testcases: avoid using UI name for default style nameMiklos Vajna
Change-Id: Ic2e08245dd022555ad6308283d406d81141a9124
2016-03-09loplugin:constantparam in sfx2Noel Grandin
Change-Id: I50a2d8221f907f0e844e558f3dbdd0346c010201
2016-03-09loplugin:constantparam in svlNoel Grandin
Change-Id: Iefc441262cbdc6f115ea4ca5a673456b59477e13
2016-03-09loplugin:constantparam in svxNoel Grandin
Change-Id: Ib2a432fc334898c75ab5e5cf629a21fd310bd467
2016-03-09loplugin:constantparam in swNoel Grandin
Change-Id: I8fa1af4a34770b71f6f4bb28b3313edf4875322b
2016-03-08tdf#87530 finish the regression testMichael Stahl
Need to store the document twice to actually reproduce the bug. Change-Id: I2332bce1e30546b3a9fe2ec020f2eea8e8d0da58
2016-03-08sw: detect copy&paste between different classification levelsMiklos Vajna
With this we cover all 4 cases of copy&paste between possibly classified documents. When both are classified, then we also check the classification level, if they have the same scale. Change-Id: I8c02781fc9755114cd6a2fb93be11dca7b3441d0
2016-03-08Unused defineMaxim Monastirsky
Change-Id: I3f0218ad6fec542d285bfbfdd2d508375f74dee5
2016-03-08sw: detect copy&paste from classified to non-classified documentsMiklos Vajna
It still allows copy&paste between different classification levels, though. Change-Id: I142b6c2ab752a5b786fe6a16e29a89e549254d0f
2016-03-08Move anchor submenu to separate popupmenu fileMaxim Monastirsky
Objectives: - Reduce copy-paste, by defining the list of commands only once, and reusing everywhere (menubar, context menu, toolbar button). - Kill SwTbxAnchor. Once we have separate popupmenu, we can just load it with the generic controller. Change-Id: I5a8b47892471e293ee2331915361f8ce256dc76c
2016-03-08loplugin:constantparam in xmloffNoel Grandin
Change-Id: I531dcf0861ab5a545eec16bf4aa92ac92eb9626e Reviewed-on: https://gerrit.libreoffice.org/23022 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-08tdf#97601 sw: don't mark an already modified chart as modifiedMiklos Vajna
Regression from commit e2b260fc98e833d4e64426b90992094f2da0498c (sw: let layout not mark embedded object as modified, 2014-06-03), an infinite loop was caused by: 1) SwDoc::SetOLEObjModified() triggering the maOLEModifiedIdle Idle 2) which at the end called SwWrtShell::CalcAndSetScale() 3) which at the end called chart::ChartModel::setModified() 4) where chart code called back into SwDoc::SetOLEObjModified() via the modification listener, and this happened again and again. The original fix wanted to avoid marking the document as modified without a user interaction, so fix the bug by only calling setModified() if it prevents a not-modified -> modified transition. This keeps the original bug fixed, but prevents the infinite loop, that is always a modified -> modified transition. Change-Id: I3b56a91afaacd3e0b7cb646a492fd15f1b5168ee
2016-03-07tdf#65219 Fix temp files clean up in sw unit testsAleksas Pantechovskis
Change-Id: I57f4dc90bc2ad8488af8cd42515b195f4320a9d9 Reviewed-on: https://gerrit.libreoffice.org/22939 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-07drop now-needless depsDavid Tardon
Change-Id: I2ef0b873a58710de399889cee3abf6b6ecf4fb1e
2016-03-07remove remaining uses of gb_SrsTemplateTarget_get_targetDavid Tardon
Change-Id: I5ddf0ba5fc289a124b39b9c14b7f5fdd3d7b54a4
2016-03-07expand src templatesDavid Tardon
Change-Id: Id35caa8b8ed0c2f7e4d868f5c87a2a0f331cb352
2016-03-07these ResIds are used solely for their number by nowCaolán McNamara
so cut out the middle-man ResId Change-Id: Ic83db355cc1a0c7dc70958bca79b466baadaedd0
2016-03-07loplugin:write only fieldsNoel Grandin
Change-Id: Ia0fb487c5590e096659b81f76c4dc543e184c59c
2016-03-07Resolves: tdf#96172 crashtesting: avoid crash in layoutCaolán McNamara
sectfrm is riddled with workarounds for "half dead" section frames. This is yet another one. Change-Id: Ic03ad8971002d7dce308475f1497d1dda8045d15
2016-03-07convert DEFINE to anonymous functionCaolán McNamara
Change-Id: I9b62f02ac0013d1da13c176155c5742972a43fe3
2016-03-07OSL_ENSURE followed by deref -> assertCaolán McNamara
Change-Id: Ib815da2f341096775052d2280d62a210a856fdf8
2016-03-07basic: tdf#87530 don't copy storage that doesn't existMichael Stahl
If the Basic library is newly created it may not have been stored to the document storage yet. (regression from 5246fa262450f686674850c53df666422f441c86) Change-Id: I9c2fc1d7446795b9c1c2224671118b2a671dcad8
2016-03-07loplugin:unuseddefaultparamsNoel Grandin
Change-Id: Ia414f7845425ef73859ed04853378e96cc738795 Reviewed-on: https://gerrit.libreoffice.org/22971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07fix build, this time for realDavid Tardon
Change-Id: I9dbaedc6b4427399618261cac35b2ab9caddc54e
2016-03-07fix buildDavid Tardon
Change-Id: I372e87f94b52c9880662573a56f28b07fede7d8d
2016-03-07fix buildDavid Tardon
Change-Id: If6e42d519187990b27fbf15f22d600af86d952f0
2016-03-07expand src templates only used in a single placeDavid Tardon
Change-Id: I0af62539f9dfe636eb242acd766559ffe1097217
2016-03-07improve defaultparams lopluginNoel Grandin
to catch calling params with defaults like "= OUSString()" Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9 Reviewed-on: https://gerrit.libreoffice.org/22932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-06cppcheck: help it a bit to not fail with syntax error in its ASTJulien Nabet
Change-Id: I22e1405b2ad94ec4d47011c3f11d108a1bde4fba
2016-03-06cppcheck: fix redundantConditionJulien Nabet
Change-Id: I4b8883ae7e0bf0990ae8736dba598ab3943ad401
2016-03-05tdf#87610 Replace Bookmark with Anchor in Writer WebYousuf Philips
Change-Id: Ia698aec5a4ea9bb2452263f5ff975e045da66393 Reviewed-on: https://gerrit.libreoffice.org/22747 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2016-03-04Resolves: tdf#98399 RET_USER_CANCEL is non-zero and returned on cancelCaolán McNamara
Change-Id: Id4231454dfb34cac6ee89d63beb18a83c63a44c1
2016-03-04sw, sd: indentation fixesMiklos Vajna
Change-Id: I4813488d94e6ae2877cdaf39a3849bccb83c389d
2016-03-04loplugin:unuseddefaultparam in swNoel Grandin
Change-Id: I1a8a25c09ae0c8ba39fcedb032562df93fdd6ba4
2016-03-03tdf#98224: endless loop in replace all stoppedOliver Specht
If a drawing in the document contains the search text then the selection of that object removes a selection (SwShellCursor) that marks the end of the search. This is now fixed for that special case. Replacing text in drawing doesn't work - as before and also not all occurrences of the searched text are found. Change-Id: I4a10ddf2dc547572ebb55b6355439d6e320bc980 Reviewed-on: https://gerrit.libreoffice.org/22851 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-03-03Break SmartTagMenuController-VCLXMenu cycleMaxim Monastirsky
Change-Id: I6da45f6b6750f78d309fa3080eada1931640f188
2016-03-02sw: tdf#91131 when renaming a SwNumRule, also ...Michael Stahl
... update the DocumentListsManager::maLists because without that all list styles created in the UI will have GetDefaultListStyleName() == "Untitled1" and then deleting one of them deletes all these entries from maList, which makes the DocumentListsManager unhappy. Change-Id: Ic40e561fc540881ab29566a3f5ecdc8a180c97ef
2016-03-02sw: SwDoc::RenameNumRule() relies on caller checking that ...Michael Stahl
... the new name is not being used. Change-Id: Idd392fa4ab6379ec21c5b308767c052bf28fa5aa
2016-03-02loplugin:unuseddefaultparam in sfx2Noel Grandin
Change-Id: I37afde801a6468c79259fe51acbdea0614c2c8c5