summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2014-12-18XmlTestTools: fix conversion from UTF-8 xmlChar strings to OUStringStephan Bergmann
...which resolves the mystery of 0ba6360363fb73b5b200bbc486ed8eeac5f3d337 "Garbage in, garbage out?" Change-Id: I51f102699d0474872c80392b27f71030b5e3fb59
2014-12-18Factor out SvxFontHeightItem::dumpAsXml() from swMiklos Vajna
Change-Id: I8dc3a0ed7bfce62b0d20c6bff143d77c0f26963f
2014-12-18Related fdo#86929: Kill FOREACHPAM_START for good (final part)Julien Nabet
Change-Id: I74c6e8633ee5ac477d2f7ac8ee468204076bc886 Reviewed-on: https://gerrit.libreoffice.org/13488 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-18fdo#85876: add unittestBjoern Michaelsen
rather uglyish unittest, but still worth it as cutting nothing needing to have sideeffects is really kind of non-obvious and prone to return Change-Id: I02bbfb05f019874d873670cdae060ac3183f5ca6
2014-12-18SwNodeIndex should really be finalBjoern Michaelsen
Change-Id: I2ae917b43b18b14dce01121902a678d45ad520fe
2014-12-17Introduce rtl::OUStringLiteral1Stephan Bergmann
...to use single ASCII character literals "more directly" in the OUString API (instead of having to go via an intermediary OUString ctor call). Especially useful for character literals that are defined as const variables or via macros ("direct" uses of character literals in the OUString API can often simply be replaced with single-character string literals, for improved readability). (The functions overloaded for OUStringLiteral1 are those that are actually used by the existing LO code; more could potentially be added. The asymmetry in the operator ==/!= parameter types is by design, though---writing code like 'x' == s is an abomination that shall not be abetted.) Change-Id: Ic5264714be7439eed56b5dfca6ccaee277306f1f
2014-12-17Garbage in, garbage out?Stephan Bergmann
Non-ASCII characters (like Unicode "é", represented as two bytes \xC3 \xA9 in the UTF-8--encoded source file, and presumably passed trhough unchanged by compilers into the resulting string literal object) in the OUString "literal" ctor trigger a SAL_WARN_IF in rtl_uString_newFromLiteral, but are copied "verbatim" into the resulting OUString, which will thus contain UTF-16 code units \x00C3 \x00A9 (if char is unsigned) resp. \xFFC3 \xFFA9 (if char is signed). That assertXPathContent shall indeed match such an odd OUString value looks suspiciously like a bug elsewhere, papered over by a broken test. To be investigated. Change-Id: I07c995ad0e17235c214d7630fb34e8ef35d5ad30
2014-12-17sw: prefix SwLayoutFrm::pLowerMichael Stahl
Change-Id: I844c00639307c14140ba7e8a1b919e3f2ecdc114
2014-12-17fdo#75757 Remove inheritance to std::vectorMichaël Lefèvre
Change-Id: I5d5746869e47a1d25d6bec28452394e215d4427d Reviewed-on: https://gerrit.libreoffice.org/13483 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-17Factor out SvxBrushItem::dumpAsXml() from swMiklos Vajna
Change-Id: I5421cf5a7d1a2ff4db81d028f44a490c234b9ccf
2014-12-16(related fdo#84685): writerfilter: RTF import: support \tc TOC entryMichael Stahl
Change-Id: Icda252e1f092707728d3a24df50fba7080e759bb
2014-12-16fdo#84685: writerfilter: RTF import: support \xe index entryMichael Stahl
Change-Id: Ia957541a5997961aa86b2eb8537ebd29d3092691
2014-12-16fdo#86857: sw: fix HTML export of page style background colorMichael Stahl
SwPageDesc no longer contains RES_BACKGROUND but XATTR_FOO. Change-Id: Ie722b0279f9d9831338f6613a4722010afd1543e
2014-12-16Related: #i123653# skip ranges that end before starting pointCaolán McNamara
fix assert on loading ooo123653-1, we don't care about ranges that end before the starting point we are interested in Change-Id: I46ddf882ce4099dbcd77c62569c5c51f1ce5aa76
2014-12-16Factor out SvxFontItem::dumpAsXml() from swMiklos Vajna
Change-Id: I8283ddd868639e6535e27798d91a7273d77f048c
2014-12-16WaE: replace '+' between string literals with juxtapositionTor Lillqvist
Change-Id: I64690ce1d6960dea52bae6a5bc1d0f1de742cb63
2014-12-16HTML export: optional CSS2 dot leaders in the Table of ContentsLászló Németh
To use it, enable "Print layout" in Options->Load/Save->HTML Compatibility, and select the HTML Document file type in the Writer Save As dialog. Change-Id: I763ab8340a59050fd5c68677715679f41fd91fb3
2014-12-15fdo#74981: sw: fix input field handling when splitting paragraphsMichael Stahl
The SwInputFld is copied because it doesn't have HasDummyChar() set although it has 2 dummy characters; TODO why is that... Change-Id: Iee91c1d0cf7a7a928e7383c1839f8192e8d4d5b0
2014-12-15fdo#85876: Revert "fdo#74981: cutting nothing should do nothing, ...Michael Stahl
... should fix field dupes" This reverts commit f384598d8eec91c3c0f84a07ff3e59b8e3e13b3f. The attributes have to be copied in case splitting a paragraph creates an empty paragraph. Change-Id: Icd5730dd9ab8a68f737492645988a4d2f07af7a0
2014-12-15Related fdo#86929: Kill FOREACHPAM_START for good (part1)Julien Nabet
Change-Id: Ifdb896108cf0db0a9be7ba419df785da536c0fab Reviewed-on: https://gerrit.libreoffice.org/13465 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2014-12-15Related fdo#86929: Kill FOREACHPAM_START for good (part2)Julien Nabet
Change-Id: Ia6e166a4158d28f1a4145e51040f2f5637827197 Reviewed-on: https://gerrit.libreoffice.org/13466 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2014-12-15fdo#82614: sw: Revert "Simplify code path"Michael Stahl
This reverts commit 07c00671443f3f0a2e2e6c3a54c391f040e8fd2b. The bug is because the check of the GotoHeaderTxt() is inverted. Actually in the old code it is a bit easier to understand what is intended, even though it is more verbose, so just revert the commit.
2014-12-15fdo#86671 Swap default order of Yes/No to suit what Windows users expectAdolfo Jayme Barrientos
Change-Id: Iac3917c42ff70b6cd594355fe5296aff97cb70b9 Reviewed-on: https://gerrit.libreoffice.org/13453 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-12-15Resolves: fdo#87199 deregister during destroy as lower of upperCaolán McNamara
Change-Id: I7e52bba78a0fbe32814510b44ad049d3504e7164
2014-12-15java: remove some unused fields and variablesNoel Grandin
Change-Id: I5d6071096307adbe7df0178000346cf915afa3e7 Reviewed-on: https://gerrit.libreoffice.org/13477 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-15Resolves: fdo#87248 assume 0 chse means use encoding that matches lidCaolán McNamara
Change-Id: I813cc6bdc92b03bdfdd5202a85e958020a9c52c8
2014-12-15coverity#1078451 Unchecked return valueCaolán McNamara
Change-Id: I286df7dc70e7f8e6e911f02d2e8aa6ebb390ef61
2014-12-15sw: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I559d1e44d9096a2583af8e05468b3743ac210c6c
2014-12-15Unused includesMiklos Vajna
Change-Id: I84e475a64cf09e4eeea524b73f8febf7f0a1a46b
2014-12-15Factor out SwNumRuleItem::dumpAsXml() from nodedumpMiklos Vajna
Change-Id: I893d358f8a842e19248cfeb151170ed2872c3dae
2014-12-14Factor out SfxUInt16Item::dumpAsXml() from swMiklos Vajna
Change-Id: Ia58bed9c4a0be4b909789e8bdcd64f06230c0f43
2014-12-14fdo#86761 RTF import: positive border width and fLine=0 means no borderMiklos Vajna
Regression from 01a32b7d074511bed24044dc94e1159aea62722b (fdo#85179 RTF filter: import image border, 2014-10-23), there were a number of problems here: - CppunitTest_sw_htmlexport: revert back to the old behavior, where in case there is no border, we don't set the color of it. - The testcase of the above commit omitted fLine=1 shape property, which is present in the original bugdoc, and only with that should we put a border around the shape. - Let fLine=1 explicitly change the line style from NONE. - dmapper: if line style is NONE, then don't bother setting the border color and width. Change-Id: Iffee41066d42822b699c478821645b9742df3f58
2014-12-13Fix build for iOSTor Lillqvist
Change-Id: Ib2c1d439866764a5c3510f0796efe6bc0d8d2a1e
2014-12-12coverity#1257108 Explicit null dereferencedCaolán McNamara
Change-Id: Ic4d9c99c8a2b994cec8828808d02a46ec6a18e2c
2014-12-12coverity#1257736 Explicit null dereferencedCaolán McNamara
Change-Id: I2cd312255f80e22ead614d0ea12a2130fb8bbeaa
2014-12-11coverity#1257737 Dereference null return valueCaolán McNamara
Change-Id: Idc4dfb74734f1203586b04ea86a05905f5dac694
2014-12-11DOCX export: handle <w:autoHyphenation/>Miklos Vajna
Change-Id: Ie4bb2b3bf7d2df58c30a54ded68f7b932c2111ed
2014-12-11fdo#85486 - Clean up unnecessary enumerations from xenum.hxxRadu Ioan
Removed XGradientStyle Reviewed on: https://gerrit.libreoffice.org/13320 Change-Id: Iff662c05105c3a939104f658f2d0be7d8cb57995
2014-12-11DOCX export: don't write w:suppressAutoHyphens unconditionallyMiklos Vajna
Change-Id: I0e716f1c6d5034774247264cd098ede14601f751
2014-12-11WaE: C4101: 'rException' : unreferenced local variableTor Lillqvist
Change-Id: I7bb396cee015e36a02a8afb30a4f09f33fb5507c
2014-12-11Add undo operation for deleting a bookmark + unit test, related fdo#51741Matúš Kukan
Change-Id: I79d8d3c30b6b0b2cc253963fdd50019aec033e12
2014-12-11-Werror,-Wunused-variableStephan Bergmann
Change-Id: I7afbcb0fb24406e9331cbfb104f0625e6e8fe14e
2014-12-11Remove resizable:False property from dialogs containing GtkEntry.Jan Holesovsky
As agreed with Adolfo (and others) at the Design hangout on 2014-12-10. Change-Id: Ibe0e8075566523e746866b9d2c15c348c345d2df
2014-12-11Factor out SvxCharRotateItem::dumpAsXml() from swMiklos Vajna
Change-Id: I52bca77e8ff0d4fccf8423f01dac9b6a7498f8d1
2014-12-11java: reduce visibility of fields and methodsNoel Grandin
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10fdo#75137: Can't Move Cursor Between Footnotes with Up/Down Arrow KeysTakeshi Abe
This fixes a regression introduced at 43941d9a5313fcd7fe39a61bd2eace64f7743486. Change-Id: If73883569049f0f3ae8a2d40f6704f74e63eecb2 Reviewed-on: https://gerrit.libreoffice.org/13401 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-12-10Typo: postion(s)=>position(s)Julien Nabet
Change-Id: Id2957f1cb68fc4b2fef9966abeb6745b548bcb75
2014-12-1032/64 bit type mismatchDavid Ostrovsky
Change-Id: I4ca19e6efed8ba1ef724136c577a3dcac80f7d62 Reviewed-on: https://gerrit.libreoffice.org/13365 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-12-10Use Any specializations for bool, instead of SetValueMatteo Casalin
Change-Id: I7a5babe494bdb09a71164ea74d7be3f6bf985ff6 Reviewed-on: https://gerrit.libreoffice.org/13215 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-12-10fdo#80403: Writer specific AutoCorr use FastParserDaniel Sikeler
Contextclasses implement XFastContextHandler Importclasses implement XFastDocumentHandler Tokens for BlockList.xml are defined in BlockListTokens.txt Tokens for content.xml are defined in TextBlockTokens.txt A perfect hash table is generated with gperf and used by the tokenhandlers This is corrected version of c1e90457d2ecc6e1171b7a296ab8bd05821e39e6 (Also pushing again follow-up c940d4d30673dc02ea34b5e60a4a8140648a0dba "loplugin:saloverride" and 5f0f3d4e91e9eb1d1f60b0cd073e7bbd8ea38c29 "Work around -Werror,-Wdeprecated-register") The commits were reverted in 7ef4457b9fc06b5c25c607d7e0149f45c7015b10 Change-Id: I08cd852fa751f98fd0ac6a55dda22f82a869b4d8