summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2019-03-22Unfloat: Move the button to the top of the frameTamás Zolnai
User can find it easier in this position. Change-Id: I38fd782485a180e0d5223b52cc2c6ee061661600 Reviewed-on: https://gerrit.libreoffice.org/69562 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-22Related: tdf#124109 vcl: make glyph item caching work with kashida glyphsMiklos Vajna
This was broken because GenericSalLayout::LayoutText() sets the SalLayoutFlags::KashidaJustification flag as a side-effect of building the glyph list. So in case we cache the list and not build it, the flag will be missing. This means that later in GenericSalLayout::ApplyDXArray() kashida glyphs won't be inserted. With this, the workaround in sw can be removed. Change-Id: Ic18211bf50ca673daa238e8950a381915e4b3096 Reviewed-on: https://gerrit.libreoffice.org/69566 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-22FIX: Use correct table x/y postion in docx exportPatrick Jaap
Until now we exported the original x/y position values of the table from the grabbag. Ignoring users actions like moving the table around. Now, we compute the position from the parent frame and write the actual position in the docx file. Change-Id: I25a09f9c7c8fbe49acbd19e2b1440c7fa90b8aff Reviewed-on: https://gerrit.libreoffice.org/67969 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-22Related: tdf#124109 sw: save one vcl layout call in SwFntObj::DrawText()Miklos Vajna
Commit 436b829f5b904d76039db0818cff5dedf1ae89f1 (sw: save one vcl layout call in SwFntObj::DrawText(), 2018-08-16) did this unconditionally, which broke kashida justification. Re-introduce the same mechanism, but this time opt out in the kashida case to keep that working. This means that for Latin scripts we are back to 2 layout calls (instead of 3) for each keypress in Writer. Change-Id: I890f0ab04d1f5dce561f1536d7c8a6d67a639813 Reviewed-on: https://gerrit.libreoffice.org/69557 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-22weld SwFieldDlgCaolán McNamara
Change-Id: I324a581721e01c907113bb3ab1cc91a290bd71a7 Reviewed-on: https://gerrit.libreoffice.org/69475 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-22refactor into a shareable base classCaolán McNamara
Change-Id: I5eb1f2b6b7b2dbc3bc675845730cb3aef1cab5f0 Reviewed-on: https://gerrit.libreoffice.org/69528 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-22Add few more fixes to build with Boost < 1.56Tomáš Chvátal
Change-Id: Ifbdbf7f2d44d569c491b1822d9d842433a9978a1 Reviewed-on: https://gerrit.libreoffice.org/69462 Tested-by: Jenkins Reviewed-by: Tomáš Chvátal <tchvatal@suse.cz>
2019-03-22tdf#124109: Fix missing kashida glyphsKhaled Hosny
This partially reverts: commit 436b829f5b904d76039db0818cff5dedf1ae89f1 Author: Miklos Vajna <vmiklos@collabora.co.uk> Date: Thu Aug 16 17:35:17 2018 +0200 sw: save one vcl layout call in SwFntObj::DrawText() Pressing a key in Writer used to lay out the relevant string 4 times (counting GenericSalLayout::LayoutText() invocations), save one of them by pre-calculating the layout and sharing it between GetTextArray() and DrawTextArray(). The reverted part was causing inserted Kashida to be missing, leaving gaps inside the words. See attachment in the bug report. Change-Id: Iaafbc793ed5906e6fdf3dcb03c54d5a440e15da4 Reviewed-on: https://gerrit.libreoffice.org/69530 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-22tdf#123943 sw btlr writing mode render: fix text portion backgroundMiklos Vajna
The text frame is swapped in this case, so handle BTLR similar to the normal vert (TBRL) case and the background will be positioned correctly behind the text portion. Change-Id: I2399131ef74ea8849577a467ad9bb02d980d8609 Reviewed-on: https://gerrit.libreoffice.org/69539 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-21fix db field page database refreshCaolán McNamara
Change-Id: I87e18e8624d63de18bd6e0d68eececab75e7166b Reviewed-on: https://gerrit.libreoffice.org/69527 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-21tdf#124109: Revert "Only do kashida insertion with fonts that have non-zero ↵Khaled Hosny
width kashidas" This reverts commit c45b23377bb2fe44c26f1287ff38495344e4ca50. This commit breaks Kashida justification when a document is first opened (the kashida justification will be disabled and spaces will be used untill the text is changed). Probably it is checking for width of Kashida glyph too early. Also I'm not sure what the reverted commit was trying to fix since we already do kashida justification in fonts that has non-zero width Kashida and it has been the case for a long time. This does not fix the original issue in the document attched with the bug report, but if fixes kashida not being applied when opening the document. Change-Id: Ic95859bca94fa792793e3223d2adb465bc6d880f Reviewed-on: https://gerrit.libreoffice.org/69509 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-03-21tdf#79717 save/restore character style on selection overwritePhil Krylov
Change-Id: Ie423e72014734bc188ffb585150dcb024d377d1b Reviewed-on: https://gerrit.libreoffice.org/69323 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-20sw: make ODT export of paragraph auto-styles deterministicMiklos Vajna
If a complex enough document is loaded into Writer and saved as ODT, then the content.xml's automatic paragraph styles (P<num>) are re-ordered on each save, which leads to unnecessary noise. The actual random order is created during import by the time we convert direct formatting (e.g. from HTML import) to autostyles, as StylePoolImpl::maRoot stores autostyles in a map that orders autostyle parents based on their pointer address. This has benefits like automatic ordering of item sets and fast comparison, so don't change that, but extend the svl API to also track the name of those parents. This way by the time StylePool::createIterator() would iterate over those autostyles, it can order the parents by their name, so two import->export runs will result in the same autostyle ordering. (This appears to be the only indeterminism in content.xml for a test HTML input, while meta.xml and settings.xml still changes all the time.) Change-Id: I1cfcae2c664a5c5c3dee48be733046979c1593ed Reviewed-on: https://gerrit.libreoffice.org/69469 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-20VclAbstractDialog_Impl is now unusedCaolán McNamara
Change-Id: Ibd77f77d01137f1e5b41100fd629e8a6f439c1c4 Reviewed-on: https://gerrit.libreoffice.org/69465 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-20SwAbstractSfxDialog_Impl is now unusedCaolán McNamara
Change-Id: I7d17f8dbee1815cb128023283f6265f334cac0f9 Reviewed-on: https://gerrit.libreoffice.org/69464 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-20weld SwFieldEditDlgCaolán McNamara
Change-Id: I786944a4bf8979526f0ccae5b00fb42ad5016a66 Reviewed-on: https://gerrit.libreoffice.org/69463 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-20fix transparency handling in BitmapEx::GetPixelColor()Luboš Luňák
Apparently the Color class uses transparency as the opposite of the normally used meaning of opacity, so transparency 255 means transparent. Change-Id: I3a76c2c93d98ad3c850017d3fd569b04dc6c19c8 Reviewed-on: https://gerrit.libreoffice.org/69211 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-20tdf#42949 Fix IWYU warnings in include/drawinglayer/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I8daf57df5b8f9c609d4f3ca44bae7366addceb6c Reviewed-on: https://gerrit.libreoffice.org/69151 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-20rhbz#1690645 null deref of pEntry when GetCurEntry return nullCaolán McNamara
in GetFocusRect at SvTreeList::GetDepth code in since.... commit 76c549eb01dcb7b5bf28a271ce00e386f3d388ba Author: Steve Yin <steve_y@apache.org> Date: Fri Nov 29 13:03:27 2013 +0000 Integrate branch of IAccessible2 Change-Id: Ida6cb934c94037c861c7d5da005226f32599b5fc Reviewed-on: https://gerrit.libreoffice.org/69459 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-20rename SwConditionEdit back to ConditionEditCaolán McNamara
Change-Id: I6ba7cc5193d6d0badf1f520a907864ab3e16f3f3 Reviewed-on: https://gerrit.libreoffice.org/69445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-20ConditionEdit is now unusedCaolán McNamara
Change-Id: Ibede37194a6ae67032db68d64f51d58c8c48446b Reviewed-on: https://gerrit.libreoffice.org/69444 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-20fix some SwFieldVarPage problemsCaolán McNamara
Change-Id: Ib26efb7bf872b14ff4947ee3880fc316550ed226 Reviewed-on: https://gerrit.libreoffice.org/69449 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-20sw: document what quo vadis and ergo sum portions portions actually doMiklos Vajna
Thanks Michael Stahl for the hint that they are related to multi-page footnotes. Change-Id: If7d839ff01e96070bfcb51952d5e7aea0fd05d14 Reviewed-on: https://gerrit.libreoffice.org/69442 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-19tdf#124162: Crash when trying to accept changesHenry Castro
Change-Id: If4a4034a891d6539b183f6083c0711b05ef7692d Reviewed-on: https://gerrit.libreoffice.org/69441 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2019-03-19more newly unused functionsCaolán McNamara
Change-Id: Id89fb1104bdcfd1c14842b5c6641466c83f2f995 Reviewed-on: https://gerrit.libreoffice.org/69434 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-19drop now unused SwFieldPage ctorCaolán McNamara
Change-Id: Iffba830b1eb3406661f110e8124b317d7f417858 Reviewed-on: https://gerrit.libreoffice.org/69429 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-19weld SwFieldVarPageCaolán McNamara
Change-Id: Ifd71cbb4c3ed3baa33136c5b86c042144faa5002 Reviewed-on: https://gerrit.libreoffice.org/69435 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-19try2 tdf#116404 filter\ww8: use bidi for default style in RTL localeJustin Luth
This reverts commit 06742182e5306d6d06e3253981723a69a3c978ab and implements the same thing without altering the original document. Thanks Miklos for pointing out that shortcoming. Change-Id: I0eca9a730853f97251bc2a1cb1ee4128acf31c1f Reviewed-on: https://gerrit.libreoffice.org/68358 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-03-19weld SwFieldDokInfPageCaolán McNamara
Change-Id: I468f6927f089db19c3b461d965b1dc6222f65716 Reviewed-on: https://gerrit.libreoffice.org/69428 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-19weld SwFieldDokPageCaolán McNamara
Change-Id: Ie6c450b9f9f704d75bf9e9f6b3c6ab890fc04f8d Reviewed-on: https://gerrit.libreoffice.org/69418 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-19tdf#118621 - Optional header/footer menuheiko tietze
Missing bits added to allow leaving the edit mode per escape Change-Id: Ife6fd1b6106fafe5f16b36aea4c88127c16ccf23 Reviewed-on: https://gerrit.libreoffice.org/69408 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-03-19Make condition logic slightly clearerMike Kaganski
Change-Id: I8c35ddf047751cf06707efbbe11730414767a0af Reviewed-on: https://gerrit.libreoffice.org/69416 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-19tdf#86731: Add the dictionary not available messageVaibhav
The patch enables a message or notification box which notifies the user with the message *No dictionary available* in case there is no dictionary available for any content. Change-Id: I61fa01ea469acb345637ab86da98a8de8f8a9762 Reviewed-on: https://gerrit.libreoffice.org/69366 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-03-19rename DBTreeList back to SwDBTreeListCaolán McNamara
Change-Id: Ia5880f81aac7df1766ce306d175f80f64920b4d7 Reviewed-on: https://gerrit.libreoffice.org/69409 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-19weld SwFieldDBPageCaolán McNamara
Change-Id: Ic4919fa3caa2106598ed8da3cec5deffa506eee1 Reviewed-on: https://gerrit.libreoffice.org/69401 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-19tdf#42949 Fix IWYU warnings in sw/source/core/inc/[a-f]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I6c3ae806cbb4a00381e39414ff8c8fede5bf1733 Reviewed-on: https://gerrit.libreoffice.org/69150 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-19tdf#120548 sw ApplyParagraphMarkFormatToNumbering: fix handling of font colorMiklos Vajna
Regression from commit b2c1474c1dc93b69f0ede03fc5c9ab496c669955 (SwTxtNode::IsIgnoredCharFmtForNumbering: ignore RES_CHRATR_COLOR, 2014-11-20), where the problem was that unconditionally ignoring or not ignoring the font color is not correct. Re-examining the test document from the above commit, it has an explicit font color set in the numbering, while this bugdoc doesn't have it. So make applying the paragraph mark font color to the numbering conditional if the numbering already has a color set, this makes both cases work correctly. Change-Id: I43a6dec7d3a77689e2acbdc9d3671e79a9c4cac8 Reviewed-on: https://gerrit.libreoffice.org/69400 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-19name apitest suites consistently while we still canBjoern Michaelsen
- writer test apitest suites are now called like the UNO implementation they are testing - also mark them final for good measure - move tests to module test and try to match its conventions * BaseIndex * TextDocumentIndex * TextDocumentSettings * TextPrinterSettings * TextSettings * XDocumentIndex - also remove anonymous namespace in header, as that is a bad idea - also remove now obsolete ApiBaseTest - also remove dead code in TextPrinterSettings - remove writer xtextcontent test as it duplicates the impl in module test Change-Id: I71aa5f3755d5c90726f4ff4394117fa2391495d7 Reviewed-on: https://gerrit.libreoffice.org/69374 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-03-18weld SwFieldRefPageCaolán McNamara
Change-Id: I5ae3965aa681ea1f5a005fbc8dad4d0ce36af1b3 Reviewed-on: https://gerrit.libreoffice.org/69373 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-18sw: prefix members of SwFormatChain, SwFormatHeader, SwFormatFooter and ...Miklos Vajna
... SwFormatFootnoteEndAtTextEnd Change-Id: I2b092c8a6d713e2741e99f334b2e9d2247cde6c2 Reviewed-on: https://gerrit.libreoffice.org/69380 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-18tdf#97361 make xscriptprovider.py more pythonicHamish McIntyre-Bhatty
Use pylint to identify style and convention errors in xscriptprovider.py. Also make use of setUp and tearDown methods to streamline the class and reduce code duplication. Change-Id: Iee4addb6577c304c5ced4e2d246c4bb557d2b6f4 Reviewed-on: https://gerrit.libreoffice.org/66197 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-17tdf#103301 Set focus to the filter textboxRoman Kuznetsov
Change-Id: I8e44148e718ed38760098b7c72606f977d7ecf47 Reviewed-on: https://gerrit.libreoffice.org/69370 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-17remove this nonsense of init() returning a map, and then ...Bjoern Michaelsen
- make the DocumentIndex and the DocumentSettings test against XServiceInfo and XComponent, if applicable - fix SwXDocumentSettings implementation name to meet expectations, almost [API CHANGE] - leave out tests on Desktop->terminate() for now though Change-Id: I1e1ab69dd6f6aa67f2cb9291a5665f3f94ff4a38 Reviewed-on: https://gerrit.libreoffice.org/69339 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-03-16Component testBjoern Michaelsen
Change-Id: I03785b3126671629011d5e62925a5658ab5ec2f7 Reviewed-on: https://gerrit.libreoffice.org/69067 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-03-16weld SwFieldFuncPageCaolán McNamara
Change-Id: I5b098eecb7318ab64dcafff3ce1ef0fa34536f50 Reviewed-on: https://gerrit.libreoffice.org/69346 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-16weld SwEditRegionDlgCaolán McNamara
Change-Id: I6aacd013a344caa731841ff4f015017ba16c4aca Reviewed-on: https://gerrit.libreoffice.org/69325 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-16UNO SwXTableTextCursor: uso SvtListener instead of SwClientBjoern Michaelsen
Change-Id: Ie026909a1822c0e928f022e61b14e785224f5d17 Reviewed-on: https://gerrit.libreoffice.org/68472 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-03-16make SwXRedline finalBjoern Michaelsen
Change-Id: Iad53e3dea745cf2d473b8218775816dfb042fcec Reviewed-on: https://gerrit.libreoffice.org/68471 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-03-16tdf#98620 filter\ww8 export: spam Jc if environment defines BiDiJustin Luth
If the BiDi value value comes from the page style, then MS formats have no idea what to do with it, so those values are written out into the paragraph itself. Since Justify is highly dependent on BiDi in order to understand its meaning, it also needs to be spammed. Change-Id: I7407056573bb115e8bab2dce0070b0a718dcc1eb Reviewed-on: https://gerrit.libreoffice.org/66923 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-03-16pahole changes in variousNoel Grandin
I'm not seeing as much as I would expect here, mostly because pahole seems to be having trouble parsing quite a few of our structures, and consequently producing useless data than I then ignore. XDash 24bytes -> 20bytes vcl::font::FeatureDefinition 64bytes -> 56bytes SvXMLTokenMapEntry 16bytes -> 12bytes SvXMLItemMapEntry 16bytes -> 12bytes SwContentAtPos 40bytes -> 32bytes Change-Id: I74c8b93f74b8352f48ef552d7d4239aa7f4237d4 Reviewed-on: https://gerrit.libreoffice.org/69304 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-24 06:16:45 +0000