summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2019-05-10tdf#62699 Drop pass-through header file include/svx/svdattr.hxxGabor Kelemen
Change-Id: I04289589196ac69b31f75989d9252c79d03c890f Reviewed-on: https://gerrit.libreoffice.org/71633 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-10sw btlr writing mode: implement layout for fly framesMiklos Vajna
The case when a fly frame was first constructed with one direction then switched to btlr was already working. The case when the direction is already set before the SwFlyFrame is constructed was not, as SvxFrameDirection::Vertical_LR_BT was unhandled. Change-Id: I97d15b3fc15ee116181718144dc9bccf8f31529f Reviewed-on: https://gerrit.libreoffice.org/72077 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-10NB writer: update the different UI files for better syncandreas kainz
Change-Id: Ie4a5401e9f20e4fd5fe8a30ba21faffc2aa69010 Reviewed-on: https://gerrit.libreoffice.org/72085 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-05-09tdf#124343 Make string translatableOlivier Hallot
Turn standard button translatable. Change-Id: I042846b0377adade66eb9bb8b4a3b3bef829a9f4 Reviewed-on: https://gerrit.libreoffice.org/72061 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-05-09uitest for bug tdf#107847Zdeněk Crhonek
Change-Id: Ia3ad578f72fa82f0693c7eef34a43261e4efb878 Reviewed-on: https://gerrit.libreoffice.org/72060 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-05-09regenerate PCH headers for the 4 new levelsLuboš Luňák
Plus some build fixes triggered by this. Change-Id: I59b21def706598ceffd45ae5b1f0262ec9c1ad50 Reviewed-on: https://gerrit.libreoffice.org/71581 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-09tdf#124675 sw: fix crash when moving SwTextFrame in table to prev pageMichael Stahl
The problem is that the SwTabFrame and SwRowFrame that are being iterated are deleted: 7 SwFrame::DestroyFrame(SwFrame*) (pFrame=0x79052c0) at sw/source/core/layout/ssfrm.cxx:386 8 SwTabFrame::RemoveFollowFlowLine() (this=0x5bf07d0) at sw/source/core/layout/tabfrm.cxx:907 9 SwTabFrame::MakeAll(OutputDevice*) (this=0x5bf07d0) at sw/source/core/layout/tabfrm.cxx:1839 10 SwFrame::PrepareMake(OutputDevice*) (this=0x5bf07d0) at sw/source/core/layout/calcmove.cxx:344 11 SwFrame::Calc(OutputDevice*) const (this=0x5bf07d0) at sw/source/core/layout/trvlfrm.cxx:1790 12 SwFrame::PrepareMake(OutputDevice*) (this=0x603a570) at sw/source/core/layout/calcmove.cxx:247 13 SwFrame::Calc(OutputDevice*) const (this=0x603a570) at sw/source/core/layout/trvlfrm.cxx:1790 14 SwFrame::PrepareMake(OutputDevice*) (this=0x5daf120) at sw/source/core/layout/calcmove.cxx:247 15 SwFrame::Calc(OutputDevice*) const (this=0x5daf120) at sw/source/core/layout/trvlfrm.cxx:1790 16 SwFrame::PrepareMake(OutputDevice*) (this=0x6005ca0) at sw/source/core/layout/calcmove.cxx:247 17 SwFrame::Calc(OutputDevice*) const (this=0x6005ca0) at sw/source/core/layout/trvlfrm.cxx:1790 18 SwFrame::MakePos() (this=0x6094330) at sw/source/core/layout/calcmove.cxx:490 19 SwTextFrame::MakePos() (this=0x6094330) at sw/source/core/text/frmform.cxx:343 20 SwContentFrame::MakeAll(OutputDevice*) (this=0x6094330) at sw/source/core/layout/calcmove.cxx:1346 21 SwFrame::OptPrepareMake() (this=0x6094330) at sw/source/core/layout/calcmove.cxx:368 22 SwFrame::OptCalc() const (this=0x6094330) at sw/source/core/inc/frame.hxx:1060 23 SwLayAction::FormatLayout(OutputDevice*, SwLayoutFrame*, bool) (this=0x7ffc6da48350, pLay=0x8a349c0, bAddRect=false) at sw/source/core/layout/layact.cxx:1362 24 SwLayAction::FormatLayout(OutputDevice*, SwLayoutFrame*, bool) (this=0x7ffc6da48350, pLay=0x79052c0, bAddRect=false) at sw/source/core/layout/layact.cxx:1357 25 SwLayAction::FormatLayoutTab(SwTabFrame*, bool) (this=0x7ffc6da48350, pTab=0x7a9c300, bAddRect=false) at sw/source/core/layout/layact.cxx:1569 26 SwLayAction::FormatLayout(OutputDevice*, SwLayoutFrame*, bool) (this=0x7ffc6da48350, pLay=0x7c30300, bAddRect=true) at sw/source/core/layout/layact.cxx:1354 27 SwLayAction::FormatLayout(OutputDevice*, SwLayoutFrame*, bool) (this=0x7ffc6da48350, pLay=0x79e1780, bAddRect=true) at sw/source/core/layout/layact.cxx:1357 28 SwLayAction::InternalAction(OutputDevice*) (this=0x7ffc6da48350) at sw/source/core/layout/layact.cxx:546 They are deleted because the last SwTextFrame was moved via MoveBwd() to the previous page, and is formatted there. (regression from commit 18765b9fa739337d2d891513f6e2fb7c3ce23b50) Prevent this via: * delete-guard for the SwRowFrame - causing RemoveFollowFlowLine() to return early (also, let it return false, so the Join() isn't even called, although that doesn't make a difference in practice because of the next item:) * join-guard for the SwTabFrame - otherwise tabfrm.cxx:2199 will Join() it anyway This means that when the page with the follow-frame is done formatting, the empty SwTabFrame with no SwTextFrame in it will remain. Fortunately this is not a problem, because due to the moving, the previous page will be invalid and layact.cxx:613 will iterate to the previous page and format it again; then tabfrm:2199 of the master SwTabFrame will detect that the follow SwTabFrame is empty and Join() it. Change-Id: I2cca89d63b81e7d4909319fa4feab2f5d67a6ff3 Reviewed-on: https://gerrit.libreoffice.org/71996 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-09tdf#125151 sw: allow protection around field marksJustin Luth
Similar to bug 105625, the cursor should be considered outside of a fieldmark when it is at the start. A delete at the start would normally delete the entire form field, but in this case the section is supposed to be protected, so deleting should be forbidden. This atStart situation is already looked for when the document is not protected. However, when the section is already protected, then a different code path is followed, and there the start position was ignored and thus became an editable part of the page, allowing the user to easily delete the field by mistake. LO6.2's commit 63ec2e8d07dff652a68c9dc96859c4c61f26b9df accurately identfied that this is in a protected section, and so exposed this missing scenario. Related idea: Also added a unit test to ensure that Protect_Form keeps protecting the formfields as well. A test document in the bug report, containing a combobox and checkbox, confirms that this fix is good for all three types of fieldmarks. Change-Id: Ida08163f3376e55c620d6670da160832e79cd252 Reviewed-on: https://gerrit.libreoffice.org/71927 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-05-09avoid copying when placing items into SfxItemSetNoel Grandin
Change-Id: I05c627f590e7794c1ba11b66021dc30aa3285eb0 Reviewed-on: https://gerrit.libreoffice.org/71941 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-08Fix commentSamuel Mehrbrodt
Change-Id: Ic2093aaea6e71559ba49e248f9afd5d86bcb0b67 Reviewed-on: https://gerrit.libreoffice.org/71949 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-08improve tools::Rectangle->basegfx::B2?Rectangle conversionNoel Grandin
Improve the conversion method to do something reasonable with empty Rectangle. Use the conversion method in more places. Change-Id: I48c13f3d6dae71f39f03f7939101e545c8125503 Reviewed-on: https://gerrit.libreoffice.org/71853 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-05-08Convert OSL_ENSURE to SAL_WARNSamuel Mehrbrodt
Change-Id: I6213bd2b10746416a5e0bc9029c49b0b09a8b0a4 Reviewed-on: https://gerrit.libreoffice.org/71947 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-08tdf#116501 fix freezing at embedded text tablesLászló Németh
by disabling their in-row splitting using loop control. Change-Id: Ibd93213fa0ce45458ce188de20da982e4abc17c5 Reviewed-on: https://gerrit.libreoffice.org/71920 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-05-07Fix typoAndrea Gelmini
Change-Id: I8d705a0d31f36242f8a93591a2c0fc69ee6847a0 Reviewed-on: https://gerrit.libreoffice.org/71911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-07tdf#124594 DOCX filter: don't extend margins from effects for rotated shapesMiklos Vajna
Regression from commit a5a836d8c43dc9cebbbf8af39bf0142de603a7c6 (DOCX filter: effect extent should be part of the margin, 2014-12-04), the problem was that extending margins as-is based on the effect extent values only work correctly in case of non-rotated shapes. For example, with 90 degree clockwise rotation the top effect extent should extend the right margin, etc. Fix the bug by limiting this extension to the non-rotated scenario. Test the behavior at a layout level, so in case later the effect extent feature is implemented, it won't be necessary to adjust the test. Change-Id: I97271bbb7c079951980b436cb8d8e5e54eeead55 Reviewed-on: https://gerrit.libreoffice.org/71878 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-07Replace list by deque for maFkpCache (ww8scan)Julien Nabet
Change-Id: I5d2699bd3cbbc18844585f8c2619295f974eb7ce Reviewed-on: https://gerrit.libreoffice.org/71887 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-06tdf#122892 tdf#124366 sw: fix loop in SwTextFrame::CalcFollow()Michael Stahl
... differently; commit b7d4418c309c8bc4fd25485dd3a0ea6ad9edf34e was partially wrong because if SetPrepWidows() isn't called and the master and follow have fewer lines than the sum of orphans and widows, then the frames must be merged, i.e., master must move forward to the next page and follow must be deleted, but that only happens with SetPrepWidows(). However if the SwTextFrame::PrepWidows() determines that no lines can be moved from the master, SwTextFrame::CalcPreps() will grow the master to force it to move to the next page, and then it sets SetWidow() too, so check this flag to break the loop in SwTextFrame::CalcFollow(). Another question is what is the point of the "very cheesy" follow formatting fall-back, which might be removable. Change-Id: I0769a5a4f13ca4c95c2229a496207809d05576f9 Reviewed-on: https://gerrit.libreoffice.org/71866 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-06Translate German variable namesJohnny_M
Translated the defines, but kept the their NC_(...) translation references to prevent a need to update translations. Standardized terms from http://www.upu.int/en/activities/addressing/s42-standard.html were used, although textual strings use US English terms. Change-Id: Ic5b13d21f9552d3e8b2adce92cca36f651eaa7eb Reviewed-on: https://gerrit.libreoffice.org/71792 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-06sw: prefix members of CSS1ParserMiklos Vajna
Change-Id: Iaf7ed92d3ef132a79de30f0d596acdfba9c7185a Reviewed-on: https://gerrit.libreoffice.org/71848 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-05-06tdf#113483: DOCX: fix encoding of bookmarks with non-ASCII lettersAdam Kovacs
Non-ASCII letters were stored using percent-encoding, resulting broken bookmark names after export/import. For example, the word "Első" became the wrong "Els%C5%91". Now only the reversed ASCII characters are stored in percent-encoding. For example, the name "Első!" stored in the following form: <w:bookmarkStart w:name="Első%21" w:id="0"/> <w:instrText> REF Első%21 \h </w:instrText> Change-Id: I65168e071b6baa12385c0aaa12d9f2ae4ccf9f98 Reviewed-on: https://gerrit.libreoffice.org/71299 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-05-06Writer Notebookbar Layout syncronisationandreas kainz
Change-Id: Ibe8fb5114e624482292928d14ad8cc89b711f5a8 Reviewed-on: https://gerrit.libreoffice.org/71814 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-05-05[API CHANGE] SwXTextField: no more SwModify/SwClientBjoern Michaelsen
- fix unittest assuming the double-insertion of annotation throwing an IllegalArgumentException was intentional - remove SwModify/SwClient in SwXTextField - also: add basic C++ api test Change-Id: Ia4657dc65dfadc3e975bdf409bd5e43413ea1f5a Reviewed-on: https://gerrit.libreoffice.org/71452 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-05-05sw: make ooxml export tests fail when re-reading doc failsThorsten Behrens
Bit odd to bail a unit test when reading back the document doesn't succeed for whatever reasons. Since there are tests that also check the initial loading of a docx (even for ooxml export tests), leave those untouched. Change-Id: Iede4b360eecf3ff2c864a5d565d21120fd0e1020 Reviewed-on: https://gerrit.libreoffice.org/71503 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-05-05Fix typoAndrea Gelmini
Change-Id: I87fa75d2aab64031426ce0560344908bd81d413c Reviewed-on: https://gerrit.libreoffice.org/71816 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-04Use hasElements to check Sequence emptiness in swArkadiy Illarionov
Similar to clang-tidy readability-container-size-empty Change-Id: If44f20a7aa678915e32d12101e1af71476f4b590 Reviewed-on: https://gerrit.libreoffice.org/71679 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-03Resolves: tdf#124552 - Sentence selection UNO actionheiko tietze
UNO command SelectSentence / FN_SELECT_SENTENCE added executing SelSentence() Change-Id: Idcd528cf2915b30a59a9916dcff14d60d01dcd74 Reviewed-on: https://gerrit.libreoffice.org/70411 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2019-05-03The -fvisibility-ms-compat hack is no longer needed for UBSan on Linux...Stephan Bergmann
...with latest Clang trunk towards Clang 9. All the no-longer necessary hacks are made conditional on new NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY, which is still set for UBSan builds with older Clang on Linux (but which should eventually be purged). Various classes needed additional SAL_DLLPUBLIC_RTTI annotations, as building with UBSan instrumentation can generate references to RTTI symbols from additional places like outside a dynamic library that used to hide those symbols by default (but used to not hide them for old UBSan builds thanks to the -fvisibility-ms-compat hack). The odr-violation suppressions in solenv/sanitizers/asan-suppressions (which is not referenced from anywhere in the code base, but meant to be included in an ASan/UBSan build's ASAN_OPTIONS env var) are also no longer needed when NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY is false. Change-Id: I24ec3e388b0cbab50dbe2bf008d9569bff7bf25a Reviewed-on: https://gerrit.libreoffice.org/70829 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-03sw: reduce accuracy of double compares in testFDO74215Michael Stahl
This failed several times recently on Mac in Jenkins. - Expected: 14.7945205479452 - Actual : 14.8 - Delta : 0.001 Change-Id: I966b8085bf4120afb0a09e50f85ada4e5d8d488c Reviewed-on: https://gerrit.libreoffice.org/71725 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-03tdf#123285 sw_redlinehide: fix SwAutoFormat::DelMoreLinesBlanks()Michael Stahl
The "Delete spaces and tabs at end and start of line" AutoFormat option was deleting the wrong characters: on the 2nd line, it deletes the spaces as it should, but on subsequent lines the selection is off by the number of characters that have already been removed. The range indexes are now integers, so not automatically corrected on deletions like the SwIndex they were before; in this case, where only plain characters are deleted, it should suffice to iterate the ranges in reverse order to avoid the problem. (regression from 180e5f515c9cd21fb8057c797a480eca7d9ed260) Change-Id: Ie8e08c00803d94e700cd5b64f29edb0b841eda2b Reviewed-on: https://gerrit.libreoffice.org/71686 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-03tdf#125039 sw_redlinehide: keep shape selected when changing anchor typeMichael Stahl
Avoid the problem by not moving the drawing object to the invisible layer, which isn't necessary because it will be inserted immediately anyway. (regression from 214e6ed5286566e689a4ef13a9115e2ad38fff57) Change-Id: I9936de990d1db56fa4c00c37d05b4ed2923790ff Reviewed-on: https://gerrit.libreoffice.org/71685 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-03NB Tabbed compact writer update print tabandreas kainz
Change-Id: I0ff8c4cb5e0ebc408e827e852d6e6134c42a3382 Reviewed-on: https://gerrit.libreoffice.org/71707 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-05-02writer: sync global and print toolbars between dif UI layoutsandreas kainz
Change-Id: I226db3f1a9cd6bed12db8edcb37ae6a6dcc999bc Reviewed-on: https://gerrit.libreoffice.org/71656 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-05-01weld ScPivotLayoutDialogCaolán McNamara
Change-Id: I821ee682bf5b65774a609227811365b94ae2063e Reviewed-on: https://gerrit.libreoffice.org/71547 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-01Make getXPathPosition assert on requested child foundMike Kaganski
Previously, for an XML like this: <sharedItems> <d v="2017-07-10T09:11:02"/> <d v="2017-07-10T09:11:03"/> <m/> </sharedItems> the call like int pos = getXPathPosition(pDoc, "/x:sharedItems", "absent"); gave 3. That could result in mistakes, when a test would assert on position "3" for a child element which name is mistyped. I made such a mistake when creating a unit test trying to assert on a position of the last element, and writing its name as "x:m", like in rXPath itself; the return was 3, and I initially wrongly assumed that the return is 1-based (like in xpath bracketed expressions). rChildName made const OString&, for consistency with rXPath, or with rAttribute in getXPath: child name is just a part of a longer xpath. Change-Id: I7ba9c4466c75b1b10fce1ccf26ef3b56b4e11e87 Reviewed-on: https://gerrit.libreoffice.org/71614 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-05-01add Footer and Header settings to tabbed notebookbarandreas kainz
Change-Id: I90e103f1ded9671817b83ae4755c235acf4050f1 Reviewed-on: https://gerrit.libreoffice.org/71619 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-05-01Removed executable flag on .docAndrea Gelmini
Change-Id: If5e6366e307349fa17ba450d330c1f57f9e05d30 Reviewed-on: https://gerrit.libreoffice.org/71611 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-01loplugin:stringconstant in sw/qa/extras/layoutJulien Nabet
Change-Id: I4934240946b435e7b5b13c2623143f7741106efa Reviewed-on: https://gerrit.libreoffice.org/71599 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-01NB contextual single update for vertical alignmentandreas kainz
Change-Id: Id0b9a5816ee459837ca8fe2b4dd7a0233a517c0d Reviewed-on: https://gerrit.libreoffice.org/71604 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2019-04-30sw: remove testForcepoint79 from SwLayoutWriterMichael Stahl
Was recently added in 453e6fb7c1827d317dc775df32a6cf91b2bb5a67 Here this goes into an infinite loop, at least it doesn't finish in an hour; Miklos claims it's due to missing fonts, let's just remove the test for now, the file will still be tested by crashtesting. Change-Id: I8acd05e9428ca25d1255b9f14ca56c7a9f5d4f00
2019-04-30tdf#122607 sw: restore CalcLayout() call in getRendererCount()Michael Stahl
Effectively revert commit 1ecca673b40fedc53db125e332b087d1c120a254. There are some documents that aren't formatted correctly. Change-Id: I4b0cf6313c249a0ed916c2630cd5194d809bfb48
2019-04-30tdf#122607 sw: fix preservation of text frame cache entriesMichael Stahl
SwSaveSetLRUOfst would leave only 50 cache entries available for the CalcLayout() to use; apparently it's not enough for this document. The difference between the 1st loading/layout and the 3rd loading/layout of the document is that in many paragraphs the cache entry is missing, because the entires of the previous loads were clogging up the cache and were preserved here, and the cache only has 50 available entries; if enough entries are available, everything is positioned properly. The idea with the 100 entries per visible shell actually comes from the CVS initial import, where there was a comment suggesting that; but the corresponding parameter was actually unused and removed in 7c704c78d3c652504c064b4ac7af55a2c1ee49bb. Ideally we'd have time to investigate why a missing cache entry causes the wrong position... Change-Id: I64a72a94361dbf5717bbc709fa3bc9abbe18a37c Reviewed-on: https://gerrit.libreoffice.org/71542 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-04-30tdf#122607 sw: remove deleted SwTextFrame's cache entryMichael Stahl
Apparently nothing else would remove the entry, and without SwTextFrame it's not accessible any more. If the entry was recently used, then the SwSaveSetLRUOfst usage in SwViewShell::CalcLayout() will preserve it instead of giving the cache entry to a new frame. Change-Id: Id43fdbad2ac006853928e30a7b6768c3e3dc1667 Reviewed-on: https://gerrit.libreoffice.org/71541 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-04-30tdf#123636 writerfilter: handle deferred breaks on framesJustin Luth
...similar to handling breaks before shapes in lcl_startShape. Three different examples found to create/split a paragraph. Which one to use? (addDummy, m_bIsSplitPara, and lcl_startCharacterGroup). SplitPara is not good because the paragraph properties probably should not be copied to the dummy paragraph (like numbering for example). Slightly modified the lcl_startChar example to ensure that the dummy paragraph doesn't steal a part of the properties, but is only default properties plus page-break. This doesn't export very well, so roundtripping is very poor. Research Note: There exists a compat flag showBreaksInFrames (Display Page/Column Breaks Present in Frames) "This element specifies whether applications should honor the presence of page and/or column breaks which are present within the contents of paragraphs which have been defined as frames using the framePr element." --Currently, LO does nothing with this flag. Probably too exotic and irrelevant (word 2003 era?). No existing unit tests found that have isSet(pg_brk) frames. Change-Id: I29f815355401c7af8b347a3ed9d0298bc9b27b93 Reviewed-on: https://gerrit.libreoffice.org/71255 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-30tdf#101826 ww8import: Fly - don't convert XATTR back and forthJustin Luth
In this case we are explicitly interested in textboxes, but any fly that accepts XATTR will now use that and skip the old RES_BACKGROUND. In the case of textbox import, the properties were being converted into RES_BACKGROUND and then back to XATTR again. Just copy the XATTR properties to the new FlySet instead. The ability to import XATTRs into a textbox was added to LO6.3 with commit 15819181772d95963d16c1c2eaa9e51af81f7f68 Change-Id: Ib65b3d9097d0a56dbe205b419d052af53d0132c8 Reviewed-on: https://gerrit.libreoffice.org/66331 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-30Resolves: tdf#124920 insert section from clipboard dialog doesn't cancelCaolán McNamara
Change-Id: Ic85cea08a9730cbd87d4ba1344ee6ddaa1b9d7bb Reviewed-on: https://gerrit.libreoffice.org/71567 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-30tdf#62699 Drop pass-through header file include/svx/xlineit.hxxGabor Kelemen
Change-Id: I3ae76558f476934dffc2b43b19af848b5ad5015e Reviewed-on: https://gerrit.libreoffice.org/71454 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-30sw btlr writing mode: implement ODF filter for textframesMiklos Vajna
Layout is still not yet correct right after the import, though. Change-Id: Icdba2e8d608f35b6b5b43b88ffb223f779af1b89 Reviewed-on: https://gerrit.libreoffice.org/71552 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-30Sifr, Breeze, Colibre icon theme update for menubarandreas kainz
Change-Id: I10010dd0c8f0eb51e0ca220e5ce7feee817f25f2 Reviewed-on: https://gerrit.libreoffice.org/71559 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-30improve loplugin:stringconstantNoel Grandin
to find more places we can elide the OUString() constructor at call sites Change-Id: Ie09f3c61f2c4b4959c97dc98ebcbaf7c51d5d713 Reviewed-on: https://gerrit.libreoffice.org/71514 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-30drop Graphic::operator boolNoel Grandin
which tends to interact in very weird ways with other code, for example it makes Graphic appear to have an operator< Change-Id: I335fe8f3644b710bc61291e625cbca7334a37716 Reviewed-on: https://gerrit.libreoffice.org/71532 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2024-07-10 18:26:43 +0000