summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2020-12-19don't mention VclBuilder in the dialog tests docsCaolán McNamara
Change-Id: Id18a25e3d3310342887757fe417769f4213b8a3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107981 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-19tdf#82802 sw conditional style conditions not saved for TextBodyJustin Luth
Someone thought it would be a good idea for the built-in paragraph style Text Body to be special and support conditional formatting. It has been broken for import/export since 2015. It was mostly fixed in duplicate issue tdf#103091, but the side case of Text Body was missed. Partially reverting commit a5b4cb3f836c991d0647f55e1ef4920ce6115eac. xNewStyle didn't need to be a member variable since it is assigned to GetStyle anyway. Change-Id: I102d86c0b1f28e42b2c1350abc247b6b1f8acd4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107352 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-12-19make *String(string_view) constructors explicitNoel Grandin
to make it more obvious when we are constructing heap OUStrings code and potentially inadvertently throwing away performance. And fix a handful of places so revealed. Change-Id: I0cf390f78026f8a670aaab53424cd31510633051 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107923 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-19use more string_view in SfxItemPropertyMapNoel
Change-Id: I053dedcbf0b110a61752722d247d6ee5e9ba481d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107977 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-18tdf#138953: use original (cropped, but unrotated) object size in spPrMike Kaganski
This not only fixes the regression from b226383a83e41bbced9fc2a02dc09a449401ec97, but also makes the written size more correct than before, when it was slightly larger compared to original object size. Corrected unit test for tdf#116371 reflect that: the object in ODT is 241.78 mm x 240.61 mm. It previously was exported as 241.88 x 240.70; now the exported size is closer: 241.79 x 240.63. Change-Id: Ibfe85c7cd98c089e58af8d7f3848990af8e1100f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-12-18sw: document how the first page frame is createdMiklos Vajna
I can't remember if the boolean order is left/right and then first/nonfirst or the other way around. Change-Id: Id39d81f8501da690ce179546e9aa3d4b54f39fcf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107937 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-12-18tdf#138897 sw: avoid creating SwUndoResetAttr in CopyImplImpl()Michael Stahl
The problem is that SwTextNode::CopyCollFormat() both creates the SwTextFormatColl with undo and applies it with undo. The first is desirable, the second causes a problem because it necessarily happens after SplitNode() and currently happens before copying the non-start/end nodes, so the node-index may not match in Undo, regardless if it runs before or after SwUndoCpyDoc. But SwUndoInserts restores the SwTextFormatColl on the node itself, so it can just be suppressed, which looks easier than refactoring this to call SplitNode() with Undo enabled. (regression from b4365b985178e1866c74afd757a104aad1d405a9) Change-Id: I4d15fb88cd5ae4cc53d9afb3397dec8fcf7635fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107921 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-12-18throw exception in SvStream when reading past end of fileNoel
to avoid chasing weird problems where we read past the end of file, which leads to random data in the variable we read into. I expect a couple of possible regressions from this change (1) memory leaks caused by non-exception-safe memory handling. Of which there should not be much because we're pretty good about using smart pointer classes these days. (2) Broken files which used to load, will no longer do so. These will have to be debugged by putting a breakpoint on the SvStreamEOFException constructor, and examining the backtrace to see where we should be catching and ignoring the exception to make the code continue to handle such broken files. Change-Id: I351be031bb083a3484a9a1b650a58892700e6fb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105936 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-17sw ChangesInMargin: fix crash at Undo of deletion of paragraph breakLászló Németh
Deletion of the paragraph break by pressing Delete results an empty hidden redline, too, which caused a problem during Undo (if there were other tracked redlines, too). Change-Id: I64968688688be72d4e501631244b4c57ab634585 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107830 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-17Removed executable bits on fodt fileAndrea Gelmini
Change-Id: I6abb926efe745e27190cd36e249d2b8845c348f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107855 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-12-17tdf#138976 change "Cancel" button to "Close" in Template Manager dialogSeth Chaiklin
Change-Id: I3e8cbdb70f70002f1fe2b873e899f25a72463358 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107704 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-16tdf#138592: also consider following zero-width text portionsMike Kaganski
... after this text portion, to handle possible combining characters inside separate text span, and hence separate portions. The fix is modelled after 63d8041c60c5d7c63dd34f94a694871b7ea9e2ca. Thanks Justin! Change-Id: Idf3b79ce1c384f093bce201ccb5ecefd350e1478 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107826 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-12-16don't scroll the document between mouse down and mouse up in an annotationCaolán McNamara
because that causes the editview to get a mousedown, then the window is scolled under it, then a mouseup so it selects the text between the location it was at mouse down and the new pos at mouse up which is infuriating Change-Id: Ie8d88f851ebe090eb2b1968f1ef6577183586506 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107850 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-16tdf#137819 sw: fix textboxes anchoring "As Char"Attila Bakos (NISZ)
Changing anchoring type of a textbox to "As Char", shape position follows the new text frame position. Also SwTextBoxHelper::mapAnchorType() was introduced to map between text frames and shapes, with a small cleanup. Change-Id: Iea0abe6f12a293fb4270970fde53ea903b347fb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107221 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-16uitest: sw: Add missing assertsXisco Fauli
Change-Id: Idacea3eae1124778cbec98af6424f2462b4ef78f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107842 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-16Fix typosAndrea Gelmini
Change-Id: I1c0e4daa835eba2004ffe9490757dd91d9c9889b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107790 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-12-16tdf#136816: fix hidden legend entries in "Column and Line" chartsTünde Tóth
Regression from commit: 300e65cc47f3d6ae1563350757dbfadc080d7452 (tdf#123268 fix lost chart if all legend entries are hidden) Change-Id: Id59cd8d681dada123feadbe7910be7fbc7ec37f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107757 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-16tdf#138777 pie chart: improve long data label widthTünde Tóth
to avoid chart distortion. Reduce the maximum text width of data point label shape based, because in some cases the long data label flowed out of the chart. Change-Id: I045c81ecc6ce579e1f472d7ea67e04315ce9c60b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107585 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-16tdf#138847 sw ChangesInMargin: show all characters in marginLászló Németh
deleted by pressing backspace or delete, not only the first character from the deleted character sequence. Regression from commit 469f472fb31c4ef1a57f8ec54ba750c1332feec2 (tdf#138479 tdf#137769 sw ChangesInMargin: fix Undo in paragraphs). Change-Id: I0027cc0da02df8bccba2d957d4cc0407f34ba014 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107745 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-16tdf#138892 writerfilter: cancel style list if bNoNumberingJustin Luth
This fixes 6.1 regression e24e2d2fb02239753c1520a0458b44683ea4cc2e. Starting in 7.0 (tdf#131321), paragraph styles kept their numbering property. But even before that, non-paragraphs marked by bNoNumbering we having their direct numbering removed, and then finishParagraph applied para-style numbering since there was no direct numbering. So, we need to pass the bNoNumbering to finishParagraph so that it can cancel out a style-assigned numbering. Change-Id: I0c24af4e9bd0ea3712179a47ed3550f91c8f44b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107738 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-12-15Fix typoAndrea Gelmini
Change-Id: I41e1d5a251e29908d0001824d376966644c36c21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107680 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-12-15update pchesCaolán McNamara
Change-Id: I280dea8fe5f346a5555f4bf479896877579d63e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107748 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-15don't need to include vcl/menu.hxx hereCaolán McNamara
Change-Id: I16c4c2fd84ea8af6b7601e49c38630bbbfdb2cb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107746 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-15use views to parse rather than allocating OUStringNoel
Change-Id: If0a848c64ce8077d1681661873629c83307cf8b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107736 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-15tdf#118711 writerfilter: don't hardcode default page descriptionJustin Luth
well, at least not at the beginning of the document. The problem with specifying is that it becomes a property of the paragraph - and so if the paragraph is copied or moved, the page break comes along with it and the user has to remove the unnecessary page break wherever it lands. Since the default will be applied anyway, there is no value in specifying it. I'm not sure how, but at least one test document started with a Converted1 style, so I had to explicitly confirm that the stylename really did match the default for a first section. A unit test also indicated that it needs to be specified if an explict page number is assigned because RES_PAGEDESC contains MID_PAGEDESC_PAGEDESCNAME as well as MID_PAGEDESC_PAGENUMOFFSET. Change-Id: I0d0f6b70767f7daaf300e09c0d31ac4b17b91ed1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107555 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-15tdf#138600 sw: fix too small print area for btlr text in nested tableMiklos Vajna
Regression from commit 435ab51ec8920033b7865f27f4afee8a852a0b31 (tdf#128399 sw btlr: fix clicking to lower rotated cell, 2019-10-29), the bugdoc has a btlr table cell and the row frame of the outer table has a bottom value which is very small at the point when SwFrame::GetPaintArea() is invoked for the inner btlr cell. This means the "cell should not leave its parent" mechanism kicks in and reduces the bottom of the paint area to a small value, so the text is not visible at all. Fix the problem by teaching SwFrame::GetPaintArea() that btlr cell frames are OK to leave their parent towards the bottom of the page; that parent will grow at a later phase of the layout process anyway. Change-Id: I99334bbf0116df8d8ed27f192c81c0441b6c797d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107730 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-15tdf#122045: sw: Add UItestXisco Fauli
Change-Id: Ic49462e6d5a78d75947518744bde72b3d2cef86e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107688 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-14tdf#122045 using 'Apply' doesn't keep document modified on later 'Cancel'Caolán McNamara
Change-Id: I7c6232747785a0c5827fe7344e1dc20758419956 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107683 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-14use more direct parsing on FastAttributeListNoel
instead of first allocating an OUString Change-Id: I796b1b2d47eb3cb9bebb00ae1bbd465010ebf494 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107691 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-14tdf#82802 sw page-style UI: remove pointless makeConditional CBJustin Luth
There is no point in having a tick-box to enable the bottom panel. If anyone assigns anything, then the style automatically becomes a conditional style, and reverts back when all are removed, regardless of the status of that checkbox. So it was just a UI element - probably a remnant of a long-ago design that was phased out. Change-Id: I318f7d8061a938c24c97d5b718f3d328e66f8ff1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107162 Tested-by: Jenkins Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-12-14sw: prefix members of SwXMLBlockListContext, SwXMLTextBlockBodyContext, ...Miklos Vajna
... SwXMLTextBlockDocumentContext and SwXMLTextBlockExport See tdf#94879 for motivation. Change-Id: I18eeb2ef5905a1117d5915d403278cfa66dfcc20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107671 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-12-14SwContentFrame: Modify no moreBjoern Michaelsen
Change-Id: I934e5f096b7e650fe95d62b0030cbbe3a90daf6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107667 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-12-13sectfrm: Modify no moreBjoern Michaelsen
Change-Id: Ie4aaa1a6ced60db3d812107d567af571c6a4d2e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107664 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-12-13tabfrm:Modify no moreBjoern Michaelsen
Change-Id: Ie54bea8a8c60b0a74f745630f9cddfc4bd4b0ac7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107656 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-12-13pagechg: Modify no moreBjoern Michaelsen
Change-Id: I571813d6e4fd3c465f77eb7acca9d656440a136a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107648 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-12-12tdf#138605 sw change tracking: fix crash with UndoLászló Németh
Regression from commit 469f472fb31c4ef1a57f8ec54ba750c1332feec2 (tdf#138479 tdf#137769 sw ChangesInMargin: fix Undo in paragraphs) Change-Id: I7826b7920e51733da98c00bfdcb8636d42655afc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107637 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-11Adapt the remaining OUString functions to std string_viewStephan Bergmann
...for LIBO_INTERNAL_ONLY. These had been missed by 1b43cceaea2084a0489db68cd0113508f34b6643 "Make many OUString functions take std::u16string_view parameters" because they did not match the multi-overload pattern that was addressed there, but they nevertheless benefit from being changed just as well (witness e.g. the various resulting changes from copy() to subView()). This showed a conversion from OStringChar to std::string_view to be missing (while the corresponding conversion form OUStringChar to std::u16string_view was already present). The improvement to loplugin:stringadd became necessary to fix > [CPT] compilerplugins/clang/test/stringadd.cxx > error: 'error' diagnostics expected but not seen: > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 43 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:42): simplify by merging with the preceding assignment [loplugin:stringadd] > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 61 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:60): simplify by merging with the preceding assignment [loplugin:stringadd] > 2 errors generated. Change-Id: Ie40de0616a66e60e289c1af0ca60aed6f9ecc279 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107602 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-11sw: add missing nullptr checkXisco Fauli
introduced by 0aa0fda64057647219954480ac1bab86b0f0e433 See: https://crashreport.libreoffice.org/stats/signature/SwCursor::UpDown(bool,unsigned%20short,Point%20const%20*,long,SwRootFrame%20&) Change-Id: Ifb7a86b0dfd1477d6ffa15c7d4d3289984747f87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107561 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-11cid#1470587 Dereference after null checkCaolán McNamara
since... commit 4d6f00a097e68715c63c3388b1183bf08fa8cdbb Date: Thu Dec 10 00:09:32 2020 +0100 flyincnt: Modify no more Change-Id: Ief0ed9248c89b74e325746401c321a34990477ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107582 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-11cid#1470585 Dereference null return valueCaolán McNamara
Change-Id: If2a3eae843753a06d2f3fa9ac31acc9470cb6982 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107584 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-11cid#1470586 Dereference after null checkCaolán McNamara
since... commit d79a578c200ff30134cf5ec7ad5c66f3e5d2d4c9 Date: Tue Dec 8 23:50:27 2020 +0100 flylay: Modify no more Change-Id: Ief190dfb135d1bcc25004278cc68bf014554d533 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107583 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-11tdf#136929 docx export: keep frame with paragraphJustin Luth
EndParagraph was checking if any frames were to be attached. Well, startParagraph can occur multiple times before endParagraph, so the frames can be attached to the wrong paragraph. In this case, it was moving the text-body frame into the footer. So make a stack of these things, so that each paragraph can keep track of it's own setting. RTF can have endParagraph without startParagraph. Although that doesn't seem to apply in this DOCX-only context, just to be safe I'm assuming that it could in theory happen as well with a DOCX, and so never assume that the stack exists. Based on a code read, (and then a confirming unit test,) things seem to be complicated by multi-levels of textboxes that need to be squished. The for loop with a changing upper end really threw me for a loop, so I'm clearly documenting that. Change-Id: I1060736c0a2174af125d853ff7d72265e000c8de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107516 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-10tdf#131990: sw_uiwriter: Add unittestXisco Fauli
Change-Id: I99ed5b61479076f44bfabdf1cf3b95732fff79f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107581 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-10tdf#81226: sw_uiwriter: Add unittestXisco Fauli
Change-Id: If5f6ae5822b7af9618b447dc60180ffe3f9f04b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107569 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-10Add comments wondering what some magic numbers might meanTor Lillqvist
Change-Id: Iece65c9d96561abc0a97726cd4eb642317dc0f9c
2020-12-10Don't leave an empty area at the bottom if we can move the text downCaolán McNamara
in writer's margin comment, which is what ScTextWnd does Change-Id: I2d71d32619e0f6f5c11f57584b1889c7c4fbe121 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107559 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-10One more OUString::fromUtf(u8"...") simplificationStephan Bergmann
Change-Id: I0a658edab6c2f4a5b4ff58fb7a4b57bde3809962 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107556 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-10Drop pointless forward declarationTor Lillqvist
Change-Id: I3d5de86024ca411545ead5abecff33390ff6c2a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107533 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-12-10Drop obviously unnecessary forward declarationTor Lillqvist
Change-Id: I87afac091869356e2faa0d71ea36055482e3d8b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107532 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-12-10fix printing of 'margins in comment'Caolán McNamara
mangled since... commit c200aa27ee4a0f5a89af6e970c2c22580029eded Author: Caolán McNamara <caolanm@redhat.com> Date: Thu May 21 15:54:15 2020 +0100 remove Size arg from Window::Draw and depend on GetSizePixel which was a real monday-morning commit that bizarrely dropped drawing of the date/resolved widgets entirely and failed to notice that the PixelToLogic call in SwPostItMgr::DrawNotesForPage was originally called on the input pPostIt, not the output pDev Change-Id: I73b87f5889ef13018bcc43f97cd65169a3b77a65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107530 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>