summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2016-07-21Related: tdf#100813 crash in this doc on scrolling past page 44Caolán McNamara
Change-Id: Ib9f1f6f43229ce29e7db7e3fcdacaa10fb692ca4
2016-07-20Simplify dynamic_cast followed by a static_cast.Jan Holesovsky
Change-Id: I288f947fa74fd246dd07dd709fc8c20f72d89f86
2016-07-19Simplify dynamic_cast followed by a static_cast.Jan Holesovsky
Change-Id: I615100fcdcc1bb6e461ecc1f8bdcef301cd68615
2016-07-19clang-tidy performance-unnecessary-value-param in swStephan Bergmann
Change-Id: I6cd0d28dade01366b087aebff894b6f003d87b31
2016-07-19sfx2 lok: expose part number in SfxLokHelper::notifyOtherViews()Miklos Vajna
This way a client can decide if the view cursor it gets is relevant (the views show the same part) or not. Change-Id: I7b274b28f0c4f0509df5071831acf50512eff640 Reviewed-on: https://gerrit.libreoffice.org/27311 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-19tdf#61901 RTF export: fix implicit font name of non-ascii textMiklos Vajna
The problem was that in case we used \loch, then \f only had an affect on ascii characters, not on every other character range. Change-Id: I30a851fe28131f18f5c429273a24c1424d2cec22 Reviewed-on: https://gerrit.libreoffice.org/27310 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-18Resolves: tdf#100731 include palette in checksumCaolán McNamara
Change-Id: I084d840b9fa078ebea3ff1471d8c8bc88171abc7
2016-07-18sw: prefix members of SwXTextSearchMiklos Vajna
Change-Id: I3231605c0468462a36d75318d0070e5e3c36f4d6 Reviewed-on: https://gerrit.libreoffice.org/27276 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-18GSoC notebookbar: don't show empty space for hidden tabsSzymon Kłos
Change-Id: Ia00f64c1cb5d990e852cc297b6b7bd76df4b1b05 Reviewed-on: https://gerrit.libreoffice.org/27191 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-18GSoC notebookbar: dropdown with hidden objectsSzymon Kłos
+ added dropdown for hidden content Change-Id: I86c9277d91b18fbe9e8505ccf170196fdb28638f Reviewed-on: https://gerrit.libreoffice.org/27241 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-18CppunitTest_sw_tiledrendering: blind stack-use-after-return fixMiklos Vajna
Change-Id: I23c0324979939955f94408a452020e9776358967
2016-07-18add tagging to ThreadTasks so we don't need more one poolNoel Grandin
If more than one place in the code submits tasks to the shared pool, then waitTillDone() becomes unreliable. Add a tagging mechanism, so different callsites can wait on different sets of tasks. Also try to protect our worker threads against exceptions from the thread tasks code. Change-Id: Idde664ab50008d31a2dd73910bb22f50e62ae22f Reviewed-on: https://gerrit.libreoffice.org/27042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-15tdf#83054 Preselect current page number in the text entryAkshay Deep
Change-Id: Ie65cde1f2967042afb2988cc429613fda3f0e93f Reviewed-on: https://gerrit.libreoffice.org/27242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-07-15GSoC Writer Table Styles; Cell Style XPropertyStateJakub Trzebiatowski
Implemented XPropertyState for SwXTextCellStyle, that allows to skip export of default valued attributes. Implemented odfexport tests. Change-Id: I906c63d4937e378cf89750616fc9ec929c7f3e44 Reviewed-on: https://gerrit.libreoffice.org/27215 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-15lok::Document::destroyView: clean up view cursors/selectionsMiklos Vajna
Change-Id: Icd3f96a922e7d1aec0d52e90df87ec45790c9807
2016-07-15sw: indentation fixesMiklos Vajna
Change-Id: I6cdc7cff7c45e58c9b684ff53a8dd84af7cf0c83
2016-07-15sw lok: fix shape text editing with multiple viewsMiklos Vajna
When changing the active view shell, sw::DocumentLayoutManager::GetCurrentViewShell() is not instantly updated, only when e.g. the focus changes. This means that calling setView() + paintTile() pairs on random views typically did not use the matching view shell, but the last one. This has a visible effect when editing shape text, as the non-text-edit views had the outdated shape text visible, unlike on the desktop. Fix the problem by using SwDocShell::GetWrtShell() instead. Change-Id: Ia4b67d0a8931692ed4fc5c5e97cc1a09ef81e647
2016-07-15new loplugin unnecessary overrideNoel Grandin
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-15Simplify dynamic_cast followed by a static_cast.Jan Holesovsky
Change-Id: I4bf7f85397f83554f511f80621b5086cda6ab1a9
2016-07-14Blind fix attempt for some GCC versionsStephan Bergmann
Change-Id: Id84c3e8d2306f65ce3153de54efff8c13adcaf37
2016-07-14Disambiguate DeflateThread classesStephan Bergmann
...in package/source/zippackage/ZipPackageStream.cxx and sw/source/core/ole/ndole.cxx. The -fvisibility-ms-compat used under -fsanitze=* (cf. gb__visibility_hidden in solenv/gbuild/platform/com_GCC_defs.mk) causes the vtables of both classes to each be exported weakly from the package2 and sw libraries, respectively, and e.g. CppunitTest_chart2_export under ASan happend to erroneously use the vtable from sw in package2, causing a bogus error. Change-Id: I4e3ca96f1fd9a423b8df9fb1d9682dab8cb63192
2016-07-14Simplify dynamic_cast followed by a static_cast.Jan Holesovsky
Change-Id: Id4ab82db5e0ac95e26299730797a6eac0f925fb8
2016-07-13-Werror=maybe-uninitializedStephan Bergmann
Change-Id: I649c25c4da055a8e92260ac36144283f3d66aabb
2016-07-13tdf#84635 - Slow layout of large tablesNoel Grandin
Based on suggestion from Aron Budea. And do something similar to most other places keeping vectors of weak references where the code looks like it will hold more than a few entries. Measurements: the 26 page file file takes 51s without my path 15s with this patch the 69 page file file takes 5m28 without my path 51s with this patch the 84 page file file takes 8m28 without my path 58s with this patch Change-Id: I8da94c525fc73ebd969e0343c6f074be4f0063b1 Reviewed-on: https://gerrit.libreoffice.org/27093 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-13GSoC Writer Table Styles export of paragraph and char propertiesJakub Trzebiatowski
+ Export of paragraph and character properties + Tests Change-Id: I689deb2c524fdcd462c69a33ad9bc2865890793d Reviewed-on: https://gerrit.libreoffice.org/27115 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-13Moved SfxModule owner to SfxApplicationMark Page
::GetAppData replaced with SfxApplication::GetModule that now returns SfxModule* SfxModule no longer registers self for ownership instead it is now registered using SfxApplication::SetModule Change-Id: Ifbbe1b2b4c5122da8e643b7926d47878d116c6c8 Reviewed-on: https://gerrit.libreoffice.org/26914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-12Resolves: tdf#100538 make searching in shape text a libreoffice-kit only thingCaolán McNamara
This effectively reverts for the normal-app commit bdc1824ea7acfa2fe9d71cdbe57882acce155577 Author: Miklos Vajna <vmiklos@collabora.co.uk> Date: Tue May 19 17:20:10 2015 +0200 SwPaM::Find: search in shapes anchored to the range The catches are that... writer will use SvxSearchCmd::Find and not SvxSearchCmd::Replace when Replacing text, and replacing it afterwards. So replace doesn't work. It might be possible to mitigate that by passing down the m_bReplace to SwPam::Find and do a SvxSearchCmd::Replace on the editeng SearchAndReplace in that case and then change the return code to not-found/found-in-writer/found-in-drawing to figure out what to do there. regexps are disabled in the ui for draw/impress, maybe because they seem not be fully implemented right wrt matching empty paragraphs, so using regexps in writer and letting them into editeng via this loophole is new territory for the editengine I think if I was trying this I'd fix regexp in editengine, then try add searching/replacing in drawing boxes sort of at the end of searching in the main document, something like how searching in frames works. Change-Id: I2875b374a7ede8edd7f479254cbc2da36488abc8
2016-07-12tdf75573 docx - complete frames before starting alternate streamsJustin Luth
An unused odd header was set to be discarded. The handling of unregistered frames occurred at the same time, and thus ended up being discarded as well. Since a frame shouldn't encompass both the alternate stream and the current stream, finalize any unfinished frames first. Change-Id: Ie9123769724da461dd265936aa6b97de7f4dfbbc Reviewed-on: https://gerrit.libreoffice.org/26972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-11GSoC notebookbar: added priorities in all Writer tabsSzymon Kłos
Change-Id: Ib9ac09392f0e50cdd5577b579e5f19d362a53a0e
2016-07-11GSoC notebookbar: File tabSzymon Kłos
Change-Id: I98640b0b4585b2fe1088b13b07dce82a185fd8bf
2016-07-11GSoC notebookbar: added image tab in the WriterSzymon Kłos
Change-Id: Id72bf97fe31625c63bb16b7796c22661cb6fe008 Reviewed-on: https://gerrit.libreoffice.org/27109 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-11sw: prefix members of SwColumnPageMiklos Vajna
Change-Id: I94bc95a25ac11de419f18490b7d466ee22631778 Reviewed-on: https://gerrit.libreoffice.org/27095 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-11tdf#99090 docx export page-break only inside a paragraphJustin Luth
If a paragraph hadn't been started yet, a w:r was being written directly in the /document/body which caused MSWord to complain about a corrupt document. Change-Id: Ie7f629869aab0f3d2405660a033c3f23bbd6baca Reviewed-on: https://gerrit.libreoffice.org/26771 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-11Fix typosAndrea Gelmini
Change-Id: I81671c9a8e7e5b878e605ac0ed6c3d8ef5c5b689 Reviewed-on: https://gerrit.libreoffice.org/27088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-07-10Remove redundant SvxGet* wrappers around LinguMgr functionsStephan Bergmann
Change-Id: Ic431ce4880d0c1277ddb411ca59b3c8e8ca36518
2016-07-09Resolves: tdf#78112 print preview underlines spelling errors...Caolán McNamara
after unrelated display option used, e.g. display field shadings Change-Id: I61cb2456fb4b048fab571d0f2c57855ea4da0336
2016-07-09tdf#100820: missing nullptr check in writer's apphdl.cxxMarkus Mohrhard
Change-Id: I32c22b1e2c6ee23ca712bde7b7f86dada654b802 Reviewed-on: https://gerrit.libreoffice.org/27067 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-08Resolves: tdf#100452 class Date full (BCE,CE) proleptic Gregorian calendarEike Rathke
... implementing signed years with year 0 gap. Date(31,12,-1) last day BCE Date(1,1,1) first day CE New class Date member functions: * AddYears(sal_Int16) to be used instead of aDate.SetYear(aDate.GetYear()+sal_Int16) to handle year 0 gap. * convenience GetNextYear() to be used insted of GetYear()+1 * convenience GetPrevYear() to be used insted of GetYear()-1 * AddMonths(sal_Int32) * operator=(const css::util::Date&) New class DateTime member functions: * operator=(const css::util::DateTime&) Made some conversion ctors explicit, specifically Date(sal_Int32) Adapted hopefully all places that used a sal_uInt16 year to use sal_Int16 where appropriate. Eliminated some quirks in date handling found on the fly. Added era handling to i18npool icu calendar setting interface, which missing was responsible for 0001-01-01 entered in Calc being set as -0001-01-01, hence subtracting one day resulted in -0002-12-31. Change-Id: I77b39fba9599ebd5067d7864f6c9ebe01f6f578f Reviewed-on: https://gerrit.libreoffice.org/27049 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-08SvxGetOrCreatePosDic parameter is unusedStephan Bergmann
...ever since fd069bee7e57ad529c3c0974559fd2d84ec3151a "initial import", so kill the equally old "TODO: remove argument or provide SvxGetIgnoreAllList with the same one" comment for good now Change-Id: Ie7b64306b8d06fc72d0bb49cc1e5fa3b00f59d6b
2016-07-08Disabled async/parallel chart loading for nowArmin Le Grand
Need to check deeper for circumstances leading to problems Change-Id: I58c9601008edc53c958d59d04a30d11bc0c1bba3
2016-07-08Resolves: tdf#100813 crash during pagination of particular docxCaolán McNamara
Change-Id: Id2c99cc6c5fe4c3a5bcf3c0b3f16b603cdd46239
2016-07-08loplugin:redundantcast: redundant static_casts in swStephan Bergmann
Change-Id: I09c1ebaf5742e983ee05942a4c7c17c6aa5179cc
2016-07-08tdf#83054 Writer: Add "Go to Page" Entry in Edit MenuAkshay Deep
Change-Id: I09026910687b019fe33d4016612b8247ff076100 Reviewed-on: https://gerrit.libreoffice.org/25949 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-08sw lok: add LOK_CALLBACK_VIEW_CURSOR_VISIBLEMiklos Vajna
With this, in case a text cursor is turned into a graphic selection in view#0, then view#1 can also hide the text cursor of view#0. Change-Id: I7de89b8537ef8b0985336793b719d93733604bff Reviewed-on: https://gerrit.libreoffice.org/27044 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-08GSoC notebookbar: container with prioritySzymon Kłos
+ extended vcl builder to parse priority + IPrioritable interface for controls with priorities + added IPrioritable as a base for VclContainer + Added PriorityHBox - box which shows controls if we have enough space PriorityHBox listen vcl events from SystemWindow to detect Resize Change-Id: I74ac1a80e7d0a061f5e7a8584dbb2abf956053c7 Reviewed-on: https://gerrit.libreoffice.org/26983 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-08tdf#64372 docx import: don't ignore continuous section breakJustin Luth
If the previous break was also a continuous section break, this break was simply ignored ever since commit 1fdd61db155cf63d5dd55cc2bfb45af33796e131. Thus, the default handler took over and assigned PROP_PAGE_DESC if there was some kind of page style known (either the first page/Standard defaults or any "converted" styles that had been created) which effectively became a new page break. Change-Id: I839570b0330ba274552cc671014e997c42765f4b Reviewed-on: https://gerrit.libreoffice.org/26567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-08oox: indentation fixesMiklos Vajna
These files had consistently no space between the "const" and "&", keep it that way. Change-Id: I5463c488d807344d67fb22ad544c049ea749be94
2016-07-07loplugin:nullptrStephan Bergmann
Change-Id: Ic37247f1e4ffe5a32e2fbb73464dfdfa59a79296
2016-07-07Related: tdf#50613 use an own instance of ThreadPoolArmin Le Grand
Using the global ThreadPool (getSharedOptimalPool()) can lead to problems when more than one usage executes and one of them already calls waitUntilEmpty() what of course influences the other usage. Thus I added an own instance of ThreadPool for async loading of chart models in writer Change-Id: I4bea64af0d36e87081abec95c75574966d0fe5b9
2016-07-07tdf#99165 avoid passing empty control points for beziersArmin Le Grand
Some graphic sub systems have problems to create correct geometry for fat line drawing when 'empty' control points are handed over for bezier curves. Avoid this by offering the mathematical correct default in that cases. Change-Id: I20f484ef4537076889d832d83581844690514acc