summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2017-11-17TSCP: show "OK" dialog when doc. classification changes on saveTomaž Vajngerl
Change-Id: If0b24ceb5789ce505dc329d17fdad114749374d7 Reviewed-on: https://gerrit.libreoffice.org/44859 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-17tdf#113880 a11y: Link 'Numbering style:' label to drop-down listYousuf Philips
Change-Id: I2e758d69f7193f611cfbba5d6189ceb858ecb81e Reviewed-on: https://gerrit.libreoffice.org/44833 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-11-17Notebookbar: PriorityMergedHBox, OptionalBoxSzymon Kłos
Change-Id: I7822fb1b6a342065d66a3fd62f1277e43c2562dd Reviewed-on: https://gerrit.libreoffice.org/44694 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-17TypedWhichId for EE_CHAR* constantsNoel Grandin
Change-Id: I261f8a949ddd858dee196118bb42993a101a2a28 Reviewed-on: https://gerrit.libreoffice.org/44829 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-17TSCP: convert the class. ID to name, fix class. change on saveTomaž Vajngerl
Change-Id: Ic829ebeb488f41f3189170e6fdeebd80b28ae8c5 Reviewed-on: https://gerrit.libreoffice.org/44855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-17TSCP: add or delete watermark when set through class. dialogTomaž Vajngerl
Change-Id: Iedcf0ee7292b447bc2e2030335234aeb4eb14752 Reviewed-on: https://gerrit.libreoffice.org/44854 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-17Resolves: tdf#113871 bounds check kashida posCaolán McNamara
the inner loop checks the kashida validity so reuse the same check outside to avoid index 3 into vector of len 3 Change-Id: I27c30aec1a61ccc8ca6611498d3281eddb4b54eb Reviewed-on: https://gerrit.libreoffice.org/44831 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Martin Hosken <martin_hosken@sil.org>
2017-11-17sw: remove temporary debug code in txtftn that no longer builds anywayMiklos Vajna
Change-Id: I3a5f35f8184a513a2d11b01a13535700be149ead Reviewed-on: https://gerrit.libreoffice.org/44839 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-17loplugin:useuniqueptr in DocxExportNoel Grandin
Change-Id: Iedc5823d23102569ed32a2a0df4c3c60feaca1f6 Reviewed-on: https://gerrit.libreoffice.org/44823 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-17loplugin:useuniqueptr in SwPostItMgrNoel Grandin
Change-Id: I567ec14112ee8d5224c19c7616fd8ed06619c228 Reviewed-on: https://gerrit.libreoffice.org/44822 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-17loplugin:useuniqueptr in SwTransferableNoel Grandin
Change-Id: I803eef7270f8f1a13b253d5ac9ba4d7e41b5adef Reviewed-on: https://gerrit.libreoffice.org/44821 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-17loplugin:useuniqueptr in SwNumRulesWithNameNoel Grandin
Change-Id: If539e9a3d859cea034d53690fdad746479a9f548 Reviewed-on: https://gerrit.libreoffice.org/44820 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-17TypedWhichId for EE_PARA* constantsNoel Grandin
Change-Id: I64d1765336f39c3e3ded4d58ebdee80e97624276 Reviewed-on: https://gerrit.libreoffice.org/44799 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-17TSCP: add category from doc. properties if not found in headerTomaž Vajngerl
If we selected the classification on the toolbar and then go into the classification dialog, we need to add the current category from the doc. properties to the classification result so it is shown in the dialog automatically. Change-Id: I80909d39efa61f263fdb7dd10188f8d7ae12d1e0 Reviewed-on: https://gerrit.libreoffice.org/44853 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-17Use auto/for range loops in PostItMgr (second pass)Julien Nabet
Change-Id: Ib827968c6194173e107b6b9e72c6545f5de673d2 Reviewed-on: https://gerrit.libreoffice.org/44791 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-17TSCP: disable toolbar pop-up if category was set with dialogTomaž Vajngerl
In addition move reading of origin to classificationhelper as we need to read it there. Change-Id: I472b073587e68e6896f915477603a25db9b310d3 Reviewed-on: https://gerrit.libreoffice.org/44848 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-17TSCP: consistently use identifier for categoryTomaž Vajngerl
When identifier is used for category, it is written into the metadata under a different key. When loading it back, it should fill the corresponding properties (identifier if identifier key was used or name if name key was used), otherwise this can lead to inconsistent behaviour when loading the classification data back from the file. Change-Id: Idbd9bde866d117bd7f60bcc224069f00a27fb9e2 Reviewed-on: https://gerrit.libreoffice.org/44846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-16Fix typosAndrea Gelmini
Change-Id: I7b6c699b46fb71c1f19b5e5548c22a11efe8b864 Reviewed-on: https://gerrit.libreoffice.org/44836 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-16fail earlierCaolán McNamara
Change-Id: I8a4f93eea723075103ccdc21e894f44d3bdb7c06
2017-11-16silence coverity#1399176 Uncaught exceptionCaolán McNamara
and probably a bunch of others Change-Id: If4556e8914c770456f9de729426c52d5e27cb691 Reviewed-on: https://gerrit.libreoffice.org/44777 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-16coverity#1421111 Useless callCaolán McNamara
since commit 1c46621b4b7d73537a8cf7d07237ff682278d7ee Date: Tue May 22 15:35:06 2007 +0000 INTEGRATION: CWS chart2mst3 (1.85.12); FILE MERGED Change-Id: I1af5fbaf4ed0bceb2062a9ed2de9ea5703cfbb97 Reviewed-on: https://gerrit.libreoffice.org/44776 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-16use implict conversion operator in TypedWhichIdNoel Grandin
instead of spreading calls to Which() everywhere. Change-Id: Ie32d106e44f5cb583908eeebe254ab8b8168ae61 Reviewed-on: https://gerrit.libreoffice.org/44760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-15crashtesting: assert on export of fdo59645-3.odt to docxCaolán McNamara
probably since... commit 3f2e84b4bd0bbd936e0af845ba7cbf68cb2803d6 Date: Tue Oct 31 23:39:26 2017 +0100 tdf#38778 Fix output of the font in DOC run The font information should be output before field declaration. Added unit test. tdf#38778 DOCX output: no double output of the font info need to also not double output the complex script font info as well as the western and ctl info I misread hAnsi as Asian the last time so thought CJK was already handled, handle it for real this time Change-Id: If57a3ca3f96a7b76f1fb8702a0d5071c0b3e5cd9 Reviewed-on: https://gerrit.libreoffice.org/44771 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de>
2017-11-15lokdialog: Expose cursor visible statusPranav Kant
Change the notifyDialog API a bit. Use a std::vector to keep track of each payload item that needs to be fed to the resulting JSON. Change-Id: If3229a88d2df5368e14290a0e80ebe6206780639 Reviewed-on: https://gerrit.libreoffice.org/44722 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-11-15tdf#108144: tabbed notebookbar add margins to seperatorsandreas kainz
Change-Id: I374873eed5e89c0788869150187219078d22f986 Reviewed-on: https://gerrit.libreoffice.org/44757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2017-11-153813dd1315 follow-up: revert incorrect loop changesMike Kaganski
Change-Id: Ifdccf64630e76f6189668aa7f7412c41a6af04c2 Reviewed-on: https://gerrit.libreoffice.org/44756 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-15coverity#1421163 Unchecked dynamic_castCaolán McNamara
and coverity#1421165 Unchecked dynamic_cast Change-Id: Iabd9560d41ec3ddbdb7a560b7839024b7749f917
2017-11-15sw: document SwRootFrame -> SwLinePortion encapsulation chainMiklos Vajna
Change-Id: I4c8b7ce0375c97b6947f201aa2389c00089b8f5a Reviewed-on: https://gerrit.libreoffice.org/44751 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-15Use auto/for range loops in PostItMgr (first pass)Julien Nabet
+ fix a loop by adding the increment Change-Id: I27add28e03dee4c882931e0c173ec0c23b44d198 Reviewed-on: https://gerrit.libreoffice.org/44743 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-15Resolves: tdf#113615 wrong SwXShape from three possibilities returnedCaolán McNamara
There is the group object itself and the two subobjects all registered with this SwFrameFormat and the right line is randomly returned instead of the wanted one. Its possibly the presence of working a11y under gtk3 causing it to be the only platform apparently with this trouble with a11y querying for details of the grouped object Change-Id: I4d1bd3f826b630dd7734eb1decaf0211cd896894 Reviewed-on: https://gerrit.libreoffice.org/44729 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-15ofz#4213 Integer-overflowCaolán McNamara
Change-Id: Ice22ad92a82971f34c01d2c16fc3d4805b1fd5f3 Reviewed-on: https://gerrit.libreoffice.org/44742 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-15TypedWhichIdNoel Grandin
use a strong-typedef template to give which IDs a type, which we can carry around to do a (a) little bit more convenience when Get()'ing them and (b) a little bit of enforcement of which PoolItem subclass each ID uses Fix a bug in casting EE_PARA_BULLETSTATE to the wrong subclass in AccessibleEditableTextPara::_correctValues Change-Id: I015ce8b3b0f6d21308af182afa3caf122c877a5b Reviewed-on: https://gerrit.libreoffice.org/44587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-14Only do kashida insertion with fonts that have non-zero width kashidasMartin Hosken
Change-Id: I54f51432531072a8ec3cde832003369b23cb6eaf Reviewed-on: https://gerrit.libreoffice.org/44704 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Martin Hosken <martin_hosken@sil.org>
2017-11-14tdf#113037 DOCX Watermark correct ratioSzymon Kłos
Import and export Watermark with padding like MSO does. Shape is scaled to save correct ratio. Change-Id: Iebd8eb5f168e0030320406d4fd6b287e451267bd Reviewed-on: https://gerrit.libreoffice.org/44319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-14tdf#113790: skip charfmt grabbag items existing in autofmt grabbagMike Kaganski
Change-Id: Icc0065c1da9471cb36bfef0da45e2f67381a1a31 Reviewed-on: https://gerrit.libreoffice.org/44706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-14Fix typosAndrea Gelmini
Change-Id: I53b47cab5cbc603bf11adcda8ac2a8373eef26a8 Reviewed-on: https://gerrit.libreoffice.org/44695 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-14RTF import: add odd section break testcaseMiklos Vajna
lcov points out this was not covered so far. Change-Id: I7c5047b75f6548e7738e6118f8d3c0eb9ed76045 Reviewed-on: https://gerrit.libreoffice.org/44702 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-13More proper construction of vnd.sun.star.pkg URLMike Kaganski
See commit bff8d843bd4e5dcca5dc1a60c2c7852b1b72a00b The SwUiWriterTest::testEmbeddedDataSource unit test is adjusted to test the paths with "#". Change-Id: I8d85147128915c7100ab9cc2888eb73c94fe6486 Reviewed-on: https://gerrit.libreoffice.org/44678 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-13sw: prefix members of SwLabRecMiklos Vajna
Change-Id: I5a2f882a51c60229414bc29522d27adbbe37fd62 Reviewed-on: https://gerrit.libreoffice.org/44663 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-13Fix typosAndrea Gelmini
Change-Id: Ia544298334364ece3b3963a4adc00c5e01189b91 Reviewed-on: https://gerrit.libreoffice.org/44654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Page <aptitude@btconnect.com>
2017-11-13Replace list by vector vRedlines (sw)Julien Nabet
Change-Id: I4c5ca9dc59a08343fdbd2c2237f8346572f26011 Reviewed-on: https://gerrit.libreoffice.org/44659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-12use copy constructor to clone PoolItemsJochen Nitschke
Change-Id: I2a45a62fd56cc5a768406c7a6e4c72456f962367 Reviewed-on: https://gerrit.libreoffice.org/44648 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-11RDF: support cloning of all entries for a given typeAshod Nakashian
This is currently unused, but can come in handy later on when we implement copy/pasting of metadata fields. Change-Id: Idd4d6c186fa5c75e06f0ab1b0dfcbc85b6343116 Reviewed-on: https://gerrit.libreoffice.org/44602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-11-11TSCP: Remember the origin and on save, act accordinglyTomaž Vajngerl
If we created the document classification via pop-up (BAF policy) then the highest classification needs to apply the classification from the BAF policy. In other case the classification was set via the advanced classification dialog, we only need to reset the document properties. Change-Id: I0aa0c010e8de3c16920b64a97e5e4dd2e643c2cd Reviewed-on: https://gerrit.libreoffice.org/44576 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-11A user object id is *NOT* a SotClipboardFormatIdEike Rathke
Do not try to squeeze it into such.. especially if SotClipboardFormatId::... enum identifiers are used in a user object id context that is completely not related to the identifier name this is totally confusing. commit fb14be5f8f74f83ba89e15f891ddf1f753dcc62f Date: Thu Mar 12 14:53:28 2015 +0200 create new 'enum class' SotClipboardFormatId to unify types overdid with that. Change-Id: I34b570be9f52b7b94ca8af6b23983393ac3a3a55 Reviewed-on: https://gerrit.libreoffice.org/44612 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-11TSCP: simplify setting the highest classificationTomaž Vajngerl
No need to check the document header for the current document classification category. It is right there in the document properties. Change-Id: I46d31fe2ead034b591ea10b478e7cc9e3ef410ef Reviewed-on: https://gerrit.libreoffice.org/44575 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-11TSCP: use classification key creator instead of stringsTomaž Vajngerl
Change-Id: I2bc224aa0e290b0fab1c989834e5d79a72de35aa Reviewed-on: https://gerrit.libreoffice.org/44574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-11TSCP: bail out quickly in paragraph classification check on saveTomaž Vajngerl
Before saving a document we need to check that the document level classification is at the higher or same level as the individual paragraph level classification is. The trouble here is tha this can be quite a costly operation, so bail out quickly if we don't detect that no paragraph classification has been applied to the content by checking if we have the RDF metadata present or not. Change-Id: Iaef29de7e138937a5c1881cf34c9075fb37ba87d Reviewed-on: https://gerrit.libreoffice.org/44573 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-10TSCP: strip metadata fields when copyingAshod Nakashian
Since the RDF entries are not copied (due to limitations in the clipboard doc), metadata fields become inconsistent upon copying. This is especially problematic for signatures and classification as they are no longer maintainable or verifyable (which is a particularly critical issue for crypto signatures of paragraphs). Change-Id: I5468a961ed43befdc48fcea8be00734453917c1f Reviewed-on: https://gerrit.libreoffice.org/43631 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-11-10rework tdf#113647 solution to be safeCaolán McNamara
rather than passing the pointer around, tragic use of uno apis means monstrous awt::Window thingy has to be passed around and still smuggled through the dispatch arguments to get through the eye of the XDispatch::dispatch needle Change-Id: I353f8a3b0bb698bb58f75576e49efd701f3db8bf Reviewed-on: https://gerrit.libreoffice.org/44585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-08-17 02:33:45 +0000