summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2018-03-14enable column search for welded treeviewsCaolán McNamara
Change-Id: I017dc2e5270d86b2168faf3f9240eeded1fc3533 Reviewed-on: https://gerrit.libreoffice.org/51272 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-14Moving XSAXDocumentBuilder2 to use XFastDocumentHandler:Mohammed Abdul Azeem
This is used in parsing of meta Contexts across different modules. This also involved moving to XFastParser for parsing xml filters in sw, sd, starmath. Change-Id: Ic663aaac6cb20ee8ce5b97cae87c93220f5a2929 Reviewed-on: https://gerrit.libreoffice.org/42989 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-14sw XHTML export: fix handling of character stylesMiklos Vajna
Namespace prefix was missing here. Change-Id: Id746d47713b22e2efd5d679c2325b32a0bee8a09 Reviewed-on: https://gerrit.libreoffice.org/51270 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-14Missing intialization of SwPageDesc::m_pTextFormatCollStephan Bergmann
...in efcb9a7078e08a367816b825d14419ddf351ff3e "use sw::WriterMultiListener instead of SwDepend in SwPageDesc", causing > /sw/source/core/layout/pagedesc.cxx:198:74: runtime error: upcast of misaligned address 0xbebebebebebebebe for type 'SwTextFormatColl', which requires 8 byte alignment > 0xbebebebebebebebe: note: pointer points here > <memory cannot be printed> > #0 0x2b06bea9116b in SwPageDesc::GetRegisterFormatColl() const /sw/source/core/layout/pagedesc.cxx:198:74 during e.g. CppunitTest_sw_odfimport of ASan+UBSan builds. Change-Id: If50a920ca5dafdce6c1a3e2fbf540488685e641a
2018-03-14remove dead SwNoteURLNoel Grandin
According to: <mst_> noelgrandin: apparently this code exists so you can export a text frame as an image and then the urls in the text become image-map links which means that according to my analysis below, nobody has noticed the removal in 17 years :-) SwNoteURL::InsertURLNote was the last place that constructed an SwNoteURL and it was removed in commit bb7ade140df807b6a0f12766a1365b8f8d0fd342 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed Mar 7 13:42:58 2018 +0200 loplugin:unusedmethods and SwNoteURL::InsertURLNote was dead because void SwTextPaintInfo::NotifyURL_( const SwLinePortion &rPor ) const was removed in commit 73139fe600fc1399ae828077981a2498cb0a0b0c Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Fri Jan 19 13:10:22 2018 +0200 loplugin:unusedmethods and SwTextPaintInfo::NotifyURL_ was dead because void SwTextPaintInfo::NotifyURL( const SwLinePortion &rPor ) const was removed in commit be8c414567f49242164b1fdfb12764b16be355c1 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Fri Jan 19 09:13:03 2018 +0200 loplugin:unusedmethods also check for functions returning bool and NotifyURL was dead because calls to it were removed in commit 1b666235f6b0b0f0b13f473bf3b639f4f5f0b12f Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed Jan 3 09:08:52 2018 +0200 loplugin:singlevalfields improve copy constructor check those calls were removed because the m_bURL field of SwFont was always false. tracing back, we find that m_bURL was called bURL before commit b4e2a13f46a247002b239d04ff3bf1d1a98d08c2 Author: Miklos Vajna <vmiklos@collabora.co.uk> Date: Mon Oct 26 08:55:17 2015 +0100 sw: prefix members of SwFont and we find that a method void SwFont::SetURL(const bool) that modified bURL was removed in commit 407731c9f403c35357a0d1428c9b99835f79a5f7 Author: Noel Grandin <noel@peralex.com> Date: Tue Jul 21 10:44:17 2015 +0200 loplugin:unusedmethods sw and we find that calls to SetURL were removed in commit da7671e4f7482110ecd0cfbfd7dbd9e0b873c81c Author: Andreas Martens <ama@openoffice.org> Date: Thu Mar 15 14:59:12 2001 +0000 Opt.(FME): The new attribute handler makes a lot of code superfluous which appears to be the root of the problem Change-Id: Id2362ce216c06bc8dcf71698695d708eb494af4e Reviewed-on: https://gerrit.libreoffice.org/51225 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-14tdf#115565 Change tab key behavior to navigate out of gotopage controlJim Raykowski
...in Writer Sidebar Navigator deck helper toolbox Change-Id: Ieeabcb30f421aa0ce2a5f841e45fff5f57358215 Reviewed-on: https://gerrit.libreoffice.org/50295 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-13use sw::WriterMultiListener instead of SwDepend in SwDDETableBjoern Michaelsen
Change-Id: Iaf3b3429d48ecebae5aaf27b384377aec607d3ba Reviewed-on: https://gerrit.libreoffice.org/51188 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-03-13use sw::WriterMultiListener instead of SwDepend in SwPageDescBjoern Michaelsen
Change-Id: Ifaf9c808e04e736d0a1f7eaf884b8674ac78e0f3 Reviewed-on: https://gerrit.libreoffice.org/51189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-03-13weld insert table dialogCaolán McNamara
Change-Id: I17bdbba38a74ea05b0d6869ee04f01f870a3b17b Reviewed-on: https://gerrit.libreoffice.org/51219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-13set welded enties to activates-defaultCaolán McNamara
cause the vcl ones are equivalent to this so less change Change-Id: I60d9ba5faab6c133242b002b81fa8e4747a92383 Reviewed-on: https://gerrit.libreoffice.org/51220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-13sw: try to fix Android build, use printf macroMichael Stahl
Change-Id: I94208553c7678d9d108ec3f76decc3c38d69802e
2018-03-13ofz#6891 empty vector accessCaolán McNamara
Change-Id: Ic36d03d2646ebd90bea5fa91bc4dac3596a55d4a Reviewed-on: https://gerrit.libreoffice.org/51224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-13tdf#116354 Termchange: Picture -> ImageSamuel Mehrbrodt
Change-Id: I01a87ca6647a6e7dba4c20d20c2e3120c2a96feb Reviewed-on: https://gerrit.libreoffice.org/51218 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-13SDI: don't #define/#undef names of actual classes for slot headersMike Kaganski
Visual Studio 2015/2017 cannot handle that correctly, and emits a lot of intellisense errors. So, just prepend the define with "ShellClass_" Change-Id: I473ceb7e0a88e114b92e6342fd4ae63015cafd3e Reviewed-on: https://gerrit.libreoffice.org/51135 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-13tdf#116179 Support reading "auto" colour from docxLuke Deller
In docx a colour value is represented as a 6-digit hex RGB value, or alternatively the word "auto" to represent automatic colour. - Add support for reading the value "auto" as COL_AUTO. Previously this would be read as if it were a hex value, stopping at the letter 'u' which is not a valid hex digit, resulting in the colour 0x00000A - a very dark blue, which looks close enough to black that it went unnoticed for a long time :-) - Remove code which tried to handle this wrong 0x00000A value, including the constant OOXML_COLOR_AUTO, as it is no longer needed and will cause surprises for anyone who really wanted this exact shade of dark blue - Fix unit tests that were checking for 0x00000A Change-Id: I6000070341931147ff9341ad6281cd3b53c02b46 Reviewed-on: https://gerrit.libreoffice.org/50995 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-13Translate German variable namesJohnny_M
Akt -> Current in docxattributeoutput Change-Id: I9139eeb3cc4f893b9d6ae60b8373641e467b34e9 Reviewed-on: https://gerrit.libreoffice.org/51029 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-13Translate German variable namesJohnny_M
Akt -> Current in docnum Change-Id: Ia6d67ee3f3c4cf15bbfe2fabf2baa1f4adbd91a8 Reviewed-on: https://gerrit.libreoffice.org/51027 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-13Translate German variable namesJohnny_M
Akt -> Current in rtfsdrexport Change-Id: I87fd3c26f785771bb7bef252ce6a99f0e1a5875f Reviewed-on: https://gerrit.libreoffice.org/51031 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-13Translate German variable namesJohnny_M
Akt -> Current in crsrsh Change-Id: Ifea6e66605556b197b64aa453902326e00631d76 Reviewed-on: https://gerrit.libreoffice.org/51026 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-13Translate German variable namesJohnny_M
Akt -> Current in doctxm Change-Id: I45c99d61047b4a45af27ab1da61969b1ddfa54db Reviewed-on: https://gerrit.libreoffice.org/51028 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-13Translate German variable namesJohnny_M
Akt -> Current in itratr Change-Id: I0d35874ad412a825242de6474860d745f94ae6aa Reviewed-on: https://gerrit.libreoffice.org/51030 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-13Translate German variable namesJohnny_M
Akt -> Current in wrtw8esh Change-Id: Ie2933ad59f9e01cfce57a5b3847048323be787c4 Reviewed-on: https://gerrit.libreoffice.org/51036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-13Translate German variable namesJohnny_M
Akt -> Current in ww8graf2 Change-Id: Idf70cdc5ebac2385ad7a74084b58c1a1aae652a7 Reviewed-on: https://gerrit.libreoffice.org/51037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-13Translate German variable namesJohnny_M
Akt -> Current in ww8graf Change-Id: I4b95d4d884798020feff6c6efa09ba4891886171 Reviewed-on: https://gerrit.libreoffice.org/51038 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-13Translate German variable namesJohnny_M
Akt -> Current in unovwr Change-Id: I8825f40a6756c73543b7fcdea32313034ecfa1d8 Reviewed-on: https://gerrit.libreoffice.org/51035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-13Translate German variable namesJohnny_M
Akt -> Current in swhtml Change-Id: I54cad4bfd4ae411d397426deab9236fe3cb0c008 Reviewed-on: https://gerrit.libreoffice.org/51034 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-13lokdialog: Tunnel the spell-checking context menu with recommendations.Jan Holesovsky
Change-Id: I1a7952e88a3f89346c97d2516628b4a7a0423de6 Reviewed-on: https://gerrit.libreoffice.org/51062 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/51166 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-03-13Revert "lok: Don't freeze the LibreOfficeKit via the spell-checking popup..."Jan Holesovsky
This reverts commit 551e639f467813e52ff4301822b6a7f8778a2ef4. Change-Id: I0c7c85fe22d53aa5587ec119e1c3242682b88e43 Reviewed-on: https://gerrit.libreoffice.org/51164 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-03-13sw XHTML export: avoid <u> for underline in ReqIF modeMiklos Vajna
The spec insists on the CSS equivalent (while <b> and <i> is OK). Change-Id: Ied3ebc896403ab85f544b0071e841e35eafdeb64 Reviewed-on: https://gerrit.libreoffice.org/51158 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-13sw XHTML export: always write images as PNG in ReqIF modeMiklos Vajna
JPG image would have to be JPG + PNG fallback, at which point it's easier to just write PNG. Change-Id: I6e4f0759244d29735fdcda8e050d198f118c737d Reviewed-on: https://gerrit.libreoffice.org/51151 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-13tdf#114552 Convert anchor toggle to anchor menuSamuel Mehrbrodt
Since we now have three, not two anchor types. Change-Id: I9654de574a9d546d2191093cba9c192fac3cd3d7 Reviewed-on: https://gerrit.libreoffice.org/50987 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-12tdf#107094 backward heading search doesn't always workCaolán McNamara
regression from... commit 84e44386d70e886f9bae633ebe915ea3a52f8dbd Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Nov 12 10:35:18 2014 +0000 coverity#982189 Unchecked return value so put it back the way it was and explicitly ignore the return instead Change-Id: I6f5ef42b38236ea5f70ddbccfa25a81f2f3e976c Change-Id: I0c0084247e8570ace2198fa893db273dab00d2b0 Reviewed-on: https://gerrit.libreoffice.org/51146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-12forcepoint #21 pop on empty stackCaolán McNamara
Thanks to Antti Levomäki and Christian Jalio from Forcepoint. Change-Id: I25b1c6361fb0a3ae6b01f2be870c9e1b49bf5b84 Reviewed-on: https://gerrit.libreoffice.org/51114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-12forcepoint #24 back() on empty vectorCaolán McNamara
Thanks to Antti Levomäki and Christian Jalio from Forcepoint. Change-Id: Idb6723b53a1ae8aaca80847bfe643bc4abaedd21 Reviewed-on: https://gerrit.libreoffice.org/51121 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-12forcepoint #23 Null dereferenceCaolán McNamara
Thanks to Antti Levomäki and Christian Jalio from Forcepoint. Change-Id: I2e68a6c3fe1846fbfaaa0305c02da135a930d863 Reviewed-on: https://gerrit.libreoffice.org/51120 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-12forcepoint #22 pop on empty stackCaolán McNamara
Thanks to Antti Levomäki and Christian Jalio from Forcepoint. Change-Id: I964c79af0087075df0142cd251fd304a68bc497b Reviewed-on: https://gerrit.libreoffice.org/51119 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-12loplugin:redundantfcastStephan Bergmann
Change-Id: If705487606f419d28504341808da3301b585bf91
2018-03-12sw: prefix members of SwColumnDlgMiklos Vajna
Change-Id: I3689035ff23ee6610544ace2e9c7e85f38a14827 Reviewed-on: https://gerrit.libreoffice.org/51097 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-12ofz#6827 drop last anchor pos if it will be joinedCaolán McNamara
Change-Id: Ib36b74b455f741d9dcccbdf244d21453837bda3c Reviewed-on: https://gerrit.libreoffice.org/51093 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2018-03-12loplugin:redundantfcast look for redundant copies in return statementsNoel Grandin
Change-Id: I5f416c865dfe1c36018784246a8007452eb42008 Reviewed-on: https://gerrit.libreoffice.org/50996 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-11use sw::WriterMultiListener instead of SwDepend in SwXTextPortionBjoern Michaelsen
- also switch from old Modify() handler to new SwClientNotify() - also simplify some sequence generation with C++11 Change-Id: I219f626ce51e07c581ddf49d0cf5dc66e2d6a997 Reviewed-on: https://gerrit.libreoffice.org/49567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-03-11use sw::WriterMultiListener instead of SwDepend in SwJumpEditFieldTypeBjoern Michaelsen
Change-Id: I93f6dbf4eda561d68146be714e633576394d5a75 Reviewed-on: https://gerrit.libreoffice.org/49566 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org> Tested-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-03-11introduce sw::WriterMultiListenerBjoern Michaelsen
- it can handle multple sources to listen to: this should make SwDepend (always been a hack) soon obsolete - also add a unittest for it - WriterMultiListener notifies via hints about reregistering, so help migrating away from these crazy static_cast<>(GetRegisteredIn()) - fix expected<->actual asserts in uwriter.cxx Change-Id: I8c70826d1a8be5c8097d81304f0df42bb7319cd4 Reviewed-on: https://gerrit.libreoffice.org/49565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-03-11weld color pickerCaolán McNamara
Change-Id: I487b9a0cc13b2b60a0f1e28667773b5d3b5c66cc Reviewed-on: https://gerrit.libreoffice.org/51001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-11has-default without can-defaultCaolán McNamara
Change-Id: Id10bf6afd455c1f78152aabde033b24cb879db36 Reviewed-on: https://gerrit.libreoffice.org/51056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-11Move (and rename) graphic stuff from svtools to vclTomaž Vajngerl
This is preparing to change how GraphicManager works where it won't base itself around GraphicObject anymore but Graphic. No functional or cosmetic change was made to the classes, only changes that were needed because of the move and rename. The only thing that wasn't moved is the GraphicRenderer as it is not needed in vcl for now (but makes sense to move it in the future to keep graphic stuff together). grfmgr was renamed to GraphicObject as the GraphicManager will be changed a lot and most likely moved out, so the name grfmgr won't make any sense anymore. All the UNO implementations were renamed with a prefix Uno and used the same name as the class name. This is made to be more specific which are the Uno objects (for example graphic.cxx contained the implementation of XGraphic, which is similar to graph.cxx contains Graphic). Change-Id: I54a2fa6c7e997469aaa7770db05244adb9f64137 Reviewed-on: https://gerrit.libreoffice.org/51068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-11tdf#108482: ignore repeated headlines' previous instances heightMike Kaganski
Change-Id: Idae0b99c4171556612fb41bb02f1c48bbfeec4b2 Reviewed-on: https://gerrit.libreoffice.org/51073 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-11use XML_EMBEDDEDOBJECTGRAPHIC_URL_BASE defineTomaž Vajngerl
Change-Id: I6d37cc1e745b797a1c727a988177916291b650be Reviewed-on: https://gerrit.libreoffice.org/51049 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-10remove references to {Header,Footer,Para}GraphicURLTomaž Vajngerl
Change-Id: I559f25ee99f7b8b49545390479cbb06d3c601d3c Reviewed-on: https://gerrit.libreoffice.org/50982 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-09Remove unused HIDsGabor Kelemen
These were no longer used in the code. This should help me in identifying obsolete and missing HIDs in helpcontent. Found by this somewhat sophisticated method: for mod in $(find -name helpids.h) ; do echo $mod; for i in $(grep ^#define "$mod" | cut -d " " -f2 ) ; do if [ $(git grep -c "$i" $(echo "$mod" | cut -d "/" -f 2 ) | wc -l) -eq 1 ] ; then echo "$i"; fi ; done done Change-Id: Iaf8179322419ce51175bc5a42fedec0add8c5241 Reviewed-on: https://gerrit.libreoffice.org/50680 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>