summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2017-08-28Translate German comments/debug strings (leftovers in dirs starmath to sysui)Johnny_M
Translates leftovers found using a custom regex. Additionally translated: - One randomly found comment in /reportdesign - Test strings in /stoc/test (let's see if it works) Change-Id: I5f893c194c4b56b5365700928a3b8b63936d03e2 Reviewed-on: https://gerrit.libreoffice.org/41583 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-08-28sw: don't undo paragraph signaturesAshod Nakashian
Change-Id: I188ab9dfebd5abd24f4e404bda13d40be022b7c4 Reviewed-on: https://gerrit.libreoffice.org/41596 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-08-28sw: insert paragraph signature fieldAshod Nakashian
Change-Id: Ibf062c19b9896841df765bc39716cddad8bc12f2 Reviewed-on: https://gerrit.libreoffice.org/41602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-08-28sw: validate paragraph signatures on loadAshod Nakashian
Change-Id: I5ce2587d15c3f0d47cbc0f06e96246cf4dd984cb Reviewed-on: https://gerrit.libreoffice.org/41595 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-08-28sw: remove signature metadata on deleting signature fieldAshod Nakashian
Change-Id: I1f82b2d59889c1ba84d91880df13d12d3e5b796c Reviewed-on: https://gerrit.libreoffice.org/41594 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-08-28sw: invalidate paragraph signature on editAshod Nakashian
Change-Id: I7267b1492f2eff043058a9322286f742338a2335 Reviewed-on: https://gerrit.libreoffice.org/41593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-08-28sw: sign paragraphs and validateAshod Nakashian
Change-Id: I917ad1460c89183eec38d50de8a0de2d76239ea6 Reviewed-on: https://gerrit.libreoffice.org/41592 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-08-28fix tdf#112025 insert docx into existing documentManfred Blume
Change-Id: I41f694bf3c2aa4edcad19a05d5dda6e87456d08f Reviewed-on: https://gerrit.libreoffice.org/41469 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-08-27coverity#1416667 Unchecked dynamic_castCaolán McNamara
Change-Id: I562f7b41da67b65609d3eb156f52e2fa0adc9fd4 Reviewed-on: https://gerrit.libreoffice.org/41604 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-27coverity#1416883 Useless callCaolán McNamara
Change-Id: Icf2dae3e69a84368a69f954276286483e3714aa0 Reviewed-on: https://gerrit.libreoffice.org/41605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-27coverity#1416886 Unchecked dynamic_castCaolán McNamara
Change-Id: I5a6a4ec99449d70d2dd812cf5520900e4d0d3d14 Reviewed-on: https://gerrit.libreoffice.org/41603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-27convert code-class in ErrCode to scoped enumNoel Grandin
Change-Id: I9aa8703921308d6fee8bae9ee2d7b29e19181cc7 Reviewed-on: https://gerrit.libreoffice.org/41601 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-27OUString: constify, avoid unnecessary assignmentsMatteo Casalin
Change-Id: I697e19196b7d3ab9febafc05b07eb8c2aa218248
2017-08-27Calculate values only when they are really neededMatteo Casalin
Change-Id: I21d1df718b3d453220200defb16f07bbb5b2baa3
2017-08-26sw: new RDF helpersAshod Nakashian
These are to help with adding paragraph signature metadata. Change-Id: Icac32c9e7937696f755ff3c99d619e97d56fc2e8 Reviewed-on: https://gerrit.libreoffice.org/41590 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-08-26tdf#111980: DOCX: Handle ActiveX radio button groupTamás Zolnai
Change-Id: I3372b3b69623bda5c6e8587215e8fb7056fdf0a7 Reviewed-on: https://gerrit.libreoffice.org/41586 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-26tdf#32991 DOCexport: MSO-compatible table justificationJustin Luth
Although LO could round-trip the files, MSO didn't open them properly, indicating both import and export differences. There are two table justification codes: sprmTJc and sprmTJc90. LO appears to treat sprmTJc90 as the WW8 version, but actually both are valid. TJc is the LOGICAL justification - meaning that it is affected by RTL/LTR settings. TJc90 is the PHYSICAL justification, regardless of BiDi. https://msdn.microsoft.com/en-us/library/dd951612(v=office.12).aspx Based on testing results, it appears that MSO REQUIRES TJc codes. If it isn't defined, MSO uses the default value of TJc:LEFT, and ignores TJc90 code. It appears that MSO always writes out both codes if they aren't the default values. This patch only deals with the export difference. Change-Id: Id722261acab7ae6c0b7d808be75fc3452c2255d8 Reviewed-on: https://gerrit.libreoffice.org/41584 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-08-26remove dead comment.Justin Luth
The code that this comment documented was /* ... */ commented out in 2004 commit ed9a3e51ef9353dd028126496a1a105570dc48a2 That dead block of code was removed in 2010 commit 6eb5f64fd829338614d12212ad9c03ec616f3436 but they didn't take the comment out with it. Change-Id: Id0ef75c09bd060e2621400492fb404eebbee6385 Reviewed-on: https://gerrit.libreoffice.org/41581 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-08-25tdf#109267 sw: fix confusing return value of AppendRedline()Michael Stahl
AppendRedline() has a boolen return value which is rather unclear and confusing: most callers don't even check it, but SaveMergeRedline::InsertRedline() expects "true" to mean that its redline hasn't been deleted, whereas makeRedline() expects "true" to mean that the redline was somehow "valid", even if it has been deleted and merged with an existing one. The "bMerged" variable in AppendRedline(), which is the source of the confusion, was introduced with commit 81286906d0b76a3b6c4443378877828290c3e5f0 "docx import fixes for: redlines". Split these differing expectations into different return values of a new enum type. Change-Id: If81631bde49ee52a249f5ba1dd64ab8e92fffaf7
2017-08-25tdf#109267: Fix crash during undo of delete inside redline insertRosemary Sebastian
Change-Id: I070ce600c10f469b914cc1d6c036a55f33dc9529 (cherry picked from commit bd37233020266a5892d6ec7022688e3dfb9cef75) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2017-08-25ofz#2877: crash in SVTB16ShortCaolán McNamara
sal_uInt16 wraparound Change-Id: Ifd791bdd5f1b96576fdd4ca6665bb972fb8b1e4c Reviewed-on: https://gerrit.libreoffice.org/40848 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-25coverity#1416667 Unchecked dynamic_castCaolán McNamara
Change-Id: I1df3f13c47a021bad7c5b5ab7d5804dc70f091c8 Reviewed-on: https://gerrit.libreoffice.org/41558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-25Drop gratuitous initial :: from comphelper::ProfileZoneTor Lillqvist
Change-Id: Iae7d86b857d0563d9ed9d9b4187e009554698412
2017-08-25tdf#60351 - add unit test for shape brought to foregroundJustin Luth
Test for this comment in d59ef5b2ddb9249905fecf941be6ec83251d12de // We should bring it to front, even if wp:anchor's behindDoc="1", // because otherwise paragraph background overlaps the graphic // TODO: if paragraph's background becomes bottommost, // then remove this hack Actually, the proper fix for this would be that the paragraph background also "wraps" around the picture (just like the text), not that the paragraph background becomes bottommost. The main concern in forcing to the foreground would be if wrap_THROUGH text would become hidden. However, testing suggests that cannot happen in this code. In that case, the worst would be that this shape now overlaps another shape - a rather unlikely situation. So this hack should be safe and maintained since it visually fixes a compatibility problem. Change-Id: I96495cd08a580afbca71a7f6d6dfd85652ff021b Reviewed-on: https://gerrit.libreoffice.org/41487 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-08-25Allow non-modal Dialogs during FileImport/LoadArmin Le Grand
When opening a file that triggers Dialogs (e.g. cannot read/repair/FileType) the Frame from which it was initialized gets blocked. This irritates quite some people. Changed this to a non-modal Dialog so that the user can continue to work with all opened docs, open new ones, close and print/PDF/export these. Change-Id: I048d3de3369527cec20d26396b87439254764b8a Reviewed-on: https://gerrit.libreoffice.org/41534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2017-08-25loplugin:unusedmethodsNoel Grandin
Change-Id: Iaaf9092ec4d6189492906648b84494d087fed81f Reviewed-on: https://gerrit.libreoffice.org/41539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-24tdf#111934: add document for filters-testsMichael Stahl
Thanks to infostud91@gmail.com for the document; unfortunately git tells me that i can't set the commit author to just an email address. Change-Id: I844e725d06cfa2a56adcd93aaa0a222fbb14028f
2017-08-24Watermark: not visible if page background was setSzymon Kłos
Watermark was drawn under the page background. It has to be placed on the upper layer to be visible. Change-Id: I132a313eed6fb712aafdca14a38fe559aa4231c8 Reviewed-on: https://gerrit.libreoffice.org/41289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-08-24tdf#111870 Translate the "My AutoText" string in the Edit Categories windowGabor Kelemen
Change-Id: I483fa998d140c8458948fe19c5338e7af0d32527 Reviewed-on: https://gerrit.libreoffice.org/41234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-24tdf#91781 Removal of Format > ColumnsYousuf Philips
Columns tab is available in Format > Page and in Format > Section > Options which makes this menu entry redundant Change-Id: Ia637b7fe5c95ba075bad921cacb9d2e41e159cb8 Reviewed-on: https://gerrit.libreoffice.org/39017 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-08-24sw:rtf - timely export of footnote char propertiesJustin Luth
related to tdf#82173 and tdf#108949. Write the footnote character properties now - otherwise they will affect text incorrectly later on. Change-Id: I33af1586a51f9028ef5b0d646e4ba3d746c77a2c Reviewed-on: https://gerrit.libreoffice.org/40435 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-24Consistently use OUString in test::DirectoriesStephan Bergmann
Change-Id: Ia5fd8af34ee9d2f37e4450ab241f6bb9a06445b2 Reviewed-on: https://gerrit.libreoffice.org/41466 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-08-24Related: tdf#108795 a shared SvxAutoCorrect instance can not be statefulEike Rathke
An SvxAutoCorrect instance is shared via SvxAutoCorrCfg::Get().GetAutoCorrect(). Since commit 284eb106767d094fc5c547efd6c11cc390e3538a and following the SvxAutoCorrect::bRunNext/HasRunNext() introduced a state whether a previously inserted NO-BREAK SPACE should be removed again, depending on the next character input. That does not work, for example, if SvxAutoCorrect::DoAutoCorrect() is called from two different EditEngine instances, like it is the case in the Calc input line and cell which are synchronized; or any other two or more instances for that matter. The caller has to pass and remember a flag that is maintained by SvxAutoCorrect. Change-Id: I79a26d2ba44cc40771979a78b686c89f0c80b412 Reviewed-on: https://gerrit.libreoffice.org/41475 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-23DOCX: Fix an other test case of ActiveX control exportTamás Zolnai
When LO control is anchored to the end of the run, it is exported into a new run. Change-Id: I9269fd1b34924780aad61c452d1e2094dc8e4aad Reviewed-on: https://gerrit.libreoffice.org/41472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-23VML, Watermark: detect shapetype from other subdocumentsSzymon Kłos
In some documents Watermark wasn't visible because shapetype wasn't detected. It was impossible to use shapetype defined in header1.xml in shape placed in the header2.xml. Change-Id: Ib406c8fc702968684ad46efd0857b768af2820f5 Reviewed-on: https://gerrit.libreoffice.org/41395 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-23drop SwBackgroundDestinationItem wrapperJochen Nitschke
other call sites just use SfxUInt16Item and overridden Clone does same as base class. Change-Id: I50acb4fbb08b3c2fdc4c7605d0ccecac0e9cc209 Reviewed-on: https://gerrit.libreoffice.org/41449 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-08-23tdf#111964: only trim XML whitespaceMike Kaganski
OUString::trim() uses rtl_uString_newTrim, which relies upon rtl_ImplIsWhitespace. The latter treats as whitespaces not only characters with values less than or equal to 32, but also Unicode General Punctuation area Space and some Control characters. Thus, using OUString::trim() is incorrect when the goal is to trim XML whitespace, which is defined as one of 0x09, 0x0A, 0x0D, 0x20. The comments for OUString::trim() and rtl_uString_newTrim are corrected to describe which characters are considered whitespace. A unit test included. Change-Id: I45a132be923a52dcd5a4c35aeecb53d423b49fec Reviewed-on: https://gerrit.libreoffice.org/41444 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-08-23tdf#109184 auto cell color should be transparentSzymon Kłos
Don't add color to the property map if is set to auto. In this case white color was assumed and tables were white instead of transparent. Change-Id: I7f203b8f3831b86ba8de33dc57de227b3029c6d9 Reviewed-on: https://gerrit.libreoffice.org/41255 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2017-08-23tdf#108943 RTF import: handle \tx inside a list level definitionMiklos Vajna
\tx in the list level definition has a different meaning (we should map it to the ListtabStopPosition UNO property), compared to when it's used as a plain text property. Change-Id: I7b98ae3d82bbd2c4ad41d0d7f4ad50525c4d0f9a Reviewed-on: https://gerrit.libreoffice.org/41442 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-23convert message box style bits to scoped enumNoel Grandin
and fix harmless bug in ImpSVGDialog::ImpSVGDialog, which there since commit 6456f1d81090dd5fe44455c09ae3ede7ec6ac38a Date: Fri Feb 4 14:52:54 2011 +0100 ka102: added/removed files for SVG import and module cleanup Change-Id: I66b2ec2b029431ab453e54e962863e4ed7d78962 Reviewed-on: https://gerrit.libreoffice.org/41412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-23Fix typosAndrea Gelmini
Change-Id: Ic78d3e15c5e58f1306f8448c0806db275b3ae616 Reviewed-on: https://gerrit.libreoffice.org/41435 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-08-23tdf#111975: Inline checkbox control's label is not saved to DOC formatTamás Zolnai
This MiserableFormFieldExportHack lives from the beginning of the git history: 7155b11b7eac65e242aca1efaf29ffcfa28f2564 So it might be a workaround of an old issue. By now when the checkbox is not inline, but a floating one, it is exported as ActiveX control, which works nicely. So just remove this workaround and let the code export also inline checkboxes as ActiveX controls. Change-Id: I350b7a7595bb46334c63d9dfcf40abf9e10943bc Reviewed-on: https://gerrit.libreoffice.org/41436 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-22tdf#97362: TextPortionEnumerationTest partially migrated to python (part 6)jmzambon
Convert tests: - test_range_hyperlink_meta - test_range_ruby_meta - test_range_meta_hyperlink - test_range_meta_ruby - test_range_meta_meta Change-Id: I5e7adba17ad19e8c299d178fe45ed7e987b92cf0 Reviewed-on: https://gerrit.libreoffice.org/41098 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-22tdf#94882 use first page header on first pageLuke Deller
The very first page of the document should always be formatted using the "first page" settings in the page style, regardless of the page number set for that page. Change-Id: I49cb00cef8b1d10120349073dee1511657dc84d1 Reviewed-on: https://gerrit.libreoffice.org/39851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-22tdf#110355: loading options from default configVitaliy Anderson
Enable loading the "Protect Form" and "Use LibreOffice 4.3 anchoring paint order (in current document)" compatibility options from default config Change-Id: Ibb0cd4b66516a8b054974d458edf9f28a4b4743d Reviewed-on: https://gerrit.libreoffice.org/41400 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-22sw: Use primitive renderer for graphicsArmin Le Grand
To allow using the prepared VectorData of imported Metafiles (and EMF+), let Writer use a Primitive Renderer for Graphic output. For now, use a temp PrimitiveRenderer (until sw is fully adapted to primitives). Change-Id: Iaa39111c5ef35a052394be6e4d1b86a5a8e33068 Reviewed-on: https://gerrit.libreoffice.org/41411 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-08-22sw: prefix members of SwOLEObjMiklos Vajna
Change-Id: I55f2b9c1c518a569dc36d968450b94efeffa4c5f Reviewed-on: https://gerrit.libreoffice.org/41410 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-22Convert ErrCode area to scoped enumNoel Grandin
Change-Id: Ifa365bbac3c7eb21da9381ec8bb3be6b6785016b Reviewed-on: https://gerrit.libreoffice.org/41402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-22writerperfect: make sure EPUBExportFilter.hxx is self-containedMiklos Vajna
By including it first in its implementation file. Change-Id: I8eda0cc8a7e8c37883dbecc84f3f315cff8c3146
2017-08-22convert WB_QUICK_SEARCH/WB_FORCE_MAKEVISIBLE to bool fieldsNoel Grandin
Change-Id: Ic297d97911a6c0356d24ffe4b58442dfe866139f Reviewed-on: https://gerrit.libreoffice.org/41407 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-15 09:55:11 +0000