summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2017-09-05Use LanguageTag::getBcp47MS() to write MS malformed tags to OOXML, tdf#83190Eike Rathke
Change-Id: Id706cf40f717005df840e7856528dd7bbc866e98
2017-09-05tdf#97362: TextPortionEnumerationTest partially migrated to python (last part)jmzambon
Convert tests: - test_meta_xtextattach_toxmark - test_meta_xtextattach_refmark - test_meta_xtextattach_textfield - test_meta_xtextattach_footnote - test_meta_xtextattach_meta - do_meta_xtextattach - test_metafield_xtextfield - test_metafield_xpropertyset - test_load_store - test_load_store_xmlid Change-Id: I471329e8088b533eedec6a55c521ed313f1960b4 Reviewed-on: https://gerrit.libreoffice.org/41863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-05tdf#104936 RTF export: implement ZOrder of TextFrames / shapesMiklos Vajna
This used to work by accident for the particular textbox, but broke with commit 38f2b8b3b16aab19a2564ec699d253d3dccecc3c (tdf#88811 SwXText::convertToTextFrame: handle shapes anchored to us, 2015-02-03), so write ZOrder explicitly, like other filters already do. Change-Id: Ie8f11f4ec77707fb5aec7a597544d589a99bf6ca Reviewed-on: https://gerrit.libreoffice.org/41921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-05update notebookbar_groupedbar_full view groupandreas kainz
sync appearance between writer and calc Change-Id: I7a91e12c0632be4a1dfbc488bcf6397b5219c43f Reviewed-on: https://gerrit.libreoffice.org/41714 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-09-04tdf#112208 rtfimport: fix missing paragraph first line indentJustin Luth
This is a followup to commit f528f9499bd91b700c549575e88fa102cfffede9 adding ParaFirstLineIndent to that commit's Para(Left|Right)Margin. I also added code for hanging indents, but it doesn't look like that case will ever hit. Just added for completeness. My test unit was created in Word as a hanging indent, but it invokes the firstLine case... Change-Id: I2b04866b9eb4b085503f3b7d3b6e97d4f9e3d19c Reviewed-on: https://gerrit.libreoffice.org/41901 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2017-09-04tdf#111891 unostyle: use default handler for non-page styleJustin Luth
LO 5.1 commit 664197d95becd516c3dac25a50439078ba61e051 introduced a handler for RES_TEXT_VERT_ADJUST to handle page styles, but that meant that the default handler was no longer called for frames (the only other item currently using RES_TEXT_VERT_ADJUST). Change-Id: I33827160fe64dc4cc2107afc26f7ac2e698007e1 Reviewed-on: https://gerrit.libreoffice.org/41538 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-09-04Revert "tdf#111895 writerfilter: avoid hiding shapes behind background"Justin Luth
This reverts commit d21f67fa7fd0360688e083eeb2bbcd57f5414d71. A better fix is commit de0993097cad2fd5819f8bea5ff53cddce7cde41. This patch didn't properly describe the zOrder stuff anyway. The problem technically wasn't with the zOrder - the painting method only made it seem to be so. Thanks to the reviewers for their helpful comments that spurred further areas of research. Change-Id: I586edd189e5b0a25b6e1e64ca42fdf43305997da Reviewed-on: https://gerrit.libreoffice.org/41904 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-09-04tdf#37153 ConsiderWrapOnObjPos: always affect anchoring cellJustin Luth
MSO doesn't make a distinction where the object is located - whether it is contained within the boundaries of the anchoring cell or not. It always affects the anchoring cell's vertical orientation. Both DOC and DOCX enable this compatibility setting. Change-Id: Ifa066d3549b1a6183360b5b01c659e41c681d492 Reviewed-on: https://gerrit.libreoffice.org/41821 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-09-04just blow through the hierarchy to find the polylinesCaolán McNamara
Change-Id: I080243911e07d46a1ecc3f935df8ec86b54931e9 Reviewed-on: https://gerrit.libreoffice.org/41889 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-04tdf#112160 sw: audit GetNextLayoutLeaf() calls in SwFrame::GetNextSctLeaf()Miklos Vajna
GetNextLayoutLeaf() returns the next container, not the follow one, so calls to that without checking first if we are in a table are always suspicious. This leads at the end to strange content move, as described in the bug. There appears to be only a single place in SwFrame::GetNextSctLeaf() which may be executed for split sections and called GetNextLayoutLeaf() unconditionally. Change-Id: I759d9ef63660f3d2ffe006c88b18cba7dba99f33 Reviewed-on: https://gerrit.libreoffice.org/41882 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-04coverity#1399392 Uncaught exceptionCaolán McNamara
Change-Id: Ic9eb2233d4e88ed9923bdabcf09b2a92ad24c0bf Reviewed-on: https://gerrit.libreoffice.org/41880 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-04sw: document the "leaf" layout conceptMiklos Vajna
For some reason this is missing from the usual wiki pages. Change-Id: I2c3dcce983053452dc9fd1e886f8169678d7e6a4
2017-09-04tdf#104602: don't re-draw page background when bOnlyTextBackgroundJustin Luth
In 2014 Writer gained support for Paragraph and PageStyle DrawingLayer FillAttributes, it changed some behaviour with PaintBackground, so that compat setting BACKGROUND_PARA_OVER_DRAWINGS now overwrote the entire "hell" layer as the page background was re-applied. Only DOCX uses this 2012 compatibility setting. Change-Id: I69517efb7d82acd719d6a27a09ba61554dbf1ec9 Reviewed-on: https://gerrit.libreoffice.org/41744 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-04sw: prefix members of SwFormatCharFormatMiklos Vajna
Change-Id: Id1f860b1355ad835fd2ab991c4bbb7db49dbda69 Reviewed-on: https://gerrit.libreoffice.org/41875 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-04loplugin:unnecessaryparen include c++ castsNoel Grandin
Change-Id: I132d3c66f0562e2c37a02eaf4c168d06c2b473eb Reviewed-on: https://gerrit.libreoffice.org/41874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-04New loplugin:dyncastvisibilityStephan Bergmann
...to find uses of dynamic_cast where the static (base) type has hidden visibility while the dynamic (derived) one has default visibility, and which may thus fail at least on macOS like happened in d5ed3cd6dbd22bb18542778f1c48f4d5b3ae0f95 "Make WinMtfFontStyle's base class EMFIO_DLLPUBLIC, too". libcxxabi's __dynamic_cast takes static_type and dst_type arguments. Now, if dst_type (the derived type, with default visibility) is taken from .so A (and thus references the version of the base type info hidden in .so A) but the __dynamic_cast call is made from .so B, it passes for static_type the base type information hidden in .so B, and __dynamic_cast will consider the cast to fail. I'm not sure whether hidden intermediary types (in the hierarchy between the dynamic_cast's base and derived types) acutally cause a problem too, but lets flag them with the plugin anyway. The fixes use SAL_DLLPUBLIC_RTTI. For one, there appear to be no other reasons than type visibility to make those classes SAL_DLLPUBLIC. For another, this nicely avoids any actual changes on Windows (where SAL_DLLPUBLIC expands to nothing, and many of the affected classes were explicityl introduced into class hierarchies as "MSVC hacks"). Change-Id: Ia85a9635cebffb1009a9efc1484b8bd4025585d4 Reviewed-on: https://gerrit.libreoffice.org/41802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-04new loplugin:redundantpointeropsNoel Grandin
Change-Id: I8428d86ea9628d69c2b40b36feee3da428a9fe1d Reviewed-on: https://gerrit.libreoffice.org/41787 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-03Resolves: tdf#112145 pdf export of editengine highlight color fails sometimesCaolán McNamara
When setting a fill or line color on the outputdevice, put it back to its previous setting when finished with the record, PRIMITIVE2D_ID_POLYPOLYGONCOLORPRIMITIVE2D was the one in this case but protect the other similar ones here too Change-Id: Ifb9b182d72bb6c48a9d9480270fde4384be6291e Reviewed-on: https://gerrit.libreoffice.org/41761 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-03Fix typosAndrea Gelmini
Change-Id: I0ce33d497d405398145653b9b7da81bd066f68e1 Reviewed-on: https://gerrit.libreoffice.org/41868 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-03tdf#112169: Crash while saving character background color to DOCXTamás Zolnai
Change-Id: Iff12b9587b639166caef86f895fb841e83596817 Reviewed-on: https://gerrit.libreoffice.org/41857 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-03set parent for insert media file dialogCaolán McNamara
Change-Id: I71eace1995b229caa75e61df363fd8bad981bed1 Reviewed-on: https://gerrit.libreoffice.org/41851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-02tdf#37153 ConsiderWrapOnObjPos: also affect wrap-thru objsJustin Luth
MSO doesn't make a distinction when the wrapping is THROUGH. Both DOC and DOCX enable this compatibility setting. Change-Id: I123801fc83b5f4ac6a26a5ea77ba6dba2c60ec39 Reviewed-on: https://gerrit.libreoffice.org/41795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-09-02convert SHAPEFLAG defines to scoped enum ShapeFlagJochen Nitschke
they were defined in escherex.hxx as SHAPEFLAG_* and in msdffimp.hxx as SP_*. Added include for escherex.hxx to msdffimp.hxx. Filled the missing flag bits. ShapeFlag::Deleted is not used at the moment. Convert ADD_SHAPE macro to lambda. Fix horizontal/vertical mixup in RtfSdrExport::AddLineDimensions. Comments for flag Connector were wrong. The flag applies to shapes which ARE connectors. MSO definition: "connector: A line that is used to connect two or more shapes and that remains connected to those shapes." So Rectangles and such with Connector flag don't make sense. Change-Id: I735de00110411b280a302840dc0fcdfac5156399 Reviewed-on: https://gerrit.libreoffice.org/41754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-02set parent for insert image file dialogCaolán McNamara
Change-Id: Ibf2adff486947926b9624e762873fb8c46e59c71 Reviewed-on: https://gerrit.libreoffice.org/41813 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-01sw: paragraph signatures are detachedAshod Nakashian
While for NSS both types of verification works, for CryptoAPI only detached works. Change-Id: I8de0d7a98c2f857511eeadd2c8e205bc86a71f93 Reviewed-on: https://gerrit.libreoffice.org/41791 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-01sw: move paragraph signatures to the beginningAshod Nakashian
Change-Id: Ic9fb1f74ff19d3e9ad455483b221181f25f09653 Reviewed-on: https://gerrit.libreoffice.org/41790 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-01tdf#101936 sw: ignore comment anchors during searchJustin Luth
Comments are anchored by unicode character U+fff9. If the comment was anchored in the middle of a word, then a search would not find that word. A comment anchor is not a word-breaking character, so remove it instead of replacing it with 0x7f. Change-Id: I4606dbfac74161029029d9807b74bd6ffa285126 Reviewed-on: https://gerrit.libreoffice.org/39361 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-09-01Fix typosAndrea Gelmini
Change-Id: I4496faa9ce7cad393bf06ca789099b045aea2741 Reviewed-on: https://gerrit.libreoffice.org/41785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-01bump FileDialogHelper to XFilePicker3Caolán McNamara
Change-Id: I726676aaa8944bc3b6418abe305ad03f8ec96c59 Reviewed-on: https://gerrit.libreoffice.org/41783 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-01Insert blank page when first page number is evenLuke Deller
When the page number is explicitly changed at a page break, LibreOffice will insert a blank page if necessary to ensure that even page numbers appear on "left" pages. This commit fixes a case that was missed: the case where the page number of the very first page in the document is explicitly set to be an even number. Also: - adjust a couple of unit tests which were referring to specific physical page numbers, that were not expecting this blank page to be there - enhance SwModelTestBase::parseDump to support xpath expressions evaluating to simple values rather than nodes, for use in a test case for this change Change-Id: I1f41760c3bb17bdffb868cf32a1331de87d1d0e1 Reviewed-on: https://gerrit.libreoffice.org/39858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-31Resolves: tdf#112122 Use EndElement instead of dtor to call throwing methodsCaolán McNamara
Change-Id: I1cc3b9af4089f1e657c5c63e0911aac8bdce04f3 Reviewed-on: https://gerrit.libreoffice.org/41756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-31tdf#108765 DOCX: after import, allow default styles againJustin Luth
During import, we don't want LO's style defaults to intermingle with those of MSO [1]. However, if any styles are NOT defined by the document itself, then we want to use that new style with appropriate defaults. For example, if footnotes were never used, that style might not be defined in the .docx file. Later, if a user inserts a footnote for the first time, we certainly don't want the "default paragraph" settings. Instead, we want the default "Footnote" settings. [1]: see commit b95d203bc17c83ec0fe5139f519d53ed1d842d3a Change-Id: Ia71490e795885d3c16f764d0f716f6499765cb67 Reviewed-on: https://gerrit.libreoffice.org/41546 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-08-31tdf#108932 - prevent textbox shrink from actually growingJustin Luth
fix regression from a4dee94afed9ade6ac50237c8d99a6e49d3bebc1 for a particular situation - where the textbox flowed onto the following page. Change-Id: I58fe2909411c4e5e484083cfc395976f0bc4ba17 Reviewed-on: https://gerrit.libreoffice.org/40558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-08-31Resolves: tdf#112123 check m_xAutoStyles like in similar methodsCaolán McNamara
Change-Id: I099da789a0e64fd862d09bb462ccb699e1dc8b9f Reviewed-on: https://gerrit.libreoffice.org/41751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-31tdf#112109 sw: split section frames inside table cells, ignore nested tablesMiklos Vajna
Commit f8a76d218305a56d15b82b9dac4fafa558872780 (tdf#108524 sw: split section frames inside table cells, non-split text frames, 2017-07-06) added support for moving text frame masters to a next page inside section-in-table frames. But the code in SwFrame::GetNextSctLeaf() responsible for this is not up to nested tables, so don't try to split sections in this case. Otherwise we'll end up with frames which are marked as "in table", but don't actually have have table frame parents, so we crash in SwFrame::IsFootnoteAllowed() which assumes being in a table means a table frame parent. Change-Id: Iff19a4eda21a4dbfb9562dea7af8ec6767d47873 Reviewed-on: https://gerrit.libreoffice.org/41748 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-30sw: WW8 import: properly handle consecutive range annotationsMichael Stahl
moz1187869-1.doc crashes on export to ODF because an annotation mark has been inserted that does not have a SwPostItField. In fact, the SwPostItField exists, but the annotation mark is at the wrong position. There are 2 consecutive range annotations in the file, so when Read_And() calls MoveAttrs(), the end of the both annotations are moved 2 times, hence later SwFltControlStack::SetAttrInDoc() will insert 2 annotation marks with the same end position, and the 2nd one will overwrite the name that the 1st one set on the 2nd SwPostItField, while the 1st SwPostItField remains with an empty name. Ensure that the end of an annotation mark is no longer moved once it's on the position of the field inserted in Read_And(). Crash is a regression from 31c54fa7bb03768b425ae019096e0a0e26e9c736. Change-Id: I0fd661e22e51701de67227f9145a13c62b10143e
2017-08-30Correct a test that worked only by chance, tdf#91758 follow-upEike Rathke
... but now doesn't anymore. Change-Id: I573bdda023c69b895afe9959f345fc0e6d862cf8
2017-08-30Resolves tdf#112101 crash on particular file with office:event-listenersCaolán McNamara
Change-Id: I99a007543f90f4024666d296e9a775f8cee15086 Reviewed-on: https://gerrit.libreoffice.org/41723 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-30loplugin:constparam in variousNoel Grandin
Change-Id: I6821a3946f2e8fabf26558a84370c16ac8827fed Reviewed-on: https://gerrit.libreoffice.org/41721 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-30remove insertsymbol cause we have now CharmapControlandreas kainz
Change-Id: I955fe255021996bd717cada64a1c69751a83cf45 Reviewed-on: https://gerrit.libreoffice.org/41715 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-08-29Resolves: tdf#112017 crash on particular odtCaolán McNamara
Change-Id: I6ba2e73562a16afecb6abdfe4f1a40b1e316379e Reviewed-on: https://gerrit.libreoffice.org/41685 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-29Resolves: tdf#112018 number-columns-repeated has the data type positiveIntegerCaolán McNamara
Change-Id: I534885fe7a36a8e3ad891a3f5ed50b589f36e3b9 Reviewed-on: https://gerrit.libreoffice.org/41692 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-29Related: tdf#112018 limit to min of 1 before conversion from signed intCaolán McNamara
Change-Id: I1a27f9ebfbe70891d64afa9553f37f565f2d49bf Reviewed-on: https://gerrit.libreoffice.org/41689 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-29tdf#100492 Skip empty shapes in SVG exportVasily Melenchuk
Some shapes do not contain polyline and meanwhile contain start/end arrows. This is causing unexpected line endings appear in export. TODO: Unittest is disabled, since XML parsing returns only root node without children. So XPATH assert fails. Change-Id: Ibc28f12b0f3838065978a674f0debe8e1b8103e9 Reviewed-on: https://gerrit.libreoffice.org/40422 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-08-29tdf#97362: TextPortionEnumerationTest partially migrated to python (part 7)jmzambon
Convert tests: - test_range2 - test_range3 - test_range4 - test_range5 - test_range6 - test_range7 - test_meta_xchild - test_meta_xtext - test_meta_xtextcursor - test_xtextcursor Change-Id: Iabfa51869611ee027565102f6658b045a182d66e Reviewed-on: https://gerrit.libreoffice.org/41589 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-29tdf#104937 RTF import: \trwWidthA is an absolute valueMiklos Vajna
Not a relative one, so similar to \cellx need to convert these before sending the value to dmapper (which expects an OOXML value, which is always relative). The result of the correct type is that the relative width of the last cell in the table row is smaller, so other cells are wider -> they now reach the expected width. Change-Id: If282eb9a5ec644b38e552b5a66fc64a93538f216 Reviewed-on: https://gerrit.libreoffice.org/41668 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-29Removed duplicated includeAndrea Gelmini
Change-Id: I2dc7df964068e1925630acd65df56f462fe50437 Reviewed-on: https://gerrit.libreoffice.org/41656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-28ofz#3189 Direct-leakCaolán McNamara
Change-Id: I5702fe12c9c56794983536caecfb7d05f26f9b8b Reviewed-on: https://gerrit.libreoffice.org/41649 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-28tdf#111895 writerfilter: avoid hiding shapes behind backgroundJustin Luth
In MSO, page background is "in hell" zOrder, however in LO, page background is at the same zOrder as the text, so avoid hiding shapes behind the page background unless doing so would hide text. When importing gradients/pattern/hatch backgrounds are supported, HasPageBackground will need to be expanded to include those as well. Change-Id: I4496fd3f4c644ac9ac1854090658017078ce3e88 Reviewed-on: https://gerrit.libreoffice.org/41486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-28sw: prefix members of SwFootnoteFrameMiklos Vajna
Change-Id: Ie98687b331d6e7d99d4d3ee673dfc45bbc354ccc Reviewed-on: https://gerrit.libreoffice.org/41615 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>