summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2015-07-24filter: replace boost::ptr_vector with std::vector<std::unique_ptr>Michael Stahl
Change-Id: I9aa0543edf3f0aef3a0a376aa0f82f51c6d93313
2015-07-24filter: replace boost::ptr_set with std::set<std::unique_ptr>Michael Stahl
Change-Id: I171fdb41bef4a7f3ef6418d81a1d99f123c0652c
2015-07-24convert WindowAlign to scoped enumNoel Grandin
Change-Id: I028d108b3a83bd5541d873c4d03b87339cd3be52
2015-07-23Added test for tdf#57197 table row/column insert undo crashVarun
Change-Id: I143d657239dd983396847eb67019e84a202f0bcb Reviewed-on: https://gerrit.libreoffice.org/17284 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-07-22limit storage entry max size to size of underlying streamCaolán McNamara
Change-Id: Ie3772338009c07fea40b637621b1170863830e14 Reviewed-on: https://gerrit.libreoffice.org/17296 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-22read block in one swoop, rather than char by charCaolán McNamara
Change-Id: Ic879c096c6b3167a123cee352361da6c39e57de2
2015-07-22xstUsrInitl contains max 9 charsCaolán McNamara
Change-Id: Ia40d037d7af6cd3a283aa12948e4c5565dcb2ae6
2015-07-22remove some unused constantsNoel Grandin
Change-Id: I8742db77a0cfd99257584d830162c1c7126da263 Reviewed-on: https://gerrit.libreoffice.org/17283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-22tdf#86374 DOCX import: fix btLr text table direction without <w:cantSplit/>Miklos Vajna
Commit 0208ead70a9412ccd554fcef3e9308f8ca17037b (DOCX import: improve btLr table cell support, 2013-02-22) made any table row that has at least one btLr cell fixed height. This causes problems in case a table has a minimal height with lots of content, where the fixed height gives wrong layout, but the minimal height is correct. Fix the problem by only making the row fixed height if <w:cantSplit/> is set (as seen in the old bugdoc), and revert to setting the height type to minimal in any other case. Change-Id: Ibaf91f542e64e5caa7904df97eb6eb52618e0023
2015-07-22loplugin:unusedmethods sw(part2)Noel Grandin
Change-Id: Ib95638267c5a7df73ccdd179dd62ac7c9a53a5e4 Reviewed-on: https://gerrit.libreoffice.org/17262 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-21need to check for after reading and before seekingCaolán McNamara
seeking resets eof, so the IsEof is always false after the first loop Change-Id: I2e533f3f9c494566aabb947c05258a770e883b1f
2015-07-21add testcase for CVE-2015-0097Caolán McNamara
Change-Id: I794cc4de0fb35dc5471c15873649712f03178817
2015-07-21tdf#36796 Status updates for custom shapes buttonsMaxim Monastirsky
We're dealing here with 2 bugs: 1. Single shape buttons (like rectangle, ellipse etc.) don't get the pressed state when active. The cause is that all commands of the same kind (Basic Shapes, Symbol Shapes etc.) are handled as one internally, allowing only one type of status updates. It used to transport the current active shape, but it was changed to a boolean value in the fix for i#41753, and since then used for the pressed state of the group buttons. 2. The pressed state of a group button shows always, even when a user activates a shape from a place other than the drop-down of that button. But in this case the image of the group button doesn't update with the current shape, thus confusing the user on what is currently active. The cause here is that we use (since i#41753) the XSubToolbarController interface to update the last selected function (instead of the old-style status based update), and ToolBarManager notifies a controller about a new selection only if it was made from a particular toolbar that the controller claimed to use in the getSubToolbarName method. Since 7352a7c17875e5adcc4226c45f4a03e11c44ff49 there is a similar regression for other group buttons in sd (like lines, 3D Objects and other), with the same cause. This is also fixed now. Change-Id: Ida074a001ff78bf5bd5bcb8151516daa6e27cbce
2015-07-21SimplifyMaxim Monastirsky
Change-Id: I6fff5af5d623bff6f8adedf6f3d42d849ea4d24b
2015-07-21loplugin:unusedmethods swNoel Grandin
Change-Id: Ied51535fa169451fc4991237122817a34a59f6fe Reviewed-on: https://gerrit.libreoffice.org/17256 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-21tdf#89702 DOCX import: fix too large bullet characterMiklos Vajna
Commit c1f8437dbed0e8b989e41a345ef7e658a6e8a4cd (fdo#83465 RTF import: handle font of numbering, 2014-09-25), changed the "get the me character style of the current numbering's current level" member function to be successfull even in case we're inside a DOCX run, not when we're inside a DOCX paragraph, but outside runs. While this is necessary for RTF, the side effect of this was that unwanted run properties started to affect the above mentioned character style in case of DOCX. Fix the problem by enabling the "in paragraph and run" looking for RTF only. Change-Id: I610bfce6cec15b918fe547402360f5a894401f7e
2015-07-20sw: SwXFlatParagraph::isChecked() return value is invertedMichael Stahl
It was checked if the flag says it's not dirty. Thanks to Varun Dhall for pointing to this problem. Change-Id: I4aa1fef8b2251f0f3e579930b39d6d5a256c1895
2015-07-20svtools: change these SvTreeListEntry functions to unique_ptrMichael Stahl
... parameters to make it clear that they take ownership. Change-Id: I572c5fa6268438a86d0a4fa1d2aef15382cb5607
2015-07-20Added UNO test coverage for SwXFlatParagraphVarun
Change-Id: I2bcc6283ccdc527b968b9da0255922ef3d46953e Reviewed-on: https://gerrit.libreoffice.org/17242 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-20WaE: maybe-uninitializedCaolán McNamara
Change-Id: Idbe9f52b0c4b6eeb2fb7b5d934727bd74e96e6d3
2015-07-20test should check that all levels are equalCaolán McNamara
regression from commit bf586debd4d8274cff2737f02beac465525328e8 Author: Matteo Casalin <matteo.casalin@yahoo.com> Date: Sat Feb 21 12:38:54 2015 +0100 Simplify Change-Id: I09f83b2bab053fcd48fe1a1a4184cc11a4f9d663
2015-07-20Added UNO test coverage for SwXParagraphVarun
Change-Id: I2779114e2655e9574003b929b1517560c21ae4b5 Reviewed-on: https://gerrit.libreoffice.org/17141 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-20convert to typed Link<> in sfx2Noel Grandin
Change-Id: Ifa42bd14d7329ff1043fa736513c468dda30485e Reviewed-on: https://gerrit.libreoffice.org/17195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-19Fix typosAndrea Gelmini
Change-Id: I52cbaad71560d73f5e24f3de3cd62b00d678dd6c Reviewed-on: https://gerrit.libreoffice.org/17187 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-18sw: DOCX export: *really* fix non-well-formed XML with hyperlink/rubyMichael Stahl
Turns out that 84ea33ef9a86f097a248b526554cdc3581c8d725 did not actually fix the problem; it was merely good enough to fool the asserts in FastSaxSerializer that were not yet adapted to the funky maMarkStack. The problem is that the StartRuby()/EndRuby() call StartRun()/EndRun() and that really messes up the mark stack. Prevent that by first ending the run before starting new one in StartRuby(), and then starting a new run after ending the ruby-base one in EndRuby(). The hints handled in SwWW8AttrIter::OutAttrWithRange() are sorted in the right way for this to work (i.e. the EndRuby() will be the last call for any given position). This apparently causes an additional <w:r/> empty element to be written, not sure if that causes any issues but at least the output is well-formed for fdo82849-1.odt. Change-Id: I28ffd029246310ff0e405b0674aef8e724700d4d
2015-07-18sax: convert MergeMarksEnum to enum classMichael Stahl
This should detect if a MergeMarks value is erroneously passed as tag. Change-Id: I7b855a661f182136824cf25f2174a9bcce8ff3d1
2015-07-18sax, sw: try to make that maMarkStack easier to understandMichael Stahl
In DocxAttributeOutput it's not at all obvious which mark() is supposed to be ended by which mergeTopMarks(), so add an extra parameter to the FastSaxSerializer functions and verify with an assertion that a LIFO order is maintained. Change-Id: I5a421e2fb11f15343147417fe0b9b23642c70721
2015-07-17ignore long press after all in writerCaolán McNamara
it appears on a long press on anything not just the document, e.g. on scrollbars etc, which isn't that useful after all Change-Id: Ic6ccacecdad5db100d2f2768ad6b7ce5e36b80a3
2015-07-17BreakPoint isn't really usefulCaolán McNamara
merge branches to fix OSL_DEBUG_LEVEL > 1 build Change-Id: If4a81287ffffbc41d7caa1240293d34e5186f293
2015-07-17loplugin:unusedmethods filterNoel Grandin
Change-Id: Ie33a5ebda9337cf123b39ae18a8d7b4ef12b6991 Reviewed-on: https://gerrit.libreoffice.org/17131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16Added UNO test coverage for SwXTextDefaultsVarun
Conflicts: sw/qa/extras/uiwriter/uiwriter.cxx Change-Id: I963509aae81616711726268a5b215b2ecb93898f Reviewed-on: https://gerrit.libreoffice.org/17125 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-07-16Convert Alignment button to the generic controllerMaxim Monastirsky
Change-Id: I76ead43fa1cfe7ba1b62d2b13c4f4d7658a9f290
2015-07-16Convert FontWorkShapeTypeControl to the generic controllerMaxim Monastirsky
Change-Id: I7824136aa2780c4062a66f7a5284a342862f319a
2015-07-16oox: fix invalid mime type "image/tif"Michael Stahl
(regression from ccfc02f7691848284403d339ee17054169fbff1d) Change-Id: I29a366228bf08f29edfa4a8e963889e34aa3d2ea
2015-07-16silence warning about unknown swipe commandCaolán McNamara
and show context menu on long-press Change-Id: I6d603ebcc049b5ec2f9b23f7e400d995883324ea
2015-07-16coverity#1311944 Logically dead codeCaolán McNamara
for the record its a SwFormatChg we get here at the crash time regression from commit 7de992bcc66c973bb6b247184cac38f01cd1104a Author: Caolán McNamara <caolanm@redhat.com> Date: Mon Jul 13 12:38:18 2015 +0100 fix a11y crash seen on close of tdf#92573 its not the reported crash, which has "gone away" which might be a duplicate of tdf#90502 the switch only handled RES_TITLE_CHANGED and RES_DESCRIPTION_CHANGED so if its anything else, e.g. OBJ_DYING, then don't attempt GetNoTextNode Change-Id: I290d6e633811423c3acc198aba7a60943518ec4a
2015-07-16tdf#39468 Translate German Comments - sw/source/filter/xml/Phillip Sz
Change-Id: Ie637ef4258caf2519a77d596b76cc52570a182e8 Reviewed-on: https://gerrit.libreoffice.org/17077 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-07-16loplugin:unusedmethods svx(part2)Noel Grandin
Change-Id: I161360e2f3113c4814fe1c2c095e602b2c93dcd7 Reviewed-on: https://gerrit.libreoffice.org/17120 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16loplugin:unusedmethods svxNoel Grandin
Change-Id: I92158457b3ffaaf7c84c6f4c87708d766c8c9f61 Reviewed-on: https://gerrit.libreoffice.org/17117 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16loplugin:simplifyboolStephan Bergmann
Change-Id: Ibdfb3a4f66513ef6844c8b7df0c07ffef6258e89
2015-07-16Working toolbar entry: Save As > Remote fileSzymon Kłos
Change-Id: I5601c7847f30a7d5fb7ede5f90b2a6a89f4c8693
2015-07-16'Save As' popup menu in the Writer's toolbarSzymon Kłos
Change-Id: I1b1cb7fcd2ae0e0f50e4d8e3900bc416435e60bf
2015-07-16open remote button in sw standard toolbarSzymon Kłos
Change-Id: I7e702da5d4ecc8c32d91e86bd209ec4b7d4f4431
2015-07-16loplugin:unusedmethods sfx2(part2)Noel Grandin
Change-Id: I82223b72ddb6a9df1ee52a300b083002234602dc Reviewed-on: https://gerrit.libreoffice.org/17075 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16loplugin:unusedmethods sfx2Noel Grandin
Change-Id: I98c455d89f76fbcacf74929a4e8775b4da697f62 Reviewed-on: https://gerrit.libreoffice.org/17069 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-15tdf#87539 map MSO washout filter to LO's watermark colormodeJoren De Cuyper
Change-Id: Id28e301a74a729245b20ba6cd2adecf203633f0e Reviewed-on: https://gerrit.libreoffice.org/16048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-07-15tdf#87437 exclude CR/cell break from redline deletionsJustin Luth
The marker used in Word to identify table cell division was being included in the track-changes deletion from the following cell if the deletion was the first node in the cell. This would cause the two table cells to merge into one when changes were accepted by Word. (Problem not seen in LibreOffice itself.) Change-Id: Ia98017cbba7d3a43b67764ae0fa6447b7e90ca86 Reviewed-on: https://gerrit.libreoffice.org/15340 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-07-15tdf#89007: Fix ShouldRowKeepWithNext conditionMike Kaganski
KeepWithNext shouldn't be applied to nested tables Change-Id: I6df002ae7b00afa0fcf82aab584f85d9a47315eb Reviewed-on: https://gerrit.libreoffice.org/15794 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-07-15cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: Id438b987f72ae57bd4fa882e01fba17d3fa5b95b
2015-07-15svx, sd, sw: GetPoolDefaultItem() can actually return nullptrMichael Stahl
...if you call ResetPoolDefaultItem() first. Crash found by Varun Dhall. Change-Id: I409484c172fb5843270aee2425844076a008b4df
generated by cgit (git 2.34.1) at 2024-08-11 12:21:11 +0000