summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2018-01-23new loplugin: pointerboolNoel Grandin
look for possibly bogus implicit conversions to bool when passing (normally pointer) args to bool params. this plugin comes in the wake of a couple of bugs caused by refactoring, where some of the call sites were not currently updated. Of the changes, the following are real bugs: desktop/../dp_persmap.cxx StartInputFieldDlg in sw/../fldmgr.cxx which occurred as a result of commit 39d719a80d8c87856c84e3ecd569d45fa6f8a30e Date: Tue May 3 11:39:37 2016 +0200 tdf#99529 sw: don't pop up input field dialog before inserting field CSerializationURLEncoded::encode_and_append in forms/../serialization_urlencoded.cxx XclExpCFImpl::XclExpCFImpl in sc/../xecontent.cxx I have no idea how to properly fix this, just made a guess. SwDocTest::test64kPageDescs in sw/qa/core/uwriter.cxx which looks like a simple copy/paste error. Change-Id: I795ebd5ef485a1d36863dc27fe13832989f5a441 Reviewed-on: https://gerrit.libreoffice.org/48291 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-23ofz#5566 sw: HTML import: ignore <DIV> in table structure elementsMichael Stahl
Looking at the HTML4 DTD https://www.w3.org/TR/html4/sgml/dtd.html, inside TABLE only various elements defining the structure of the table allowed, except inside cells (TD and TH elements). DIV in a table but outside cells may cause cursor positions to go off the rails, so better ignore such invalid DIV tags. Change-Id: Ia6195d80670631669c252d572242874b13642b74 Reviewed-on: https://gerrit.libreoffice.org/48359 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-23EPUB export, fixed layout: add chapter names to the navigation documentMiklos Vajna
Extend vcl::PDFExtOutDevData so that it's possible to use it outside the PDF export; this way the EPUB export can know which chapters start on which page. This means fixed and reflowable layout has the same table of contents, instead of just Page <N> in the fixed layout case. Change-Id: I935fb23c66ec747431b91e83b0e677d4e5f704b9 Reviewed-on: https://gerrit.libreoffice.org/48332 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-23More loplugin:cstylecast on WindowsStephan Bergmann
Automatic rewrite (of loplugin:cstylecast and loplugin:unnecessaryparen) after cab0427cadddb3aaf1349c66f2fa13a4234ba4b2 "Enable loplugin:cstylecast for some more cases" and a409d32e7f6fc09e041079d6dbc3c927497adfed "More loplugin:cstylecast" Change-Id: Ib3355159dd08333e1b7a8d091caf2069cdcc7862 Reviewed-on: https://gerrit.libreoffice.org/48317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-22limit the rest of CSS1_PIXLENGTH usersCaolán McNamara
Change-Id: I59487bb337bc8821cb995fd258602ff7fb580d54 Reviewed-on: https://gerrit.libreoffice.org/48311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-22ofz#5561 Integer-overflowCaolán McNamara
Change-Id: I57660848190efff8e6354670eb68b60ed57f0094 Reviewed-on: https://gerrit.libreoffice.org/48308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-22uitest for tdf#108124Zdeněk Crhonek
Change-Id: If500712e1fddc2a65b5c2df1649231ff3b46a45b Reviewed-on: https://gerrit.libreoffice.org/47019 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-22sw: add an assert wrt. recent bug in SwHTMLParser::SplitAttrTab()Michael Stahl
Change-Id: I1fa64beb4724675c2e23bd5d4f0766f6d4cf7873
2018-01-22sw: prefix members of SwDocInfoField, SwDocStatField and SwDocStatFieldTypeMiklos Vajna
Change-Id: I8c6e618266f56148df385eb140668730d9b06ed3 Reviewed-on: https://gerrit.libreoffice.org/48293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-22crashtesting: dodgy aRect is unused anywayCaolán McNamara
assert on conversion fdo66047-1.odt to doc of too large long from Fraction Change-Id: I057eb41791eb3b454192540da5e1f1d099487839 Reviewed-on: https://gerrit.libreoffice.org/48324 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-22StartExecuteAsync doesn't need a second paramNoel Grandin
we can just use this to store a keep-alive reference in AsyncContext Change-Id: I0152aef5386aa9753b48afdfc958790f10d13560 Reviewed-on: https://gerrit.libreoffice.org/48294 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-22tdf#114523 Make inline tooltips for changes optionalheiko tietze
Tooltips on tracked changes are not shown when Show track changes is switched off; additional property introduced at Tools > Option > Writer > Changes to disable the inline tooltip completely Change-Id: I5b54895bb22d167a383b06627c69326c3c2f5b02 Reviewed-on: https://gerrit.libreoffice.org/46971 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-01-22tdf#35301 Modify Asian phonetic guide dialog.Mark Hung
* Add a new ruby position option "Right" in the Asian phonetic guide dialog. * Allow set/get RubyPosition property via XRubySelection interface. Change-Id: I306450ad32f0eff71f284c85e78497a341bc7971 Reviewed-on: https://gerrit.libreoffice.org/48209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-01-22Actually remove the now-unnecessary, bad downcastStephan Bergmann
...after 8aa37ca1b94a340c0ca3dc4edebdc501edc25cf5 "ubsan SwTableBoxFormat is really SwTableLineFormat" Change-Id: I24d092a6cb4d3642e22045acde7eeffaf908075e
2018-01-22C++17 deprecated std::shared_ptr::unique()Michael Stahl
Most of these calls are in assertions, and the ones that aren't should be guarded by SolarMutex, so the thread safety concerns that caused unique() to be deprecated don't look relevant, so use use_count(), which oddly enough isn't deprecated. Change-Id: Ia166615af6c3ce85145c391752669c7461bd35fb Reviewed-on: https://gerrit.libreoffice.org/48222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-22ofz#5535 max decimal places for rtl_math_round is 20Caolán McNamara
Change-Id: I636e086c51ceb70bdac72acfbabe99ad29003cdb Reviewed-on: https://gerrit.libreoffice.org/48268 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-22ubsan SwTableBoxFormat is really SwTableLineFormatCaolán McNamara
/sw/source/core/doc/tblrwcl.cxx:1937:29: runtime error: downcast of address 0x2b328cff7da8 which does not point to an object of type ´SwTableBoxFormat´ 0x2b328cff7da8: note: object is of type ´SwTableLineFormat´ 00 00 00 00 f0 ea dd 46 32 2b 00 00 b8 80 ff 8c 32 2b 00 00 e8 43 f5 00 90 61 00 00 58 79 65 80 ^~~~~~~~~~~~~~~~~~~~~~~ vptr for ´SwTableLineFormat´ #0 0x2b323c386daf in lcl_CopyLineToDoc(FndLine_ const&, CpyPara*) /sw/source/core/doc/tblrwcl.cxx:1937:29 Change-Id: I16f7b61a3561de3e599818aba538c72c631511ca Reviewed-on: https://gerrit.libreoffice.org/48282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-21tdf#113946 add 'topMargin' to GraphicHelpers importPatrick Jaap
The case '...topMargin' was not caught for setting a relative vertical position in GraphicHelpers. The test file demands a '7' here, which stands for 'PAGE_FRAME'. The '7' was overwritten in GraphicImport in case 'LN_CT_Anchor_positionV' by a call of 'resolve'. For a better overview a switch is inserted here. Change-Id: Ie98209fe445ecbba15c3dafe5980ca52421126f8 Reviewed-on: https://gerrit.libreoffice.org/47905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-21Fix typosAndrea Gelmini
Change-Id: Id3e707e89bd0fda4d86e02a185a16336c89e7c82 Reviewed-on: https://gerrit.libreoffice.org/48281 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-21more ScopedVclPtr for dialogsNoel Grandin
Change-Id: I0f19a0c1e312843bee0ee5c9939831918ddc2da7 Reviewed-on: https://gerrit.libreoffice.org/48198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-21tdf#35301 Formatting ruby text on right side.Mark Hung
* BuildMultiPortion(): preserve room for the ruby text by increasing the width of the last portion of the base text. This allows the ruby portion to be selected with the base text so that they seemd like attached to each other. * CalcSize(): we need to be careful because the width and height of the base text line is swapped. * PaintMultiPortion(): render the base text on top of the preserved room mentioned above, by shifting the position back. * SwRubyPortion(): RubyPortion::RIGHT is designed for horizontal writing mode only. In vertical writing mode it fallback to RubyPortion::ABOVE. Change-Id: I5291e32221b6b2fc1c3e152b3a5defe857428163 Reviewed-on: https://gerrit.libreoffice.org/48244 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-01-20Addition of focus_on_click to notebookbar ui filesMaxim Monastirsky
(automatic rewrite) Change-Id: I959b58b3b0b69de9344b0f7188594a19e8b9d4ea Reviewed-on: https://gerrit.libreoffice.org/48176 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-01-20ofz#5253 restore some sort of valid state on missing RestoreCaolán McNamara
Change-Id: Ic12e1567f5a3370d1580d8c471ee38d3069568ce Reviewed-on: https://gerrit.libreoffice.org/48217 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-20loplugin:unusedmethodsNoel Grandin
Change-Id: If00b0e659e1818c29ae39b89f8b4f7ea29d14986 Reviewed-on: https://gerrit.libreoffice.org/48185 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-20tdf#115079: check that row frame belongs to table frame to avoid segfaultJulien Nabet
A row frame may not belong to a table frame, when it is being cut, e.g., in lcl_PostprocessRowsInCells(). Its SwRowFrame::Cut() has been called; it in turn called SwLayoutFrame::Cut(), which nullified row's upper in RemoveFromLayout(), and then called Shrink() for its former upper. Regardless of whether it will be pasted back, or destroyed, currently it's not part of layout, and its height does not count. See bt https://bugs.documentfoundation.org/attachment.cgi?id=139171 Change-Id: I4010e1f246a3ebb89b3f972a03619a2775146da4 Reviewed-on: https://gerrit.libreoffice.org/48089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-19Don't create database files in $HOMEMike Kaganski
Regression from commit 46b3202bf883618f1585850191c19776861013ed Change-Id: If8e0b309274ea14e996e0dde2d1ee9b49ff0f737 Reviewed-on: https://gerrit.libreoffice.org/48173 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-19coverity#1427648 Dereference after null checkCaolán McNamara
Change-Id: Ib4be7b819a5ba68d78d98d8ae05d755898f3cad1 Reviewed-on: https://gerrit.libreoffice.org/48136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-19ofz#5483 Integer-overflowCaolán McNamara
Change-Id: If364a961f5e144cc0f3572108020c99db6febfb8 Reviewed-on: https://gerrit.libreoffice.org/48177 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-19out of date 'define private public' commentCaolán McNamara
Change-Id: I21663a7eef846244f330b3236a2ff1a2efae15bb Reviewed-on: https://gerrit.libreoffice.org/48174 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-19tdf#115088: Pasting multi-line text from external source behaves strangelyTamás Zolnai
Regression from: e68b6e349c31ac1376e90218013e1e7612f2b522 AppendTextNode might be sufficient for import (when there is no content in the document), but for clipboard operations better to use the original SplitNode method. Change-Id: I7de3e9bc9c5356acb0b4cc43927a0d39079522b2 Reviewed-on: https://gerrit.libreoffice.org/48124 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-01-19sw: loplugin:unreffunMichael Stahl
HTMLTable::FixFillerFrameFormat is unused now. Change-Id: Ic09d9585368ead7317325068eabb0171b76b6a9b
2018-01-19inline some definesNoel Grandin
which don't add any value anymore Change-Id: I45977d972d4d02926630b749d3ec736416138cf5
2018-01-19loplugin:unusedmethods also check for functions returning boolNoel Grandin
we were previously excluding them Change-Id: I48a68799b0de60b4995fae541eb363e043d4dd11 Reviewed-on: https://gerrit.libreoffice.org/48167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-19new loplugin:emptyifNoel Grandin
Change-Id: I1092115a0ceb3a5e6680a4b724b129f98a892c42 Reviewed-on: https://gerrit.libreoffice.org/48128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-19sw: remove no longer building ww8toolbar dump codeMiklos Vajna
Such dumper code for other ww8 features is in the separate mso-dumper repo. If it is found really useful later, it can be still restored and fixed up to actually build, though. Change-Id: Id542fef9c0111c8bc88b943e268c9a02f3503d72 Reviewed-on: https://gerrit.libreoffice.org/48161 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-19Remove noopMike Kaganski
IsTableNode() is true when m_pTableCursor is not nullptr. So, GetCursor() is only called when it is nullptr. In turn, GetCursor() only does something if m_pTableCursor is not nullptr. This is so from the beginning (commit 84a3db80 from 2000 already has it). Change-Id: I258129fc1bab0e3e5591702af1158c1ec2579d8d Reviewed-on: https://gerrit.libreoffice.org/48144 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-19sw: HTMLTable::m_pTopTable is always "this"Michael Stahl
Ever since commit cc144e5544a41acdc703f7d243ad1747b0a2b33d fix for i#76959 the pTopTable parameter of HTMLTable was always null. Simplify HTMLTable by removing dead code. Change-Id: Ie13313f54d6ee656e56a209bc29bcc77132de269
2018-01-19pack these without holesCaolán McNamara
Change-Id: Idb5184e141c5a15d4d77268f8d45ee549c6e9a7f Reviewed-on: https://gerrit.libreoffice.org/47714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-19...and anotherStephan Bergmann
Change-Id: I06aa51f0f46f3708540ebb218387cb028b9e65d3
2018-01-19Blind fix for sal_Int32 = longStephan Bergmann
...after 252ce90e39648c47bcfdb39547d0ac82bacdbae6 "sw lokit: add page syles to header & footer" Change-Id: Ia0b3f8194d889fc1022da08bac06c85cbb22dd3b
2018-01-19SAL_W32 is just an alias for _WIN32Stephan Bergmann
...so consistently use the latter instead of the former Change-Id: I144d5e7c472632f93b2258461510346bc85892d9 Reviewed-on: https://gerrit.libreoffice.org/48135 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-19tdf#115065: nullptr dereferenceMike Kaganski
Change-Id: Iafaaafdabf9fb7947fa0b03cd38d3b4a567a41b9 Reviewed-on: https://gerrit.libreoffice.org/48110 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-18sw lokit: add page syles to header & footerHenry Castro
Change-Id: I3c0b0603d1e03f1cc19af4324dd2b909320d9d4a Reviewed-on: https://gerrit.libreoffice.org/47687 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2018-01-18ofz#4754 sw: HTML import: fix invalid tables being createdMichael Stahl
This 75-byte horror creates 2 nested tables, where one SwTableBox is in the SwTableLine of the inner SwTable but in the SwSortBoxes of the outer table, which is of course invalid. The root cause is that in SwHTMLParser::SplitAttrTab(), we move the m_pPam backward once and forward twice, moving it ouside the inner table. Change-Id: I63f6508afe1270ccdeb05da6f222b0aba5259889
2018-01-18Fix typosAndrea Gelmini
Change-Id: I633e4921042809c628e55825b70c540767eba1d3 Reviewed-on: https://gerrit.libreoffice.org/48140 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-18lokdialog: Convert the Format -> Page... dialog to async exec.Jan Holesovsky
This actually also converts the Style -> Edit Style... at the same time. Change-Id: I4c09fcdfd7a543cce613eaa3620d0b623540d7e8 Reviewed-on: https://gerrit.libreoffice.org/48043 Tested-by: Jan Holesovsky <kendy@collabora.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-01-18sw: Cleanup various unused return values.Jan Holesovsky
Change-Id: Ic0e0c6cfd4b6d79f7c3807ac4300f30343269dea Reviewed-on: https://gerrit.libreoffice.org/48042 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-01-18tdf#76817 ooxmlexport: only use stylename for Outline listJustin Luth
In LibreOffice, the special, built-in, Outline numbering style ("Chapter Numbering") is connected via the paragraph style to control the numbering. Thus, only the ParaStyleName should be written to the paragraph properties, and not the direct numbering properties. Both MSO and LO get confused when there are multiple definitions for outline numbering. Change-Id: I1af54fdea164d68e5e156c256b478e518daa5e99 Reviewed-on: https://gerrit.libreoffice.org/47828 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-18Fix typosAndrea Gelmini
Change-Id: I7aa101a5e1e47118ab94527eb37269dd7e544cf4 Reviewed-on: https://gerrit.libreoffice.org/48093 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-18sw: Actually only .uno:StyleApply and .uno:StyleWatercanMode can return...Jan Holesovsky
...a value, at least according to sfx2/sdi/sfx.sdi. Change-Id: I1a12c025386cfc6eae529782cdb69207ffa388c5 Reviewed-on: https://gerrit.libreoffice.org/48041 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-08-03 06:22:15 +0000