summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2017-04-25Optimize plain-text import.Michael Meeks
Cost of managing rsids is very significant >50% of import time, new Rsids will be generated for changes anyway. Also avoid un-necessary splitting of paragraphs on new-line. Change-Id: Ib959306f187f93bd3a85ead11fd2342b99d4ece3 Reviewed-on: https://gerrit.libreoffice.org/36938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-04-25tdf#39468 Translate German commentsAlexey Vlasov
Change-Id: I94e53a5a375422c1865e881a29d5b080f844524b Reviewed-on: https://gerrit.libreoffice.org/36493 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-04-25tdf#39468 Translate German comments sw/source/core/text/txthyph.cxxAlexey Vlasov
Change-Id: I2c818def66dcb04fabbffeb4c2ef1bdd1d2aa055 Reviewed-on: https://gerrit.libreoffice.org/36488 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-25FOOTERL and FOOTERR are write-onlyNoel Grandin
Change-Id: I65ed01d0bf10409282d9fe5087f5ea84cb084ddc Reviewed-on: https://gerrit.libreoffice.org/36932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25tdf#106035 update the contextual groupedbar full layout updateandreas kainz
Change-Id: Ic7956e11ebe2edd8e1046c4695f92b3398036c2f Reviewed-on: https://gerrit.libreoffice.org/36865 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-04-25tdf#107104 DOCX drawingML import: fix invisible arrow shapeMiklos Vajna
This is the drawingML equivalent of commit 3d9ebded1358395ed81db7a63629b046aec2aeac (Misc improvements for docx VML import, 2010-10-06), which made sure that shapes are never invisible just because they have zero height or width. For this particular bugdoc the Word-produced WW8 equivalent width is 20 twips, but let's be consistent with the VML import and just round up to 1 mm100. Also fix two existing tests that wanted to test something else, but implicitly asserted that some shapes indeed have zero width/height. Change-Id: I9600424520d0a3deecc711b44622eccc041a59da Reviewed-on: https://gerrit.libreoffice.org/36927 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-25errinf.hxx moved out of tools and into vcl moduleChris Sherlock
ErrorInfo has a hard depency on VCL, yet is in the tools package. It is more appropriate to have it reside in the VCL module. Change-Id: Ica54a46c3a7f86cf0331ed7245234bea69c05650 Reviewed-on: https://gerrit.libreoffice.org/36839 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25make __RSC a builtin define for the RSC compilerNoel Grandin
instead of randomly defining it in only some of .src files Change-Id: Ifec3920740723d248400f451d717b5288c421b8d Reviewed-on: https://gerrit.libreoffice.org/36832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25loplugin:checkunusedparams in vclNoel Grandin
Change-Id: I26661684e634aa15a18f78442de15c9db832f319 Reviewed-on: https://gerrit.libreoffice.org/36886 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25remove DYING_FLYFRAMEFORMAT: now obsoleteBjoern Michaelsen
Change-Id: If82cdcb184069058209e1b23a50b699433dcdfe7 Reviewed-on: https://gerrit.libreoffice.org/36898 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2017-04-25use a unique_ptr to track the SwFlyDrawContactBjoern Michaelsen
Change-Id: I1b9058b41d1708efa4069e737c2247c6600403f5 Reviewed-on: https://gerrit.libreoffice.org/36897 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2017-04-24tdf#39468 Translate German comments in swJens Carl
Translate German comments and terms in: sw/source/filter/html/htmltab.cxx sw/source/filter/html/swcss1.hxx Change-Id: I6986461f5df342ec9be6a19fc358150ab42dee36 Reviewed-on: https://gerrit.libreoffice.org/36573 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-04-24tdf#39468 Translate German comments in swJens Carl
Translate German comments and terms in sw/ Change-Id: Ib98bf6977e60b69ec1afa6bfdd00bab3d124946a Reviewed-on: https://gerrit.libreoffice.org/36560 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-04-24tdf#39468 Translate German comments in swJens Carl
Translate German comments and terms in sw Change-Id: Ia74a75ae28b1e5ed855dcd9e6e09b9fd53e98450 Reviewed-on: https://gerrit.libreoffice.org/36558 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-04-24move SwFlyDrawContact ownership to SwFlyFrameFormatBjoern Michaelsen
Change-Id: I19a65638c7489f74cc7ae5fc08364a103551cd1a Reviewed-on: https://gerrit.libreoffice.org/36878 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2017-04-24tdf107359: imporve line pitch and char pitch importing of writerfilter.Mark Hung
1. Use converted style name to assure the default style is found. 2. Switch off squared-page mode before setting the base text width and height. 3. Ruby text height is not effective per ODF spec. Change-Id: I0f2901a453a9f7b344cac6989780688cc2d6c7b4 Reviewed-on: https://gerrit.libreoffice.org/36828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2017-04-24coverity#1405474 Unintended sign extensionCaolán McNamara
and coverity#1405473 Unintended sign extension coverity#1405472 Unintended sign extension coverity#1405471 Unintended sign extension Change-Id: I1db183206cb03167d0dd13b2a3470caa3ea1cb4e
2017-04-24tdf#39468 Translate German comments in swJens Carl
Translate German comments and terms in: sw/source/filter/html/htmldrawwriter.cxx Change-Id: Ifce35a21033884cf1dbceb2af984d09034bf692b Reviewed-on: https://gerrit.libreoffice.org/36574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-24Fix typosAndrea Gelmini
Change-Id: I3e130b68c18ebe24c072d317d59b4854608a222f Reviewed-on: https://gerrit.libreoffice.org/36870 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-24sw: let's check GetFrame() instead, it's already publicMichael Stahl
Change-Id: I0dc25c519a8c9d658acd80372c41be0ee22c6d8b
2017-04-24sw: prefix members of SwMultiTOXTabDialogMiklos Vajna
Change-Id: Ib600741892e6e09d6af9156b105718de665a97da Reviewed-on: https://gerrit.libreoffice.org/36879 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-24clang-tidy readability-simplify-boolean-expr in swNoel Grandin
Change-Id: Ib3ec37b8280c527fa712192db043b348c3427c50 Reviewed-on: https://gerrit.libreoffice.org/36877 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-24Indentation fixesMiklos Vajna
No functional changes intended. Change-Id: Ibc23de9cb33428765b8b0c85a221a2014ad4d7bd
2017-04-24move SwDrawFlyContract creation into CreateNewRefBjoern Michaelsen
Change-Id: Ied86e1fd9424fc28e95215e60bed95069b7b51a6 Reviewed-on: https://gerrit.libreoffice.org/36869 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2017-04-23Replace GetImage with CommandInfoProvider::GetImageForCommandMaxim Monastirsky
And move ToolBoxButtonSize->ImageType mapping code to a common place. Change-Id: If158f4b6f2750054fcf64491c2941706e7d3a329
2017-04-23tdf#95845 Use CommandInfoProviderMaxim Monastirsky
And a few unused theUICommandDescription includes. Change-Id: Ic80dbfb91e5e7662723efe0cb4090416994adabd
2017-04-23merge comphelper::ChainablePropertySet with comphelper::ChainableHelperNoStateNoel Grandin
Change-Id: I8fb93665b2a2f46019306f473882a7f3d7aece87 Reviewed-on: https://gerrit.libreoffice.org/36787 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-23tdf#104610 Always enabled no-width break formatting marksYousuf Philips
Change-Id: I0708a61d43bfa44dac19683b200975e3a6da788a Reviewed-on: https://gerrit.libreoffice.org/36807 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-04-23AutoText: importing docx contentSzymon Kłos
- passing "ReadGlossaries" flag to the WriterFilter - if set - WriterFilter reads glossary document instead of the main content - updated model.xml to read docParts and docPart nodes - SwDOCXReader adds document content as an AutoText entry Change-Id: I9a0cc91c793d6accc8461e1c3aca791c5997d497 Reviewed-on: https://gerrit.libreoffice.org/36753 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2017-04-23tdf#107301: Improve non snap-to-char text rendering.Mark Hung
DrawText ingnores calculated KernArray so the text is cluttered, use DrawTextArray instead of DrawText. Change-Id: I9f7294cd6540257034ac7fcffdaff5b4f2529d8f Reviewed-on: https://gerrit.libreoffice.org/36751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2017-04-22fix the buildMarkus Mohrhard
Change-Id: Icb33610ba7923f86e48f3173b16fc7f0abd05344
2017-04-22tdf#107237 Add shape and frame contextual tabs to WriterYousuf Philips
Add contextual tabs to the tabbed Notebookbar implementation Change-Id: I24062aa2bb36d7ec2f47c97850cb2d48c3745fcd Reviewed-on: https://gerrit.libreoffice.org/36630 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-04-22tdf#102132 Contextual section in its own sectionYousuf Philips
Change-Id: I40a956075181a0692e0635090b314f4a4f09fbb5 Reviewed-on: https://gerrit.libreoffice.org/36811 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-04-22sw: skip part of uiwriter/testTdf107025 if not testable.Mark Hung
The unit test is about textgrid and uses DFKAI-SB that shipped with Windows. Required font might not installed in some build environment. Not having width in the first implies that the case is not testable. Change-Id: I98f9b9f6291eea95a1b36f1890b1be903ccb26dd Reviewed-on: https://gerrit.libreoffice.org/36802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2017-04-22sw: fix a11y crash on double DisposeMichael Stahl
When testing with the bugdoc for tdf#107126, it happend that upon applying a page style, SwAccessibleContext::Dispose() was called twice, and that's not supposed to happen (and crashes, too, at least inside an assertion). There was an Action that queued up a bunch of events, but the Action did not complete formatting the document, so right after that during Paint more formatting happened and then the FireEvents() called Dispose() and InvalidatePosOrSize() called it again. Guess we shouldn't generate events for objects that we know are disposed due to not being visible. Change-Id: I5a0f04c0f32ee5e949b552f7a373c10ceee5c279
2017-04-22tdf#107126 sw: fix layout crash with section in footnoteMichael Stahl
SwContentFrame::WouldFit_() contains a hack to temporarily reparent a SwTextFrame. In the bugdoc, there is a SwTextFrame below a SwSectionFrame below a SwFootnoteFrame. The reparenting ignores the SwSectionFrame so the result is a SwTextFrame below SwFootnoteFrame, but it still has its mbInfSct set, hence crashes with a null pointer. If the SwTextFrame is permanently moved later on, in SwFlowFrame::MoveBwd() line 2450 a new SwSectionFrame is created. Change-Id: I45a7ab793b4459e551bd11b7fb83dedc58a6c8da
2017-04-21Silence loplugin:unreffun on "FIXME breaks on Windows"Stephan Bergmann
Change-Id: I9b03f56d8d1b45648f9d71fe1e8632fe58079c4f
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-21Disable this test temporarily, breaks on Windows from some reason.Jan Holesovsky
Change-Id: I47998d5844901b8090cd47f55a49c872550e2e38
2017-04-21Avoid un-necessary dynamic_cast slowing plain-text import significantly.Michael Meeks
Change-Id: I5f3ff80b36220c80e777946f5f75354c4b6e4ab9 Reviewed-on: https://gerrit.libreoffice.org/36789 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-04-21ofz#1202 fix oomCaolán McNamara
Change-Id: I9b7b318af112fb9226bf8d2b54ea2a306eee4251
2017-04-21related tdf#68604: Unit test for writing the plaintext annotations in DOCX.Jan Holesovsky
Change-Id: I8c747e72ca96ffd097c92326210c39740102ec79
2017-04-21related tdf#68604: Write the plaintext version of the annotation...Jan Holesovsky
...if the TextObject is not available. This is perfectly valid situation in the case when the SwPostItField was created via the .uno:InsertAnnotation API. Change-Id: I3ae2a529ba7cc13cf5b04d57aa299d79e2044f37
2017-04-21tdf#107211 sw: ODF import: add a horrible hack to import "Default"Michael Stahl
... character style for hyperlinks and index-entry-templates. The problem is that the "Default" character style doesn't actually exist, it is just displayed in the UI so you can remove a character style that is set. So for the most part there is no need to store "Default" in ODF files, except that for hyperlinks the default isn't "Default" but "Internet Link"/"Visited Internet Link". Hence it was not really a good idea to rename "Default" to "Default Style", because when importing existing documents the text:style-name="Default" is not found, and for new documents text:style-name="Default_20_Style" is not found either because there is no style:style element that sets up the mapping between the encoded style-name and the unencoded display-style-name. Add some hack in SwXMLBodyContext_Impl::SwXMLBodyContext_Impl(), when all style:style elements have been read (so we don't override what's in the document) to create the mapping for "Default", "Default_20_Style" and whatever the translation of that is. (regression from 783d13a9276931e274a90b9b53de2c92dc8c055e) Change-Id: I8a80847571f194204c5df267cb48e826a82328b2
2017-04-21add CVE-2017-0199 testcaseCaolán McNamara
Change-Id: I07cac2ffac85093761dbdd7c50c52483bfbb5754
2017-04-21convert HTML_OPTION_IDS to scoped enumNoel Grandin
Change-Id: Ia766dc58a571e5853005fd394283d7b53f02e4a6 Reviewed-on: https://gerrit.libreoffice.org/36748 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21pass RndStdIds around instead of sal_uInt16Noel Grandin
Change-Id: I28c85b8a5370faa06043ad93412897778ed1a619 Reviewed-on: https://gerrit.libreoffice.org/36731 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21remove unnecessary explicit linefeeds from end of SAL and OSL log callsNoel Grandin
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf Reviewed-on: https://gerrit.libreoffice.org/36727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21remove some old MSVC workaroundsNoel Grandin
Change-Id: I6abd8aaffb27b3c85df7c0518f7f576be4e32222 Reviewed-on: https://gerrit.libreoffice.org/36660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>