Age | Commit message (Collapse) | Author |
|
Change-Id: I30e673fc5741c37e3064e2b2035d772b43364d06
Reviewed-on: https://gerrit.libreoffice.org/39022
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Translate the last remnants found by ./bin/find-german-comments sw
Change-Id: I0618671b8794e05a51eeff811746a1154359d0fe
Reviewed-on: https://gerrit.libreoffice.org/39028
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I3cfc777be4b717bee7fd4559ca79fb9ba6626a51
Reviewed-on: https://gerrit.libreoffice.org/39027
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
and fix a memory leak in NotebookbarTabControl where it was not freeing
it's m_pListener field
Change-Id: Ib9970c9084982d532fa38d1bc3c44180ab2c3c39
Reviewed-on: https://gerrit.libreoffice.org/39036
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ic8f67d40825d9843fd57535bd61bef51b470a8be
Reviewed-on: https://gerrit.libreoffice.org/39016
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ie9fd55b71a152f428a397d9917918f0e9de39aaf
Reviewed-on: https://gerrit.libreoffice.org/39014
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
after commit 528632660b72b105345945c13c5b68060d94a91b
"convert ErrCode to strong typedef"
Change-Id: I31727d89f6450e5d1d0930abf7dba7a32f8b894a
|
|
In MSWord, Footnote Reference applies to both in-text and in-footnote
formating of the reference number, while LO uses two.
Convert into one style, and copy into the other style.
Change-Id: I8cf731d5d1236c86fc1c82e798d8a459ca95d0ba
Reviewed-on: https://gerrit.libreoffice.org/38374
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Goal of this testcase is just to ensure that some table cell borders
exist while some others do not. There is no reason to do exact width
comparison which is causing errors on some MacOS configurations.
Change-Id: I574c29220696ae654dea2db0398790a440efd83b
Reviewed-on: https://gerrit.libreoffice.org/39015
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: I6621e0dda5a5dc3e68c7b1613975c075e2879912
Reviewed-on: https://gerrit.libreoffice.org/39006
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
would have preferred to re-use o3tl::strong_int, of which this
is a modified copy, but there are lots of convenience accessors
which are nice to define on the class.
Change-Id: I301b807aaf02fbced3bf75de1e1692cde6c0340a
Reviewed-on: https://gerrit.libreoffice.org/38497
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I2f76f179fb3ef251be16e60bf64f2b6d701bfd35
Reviewed-on: https://gerrit.libreoffice.org/39004
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Eleventh and final set of translations.
Change-Id: I62876e2b05ddc4879951bd2788e9eb1087b59b19
Reviewed-on: https://gerrit.libreoffice.org/39003
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
And if we're at it, test the other way around as well, I almost broke
it.
Change-Id: Ia81e46f218336e5db13dafdbad7b896d8dadaf46
Reviewed-on: https://gerrit.libreoffice.org/38999
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
so they're closer to radio buttons than checkboxes
though this isn't great either as there are possibilites that are not listed,
in which case all are unchecked, and when is selected like buletting it cannot
be turned off from the menu
Change-Id: Ifa9650cdde5575807c0bd876e859c3ba3748e580
|
|
Change-Id: I9325a02293a221fe63f8936da1e056dce42265e7
|
|
Some paragraph-level run properties affect the current list style since
commit 2123ede032ca64f696ef54af4ad3238974ca2b5d (n#758883 dmapper:
paragraph-level run props should affect numberings as well, 2012-06-19).
This was extended for any run properties in case of RTF since commit
c1f8437dbed0e8b989e41a345ef7e658a6e8a4cd (fdo#83465 RTF import: handle
font of numbering, 2014-09-25), as RTF doesn't really separate the
paragraph-level and the other run properties.
However, field formatting clearly should affect only the field itself,
so disable this mechanism in that context.
Change-Id: I6df7488e99e44f3ba7e17bf09ce590c88151e043
Reviewed-on: https://gerrit.libreoffice.org/38980
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: Iddbe19638796564f5d443f6376b95ad7d69ecf0e
Reviewed-on: https://gerrit.libreoffice.org/38989
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
|
|
Change-Id: I747562462accc49e7f3dc851e1ebb274e36b93d7
Reviewed-on: https://gerrit.libreoffice.org/38988
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
|
|
Tables-in-sections were already split across multiple pages, but not
secions-in-tables. To be safe still don't allow
sections-in-tables-in-sections, so you can combine these in both orders
now, but not recursively.
To achieve this, relax two "not in table" conditions to just require
"not in a table that is already in a section", and define that in case a
section-in-table is to be split, the follow section frame should be
inserted under the follow of its cell.
With this, finally the section frame in the bugdoc is split into two,
and the second section frame is moved to the second page as expected.
Change-Id: I16ebb2d30870b145a2378d46603324ab267b0dd3
Reviewed-on: https://gerrit.libreoffice.org/38965
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Add tests:
- test_meta
- test_meta_empty
- test_meta_field
- test_meta_field_empty
- test_bookmark1
- test_bookmark2
- test_refmark2
- test_refmark3
- test_toxmark2
- test_toxmark3
Change-Id part 1: I0920517b5e8806a5fc46708822fed33006f03fd5
Change-Id: If8e50aa036f10caf1b460c041dd7bce068f9cd7b
Reviewed-on: https://gerrit.libreoffice.org/38842
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: I5c2ead67465c79fa30fc7d7db9d48748bdaf5491
Reviewed-on: https://gerrit.libreoffice.org/38961
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
|
|
Change-Id: Ib9769706e4f66a1ecae49869565e84091cd2279a
Reviewed-on: https://gerrit.libreoffice.org/38945
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: I8daa6c2c5941a894259a5af74a16f7ef32f8a867
Reviewed-on: https://gerrit.libreoffice.org/38577
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
|
|
Change-Id: I2bcbf84dff8a5f6a2311cd0b1f19e90c03e6175c
|
|
...with the aid of an extended compilerplugins/clang/store/sfxitemsetrewrite.cxx
(which in turn needed a small addition to compilerplugins/clang/check.hxx).
Enable svl::detail::validGap check for the static case, but keep it disabled for
now for the dynamic case.
Change-Id: I4846ba8e99aff94a86518e2cb5044e575093386e
|
|
And switch to a non-deprecated alignment property
Change-Id: I74b3d6bea1d7af09b8e044f7b3e25e906bf67c9b
|
|
When Watermark size is set to Auto in the MSO,
the saved value is equal 1pt. Before this patch
in this case Watermark was invisible due to small size.
Change-Id: Ia2028a6547cf98dd31031305bcc5375625b83fe0
Reviewed-on: https://gerrit.libreoffice.org/38883
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: If6927f3b9e983d41ec957997a26d235b8be378a5
Reviewed-on: https://gerrit.libreoffice.org/38934
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Ib352e8cfac2e01b17dc22776cb45b5ba81e5875a
Reviewed-on: https://gerrit.libreoffice.org/38912
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: If28e198b8e1a26660e07dce49db66a651de43d3f
Reviewed-on: https://gerrit.libreoffice.org/38850
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb
Reviewed-on: https://gerrit.libreoffice.org/38905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
|
|
Change-Id: I51b44a49eb05da0bf89ae2db7b5f2d4647c3ee87
|
|
A very basic implementation of the proposed std::array_view, similar to
clang's llvm::ArrayRef.
Mostly cribbed from the string_view implementation :-)
Use it for the SfxDispatcher::setSlotFilter function
Change-Id: Ife7e4971741b41827e145787899872c9b2bea82b
Reviewed-on: https://gerrit.libreoffice.org/38817
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
which means that SfxObjectShell::GetMiscStatus becomes unused
Change-Id: I5c89a2cd5c77c7f08a57fdac08237aab514fc7fa
Reviewed-on: https://gerrit.libreoffice.org/38843
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This is a follow-up to 45a7f5b62d0b1b21763c1c94255ef2309ea4280b "Keep WID ranges
sorted, and join adjacent ones". While SfxItemSet::MergeRange relies on the
m_pWhichRanges being sorted (and, under DBG_UTIL, asserts if they are not), the
various SfxItemSet constructors curiously only check (via assert or DBG_ASSERT)
that each individual range has an upper bound not smaller than its lower bound.
Arguably, all SfxItemSet instances should fulfill the stronger guarantees
required and checked by MergeRange.
And in many cases the ranges are statically known, so that the checking can
happen at compile time. Therefore, replace the two SfxItemSet ctors taking
explicit ranges with two other ctors that actually do proper checking. The
(templated) overload taking an svl::Items struct should be used in all cases
where the range values are statically known at compile time, while the overload
taking a std::initializer_list<Pair> is for the remaining cases (that can only
do runtime checking via assert). Most of those latter cases are simple cases
with a single range covering a single item, but a few are more complex.
(At least some of the uses of the existing SfxItemSet overload taking a
const sal_uInt16* pWhichPairTable
can probably also be strengthened, but that is left for another day.)
This commit is the first in a series of two. Apart from the manual changes to
compilerplugins/clang/store/sfxitemsetrewrite.cxx, include/svl/itemset.hxx, and
svl/source/items/itemset.cxx, it only consists of automatic rewriting of the
relevant SfxItemSet ctor calls (plus a few required manual fixes, see next).
But it does not yet check that the individual ranges are properly sorted (see
the TODO in svl::detail::validGap). That check will be enabled, and the ensuing
manual fixes will be made in a follow-up commit, to reduce the likelyhood of
accidents.
There were three cases of necessary manual intervention:
* sw/source/core/unocore/unostyle.cxx uses eAtr of enum type RES_FRMATR in
braced-init-list syntax now, so needs explicit narrowing conversion to
sal_uInt16.
* In sw/source/uibase/uiview/formatclipboard.cxx, the trailiing comma in the
definition of macro FORMAT_PAINTBRUSH_FRAME_IDS needed to be removed manually.
* In svx/source/svdraw/svdoashp.cxx, svx/source/svdraw/svdotext.cxx,
sw/source/uibase/app/docstyle.cxx, sw/source/uibase/shells/frmsh.cxx,
sw/source/uibase/shells/grfsh.cxx, and sw/source/uibase/shells/textsh1.cxx,
some comments had to be put back (see "TODO: the replaced range can contain
relevant comments" in compilerplugins/clang/store/sfxitemsetrewrite.cxx).
A few uses of the variadic form erroneously used nullptr instead of 0 for
termination. But this should have been harmless even if promoted std::nullptr_t
is larger than promoted sal_uInt16, assuming that the part of the nullptr value
that was interpreted as sal_uInt16/promoted int was all-zero bits. Similarly,
some uses made the harmless error of using 0L instead of 0.
Change-Id: I2afea97282803cb311b9321a99bb627520ef5e35
Reviewed-on: https://gerrit.libreoffice.org/38861
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Only font name switch (f) is implemented.
Change-Id: I09df8230dff3cf0619065da69bfaf3caad0a39ae
Reviewed-on: https://gerrit.libreoffice.org/38654
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Hung <marklh9@gmail.com>
|
|
Change-Id: Ie5669bd75d9b4be047d98402cb69ac313ab618df
Reviewed-on: https://gerrit.libreoffice.org/38787
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
The intention here is to deny the move of a frame that's inside a table
inside a section. But the code also checked if there a column frame
in-between, so it allowed the move for a frame in a section with 2 cols,
but not without columns (which does not sound intentional, since that's
a simpler case). So drop the requirement to have a column frame between
the argument and the section frame, just check that there is no table
frame in between.
This is needed, but not enough to split the section in the bugdoc (but
at least now the content of the section is marked as movable).
Change-Id: I9155b291a19c692efc30f01f8e206fac5f1ccf81
Reviewed-on: https://gerrit.libreoffice.org/38858
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: Idc601e9ca4ac3ea429d3b514ad6af4198954ca33
Reviewed-on: https://gerrit.libreoffice.org/38859
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: Icd115383970d351ed8b224bbbd18e98ae0cc8f0d
|
|
Change-Id: Ia2596e11f303edf5e1b81ab90062fd93df42159b
Reviewed-on: https://gerrit.libreoffice.org/38847
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: I0af54a66679e66d7d2d05aba5dd341a9126ce631
|
|
We used to not even attempt to split a row that contains sections. Relax
this condition and try to split the row in case the table itself is not
in a section (to avoid recursion) and the section has no columns.
This is needed, but not enough to split the section in the bugdoc.
Change-Id: I6ad0d6eb18611f108ae29e4feea7101ffe552c48
Reviewed-on: https://gerrit.libreoffice.org/38824
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: Iea1f82e95c37bdf778941a568d61f17f179f838d
Reviewed-on: https://gerrit.libreoffice.org/38795
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
...at least ever since 7b0b5cdfeed656b279bc32cd929630d5fc25878b "initial import"
Change-Id: I16b02bd3bfd687b0e451840cd53d93866e9c0f0e
Reviewed-on: https://gerrit.libreoffice.org/38816
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...at least ever since 7b0b5cdfeed656b279bc32cd929630d5fc25878b "initial import"
Change-Id: I66f937ec5d465340a49fa63174b941d7bbf2f439
Reviewed-on: https://gerrit.libreoffice.org/38826
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: I488ee070ab781011e357db6858188d2b706cb348
|
|
Change-Id: Ifd730a0f162ab5032665926d66debe716b0579df
|
|
Change-Id: I544aaadb6809204a0ab8864367fc9f267a5327c6
Reviewed-on: https://gerrit.libreoffice.org/38812
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|