summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2018-12-07tdf#114163 Chart: fix order of legend namesBalazs Varga
Respecting the axis direction in case of normal/stacked/percent stacked Bar chart and the legend names will be in the right order. Change-Id: If782393a33e48dae32f919d137e1d1148a85b0b0 Reviewed-on: https://gerrit.libreoffice.org/64632 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-12-07lok: Insert shapes directly into the document.Mike Kaganski
Change-Id: I182aa395ce0f4e4185c9c85a866dec89499842f9
2018-12-07add parameter TransformRotationDeltaAngle to .uno:TransformDialogHenry Castro
Change-Id: Ib22ba6956afedf1eea055e0ac3a78c53b4ee5861
2018-12-07remove unused ConfigItemMode::DelayedUpdateNoel Grandin
unused ever since commit c1758889cbd5e8e4afb1044425c908715eb3e1cd Date: Fri Nov 11 22:48:37 2011 +0100 Heavily simplified utl::ConfigManager. and rename ConfigItemMode::ImmediateUpdate to NONE, since it doesn't mean that anymore Change-Id: Ia1d06142a25c9eea0f1d30b70653eed325a21b37 Reviewed-on: https://gerrit.libreoffice.org/64719 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-07adapt to the change from sal_Int32 to TextFrameIndexhimajin100000
see commit 2136dc24 and commit e721f958 Change-Id: I07ace74f93adc2568003314b5f05c41611d6f77c Reviewed-on: https://gerrit.libreoffice.org/64671 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-07remove unused SvxNumRuleFlags::CHAR_TEXT_DISTANCENoel Grandin
which is dead as far back as its introduction in commit fd069bee7e57ad529c3c0974559fd2d84ec3151a Date: Mon Sep 18 16:07:07 2000 +0000 initial import Change-Id: Ieff923732005aaa48cfae4918e8094020e6a540b Reviewed-on: https://gerrit.libreoffice.org/64715 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-07loplugin:singlevalfields extend to all static varsNoel Grandin
Change-Id: Ic238bb5291539fd1b7e98cb4afc9b25f37e7d528 Reviewed-on: https://gerrit.libreoffice.org/64710 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-07tdf#121606: displaying Mail Merge toolbar shouldn't activate connectionMike Kaganski
At least I think so. Thus now the code that queries the state of the toolbar controls only queries dataset if connection is active. Operating the navigation buttons (next/prev) will, naturally, activate connection if not yet active. This should also enable the other controls that may be initially disabled: create/save/print/email documents. Thus, the navigation controls also check if they have activated the connection, and invalidate said document creation controls state. Possibly there's a better place for the invalidation of the controls, but I was unable to find one. Regression after commit 5c2c5ff01c23e4f7a8947746afc13a46cbef5bec Change-Id: I76f895c871718c9c761339ba03963baf6837b592 Reviewed-on: https://gerrit.libreoffice.org/64738 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-06remove extra padding in action areaCaolán McNamara
Change-Id: Id3b338278e6d47b90268f0bdc77f1bdaa495edb8 Reviewed-on: https://gerrit.libreoffice.org/64723 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-06Resolves: tdf#114144 let double click advance to next if 'next' existsCaolán McNamara
Change-Id: Id05ad8b72e0ec4f9bad2a9cfb780a44a27618d37 Reviewed-on: https://gerrit.libreoffice.org/64700 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-06uitest for bug tdf#119462Zdeněk Crhonek
Change-Id: I87e601b8a68bfcfee700299526e2b899427e56f1 Reviewed-on: https://gerrit.libreoffice.org/64652 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-05tdf#121561: sw: DOCX: add std/stdPr/stdContent around TOCSerge Krot
During export into DOCX from ODT we need to do it because in this case the TOC title will be recognized inside MS Word as part of the TOC. Later we could add support of these keywords in LO import in order to detect TOC title from DOCX input. Added unit test for export. Change-Id: I7135e91dc04d4c0501e6074a046fc473e041f014 Reviewed-on: https://gerrit.libreoffice.org/63786 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-12-05loplugin:singlevalfields in swNoel Grandin
Change-Id: I39a786155e25888fa9e719e22d2b0c4a70a5ce58 Reviewed-on: https://gerrit.libreoffice.org/64598 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05sw RtfExport: make members privateMiklos Vajna
Change-Id: I6f5b46e3eaf0201368944918fcb8f431be841238 Reviewed-on: https://gerrit.libreoffice.org/64577 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-05Removed executable permission on docx fileAndrea Gelmini
Change-Id: I7738c8048a3dee4788b89826d69b35d62ce79417 Reviewed-on: https://gerrit.libreoffice.org/64356 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-05tdf#105413 track changes: keep paragraph stylesLászló Németh
applied in Show Changes mode, instead of losing them after saving the document or hiding the changes. The bug occured in paragraphs with directly preceding tracked deletions. Change-Id: I9a5fd1b82cb7e99884d8807d0abee1fea59d5df3 Reviewed-on: https://gerrit.libreoffice.org/64518 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2018-12-05remove unused SfxCallMode enum valueNoel Grandin
Change-Id: Ie092724ac22088d607f6250fbed764269b3707ba Reviewed-on: https://gerrit.libreoffice.org/64571 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05remove unused SvLockBytesStatFlag enumNoel Grandin
Change-Id: I90b82f1bbf4b51fc76cde10ec55448053345018c Reviewed-on: https://gerrit.libreoffice.org/64561 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05remove unused GraphicManagerDrawFlags enumNoel Grandin
Change-Id: I12ef5e6257db337c4432b251bc92107a2c2ea88b Reviewed-on: https://gerrit.libreoffice.org/64557 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05use unique_ptr in ww8 export codeNoel Grandin
Change-Id: I505c8005aebec40b8e812aea10deaf79eb7223ab Reviewed-on: https://gerrit.libreoffice.org/64523 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05use unique_ptr in SwModuleNoel Grandin
Change-Id: I6c17853cc84365cb86b3dd2525ab8f2ff7844369 Reviewed-on: https://gerrit.libreoffice.org/64516 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05loplugin:unnecessaryparen include more assignmentsNoel Grandin
Change-Id: I9fb8366634b31230b732dd38a98f800075529714 Reviewed-on: https://gerrit.libreoffice.org/64510 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-04Translate German variable namesJohnny_M
Change-Id: Ibaf473a2146fd925b4d8e8ffdbb6f214844a18cc Reviewed-on: https://gerrit.libreoffice.org/64424 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-12-04sw: fix paragraph enumeration going past selection endMiklos Vajna
SwCursor::MovePara() may move the uno cursor past the end of the selection range, check for this explicitly. In practice this makes sure that in case a 1-paragraph cell text is selected, we never jump to the next cell for a selection created from the previous cell. Change-Id: Ibe2d00cfa75ed0c32b9c89d86cfae3b51d70ddc6 Reviewed-on: https://gerrit.libreoffice.org/64509 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2018-12-04Translate German variable namesJohnny_M
Change-Id: Ie287f9122d4ac362b533cb9270e60337c4985113 Reviewed-on: https://gerrit.libreoffice.org/64423 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2018-12-04NB: update writer groupedbar_fullandreas kainz
Change-Id: I4fffde4c7ee687af1eb1c7f5eb28be16bb369e28 Reviewed-on: https://gerrit.libreoffice.org/64386 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-04weld OfaAutoCorrDlgCaolán McNamara
Change-Id: Iba217a2998de57bf963872f9b8c1cf38694eb935 Reviewed-on: https://gerrit.libreoffice.org/64476 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-04tdf#121664 DOCX import: fix lack of line numbering reset on page breakMiklos Vajna
Regression from commit d620629521aee48dc820b6970ca446c329d0b09a (Use constants for ST_LineNumberRestart values, 2014-10-01) where I forgot to adapt the constructor's initializer list to also use the new constants. Change-Id: I7113d23cceb3a00f0d466b63c99a18bf3dfd0ee3 Reviewed-on: https://gerrit.libreoffice.org/64489 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-04use unique_ptr in SwView::FUNC_SearchNoel Grandin
which also fixes a leak Change-Id: I49da3f4ca3570b9fac44cee4c88c710472ca689e Reviewed-on: https://gerrit.libreoffice.org/64471 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-04convert m_pDocContent in SwGlobalTree to unique_ptrNoel Grandin
Change-Id: I779baa6dcad33aa5fbe49b5143b2b390a747036a Reviewed-on: https://gerrit.libreoffice.org/64470 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-04remove unused enum SfxObjectShellFlagsNoel Grandin
Change-Id: I594e7beb3fb320b70ffe4dd98fee46c833f443dc Reviewed-on: https://gerrit.libreoffice.org/64453 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-04NB update writer grouped_compactandreas kainz
Change-Id: Ie34f51e2540cfb2f0623402c2d69ac06f60fb9e4 Reviewed-on: https://gerrit.libreoffice.org/64383 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-04NB: change macro selection in writer notebookbarandreas kainz
Change-Id: I64d580096783300179ab10ecde270544bc561d54 Reviewed-on: https://gerrit.libreoffice.org/64382 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-12-04tdf#118764 Writer Page Styles panel tab stop fixesJim Raykowski
Change-Id: I090f15829a8c24f4204dd942b1c53ee8dce7834b Reviewed-on: https://gerrit.libreoffice.org/63833 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2018-12-03sw uno: do not throw exceptions on getString()Vasily Melenchuk
getString() is passive method and no reason to throw an exception instead of returning empty string in some corner situations like object is being disposed. As a compromise information about inbalid state is reported into log. Change-Id: Ied6ecb356ce341d44e5a2bb21fb8379257e38c31 Reviewed-on: https://gerrit.libreoffice.org/64442 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2018-12-03tdf#117189 Fix table insert row redoJim Raykowski
When a table does not have the cursor the code that inserts rows/cols ignores the table style. This fix approach moves the cursor into the table when restored with redo. Change-Id: Icbcdcd8fb931807267f24752c8af36da180735ca Reviewed-on: https://gerrit.libreoffice.org/60132 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2018-12-03Revert "sw_redlinehide_3: apparently a live SwNodeNum always has a parent"Michael Stahl
This reverts commit 6eebecf39a9e634cccad50ede29d281a6bfd24c8. The problem is that *during* RemoveFromList(), the IsInList() is called after the parent pointer is reset to null. e.g. during export of ooo67907-1.doc to .doc. SwTextNode::IsInList() const (this=0x57a3b30) at sw/source/core/txtnode/ndtxt.cxx:4352 SwTextNode::NumRuleChgd() (this=0x57a3b30) at sw/source/core/txtnode/ndtxt.cxx:2863 SwNodeNum::NotifyNode() (this=0x5804f80) at sw/source/core/SwNumberTree/SwNodeNum.cxx:211 SwNumberTreeNode::Notify() (this=0x5804f80) at sw/source/core/SwNumberTree/SwNumberTree.cxx:1068 SwNumberTreeNode::NotifyInvalidChildren() (this=0x52f1820) at sw/source/core/SwNumberTree/SwNumberTree.cxx:1088 SwNumberTreeNode::NotifyInvalidChildren() (this=0x57e4ab0) at sw/source/core/SwNumberTree/SwNumberTree.cxx:1111 SwNumberTreeNode::RemoveChild(SwNumberTreeNode*) (this=0x52f1820, pChild=0x5804f80) at sw/source/core/SwNumberTree/SwNumberTree.cxx:618 SwNumberTreeNode::RemoveMe() (this=0x5804f80) at sw/source/core/SwNumberTree/SwNumberTree.cxx:648 SwListImpl::RemoveListItem(SwNodeNum&) (rNodeNum=...) at sw/source/core/doc/list.cxx:151 SwList::RemoveListItem(SwNodeNum&) (rNodeNum=...) at sw/source/core/doc/list.cxx:251 SwTextNode::RemoveFromList() (this=0x57a3b30) at sw/source/core/txtnode/ndtxt.cxx:4328 (anonymous namespace)::HandleSetAttrAtTextNode::HandleSetAttrAtTextNode(SwTextNode&, SfxItemSet const&) (this=0x7ffffcc90aa0, rTextNode=..., rItemSet=SfxItemSet of pool 0x51799b0 with parent 0x0 and Which ranges: [(72, 72)] = {...}) at sw/source/core/txtnode/ndtxt.cxx:4751 SwTextNode::SetAttr(SfxItemSet const&) (this=0x57a3b30, rSet=SfxItemSet of pool 0x51799b0 with parent 0x0 and Which ranges: [(72, 72)] = {...}) at sw/source/core/txtnode/ndtxt.cxx:4917 Change-Id: I5a2775f397da171cde23cbf42f7e95da958987e8 Reviewed-on: https://gerrit.libreoffice.org/64448 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-12-03sw: convert assert(bSelected out of sync) to SAL_WARN for nowMichael Stahl
This evidently happens sometimes, but when it does it it's impossible to reproduce... Let's use SAL_WARN for now. Change-Id: Id724fd52060bfae45f9eeb16163ddfc94e53af03 Reviewed-on: https://gerrit.libreoffice.org/64447 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-12-03sw: prefix members of SwTableFieldMiklos Vajna
Change-Id: I02dd9227ee43967d8cf49d99791bada5d1231566 Reviewed-on: https://gerrit.libreoffice.org/64440 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2018-12-03sw: paragraph-sign: formattingAshod Nakashian
Change-Id: I9bf1b58aa6e18202a5f7eba010cc5b914e1d33d4 Reviewed-on: https://gerrit.libreoffice.org/63005 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-12-03sw: paragraph-sign: validate current SwTextNode directlyAshod Nakashian
When invoking undo, it turns out that the cursor position is updated after the text modification, which triggers the paragraph signature validation. Relying on the cursor position, then, results in the wrong (previous) paragraph to be validated (if the undo is in a different paragraph). Since we have the correct SwTextNode when it's modified (due to undo or otherwise), there is no reason why we shouldn't use it and try to deduce it from the cursor. Change-Id: I4c3283d59738988dcc1c592a9f3ef2c818ce675d Reviewed-on: https://gerrit.libreoffice.org/63004 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-12-03sw: paragraph-sign: get graph-names only onceAshod Nakashian
And reduce other overheads to make the paragraph signature validation significantly faster. Change-Id: I631bd0f15200bb8f0b85b40c0d4819a7bc4d562e Reviewed-on: https://gerrit.libreoffice.org/63003 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-12-03paragraph-sign: exception-safe metadata graph enumerationAshod Nakashian
Metadata graph enumeration can throw from a number functions and break things in horrible ways. Here we sanitize against the most egregious offenders, but not all possible sources. Change-Id: I40e006ea433dd7274d4fa08f3e8f8507680ef2f4 Reviewed-on: https://gerrit.libreoffice.org/63009 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-12-03sw: rdf: Split graph-name lookup from getStatementAshod Nakashian
The graph-name lookup is significantly costly (compared to the statement lookup, esp. when no statements exist). Luckily, the graph-names do not change often and in the course of enumerating all paragraphs (as happens for paragraph-signature validation) it doesn't change at all. This split allows for doing the graph-name lookup only once and also allows for passing custom graph-names directly, if we know them already. Change-Id: I75425df201becb41105ba1fa6ba580af202d035c Reviewed-on: https://gerrit.libreoffice.org/63002 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-12-03sw: paragraph-sign: erase metafields from copied text correctlyAshod Nakashian
This is relevant for paragraph signatures where the metadata is not yet copied and so we exclude it. The issue was that in some cases we didn't use the proper range of text and an assertion was triggered in debug builds. Otherwise there should be no change of behavior in release builds with this patch. Change-Id: I90bc2ca56d586b96d39f34c68de53d3dac6099d7 Reviewed-on: https://gerrit.libreoffice.org/63000 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-12-03sw lok: delay processing idle jobs to let LOK finish initializationAshod Nakashian
When loading document, LOK needs to setup the client view, register callbacks, get document size and type, etc. All of these need to take SolarMutex, which is taken by the idle jobs immediately after loading, blocking LOK from finishing initialization and rendering the first tiles for the user. This gives the user the impression that the document is loading for far longer than it actually is, due to lack of interactivity (or indeed any activity on the screen besides the spinning wheel). By delaying the idle jobs, we allow time for LOK to finish initialization and render the first tiles before the idle jobs kick in and hog SolarMutex. Reviewed-on: https://gerrit.libreoffice.org/56572 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 1056640a6e1fd044cb61f5bf5ee85dfec3cbeb7c) Reviewed-on: https://gerrit.libreoffice.org/58157 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit e5225f152c3128efa73cb602d7a524f2cb436189) Change-Id: Ic6f437bfd6f43dfed2aaa1a9d3510d43f5ec30ae Reviewed-on: https://gerrit.libreoffice.org/64013 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-12-03tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: Id7af9a6eaefc8b49a790eb299620c4fa97067a11 Reviewed-on: https://gerrit.libreoffice.org/64429 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-03tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: Ieff0dde4faee209200b8f4e809e8bb4eb1b8f4a6 Reviewed-on: https://gerrit.libreoffice.org/64433 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-02weld ScShareDocumentDlgCaolán McNamara
Change-Id: I790f957c9ebc6d87a94a355c30215245aaabeb30 Reviewed-on: https://gerrit.libreoffice.org/64345 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-02Related: tdf#121810 pass suitable message dialog parent aroundCaolán McNamara
Change-Id: I1a27d82ef94f1052171f7a3f6c5c80c0ec66b547 Reviewed-on: https://gerrit.libreoffice.org/64408 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-24 04:05:45 +0000