Age | Commit message (Collapse) | Author |
|
...since the (only) read of sXmlId got removed with
c50357ff625972464d1a591afe4198d3f6f42a39 "loplugin:unusedfields in sw"
Change-Id: I609eae60eb0e1d440a47f97b6387c833c1404518
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116855
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Since 20e5f64215853bdd32c5f16394ba7f2f36745904 "loplugin:unused-returns in sw"
removed
> return bChanged || bTabChanged;
from the end of SwLayAction::FormatLayoutFly, bTabChanged is effectively
completely unused (and now gets warned about by Clang), and the update of
bChanged is apparently no longer used, either.
Change-Id: Iab180e83070c45531aecf46d85a030463cf7b22d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116853
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This really confused me because it lead me to think
that this was something done for MS compatibility.
Well, that is only true in an off-handed way.
LibreOffice itself was changed to work similarly
to MS Word. So there is nothing special about how DOC
or DOCX/RTF are handled.
Since the compat settings are not saved or loaded
into MS Formats (i.e. it just takes the default value),
and since on an ODT save it also will just save
with the proper default value, there is no need
to specify "TabOverflow = true" in non-ODT import filters.
Only ooxmlexport16 has a unit test that reacts if
tabOverflow is false. That one is mine and it indicates
that the document would be better if tabOverflow was off,
so there are no examples of how tabOverflow improves a doc.
Change-Id: I97c25154108bc1ca0fcd3dfcff66fea0ea2bca7e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116741
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
where the previous attempt of
commit 4d52d2bc81f9d27472fe368785912a530489d046
tdf#142165 restore a SwShellTableCursor if the orig selection described that
so that we are operating on the same selection that existed when the
dialog was originally launched
wasn't sufficient to restore a single cell selection.
we continue to need to avoid the assert of
commit 6db71f70a3b200d4074f6cda8ce445e9861d3296
tdf#140977 drop possible table-cursor before setting the new one
and support the multi-selection of
commit e08b446e46f56e15af58fdd4396afba1a316f9e5
tdf#140257 duplicate entire PaM ring when making copy
and support not scrolling to a different location on changing a table
page break style of
commit 9c61732677d038e32b73fc9fb883aced14c0febf
tdf#135916 just set the target table as selection
and keep making it possible to remove a page break on a table of
commit 81f91196b98af38e29af451b86c26a893a109abc
tdf#135636 the selection at dialog-launch time is lost by dialog-apply time
all of which is necessitated by
commit c3a085d22742f88e91ff92f319a26d6e8d1d9a98
lokdialog: Convert the Table -> Properties... to async exec.
Though; since 4d52d2bc81f9d27472fe368785912a530489d046 where we started
using rSh.GetTableCrs if IsTableMode() then in practice
6db71f70a3b200d4074f6cda8ce445e9861d3296 probably cannot arise. The
scenario of rSh.IsTableMode() changing between launch of the dialog and
applying the result of the dialog is presumably maybe theoretically
possible in e.g. an online scenario, but not in the normal user case,
but handled here anyway.
Change-Id: I12f0b6bc7e0e2f5bad45a88007bf6fe2cd3d3b0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116933
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
It's a per-document setting, but it was only possible to set/get this for a
direct formatting dialog. Allow it for styles as well.
Change-Id: Iafe1cab37be1eb741b895fe3c6613c21bc63f0d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116931
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Before sw/qa/extras/layout/layout.cxx had 23 tests and
sw/qa/extras/layout/layout2.cxx 124. Now they have
81 and 66 respectively
Change-Id: Ib28824b4cbe6467c1e66ed29c99a3467dd9943f4
Change-Id: Ic561b2a2e5d6d33e24a4d0a73508fb3cb7284ea9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116889
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I9bac18844bded21ecf16c040c78b52a6eedeafc4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116883
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Uses filter options to manage whether hidden text output to file.
Fixes filter options usage in test.
Change-Id: I12a234438730795df6dd11bd6707dfa1fbfa4740
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105631
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
Change-Id: Ifba71748cc389544bfb64e225a7020de8261967b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105621
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
The line portion width can be quite large if the line contains an
as-char image.
Found by asking -fsanitize=implicit-unsigned-integer-truncation
-fsanitize=implicit-signed-integer-truncation to flag the problematic
conversions.
Change-Id: I303b9c71dcd979d79b9c9aee5283b268cc4e3b8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116835
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
...since the (only) read of sText got removed with
4e6be990eaf6a524740299e8d00fb5401c1a21c0 "weld SwTOXEntryTabPage"
Change-Id: I24bceb37c106cc840cef60d6a08953ca25cc3d15
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116854
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
The only read of nChgFormatLevel (spelled "nChgFmtLevel" back then) back at
84a3db80b4fd66c6854b3135b5f69b61fd828e62 "initial import" was in a
> #ifndef NUM_RELSPACE
block that was removed with f917bb6900bad2c9382374a2cbc5678b278dde2e
"INTEGRATION: CWS swnumtree". It apparently was dead code, as sw/inc/sw.mk had
included
> CDEFS+=-DNUM_RELSPACE
ever since at least 7b0b5cdfeed656b279bc32cd929630d5fc25878b "initial import"
(which was later removed with 58003f28fc09cb2021e145afa0d0d692a7a402a7
"INTEGRATION: CWS writercorehandoff" when all its remaining uses were also
removed in that CWS writercorehandoff).
Change-Id: I5972e2c949d21970e7f3f98a0a61600265ccb66b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116844
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Ic59398c15f4caa04191dbf4d6252361a330fc8c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116863
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
In Writer, cropping an flipped image crops the
opposite side of the image instead of the
selected side.
Fix: update crop values after the flipping(mirroring).
Change-Id: I55cfed086bbf63b0c516e1cb6b2624c02b04a6da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116770
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
DOCX in 2013 (compatibilityMode 15) no longer supports
TabOverMargin (i.e. the text margin),
but it does a similar kind of thing if the tab goes
into the spacing-after of a paragraph.
So add a compat flag to handle this in-between
kind of situation.
I grepped -i "tab_*over_*margin" to see if I was missing
anything. Decimal/Center proved to be only tabOverMargin.
IsInSect shouldn't matter since it fits inside the printing range.
The other places where I didn't insert TabOverSpacing
didn't seem relevant based on a code read.
Tab-after-tab still doesn't work great, but what we have is
already a massive house of cards that will just collapse if changed.
No real provision for handling tabs-over-paragraph-end.
-auto-tabs are created instead of "beyond nMyRight" tab,
unless it is the first tab defined.
-doesn't allow auto-tabs to fill the remaining space.
But on the other hand, MS Word's implementation of tabs
follows some kind of incomprehensible bizarre logic,
so just ignore the tabs completely, please.
Change-Id: I3723107b29ec3e287ea8661544711c13eee3ca48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116667
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
This uses existing ODF markup, as used by Writer's text frame:
style::columns child element of style:graphic-properties, its
fo:column-count and fo:column-gap attributes. No ODF extension
is required.
Since currently only columns with same width and spacing are
implemented, without additional settings, style:column child
elements are exported, but ignored on import.
This adds new property to css::drawing::TextProperties service:
TextColumns (of type css::text::XTextColumns).
Change-Id: I7e63293e5814b281ceec8a9632e696322d3629e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116035
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
(anchored as character) during change tracking instead of
using always the same NON_PRINTING_CHARACTER_COLOR blue one.
Follow-up to commit 76dc21860ce185bd5495adde8858d2f23284c78e
"tdf#142128 sw: set author-color strikethrough for deleted images".
Change-Id: I3fa02f6ec6cd1f71ae3b3c06644dd24f6c684f6f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116795
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
anchored to character during change tracking instead of
using always the same NON_PRINTING_CHARACTER_COLOR blue one.
Follow-up to commit 1610eeef6f2312616fe5d3535475f27f7896bef8
"tdf#142196 sw: crossing out images anchored to character".
Change-Id: I267a492dc6bb75327fb96ccdb51b784d00ba7a41
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116785
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
ODF doesn't track RTLness of the gutter explicitly, it infers this
setting from the writing direction. This means that in case the UI is
used to set it explicitly to a custom value, it'll be lost after
export + import.
Fix the problem by hiding the widget in the ODF case, so it doesn't
confuse users; it's still visible for Word formats which store this
explicitly.
Change-Id: I1316dcf461429af72498957c9b3eebcbdac794bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116799
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
if a unit test opens a dialog and exception
is thrown if does not exist a control, the
terminate() method fails, the unit test will
wait indefinitely for the subprocess to terminate.
Change-Id: I6dc77b2db8ce042ead78d13ce57e91892cd2db90
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113896
Tested-by: Jenkins
Reviewed-by: Henry Castro <hcastro@collabora.com>
|
|
SwViewOption::IsKeepRatio() was only in-memory, so ticking that checkbox
and restarting soffice disabled it again.
Handle this similar to e.g. the zoom factor which is mapped to a
view-specific settings.xml key.
Change-Id: I8d2de7d2c7ae0dbf34230e2011f6b07f63e02fbb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116791
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
it already has 230 tests
Change-Id: Id06ffb791cf65342676e6d7076105773c8137685
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116784
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I19162c6e6868dc9eb57444f5b33dc2bad299c230
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116783
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Ie22d23a49e4e1f352cec5ef32c2b0545b50f5aa5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116777
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I1c09a3bbf301166ccab16ecf0b57f22a335e0791
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116778
Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Tested-by: Jenkins
|
|
... SwHTMLPosFlyFrame
See tdf#94879 for motivation.
Change-Id: I4d1a427653aea5c6414f79c8eaea71336150bab7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116773
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Calling ZoomPlus has always executed shell SID_ZOOM_OUT case handling.
ZoomMinus, which replaced ZoomIn, does SID_ZOOM_IN case handling.
This patch changes ZoomPlus to do SID_ZOOM_IN case handling and
ZoomMinus to do SID_ZOOM_OUT case handling and makes appropriate
changes required by these name changes to provide expected zoom
results in all module shells that have handling for these calls.
Change-Id: If148f4f7866bfc8fc6452ad1c1dace723a125ef6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116287
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
Change-Id: I5030afe7d370b49b24f6a590bf9ce6e2a7a428e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116756
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Return a flag if the auto detected text has a BOM.
Save the flag in SwAsciiOptions so that BOM gets set correctly when
file is written.
Change-Id: I358c3ba243bc326a552c2dc24773c94f8319c700
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116759
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
store auto detected/configured ascii options in medium.
use stored ascii settings for saving and text encoding
settings dialog.
Change-Id: I88e2d54923bfcf5d7c460ef3b89c36fc002c5097
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116678
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
The test had previously raced between the effect of
vnd.sun.star.findbar:FocusToFindbar, typing, and pressing
the "Find All" button. If typing happened before focusing,
then focusing selected the already typed text. If button
was clicked before focusing, it found the edit unfocused,
and grabbed the focus, selecting its content.
This adds "HasFocus" property to WindowUIObject::get_state.
Change-Id: Ib277bd70508a3c1e86e1668afb7592d7a1523947
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116697
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I0f1f4121c06b8f628f4fe49284737cea3d28e4b8
Signed-off-by: merttumer <mert.tumer@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116141
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116301
Tested-by: Jenkins
|
|
But leave the CSS pixel size of them unchanged in the HTML markup.
Also add some documentation on the various options, so one doesn't have
to dig them out from testcases.
Change-Id: I6c6ee4e9c98d674f44e7c5835f2e6a6737e13f34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116722
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
It needs to wait until vnd.sun.star.findbar:FocusToFindbar does its
magic, which was racing with Python executing its typing.
This adds "SelectedText" property to ComboBoxUIObject::get_state.
Change-Id: I30faab2cc36a3cde59cf72ae5a383738a3ad4738
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116694
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
|
|
- the twips logic size was set, but it was consumed as mm100 logic size,
so the pixel size was about half of the correct one
- the HTML export didn't write a logic size ("CSS pixels size") for
shapes
Change-Id: I37f6b4acde9d1298fae81f9975e9db95485631ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116691
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I0e2811802f17831097a86103571b505a7557717a
Signed-off-by: merttumer <mert.tumer@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116040
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116299
Tested-by: Jenkins
|
|
Change-Id: Ia1049325bf26fbe6a3c8ac77c873d1af010d3581
Signed-off-by: merttumer <mert.tumer@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115541
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116297
Tested-by: Jenkins
|
|
sc/ could potentially benefit from this as well, that's not yet done
here.
Change-Id: I03d0b4afa21a02c74d34aab6e03ab53991df29dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116679
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
This adds a indexing output/export to HTML code, which will output
a xml document that will be used for indexing of the document. It
is based on HTML to reuse the traversal through the doc. model.
It is enabled by setting the "IndexingOutput" export parameter.
This commit only adds in the groundwork, but the output is still
more or less the same as html and the follow up commits will
add more indexing specific changes. The only change is to use
"indexing" as the top level element and the document is a valid
xml (has the xml header).
Also add basic test that the indexing output/export works and
can be parsed as an xml with "indexing" top level element.
Change-Id: I153b1a70da7cbcf0d33b8610d962e6b7ae23ad23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116631
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Only DOCX round-trip was supported for tracked table and
table row deletions. Now change tracking of newly
deleted tables and table rows is exported in DOCX.
Also the DOCX import is handled by Manage Changes now:
accepting the deleted ranges of a deleted row removes
also the table row, not only its text content.
Follow-up to commit 05366b8e6683363688de8708a3d88cf144c7a2bf
"tdf#60382 sw offapi: add change tracking of table/row deletion".
Change-Id: Ic02e0adbda11032acb9616c262c2fce134f6b07c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116652
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
image/x-vclgraphic is not something anybody else will understand.
Change-Id: I5a5b37b7f769de351bd3dfc38ccd57381bc43319
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116673
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
in order to remove duplicated code
Change-Id: Ic1e7d331b14f74051ed23bf6c7e64016eca61206
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116651
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
The term background is deprecated in several dialogs, e.g.
page style, paragraph and paragraph style in Writer and other
modules.
This patch changes the term 'Background' to 'Area' in the Insert section
dialog.
Change-Id: I6424517f8e3c6d8d8975c8dc62f905a3508aba55
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116580
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Change-Id: I9d9f02af7708043fbf80eb04dd12ea57cb4aa628
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116653
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
in order to remove duplicates code
Change-Id: Ie107d953d2e7ab4624edccd58fd8637349b9e098
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116649
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
ExportImagesAsOLE=true was only handled for Writer images, not for Draw
shapes, fix this.
Change-Id: If5018ff4b7c8b303d63a862f7428aa4e8b77d498
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116641
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Rename to "default" instead of "dflt", "start" instead of "stt",
"content" instead of "cnt",....
The shorter names are a product of utter laziness.
Change-Id: I5f5c8f6504e788395db495c000c098401767f8a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116628
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: Ib16661ea9d5f28bc4855b7b8b34f620a64c33475
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116613
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
But non-PNG needs a PNG fallback, add logic similar to how we already
handle this in the Writer image case.
Change-Id: Id853a7072878cada4a6e1e9367443f869028aa1b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116581
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I537d32f01da3ad33be0f021917d9dea67c083b09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116577
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|