summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2019-08-15loplugin:sequenceloop in swNoel Grandin
Change-Id: Icda7c89b396e5607ca847c0a8393cb27a2d50c6c Reviewed-on: https://gerrit.libreoffice.org/77530 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-15tdf#53847 - Styles focused toolbarHeiko Tietze
Improved the focus on style by hiding a few direct formatting functions Change-Id: Icd98472d5ecaf79c9612cbd9be654abd935077d5 Reviewed-on: https://gerrit.libreoffice.org/77496 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-08-15tdf#125041 fix hyperlinks to IDN websitesTünde Tóth
Revert "tdf#86087 Open relative links in Writer" This reverts commit 4b9e237850efe36f7e35d65e14d6953f1e1f3a45. The reverted commit caused a regression in the handling of internationalized domain names: these non-ASCII URLs were converted to file URIs. Change-Id: Ia481aa1199d20083b72f9f8571992e40b3fc2e77 Reviewed-on: https://gerrit.libreoffice.org/76804 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-08-15Removed duplicated includeAndrea Gelmini
Change-Id: I8af2cae6d88c196e3d5d64266a43ded054d7cffb Reviewed-on: https://gerrit.libreoffice.org/77487 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-15replace ".get->" with "->"Noel Grandin
Change-Id: I327a6fda1fe0170da33e06b735f09a39421c8a58 Reviewed-on: https://gerrit.libreoffice.org/77469 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-15sw btlr writing mode: RTF filter of Writer textframesMiklos Vajna
Both import and export needed fixing. Change-Id: Ie1728c3e67d8637e3720748d7f61a69c058eafe3 Reviewed-on: https://gerrit.libreoffice.org/77474 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-15tdf#122529 lok - table border position manipulationTomaž Vajngerl
This adds a new LOK callback (LOK_CALLBACK_TABLE_SELECTED) that sends the border positions to the client when the user has the cursor or slelection in a table. In addition this adds a .uno:TableChangeCurrentBorderPosition uno command, which implements changing a specific border in the current table. Border can be either a column or a row border, which is either at the first, middle or last position. Change-Id: Ife7cff14d91ffc84c95c040f0b42319e3d6194b4 Reviewed-on: https://gerrit.libreoffice.org/77365 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-08-14sw: fix assert on export of ooo39250-1.rtf to DOCXMichael Stahl
The problem is that a fly anchored at-char inside a text frame is being exported; in DocxSdrExport::startDMLAnchorInline() the m_bFlyFrameGraphic is true so an "inline" element is written but then DocxSdrExport::writeDMLTextFrame() sets the flag to true then false, so in endDMLAnchorInline() it's false and "anchor" results. Remove the pointless information hiding between DocxSdrExport and its own pImpl class so that the previous flag can be restored. (regression from commit 28b77c89dfcafae82cf2a6d85731b643ff9290e5 which changed things somehow so that the anchor is inside the text frame instead of the body as it was before; Word has it also in the text frame so we can consider it an improvement) Change-Id: I2df20b5cc336251f1c20cf81b6d68153c0c6ff46 Reviewed-on: https://gerrit.libreoffice.org/77454 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-14Set "Resolved Comments" view option on by defaultScott Clarke
The "Resolved Comments" view option now starts switched on by default to match the fact that resolved comments would be visible when a document was first opened anyway. Change-Id: Ib9c41c57c826f4282d0d6bf0ebcd485aa71ce1d6 Reviewed-on: https://gerrit.libreoffice.org/77189 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-14Change some handling for resolved commentsScott Clarke
Changed the way the lcl_CommentNotification method is called when a comment is resolved such that resolution is distinct from other changes. Resolved flag is now only stored in the top annotation of a thread when saved as ODT. Change-Id: I5ef36718fd7e1dfcc16c077871653a70476e8804 Reviewed-on: https://gerrit.libreoffice.org/77411 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-14Resolves tdf#126257 - Writer styles hierarchical organizationHeiko Tietze
Index styles moved below Index Heading Change-Id: I178dcb668abe225a25ce35108b1bba4a73ffa960 Reviewed-on: https://gerrit.libreoffice.org/77394 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-08-13Writer: Saving a damaged file as DOCX crashesTamás Zolnai
Change-Id: I42de376c69d0b1caa0a03622506d1bf6385ca57e Reviewed-on: https://gerrit.libreoffice.org/77412 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-08-13tdf#123583 use TaskStopwatch for Writer Idle loopJan-Marek Glogowski
I don't see much of a point in the extra CheckIdleEnd() function. We already check IsInterrupt() almost everywhere, so move that check in there. An other strange thing is the Idle job, which should just be interrupted by keyboard events (using SetInputType(, which this patch removes). Unlucky for me this code was there in the initial import. I can just say that othing obvious breaks... Change-Id: Ia5955d1eaf2ab612f2c4b63b0e458ed92507b75c Reviewed-on: https://gerrit.libreoffice.org/77040 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-08-13sw doc model xml dump: improve OLE node handlingMiklos Vajna
So it's possible to see if we have a dummy, common or OLE embedding. Change-Id: I8c241211a149ca5261fdf8171cd2814fced8de79 Reviewed-on: https://gerrit.libreoffice.org/77403 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-13sw undo/redo derived style storing during creation by exampleVasily Melenchuk
Same as c4d82fc21c5e155472f6a30244b3fce806ada85c done for tdf#118384, but this code is fixing same problem with SwDocShell::MakeByExample ("New Style from Selection"). Change-Id: I488018bbf5ecb02e9e57eb032b6f875f4fe08f98 Reviewed-on: https://gerrit.libreoffice.org/77199 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-13warn on load when a document binds an event to a macroCaolán McNamara
a) treat shared/Scripts equivalently to document scripts This doesn't automatically warn/block running those scripts when used in a freshly loaded document on its own however because DocumentMacroMode::checkMacrosOnLoading will see at... if ( m_xData->m_rDocumentAccess.documentStorageHasMacros() || hasMacroLibrary() ) that the document contains no macros and flip the allow macros flag to true so that potentially new uses of macros added by the user during the edit are allowed to run b) so, add an additional flag to indicate existence of use of macros in a document c) for odf import, set it when a script:event-listener tag is encountered d) for html import when registerScriptEvents or SwFormatINetFormat::SetMacroTable is called e) for doc import when Read_F_Macro or StoreMacroCmds is called as well for good measure f) for xls import when registerScriptEvent or ScMacroInfo::SetMacro is called g) for oox import when VbaProject::attachMacros is called Change-Id: Ic1203d8ec7dfc217aa217135033ae9db2888e19b Reviewed-on: https://gerrit.libreoffice.org/77131 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-13tdf#125100 After insert of calc document as OLE object, content is shownIlhan Yesil
After inserting an OLE object, the object has to be shown with the preview of it's content. The flag for this is set in the InsertObject method. Change-Id: I9f0f362190bb9ab0bc36987cf0a6f969932544ec Reviewed-on: https://gerrit.libreoffice.org/75207 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-13remove unused constantNoel Grandin
result of a patch from me(137c7fb55462bf2b8792fc742f9f8343a23aac87) colliding with a patch from sberg (8075ef1a616da27ea1fb65e988e5ef5764d8ec11) Change-Id: Ie72e5e9660236edc3c30347662f8802081e59f25 Reviewed-on: https://gerrit.libreoffice.org/77375 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-13tdf#42949 Fix IWYU warnings in sw/source/ui/*/*hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I6dcdf9865589b1886a3ebaa1f37cbe8e2da7c98d Reviewed-on: https://gerrit.libreoffice.org/77348 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-13RTF filter: add redline insert/delete testcaseMiklos Vajna
lcov points out these were not covered previously. Change-Id: I469fab797b2935b36c06eb8854061b81faf2dbcf Reviewed-on: https://gerrit.libreoffice.org/77372 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-13Fix typosAndrea Gelmini
Change-Id: If99059383039e65aacfc55baec660eb6fde47032 Reviewed-on: https://gerrit.libreoffice.org/77376 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-13tdf#114854 writerfilter: EditEng URLs import different from SW URLsJustin Luth
The only example I found was comments (aka annotations/postits). No other unit tests had a URL in a draw component. Change-Id: Iad5c285090d646c495cd2a7b19e076d9e50fb58d Reviewed-on: https://gerrit.libreoffice.org/77108 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-08-13sw: avoid dangling references to style in undo/redoVasily Melenchuk
if text style was created/deleted, reference contained in SwUndoAttr is irrelevant and can't be used. Instead of this style name is keept and reference to style is found during redo. Change-Id: I688ae5e7d58149f9fe824c6b0945e72aba82abb1 Reviewed-on: https://gerrit.libreoffice.org/76842 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-13sw: clean-up SwTabCols header a bit, no chnageTomaž Vajngerl
Change-Id: Ifd42ef5ba86edd75f208d540d02970b3f5c67745 Reviewed-on: https://gerrit.libreoffice.org/77364 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-08-12sw: Immediately construct a shared_ptr instead of raw pointerTomaž Vajngerl
Change-Id: Id6e212ae143133ea1899c585f18986c02bf3a58d Reviewed-on: https://gerrit.libreoffice.org/77363 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-08-12sw: properly initialize the instance variablesTomaž Vajngerl
Change-Id: Id12dcebe12540302e32a54e6c62b6773f6695e0c Reviewed-on: https://gerrit.libreoffice.org/77362 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-08-12sw: factor out changing of mouse pointer on mouse moveTomaž Vajngerl
Change-Id: I3ff9783d17b018cd962b2416810ac2ce166d35c6 Reviewed-on: https://gerrit.libreoffice.org/77361 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-08-12Remove executables bit on odt fileAndrea Gelmini
Change-Id: If964ef0a42ea70de338ac97c56a4bbbe46641e76 Reviewed-on: https://gerrit.libreoffice.org/77354 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-08-12sw: fix assert in SwTextFrame::RegisterToNode() on ooo33427-1.sxwMichael Stahl
If we now allow deleting the first node from SwRangeRedline::DelCopyOfSection(), it will trigger if there's a insert redline ending on the same empty node where a delete redline starts. (somehow this was missing in beec1594587d0bf1ea2268f9a435c948b5580278) Change-Id: I83ce5bdac983873b89536e06d1dc0d7d8fb17ada Reviewed-on: https://gerrit.libreoffice.org/77351 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-12tdf#120734 Only enable "Remove hyperlink" when hyperlink selectedSamuel Mehrbrodt
Change-Id: I4a4b7fc8adb86f6af4660e7d987a7703945c40d4 Reviewed-on: https://gerrit.libreoffice.org/77349 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-12loplugin:staticconstfieldNoel Grandin
Change-Id: I50153c5635d083f568315aca06e05fe98e10867a Reviewed-on: https://gerrit.libreoffice.org/77347 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-12Add test for resolved comments in odfexportScott Clarke
Change-Id: I069d84b1e6b80731c5d13a1f8b06f4ed9df0844a Reviewed-on: https://gerrit.libreoffice.org/77153 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-12Fix typosAndrea Gelmini
Change-Id: I4a334f1f40c829ddffb93cd8a41f0a9c8e65d5d8 Reviewed-on: https://gerrit.libreoffice.org/77279 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12cid#1401328 Uncaught exceptionCaolán McNamara
Change-Id: I22ce1fd66796ed4b95f56c4d8ca7b20b6eee7e8a Reviewed-on: https://gerrit.libreoffice.org/77332 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-12Don't select hyperlink fields arbitrarilySamuel Mehrbrodt
For some functions, like remove or edit hyperlink, it's required that the hyperlink field is selected. However, we should do that only when executing the function, not when queriying its status. This led to selection changes on mouse over/right click. Change-Id: I22035698032d1e651aae6a74d6e445dfe044bf74 Reviewed-on: https://gerrit.libreoffice.org/77336 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-12wether->whetherCaolán McNamara
Change-Id: I588b7cc4b494e6569e7a7ba95e57e666d029b72b Reviewed-on: https://gerrit.libreoffice.org/77324 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-12sw: prefix members of SwUndoMiklos Vajna
See tdf#94879 for motivation. Change-Id: I390704209678710d7aef3dc90aef509c355cc4e1 Reviewed-on: https://gerrit.libreoffice.org/77330 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-12Fix typosAndrea Gelmini
"its" Change-Id: I02c660e46964270376a66210fdb5f1b1985ce5b6 Reviewed-on: https://gerrit.libreoffice.org/77255 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: Ib6b4f091e56e047968b2ad9b575aff2c81558635 Reviewed-on: https://gerrit.libreoffice.org/77254 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-10loplugin:staticconstfieldStephan Bergmann
(no idea why that only started to show now; Clang 10 on macOS here) Change-Id: Ie9115e7c2396378f31f85ae592841711e58c6b1d Reviewed-on: https://gerrit.libreoffice.org/77237 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-10sw: fix ~SwIndexReg asserts on ODF export of ooo83072-1.odtMichael Stahl
It is now possible that the stupid redline-moving code deletes the first node in the document, and there are 2 SwPaM that point to it, Writer::m_pCurrentPam and local pPam in SwWriter::Write(). So i thought it should be quite trivial to just use SwUnoCursors in these cases, but it required a bit more keyboard bashing than expected. (regression from beec1594587d0bf1ea2268f9a435c948b5580278, which i didn't really intend to push and am not sure if it's really a good idea but whatever...) Change-Id: Ia5c18d67af8760664517a4b7ee62ef3e4a417686 Reviewed-on: https://gerrit.libreoffice.org/77225 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-09sw qa: fix typos in rtfimport/export testsMiklos Vajna
This doesn't matter in practice, since both tests inherit from the local "Test" class, which has the correct filter name; it was just misleading. Change-Id: Ie5f2e0a89a31b56abc200a1270b4b65e870fb459 Reviewed-on: https://gerrit.libreoffice.org/77198 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-09sw: remove unnecessary boost includeMichael Stahl
Change-Id: I38698992ee829ab1055e6f1da0f61ce35164a92f Reviewed-on: https://gerrit.libreoffice.org/77213 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-09tdf#118699 sw_redlinehide: need some more changes to use the last nodeMichael Stahl
... as property node for the merged frame. This would assert in SwContentNode::DelFrames() during tdf#126627 and also in crashtesting, e.g. fdo66302-1.odt. (regression from fa5eb82b398e29ae033f7b7c8c8195dfc10cf5b0) Change-Id: Ia6d52287ed42f41d16ebf12bc61d7f4a6d7c5b03 Reviewed-on: https://gerrit.libreoffice.org/77212 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-09tdf#126627 sw_redlinehide: fix corner case in SwUndoDelete::UndoImpl()Michael Stahl
The assumption that the merge by the moved nodes would be sufficient to handle the end node's frames is wrong: the MakeFrames() uses FrameMode::New, so the frames on the end node are not deleted, even if a previous node is merged with the end node, so the end node has 2 frames in the same layout, which will cause all sorts of problems. Ensure that the ::MakeFrames() that is called from SwUndoDelete will *once* use FrameMode::Existing, which will delete the existing frames on the end node *iff* it is merged. Subsequent SwTextNode::MakeFrames() calls on the nodes must use FrameMode::New of course, to prevent deleting the newly created frames immediately. Hopefully the SwUndoDelete is the only caller of MakeFrames() that will run into this corner case, as the others typically operate on a nodes-array section... (regression from 723728cd358693b8f4bc9d913541aa4479f2bd48) Change-Id: I829c1e7a92434f93d56e3c88a4ba4a55bab818d4 Reviewed-on: https://gerrit.libreoffice.org/77211 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-09tdf#126626 sw: fix duplicate SwUndoInsLayFormat in single-node CopyMichael Stahl
Fly Undo created later in SwUndoInserts::SetInsertRange(); suppress it in DocumentContentOperationsManager::CopyImpl(). (regression from 28b77c89dfcafae82cf2a6d85731b643ff9290e5) Change-Id: I3b8756c20a7472029748d9e64a941320fc10b19f Reviewed-on: https://gerrit.libreoffice.org/77190 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-09Fix typosAndrea Gelmini
"its really" Change-Id: Ic0b41597c83be6c1c66b9cdf6ccbf80b0c2bc9ef Reviewed-on: https://gerrit.libreoffice.org/77204 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-09tdf#126768 DOCX import: fix absolute hyperlinks to documentsTünde Tóth
file:///absolute\\path\\to\\file didn't work in Writer. Change-Id: I61135668e47bc1d67afb4ed6bec6a90744d295cf Reviewed-on: https://gerrit.libreoffice.org/77184 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-08-09tdf#126723 writerfilter::finishParagraph - me, not previousJustin Luth
In LO 6.2 commit 480ac84f2f5049fb4337b36f12fd6796e005761b the existing m_xPreviousParagraph was conveniently used to apply the changed properties. I never did like that choice, but despite looking at it, I failed to see that it is set in an inside loop, which means that it was NOT NECESSARILY reset to the current paragaph. So I'm happy to have proof that we should not use m_xPreviousParagraph. Change-Id: I5c7f1b0f097711d65ae0d0be1f0fbc40c8b96e9d Reviewed-on: https://gerrit.libreoffice.org/77185 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2019-08-09tdf#42949 Fix IWYU warnings in sw/source/uibase/*/*hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I611478d4ade6d05625f599f9d51dd0e1335e7b0a Reviewed-on: https://gerrit.libreoffice.org/77180 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-16 10:13:50 +0000