summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2019-12-03Adapt CPPUNIT_ASSERT to C++20 deleted ostream << for sal_Unicode (aka char16_t)Stephan Bergmann
<http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1423r3.html> "char8_t backward compatibility remediation", as implemented now by <https://gcc.gnu.org/ git/?p=gcc.git;a=commit;h=0c5b35933e5b150df0ab487efb2f11ef5685f713> "libstdc++: P1423R3 char8_t remediation (2/4)" for -std=c++2a, deletes operator << overloads that would print an integer rather than a (presumably expected) character. But for simplicity (and to avoid issues with non-printing characters), keep printing an integer here. Change-Id: I751b99ee32d418eb488131ffa130d6f7d6d38dc7 Reviewed-on: https://gerrit.libreoffice.org/84348 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03Use o3tl::doAccess, prevent -Werror=maybe-uninitializedStephan Bergmann
Change-Id: I6a86db428dcf92083ee13298417b3d3027e45822 Reviewed-on: https://gerrit.libreoffice.org/84338 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03Use o3tl::doAccess, prevent -Werror=maybe-uninitializedStephan Bergmann
(and do not unbox Any where it is not necessary anyway) Change-Id: Ic5461fb8b62157e9116cd2d557ee38fface28fb7 Reviewed-on: https://gerrit.libreoffice.org/84337 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03Silence false -Werror=maybe-uninitializedStephan Bergmann
...where success of >>= has already been checked with CPPUNIT_ASSERT Change-Id: I127d559ab0bf212e4a32db4f297954d3b94032fc Reviewed-on: https://gerrit.libreoffice.org/84345 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03Adapt to C++20 deleted ostream << for sal_Unicode (aka char16_t)Stephan Bergmann
<http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1423r3.html> "char8_t backward compatibility remediation", as implemented now by <https://gcc.gnu.org/ git/?p=gcc.git;a=commit;h=0c5b35933e5b150df0ab487efb2f11ef5685f713> "libstdc++: P1423R3 char8_t remediation (2/4)" for -std=c++2a, deletes operator << overloads that would print an integer rather than a (presumably expected) character. But in these cases printing an integer is as expected, so add explicit casts. Change-Id: I7c2f1afaa2982b284aef8af183b71466c37142c2 Reviewed-on: https://gerrit.libreoffice.org/84339 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03tdf#101513 add customizable option to writer NB contextual singleandreas kainz
Change-Id: I0c62b26d0b47cef7f02ee581412aa3cd2d6ac7e4 Reviewed-on: https://gerrit.libreoffice.org/84285 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-03remove some useless comment linesNoel Grandin
which merely announce that the next declaration is a class Change-Id: Ifdb1398bcd99816b13e0b3769b46d0562bfbc1dc Reviewed-on: https://gerrit.libreoffice.org/84229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-03Directly use o3tl::optional comparisonStephan Bergmann
Change-Id: I864137704dd8c27d034dc34c947c97954dd18ef3 Reviewed-on: https://gerrit.libreoffice.org/84296 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03lok: calc - store zoom in the view itself.Michael Meeks
Don't duplicate this on the ITiledRenderable interface, which is not a per-view construct, this just confuses everything. Store & restore the zoom level before/after rendering a tile - unfortunately this is not done by the most optimal view yet. Change-Id: I1f7dfaa353333f45c5601d49a9bca784d34fb81a Reviewed-on: https://gerrit.libreoffice.org/84281 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-12-02tdf#101513 add customizable option to writer NB tabbedandreas kainz
Change-Id: I2a8dcf184b8ca268be2163b90305babd2ee70807 Reviewed-on: https://gerrit.libreoffice.org/84169 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-02tdf#47583 sw: Don't mix doc print settings into option dialogMichael Weghorn
Show and manage the default Writer print options in the "Tools" -> "Options" -> "LibreOfficeDev Writer" -> "Print" dialog and don't mix in the document-specific values of the currently opened document, as this is rather confusing as described in tdf#47583. There is a separate dialog to manage the settings for the currently opened document available via "File" -> "Printer Settings" -> "Options". At a quick glance, this also matches the behaviour for Calc, which doesn't mix in the current doc's settings either. This handles the case for the Writer-specific print options. For a more general approach on whether and how document-specific options should be handled in the "Tools" -> "Options" dialog at all, there are already tdf#43786 ("Intransparent Use of Options") and tdf#105751 ("Separate document saved options from global options in Options dialog"). Side note: The previous implementation also wasn't synchronizing the settings both ways. Changes made in the "File" -> "Printer Settings" -> "Options" dialog did show up in the "Tools" -> "Options" -> "LibreOfficeDev Writer" -> "Print" dialog at once, but not the other way around. The reason is that Writer-specific print settings are currently managed in two places in DocumentDeviceManager: (1) its SwPrintData, accessible via 'DocumentDeviceManager::{g,s}etPrintData' (2) the print data set in its 'SfxPrinter*' ('DocumentDeviceManager::{g,s}etPrinter') The "File" -> "Printer Settings" -> "Options" dialog uses the settings from the SfxPrinter. So, to make synchronization work both ways with the previous implementation, the changes made in the "Tools" -> "Options" dialog would also have to be applied for (2), not just (1), e.g. this way: diff --git a/sw/source/uibase/app/appopt.cxx b/sw/source/uibase/app/appopt.cxx index 9c7e24592014..83bae7eb71b9 100644 --- a/sw/source/uibase/app/appopt.cxx +++ b/sw/source/uibase/app/appopt.cxx @@ -371,8 +371,15 @@ void SwModule::ApplyItemSet( sal_uInt16 nId, const SfxItemSet& rSet ) const SwAddPrinterItem* pAddPrinterAttr = static_cast<const SwAddPrinterItem*>(pItem); *pOpt = *pAddPrinterAttr; - if(pAppView) + if(pAppView) { pAppView->GetWrtShell().getIDocumentDeviceAccess().setPrintData( *pOpt ); + SfxPrinter* pDocPrinter = pAppView->GetWrtShell().getIDocumentDeviceAccess().getPrinter(false); + if (pDocPrinter) { + SfxItemSet aOptions(pDocPrinter->GetOptions()); + aOptions.Put(*pAddPrinterAttr); + pDocPrinter->SetOptions(aOptions); + } + } } } (Maybe that should be consolidated at some point in time...) Change-Id: I74961f4d8947e200b415e6e32e128a0ce3d317f5 Reviewed-on: https://gerrit.libreoffice.org/84212 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-12-02tdf#109425 KB navigation fixes for NB groupedbar compactJim Raykowski
Change-Id: Ie4b21b8b4d07df1a8f7ca5cd9a7a83160f5c9056 Reviewed-on: https://gerrit.libreoffice.org/84185 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-02tdf#42949 Fix IWYU warnings in sw/source/core/[o-t]*/*cxxGabor Kelemen
Also drop a duplicated blacklist rule found with: grep :$ sw/IwyuFilter_sw.yaml | sort | uniq -cd Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ied72f3f086ed4c1eb7ff4bcdbcf8aee73ddd4f7c Reviewed-on: https://gerrit.libreoffice.org/83250 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-12-02tdf#105481 : Do not skip invalidation of as-char anchored objectsDennis Francis
inside a growing text-frame after doing recalc of positions of other frames (visually above current) in the tree. Otherwise the as-char anchored objects gets wrong reference (base) position (more accurately the base Y position) and hence get displayed at wrong vertical positions (in case of the bug document, it goes out of the page area). Some notes about the bug: Above mentioned problem is visible (at least) when you have a frame anchored to the bottom of the page with auto-height and it contains one or more <text:p> with at least one of them having a draw object like a shape or math formula with 'as-char' anchoring. Only the draw object in the last <text:p> is affected by the bug possibly because this text-frame is the cause of growth of the parent (upper) frame. Change-Id: If968c8c00aa57d26b1000e3250b352b24df47cf6 Reviewed-on: https://gerrit.libreoffice.org/83603 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-12-02sw: prefix members of SwScriptIterator, SwUndoInsert, SwUndoReRead and ...Miklos Vajna
... SwUpdFootnoteEndNtAtEnd See tdf#94879 for motivation. Change-Id: I013bae47e38afd9dcb1678a1d0b988495d5ac265 Reviewed-on: https://gerrit.libreoffice.org/84188 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-12-02tdf#129054 Chart OOXML Import: Fix size of Pie ChartBalazs Varga
Do not shift (set to false ShiftedCategoryPosition) the category axis for Pie chart with complex category. Change-Id: I3b1d99899a2daf9fd7a596c88531797aa5084734 Reviewed-on: https://gerrit.libreoffice.org/83871 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-12-01SpellingPopup: lok: keep the selection to make context menu work.Tamás Zolnai
Change-Id: Ida46a1140c889d1864b423eb9c5512d99a028fce Reviewed-on: https://gerrit.libreoffice.org/84155 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-12-01Remove unused variable.Tamás Zolnai
Change-Id: I34a15cb1e457c3ac0329e5ba735ac93db99e9fbf Reviewed-on: https://gerrit.libreoffice.org/84154 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-12-01SpellingPopup: lok: we don't need to disable menu items for online.Tamás Zolnai
Now, that we generate the conext menu in JS code, we can control the visibility of items. Change-Id: I09112619a9669e6ebf1a8d468e0329b8914db0ff Reviewed-on: https://gerrit.libreoffice.org/84153 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-12-01tdf#109425 NB bar compact: Make send mail button kb accessibleJim Raykowski
Change-Id: I4b0bbe9834cb950ff67210404c0e28225f1bd4a0 Reviewed-on: https://gerrit.libreoffice.org/84101 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-01tdf#109425 Fixes for notebookbar singleJim Raykowski
Enable grow and shrink controls to be keyboard accessed and make print preview controls show Change-Id: I6a31b881fb08bc73d4b4b475658c210824cbc109 Reviewed-on: https://gerrit.libreoffice.org/84105 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-01Introduce o3tl::optional as an alias for std::optionalStephan Bergmann
...with a boost::optional fallback for Xcode < 10 (as std::optional is only available starting with Xcode 10 according to <https://en.cppreference.com/w/cpp/compiler_support>, and our baseline for iOS and macOS is still Xcode 9.3 according to README.md). And mechanically rewrite all code to use o3tl::optional instead of boost::optional. One immediate benefit is that disabling -Wmaybe-uninitialized for GCC as per fed7c3deb3f4ec81f78967c2d7f3c4554398cb9d "Slience bogus -Werror=maybe-uninitialized" should no longer be necessary (and whose check happened to no longer trigger for GCC 10 trunk, even though that compiler would still emit bogus -Wmaybe-uninitialized for uses of boost::optional under --enable-optimized, which made me ponder whether this switch from boost::optional to std::optional would be a useful thing to do; I keep that configure.ac check for now, though, and will only remove it in a follow up commit). Another longer-term benefit is that the code is now already in good shape for an eventual switch to std::optional (a switch we would have done anyway once we no longer need to support Xcode < 10). Only desktop/qa/desktop_lib/test_desktop_lib.cxx heavily uses boost::property_tree::ptree::get_child_optional returning boost::optional, so let it keep using boost::optional for now. After a number of preceding commits have paved the way for this change, this commit is completely mechanical, done with > git ls-files -z | grep -vz -e '^bin/find-unneeded-includes$' -e '^configure.ac$' -e '^desktop/qa/desktop_lib/test_desktop_lib.cxx$' -e '^dictionaries$' -e '^external/' -e '^helpcontent2$' -e '^include/IwyuFilter_include.yaml$' -e '^sc/IwyuFilter_sc.yaml$' -e '^solenv/gdb/boost/optional.py$' -e '^solenv/vs/LibreOffice.natvis$' -e '^translations$' -e '\.svg$' | xargs -0 sed -i -E -e 's|\<boost(/optional)?/optional\.hpp\>|o3tl/optional.hxx|g' -e 's/\<boost(\s*)::(\s*)(make_)?optional\>/o3tl\1::\2\3optional/g' -e 's/\<boost(\s*)::(\s*)none\>/o3tl\1::\2nullopt/g' (before committing include/o3tl/optional.hxx, and relying on some GNU features). It excludes some files where mention of boost::optional et al should apparently not be changed (and the sub-repo directory stubs). It turned out that all uses of boost::none across the code base were in combination with boost::optional, so had all to be rewritten as o3tl::nullopt. Change-Id: Ibfd9f4b3d5a8aee6e6eed310b988c4e5ffd8b11b Reviewed-on: https://gerrit.libreoffice.org/84128 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-01boost::optional: replace uses of get_value_or with value_orStephan Bergmann
...in preparation for wholesale replacement of boost::optional with o3tl::optional, which will be an alias for either std::optional or boost::optional, and std::optional only has value_or. boost::optional::value_or was added with <https://github.com/boostorg/optional/ commit/3984c9f9a157ef116cea69bc8bb20f433320eb61> "Added function value_or()", which according to git-describe first appeared in tag boost-1.56.0. We appear to have no strict Boost baseline (the closest we get is with > [AC_MSG_ERROR(boost/spirit/include/classic_core.hpp not found. install boost >= 1.36)] in configure.ac), and at least CentOS 7 TDF machine tb76 only has boost-devel-1.53.0-27.el7.x86_64. However, any environment using Xcode < 10 that needs to make o3tl::optional fall back to boost::optional should use --without-system-boost, and external/boost is currently at 1.69.0, so should be safe. ATTENTION: In isolation, this commit will break in any environment that uses Boost older than 1.56.0. It requires the following commit introducing o3tl::optional. (But doing these changes in individual commits was deemed more valuable than supporting a hypothetical future git-bisect against an old Boost.) Change-Id: Ib31affa3eebf0d0029d8620dc6abb7a60f6c7629 Reviewed-on: https://gerrit.libreoffice.org/84127 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-30related tdf#118947 sw tablestyle: no need to avoid numbered paraJustin Luth
Removed the hack that avoided applying table properties to paragraphs that had numbering/bullets applied. Most of the hackery around that happens in finishParagraph(), which runs before this, so any table properties already see all of the directly applied numbering properties. Since numbering heavily uses RES_LR_SPACE (which has multiple MemberIds), the previous inability to distinguish SET/DEFAULT per member probably caused problems, but since that happens now, it should be safe to also apply table-style properties. Change-Id: Id59a6249af55ea60255e2cef4ed9efe3d8321246 Reviewed-on: https://gerrit.libreoffice.org/81414 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-11-30Rewrite uses of boost::optionalStephan Bergmann
...to only use functions that are also available for std::optional (in preparation for changing from boost::optional to std::optional): * uses of get are replaced with operator * or operator -> * uses of is_initialized are replaced with operator bool * uses of reset with an argument are replace with operator = (All of the replacements are also available for boost::optional "since forever", so this change should not break builds against old --with-system-boost. An alternative replacement for is_initialized would have been has_value, but that is only available since Boost 1.68.) Change-Id: I532687b6a5ee37dab28befb8e0eb05c22cbecf0f Reviewed-on: https://gerrit.libreoffice.org/84124 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-30Replace uses of boost::optional<>::get_ptr with free functionStephan Bergmann
...in preparation of replacing boost::optional with std::optional, which doesn't have get_ptr Change-Id: I432d6deb7cf9b892b6126245882c74ab680f2984 Reviewed-on: https://gerrit.libreoffice.org/84119 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-29tdf#118947 writerfilter: remove obsolete tablestyle fontsize hackJustin Luth
LO 6.5 commit 6bced3c6a1bf8d4652dd6ba75e41b128ce1bfc5c obsoletes this old hack. The default paragraph style has (almost) nothing to do with table styles. *Any* specified (non-inherited) paragraph style property should override a table style, including the default paratyle. One exception is the default occurance of the not-yet-supported word/settings.xml compat option overrideTableStyleFontSizeAndJustification = false. The default case should cause the table-style font to override a size 11 or 12 default-paragraph-style font. So that is actually double-reason to remove this old hack which threw out the table-style size altogether. Change-Id: Id1687f32b8431b6fa8770b01c344e75e0ffb344f Reviewed-on: https://gerrit.libreoffice.org/84044 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-11-29unnecessary virtualCaolán McNamara
Change-Id: I918a8c51e55919555108c075d396b04b4dcafbd1 Reviewed-on: https://gerrit.libreoffice.org/84061 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-29jsdialog: migrate left/right margin to generic items dumpSzymon Kłos
Change-Id: Ie687393ae4b9a7f8350eea07c1d417c11fc532bd Reviewed-on: https://gerrit.libreoffice.org/84002 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-29jsdialog: migrate after/before spacing to generic items dumpSzymon Kłos
Change-Id: I18f0596baa8e1136f4546a943eafab9a13929c06 Reviewed-on: https://gerrit.libreoffice.org/83999 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-29make some function symbols module privateNoel Grandin
improve the script to filter out more noise generated by library symbols Change-Id: I22bf6037d56bc4015001825c3fb3b21a39d85e07 Reviewed-on: https://gerrit.libreoffice.org/84022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-28sw: fix asserts from SwSubFont::GetTextSize_() on ooo54042-1.docMichael Stahl
The function gets passed a single CH_TXT_ATR_FIELDSTART but it looks like this is a problem in SwTextNode::GetMinMaxSize(). That one should just skip over the CH_TXT_ATR_FIELD* basically, since it's only interested in the text; also CH_TXT_ATR_INPUTFIELD* while at it. Also adapt the SwTextFrame::GetScalingOfSelectedText(), as indicated by the comment. Change-Id: Idf24e84f000406d265e73441de643b022c0b3cff Reviewed-on: https://gerrit.libreoffice.org/83997 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-11-28jsdialogs: send graphic items updatesSzymon Kłos
Change-Id: I57d05726f80115b92e7599a7d033bf1ea8f79695 Reviewed-on: https://gerrit.libreoffice.org/83955 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-28jsdialogs: share the commands updates sending codeSzymon Kłos
Change-Id: I34c1e03a8f92efe0c0dd391d16ff907919e65b00 Reviewed-on: https://gerrit.libreoffice.org/83748 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 880ff26edff0f7dfdd0d5b74fd9d7026fd2d8523) Reviewed-on: https://gerrit.libreoffice.org/83954 Tested-by: Jenkins
2019-11-28tdf#128898 import text from file with text-decode failedNoel Grandin
regression from commit 8f6f9e4217d03d874fb1ce391730a1c893ab6844 tdf#127958 crash adding 2 or more files into writer master document just make SfxMedium use shared_ptr, rather than the sometimes yes, sometimes no, ownership. Change-Id: I77559e9f766d84aca0f9dc0bd1b856c69f0f62f1 Reviewed-on: https://gerrit.libreoffice.org/83930 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-27tdf#128782: sw: assign name to draw objectVasily Melenchuk
SwXDrawPage is inserting frame styles without name. This is confusing undo/redo code which is operating styles by names. Change-Id: Ibcda01fbd3ec88e9cdbde446c3f18c7ad6b0cbc8 Reviewed-on: https://gerrit.libreoffice.org/83415 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-11-27jsdialog: send generic fill items also in writer and impressSzymon Kłos
Change-Id: I656ee47fff4e43f77caef62c071a5aa3b867f444 Reviewed-on: https://gerrit.libreoffice.org/83945 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-27Related: tdf#128611 RTF import: handle vertical flip of line shapesMiklos Vajna
UI uses SdrEditView::MirrorMarkedObjVertical() to flip a line shape vertically, handle it similarly at import time as well. Also note that this flips in-place, while the naive '*= -1' for the height would have an incorrect vertical position. Change-Id: I42b7feb5f799b99337ddec734dcf98dd1d553755 Reviewed-on: https://gerrit.libreoffice.org/83929 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-27jsdialogs: send .uno:FillStyle updatesSzymon Kłos
Change-Id: I31eab196466b380d1121dece59e9c19f8380fb9b Reviewed-on: https://gerrit.libreoffice.org/83366 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/83777 Tested-by: Jenkins
2019-11-27tdf#115630 tdf#88922 Chart: fix custom legend position and sizeBalazs Varga
Do not need to set the "AnchorPosition" value, when we move the legend object. It is enough to set only the "Expansion" as custom, so we keep the previously set "AnchorPosition" value and we can use the lcl_calculatePositionAndRemainingSpace function to calculate the remaining space of the inner chart area. Change-Id: I7b577bc6acf2de9b6755329b92603ea5ba631d57 Reviewed-on: https://gerrit.libreoffice.org/83399 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-11-27tdf#118947 sw tablestyle: manually scan parents for ::SETJustin Luth
...since we do not want to find DocDefaults or pool defaults. This patch mainly does two things. 1.) Since DocDefaults get merged into root-level styles, this patch identifies these DocDefaults as values that can be overwritten by table style properties. 2.) Some properties (like left/right margins) are paired together, so if one is SET, the other is also initialized and reported as SET. These are identified, and followed to see if they actually inherit from pool defaults. Change-Id: I4291c77073858ae23360a9f34d3650bfd5df86ca Reviewed-on: https://gerrit.libreoffice.org/81413 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-27tdf#108642 load accessibility children fasterNoel Grandin
Reduces the cost of repeatedly iterating over the page objects, by adding a new XAccessibleContext3 interface to return accesibility children in one call. This takes the load time from 5.6s to 3.2s. Change-Id: Ifcc20fa7e7ab8ad50417073882c8c3a2405d1eaa Reviewed-on: https://gerrit.libreoffice.org/83850 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-27partial revert tdf#127316 for rtfexport: restore ++nPropJustin Luth
Because the nProp is multiplied by 100, adding +1 can have special meaning, as also noted in editeng/impedit4.cxx. This is an interesting hack, where _nProp_ is used to determine if _nEsc_ should be automatic. It was dumb of me to even consider getting rid of it just because I didn't understand it. So revert that part of the change. Change-Id: Ibae5a84c369474f00702614ac5eecdc533aea914 Reviewed-on: https://gerrit.libreoffice.org/83846 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-11-27Remove unused WW8_FFN_Ver8Stephan Bergmann
unused since bb494d6bd8c5868f34bd8f9444ed3eb401145f10 "check font and list lengths" (found by upcoming loplugin:unusedmember) Change-Id: I985e8efe4892a28c78e80750cf9957fb02b00fb8 Reviewed-on: https://gerrit.libreoffice.org/83830 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-27Unused bitfields don't need a nameStephan Bergmann
(found by upcoming loplugin:unusedmember) Change-Id: I1ca74aa2f4758c34fc1eb25f06615c1001933a39 Reviewed-on: https://gerrit.libreoffice.org/83829 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-27struct GlobalNameIds doesn't need a nameStephan Bergmann
(found by upcoming loplugin:unusedmember) Change-Id: I3ee03d5c98e5f4de1891852ab07af999911d3e8a Reviewed-on: https://gerrit.libreoffice.org/83828 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-27tdf#108642 remove dynamic_castNoel Grandin
use virtual method instead. Takes the opening time from 10.5s to 9.2s for me. Change-Id: I015c05b112dd7e8b7ea3ef722e082d25a3062cce Reviewed-on: https://gerrit.libreoffice.org/83847 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-27tdf#109425 NB accessibility event fixandreas kainz
Change-Id: I246189a0de364a1a0a5e2dc902fa3804762fe389 Reviewed-on: https://gerrit.libreoffice.org/83626 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-27tdf#76586 fix table width of auto-width nested tablesLászló Németh
when they have (sometimes incorrect) fixed cell widths. Change-Id: I98bf37bfce72b84eed14e354520e4741ae2ddada Reviewed-on: https://gerrit.libreoffice.org/83787 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-11-27tdf#108642 simplify comparison data calculationNoel Grandin
Complex table-based writer doc with sidebar slow to open. We are only using the extent data in SwAccessibleTableData_Impl as a comparison method to see if that table structure has changed. So just compare the rows and columns arrays instead of calculating extents. The downside is that we might fire events a little more often. This takes the opening time from 17s to 10s for me. Change-Id: I936cbc01072345d6360c0ec162de20b3111a588e Reviewed-on: https://gerrit.libreoffice.org/83682 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-16 03:52:40 +0000