summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2016-06-22sw: fix loplugin:defaultparamsMiklos Vajna
Change-Id: I017c0107f421590bc61c4b1b7f3df458dd0b18f9
2016-06-22Remove no longer needed ImpEditView::mpLibreOfficeKitSearchableMiklos Vajna
All clients has been ported to use ImpEditView::mpLibreOfficeKitViewCallable instead. Change-Id: I3a2513ac5900f801a2e7aec79807f4e333dfba3d Reviewed-on: https://gerrit.libreoffice.org/26561 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-21sw: replace pointless XComponent and XTextContent overridesMichael Stahl
... from SwXTextGraphicObject and SwXTextEmbeddedObject. Change-Id: I22c2937617b84262c124d2504a8f9d889895005b
2016-06-21sw: use ImplInheritanceHelper for SwXTextGraphicObjectMichael Stahl
... and SwXTextEmbeddedObjectBaseClass, and get rid of pointless manual overriding of XInterface and XTypeProvider. Change-Id: I6695d825b5caba08aca9764eb3052eab77ee6fdb
2016-06-21Added Test for tdf#72788 clear direct formattingVarun Dhall
Change-Id: I9732691cb71272d690b800316a87c06b96eb7b05 Reviewed-on: https://gerrit.libreoffice.org/26529 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-21sw: add LOK_CALLBACK_TEXT_VIEW_SELECTION testcaseMiklos Vajna
Fails with 9f66db9c474f71f43d7a3667230241fd4fa4183f (sw lok: add LOK_CALLBACK_TEXT_VIEW_SELECTION, 2016-06-21) reverted. Change-Id: Ide21167ce2dc4287b1860b5f03a6975dc9edd4c6 Reviewed-on: https://gerrit.libreoffice.org/26550 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-21sw lok: add LOK_CALLBACK_TEXT_VIEW_SELECTIONMiklos Vajna
So a view can be aware where selections of other views are. Change-Id: I5026b1ff2b99a4eedfd0bde32a05ceb8e2f424bc Reviewed-on: https://gerrit.libreoffice.org/26542 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-21Remove no longer needed vcl::ITiledRenderable::registerCallback()Miklos Vajna
All clients has been changed to use SfxViewShell::registerLibreOfficeKitViewCallback() instead. Change-Id: I2538268dc9c4b449f68b5d2b05a72de584c29fd0 Reviewed-on: https://gerrit.libreoffice.org/26540 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-21sfx2 lok: fix missing view cursors in a new viewMiklos Vajna
When a new view was created, the old views got the position of the new view, but not the other way around. Make sure that the old views notify the new one right after registering the callback. Change-Id: If26edbd57aa939e453d95f4907a0e5722329dd65 Reviewed-on: https://gerrit.libreoffice.org/26523 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-20Add MS binary format validation in writer export testsVasily Melenchuk
Validation is done with Microsoft Office Binary File Format Validator if it is enabled. Since currently all doc files are not passing validation, they are included into validation blacklist. Change-Id: Ia36c5c9f2248122b13401a6d2834b729dbb75d6c Reviewed-on: https://gerrit.libreoffice.org/26422 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-06-20Remove no longer needed SdrModel::libreOfficeKitCallback()Miklos Vajna
All former clients are changed to call SfxViewShell::libreOfficeKitViewCallback() instead. Change-Id: Ic5dcf0a8a4241338fcd6941f13ce438157676481 Reviewed-on: https://gerrit.libreoffice.org/26521 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-20sw lok: add LOK_CALLBACK_INVALIDATE_VIEW_CURSORMiklos Vajna
So a view can be aware where cursors of other views are. Change-Id: I6133fb55aa2869843c0284b7d76264bab3b3d5da Reviewed-on: https://gerrit.libreoffice.org/26513 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-20GSoC Table Styles, Export Cell StylesJakub Trzebiatowski
Exporting cell-styles Exporting table-template To be able to map SwTableAutoFormat to table-template 1:1 extended table-template by the following elements: loext:first-row-even-column loext:last-row-even-column loext:first-row-end-column loext:first-row-start-column loext:last-row-end-column loext:last-row-start-column Added attributes describing box format to SwXTextCellStyle Change-Id: I2967ba461dfc6f030c1e5cdbba62e2673d3b232b Reviewed-on: https://gerrit.libreoffice.org/26185 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-20sw: prefix members of SwWriteTableMiklos Vajna
Change-Id: I4e8885b9fd85fdecec4f936c3c306887f1964c4b Reviewed-on: https://gerrit.libreoffice.org/26498 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-20tdf#95797: Don't jump to the cursor position after auto-save.Jan Holesovsky
Apparently the commit 07c7c88bc2d9d860ea92ab562ea0431ec1949b29 changed the condition; I suppose that not deliberately. Big thanks to raal for the bisect! Change-Id: I775e133396ceb763e31aca101d365880652e1ac8
2016-06-20tdf#90834 Turn in-line version controlapurvapriyadarshi
Some unnecessary comments removed Change-Id: I01b90f760106819e2c5d065e0bb32d5f132ae33c Reviewed-on: https://gerrit.libreoffice.org/26462 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-19loplugin:salbool: Implicit conversions from non-Boolean fundamental typesStephan Bergmann
Change-Id: I67eac95686678e6f5a2d60798535b2c65a9ba5d7
2016-06-18uitest: loplugin:implicitboolconversionMarkus Mohrhard
Change-Id: Id852960cdfd49331251e89306a6a32eb9e45a666
2016-06-18uitest: support selecting writer textMarkus Mohrhard
Change-Id: I6d1c4e5a05bdcb3299af86a9044d912239659fb9
2016-06-18uitest: add more properties to writer stateMarkus Mohrhard
Change-Id: Iadf223b38d84c1a6fb9892642f39e63dd16c72c8
2016-06-18uitest: provide a way to jump at the beginning of pageMarkus Mohrhard
Note that page numbers in writer are 1-based Change-Id: I614ff08927b4cb92d3819b557ec6791199da69a4
2016-06-18uitest: provide information about current pageMarkus Mohrhard
Change-Id: Ie0ef65a023e156f65370e11f024fa6349841841e
2016-06-18uitest: forward unhandled actions to the base classMarkus Mohrhard
Change-Id: Iac08e77d9b0e80f2af93c8b229d083603f1d22d4
2016-06-18uitest: add wrapper for writer's main edit windowMarkus Mohrhard
Change-Id: Ibd6ffe85ca95cdc915f5c73b1b566de1d7413ee7
2016-06-18uitest: set id for main writer edit windowMarkus Mohrhard
Change-Id: Ie039b9983dd2aa6ec2c79b35bfd87161a57438b5
2016-06-17tdf#83830: Page Header Panel & Page Footer PanelSusobhan Ghosh
Change-Id: Ic927bd52949f1bd196bec0efd3d49f9bb2841bd6 Reviewed-on: https://gerrit.libreoffice.org/25781 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-17tdf#91781 Move bookmark and cross-reference to root insert menuYousuf Philips
Change-Id: I06485c07e6c6fd3621fdfc99b7176107bb0ee999 Reviewed-on: https://gerrit.libreoffice.org/26418 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2016-06-17comphelper lok: remove the g_bViewCallback globalMiklos Vajna
Its purpose was to allow incrementally migrate all callers of SdrModel::libreOfficeKitCallback() to use SfxViewShell::libreOfficeKitViewCallback() (which allows notifying only the currently active or all views) instead. That is done by now, so it can go. Change-Id: I521bbbe5c638dfd844ebf025153459a37362d3c3 Reviewed-on: https://gerrit.libreoffice.org/26413 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-17GSoC Table Styles, Add TableStyle propertiesJakub Trzebiatowski
Added properties for the following odf attributes: table:first-row-end-column table:first-row-start-column table:last-row-end-column table:last-row-start-column Change-Id: Iac140e00a3439740623649ea234504f08146aaf3 Reviewed-on: https://gerrit.libreoffice.org/26359 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-17sw: speed up the navigatorMichael Stahl
The call to SwTextBoxHelper::findTextBoxes() in SwDoc::GetFlyNum() made this so unbelievably slow that in a dbgutil build opening the navigator on the bugdoc of tdf#94212 the UI freezes because getting all the fly frames takes longer than the 1 second timeout. Lets's not retrieve the flys one by one but instead all at once, which makes it usable again. Change-Id: Ic41c1648a82dcc3f758ae1b08bac6058f541f25e
2016-06-17Resolves: tdf#100421, don't crash on deleting particular tableCaolán McNamara
Change-Id: I52a4cf0732240aa26147313ae6a52c4fd8d8933c
2016-06-17Related: tdf#100421 crash in a11y on load of source odtCaolán McNamara
stldebug assert because end is before start and we can'g get to start from end in a std::set Change-Id: I0471220d3940e08b564f88841703a539aaf369d6
2016-06-17GSoC Table Styles, TableStyle isInUse, isUserDefined, mutex fixesJakub Trzebiatowski
Also added: + SwXTextCellStyle::IsInUse() + check_styles.py SwXTextTableStyle::isUserDefined() tests Change-Id: I76cb166107f186098599c4a8da6f94f7c40cc545 Reviewed-on: https://gerrit.libreoffice.org/26366 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-17More efficient OUString concatanation in LineNumberingDialogMuhammet Kara
According to https://goo.gl/jsVAwy: All the other alternatives, like explicit OUStringBuffer and repeated append() should be now worse in all possible aspects. In fact, this should result in just one OUString allocation, one data copy for anything and at most one length computation, so it should possibly beat even strcpy+strcat, while at the same time looking good. Change-Id: I23bf5b5a0b8d79b2d8995700eefc20ab3fb6f79c Reviewed-on: https://gerrit.libreoffice.org/26386 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-17sw: fix crash on pasting from an already closed documentMiklos Vajna
As pointed out by <http://crashreport.libreoffice.org/stats/signature/%60anonymous%20namespace'::lcl_checkClassification%28SwDoc%20*,SwDoc%20*%29+0x0>. Thanks to Michael Stahl for figuring out the list of steps to reproduce this bug: 1) Create a new Writer document 2) Type some text 3) Select all 4) Copy it 5) Close the document 6) Create a second Writer document 7) Paste -> crash Change-Id: I8cfcad465803e37ec9d01d035428c5ca953adf14 Reviewed-on: https://gerrit.libreoffice.org/26380 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-16Ensure updated accessible names in SwSortDlg ctorMuhammet Kara
Set accessible names after the conditional block because text of m_pColLbl may be changed Change-Id: I2902fd346384be2c9ffa471c71ad94cacede7d14 Reviewed-on: https://gerrit.libreoffice.org/26352 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-16comphelper: enable LibreOfficeKit::isViewCallback() by defaultMiklos Vajna
This requires porting the sw/sd/sc_tiledrendering test code to the new internal API, as only the public LOK API is unchanged. Change-Id: Ic6a2f96421da4a16bdee7d0cbb3f6e35bc6ddff9 Reviewed-on: https://gerrit.libreoffice.org/26379 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-16sw lok: move filtering of callbacks during paint to desktopMiklos Vajna
This will be important when in the per-view case SwViewShell::libreOfficeKitCallback() won't be called anymore; as pointed out by online.git's TileCacheTests::testSimpleCombine() test. Change-Id: Ie68f8c51facdba127763df660e9220f820805ecc Reviewed-on: https://gerrit.libreoffice.org/26372 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-16Resolves: tdf#100422 crash if you exit mail merge wizard...Caolán McNamara
after loading previous document or template Change-Id: I3bdd1159e367b0297aee84763bf5c4312e9e91fa
2016-06-16Fix comments: Headinline -> HeadingSamuel Mehrbrodt
Change-Id: Ib904016501afe4c519793bff6127109508529733 Reviewed-on: https://gerrit.libreoffice.org/26363 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-16tdf#91684 RTF import: handle fFlipH and fFlipV shape propsMiklos Vajna
Change-Id: I930f99647de00c2e43ef94b1ac0320daa440eae9 Reviewed-on: https://gerrit.libreoffice.org/26349 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-16Remove the :: prefix in ::std for swMark Page
This patch was created using a script Variable name textual alignment is preserved to the same level Change-Id: I6b4858f8059b8cf71fc253e87d6df634362d62e9 Reviewed-on: https://gerrit.libreoffice.org/26306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-15tdf#98797 sw: try to fix crash in SwMailDispatcherListener_ImplMichael Stahl
Commit c48df7ad7d49ac093058ceb28d6d3f272f6e2e07 added a isDisposed() call in SwMailDispatcherListener_Impl::idle() and i can't see why that would not be necessary in the other functions that access m_pSendMailDialog if it is necessary in idle() - it's not obvious *why* it would be necessary in idle() in the first place but obviously i don't understand when SwSendMailDialog::dispose() is invoked (which is what deletes m_pStatus, dereferencing which the backtrace crashes). There is code in SwSendMailDialog::dispose() to handle the case that the xMailDispatcher thread is still running, and stop it without joining, which would obviously trigger this crash if it were ever executed. (Maybe i should actually try what happens at runtime, but these mail-merge dialogs are all scarily confusing.) Change-Id: I550f6107b064b0c97f3d33bed5bd3830fa2e86f4
2016-06-15Move accessibility relations to .ui files, Part 9: tdf#87026Muhammet Kara
By removing unnecessary variables/strings/function calls, and making proper changes in the related .ui files. Change-Id: I52e3f2a16519aee13b06f0efc6beb3385bcb0f1c Reviewed-on: https://gerrit.libreoffice.org/26066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-15sfx2: bring the view shell's LOK callback up to date with SdrModelMiklos Vajna
This fixes CppunitTest_sw_tiledrendering in the LOK_VIEW_CALLBACK=1 case. Change-Id: Ib79e57908c3edda0154341baba8279ede4281a42 Reviewed-on: https://gerrit.libreoffice.org/26313 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-15tdf#100105 sw: RTF export: fix empty hyperlinksMichael Stahl
For empty hyperlinks the EndURL() is called immediately after StartURL() Due to the way the various buffers are written, the group closing braces are written before the groups are opened, which is rather invalid. Using the m_aRun buffer instead of m_aStyles appears to fix the problem. (regression from b8907bf3d3b37c686a414ffbbd2d732348aab5b9) Change-Id: I6910e1afa0ee262ae0496cf1d3aa83ae3e537ad0
2016-06-15tdf#61396 Possibility to edit a template not in Template RepositoryAkshay Deep
Menu Sequence: Open Template... Save as Template... ---------------------- Manage Templates Change-Id: I0d0c8ca15d8dc38662e7f84a4f598933c13dd512 Reviewed-on: https://gerrit.libreoffice.org/26179 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-15Remove unused SwMiscConfig instanceStephan Bergmann
Unused ever since it was introduced in 5d7ce6db70b362b9f69aee2aaf651cbddcf35b84 "INTEGRATION: CWS swmailmerge", and access to any SwMiscConfig members has always been done indirectly via SW_MOD()->GetModuleConfig()->..., so looks like aMiscConfig is unnecessary (and Oliver agrees with me on that). Change-Id: I98b1962a43ba969cdadf1e42fdb1d3522ae4bc35
2016-06-15tdf#42949: clean up includes in include/filter with iwyuJorenz Paragas
Change-Id: Id08a999764bfeeff3bb3409b46f48b278009ccbe Reviewed-on: https://gerrit.libreoffice.org/26238 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-15tdf#100275 sw: fix target node of bookmark copyMichael Stahl
Replaces the defensive programming band-aid of 5c1a1d1c66aff497702abc20df5832fa348f1008 with a real fix. The problem is that lcl_NonCopyCount() has some special case code to ignore the first node in the target document, which erroneously is executed for every bookmark, which results in the 2 bookmarks in the bugdoc being created with nDelCount 1 and 2 so they land on the same node, which is not allowed for cross-reference marks. Extract the adjustment into a separate function that is called once. (regression from 689962feae2054f965a7378c3408b0ccfad2bbd5) Change-Id: Ie14c650f7fdb259c13cb9048226da30971d2ab3c
generated by cgit (git 2.34.1) at 2025-02-27 18:43:56 +0000