summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2019-11-08tdf#128504 save DOCX as ODT: don't color not highlighted hyperlinksTünde Tóth
During DOCX import, not highlighted hyperlinks, ie. without hyperlink character styles, set the Visited/Unvisited character style text attributes to "Default Style" to avoid saving them with the default highlighted hyperlink character styles in ODT. Regression from the commit 576611895e51186d38ddefa10ed8d66075d9de37 "tdf#127741 DOCX import: format hyperlink with Default character style". Change-Id: I5ffbb107e6704b285bc3d1546e08a324c386a0ab Reviewed-on: https://gerrit.libreoffice.org/82205 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-11-08Missing include (Windows --disable-pch)Stephan Bergmann
> sw/source/core/doc/docfld.cxx(558,18): error: member access into incomplete type 'const ::utl::TransliterationWrapper' > if( rSCmp.isEqual( rDBName, sName.getToken(0, ';') ) ) > ^ Change-Id: I041879acb350a2bc42133f55be5a1501ffe93c95 Reviewed-on: https://gerrit.libreoffice.org/82272 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-08loplugin:stringadd (clang-cl)Stephan Bergmann
Change-Id: Icf2894f77c90aa4620910d621249947bad4be8b7 Reviewed-on: https://gerrit.libreoffice.org/82269 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-08jsdialog: consume .uno:LineWidth double valueSzymon Kłos
Change-Id: Iaf09dd11ae4fd6b3d9ebeabac790f0cfe73fec17 Reviewed-on: https://gerrit.libreoffice.org/82226 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82234 Tested-by: Jenkins
2019-11-08Revert "tdf#120734 Only enable "Remove hyperlink" when hyperlink selected"Samuel Mehrbrodt
This reverts commit cae4b4951f061a67fab779493e6992d9097f4a4d. Change-Id: I06f6a828e2766058b90dde14e8efbe5759867084 Reviewed-on: https://gerrit.libreoffice.org/82228 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-11-08sw: no reason why SwModelTestBase can be used only by "extras" testsMiklos Vajna
So move it one level up, this way more tests can share code in the future. Change-Id: I35300b3c88ac9a5c39916f53b1b1743aa85869a0 Reviewed-on: https://gerrit.libreoffice.org/82252 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-08Bibliography .ui file update labels are right align for beter readandreas kainz
Change-Id: I6b7edb822896ab6d600ecd0d751e5adf53fa1fb9 Reviewed-on: https://gerrit.libreoffice.org/82258 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-08Writer Property Statistic Dialog updateandreas kainz
Change-Id: I1da8500ea12581b856b276247584a37e8f18f0aa Reviewed-on: https://gerrit.libreoffice.org/82259 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-08Bibliography Insert Dialog updateandreas kainz
Change-Id: I8b0eb23660aa15254d5a84eba4a045278a7c8152 Reviewed-on: https://gerrit.libreoffice.org/82255 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-07Avoid .uno: command names in the customization dialogMaxim Monastirsky
Change-Id: I37a510727dc2d5f8de1eb6ee5b60653e43ff0e4c Reviewed-on: https://gerrit.libreoffice.org/82230 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2019-11-07Related: tdf#128603 sw textbox: fix use-after-freeMiklos Vajna
lcl_RestoreAnchor() needs to decide if if wants to not copy the old anchor (and keep reading it via a reference) or it wants to update the item set, it can't do both at the same time. The reason for this is that the item set update works by deleting the old pool item and allocating a new one, it doesn't work by updating the old pool item. I believe this was always broken, but now sanitizers found the issue since the cppunit test for the above bug was added recently. Change-Id: Ic08d60eb522a62d78cb2b0ea6a4cda328f8fb80b Reviewed-on: https://gerrit.libreoffice.org/82245 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-07sw XHTML export: <blockquote> can't have character childrenMiklos Vajna
Fixes the following reqif-xhtml validation error: ERROR at 214: [XSD] cvc-complex-type.2.3: Element 'reqif-xhtml:blockquote' cannot have character [children], because the type's content type is element-only. But this is probably useful in the general xhtml case as well. [ Also add a way to not load a document when we want to cover "store" behavior in a test. ] Change-Id: I88795271475863b9560ac1cb99636c507746f1e9 Reviewed-on: https://gerrit.libreoffice.org/82239 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-07Looks like UBSan still needs various RTTI for some reasonStephan Bergmann
After 5d7af3c38b618d438e065da9d90668e7c4baa849 "make some classes module-private" various tests in my Linux ASan+UBSan build failed due to missing symbols. Identified the problematic types with > make check screenshot gb_SUPPRESS_TESTS=x && for i in $(find instdir/program workdir/LinkTarget/CppunitTest -type f); do LD_LIBRARY_PATH=${LD_LIBRARY_PATH:+$LD_LIBRARY_PATH:}instdir/program:workdir/UnpackedTarball/cppunit/src/cppunit/.libs ldd -r "$i" 2>/dev/null | grep 'undefined symbol: _ZTI'; done and fixed the ensuing > sw/source/core/SwNumberTree/SwNodeNum.cxx:190:32: error: dynamic_cast from 'SwNumberTreeNode' with hidden type visibility to 'SwNodeNum' with default type visibility [loplugin:dyncastvisibility] > SwNodeNum* pChild( dynamic_cast<SwNodeNum*>(pNode) ); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > sw/inc/SwNumberTree.hxx:114:7: note: base class 'SwNumberTreeNode' with hidden type visibility defined here [loplugin:dyncastvisibility] > class SwNumberTreeNode > ~~~~~~^~~~~~~~~~~~~~~~ > sw/inc/SwNodeNum.hxx:29:26: note: derived class 'SwNodeNum' with default type visibility defined here [loplugin:dyncastvisibility] > class SAL_DLLPUBLIC_RTTI SwNodeNum : public SwNumberTreeNode > ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fallout. Change-Id: I7abafdb4d02216e1a047f886d5e72ad3420115ce Reviewed-on: https://gerrit.libreoffice.org/82210 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-07tdf#109219 Allow files with spaces in name as MM data sourceMichael Weghorn
The filter needs to be the unescaped file name. Change-Id: I2b5337c184c1ce75595e129d5a87ed4d189ec1e7 Reviewed-on: https://gerrit.libreoffice.org/82201 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-07tdf#125778 docxexport: handle pageBreak before TOXJustin Luth
The pagebreak before the TOX was lost in docx (but not in .doc or .rtf). Change-Id: I280b0bd19a73db180b65a0937bd0fe809e5dfc6f Reviewed-on: https://gerrit.libreoffice.org/81979 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-07tdf#128603 sw textbox: restore shape+frame pair on undoMiklos Vajna
Undo of cut + paste restored both the shape and the frame, but the shape's content pointed to an invalid node index. Later this resulted in a crash. Make sure that in case the content of shape+frame don't match by the time the frame format pointer is set, we sync the draw format to the fly format. Change-Id: I233a504ca52698d1c514769d16c256408c29ae30 Reviewed-on: https://gerrit.libreoffice.org/82192 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-07Fix typo in codeAndrea Gelmini
Change-Id: I05657a97092a3d119d4a18535ba0f43d096530ca Reviewed-on: https://gerrit.libreoffice.org/82190 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-11-07Chapter Numbering Dialog width for numbering definedandreas kainz
Change-Id: I55b61de4476bad237c21b5472882924c69a47e61 Reviewed-on: https://gerrit.libreoffice.org/82187 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-07Linenumbering Dialog update for smaler widgetsandreas kainz
Change-Id: I7c483f95252e99cb4385801348ea3757703e8dac Reviewed-on: https://gerrit.libreoffice.org/82188 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-07sw: convert remaining uses of DECLARE_RTFIMPORT_TEST()Miklos Vajna
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: Icef8d75ac759480e841363142c474b95544bcf0e Reviewed-on: https://gerrit.libreoffice.org/82176 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-07android: ODR fix of RID_PAGEFORMATPANEL_MARGINS_CM.Jan Holesovsky
Without this, we get a linking error that RID_PAGEFORMATPANEL_MARGINS_CM is defined twice. Change-Id: Ib9c07adcb0a8def991d1e39429c1bb4947cd7d32 Reviewed-on: https://gerrit.libreoffice.org/82159 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-11-07Chapter Numbering Dialog updateandreas kainz
Change-Id: Id82145528ac7a9d991ca8e01d87081afea9981e7 Reviewed-on: https://gerrit.libreoffice.org/82184 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-07tdf#38199 Readonly mode tab key: Don't scroll if no hyperlink foundJim Raykowski
When viewing a document in readonly mode the action of the tab key is to move among Graphic, Frame, Ole, DrawObject, or DbForm if one these is already selected. If the cursor is inside an input field and has no multi selection then move among InputFields. Finally if neither the previous two cases apply then move among Hyperlinks which causes cursor position to move to top or bottom of the document when no Hyperlink is found. When no Hyperlink is found this patch restores the cursor position to the position before search and does not scroll to it on EndAction. Change-Id: I94ac882e7be124d2ddb6f86daac03a9389117cc5 Reviewed-on: https://gerrit.libreoffice.org/81955 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-11-07Linenumbering Dialog updateandreas kainz
Change-Id: Icbfdcc293bd9dd3a73b40330e359ac141f08f998 Reviewed-on: https://gerrit.libreoffice.org/82183 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-07Footnote/Endnote Settings Dialog update and sync between each otherandreas kainz
Change-Id: Ie04c9046ce8d00015ff020a7419a47c101f18430 Reviewed-on: https://gerrit.libreoffice.org/82182 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-06Insertfootnote Dialog alignment updateandreas kainz
Change-Id: I1a07821e22fd96ddf1f8b57a59173889e47aec35 Reviewed-on: https://gerrit.libreoffice.org/82181 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-06loplugin:unnecessaryvirtualNoel Grandin
Change-Id: Ibffbd0f5d30ec14cace3638b2bb47c91a583711c Reviewed-on: https://gerrit.libreoffice.org/82171 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06tdf#120412 better unit testJustin Luth
The previous unit test OUGHT to have reported exactly 100% escapement, and the patch's purpose was to support greater than 100% escapement. Depending on a number of patches (related to bug 99602), this unit test verifies that 400% works. Change-Id: I1ee36d1570c34d86dbfb0a03ee3c2026b9645b63 Reviewed-on: https://gerrit.libreoffice.org/80220 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-11-06convert SwXMLSectionList to FastParserNoel Grandin
Change-Id: I6bffd6891a4a90f986513a5385ef30c38f1a48c4 Reviewed-on: https://gerrit.libreoffice.org/82127 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06revert some module-private changesNoel Grandin
see comments at https://gerrit.libreoffice.org/#/c/82062 Change-Id: Ie128f2de770ca7c3156f63c6d4e981575a580668 Reviewed-on: https://gerrit.libreoffice.org/82135 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06tdf#121661 Add testSamuel Mehrbrodt
Change-Id: I0da9ab59bbfdb5d7dfb717ac2bcff3ac74686907 Reviewed-on: https://gerrit.libreoffice.org/82130 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-11-06convert ImportStoredChapterNumberingRules to XFastParserNoel Grandin
Change-Id: I80ceed4bf2e767b86aedd1dd7bf4f892e3077138 Reviewed-on: https://gerrit.libreoffice.org/82132 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06tdf#128593 fix crash on setting table background colorSzymon Kłos
Change-Id: I9596cd9817d63590f07ffd2068e79b2df5806aeb Reviewed-on: https://gerrit.libreoffice.org/82128 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-06tdf#99602 writerfilter: import subscript into character styleJustin Luth
and superscripts (aka escapements, but who knows that term). This isn't perfect, but I just fixed about 4 subscript bugs under much simpler conditions. Doing this completely compatibly with MS Word would be several magnitudes of order more difficult, since WORD works in absolute amounts (much easier to deal with) and LO works in relative percentages. Normally, the default auto settings make subscripts look the best anyway, so this should be a pretty good solution. Change-Id: Iefdc8ad55988d96ddbbba4701795a4f7a61b1521 Reviewed-on: https://gerrit.libreoffice.org/80219 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-06loplugin:unusedvariablecheck tweak to find more stuffNoel Grandin
but leave the tweak commented out, since it generates false positives Change-Id: Iaf3f92414d2618f8780561f98765e33e282afe0c Reviewed-on: https://gerrit.libreoffice.org/82121 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06tdf#121661 Roundtrip w:hyphenationZone via InteropGrabBagSamuel Mehrbrodt
Change-Id: I097afb54ff31bd1c878231b51eac5af9f27d35e9 Reviewed-on: https://gerrit.libreoffice.org/81880 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-11-06CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE()Miklos Vajna
Let's see if this causes any problems before doing a mass-conversion. Benefits are: - ctags can jump to the testcase if Writer-specific macros are not used - the Writer-specific macros just overcomplicate things for people not familiar with Writer Change-Id: Icc057a789acc220f5625461944dc6b8f35aad334 Reviewed-on: https://gerrit.libreoffice.org/82109 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-06make some classes module-privateNoel Grandin
Change-Id: I00ab3a3f6a8bbc85320e7b4fd1aa13af798e7e4c Reviewed-on: https://gerrit.libreoffice.org/82062 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06loplugin:indentation find broken if statementsNoel Grandin
so I don't read the "then" block as being a sequential statements Change-Id: Ib2004acd3518bd4ebd2246f02a26c2c0a8bbab4c Reviewed-on: https://gerrit.libreoffice.org/82069 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-05weld SwSyncChildWinCaolán McNamara
Change-Id: I23eef815ba05e07f50f86ec375c5dff3ef759d55 Reviewed-on: https://gerrit.libreoffice.org/81746 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-05tdf#127759 Writer: add table row/column insert modeLászló Németh
using enhanced table selection. When the table rows or columns are selected by enhanced table selection, ie. clicking in front of them, next Cut operation cuts the selected rows or columns completely without leaving empty cells. Pasting them results insertion before the actual row/column instead of overwriting the actual and the next rows/columns. This greatly speeds up moving table rows and columns, like in MSO. Change-Id: I6d82ca8aad4888ab37bdb9a89d37102763fcd6c6 Reviewed-on: https://gerrit.libreoffice.org/81503 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-11-05tdf#42949 Fix IWYU warnings in sw/source/core/d*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Id33b8c1e0c02c21591b167a8b3f0ea288fac63bd Reviewed-on: https://gerrit.libreoffice.org/81689 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-05tdf#128335 sw textbox: fix crash on deleting multiple shapes with textboxesMiklos Vajna
This was introduced in commit 33141f999b22ce10cdbfbd76081fff211c4b5067 (SwDrawView::DeleteMarked: delete textbox of shape as well, 2014-06-23), the problem is that in case one shape+textframe pair is anchored in an other textframe, which is also part of a shape+textframe pair, it matters what order we use for deleting these objects. What happened is that the anchor position of a 2nd textbox was updated on the deletion (cut) of the 1st textbox, and this was not properly restored on paste. Fix the problem by deleting in reverse order, assuming that the container is ordered by anchor positions. Change-Id: I62bc12a5064ce397234999e8fd7b108f79de3c24 Reviewed-on: https://gerrit.libreoffice.org/82042 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-04loplugin:finalclasses in sw/incNoel Grandin
Change-Id: I084502d8c5607f103ef987b54252ef95341f0bef Reviewed-on: https://gerrit.libreoffice.org/81981 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-04tdf#120315 DOCX import: fix cells merged verticallyBakos Attila
Due to rounding mistake cells weren't merged vertically, when their horizontal positions are different a little bit. Change-Id: I10623719a3759b35fcd04b154590b8ac6ec3ac45 Reviewed-on: https://gerrit.libreoffice.org/81604 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-11-04sw: remove dead SwFormatFollowTextFlow::mbLayoutInCellMiklos Vajna
Now that the UNO API doesn't write it and the layout doesn't read it. Change-Id: I0c9bb6aca8f3642f06cb25b9857738a751520702 Reviewed-on: https://gerrit.libreoffice.org/81980 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-03make some classes module-privateNoel Grandin
improve the script, but it still generates some false positives Change-Id: If8ee1cba8c04ac0be11f73220149e6de15f24f44 Reviewed-on: https://gerrit.libreoffice.org/81929 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-03loplugin:stringaddNoel Grandin
tweak the plugin to be more permissive, then validate by hand afterwards Change-Id: I40c5c911fe6ff7e45baaca372abf7dac211d9654 Reviewed-on: https://gerrit.libreoffice.org/81942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-03find symbols that can be privateNoel Grandin
update the script and make private standalone functions Change-Id: Icb26ce258107700c90f89ad4e0d3329d075a2eb1 Reviewed-on: https://gerrit.libreoffice.org/81879 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-02New loplugin:conditionalstringStephan Bergmann
Change-Id: I2eab990c15f845b44a3b598571aca361dadf9ff3 Reviewed-on: https://gerrit.libreoffice.org/81946 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-11 16:15:30 +0000