summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2019-09-01Fix '..'Andrea Gelmini
To complete this: https://gerrit.libreoffice.org/#/c/78312/ This is a massive replace for lines ending with ".." instead of "..." It passed "make check" on Linux. Change-Id: I07fa7b2e30ba9ea17a1f9a5e21c57216ba958efe Reviewed-on: https://gerrit.libreoffice.org/78356 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-08-31drop some unnecessary includesCaolán McNamara
Change-Id: I004b920e5eab5a848f30842c72399d96a6c033d5 Reviewed-on: https://gerrit.libreoffice.org/78349 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-31drop some unnecessary includesCaolán McNamara
Change-Id: I1abef2c2318e83aa8045d2b4763e74f45b4755e5 Reviewed-on: https://gerrit.libreoffice.org/78347 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-31drop some unnecessary includesCaolán McNamara
Change-Id: I4cbfe7e0d31217cf7790f656156a7e9a58b4e82f Reviewed-on: https://gerrit.libreoffice.org/78344 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-31drop some unnecessary includesCaolán McNamara
Change-Id: Ic3ccc7f0e93258cce30a42c71011154bc9313f52 Reviewed-on: https://gerrit.libreoffice.org/78343 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-31Remove .. from READMESamuel Mehrbrodt
Change-Id: I6f4a93fbcd48bac7246929ab8afcbc1c0f8e5d83 Reviewed-on: https://gerrit.libreoffice.org/78312 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-08-31sw sd lok: Don't enter the OLE editing mode right after inserting a chart.Jan Holesovsky
Turns out that it is confusing for the users that they can edit the properties of the chart rather than its position just after inserting it in the browser. Let's change it accordingly. When the user wants to edit the chart itself, they have to double-click. Calc is not handled in this patch. Change-Id: If5661b843a06ebaeb8d4cd1b2c469aeedda4257e Reviewed-on: https://gerrit.libreoffice.org/78318 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-30SwAutoFormat::HasObjects() could be fasterMichael Stahl
Change-Id: I928401382ca986fb75de3689b9ef5e08474e2b85 Reviewed-on: https://gerrit.libreoffice.org/78278 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-30new loplugin:noexceptmoveNoel Grandin
idea from mike kaganski look for places where we can mark move operators as noexcept, which makes some STL operations more efficient Change-Id: Id732b89d1fcadd5ceb0ea2b9d159fed06136330f Reviewed-on: https://gerrit.libreoffice.org/78251 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-29related tdf#81345: make unit test robust - check last pageJustin Luth
On KDE Neon 18.04, something was causing page 1 to spill over onto page 2. Checking the last page instead of the second one is fine for testing the problem solved for bug 81345. Confirmed with bibisect53 that same header/page style had been used for the whole document originally. Change-Id: Id85562153d7ce1d570806a611f11d33fa5b83c87 Reviewed-on: https://gerrit.libreoffice.org/78250 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-28tdf#118169: ActiveX form control saved incorrectly with accented lettersTamás Zolnai
Write out unicode strings without any compression. Change-Id: I93cadc40bacbd679724c3404fd870cba48065650 Reviewed-on: https://gerrit.libreoffice.org/78234 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-08-28Avoid dynamic_cast in AttributeOutputBase::ConvertURLMike Kaganski
This unifies the code for any format using the function. Note: RTF code currently doesn't use the function, so an empty string is used in its ctor. Change-Id: I8776c095d4527313d06b0620059a892a48a9eaa1 Reviewed-on: https://gerrit.libreoffice.org/78229 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-28sw lok: extend language status with BCP 47 language tag info in here as wellMiklos Vajna
This brings Writer in sync with Calc, which does this since commit 47025060e4474d23e3bd97053a77b3943eeae724 (Send Bcp47 codes with region, 2019-08-28). Change-Id: I615af4a0692216f794c78955d337e6b8dbc8db5e Reviewed-on: https://gerrit.libreoffice.org/78230 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-28Simplify code removing the last segment from a URLStephan Bergmann
This code had been introduced with 2b2f1352c72280dd25ed3bef090a3c708ee4b964 "tdf#86087 Save relative links in DOCX", but it is not clear to me what part of <https://bugs.documentfoundation.org/show_bug.cgi?id=86087> "FILESAVE FILEOPEN VIEWING: Can't open or save relative links in docx" it is meant to address. None of the tests in `make check` trigger the > else > { > // DOC > WW8Export* pWW8Export = dynamic_cast<WW8Export*>(&GetExport()); > if ( pWW8Export ) > { > SwWW8Writer& rWriter = pWW8Export->GetWriter(); > sExportedDocumentURL = rWriter.GetMedia()->GetURLObject().GetPath(); > } > } block. But what the code presumably wants to do is to create, for the DOC case, an anAbsoluteParent that is rWriter.GetMedia()->GetURLObject() with the final URL path segment removed: INetURLObject::GetPath returns the "dirname" part of a file URL's path (i.e., everything but the last path segment), and with a trailing slash removed, in the form of a filesystem pathname. That means that > INetURLObject anAbsoluteParent( sExportedDocumentURL ); creates an invalid anAbsoluteParent (because the input is not a URL), so > if ( anAbsoluteParent.GetURLPath().isEmpty() ) is true (but why not use a more obvious check of anAbsoluteParent.HasError(), or should this code also be relevant for the DOCX case?), so the following block > { > // DOC filter returns system path (without file:///) > anAbsoluteParent.setFSysPath( sExportedDocumentURL, FSysStyle::Detect ); > anAbsoluteParent.setFinalSlash(); > } recreated the URL from the filesystem pathname and added back the trailing slash. Change-Id: I9346a23680a65b6fd1ba0fa33f4565df50bd9e51 Reviewed-on: https://gerrit.libreoffice.org/78210 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-28sw: prefix members of SwUndoFlyBaseMiklos Vajna
See tdf#94879 for motivation. Change-Id: I266ba820629ec6f8505d091fb6090ed8626b4742 Reviewed-on: https://gerrit.libreoffice.org/78211 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-28GtkWidget for the priority of extension under Extension Tab.Sumit Chauhan
The new structure : PriorityMergedHBox --OptionalBox --ToolBoxExtension --Extension1 --OptionalBox ..... Change-Id: I72760e4f0d60eb6f1f82c1e928601d41a2e4b6ce Reviewed-on: https://gerrit.libreoffice.org/76987 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-08-27loplugin:referencecasting find more redundant static_castNoel Grandin
Change-Id: I3a51812bbd3fcdc6b11e47cb12962f0d4fa7a2ae Reviewed-on: https://gerrit.libreoffice.org/78191 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-27use SdrCircKind enum more widelyNoel Grandin
and make it a scoped enum Change-Id: I6325ff86ff8566135f6d01a576c659539dcb3ed9 Reviewed-on: https://gerrit.libreoffice.org/78176 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-27"HyperLinkURL" already is a URL hereStephan Bergmann
...at least in all cases encountered during CppunitTest_sw_ooxmllinks, so why bother going via an assumed filesystem pathname? (Rather, add some CPPUNIT_ASSERT to clarify expectations.) This code had originally been added with 2b2f1352c72280dd25ed3bef090a3c708ee4b964 "tdf#86087 Save relative links in DOCX". Change-Id: I03e4389338e5549ad3a530bed054a17518f21c96 Reviewed-on: https://gerrit.libreoffice.org/78196 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-27Use a direct way to get at the temp dirStephan Bergmann
...in code originally added with 2b2f1352c72280dd25ed3bef090a3c708ee4b964 "tdf#86087 Save relative links in DOCX", by introducing utl::TempFile::GetTempNameBaseDirectory Change-Id: Ic0e8b54896a3829c081255404ef92b96f1724a2a Reviewed-on: https://gerrit.libreoffice.org/78174 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-27tdf#107776 sw ODF shape import: make is-textbox check more strictMiklos Vajna
Regression from commit 9835a5823e0f559aabbc0e15ea126c82229c4bc7 (sw textboxes: reimplement ODF import/export, 2014-10-04), the problem was that we assumed graphic autostyles look like: <style:style style:name="gr2" style:family="graphic"> for simple (non-text-box) content, and look like: <style:style style:name="gr1" style:family="graphic" style:parent-style-name="Frame"> for complex (text-box) content. Turns out it's valid to have other parent styles as well, e.g. Graphics, which should not be imported as sw textboxes. With this, the arrow at the bottom of page 3 of the bugdoc is now again on top of the image, i.e. layout compatibility is restored. Change-Id: Icbba8a23c5f66e63090f90e6581ebc98948cb80b Reviewed-on: https://gerrit.libreoffice.org/78155 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-27Fix old boost build for goodTomáš Chvátal
With the previous approach the code could lead to crashes in the flowfrm.cxx Change-Id: I3b56ed46db9d37a606a1cd793a20b8aff22db6e2 Reviewed-on: https://gerrit.libreoffice.org/78003 Reviewed-by: Tomáš Chvátal <tchvatal@suse.com> Tested-by: Tomáš Chvátal <tchvatal@suse.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-26lok: change table border position param. from new pos. to offsetTomaž Vajngerl
To implement table border position changing for Impress requires that instead of parameter with new absolute position, we use offset from the previous position. It's easy to change the code for Writer to do this instead of Impress so this commit does this. Change-Id: I2d3ebe5ba0dc30fb8b4a58cc9ca820cc8330204b Reviewed-on: https://gerrit.libreoffice.org/78121 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-08-26fix impress crash in shape listenerNoel Grandin
after commit ec940941e0bd7db15c5cf7d43df82226e0d849dc Date: Tue Aug 20 17:03:13 2019 +0200 tdf#119388 add new UNO listener/broadcaster grumble grumble stoopid AccessiblePageShape that overrides AccessibleShape but doesn't actually set any shape on it. Also, there appear to multiple copies of something listening to the same shape somewhere, but I didn't track that further. Change-Id: I78713716788dd99b1f56519d960b43e5538c1304 Reviewed-on: https://gerrit.libreoffice.org/78120 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-26tdf#127163: Add AutoRedactDoc command to the Tools menuMuhammet Kara
Change-Id: I3a1081c29c222bf868a853ff19d471881fb43ce7 Reviewed-on: https://gerrit.libreoffice.org/78141 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-08-26enum SvLBoxButtonKind is effectively unusedNoel Grandin
since commit e569b9d40eb02f53a3f13024af4ab1dc9ca7634a Date: Tue Jul 30 17:07:41 2019 +0100 weld OfaMSFilterTabPage2 Change-Id: If8777180aec04336eda08c75bbee400de2ccb43b Reviewed-on: https://gerrit.libreoffice.org/78136 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-26tdf#42949 Fix IWYU warnings in sw/source/core/[a-c]*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I1c68650bb93f918d7ff38491ffedf9af96d80b52 Reviewed-on: https://gerrit.libreoffice.org/78083 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-26tdf#105485 DOCX: import deleted comments as deletedLászló Németh
in tracked deletions, instead of importing them as normal comments of the actual text content, ie. showing them in the Hide Changes mode, too, without crossing out. Change-Id: I7f84d2e9f2dd280bbca2236b40bab83b94d40c68 Reviewed-on: https://gerrit.libreoffice.org/78018 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-08-25cid#1452762 Uninitialized pointer fieldCaolán McNamara
Change-Id: Ib1d7637254e12971d45047680b5d5345f8c30be8 Reviewed-on: https://gerrit.libreoffice.org/78066 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-24loplugin:returnconstval in swNoel Grandin
Change-Id: I15d8553bff7528f690ff92bee75d6a67037c0adf Reviewed-on: https://gerrit.libreoffice.org/78062 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-24tdf#123703 strip six-em-space (U+2006) at line breakLászló Németh
as normal (' ') and ideographic (U+3000) spaces to get the same layout in justified paragraphs, too, with the previous RTF import fix. Note: this can be useful for manual kerning fixes during editing, too. Change-Id: I7c031b7d79a8703e4821da91fc60a752a1d15788 Reviewed-on: https://gerrit.libreoffice.org/77367 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-08-24tdf#123703 RTF import: fix length of space character sequenceLászló Németh
A default RTF space character is longer by an extra six-per-em space in a space sequence. To get the same layout of documents formatted with consecutive spaces, insert six-per-em space before every space in a space sequence. Extra spaces are removed during the RTF export. Note: This is a workaround to get the same layout in documents based on RTF templates, often used for example by bussiness applications. Instead of adding a new RTF specific core/text layout feature, with this workaround the layout will be compatible with ODT and DOCX documents, too. (In contrast, MSO's DOCX export messes up the document layout silently, shortening the length of the space sequence.) Change-Id: I620807e1d4497e86c18732e5aa3131cf817ed94a Reviewed-on: https://gerrit.libreoffice.org/77172 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-08-23Related: tdf#126693 cannot put focus into combobox entryCaolán McNamara
set can-focus=True in internal GtkComboBoxText GtkEntry where the GtkEntry is editable=True Change-Id: I32cc7686c3a3cb9827f05f192227c0ad39669aa5 Reviewed-on: https://gerrit.libreoffice.org/78035 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-23Resolves: tdf#126693 cannot put focus into combobox entryCaolán McNamara
Change-Id: I52a316e5c88a41c66ef08be1bae8fcdd10d2ab8e Reviewed-on: https://gerrit.libreoffice.org/78030 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-23give address page an initial size req of its max sizeCaolán McNamara
so it won't jump around in size on activation Change-Id: If7c1ce0db0817ee552450a7776f98b7b9cc8a0a7 Reviewed-on: https://gerrit.libreoffice.org/78009 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-23tdf#119809: FILESAVE DOCX The combo box ActiveX control is lostTamás Zolnai
The problem was with the empty combobox. The implemenation before this commit imported a combobox only when the combobox had any item. Change-Id: I945098277d1ed34c65b43f0f6ad8eb361cf41b53 Reviewed-on: https://gerrit.libreoffice.org/78024 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-08-23loplugin:returnconstval in svxNoel Grandin
Change-Id: I501c341962e1d7e31f1466527b6e80f2294d79ed Reviewed-on: https://gerrit.libreoffice.org/78017 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-23loplugin:returnconstval in ooxNoel Grandin
Change-Id: Id83744fcb90d1bf6e6fe048858f48a4944351494 Reviewed-on: https://gerrit.libreoffice.org/78013 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-23weld SwMailMergeWizardCaolán McNamara
Change-Id: I03a7fd1f7676792387155db986d710a001887c8d Reviewed-on: https://gerrit.libreoffice.org/77977 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-23tdf#119388 add new UNO listener/broadcasterNoel Grandin
so that we only need to fire each event to the exact shape that wants it, instead of spamming all the shapes. Takes deleting a column from 20s to 10s for me. Note that none of the broadcasters are calling disposing(EventObject), so I did not make XShapeEventListener extend lang::XEventListener. If a memory leak regression points at this commit, possibly I missed something. Change-Id: I2b8db08247d3e0203d41faf77491368168994e4d Reviewed-on: https://gerrit.libreoffice.org/77857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-23rename AddressPreview back to SwAddressPreviewCaolán McNamara
Change-Id: I2afd5580fd94621163a5217d08d5b60190673fd2 Reviewed-on: https://gerrit.libreoffice.org/77973 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-23tdf#127101 Change tracking: fix format reject at paragraph joinLászló Németh
Now "Reject tracked change" can restore the original format of multiple paragraphs of a tracked deletion during editing. Change-Id: I83a307b4206ab610af3458f8cb6e9de905b88776 Reviewed-on: https://gerrit.libreoffice.org/77101 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-08-23tdf#127101 Change tracking: reject format at paragraph joinLászló Németh
Now "Reject tracked change" can restore the original format of the paragraphs of a tracked deletion during editing, storing the format change using SetExtraData() of SwRangeRedline. Change-Id: I916f624de081bf2fab020e0574aa4ec3136946c4 Reviewed-on: https://gerrit.libreoffice.org/77100 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-08-23tdf#103345 Import decimalEnclosedCircle correctlySamuel Mehrbrodt
Change-Id: I227d149d07ea0f7b2569e5df5a5589834374fac9 Reviewed-on: https://gerrit.libreoffice.org/77992 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-23RTF filter: handle tbrl section text directionMiklos Vajna
Makes no sense to support btlr, Word can't handle it. (UI is disabled.) Change-Id: I036a1e98e8b1ac07e688eedf45b4a2c21c4a8859 Reviewed-on: https://gerrit.libreoffice.org/77986 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-23tdf#39593 extract UnoTunnelId comparison to template functionArkadiy Illarionov
Change-Id: Ia2b5dea273c8de7b8c54e74780193a8d4cba7b45 Reviewed-on: https://gerrit.libreoffice.org/73874 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-23tdf#126784 sw: only distribute across selected columnsJustin Luth
partial revert of LO6.2 commit ab18c17d70e1dcf5cf9db38256d35e6af479373e because MERGED cells had a very unexpected effect on the columns that were altered. Unselected columns are INCLUDED in the calculation IF they extend over the selected columns when SwTableSearchType::Col uses the entire table column. The last table in the unit test demonstrates why the regressive behaviour was included. A user can make an ugly layout if they don't choose a good set of columns. However, the merged cell really changes the way the calculation works, and since giving power to the user is ultimately the best, just revert the portion that tries to save the user from themself. I struggled then and now to get a good enough understanding to improve the documentation - which really is needed since reading it didn't help me a lot. However, since my understanding was and is obviously flawed, I'll just revert back to the original wording. Change-Id: Icf8f01f095652e2a023e0398852f43aa6b90332f Reviewed-on: https://gerrit.libreoffice.org/77976 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-08-22drop newly unused SwAddressPreviewCaolán McNamara
Change-Id: I84cf6570d048df86b4690cb70cc3e7a256303951 Reviewed-on: https://gerrit.libreoffice.org/77972 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-22weld SwMailMergeAddressBlockPageCaolán McNamara
Change-Id: Ib3383f1ae590766ecb1371cab2ccdb7c835c95a8 Reviewed-on: https://gerrit.libreoffice.org/77971 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-22This is an export test.Tamás Zolnai
Change-Id: Idad907f192c7a4e536bd1b8ca899fc6f9d55bbdf Reviewed-on: https://gerrit.libreoffice.org/77962 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-11 15:51:55 +0000