summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2017-12-29ofz#4829 Floating-point-exceptionCaolán McNamara
Change-Id: Ifadeff08fe0c7d88498c8c657ce3955f0a518ef9
2017-12-29ofz#4817 Chaos with multiple body tagsCaolán McNamara
Change-Id: I4f2ab3a3be0909176599963c8ca113e3af85c832 Reviewed-on: https://gerrit.libreoffice.org/47159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-29Fix typosAndrea Gelmini
Change-Id: I0e56430afa65b6b5826d56212ac501c0244fce9b Reviewed-on: https://gerrit.libreoffice.org/47145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-29Fix typosAndrea Gelmini
Change-Id: I3d16dc162e5fa2e08134d848a835eb392e64056e Reviewed-on: https://gerrit.libreoffice.org/47126 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-28ofz#4746 Invalid-bool-valueCaolán McNamara
Change-Id: I9be8bc2d37bbefa20861ea76522ed9ef985195fa
2017-12-28tdf#113877 Insert document: merge two lists into oneSerge Krot
When inserting a new document into current position we need to concat to lists into one. Added unit test. Change-Id: I10689256e0ffc5cf93722b1d45f09f610211b14a Reviewed-on: https://gerrit.libreoffice.org/46978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-27Fix typosAndrea Gelmini
Change-Id: Icebbbb392d9187a11837b72116c00036247e9b74 Reviewed-on: https://gerrit.libreoffice.org/47104 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-27ofz#4813: Direct-leakCaolán McNamara
Change-Id: I7bd257734a302ad00acf4336f4b478d6af4bc304 Reviewed-on: https://gerrit.libreoffice.org/47100 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-27tdf#113399: DOT IMPORT, DOCX EXPORT: Page number not shown correctlyTamás Zolnai
We need to export 0 padding explicitely to DOCX file. Change-Id: I7126cfd1dbf4ebd1fb5e09c3642e0da159488258 Reviewed-on: https://gerrit.libreoffice.org/47090 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-27ofz#4725 Integer-overflowCaolán McNamara
Change-Id: I74e065b8ba00dc80559bb64cf1bdefa5f9f5b480
2017-12-26ofz#4794 Null-dereferenceCaolán McNamara
Change-Id: I2fc9f5ca60c2a476c031befd0253b1829538230d
2017-12-26ofz#4796 Null-dereferenceCaolán McNamara
Change-Id: Iad537d2bb2bed1225e5647a918c923e6d95aea75
2017-12-26mark angle value in picturepage.ui as untranslatableStanislav Horacek
Change-Id: I20c2c13770d8bef2d4f8e117101fb92e8182e26e Reviewed-on: https://gerrit.libreoffice.org/47059 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-25coverity#1426946 Unchecked return valueCaolán McNamara
Change-Id: I42d94649df7e64dce0af7ae242523106b1a04679
2017-12-25ofz#4783: Integer-overflowCaolán McNamara
Change-Id: I44f5c71db2a2da00da510673ee6a596582c8e3b9
2017-12-25ofz#4777: Direct-leakCaolán McNamara
Change-Id: Iefb1304540b59a1d0fae79d9d5c1ad4a6474d925
2017-12-25coverity#1426945 Unchecked dynamic_castCaolán McNamara
Change-Id: I6c3d84a0fb1b4332f78a1c0ca04c9a7700b53c90
2017-12-25ofz#4732 Null-dereferenceCaolán McNamara
Change-Id: I5ed632702f3a2304902b32aa6ac770586cc4ef34 Reviewed-on: https://gerrit.libreoffice.org/47044 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-25various coverity exception warningsCaolán McNamara
Change-Id: I7b3588ad42e17f2f363b6a247e318f23c95e578e Reviewed-on: https://gerrit.libreoffice.org/46961 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-25ofz#4735 Null-dereferenceCaolán McNamara
Change-Id: I930c6ace947c4516facc36782451303e12dba336 Reviewed-on: https://gerrit.libreoffice.org/47043 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-25ofz#4760 Floating-point-exceptionCaolán McNamara
Change-Id: I4f379e045d12e8eae3dd140cfd6eb958a3003d09 Reviewed-on: https://gerrit.libreoffice.org/47042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-25tdf#114663: consider left/right page numbers when not printing blanksMike Kaganski
Commit 3c1a343f6936f1dcefdf79a677f8c26ce29676e6 made it possible to use document pages' sequential number (unaffected by automatically inserted blank pages) in Pages input box when not printing blank pages. But the implementation didn't take into account the case when only left/right pages were printed. In this case, it treated the unprinted right/left pages same way as automatic blanks, i.e., excluded they from page numbering, so that e.g. when user entered 10-20 (when selected even pages), actually printed 11 pages from tenth even page (#20 in original document) till twenteeth even page (#40). Expected result (familiar from other applications, and worked before the commit) is to print 6 pages with even numbers, that are in the pages range 10-20 of original document (10,12,14,16,18,20). Now we consistently use StringRangeEnumerator::getRangesFromString after converting user input with page numbers conditionally referring either physical pages, or pages without blanks, to equivalent range string referring physical pages. This preprocessing of range string also ensures correct enumerating later (when StringRangeEnumerator is created based on this string, e.g., for processing of PostIts). Change-Id: I2381699bc4c37841bf9ce789cdad03141dd72255 Reviewed-on: https://gerrit.libreoffice.org/47030 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-12-24convert RES_FRM constants to TypedWhichIdNoel Grandin
Change-Id: I0c71a6fd2e094cebdb720e6c0661cd8a7bb8482c Reviewed-on: https://gerrit.libreoffice.org/46812 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-24tdf#114670 Make sure to dispose the menuMaxim Monastirsky
Change-Id: I30612a0b3cfef7d19ff6a5180db76a8002186bd5 Reviewed-on: https://gerrit.libreoffice.org/47025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-12-23NB Writer: tabbed toolbar get updatedandreas kainz
Change-Id: I71469d410e27ebe719e861cb0964ed6e4ba21805 Reviewed-on: https://gerrit.libreoffice.org/46852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2017-12-23Use proper quotation marks in this translatable stringAdolfo Jayme Barrientos
Change-Id: I1e082e7f19af2895cfb595f1734e69808594bd04
2017-12-23TestImportHTML: survive std::out_of_rangeCaolán McNamara
Change-Id: I084fd72e472bd2e647da3a80c7573280cd22bd93 Reviewed-on: https://gerrit.libreoffice.org/46998 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-23ofz#4728 Null-derefCaolán McNamara
Change-Id: Ide91a63424f864e2913b8268c4eca7961ba54572 Reviewed-on: https://gerrit.libreoffice.org/47000 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-23ofz#4723 use vector::atCaolán McNamara
Change-Id: I07ca0d9c0dc6d15f089d5c4832bb30e1ef62ef04 Reviewed-on: https://gerrit.libreoffice.org/46999 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-23tdf#111790: Shadow imported from a PPTX file is not overridenmartinb214
by the settings while saving back to PPTX Change-Id: I958f1987d0123bcf89ef37b13807f407781f3c15 Reviewed-on: https://gerrit.libreoffice.org/45989 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-22Resolves: tdf#114572 immediate update of value while typing unwantedCaolán McNamara
Revert "connect to modified instead of up/down/focus-lost" This reverts commit 44bfe8fad4f7c263dc713a65fb2ab0e2f9afcf99 Revert "listening to modify is sufficient to get all changes" This reverts commit 5c0bb1088a678d36309866c4eee43e58901f6b7b we probably need to distinguish a modify vs update signal to get what I wanted here. Back to the original mode for now. Change-Id: I51ebfc96b3a06cf09905f4a311d526f23ce371f1 Reviewed-on: https://gerrit.libreoffice.org/46958 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-22coverity#1426874 bogus Dereference after null checkCaolán McNamara
Change-Id: Icb3ad60a7ec314182e06af179d9d5c3a1f3babcb
2017-12-22tdf#42949 Fix some Include What You Use warningsMiklos Vajna
Change-Id: I30121764303579a7cb4ded0f0f48cc1f8fff6c33 Reviewed-on: https://gerrit.libreoffice.org/46946 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-22tdf#114306 fix unexpected page break in row-spanned tableManfred Blume
If a para gets moved off to another page, it never gets moved back. Make IsMoveable() more symmetric, add condition to MoveBwd to also claim table content back. Change-Id: I5366eb824f0ef7016599c777786cbdf42f65b9b5 Reviewed-on: https://gerrit.libreoffice.org/46021 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-21tdf#91781 Writer: Add Breaks submenu in Insert menuYousuf Philips
Change-Id: I6d143aa058bce731493e3f90fe361ee2a0d257f9 Reviewed-on: https://gerrit.libreoffice.org/46865 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-12-21set dbus id for existing DbusSessionHelper usersCaolán McNamara
Change-Id: I64329e21ae79b6607856de9781bee0274b9cb136 Reviewed-on: https://gerrit.libreoffice.org/46854 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-21tdf#37697 Fix incorrect toolbar separatorYousuf Philips
Change-Id: I2b42fd785516f6f719ba3853e9694652ad03e850 Reviewed-on: https://gerrit.libreoffice.org/46880 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-12-21ofz: avoid deleting the table still being processedCaolán McNamara
Change-Id: Ia92d469fd0e280bdc6470e780ab12b00366f0f8d Reviewed-on: https://gerrit.libreoffice.org/46902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-21Make SwSection::GetSectionName() return a reference to the nameTor Lillqvist
Has a small but measureable impact on the time it takes to load a specific pathological (huge) customer document. The load time drops from 1min 46s to 1min 38s on my machine. Reviewed-on: https://gerrit.libreoffice.org/46847 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 9675f307fbd7961b3d00f810dad3eacc9920e07d) Change-Id: I93b603f369528187980d644a5364fa9bcf2f4615 Reviewed-on: https://gerrit.libreoffice.org/46904 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-12-21sw: fix inconsistent bookmark behavior around at-char/as-char anchored framesMiklos Vajna
We have a placeholder character in the sw doc model for as-char anchored frames, so it's possible to have a bookmark before/after the frame or a non-collapsed bookmark which covers the frame. The same is not true for at-char anchored frames, where the anchor points to a doc model position, but there is no placeholder character. If a bookmark is created covering the start and end of the anchor of the frame, internally we create a collapsed bookmark which has the same position as the anchor of the frame. When this doc model is handled by SwXParagraph::createEnumeration(), first the frame and then the bookmark is appended to the text portion enumeration, so your bookmark around the frame is turned into a collapsed bookmark after the frame. (The same happens when we roundtrip an ODT document representing this doc model.) Fix the problem by inserting collapsed bookmarks with affected anchor positions (same position is the anchor for an at-char frame) into the enumeration in two stages: first the start of them before frames and then the end of them + other bookmarks. This way UNO API users get their non-collapsed bookmarks around at-char anchored frames, similar to as-char ones. Change-Id: Ic1f173c85d3824afabb5b7ebf3a8594311eb9007 Reviewed-on: https://gerrit.libreoffice.org/46889 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-21TypedWhichId in svx part 2Noel Grandin
Change-Id: Id927679c9f07f1dd820f4fdca9a45eb7aede037c Reviewed-on: https://gerrit.libreoffice.org/46850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-21Fix typoAndrea Gelmini
Change-Id: I15b44b42d31eaebd2a8cea29fdaa843c9bd21b73 Reviewed-on: https://gerrit.libreoffice.org/46857 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-21tdf#79077: Load/save PapersizeFromSetup into ODF for sw and scKatarina Behrens
Change-Id: I0fc1a771927dc7116768cfbb7f7e31006e41e1c8 Reviewed-on: https://gerrit.libreoffice.org/45332 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-21sw: remove DebugHeaderFooterContent() in SwUndoPageDescMiklos Vajna
No longer builds, and the plain node array output in gdb / doc model xml dump is comparable functionality. Change-Id: Ia51dc8c707b4827aa54b9d27f3b66e5e6539a530 Reviewed-on: https://gerrit.libreoffice.org/46862 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-21TypedWhichId in svx part 1Noel Grandin
and teach the idl compiler how to ignore the TypeWhichId<T1> part of the define Change-Id: I030f54080924d51e9f0ac09b19e14106648024db Reviewed-on: https://gerrit.libreoffice.org/46849 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-21Writer: Restore old symbol button and add new numbering stylesYousuf Philips
Change-Id: I458ad3fe6c19cd5c65a4beb4758e0ac9aba630a4 Reviewed-on: https://gerrit.libreoffice.org/46757 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-12-20Make used Pages alive in AssertFlyPagesArmin Le Grand
There is a case where docs are created/exist that have an empty 2nd page with a single, page-anchored Frame (e.g. graphic), not using a PageBreak. Persistence works in this case due to method AssertFlyPages adding the missing page at end, but when multiple of these docs get serialized (e.g. MailMerge) the problem exists for in-between pages, too, and needs to be corrected. Also need to correct the Pages for the Frames when Pages in that situation were corrected. Change-Id: I7c8bbbf0668438af98bc615e5b7c472ea6eee906 Reviewed-on: https://gerrit.libreoffice.org/46855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2017-12-20coverity#1426742 IsTextBox will be false here unless pVirtO is non-nullCaolán McNamara
Change-Id: I794243a47b1693b8b4454da02efea934535cec48
2017-12-20replace pVirtO null check with just pVirtOCaolán McNamara
Change-Id: Ie9ef7736bec84085cdfab41b13059b9cec821ff2
2017-12-20dynamic_cast followed by static_castCaolán McNamara
Change-Id: Ia2fed1d1ff97108ee3bbe11b5c08901099ee33e6