summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2017-04-05ofz: convert to unicode may fail, so only advance insertion on successCaolán McNamara
Change-Id: I3ab25a9075a559f7a3eb51488e243a4302ad87fe
2017-04-05rhbz#1438179 sw: fix toolbar "Next Track Change" / "Previous..."Michael Stahl
There's some confusing workarounds in SwView::Execute() that aren't needed if the SwCursorShell just calls NormalizePam() so it always makes progress. Change-Id: I3b014079b19925041234fcd858526148890f560c
2017-04-05ofz: treat short properties as run endCaolán McNamara
Change-Id: I1250f74c9f4ed6679a89c7915fb704c8b8cd693f
2017-04-05ofz: check available data lenCaolán McNamara
Change-Id: Ibb40e1d474bb0baacd57f136ff056e248b6f0c61
2017-04-05sw: remove "revolution" assert that doesn't even build anymoreMiklos Vajna
Change-Id: I6446e732e2209b4a7fc26eccfe6cf793ddc60884 Reviewed-on: https://gerrit.libreoffice.org/36128 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-05Notebookbar: correct commands for spacing controlsSzymon Kłos
Change-Id: I84649a50fc5e8c094514c5461105bb6777d6ffa1
2017-04-05ofz: infinite loop and oomCaolán McNamara
Change-Id: Ibb23b5808ae465294adf2342d5535784476f5395
2017-04-05ofz: stay within available dataCaolán McNamara
Change-Id: Ic959cf5b2cd92ba5bc297e686beb1fd50427a994 Reviewed-on: https://gerrit.libreoffice.org/36102 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-05There is no MM wizard page after Layout page nowGabor Kelemen
Change-Id: Ifd15dada56581ccae704452f6c98f5b476ca15f5 Reviewed-on: https://gerrit.libreoffice.org/36094 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-04-05teach constantparam plugin to find always on and always off bitmask valuesNoel Grandin
Change-Id: If56a483494bd3d7feb3fa67c01000dddd0d34421 Reviewed-on: https://gerrit.libreoffice.org/36085 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05loplugin:constantparam part2Noel Grandin
Change-Id: I7ec4c946be52a6b56aee908426f95ecacc7b0746 Reviewed-on: https://gerrit.libreoffice.org/36072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05loplugin:constantparamNoel Grandin
Change-Id: I1996319e5b664dff95f7a9b2346aea6092d333ec Reviewed-on: https://gerrit.libreoffice.org/36070 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-04ofz: check olst sprm for valid ANLD payload lenCaolán McNamara
Change-Id: Ic1b6681a3f48ef0fe3f52eda9db8b7bc003ded55
2017-04-04Make HangingIndent a commandSzymon Kłos
New command .uno:HangingIndent. Code moved from the sidebar to slots. Change-Id: Ib389f9fb3368409a90cf90ad8b19f1be322fa120 Reviewed-on: https://gerrit.libreoffice.org/35930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-04-04Notebookbar: Separated paragraph spacing controlsSzymon Kłos
One big paragraph spacing control was splitted to separated widgets. It will be possible to reuse that in the sidebar. Also layout is better because explicit size setting is no longer needed. Change-Id: Ieb200af4a9a6120ae03b22b27da56256aa816193 Reviewed-on: https://gerrit.libreoffice.org/35801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-04-04std::unique_ptr<[]> -> std::vectorCaolán McNamara
Change-Id: I7fd4275664fab42c61941a4ea21750a653b437d3
2017-04-04ofz: avoid oomCaolán McNamara
Change-Id: Ie700676c8470b6764a38f4e2989dc14819244872
2017-04-04ofz: guard harder against bogus sprm lenCaolán McNamara
Change-Id: Ic82526e1454b24f094d3deee89647e88760bc44b
2017-04-04ofz: guard against bogus sprm lenCaolán McNamara
Change-Id: I9b4074e1024753549f468f427afbfdf9cd01b674
2017-04-04coverity#1403732 Mixing enum typesCaolán McNamara
and coverity#1403735 Mixing enum types coverity#1403737 Mixing enum types Change-Id: I278b7d5116d4157e6aa4483d8eef42325e4bc03b
2017-04-04tdf#106690 DOCX import: fix automatic spacing before/after numbered para blockMiklos Vajna
The context is text nodes with automatic before/after spacing and numbering rules set, like: A * B * C * D E The correct behavior seems to be (though I haven't found this explicitly written in the OOXML spec) to drop spacing between B and C and C and D, but not before B and not after D. Originally no spacing was dropped, then commit c486e875de7c8e845594f5043a37ee8800865782 (tdf#95031 DOCX import: auto spacing inside numbering means no spacing, 2016-10-18) removed spacing around all B/C/D. Fix the problem by checking the numbering rules and automatic after spacing of the previous paragraph, so spacing before B and after D is not removed. Change-Id: Icbdb36e31057ab0e8ac033888cf5cc7c52dad5d0 Reviewed-on: https://gerrit.libreoffice.org/36062 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-04ofz: check anldPap sprm for valid ANLD payload lenCaolán McNamara
Change-Id: Ie034e3b37e01c29cf19fe8ad78b1121f6eadecb2 Reviewed-on: https://gerrit.libreoffice.org/36053 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-04sw: indentation fixesMiklos Vajna
Nested namespaces were always declared in new lines in these files, let's keep the consistency. Change-Id: I1dcfdd2b1f54ec56b3554f3c0095513cec33e49c
2017-04-04make UNO enums scoped for internal LO codeNoel Grandin
this modifies codemaker so that, for an UNO enum, we generate code that effectively looks like: #ifdef LIBO_INTERNAL_ONLY && HAVE_CX11_CONSTEXPR enum class XXX { ONE = 1 }; constexpr auto ONE = XXX_ONE; #else ...the old normal way.. #endif which means that for LO internal code, the enums are scoped. The "constexpr auto" trick acts like an alias so we don't have to use scoped naming everywhere. Change-Id: I3054ecb230e8666ce98b4a9cb87b384df5f64fb4 Reviewed-on: https://gerrit.libreoffice.org/34546 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-03ofz: check anlv text boundsCaolán McNamara
Change-Id: I6288aae2d439cde6a2b95c005a2090f73e21bb7a
2017-04-03ofz: avoid oomCaolán McNamara
Change-Id: Icbd4b98e8a0a4aff967bae22f3f59248ed40598a Reviewed-on: https://gerrit.libreoffice.org/36049 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-03sw: [loplugin:sallogareas]Michael Stahl
Change-Id: I94c552e4b2ae95f57b0c667f6072664eab570042
2017-04-03More integer clean-upStephan Bergmann
...after dbaab58c1442e7f62ef0732376fe5a49840e9fd6 "loplugin:loopvartoosmall". Looks like SwLayHelper::nIndex only needs to be initialized to a very large value (so that 'nIndex < pImpl->size()' will be false), not USHRT_MAX exactly. Change-Id: I209faa00894783c468db1440f5663ea9e8ad3e19
2017-04-03only convert used part of bufferCaolán McNamara
Change-Id: I133a02ae1cbdb4fb32f81db7214d27c66ccd0a8b
2017-04-03don't check on every loopCaolán McNamara
Change-Id: I000a887925db63b5717cc0d062d9da623415f7cc
2017-04-03loplugin:unreffunStephan Bergmann
Change-Id: I7a4fe7240e43faaae3482a084b466fa87e67b6b8
2017-04-03flush writer fontcache after TestImportDOCCaolán McNamara
to get around leak sanitizer Change-Id: I45f0caefc14c35476e92887058031dddd92afb81
2017-04-03these are file urls, so don't need ucbCaolán McNamara
Change-Id: I25beaeab002db1de34be3b5f4a774bd15b71f5d3 Reviewed-on: https://gerrit.libreoffice.org/36045 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-03loplugin:loopvartoosmallStephan Bergmann
Change-Id: Ief96de6eb6f6276681130a6d16c767ab8ceaa3f1
2017-04-03loplugin:sallogareasStephan Bergmann
Change-Id: Idd4f44b66e67d938a1ba2b9c7ff4be0b0009ff53
2017-04-03tdf#106237 sw: do some basic sanity checking on layout-cacheMichael Stahl
The bugdoc, with claimed generator AOO4.1.1 on Windows, contains a bogus layout-cache: debug:26706:1: nType P nIndex 29 2147483647 debug:26706:1: nType P nIndex 66 2147483647 debug:26706:1: nType P nIndex 105 2147483647 debug:26706:1: nType P nIndex 142 2147483647 debug:26706:1: nType P nIndex 178 2147483647 debug:26706:1: nType P nIndex 205 2147483647 debug:26706:1: nType P nIndex 229 2147483647 debug:26706:1: nType T nIndex 314 65535 Due to a loop-control this causes incorrect pagination if CalcLayout() is called only once. It should look like this: debug:26765:1: nType T nIndex 382 65535 debug:26765:1: nType T nIndex 790 65535 In this case we can easily detect that the indexes and types in the layout-cache are bogus by checking against the node types, so do that in SwLayHelper::SwLayHelper(). Change-Id: I7091af49a8c29bf0a11ceff0be9ba84b1f710fdb
2017-04-03ofz: fix leakCaolán McNamara
Change-Id: I93a7b2f77713db5c51734263b78ffc69c899987b
2017-04-03coverity#1403734 Mixing enum typesCaolán McNamara
Change-Id: I46a9a85e7f70502f703ee9fb0f94abd83952d120
2017-04-03sw: prefix members of SwTokenWindowMiklos Vajna
Change-Id: Iab538d4e4943559dc09dc1e947217b0db697620f Reviewed-on: https://gerrit.libreoffice.org/36039 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-03tdf#106897: preset visited/unvisited character style in ListBoxOliver Specht
Change-Id: I9bfa2b8a50340a6b09d8cc50e5313dc45a518472 Reviewed-on: https://gerrit.libreoffice.org/35973 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-04-03sw: indentation fixesMiklos Vajna
Change-Id: I81076414ee335f34bb687f93e89d65343d2f3c57
2017-04-03Avoid redundant inline warning in swcacheArnaud Versini
Change-Id: Ia30d9f406769cab219418d4624e8547a036c4f08 Reviewed-on: https://gerrit.libreoffice.org/36022 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-03use actual UNO enums in swNoel Grandin
Change-Id: If0f4a6532cc255f632d88d97e6b1a9e57462f5fc Reviewed-on: https://gerrit.libreoffice.org/35969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-02split up doc testing for three major variantsCaolán McNamara
Change-Id: Iac1b5cb1c209ba27d185c8a7ba1e59c663553d77
2017-04-02coverity#1403662 Mixing enum typesCaolán McNamara
Change-Id: Ic5e797c65dfc736a9ef0ab14f3ae563216143947 Reviewed-on: https://gerrit.libreoffice.org/36020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-01add rtf fuzzerCaolán McNamara
Change-Id: I36a6294c158232bef8fceeaf5159527f467f5786
2017-04-01support avoiding config in SwTableAutoFormatTableCaolán McNamara
Change-Id: I9d62efc7f57e8893fc5fbd1a8bec1f7cbbbeb2e7
2017-04-01sw: replace hardcoded uno namesVitaliy Anderson
Change-Id: I4cf8a4f76744b8a6bc25cd5abdd280f98eea9499 Reviewed-on: https://gerrit.libreoffice.org/35889 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-31tdf#101846: update spelling on URL changesOliver Specht
call setWrong if URL attributes are applied to force re-spelling Change-Id: I8a5fa20c45cdf1df33975c4d6bee5e2c0f3f272f Reviewed-on: https://gerrit.libreoffice.org/35962 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2017-03-31tdf#106849: don't reduce quality of picture in bullet list.Vitaliy Anderson
An image saved in cache when NS_ooxml::LN_CT_NumPicBullet_pict property is processed should not to be resized. It reduce quality the image. Just set the property "GraphicSize" of current level of the NumRule instead of resize the image when processing NS_ooxml::LN_CT_Lvl_lvlPicBulletId property. Change-Id: I8ac80643decb7794de7a295cc7c2895a5bd24e2d Reviewed-on: https://gerrit.libreoffice.org/35592 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>