summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2020-07-31loplugin:flatten in sw/core/ole..sw/core/tableNoel Grandin
Change-Id: If74f1cfca114d52566164656c34a0764cfbaad43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99886 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-31loplugin:flatten in sw/core/frmedtNoel Grandin
Change-Id: I64f743d6f696584ff4c3c9185ae1e8fa42451677 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99884 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-31loplugin:flatten in sw/core/textNoel Grandin
Change-Id: I086860cefe9f26c3728fe0d8266c35dae37b9570 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99887 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-31tdf#134965 sw: avoid RemoveFollowFlowLine() SNAFUMichael Stahl
A follow-flow-line SwRowFrame is deleted in RemoveFollowFlowLine() while it is being iterated in stack frame #18. 0 SwRowFrame::~SwRowFrame() (this=0xaa035b0, __in_chrg=<optimized out>) at sw/source/core/layout/tabfrm.cxx:3807 1 SwFrame::DestroyFrame(SwFrame*) (pFrame=0xaa035b0) at sw/source/core/layout/ssfrm.cxx:389 2 SwTabFrame::RemoveFollowFlowLine() (this=0x9c16790) at sw/source/core/layout/tabfrm.cxx:945 3 SwTabFrame::MakeAll(OutputDevice*) (this=0x9c16790, pRenderContext=0x72afaf0) at sw/source/core/layout/tabfrm.cxx:2203 4 SwFrame::PrepareMake(OutputDevice*) (this=0x9c16790, pRenderContext=0x72afaf0) at sw/source/core/layout/calcmove.cxx:370 5 SwFrame::Calc(OutputDevice*) const (this=0x9c16790, pRenderContext=0x72afaf0) at sw/source/core/layout/trvlfrm.cxx:1791 6 SwFrame::PrepareMake(OutputDevice*) (this=0x925b740, pRenderContext=0x72afaf0) at sw/source/core/layout/calcmove.cxx:248 7 SwFrame::Calc(OutputDevice*) const (this=0x925b740, pRenderContext=0x72afaf0) at sw/source/core/layout/trvlfrm.cxx:1791 8 SwFrame::PrepareMake(OutputDevice*) (this=0x925b8e0, pRenderContext=0x72afaf0) at sw/source/core/layout/calcmove.cxx:248 9 SwFrame::Calc(OutputDevice*) const (this=0x925b8e0, pRenderContext=0x72afaf0) at sw/source/core/layout/trvlfrm.cxx:1791 10 SwFrame::PrepareMake(OutputDevice*) (this=0x925ba70, pRenderContext=0x72afaf0) at sw/source/core/layout/calcmove.cxx:248 11 SwFrame::Calc(OutputDevice*) const (this=0x925ba70, pRenderContext=0x72afaf0) at sw/source/core/layout/trvlfrm.cxx:1791 12 SwFrame::MakePos() (this=0x925bc20) at sw/source/core/layout/calcmove.cxx:552 13 SwTextFrame::MakePos() (this=0x925bc20) at sw/source/core/text/frmform.cxx:339 14 SwContentFrame::MakeAll(OutputDevice*) (this=0x925bc20) at sw/source/core/layout/calcmove.cxx:1408 15 SwFrame::PrepareMake(OutputDevice*) (this=0x925bc20, pRenderContext=0x72afaf0) at sw/source/core/layout/calcmove.cxx:370 16 SwFrame::Calc(OutputDevice*) const (this=0x925bc20, pRenderContext=0x72afaf0) at sw/source/core/layout/trvlfrm.cxx:1791 17 SwContentFrame::CalcLowers(SwLayoutFrame&, SwLayoutFrame const&, long, bool) (rLay=..., rDontLeave=..., nBottom=168478, bSkipRowSpanCells=true) at sw/source/core/layout/tabfrm.cxx:1521 18 lcl_RecalcRow(SwRowFrame&, long) (rRow=..., nBottom=168478) at sw/source/core/layout/tabfrm.cxx:1651 19 SwTabFrame::MakeAll(OutputDevice*) (this=0x93ec7e0, pRenderContext=0x72afaf0) at sw/source/core/layout/tabfrm.cxx:2421 20 SwFrame::PrepareMake(OutputDevice*) (this=0x3df3cc0, pRenderContext=0x72afaf0) at sw/source/core/layout/calcmove.cxx:316 21 SwFrame::Calc(OutputDevice*) const (this=0x3df3cc0, pRenderContext=0x72afaf0) at sw/source/core/layout/trvlfrm.cxx:1791 22 GetFrameOfModify(SwRootFrame const*, SwModify const&, SwFrameType, SwPosition const*, std::pair<Point, bool> const*) (pLayout=0x72aa850, rMod=..., nFrameType=(SwFrameType::Txt | SwFrameType::NoTxt), pPos=0x71f35e0, pViewPosAndCalcFrame=0x7ffc99f591a0) at sw/source/core/layout/frmtool.cxx:3697 23 SwContentNode::getLayoutFrame(SwRootFrame const*, SwPosition const*, std::pair<Point, bool> const*) const (this=0x6fcfb50, _pRoot=0x72aa850, pPos=0x71f35e0, pViewPosAndCalcFrame=0x7ffc99f591a0) at sw/source/core/docnode/node.cxx:1194 24 SwCursorShell::GetCurrFrame(bool) const (this=0x72a9730, bCalcFrame=true) at sw/source/core/crsr/crsrsh.cxx:2455 25 SwFEShell::GetAnyCurRect(CurRectType, Point const*, com::sun::star::uno::Reference<com::sun::star::embed::XEmbeddedObject> const&) const (this=0x72a9730, eType=CurRectType::PageCalc, pPt=0x0, xObj=empty uno::Reference) at sw/source/core/frmedt/fews.cxx:113 26 SwView::StateStatusLine(SfxItemSet&) (this=0x72af430, rSet=SfxItemSet of pool 0x6fa3d50 with parent 0x0 and Which ranges: [(10000, 10000), (10221, 10221), (10223, 10225), (11064, 11065), (21182, 21182), (21185, 21185), (21189, 21189)] = {...}) at sw/source/uibase/uiview/view2.cxx:1517 Not obvious why this changed with calling MakeFrames() instead of SwNodes::CopyNodes(bNewFrames=true) or how to best prevent it; adding another FrameDeleteGuard avoids the crash at least. (regression from 166b5010b402a41b192b1659093a25acf9065fd9) Change-Id: Ifd5a0c93064c9536429dda30a2c4ebc7a31b7e7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99870 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-31tdf#134931 sw_redlinehide: fix layout following paste of tableMichael Stahl
The pasted table does get a SwTabFrame but the problem is that TurboAction() is called and formats the pre-existing SwTextFrame and somehow that just sets all the valid flags on the new SwTabFrame without doing any formatting. Previously, SwNodes::CopyNodes(bNewFrames=true) would call SwTabFrame::Paste() which invalidates the page. In InsertCnt_(), for new SwSectionFrames InvalidatePage() is already called so do the same for SwTabFrame which gets rid of the "turbo". (regression from 166b5010b402a41b192b1659093a25acf9065fd9) Change-Id: I970a04bd8e76f5418bddb66af915ac466f44daf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99867 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-31loplugin:flatten in sw/core/txtnodeNoel Grandin
Change-Id: I0003a190cbc42845274d71f8f157977e598a3fd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99859 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-31loplugin:flatten in sw/core/view..sw/core/htmlNoel Grandin
Change-Id: I793811af353fe61b12e5e89da2056fb58108e9dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99852 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-31loplugin:flatten in sw/core/undoNoel Grandin
Change-Id: I34662fd439578fc6f446c5216c5c1b735b79718d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99860 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-31loplugin:flatten in sw/filter/ww8Noel Grandin
Change-Id: Ia296fc6e6c8f78edf533dedf52996560ae62d143 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99853 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-31tdf#134436 sw: fix SwUndoDelete::RedoImpl() with section at end...Michael Stahl
... of document; the root cause is that in some intermediate delete operation, the delete will remove a section start/end node pair that surrounds the last text node in the document, but SwUndoDelete::RedoImpl() will not remove it, thus for subsequent Undo actions the indexes are messed up and weird things happen. Fix this in DocumentContentOperationsManager::DeleteRangeImplImpl(), with the same weird "is point at the end" check as SwUndoDelete. Change-Id: Iebf20d3c129c69692df8d57e3c5b9e6fec281e4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99810 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-31loplugin:flatten in sw/core/unocoreNoel Grandin
Change-Id: If96b2484426f0d09119ca89943729c149675156f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99851 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-31tdf#81567 : sw_ooxmlexport14: Add unittestXisco Fauli
Change-Id: Ib1584b8599b65c9a122768b7c00d7891efc6e920 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99824 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-31sw: introduce a Library_swqahelperMiklos Vajna
So it is no longer necessary to define all SwModelTestBase functions inline. Change-Id: Ia1055ff967b3614102275ec92607c85ec063fce7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99820 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-30loplugin:flatten in sw/ui/dbuiNoel Grandin
Change-Id: Iab627f306a1caf52237369471393753bf2c736f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99804 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30loplugin:flatten in sw/filter/xmlNoel Grandin
Change-Id: If018f8b03816d8110bd3ba9eec3f26373e6c5a6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99803 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30loplugin:flatten in sw/ui/dialog..sw/ui/tableNoel Grandin
Change-Id: I2350c1d3f5fab727b0d47b6f3684804b77e68122 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99805 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30loplugin:unusedmethodsNoel Grandin
and tweak the plugin a little to speed it up Change-Id: Ia59456232602184c4f1b5d1d75ad94a9a2e2d0be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99799 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30loplugin:flatten in sw/uibase/dbui..sw/uibase/envelpNoel Grandin
Change-Id: I20dc75b75e999ed82d221072d6ecaf2c02c834eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99793 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30loplugin:flatten in sw/uibase/app..sw/uibase/configNoel Grandin
Change-Id: I903631568cc5285bf167ba3f0dadb95dbcd43a21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99792 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30loplugin:flatten in sw/uibase/fldui..sw/uibase/ribbarNoel Grandin
Change-Id: Iff2bd302c3a6cc23be462e5a59aee0d12e7e7c09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99794 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30loplugin:flatten in sw/uibase/shellsNoel Grandin
Change-Id: I003c2c4e48bb59590ba952c74e3ee4733ce1051f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99764 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30Resolves: tdf#134831 reorg to expand inspector to fit full panel sizeCaolán McNamara
Change-Id: I73e37dff01d67f04ea5a2a82e4083ffd5bd46440 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99774 Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-07-30tdf#134252 sw_redlinehide: fix SwUndoDelete for table before end of sectionMichael Stahl
In this funny case, the SwPaM starts inside a section, and ends in the first text node following the end of the section, which happens to be in a different section (but that doesn't matter)... this is because IsSelOvr() moves the end of the selection resulting in the 3rd SelAll off of the table end node (as the section ends with a table), but then it's on the section end node and moves forward again. SwUndoDelete::UndoImpl() must first create the outer section frames, skip over the start text node which has frames handled by RecreateStartTextFrames() and then create the frames following the start text node, where the end node of the outer section now finds its expected outer section frame. This relies on the code from 55576842ec72a748d0bad123d41fa03c89fc136d to move the existing text frame below the new section frame(s). (regression from 6c7245e789f973cf6dad03f7008ab3f9d12d350c) Change-Id: I9f39b09e603e75ef813d5c855d828ec9bd5fdd95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99723 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-30loplugin:flatten in sw/uibase/utl..sw/uibase/wrtshNoel Grandin
Change-Id: I9010524952ce3b99a62e53dbf715a72c86a89b01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99766 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30loplugin:flatten in sw/uibase/sidebar..sw/uibase/unoNoel Grandin
Change-Id: Ifc9c838ffc94e89d2049969ef28d66fed853548b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99765 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30tdf#38093 Writer outline folding - persistenceJim Raykowski
Patch 6/6 that breaks down https://gerrit.libreoffice.org/c/core/+/96672 Adds persistence attribute loext:outline-content-visible Change-Id: Ide3eeee0f127a05def4d4f493bb4b469e0877b00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99657 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-30tdf#38093 Writer outline folding - Navigator UIJim Raykowski
Patch 5/6 that breaks down https://gerrit.libreoffice.org/c/core/+/96672 Adds submenu 'Outline Content Visibilty' and action handling for submenu items to Navigator Headings context menu. Change-Id: Iccdcbc7518a83cc1b2e2e75f3052f8dbbffb1338 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99656 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-30tdf#38093 Writer outline folding - .uno:ToggleOutlineContentVisibilityJim Raykowski
Patch 4/6 that breaks down https://gerrit.libreoffice.org/c/core/+/96672 Add UNO command to toggle outline content visibility Change-Id: I5365b29ab88d67a449b551b303f050b52063b977 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99655 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-30tdf#38093 Writer outline folding - ctrl + click toggle visibilityJim Raykowski
Patch 3/6 that breaks down https://gerrit.libreoffice.org/c/core/+/96672 Adds ctrl + mouse-click to toggle outline content visibility. Right click includes sub levels. Outline content visibility of sub levels is set to that of the clicked outline content toggled visibility. Change-Id: I428b3c683bec48bec147385dcdb1708e1f28d791 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99654 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-30tdf#38093 Writer outline folding - outline visibility and on canvas uiJim Raykowski
Patch 2/6 Outline content visibility and on canvas collapse/expand control button implementations. Change-Id: I8481125b102d2f07bfcfce91e1379d8e786a7aa2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99653 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-30tdf#38093 Writer outline folding - feature sensitivityJim Raykowski
Patch 1/6 -Adds option 'Show outline visibility button' to options writer view tab in Display section. -Adds UNO command '.uno:ShowOutlineContentVisibilityButton' to toggle option on and off from menus, toolbars, and key bindings. -Makes feature experimental mode. Change-Id: If5a57defd8f568736ea08625ab6eb08e30b15c03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99652 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-30(related: tdf#134252) sw: fix assert when moving mouse pointerMichael Stahl
SwPageFrame::GetModelPositionForViewPoint() was calling GetCharRect() on a frame that doesn't match the passed prevTextPos; it was supposed to be initialised by GetModelPositionForViewPoint() call but that didn't work because the point was outside the frame so nothing was inited. (regression from edd2db1c783bd571ff796a5298385cacc91877b9) Change-Id: Ic064c3efc1b7f29d18d713206e5ea5ac0b67fbc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99692 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-30tdf#133967: sw_uiwriter: Add unittestXisco Fauli
Change-Id: I7ec43fd7109e883b0ae560cc8832e449a09fddb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99758 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-30sw: extract createDoc() from various test suites to a single getSwDoc()Miklos Vajna
Change-Id: I72d769860be8a401416e57111bea91d7a26ea4e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99751 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-30tdf#135244: don't jump when updating countsMike Kaganski
Change-Id: Id1693e420a51a913fa78da7b7f46e076876ffe68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99756 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-30tdf#135244: prevent jumping when generating drop caps previewMike Kaganski
Change-Id: Ifd9ade76384c66312eda8c8ee7cb41891459b3f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99757 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-30tdf#135244: prevent jumping to cursor at document renderMike Kaganski
This prevents the jumps when printing Change-Id: I8b6f7d60aa0ed443ec8e05ad5812830a6b655abb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99715 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-30tdf#135244: move LockAllViews to SfxObjectShellMike Kaganski
... so that it may be called from SfxObjectShell::SaveTo_Impl, and handle export cases in addition to save (as) handled in tdf#41063. Change-Id: Ie39196656dd1a95dcb6bab3ae8138c2f5c8729e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99714 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-29tdf#134250 add unit testMichael Stahl
Change-Id: I4c5d7bc1c2471a14afabf331acb8c2f2781382bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99672 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-29automatic layout height is sufficient for the toc CtrlParentWinCaolán McNamara
Change-Id: I6ece49cce56aedf4f6da1361443c1337387143fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99712 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29replace and drop MiscCfgCaolán McNamara
Change-Id: I5ea9e3663fc5d30d725cf18757badb9b9802da18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99675 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29Fix typoAndrea Gelmini
Change-Id: I4b1eefee1fd77d946f2926d0a0bb5b929de5d374 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98997 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-29replace and drop SvtPrintWarningOptionsCaolán McNamara
Change-Id: I17fd4156eb940fbdc925d9761301096e5349135f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99674 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29Further timing issues with test_insert_hyperlinkStephan Bergmann
<https://ci.libreoffice.org/job/lo_ubsan/1709/> still failed with > FAIL: test_insert_hyperlink (hyperlinkdialog.HyperlinkDialog) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/home/tdf/lode/jenkins/workspace/lo_ubsan/sw/qa/uitest/writer_tests3/hyperlinkdialog.py", line 71, in test_insert_hyperlink > self.assertEqual(get_state_as_dict(xindication)["Text"], "link") > AssertionError: '' != 'link' > + link > so try a fix similar to 27798238ecb200e0753b013c79df0e6c014c7a7a "uitest : Avoid any timing issue in test_insert_hyperlink" Change-Id: I04b1616f3c5028065aafadbd73e0e52ef220ce5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99669 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-29tdf#59674 Word export: set a tabstop at numbering IndentAtJustin Luth
...if the specified tabstop would be ignored - for the benefit of MS Word. After the numbering character, the tab in Writer stops at A.) IndentAt, or B.) a non-default tabstop. In other words, Writer ignores default tabstops. (Caveat, LO ignores IndentAt when numbering sets a larger tabstop.) However, MS Word does NOT necessarily stop at IndentAt, but it stops at default tabstops, or a specified tabstop. It only seems to stop at IndentAt if there are only default tabstops that are farther than IndentAt. In other words, Word usually ignores IndentAt. (This is true for .doc and .rtf formats. It is also true for .docx format with MS Word 2003, but not with MS Word 2016.) In this patch, I only try to fix Word ignoring the IndentAt. [A basically-unsolvable edge case is when the tabstop is larger than the first line indent, but still not behind the numbering character.] This patch could regress if paragraph-level tabstops define the position. In that case, we have introduced another tabstop at the indentAt position, and so a SECOND tabstop on the FIRST line might end up at the wrong position. This is an EXTREMELY unlikely situation, and in fact, both LO and Word seem to tabstop there anyway, so I no longer think it would cause a regression. Go figure. I heavily modified an existing unit test because although that fix "works" and was an "easy fix" it probably ought to have calculated the IndentAt and used that instead of zero to replace the LO default values. It works, however, so I won't bother doing anything about it. (Also, the paragraph used doesn't matter - it is the same list.) Change-Id: Ia13ac880ab63c610b26c99ab77903e08ebdebe35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99529 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-29sw reqif-xhtml export: avoid writing text-decoration:noneMiklos Vajna
This CSS key is allowed, but only the underline and line-through values are allowed in reqif mode, according to the top of page 66 of "01_OMG_Requirements Interchange Format (ReqIF)_Version 1.2_formal-16-07-01.pdf". Change-Id: Ide64344f58bde4569fe499d8514dab36a055bda9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99662 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-07-29tdf#134250 sw_redlinehide: fix Undo with section before tableMichael Stahl
... at start of document, part 2: In SwUndoDelete::UndoImpl(), the m_aEndStr wasn't inserted, because the pTextNd was a section node. This caused asserts when trying to add the history hints that used to be in the end text node. thints.cxx:1295: bool SwTextNode::InsertHint(SwTextAttr*, SetAttrMode): Assertion `!pAttr->GetEnd() || (*pAttr->GetEnd() <= Len())' failed. (regression from 57d488660572d62ef0371e50dcdd4ca7a6d98a14) Change-Id: I48caa7487d2d1e6250b5aceab18f270555d3ee8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99644 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-29tdf#134250 sw_redlinehide: fix copy non-empty node before non-textnodeMichael Stahl
The problem in CopyImplImpl() is that pCopyPam's end position was updated to index 0 but text was copied into the node, which is thus not covered by pCopyPam and thus also not by SwUndoInserts. Then SwUndoInserts::UndoImpl() doesn't delete the bookmarks in the end node and the bookmark positions cause ~SwIndexReg asserts. Change-Id: I4cc03e846eae4cabd9eb4346a98c1e5c2866050d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99643 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-29replace and drop SvtCompatibilityViewOptionsCaolán McNamara
Change-Id: Iab187468cf25b4a4afc7c79578677156ff224df9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99651 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29Remove some unused includesMiklos Vajna
Change-Id: I9af7e2fa0a450ebe396c0f049831a20100dbdc9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99659 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2024-06-21 22:55:51 +0000