Age | Commit message (Collapse) | Author |
|
fix some problem appear when delete the right border.
Change-Id: I2bd1d69142bb0a920bdb58c833f8cbbb461a8350
Reviewed-on: https://gerrit.libreoffice.org/3305
Reviewed-by: Ahmad Harthi <aalharthi@kacst.edu.sa>
Tested-by: Ahmad Harthi <aalharthi@kacst.edu.sa>
|
|
At least I think so. Something more complicated is needed, or at least
lots more experimentation.
Change-Id: If511697de12ca8576720d67c80113c579eb66741
|
|
Change-Id: Iff043de250fb1d81fbd4901a15f7935006edc2df
|
|
Change-Id: I10ede9fe8f4694366101458a0ce82b54148cda61
|
|
Change-Id: I30fd0aa3ab337e62023d5adec9a0033b78959703
|
|
In case the frame is AutoSize and the nominal height is less than the
real height, we used to end up with textboxes having height small enough
that some of the content was unreadable.
Instead, do what the WW8 export does and relay on sw::Frame to provide
the layout size.
Change-Id: I2a6cf4373c8565eef780273745a6ef27ddc65753
|
|
See also: i#61075, i#89667, i#111684
Found by: Yan Ji
Patch by: zjchen
Review by: Oliver
(cherry picked from commit 2eeb8010f1afbe47b56387a5ba96db41ece13fcc)
Conflicts:
sw/source/filter/ww8/ww8par5.cxx
Change-Id: Ia53b599c01d1a4b46bd52eac8a933ac6c0605586
|
|
Reported by: Yan Ji
Patch by: Oliver-Rainer Wittmann
Review by: Andre Fischer
(cherry picked from commit 66cef81342b38e23c6785c101fe204a9512f0646)
Conflicts:
sw/source/filter/ww8/ww8par.cxx
Change-Id: Ia014c0c3b9fb78caf8e1d40bd629eb685d40fdd3
|
|
Our importer could deal with the frames without these, but not Word.
Change-Id: I6f7d13aba45129357fcf8c11e60d5a9dbc7a8ca2
|
|
Change-Id: I0ff75f1dc084f426846ac4f67db85a5d932d7bee
|
|
Apple llvm-g++ 4.2.1 with _GLIBCXX_DEBUG won't eat boost::bind with
IMark::StartsAfter, and MSVC 2008 with _DEBUG even doesn't like
IMark::StartsBefore.
They evidently try to call the comparison operator with arguments in the
wrong order.
Change-Id: Ib11a79a459e84ac9d7046824678ad4ccdacc67d0
|
|
The mbLayoutInProgress bool was effectively unused - only set and reset, but
the only place that was checking for that was in lcl_RecalcRow(), again, only
to set and reset it.
Worse - with the document from i#23187, the mbLayoutInProgress was set / reset
on a page already disposed in SwFrm::InsertPage() which was causing the crash
here.
So let's get rid of all this mbLayoutInProgress, its getter and setter, and
NotifyLayoutOfPageInProgress class.
Valgrind, thank you that you exist, would have never found it without you! :-)
Change-Id: I9a9b604f8a21bb50e21af1b20b8db76d2c0504bd
|
|
Export these as new-style frames. Not counting future possibilities,
this commit finally fixes the following problems:
- borders: spacing to contents wasn't exported at all
- wrap: top/bottom and left/right spacing exported even in case they do
not equal
Change-Id: I058e00e677e20bc9501b8de320f941f256e8b6f1
|
|
Change-Id: Ie0a40b5aaf26185546916843a913d4be47f7b6fb
|
|
Add export MACROBUTTON field codes in AttributeOutputBase::TextField
Found by: yan ji
Patch by: Lei De Bin
Review by: Chen Zuo Jun(cherry picked from commit b51d354f043d19c1a8f22e1cfff6d0b43eb62b5e)
Conflicts:
sw/source/filter/ww8/ww8atr.cxx
Change-Id: I419ce091bb676aecfe8b53660549da40eec6057f
|
|
This was originally fixed in commit 792cbc03aef3873ba89c61db708898d96d6a52f8
due to fix of i#99564.
But later we reworked the handling of empty paragraphs in tables in commit
56b2cf0c10d9caa01ebae1d80465e342d046a85c, which caused the fix from i#99564
to regress.
Change-Id: Ief063181cee87c7cd43404469247d85eb96bcfe1
|
|
Change-Id: I9321dcf9d863cb59eee9b2a012d887a17cb1b454
|
|
- consider upper space amount only for page grids in squared page mode
Found by: louqle <louqingle at gmail dot com>
Patch by: Oliver-Rainer Wittmann <orw at apache dot org>
Review by: zjchen <zjchencdl at gmail dot com>
(cherry picked from commit 53ba60618af3977f5e5488225dcf050a517fb5b8)
Change-Id: If6592a41f0ef67cc20fa8b3ddaefa36571561f85
|
|
- correction of condition interpreting <LayoutInTableCell> attribute
- include support for Microsoft Office 2010 version
Found by: louqle <louqingle at gmail dot com>
Patch by: Oliver-Rainer Wittmann <orw at apache dot org>
Review by: zjchen <zjchencdl at gmail dot com>
(cherry picked from commit 3b8b3136a51af56321a1a35fcdd9ec1d7126daa3)
Conflicts:
sw/source/filter/ww8/ww8graf.cxx
Change-Id: I065ba88f0e08c5c5e892665933587fa2b796226e
|
|
We now have hectares of empty space in the English ui on the right side because
the other tabs are wider than this one.
What to do with the extra space, leave it on the right, or consume it in some
other way ? I'm inclined to spread things around the available space. If we set
our elements to expand to consume it (but left align the spinbuttons within
their expanded space) then we get a page that looks very like the original.
I'm not entirely sure if I prefer it this way because it's genuinely more
pleasing to the eye, or because it's just familiar looking this way.
Change-Id: Iafe60713eb8c6f0bd1ecd70e3f288d52b453a247
|
|
It appears I have a small bug in how size-groups and/or generic size-requests
work. It seems that margins should be part of the request, but I'm adding those
on after the request, not as part of the request. But we can workaround that by
putting a one element box around the elements with margins and put those boxes
into the size group instead. That way it works now, and will continue to work
after I change the request+margin logic
tristates are a pain, They are always set to "state unknown" on .ui load, while
in .src load they default to "state nocheck". So to be super sure that the
logic is unchanged set them explicitly initially in .cxx to "state nocheck"
restore accessibility relationship between tristate used as a label and the
labeled thing.
Change-Id: Ibf4879c3e9a4ecc4726896479377f51bf727b238
|
|
Conflicts:
sw/UI_swriter.mk
Change-Id: I5280ddaa714db0f9ffd61cf400acf9a9fcc1087b
Reviewed-on: https://gerrit.libreoffice.org/3337
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
fix: While deleting any box from chart data provider, verify whether there are
any invalidate chart data sequence inside, if so, catch the exception and
remove it.
Patch By: Peng Chen
Found By: yanji
Review By: jsc
(cherry picked from commit a92e353922d63d785e3d46aa1a4783846a9dea18)
Change-Id: I239824e92d13e42b83674dbdeaeef053f1e6ea9a
|
|
When some import filter fix arrives in, and the submitter submits a test
file, but doesn't provide a matching testcase, we accept the patch, as
it's better than nothing. This script will search for such files,
providing kind of a TODO list for what testcases have to be implemented.
Change-Id: I713fe2f0aef4cbca66ba913baf54b7bd28ba2471
|
|
i.e. use the same algorithm for assigning replacement ids for both get and set
exp fields.
Otherwise, consider for ex.
1. fields exists with ids of 1 and 2 in master document
2. a field exists with id of 1 in subdocument and must be reassigned a new
id to not collide with the pre existing master ids
In get orig algorithm assigned first unused slot of master to subdocument field
i.e. 0 unused in master, so subdocument:1 converted to master:0
In set orig algorithm sorted all used master slots and assigned largest used id
plus 1 (therefore unused) to subdocument field i.e. largest id used in master is
2, so subdocument:1 converted to master:3
so get can't find set and error's out with:
Error: Reference source not found
Change-Id: Ie8758dc22cf8deeeeff079532284e57eeaf4a9bd
|
|
It crashes after adjusting the table size.
fix: Recorrect the logic of code in SwChartDataSequence::Dispose(), release the
relationship inside.
Patch By: Peng Chen
Found By: yanji
Review By: jsc
(cherry picked from commit 3977937c2d96133c7d53c289cc9e218bb13095f4)
Change-Id: I09e9c390527402e5f91031e7370910e93cf70fa7
|
|
as pkacer points out, also use the 12 pixel indent
for dependant controls that mduffy suggested as the
best default
Change-Id: If854ec394b4233bb821f37be9c784c1ccd80b912
|
|
And remove the remaining SetPosPixel calls of layout controlled elements, they
are now unnecessary and get overridden by the layout anyway. Including the ones
left over from the printer options conversion.
Tweak things for 6/12 spacings.
Change-Id: Ifb460fb966452c10a9ac08c6f8cd57b96a2166f0
|
|
Change-Id: Ifa11da48867303dbecd2ef104f2c0842aaeb5d72
Reviewed-on: https://gerrit.libreoffice.org/3325
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I467f6383ec469f5719fd49914d81605b2a5679a1
|
|
Change-Id: Ie78b7ce399ba34485146ca7622c59d31f8105d02
Reviewed-on: https://gerrit.libreoffice.org/3229
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|
|
I plan to use it to deliver all */uiconfig files, not just .ui, as a
preliminary step to get rid of postprocess/packconfig.
Change-Id: Ie7b4434b2f247165e3ab69a4d0c193418720a149
Reviewed-on: https://gerrit.libreoffice.org/3225
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|
|
The last file in this directory with german comments.
Change-Id: I7856e383e032a98fb08a1299a77eb41636549a65
Reviewed-on: https://gerrit.libreoffice.org/3319
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
also checked and fixed memory leaks caused by not deleting
SfxStyleSheetIterator instances.
Found by: Chao Huang
Patch by: Chao Huang
Review by: alg
(cherry picked from commit aee8221b3fbe64d8e88aa3a1b630214807cd86f0)
Conflicts:
sc/source/core/data/stlsheet.cxx
sc/source/filter/xml/xmlfonte.cxx
sfx2/source/doc/objcont.cxx
svl/source/items/style.cxx
sw/source/core/unocore/unostyle.cxx
Resolves: #120077# ALG: Reverted r1354011,
adapted all usages of SfxStyleSheetIterator and CreateIterator to use
boost::shared_ptr
(cherry picked from commit ec1819f218b94bed1556653e1b2b816a65da61ef)
Conflicts:
sc/source/core/data/stlsheet.cxx
sc/source/filter/xml/xmlfonte.cxx
sfx2/source/doc/objcont.cxx
svl/inc/svl/style.hxx
svl/source/items/style.cxx
sw/source/core/unocore/unoframe.cxx
sw/source/core/unocore/unostyle.cxx
26937d4d65562b14de0aea59a7b01cc4334f73c1
Change-Id: If99bf3ee399292ec269d68b36ee78ed63f033215
|
|
Change-Id: Ia5507f8d1ec18a45d3128c809d03f8f41849f93c
|
|
Change-Id: I3640f4c791e09e39998ec25858baebc37b58b6f6
|
|
There were two problems here:
- Writer textframes don't have an AnchorPosition property, use
compareRegionStarts() instead
- turns out DOC/DOCX import doesn't create Write textframes when the
shape has no text, doing so in the RTF import fixes the other two
testcase as well.
Change-Id: Ib2b4a0b7f8317d300fd532daea22568e33eceb53
|
|
I'm not sure yet if the tests should be updated or they signal real
problems, I'll came back to this later.
Change-Id: Ie2570f01e07e557281d2577471a49a730a894393
|
|
Change-Id: I62122e298f1434aa9e44c8f3fdfb7f710513617d
|
|
This reverts commit 6c8c54ee90a2a8d3a8d35b7e89fb39770500936f.
Conflicts:
solenv/gbuild/extensions/pre_MergedLibsList.mk
Change-Id: I6393507344297990dfcc6e234c7b0e503a8bd10b
|
|
This is nice to make them more easily debuggable.
A series of crude hacks are employed to bootstrap enough services from
python so the current tests run.
This is only tested with system python3 on Fedora.
Change-Id: I5e06741e55ead7fddec41ff776ff8ca5d2399469
Reviewed-on: https://gerrit.libreoffice.org/3215
Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de>
Tested-by: David Ostrovsky <David.Ostrovsky@gmx.de>
|
|
Extract boostraping code from convwatch.py to unotest.py. Use python builtin
unittest module as unit test framework. Specify the unit test modules in make
file. Another option would be to use discover mode of unittest module.
Add __pycache__ to global .gitignore to keep the source directory clean.
Another option would be to deliver the unit tests to workdir prior to test
execution.
Currently only system python3 is supported.
Change-Id: I2692817673f786e950e1176a17c7675f989755b6
Reviewed-on: https://gerrit.libreoffice.org/3214
Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de>
Tested-by: David Ostrovsky <David.Ostrovsky@gmx.de>
|
|
Change-Id: I9d0143cc55471eb70d4c16ff1fbb33b2ae74eaff
|
|
Change-Id: I977e37931a221d1a104b13a21171e50117985c02
|
|
Change-Id: If016e387aae1a36d6d78bbefd52b231a49201617
Reviewed-on: https://gerrit.libreoffice.org/3270
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I66f527ff7463852f65e1a3f02ddcea60d329147a
|
|
Change-Id: I74427d1e0059808f04960c648b93245b06c20f7f
|
|
the service already existed, it just needed an IDL file
Change-Id: Iccd283f3537f8c8d57b2c2d68609dd9ef025da0b
|
|
the service already existed, it just needed an IDL file
Change-Id: I4410dbd1e047e5e7e83c84f0b0de7155cc4fa41c
|
|
Change-Id: I45164d4d669894888417c24a1bb95c7b5b88a35b
|