summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2018-07-29Fix typosAndrea Gelmini
Change-Id: I483680622a75affb9822bbf5fc4d14512961493f Reviewed-on: https://gerrit.libreoffice.org/58130 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-29remove unused parameter rFontJochen Nitschke
Change-Id: Iaccae5a81e555e27924452b87489e33629988b5d Reviewed-on: https://gerrit.libreoffice.org/58280 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-07-29cppcheck: knownConditionTrueFalseJochen Nitschke
Change-Id: I531667ef580bfa81126cdb3a8d227c9e8783e02c Reviewed-on: https://gerrit.libreoffice.org/58279 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-07-29coverity#1401328 Uncaught exceptionCaolán McNamara
Change-Id: I9855d38d095ab726cd4c63573b71313f6bcb2ef8 Reviewed-on: https://gerrit.libreoffice.org/58274 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-28writerfilter: unit test that no w:default still uses "Normal"Justin Luth
Note: the unit test does NOT test the changes in GetCurrentParaStyleName. That is just a logical change and this unit test asserts the validity of the intention. Word 2013 was used to confirm that Normal is used for styleless paragraphs even if it is not marked as "default". Change-Id: I405591b40ed9028b292e99ba2833c25a24e089ac Reviewed-on: https://gerrit.libreoffice.org/58161 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-07-28Missing include (Windows --disable-pch)Stephan Bergmann
Change-Id: I9e8e5da968c777519a0c3d2b1de6de40b0730900 Reviewed-on: https://gerrit.libreoffice.org/58181 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-28-Werror=deprecated-copy (GCC trunk towards GCC 9)Stephan Bergmann
...in SfxPoolItem-derived classes that have a user-provided copy assignment op (to override the explicitly deleted one of SfxPoolItem, cf. 727878a7d8ae25342db75173cc314fa330ccc077 "Remove unused copy assignment ops of SfxPoolItem-derived classes"), so GCC 9 would warn about the implicitly-defined copy ctor. Mark all those with "SfxPoolItem copy function dichotomy" comments so they can be found again should the odd design of SfxPoolItem ever be changed. Change-Id: If206716747c42205ae4822a3f54c9de037c75286 Reviewed-on: https://gerrit.libreoffice.org/58172 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-27ofz#9607 AbrtCaolán McNamara
Change-Id: I42a4cba41df0e20ef20984b18bfb605009aae1cb Reviewed-on: https://gerrit.libreoffice.org/58186 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-27sw: avoid -Werror=deprecated-copy (GCC trunk towards GCC 9)Stephan Bergmann
...by explicitly defaulting the copy/move functions (and, where needed in turn, also a default ctor) for classes that have a user-declared dtor that does nothing other than an implicitly-defined one would do, but needs to be user- declared because it is virtual and potentially serves as a key function to emit the vtable, or is non-public, etc.; and by removing explicitly user- provided functions that do the same as their implicitly-defined counterparts, but may prevent implicitly declared copy functions from being defined as non- deleted in the future. (Even if such a user-provided function was declared non-inline in an include file, the apparently-used implicitly-defined copy functions are already include, so why bother with non-inline functions.) Change-Id: Ib4a48431398d40858d9e2ee1fd685b1f223a5423 Reviewed-on: https://gerrit.libreoffice.org/58168 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-27-Werror=deprecated-copy (GCC trunk towards GCC 9)Stephan Bergmann
SwVectorModifyBase and its DestructorPolicy look like they beg for clean up, but it's not immediately clear to me what the best solution would be, so just mark the dangerous status quo with a TODO comment for now. Change-Id: I24164553baefb124969d4ac37247dabdaead0cd5 Reviewed-on: https://gerrit.libreoffice.org/58169 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-27tdf#117988 writerfilter: IgnoreTabsAndBlanksForLineCalculationJustin Luth
Introduced in LO 4.0 in a mass copy of compat settings in commit 355d25eac764713f4d52eac801ade6e2ff1deab0 Change-Id: I0d95941ff2815a43e571be1a6a0dbab1d12185d6 Reviewed-on: https://gerrit.libreoffice.org/57991 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-27Related: rhbz#1602589 silence leaked_storageCaolán McNamara
Change-Id: I21cc4af40429fa3ef4284d6c0ea592b05bf36620 Reviewed-on: https://gerrit.libreoffice.org/58121 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-27Remove unused copy assignment ops of SfxPoolItem-derived classesStephan Bergmann
SfxPoolItem has the curious design of non-deleted copy ctor and deleted copy assignment op. Many derived classes then provide a non-deleted assignment op, apparently more or less on an as-needed basis. But some of those user-provided assignment ops are actually unused (and their presence causes -Werror=deprecated-copy with GCC trunk towards GCC 9 when the---implicitly- defined---copy ctor of the derived class is used), so remove them. In some cases that would still cause -Werror=deprected-copy because of a user-declared dtor, so in those cases explicitly default all the copy/move functions (some of which will then be implicitly defined as deleted). Change-Id: If0d9f1a9f3954263a39ffd27ba895d6202afa307 Reviewed-on: https://gerrit.libreoffice.org/58133 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-26make SwContentNode handle legacy ModifyNotification() again (tdf#117749)Bjoern Michaelsen
Change-Id: If5fe61b6bfd4012be63c27d531100018fb31dd21 Reviewed-on: https://gerrit.libreoffice.org/58024 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-07-26tdf#41063: don't jump to cursor when savingMike Kaganski
Reuse the fix from commits e12184393f0591b5c5d9218062cc0a4bced6d4e6 and 36c84fa3fbd03e5f651ba9d81e321566c8fcdbd0. Change-Id: I5b7cdc321c6e30e994732d2c0295e494a172a2e2 Reviewed-on: https://gerrit.libreoffice.org/58034 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-26tdf#118539 - Recent Characters Toolbar Dropdown Control on toolbarheiko tietze
Change-Id: I2d1ec76b11c44f258b2bfbbb7d3f00259bfb4f1f Reviewed-on: https://gerrit.libreoffice.org/58045 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-07-26tdf#109077 sw textbox: fix as-char shapes with custom print area in paraMiklos Vajna
Regression from d379d18666aa42031359ca8eb34b0021960347ae (oox: import WPS shape with text as shape with textbox, 2014-06-18), the position of the textbox should be relative to the print area of the text frame, not to the text frame itself. Change-Id: I2b591dc46ad4967edd8a1691d9b100ef0d74bed3 Reviewed-on: https://gerrit.libreoffice.org/58009 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-26weld SwTextGridPageCaolán McNamara
Change-Id: I4f8e5f643126bea5deef7636b6d20f8080cb6662 Reviewed-on: https://gerrit.libreoffice.org/56309 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-26loplugin:useuniqueptr in WW8PLCFx_PCDAttrsNoel Grandin
and make WW8PLCFx_PCDAttrs store a reference to the vector in WW8ScannerBase rather than storing pointers to the data() inside a vector. yuck. Change-Id: I1a74a0f9cd9bf4669a7e49e2a56282d49be834cb Reviewed-on: https://gerrit.libreoffice.org/58023 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-26loplugin:useuniqueptr in WW8PLCFx_SubDocNoel Grandin
Change-Id: If8b9b999fd46022b5be0a3353e58653f5a42a06c Reviewed-on: https://gerrit.libreoffice.org/58022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-26loplugin:useuniqueptr in WW8PLCFx_Fc_FKPNoel Grandin
Change-Id: If1a8a0301a94c6303f7fe0db52fb3e5ae8c04715 Reviewed-on: https://gerrit.libreoffice.org/58021 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-26loplugin:useuniqueptr in SwWW8ImplReaderNoel Grandin
Change-Id: I81473abfd71f816495fe562dd57f987df03c11ab Reviewed-on: https://gerrit.libreoffice.org/58019 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-26loplugin:useuniqueptr in WW8ExportNoel Grandin
Change-Id: I1211daba231e4c5557dad06e8392a28fca922ab7 Reviewed-on: https://gerrit.libreoffice.org/58018 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-26loplugin:useuniqueptr in MSWordExportBaseNoel Grandin
Change-Id: I73c43bd95350a8ebb7373872d58fa8911736a0a3 Reviewed-on: https://gerrit.libreoffice.org/58017 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-26loplugin:useuniqueptr in SwWW8ImplReaderNoel Grandin
Change-Id: Id924a16aa9ee2935606bf89d676145d1f68f236e Reviewed-on: https://gerrit.libreoffice.org/58020 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-26loplugin:useuniqueptr in DocxExportNoel Grandin
Change-Id: I8d98585fa759070a82bf5738d20b018ec9fbabf0 Reviewed-on: https://gerrit.libreoffice.org/58016 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-26loplugin:useuniqueptr in SwWrtShellNoel Grandin
Change-Id: I570b45e4174375be9e30f6ebc8c8171cace78990 Reviewed-on: https://gerrit.libreoffice.org/58015 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-26loplugin:useuniqueptr in SwXTextDocumentNoel Grandin
Change-Id: Iafe979a9a6c6f92226a25dc52b510682c5e5924f Reviewed-on: https://gerrit.libreoffice.org/58014 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-26loplugin:useuniqueptr in SwGlossaryListNoel Grandin
Change-Id: I208d46c27e5fefb20fbc9e049a0b3b36f7be4cbb Reviewed-on: https://gerrit.libreoffice.org/58013 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-26loplugin:useuniqueptr in SwGlobalTreeNoel Grandin
Change-Id: I3499860f02e8fcdd5177f66cb648f7bdb12e4f6e Reviewed-on: https://gerrit.libreoffice.org/58012 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-26loplugin:useuniqueptr in SwAnnotationWinNoel Grandin
Change-Id: I6c362954a8004a246773e6e72137d6eafb6e019e Reviewed-on: https://gerrit.libreoffice.org/58011 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25-Wc++11-narrowing (clang-cl)Stephan Bergmann
...from vector difference_type (aka 'long long') to 'long' Change-Id: I2a1569760ef219655936fa5c10f0e6fb85b5a504 Reviewed-on: https://gerrit.libreoffice.org/58004 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-25tdf#118777: Disable signature line slot if non-text objectKatarina Behrens
both in sw and sc Change-Id: I54f7ec336026013d09ac6262779e7fcbd17c2084 Reviewed-on: https://gerrit.libreoffice.org/57949 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-07-25ofz#7886 reject bogus text offsets inside fibCaolán McNamara
Change-Id: I7e81d13c199301cc4a049081476feac6e1507bd0 Reviewed-on: https://gerrit.libreoffice.org/57972 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-25convert pFontA to std::vectorCaolán McNamara
Change-Id: I8045047a963930c4a0dca2d1eaa0dcb6362b8e53 Reviewed-on: https://gerrit.libreoffice.org/57971 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-25loplugin:useuniqueptr in SwPageGridExampleNoel Grandin
Change-Id: Ie173b7ea280e922ed7aaaec6efca08ad0d95ffd0 Reviewed-on: https://gerrit.libreoffice.org/57940 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwViewNoel Grandin
Change-Id: Ifcb8320dff5e596afe1240280f64099480a6721c Reviewed-on: https://gerrit.libreoffice.org/57947 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25tdf#106174 writerfilter: bidi - prev adjust? prev bidi?Justin Luth
Four situations to handle: 1.) bidi same as previous setting: no adjust change 2.) no previous adjust: set appropriate default for this bidi 3.) previous adjust and bidi different from previous: swap adjusts 4.) previous adjust and no previous bidi: RTL swaps adjust The previous method was pretty heavy-handed, especially when clobbering the inherited ParaAdjust value. It essentially only handled situation #2. There are several commits that this one builds on or that enhance it. Look in this bug 106174 and in bug 72560. Change-Id: I07192ed93d50b07911cc8134a4ee57da87023d78 Reviewed-on: https://gerrit.libreoffice.org/57196 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-25sw: prefix members of SwGetExpField and SwGetRefFieldMiklos Vajna
Change-Id: I703357694eb2f880fa9cc5240fcc5610bd34e924 Reviewed-on: https://gerrit.libreoffice.org/57950 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-25loplugin:useuniqueptr in SwFrameSidebarWinContainerNoel Grandin
Change-Id: If802bc040f49f6a78068bbcf2b1247a98987be11 Reviewed-on: https://gerrit.libreoffice.org/57938 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwXViewSettingsNoel Grandin
Change-Id: I29c70ad5b6d5e120d8dc709d279407d3100373b7 Reviewed-on: https://gerrit.libreoffice.org/57948 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwSrcViewNoel Grandin
Change-Id: I550d184ddd158e32abc353f8f1d458319bd4c2c5 Reviewed-on: https://gerrit.libreoffice.org/57946 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwView_ImplNoel Grandin
Change-Id: Id92590b00dbcd9b64ca90116fb6a275d66001519 Reviewed-on: https://gerrit.libreoffice.org/57945 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwModelessRedlineAcceptDlgNoel Grandin
Change-Id: I29dcfce3cc9977454f29cf21efb38dbe14f5c14f Reviewed-on: https://gerrit.libreoffice.org/57944 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwInputWindowNoel Grandin
Change-Id: If9ea84c6402269483d74a64b4b79a1f47f01c88d Reviewed-on: https://gerrit.libreoffice.org/57943 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwHHCWrapperNoel Grandin
Change-Id: Id651533b725c61f2fabd6ac51d640a42b06e6eea Reviewed-on: https://gerrit.libreoffice.org/57942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SdrHHCWrapperNoel Grandin
Change-Id: I1695dcf5af4f51e118b0286229e00896b09ec0bd Reviewed-on: https://gerrit.libreoffice.org/57941 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwSrcEditWindowNoel Grandin
Change-Id: I64d8a4ab60df95672363df7a4ac65cf4d2f9c8c2 Reviewed-on: https://gerrit.libreoffice.org/57939 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwEditWinNoel Grandin
Change-Id: I93dc00565c5ae99be774300bdde92e08546b3571 Reviewed-on: https://gerrit.libreoffice.org/57937 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwPostItMgrNoel Grandin
Change-Id: I63dd541ac975648083d75fe5ce1ef86e99016faa Reviewed-on: https://gerrit.libreoffice.org/57936 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-30 11:55:15 +0000