summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2018-09-30weld SvxLineEndDefTabPageCaolán McNamara
Change-Id: I3e947511bbffae4cd48388b17a8fb9a13d453bab Reviewed-on: https://gerrit.libreoffice.org/61139 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-30weld SwMailConfigDlgCaolán McNamara
Change-Id: I6295eeb6938f654967d2fbfc86acd90b18d9d16e Reviewed-on: https://gerrit.libreoffice.org/61107 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-30ofz#10635 oom in tight OUString concat loopCaolán McNamara
Change-Id: I56944e14b7d2b2dc0946b76360b906447e024f06 Reviewed-on: https://gerrit.libreoffice.org/61154 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-30weld SwTestAccountSettingsDialogCaolán McNamara
Change-Id: Idead8d63dc472403e15eb9adf3cb82467e4d6721 Reviewed-on: https://gerrit.libreoffice.org/61106 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-29tdf#92026 docxexport: eliminate fake tblBordersJustin Luth
This patch depends on tdf#119760. The border was based on whatever cell A1 had, but that fake default was never passed to the cell's functions, so the table border definition served no purpose whatsoever. Cells had no idea whether they needed to override those default borders, and this was bad for non-borders, because then the default borders were assigned instead of none. The other option would be to properly fill m_aTableStyleConf, but that didn't seem valuable. Better, and less code churn, to just eliminate the function altogether. (Well, the empty function kept in place as a placeholder for someone who decides it could be useful to reduce the number of borders written out per cell.) Unit test fdo80097.docx's fix was just trying to prevent an invalid table border. Since that is still obviously true when no table border is defined, it is valid to just eliminate this part of the test. (Having a table definition wouldn't be invalid in the future, so I'm not testing for zero instances.) Change-Id: I983dbe120bfc3354fefd14bc95ac01abccea7ea8 Reviewed-on: https://gerrit.libreoffice.org/60989 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-09-29just *one* button to have has_default setCaolán McNamara
Change-Id: I7c4253a5c1a2c838b832c430bb3d28fee6bdf27a Reviewed-on: https://gerrit.libreoffice.org/61093 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-29weld SwNumFormatDlgCaolán McNamara
Change-Id: I8f7acf1b662d2357f810ff3c103670df2e58757f Reviewed-on: https://gerrit.libreoffice.org/61089 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28fix issues found by bin/ui-translatable.shAndras Timar
Change-Id: I443aeea9dd21e34110307e9ef5f9db4b13c50b39 Reviewed-on: https://gerrit.libreoffice.org/61080 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-09-28sw layout-level redline hiding: add more doxygen documentationMiklos Vajna
Thanks Michael Stahl for the conference talk that was the input for these. Change-Id: Ia48248f4739218ee7832559353aab06183a934d7 Reviewed-on: https://gerrit.libreoffice.org/61079 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-09-28Fix DI_TITEL -> DI_TITLEAndrea Gelmini
It passed "make check" on Linux. Change-Id: I3239622286c07914f88727ffdbb0be8d2ca724ea Reviewed-on: https://gerrit.libreoffice.org/61084 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-28loplugin:unusedmethodsNoel Grandin
Change-Id: I5f9ef043d76c55f2c761fd08a2bc1dae66b675c8 Reviewed-on: https://gerrit.libreoffice.org/61073 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-28loplugin:useuniqueptr in SwCellStyleTableNoel Grandin
Change-Id: I9e589efa8ee8e11e6518f61f80f0e4c114867b4a Reviewed-on: https://gerrit.libreoffice.org/61001 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-28gla11y: check element visibilityJan-Marek Glogowski
Add warnings for different visibility settings in the "label-for" and "labelled-by" elements. Sine LO doesn't support multiple annotations per accessibility element, we have to switch them manually, if we change the visibility of one element of a pair. Change-Id: I9b3d941248b804b8435591536277677e99b77340 Reviewed-on: https://gerrit.libreoffice.org/61050 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-28sw: new unit test for XTextRangeCompareSerge Krot
Change-Id: Ia0d216b94f8090c3479c6e4c593baf84cb28e5e2 Reviewed-on: https://gerrit.libreoffice.org/61005 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-28loplugin:useuniqueptr in SwTable::NewInsertColNoel Grandin
Change-Id: If22b13087ab193ed37ca092c2b252579d5ac5d0e Reviewed-on: https://gerrit.libreoffice.org/61003 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-28loplugin:useuniqueptr in DocumentListsManagerNoel Grandin
Change-Id: Id179245161d707e27e009b6ebc53d925aae5ce0f Reviewed-on: https://gerrit.libreoffice.org/61000 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-28sw: increase horizontal line parastyle default borderwidthJustin Luth
RES_POOLCOLL_HTML_HR had the absolute minimum width of 1 (0.05pt). Dividing by 3 in the "convert to word size" formula returned zero. It looks like import or export must increase the size to 3 because round-tripping in ODT format loads in a larger value that works when resaving as .doc. cui/source/tabpages/border.cxx sets the default for a double style border to 10, but the minimal value of 3 will be better since it matches the ODT round-tripped value (and looks more like a single line which people probably expect from the horizontal line). Change-Id: I32a90f2add3fe746359cd9cece14762ccc2a58c1 Reviewed-on: https://gerrit.libreoffice.org/61022 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-09-28tdf#119760 writerfilter: cell border priority over tblBorderJustin Luth
If the tblBorder does not exist, or if first row's left-border has a different sized border than the overall table settings, use the cell's lineWidth value to determine the the spacing needed. The potential regression here is the spacing given to the cells. However, the current calculation is totally wrong (it needs to be based on per-cell, not on some table-level default) and so it was "wrong" a different way before. The unit test shows this visually. Plus, MS Office version are inconsistent in handling this unit test. The latest versions base the position on the *last* row and not the first row. The key reason for making this change is to support a table that doesn't have a table default, needed to fix tdf#92026. Change-Id: I319513a2f5550c1527dc564fb8b3806d1251a0c2 Reviewed-on: https://gerrit.libreoffice.org/60988 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-09-27sw: fix copying of PageDesc follows in SwDoc::AppendDocMichael Stahl
The problem in the bugdoc is that there are 2 styles; "First Page" has "Default Style" as the follow, and vice versa. When the "First Page" style is copied, its follow is copied as well, but the follow of the follow doesn't point to the *new* "First PageN" style that was just created, but the original "First Page" one. Change-Id: Ie5b0064581a585a3a545360ea5c05f60652f0d4e Reviewed-on: https://gerrit.libreoffice.org/60993 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-09-27Fix typosAndrea Gelmini
Change-Id: Icfe120db02a70d43e4120d1f4cbb2704640d3990 Reviewed-on: https://gerrit.libreoffice.org/59470 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-27loplugin:methodcycles more graph theory for the winNoel Grandin
implemeent a reduction approach, which is good at finding virtual methods that only themselves or their virtual partners. The accessibility GetVisArea stuff is dead since commit 891e41fac81fbd8d5cdb277b26639abfd25a7143 Date: Wed Apr 4 11:23:22 2018 +0200 dead code in AccessibleTextHelper_Impl::UpdateVisibleChildren Change-Id: I78d9d8bca585ecec8394f2c3fe2baa93db0e58f5 Reviewed-on: https://gerrit.libreoffice.org/60912 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27sw: new unit test for XAutoTextGroup and rdf::URIVasily Melenchuk
Change-Id: I989ff797ddcd4ce77ac9b87fde2a2f8f75dbbc6b Reviewed-on: https://gerrit.libreoffice.org/60961 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-27loplugin:useuniqueptr in SwReader::ReadNoel Grandin
Change-Id: Iff7936e440951e65653ef42ce5a2aebd22a03029 Reviewed-on: https://gerrit.libreoffice.org/61004 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27loplugin:useuniqueptr in SwObjPosOscillationControlNoel Grandin
Point is a small object, no need to store separately on the heap Change-Id: Id8fb1829b711831860ad1d7709fb4bf71ae8ff09 Reviewed-on: https://gerrit.libreoffice.org/61002 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27tdf#119037 rtf (im/ex)port: new borderlinesJustin Luth
"new" borderlines (from 2012, 2014) defined in offapi/com/sun/star/table/BorderLineStyle.idl where no supported in export yet!!! Sad. const short FINE_DASHED = 14; (rtf) const short DOUBLE_THIN = 15; (rtf/doc/docx) const short DASH_DOT = 16; (rtf/docx) const short DASH_DOT_DOT = 17; (rtf/docx) Change-Id: I07fee08e17171db4baec489864fc47da107cee75 Reviewed-on: https://gerrit.libreoffice.org/60992 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-09-26tdf#119037 doc/x export: new borderlinesJustin Luth
"new" borderlines (from 2012, 2014) defined in offapi/com/sun/star/table/BorderLineStyle.idl were not supported in export yet!!! Sad. const short FINE_DASHED = 14; (rtf) const short DOUBLE_THIN = 15; (rtf/doc/docx) const short DASH_DOT = 16; (rtf/docx) const short DASH_DOT_DOT = 17; (rtf/docx) Change-Id: I085bb4c70e53241fb59a4a3c97d7741cef841412 Reviewed-on: https://gerrit.libreoffice.org/60991 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2018-09-26Fix BMP_REDLINE_FORMATED -> BMP_REDLINE_FORMATTEDAndrea Gelmini
It passed "make check" on Linux. Change-Id: Ic3e9a1c2d9ecd2fd8583592c8cf68a3916196984 Reviewed-on: https://gerrit.libreoffice.org/60858 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-26sw AdjustCellWidth rewrite for clarityJustin Luth
This section has absolutely nothing to do with the previous idea of a "wish" width. It is dealing with actual, current cell width regardless of content. Change-Id: I53b615cb7ea61554ff3f83d253b97b0e1f38d547 Reviewed-on: https://gerrit.libreoffice.org/60904 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-09-26sw: use auto when initializing with a template cast ...Miklos Vajna
... to avoid duplicating the type name. Change-Id: I98379b35baeccf685bcadecf794e73e91024da0b Reviewed-on: https://gerrit.libreoffice.org/60979 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-09-25uno: extra exception for XAutoTextGroup:removeByNameVasily Melenchuk
According to idl, removeByName() should throw NoSuchElementException on invalid element, but it does not Change-Id: I4ae84cd8c5a0f46bedeb3df6da4dee076888295f Reviewed-on: https://gerrit.libreoffice.org/60978 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-25sw: new unit test for XTextFieldsSupplierVasily Melenchuk
Change-Id: I44c2fd97beeaa328774e241459b2a631b6a72030 Reviewed-on: https://gerrit.libreoffice.org/60794 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-25sw: new unit test for XNamedGraphSerge Krot
Change-Id: I222179c92cda3e0b2503544b7f120f35957265ac Reviewed-on: https://gerrit.libreoffice.org/60815 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-25sw: new unit test for XTextTableSerge Krot
Change-Id: Ide5e7dd75ddb30eb1db61406c6811c6846d603bd Reviewed-on: https://gerrit.libreoffice.org/60694 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-25loplugin:useuniqueptr in SdrHdlListNoel Grandin
Change-Id: I83241bd2ed172594704f4b115b584dc39b234086 Reviewed-on: https://gerrit.libreoffice.org/60959 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-25tdf#119599 RTF import: fix missing deduplication of font sizeMiklos Vajna
Deciding when to and when not to deduplicate repeated direct formatting of paragraph / character properties is stricky, this bug is about a case when deduplication should happen and did not, since commit 1970a686273c5d4fc1eeb4430283e37085d9f647 (tdf#113408 RTF import style dedup: separate paragraph and character handling, 2017-10-31). Especially that deduplication works in both directions: it should remove properties which are duplicated and also should insert explicit default values for not repeated properties. Fix the problem by making the getDefaultSPRM() aware of the context (which style type it deals with), and then by making sure that only default properties relevant for the given style type are inserted. Change-Id: I35b6599cc47fa51b8754fd921c61a3b31a283547 Reviewed-on: https://gerrit.libreoffice.org/60946 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-09-24tdf#42949 Fix IWYU warnings in include/comphelper/[a-l]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I22ba2c8aec235e34cd7835b8a0a716bf3057db7a Reviewed-on: https://gerrit.libreoffice.org/60837 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-24make all the related inheritences formatted the same wayCaolán McNamara
Change-Id: I2e0c060a86cd199a640589a7599fa5f01ef77e3b Reviewed-on: https://gerrit.libreoffice.org/60943 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-24loplugin:external (clang-cl)Stephan Bergmann
Including: * expanding STDAPI to its definition (as per <https://msdn.microsoft.com/library/ms686631(vs.85).aspx> "STDAPI"), to add __declspec(dllexport) into its middle, in extensions/source/activex/so_activex.cxx; as discussed in the comments at <https://gerrit.libreoffice.org/#/c/60691/> "Get rid of Windows .def files in setup_native, use __declspec(dllexport)", having a function both listed in a .def file EXPORTS and marking it dllexport is OK, and the latter helps the heuristics of loplugin:external; however, the relevant functions in extensions/source/activex/so_activex.cxx probably don't even need to be exported in the first place? * follow-up loplugin:salcall in sal/osl/w32/file-impl.hxx Change-Id: Ida6e17eba19cfa3d7e5c72dda57409005c0a0191 Reviewed-on: https://gerrit.libreoffice.org/60938 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-24sw: prefix members of SwRedlineExtraData_Format, ...Miklos Vajna
... SwRedlineExtraData_FormatColl and SwRedlineExtraData_FormattingChanges. Change-Id: I7dedf293ba06879985d4652e073642d5a15d97ca Reviewed-on: https://gerrit.libreoffice.org/60922 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-09-24NB tabbed: graphic update writer and draw layoutandreas kainz
open calc and impress and drop down graphic menu Change-Id: I28f0e7b964a229320ede7accfd3a98e35ef113b5 Reviewed-on: https://gerrit.libreoffice.org/60778 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-09-23coverity#1401334 Uncaught exceptionCaolán McNamara
Change-Id: Id6dad66b3c55e5b3049f57e65c857db5abce50b1 Reviewed-on: https://gerrit.libreoffice.org/60901 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-23tdf#120056 reorder radiobuttons elements into desired logical orderCaolán McNamara
Change-Id: I770dad005779e7bf347221afad46633371f17a07 Reviewed-on: https://gerrit.libreoffice.org/60908 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-23tdf#108890 - "Format" in outline/chapter dialog not self-explanatoryheiko tietze
Renamed to Load/Save according discussion on BZ Change-Id: I7444ffc6b2d6158542357364fd6a282a1684a33d Reviewed-on: https://gerrit.libreoffice.org/60876 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-09-23loplugin:unusedmethodsNoel Grandin
Change-Id: I9dac9260af9955dc4a66b34c33265c6e36094322 Reviewed-on: https://gerrit.libreoffice.org/60911 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-22tdf#105444 DOCX import: don't put extra paragraphs in commentsLászló Németh
on Win32, waiting only for \r\n instead of \n in RemoveLastParagraph(). Change-Id: I8921a6a72e8397ed04edb9f339ba3f0bf5bbb98b Reviewed-on: https://gerrit.libreoffice.org/60865 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-09-21coverity#1439597 Dereference before null checkCaolán McNamara
Change-Id: I0e4f8467440662a3d8cbda642339a55cfad445d8 Reviewed-on: https://gerrit.libreoffice.org/60849 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-21new loplugin:methodcyclesNoel Grandin
look for closed cycles of methods i.e. unused code that would not otherwise be found by the unusedmethods loplugin Change-Id: I3fb052132d97aabca573bb8e9fc424201b1e2042 Reviewed-on: https://gerrit.libreoffice.org/60875 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-21ofz#10523 infinite .doc parse recursionCaolán McNamara
Change-Id: Ie39ce942bbfe724e0f9c7be6bafaf3fdc607f19d Reviewed-on: https://gerrit.libreoffice.org/60868 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-21coverity#1439598 Inferred misuse of enumCaolán McNamara
and coverity#1439596 Inferred misuse of enum Change-Id: I4edd08c46c714c3d513df5f9403ab29dfd0e2497 Reviewed-on: https://gerrit.libreoffice.org/60850 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-21coverity#1401334 Uncaught exceptionCaolán McNamara
Change-Id: I2a74e0bcba46b730067b5baca5e934f95ba265ce Reviewed-on: https://gerrit.libreoffice.org/60854 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-06-30 10:48:22 +0000