summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2016-07-13tdf#84635 - Slow layout of large tablesNoel Grandin
Based on suggestion from Aron Budea. And do something similar to most other places keeping vectors of weak references where the code looks like it will hold more than a few entries. Measurements: the 26 page file file takes 51s without my path 15s with this patch the 69 page file file takes 5m28 without my path 51s with this patch the 84 page file file takes 8m28 without my path 58s with this patch Change-Id: I8da94c525fc73ebd969e0343c6f074be4f0063b1 Reviewed-on: https://gerrit.libreoffice.org/27093 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-13GSoC Writer Table Styles export of paragraph and char propertiesJakub Trzebiatowski
+ Export of paragraph and character properties + Tests Change-Id: I689deb2c524fdcd462c69a33ad9bc2865890793d Reviewed-on: https://gerrit.libreoffice.org/27115 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-13Moved SfxModule owner to SfxApplicationMark Page
::GetAppData replaced with SfxApplication::GetModule that now returns SfxModule* SfxModule no longer registers self for ownership instead it is now registered using SfxApplication::SetModule Change-Id: Ifbbe1b2b4c5122da8e643b7926d47878d116c6c8 Reviewed-on: https://gerrit.libreoffice.org/26914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-12Resolves: tdf#100538 make searching in shape text a libreoffice-kit only thingCaolán McNamara
This effectively reverts for the normal-app commit bdc1824ea7acfa2fe9d71cdbe57882acce155577 Author: Miklos Vajna <vmiklos@collabora.co.uk> Date: Tue May 19 17:20:10 2015 +0200 SwPaM::Find: search in shapes anchored to the range The catches are that... writer will use SvxSearchCmd::Find and not SvxSearchCmd::Replace when Replacing text, and replacing it afterwards. So replace doesn't work. It might be possible to mitigate that by passing down the m_bReplace to SwPam::Find and do a SvxSearchCmd::Replace on the editeng SearchAndReplace in that case and then change the return code to not-found/found-in-writer/found-in-drawing to figure out what to do there. regexps are disabled in the ui for draw/impress, maybe because they seem not be fully implemented right wrt matching empty paragraphs, so using regexps in writer and letting them into editeng via this loophole is new territory for the editengine I think if I was trying this I'd fix regexp in editengine, then try add searching/replacing in drawing boxes sort of at the end of searching in the main document, something like how searching in frames works. Change-Id: I2875b374a7ede8edd7f479254cbc2da36488abc8
2016-07-12tdf75573 docx - complete frames before starting alternate streamsJustin Luth
An unused odd header was set to be discarded. The handling of unregistered frames occurred at the same time, and thus ended up being discarded as well. Since a frame shouldn't encompass both the alternate stream and the current stream, finalize any unfinished frames first. Change-Id: Ie9123769724da461dd265936aa6b97de7f4dfbbc Reviewed-on: https://gerrit.libreoffice.org/26972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-11GSoC notebookbar: added priorities in all Writer tabsSzymon Kłos
Change-Id: Ib9ac09392f0e50cdd5577b579e5f19d362a53a0e
2016-07-11GSoC notebookbar: File tabSzymon Kłos
Change-Id: I98640b0b4585b2fe1088b13b07dce82a185fd8bf
2016-07-11GSoC notebookbar: added image tab in the WriterSzymon Kłos
Change-Id: Id72bf97fe31625c63bb16b7796c22661cb6fe008 Reviewed-on: https://gerrit.libreoffice.org/27109 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-11sw: prefix members of SwColumnPageMiklos Vajna
Change-Id: I94bc95a25ac11de419f18490b7d466ee22631778 Reviewed-on: https://gerrit.libreoffice.org/27095 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-11tdf#99090 docx export page-break only inside a paragraphJustin Luth
If a paragraph hadn't been started yet, a w:r was being written directly in the /document/body which caused MSWord to complain about a corrupt document. Change-Id: Ie7f629869aab0f3d2405660a033c3f23bbd6baca Reviewed-on: https://gerrit.libreoffice.org/26771 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-11Fix typosAndrea Gelmini
Change-Id: I81671c9a8e7e5b878e605ac0ed6c3d8ef5c5b689 Reviewed-on: https://gerrit.libreoffice.org/27088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-07-10Remove redundant SvxGet* wrappers around LinguMgr functionsStephan Bergmann
Change-Id: Ic431ce4880d0c1277ddb411ca59b3c8e8ca36518
2016-07-09Resolves: tdf#78112 print preview underlines spelling errors...Caolán McNamara
after unrelated display option used, e.g. display field shadings Change-Id: I61cb2456fb4b048fab571d0f2c57855ea4da0336
2016-07-09tdf#100820: missing nullptr check in writer's apphdl.cxxMarkus Mohrhard
Change-Id: I32c22b1e2c6ee23ca712bde7b7f86dada654b802 Reviewed-on: https://gerrit.libreoffice.org/27067 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-08Resolves: tdf#100452 class Date full (BCE,CE) proleptic Gregorian calendarEike Rathke
... implementing signed years with year 0 gap. Date(31,12,-1) last day BCE Date(1,1,1) first day CE New class Date member functions: * AddYears(sal_Int16) to be used instead of aDate.SetYear(aDate.GetYear()+sal_Int16) to handle year 0 gap. * convenience GetNextYear() to be used insted of GetYear()+1 * convenience GetPrevYear() to be used insted of GetYear()-1 * AddMonths(sal_Int32) * operator=(const css::util::Date&) New class DateTime member functions: * operator=(const css::util::DateTime&) Made some conversion ctors explicit, specifically Date(sal_Int32) Adapted hopefully all places that used a sal_uInt16 year to use sal_Int16 where appropriate. Eliminated some quirks in date handling found on the fly. Added era handling to i18npool icu calendar setting interface, which missing was responsible for 0001-01-01 entered in Calc being set as -0001-01-01, hence subtracting one day resulted in -0002-12-31. Change-Id: I77b39fba9599ebd5067d7864f6c9ebe01f6f578f Reviewed-on: https://gerrit.libreoffice.org/27049 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-08SvxGetOrCreatePosDic parameter is unusedStephan Bergmann
...ever since fd069bee7e57ad529c3c0974559fd2d84ec3151a "initial import", so kill the equally old "TODO: remove argument or provide SvxGetIgnoreAllList with the same one" comment for good now Change-Id: Ie7b64306b8d06fc72d0bb49cc1e5fa3b00f59d6b
2016-07-08Disabled async/parallel chart loading for nowArmin Le Grand
Need to check deeper for circumstances leading to problems Change-Id: I58c9601008edc53c958d59d04a30d11bc0c1bba3
2016-07-08Resolves: tdf#100813 crash during pagination of particular docxCaolán McNamara
Change-Id: Id2c99cc6c5fe4c3a5bcf3c0b3f16b603cdd46239
2016-07-08loplugin:redundantcast: redundant static_casts in swStephan Bergmann
Change-Id: I09c1ebaf5742e983ee05942a4c7c17c6aa5179cc
2016-07-08tdf#83054 Writer: Add "Go to Page" Entry in Edit MenuAkshay Deep
Change-Id: I09026910687b019fe33d4016612b8247ff076100 Reviewed-on: https://gerrit.libreoffice.org/25949 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-08sw lok: add LOK_CALLBACK_VIEW_CURSOR_VISIBLEMiklos Vajna
With this, in case a text cursor is turned into a graphic selection in view#0, then view#1 can also hide the text cursor of view#0. Change-Id: I7de89b8537ef8b0985336793b719d93733604bff Reviewed-on: https://gerrit.libreoffice.org/27044 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-08GSoC notebookbar: container with prioritySzymon Kłos
+ extended vcl builder to parse priority + IPrioritable interface for controls with priorities + added IPrioritable as a base for VclContainer + Added PriorityHBox - box which shows controls if we have enough space PriorityHBox listen vcl events from SystemWindow to detect Resize Change-Id: I74ac1a80e7d0a061f5e7a8584dbb2abf956053c7 Reviewed-on: https://gerrit.libreoffice.org/26983 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-08tdf#64372 docx import: don't ignore continuous section breakJustin Luth
If the previous break was also a continuous section break, this break was simply ignored ever since commit 1fdd61db155cf63d5dd55cc2bfb45af33796e131. Thus, the default handler took over and assigned PROP_PAGE_DESC if there was some kind of page style known (either the first page/Standard defaults or any "converted" styles that had been created) which effectively became a new page break. Change-Id: I839570b0330ba274552cc671014e997c42765f4b Reviewed-on: https://gerrit.libreoffice.org/26567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-08oox: indentation fixesMiklos Vajna
These files had consistently no space between the "const" and "&", keep it that way. Change-Id: I5463c488d807344d67fb22ad544c049ea749be94
2016-07-07loplugin:nullptrStephan Bergmann
Change-Id: Ic37247f1e4ffe5a32e2fbb73464dfdfa59a79296
2016-07-07Related: tdf#50613 use an own instance of ThreadPoolArmin Le Grand
Using the global ThreadPool (getSharedOptimalPool()) can lead to problems when more than one usage executes and one of them already calls waitUntilEmpty() what of course influences the other usage. Thus I added an own instance of ThreadPool for async loading of chart models in writer Change-Id: I4bea64af0d36e87081abec95c75574966d0fe5b9
2016-07-07tdf#99165 avoid passing empty control points for beziersArmin Le Grand
Some graphic sub systems have problems to create correct geometry for fat line drawing when 'empty' control points are handed over for bezier curves. Avoid this by offering the mathematical correct default in that cases. Change-Id: I20f484ef4537076889d832d83581844690514acc
2016-07-07sw: tdf#50613 fix async chart load handlingArmin Le Grand
Especially if synchronous loading is requested, an async worker is on the way and we would need to 'wait' for the data. Change-Id: I20f9938738c1b46bda6b9a7f5a761e82153aed3b
2016-07-07sw: tdf#50613 fix waitFinished into a loopArmin Le Grand
Change-Id: Ic8a720657c326d8d51bb3a73688b8f02b7096488
2016-07-07tdf#50613 add support to load charts asynchronouslyArmin Le Grand
Generating primitives for chart visualisation can be moved to a paralell executed task that loads the chart, thus speeding up initial visualization. This is not possible for e.g. PDF or print targets, only for edit visualization. On fallback, the replacement images of the charts are used which are metafiles and have less quality as primitives, but load quicker. Change-Id: I68caa9e1bec50832bce535b5f54633d53cdef037
2016-07-07tdf#50613 buffer OLE primitives for chartsArmin Le Grand
If OLE is a chart, buffer the primitives used for presentation as info at the SwOLEObj, after getting them the first time using the ChartHelper. Change-Id: I6d7486185f6eac450de9328d37ea800f424f351b
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann
Change-Id: I7e7cdfa5efaf18bb47d40947d4e1d91a2c9b5a57
2016-07-07GSoC Writer Table Styles ImportJakub Trzebiatowski
This patch is implementing import of table styles (table-template). Modified shared code: Added "background" to the cell styles export. To make cell export properties map accessible by both export and import code, moved from xmloff/source/table/XMLTableExport.cxx to xmloff/txtprmap.hxx. To avoid export of default valued properties implemented XPropertyState for SwXTextCellStyle Change-Id: I8b4f12e4b51f478f8ce8fde1203cd4611d7ae852 Reviewed-on: https://gerrit.libreoffice.org/26721 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-07sw: prefix members of SwSrcEditWindowMiklos Vajna
Change-Id: I6944a398bc7689ef4d2daf4ac8b9f601c0dff450 Reviewed-on: https://gerrit.libreoffice.org/26997 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-07tdf#95367 inherit page style if no new one importedJustin Luth
CopyLastHeaderFooter doesn't do much good if the previous section has blank stylenames. (usually because of continuous section breaks). Change-Id: Ida1e42ab0b650c7c43f06539b3cc058fe5c27919 Reviewed-on: https://gerrit.libreoffice.org/26911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-07Add test for XML Range Conversionsslideon
SwChartDataProvider's XML conversion methods were untested. Also add tests for SwChartDataSequence's clone method and its get/ set property value methods. Change-Id: I6323a7af1eae747592f5016b13fb5e2e3f0b71d1 Reviewed-on: https://gerrit.libreoffice.org/26995 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-07-06clang-tidy performance-implicit-cast-in-loopStephan Bergmann
...where the first component of the pair returned by the iterator would be const, so an implicit conversion would be required. Change-Id: I62b6ddd799261e1dd63ea5c42a85d8b071f8b8b7
2016-07-06restore loplugin:vclwidget checking for calling clear() on VclPtr fieldsNoel Grandin
Change-Id: I85eda1c33016c1461d897fc0a3b70457209a7405 Reviewed-on: https://gerrit.libreoffice.org/26806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-05when disposing popup menus, don't leave dangling pointersNoel Grandin
Change-Id: Ia1b49937ba0693a567097367b99b75a3011666bf Reviewed-on: https://gerrit.libreoffice.org/26960 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-07-05a11y crash on deleting certain frame in certain documentCaolán McNamara
I've an internal RH document which crashes in a11y when a paragraph with a graphic and a drawing frame in it is deleted. The SdrObject is removed and deleted, but when SwAccessibleContext::DisposeChild is called the object does not pass IsShowing so its not removed from the accessibility map. Leaving an entry in the map pointing to a deleted SdrObject So here take the route-one approach of always removing from the map accessibility children which depend on a SdrObject which is getting deleted, whether or not it is inside the visible area at the moment. The real change here is to SwAccessibleContext::DisposeChild and to SwFrame::RemoveDrawObj Change-Id: I764cd54d6216d233756f52b5be66c80737b5e38d Reviewed-on: https://gerrit.libreoffice.org/26824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-07-05Clarify calculation precedence tdf#39440Muhammet Kara
Use parentheses to clarify the code. Change-Id: I864dc6dacadb5b9ba9dca8e0abd9fa4e6db1eddc Reviewed-on: https://gerrit.libreoffice.org/25677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-05Add test for sw_NormalizeRangeslideon
The docstring for the function gave some examples, but this method was not fully tested Change-Id: I53bca734183297a9cca860c55b27570ad0e0f3e6 Reviewed-on: https://gerrit.libreoffice.org/25886 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-07-05Add test for the TableBorderDistances struct, and the Uno Namesslideon
TableBorderDistances was not tested. Add tests for setting/getting the TextTable name and template names. Test implementation and supported service names of various XTextTable components. Change-Id: Ieb9f2983c5d421f8c8ab4c99596444fb4ff001fe Reviewed-on: https://gerrit.libreoffice.org/25888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-07-05tdf#90834 Turn in-line version control history commentskrishna keshav
cleanup in sw/source/core/layout/layact.cxx Change-Id: I495fef2fd6bab2ac0f6633134ec3fead8b023eae Reviewed-on: https://gerrit.libreoffice.org/25598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-07-04tdf#96750 docx - ensure all styles are initializedJustin Luth
Change-Id: I50467cb2798ef81dd89006768c66aa7e93cb411c Reviewed-on: https://gerrit.libreoffice.org/26892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2016-07-04sw lok: Handle lok handling code first, for PageUp/DownPranav Kant
m_aVisArea is not set in case of lok, which means m_nLOKPageUpDownOffset would never be set for lok case. Change-Id: Ie0416ebb680695430c76b25416f4744172dc3daf Reviewed-on: https://gerrit.libreoffice.org/26902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.com>
2016-07-04typo: emtpy → emptyChristian Lohmaier
Change-Id: I60cdcdc7fc38c175243c071f34295efa8739b717
2016-07-04SfxModule to use initializer_list instead of variadic argumentsMark Page
The compiler can perform type checking with initializer lists Change-Id: I1d26b56a3a2b67fe719f33d758ca9b0c95ebd4d1 Reviewed-on: https://gerrit.libreoffice.org/26852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04remove comphelper::string::removeNoel Grandin
and replace it with OUString/OString::replaceAll Change-Id: I37b1c3b51251dfd9d749d6f1060c75b3a93d7f1a Reviewed-on: https://gerrit.libreoffice.org/26850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-01clang-analyzer-deadcode.DeadStoresStephan Bergmann
Change-Id: I2b03835f83fca604f8ef4db2cb292e6123140e86
generated by cgit (git 2.34.1) at 2025-01-31 10:05:03 +0000