summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2020-05-08CppUnittest: ooxmlexport13: assert pages where possibleXisco Fauli
Change-Id: I793d63d549ecd51a301abe064a6d7c84aa1a9d2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93735 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-08CppUnittest: ooxmlencryption: assert pages where possibleXisco Fauli
Change-Id: Id4a7ed5ecab048a6249444e30a38c1ffa310f96e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93733 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-08improve loplugin:referencecastingNoel Grandin
to catch a few more cases Change-Id: I0323fba51bb2b4ba255e1db5aa0d890c5c6a2e1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93726 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-08lok: MSForms: Send also the drop down field params to the client code.Tamás Zolnai
Change-Id: Id42f428b7944d97d1b61a5b60d6e0807cb51cc95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93658 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-08tdf#132270: sw: restore unittestXisco Fauli
Removed in f9fc420dceb1ece2c98767da16a21aaff771f140 Change-Id: Ib2cc294f5efa3c1f10c43c481c9be4d1738f6fe9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93720 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-08lok: MSForms: Add callback for form field button.Tamás Zolnai
Show and hide the button and send the button area, where it should be displayed. Change-Id: I5922eb9f5e544483dd4efd12e4218d2e51270632 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93657 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-08tdf#111535 - Add First-line indent, paragraph indent, and tab spaces/Core partgokaysatir
Change-Id: Ib340e74646299c344dd770977497f59a030c86f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93165 Tested-by: Jenkins Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-08CppUnittest: ooxmlexport9: assert pages where possibleXisco Fauli
Change-Id: Ifc6593869079b6b875a5a8c15468fc1a338bc8e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93703 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-08sw: remove now unused SwBlinkPortionMiklos Vajna
Change-Id: If2ae13219f7907eb2b2a66a38bcd636dd64dfe3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93676 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-07tdf#101181: store glow radius in 100ths of mm instead of EMUsMike Kaganski
... as we do for all metric values. This fixes storing values like "190.5cm" in ODF for 15 pt (should be "0.529cm"). Change-Id: I382756af56464424dcb24ed8801d0a4203658c11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93640 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-07CppUnittest: ooxmlexport10: Assert pages where possibleXisco Fauli
Change-Id: I40cc389edf9d072f643c724bdb2c70c48edced63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93645 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-07sw: fix SwModelTestBase::parseExportedFile()Michael Stahl
Both tests in fodfexport.cxx didn't test anything becuase this was called twice and the first time the stream was created for 0-sized file and the 2nd time the existing stream was reused so still no data. Change-Id: I97794490751d1f205919619484bb0c4ed962d4a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93174 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-07replace ODFDefaultVersion usage with ODFSaneDefaultVersionMichael Stahl
Compare with ODFSVER_012 mostly works the same, except for places where namespaces are defined where the ODFSVER_EXTENDED bit should be checked. Change-Id: I86469b763bc2f903632976bc9d6ec04d543d705e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92727 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-07Related: tdf#132678 select first entry if nothing else selectedCaolán McNamara
Change-Id: I94fae0f774c587d85e682414f5d54f35f0161c30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93614 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-07tdf#132477 don't leave removed row highlightedCaolán McNamara
so that an attempt is made to unhighlight it in dnd post-processing Change-Id: I23fdf407d53c22a6bfd697e5e23c450f009c67b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93629 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-07tdf#98409 doc export: export (non-default) cell marginsJustin Luth
Previously, the only cell margins that were being exported were the row defaults from the last column. These cell margins are tricky, because multiple cells and multiple sides can be combined together into a single definition. A previous commit for tdf#73056 was needed to import these sequences. Change-Id: I513c432ec11a78c7bb52ac6fb628851192e88023 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92701 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-07tdf#118418 implement scrollSubstringTo() for gtkColomban Wendling
Define & use new accessibility scroll type compatible with IAccessible2 and extend the XAccessibleText interface to require scrollSubstringTo(). Co-authored-by: Martin Pieuchot <mpi@grenadille.net> Change-Id: Id3b2e8616892d7dcbfb41a14b72a8a457fd1dbf6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89851 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-07NB fix visible=true/false in the ui file temporaryandreas kainz
Change-Id: I38291ad6b6d724cc951e423cd16976324dca6166 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93615 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-05-07fix memory leak of xmlDoc objectsNoel Grandin
in unit tests Change-Id: Id16731bbbe2f1b0e3642722d77aba04fc98db4cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93508 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-07tdf#127421 Export and Export Direct are now available in NB customizeandreas kainz
Change-Id: I85f54f0c8808421bbe7d3c0098add207d36f2b20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93602 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-05-07sw: handle UnbreakableNumberings when replacing compat optionsMiklos Vajna
This was added in commit 74b6759ee81c95ae75046dd411d2bd0bd2324a8b (n#707157: Word doesn't break the numberings and prefers hiding them, 2011-11-10), it's off by default and on for MSO documents. Change-Id: Ie8add246816fba7077f01b9eaedc2dfda953fb1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93589 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-07writer notebookbar table background color less space neededandreas kainz
Change-Id: I0210cf1e7c8920984c3d554a7f5b131b11169a1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93599 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-05-07tdf#132637 doc import: don't open readonly for lockRevJustin Luth
Just like with forms, the password should not be required to make changes when only enforcement of track changes is specified. So just grabbag the password and let the document open in read-write mode. TODO for the overly zealous: actually enforce file->properties->security->protect track changes, and also export it. (This has been done for DOCX.) Change-Id: Ib68ec5785aa0f5dbac507a3d50059a443f7ff42b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93551 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-05-06tdf#122342 DOCX import: fix bottom auto margin in listsLászló Németh
at paragraph style based numbering. See also commit 1bf7f6a1a50ee9f24a3687240fe6ae390b905a6b (tdf#106690 DOCX import: fix automatic spacing before/after numbered para block). Change-Id: I532181019ca97a86475c9bb0a1eea1c836705bab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93581 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-05-06sw layout comments: clarify return value for MoveFwd etc.Justin Luth
Although MoveFwd and MoveBwd sound like mirror functions, their return values have different meanings, so clarify those distinctions and hint at the complexities of what move Fwd/Bwd mean in terms of pages/columns/sections/frames. Change-Id: Ie173fa3d6234c8dd466c32678134945c21f75dfd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93442 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins
2020-05-06sw from-bottom relative orientation: add ODF filterMiklos Vajna
Map between RelOrientation::PAGE_PRINT_AREA_BOTTOM and loext:vertical-rel="page-content-bottom". Change-Id: I1d614bf7c82a76285f4268b8008e08c25ef9b7f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93120 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-06tdf#101181: support for transparency attribute of glow effectMike Kaganski
Read/write support for ODF and OOXML (in ODF, loext:glow-transparency attribute of style:graphic-properties has been added). Added UI on glow sidebar panel. Not used in actual painting yet. Change-Id: I21b25d9c52c8611cd796f056374377ebf13cc2f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93565 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-06Resolves: tdf#123801 captioning issuesCaolán McNamara
revert attempt to by default create a msword roundtrip friendly caption. commit 2333786aa0eaf70c45c80e546239fb3565b1b4e7 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Mar 20 11:48:28 2018 +0000 Resolves: tdf#116474 bring hidden text property under undo control commit ebd43aee5b9cf98ed96ce28985267ad0bc980b7a Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Apr 7 13:41:38 2017 +0100 rework setting hidden property on line break commit feedd45ba2dd308af2d3a1b2f64681b9467535b6 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Oct 27 14:37:03 2016 +0100 in msword the hard-break between image and caption has a width commit ba401ee10be2fb051bc961680f35b04e4e77a32d Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Sep 1 09:39:37 2016 +0100 coverity#1372378 Dereference null return value commit 93ab0ff24cb71c36c9e7958046e96d7472b5af90 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Sep 10 15:46:57 2015 +0100 Related: tdf#93676 default to as-char inside captions Change-Id: I460046a10f36bed13e2f4651b4c0a9b9b0662015 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93559 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-06tdf#132603: sw: Add unittestXisco Fauli
Change-Id: I2706ba434034aa4307619cde12f020deb40d669e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93509 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-06sw layout: remove useless historical timelog commentsJustin Luth
While there can be value in seeing bug numbers to figure out why certain code was added, these comments seem to have no value, but are just a timelog of when a formatting change was made. Change-Id: I47ccef9c7e4cd5c76aeec46867424dd8c9d05e13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93441 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-06tdf#132373 Remove blinking character property from the UI/editorGabor Kelemen
So far from document body and Character properties tab only. Importing and exporting existing files still works. Change-Id: I42179b47c64fe5c7db0393d0d4373363d772b51e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92875 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-05-06tdf#108493 DOCX import: fix hanging indent of listsLászló Németh
when its value comes from the numbering style, but the left indentation is overwritten by paragraph settings. The problem caused by that these settings are not independent in Writer core. Change-Id: I5d6759bb215b82dfcaa5cbd3e191ac7ea8a8bb00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93478 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-05-05sw from-bottom relative orientation: fix calculation of position limitsMiklos Vajna
Create a new Writer doc, insert a rectangle with height = 10cm, try to position it 2cm above the bottom of the page, so that would be -12cm, but we limited the metric field to -2cm because 2cm was the page margin. Teach SwFEShell::CalcBoundRect() about text::RelOrientation::PAGE_PRINT_AREA_BOTTOM, then this will work without problems. Change-Id: Ib6ddccc1512d39fff5bff2e989973b156a6c2bf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93501 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-05-05remove unused nSearchFamily and nMask membersCaolán McNamara
and so SetSearchMask which doesn't have any effect anymore Change-Id: I0b7f402ce0317971d5196fc448fe2945a6a292f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93393 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05we end up making a nFamily style, not the style of GetSearchFamilyCaolán McNamara
so use that as the filter Change-Id: I91ef5b07ccbe9a4ceafa86e2331ea72bebe38145 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93492 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05help states that SfxNewStyleDlg lists SfxStyleSearchBits::UserDefined stylesCaolán McNamara
Change-Id: Ibf89d0ff1154b943a5650ac6cd6aa64a084c15cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93491 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05use SfxStyleSearchBits::All for SfxNewStyleDlg in writer, like calc doesCaolán McNamara
Change-Id: I44399a617b07acb93ca33d537bcfcc5554e1ede5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93490 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05tdf#132187: sw: Add unittestXisco Fauli
Change-Id: I767f96fd8d373df9b8cbecd9cb75ed114166d0f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93485 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-05Prefill doc count in mail merge's "Send Email" dialogMichael Weghorn
Initialize the last document number with the doc count in the "Send Email Documents" mail merge dialog, just as is done for the "Print Merged Documents" and "Save Merged Documents" dialogs already. While at it, also set maximum value for the "from" spinbutton for the "Print Merged Documents" dialog. Change-Id: Idbd6d07eb7a21f2abf27ee06e7170125e1c706f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93459 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-05-05SwMMResultEmailDialog::FillInEmailSettings: Turn check into assertMichael Weghorn
Since SwMMResultEmailDialog::FillInEmailSettings is only called from the SwMMResultEmailDialog ctor, 'm_xMailToLB->get_count()' should always return 0 here. Change-Id: I156552c17f5a53f6049d0a25231ba91143fdfe62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93458 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-05-05nFamily is the SfxStyleFamily which was modifiedCaolán McNamara
so it seems natural to use that in the force update internal list call Change-Id: Id5871bdec5f2e06be6728c4a0290e8c91681d4fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93473 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05we want to invalidate the current iteratorCaolán McNamara
if there isn't one we shouldn't need to create one to invalidate it Change-Id: Ia936f71c18c45d8e08f013ffa143c196109495ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93471 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05make the family and mask explicit in SfxStyleSheetBasePool::FirstCaolán McNamara
Change-Id: I36655b65ca00e5f7b8779a28d4a1778c8e35dc4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93461 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05nFamily is already set to SfxStyleFamily::ParaCaolán McNamara
Change-Id: Idbe36ef183148ea126e90ff14f011d403dbaa62f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93447 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05drop SfxStyleSheetBasePool::CountCaolán McNamara
and use CreateIterator to make it explicit what is being counted Change-Id: I8d76aef601533960a23c056b83a48c4f130bbe75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93446 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-04sw: moved setting shape name to earlier stageVasily Melenchuk
During setting of some shape properties undo/redo code is called. Undo/redo code should know about shape and style name. Change-Id: I5240c450d0c739a245e32e9ca6f34518f35ddda5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93214 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-05-04tdf#116883: sw: unittest for lists with complex level formatVasily Melenchuk
Change-Id: I12a9cc1d08525536182227f26e5c44c7b8a4b319 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93125 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-05-04tdf#132514 DOCX import: fix lost table style with footerLászló Németh
Table paragraphs collected for table style processing were mixed when both body text and footer contain tables, i.e. clearing paragraph vector at processing the first table resulted missing paragraph vector and table style processing for the other one. Now tables in footer, also nested tables collect their paragraphs in separated table paragraph vectors. Regression from commit 6c5da2cd7af5c2d90e4d8e9635ba8c9989c87923 (tdf#119054 DOCX: fix not table style based bottom margin). Change-Id: Ib8568d8379cfb7da869120cdc7fe12895252d661 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93415 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-05-04make Search family and mask explicit for SfxNewStyleDlgCaolán McNamara
Change-Id: Ib3e5765d37474188d6505f1d9965969ee6c24f0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93358 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-04default CreateIterator mask to SfxStyleSearchBits::AllCaolán McNamara
Change-Id: Ie79eff57646853613e8c6060adbce92dd388df5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93357 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-11 08:27:55 +0000