summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2020-08-21Fix typo in codeAndrea Gelmini
Change-Id: I6709fd9166ae0ddf4a50b4ad56a63e2c1a7192a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101109 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-21Fix typo in codeAndrea Gelmini
Change-Id: I8681bd1be07fe44ab017bce65807b9bf0afa7b42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101107 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-21use fastparser in SwXMLMasterStylesContext_ImplNoel Grandin
Change-Id: I420312d8f58a42999c7d6c3048c391ff1f44a039 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101092 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-20tdf#123390 DOCX import: fix SIGN formulaLászló Németh
Convert SIGN(x) to the equivalent, but portable Writer formula (0 < x) - (x < 0). Note: this is a temporary conversion, which supports only 1-level nesting of function calls. Adding SIGN to Writer core, it will be possible to remove portable conversion later. Change-Id: I88853fe865808427c966b8570a052b101fecdac0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101085 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-20use fastparser in SvXMLNumFormatContextNoel Grandin
which requires making SvXMLStylesContext capable of doing both fast and slow-parser paths. Change-Id: I57428b10ac2d67bc233cc978c9a0c0c3755d60e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-20tdf#132940 Crash in mergedlo!vcl::Region::operator=Noel Grandin
We had a SdrPageWindow accessing a SdPaintWindow that had already been freed. Turns that SdrPageWindow can be "patched" more than once given enough stuff going on in writer, so make the call sites restore the previous state as the stack unwinds. Change-Id: Ia1ef5c9b2f818b7873e8e739c9cdf257554e403a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101044 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-20tdf#129542 the control is already anchored to header/footer contentCaolán McNamara
DisconnectFromLayout has unset its old anchor, if we don't insert it somewhere then its old anchor is null and we crash eventually. Seeing as we're already anchored into header/footer content, albeit only in the first view of a header/footer, then allow reconnecting to layout in that mode Change-Id: I0be4d167ee7d7b932318a1318954bed0da3a4fc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100686 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-20tdf#135721 sw: fix SwSpellPopup::Execute() deleting flysMichael Stahl
Follow-up to ec579354af954867b829e7d08e4d752518c83728 : in 6.4, this is the location of the spell check menu code; not sure how to call this but it has the same bug... (regression from 28b77c89dfcafae82cf2a6d85731b643ff9290e5) Change-Id: I0e6ce9c97d810f7c92dff320d403c986a947c266 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101073 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-20tdf#135721 sw: fix spell check context menu deleting flysMichael Stahl
Kind of similar to e1629c210ad78310e3d48c0756723134a27b89df but the problem is at a higher level: SwTextShell::Execute() with SID_SPELLCHECK_APPLY_SUGGESTION should not DelLeft() + Insert() but just Replace(). (regression from 28b77c89dfcafae82cf2a6d85731b643ff9290e5) Change-Id: I78487c7841ba22ccc6751240a8e55e08a86fba32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101014 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-20sw: remove misleading initialisation from SwUndoInsLayFormatMichael Stahl
Change-Id: I5577b388b565cdab6dcf60721f0f90d2987dac05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101005 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-20use fastparser in StoredChapterNumberingRootContextNoel Grandin
Change-Id: I133f9885755ba594d8a136baa056f9ff96908a30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101018 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-20tdf#135187 DOCX import: fix table style at character formattingLászló Németh
applied also on paragraph level during import. Regression from commit 4d5c0eaf3e0d3d3bcd9e691fffee19b75f3d6631 (tdf#118812 DOCX import: fix table style preference – part 2) See also commit 5ac6f02fdc6015a5d78071570dee310febf95fc6 (tdf#105215 DOCX import: fix paragraph-length direct formatting). Change-Id: I14072c81fc4c54e376a004fa36ba76b56d2beb01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100996 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-20Set a group for radio menu itemsMaxim Monastirsky
Change-Id: If43320e1a19163f998e1e5091a307e40fe9f83f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100964 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-08-19tdf#135329 sw MS export: don't miss nextAttr fly positionJustin Luth
Step 1 - write out bypassed flies. This patch is Step 2 - don't bypass fly position. The SearchNext function was skipping some flies because it was not returning them as a stopping position (nextAttr). The time I noticed this happening was at the start of the paragraph, when there were zero-anchored paragraph flies which hadn't been processed and so they returned a non-usable minPos. With this patch, I OUGHT to have rendered Step 1's patch unnecessary. Change-Id: I9924dbf5424f5b0309ec944e1bb79380672220f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100387 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-08-19tdf#135412 tdf#135888 sw: fix copying of linked text-boxesMichael Stahl
The resetLink()/restoreLinks() were added in commit 00a007be5ad88bac9905b373bc5e02d02acab11a because testMissingPath missing-path.docx was crashing. But then 0bcc5b3daebeb2a7d2b5ba132af4745cc6c78cd0 refactored how linking works and introduced the isTextBox function, which is called in the middle of DocumentContentOperationsManager::CopyFlyInFlyImpl() after resetLink(), and this now always returns false, the same for another call inside CopyLayoutFormat() (when called from CopyFlyInFlyImpl()), which causes text-boxes to be copied to 2 separate flys (tdf#135888). The problem in tdf#135412 is that somehow when called from SwFEShell::Paste() the content-index from the clipboard document ends up in the SwDrawFrameFormat that is created in the target document, and this causes crash in Undo because the node index is out of bounds. 10 SwUndoInsLayFormat::UndoImpl (this=0x7c2a760, rContext=...) at sw/source/core/undo/undobj1.cxx:310 (rr) p rContent.GetContentIdx()->GetNode().GetDoc()->IsClipBoard() (rr) $29 = true It turns out that missing-path.docx doesn't crash any more without resetLink(), and removing it fixes the 2 bugs. Change-Id: I0c6c91a42e00b9f3b79b774c814e7323f2bb3e05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101004 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-19update pchesCaolán McNamara
Change-Id: I6a300169d33bdc36e4c7e720a7afc336a86eea68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100962 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-19tdf#112290 sw: fix missing line break in small capitalAttila Bakos
Calculated hyphenation positions are skipped in the case small capital text, resulting long lines exceeding paragraph width, for example after wide images. Likely the reason of the problem is tdf#78527 "FORMATTING: automatic hyphenation doesn't work on text in small caps or all caps". Change-Id: Ia0121728bcc099f3ec19e01afd64e1594d6274be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99992 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-18Improve location of unfold fold code use in outline moveJim Raykowski
Change-Id: I299f871c4d6e06f63efaf80e04cb668c52ae8543 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100829 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-08-18remove dead code in SwDBManager::ImportDBEntryNoel Grandin
Found by loplugin:unusedvarsglobal I traced this back to commit 751a98ff97ba8e61d31e8d109c64f2172a820229 Date: Thu Sep 27 10:31:02 2007 +0000 INTEGRATION: CWS swwarnings (1.114.42); FILE MERGED where the code looked like uno::Reference<XNameAccess> xCols = xColsSupp->getColumns(); String sFormatStr( lcl_GetDBInsertMode( *pImpl->pMergeData )); but lcl_GetDBInsertMode looked like inline String lcl_GetDBInsertMode( const SwDBData& rData ) { return aEmptyStr; } So I guess this is a remnant of some unimplemented feature Change-Id: Ic058d8703d60c9829099daba4fed32c16a6e1589 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100894 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-18loplugin:unusedvarsglobalNoel Grandin
tackle some read-only vars. Mark some of them const to make it obvious they are not really used, and to make the constantparam plugin see more data. Change-Id: Ia25927745866746aa1aa9d5affd5857ad9f9ee24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100895 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-18new loplugin:unusedvarsglobalNoel Grandin
I copied and modified the unusedfields plugin to find unused variables. Change-Id: I18ed6daa202da70a2e564e4fe4760aed7ce070ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100891 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-18tdf#123354 DOCX import: fix ABS formulaLászló Németh
Convert ABS(x) to the equivalent, but working Writer formula SQRT(x POW 2). Note: this is a temporary conversion, which supports only 1-level nesting of function calls. Change-Id: I96ad01dc5ac26160792e6a4cb050e103c2ad7bca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100898 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-18tdf#135016 DOCX export: fix unexpected error on save with undo/redoMiklos Vajna
Regression from commit d379d18666aa42031359ca8eb34b0021960347ae (oox: import WPS shape with text as shape with textbox, 2014-06-18), then problem was that when undo restored text deleted by cut, we ended up with an SwXShape that had no frame format. Fix the problem by deleting the cached old UNO wrapper after changing the association between a textbox's shape and text frame. An alternative would be to handle errors better when the TextBox UNO property is not of type bool, but that would still lead to silent data loss, so don't fix the problem that way. Change-Id: Id45ad292befc746e7c49a3b827c91efd069d29df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100876 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-08-17tdf133647 tdf123386 tdf123389 fix DOCX table formula exportLászló Németh
Keep original DOCX table formula during round-trip using grab-bagging. This is a temporary solution until fixing formula export and a proposed solution for formula cannot be converted. Follow-up of commit 68e74bdf63e992666016c790e8e4cfd5b28d6abe (tdf133647 tdf123386 tdf123389 Improved .docx table formula import). Change-Id: Ia4759e250c06e9cc0495fb0b57fccd1ee1f50da9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100872 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-17tdf#135338 sw layout: show FirstLeft on very first left page style.Justin Luth
Although extremely unlikely, the Left Page style can have a different Left and FirstLeft. In the even more unlikely case that the document starts off using a left-page-only style, then the first header would not show on the first page, but only on all of the following left-only pages. So, of course, we want the very first visible page in the document to show the defined First header/footer. Change-Id: I7e74fdc085509fb8d6b80f36d1402309b9db9404 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99862 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-08-17tdf133647 tdf123386 tdf123389 Improved .docx table formula importMichael Warner
Converts table formula syntax from MS Word to LibreOffice. This version uses the list separator of the document for the formula regexen; however, it does not convert the decimal or list separators in the case where the person opening the document is using a different locale from the author. Change-Id: I9600a0bea060a76705a7ad6b051ed4fdd50b9d40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98614 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-17sw: prefix members of SwNode2LayImpl, SwRetrievedInputStreamDataManager, ...Miklos Vajna
... SwXDrawPage and SwXShape See tdf#94879 for motivation. Change-Id: I0cfdc1a1b7e1667dccf8db29616b895a76b8fea5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100843 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-08-17tdf#132892 Revert "sw: paragraph-sign: erase metafields ... correctly"Caolán McNamara
This reverts commit b402d0112a0bb53221b847fa372bfa3f6390a0e2. Change-Id: I210d2fded01fb952d7384b78240e32d868b08575 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100753 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-16tdf#134439 honor FN_PARAM_PAM argumentsCaolán McNamara
which was dropped by commit bba8e5aa6d1968e5279b3fe368c0f81145513d04 Date: Thu Mar 1 21:00:24 2018 +0100 tdf#116070: Use a valid PaM when confirming the dialog. when fixing commit 34527cec54ca634b831cfa5ac1098c4046818ac3 Date: Tue Jan 16 18:54:19 2018 +0100 lokdialog: Convert the Format -> Paragraph... dialog to async exec. so, go back to using pPaM instead of rWrtSh.GetCursor but make a copy of pPaM to avoid the crash of tdf#116070 Change-Id: I0aaaf5173c6be47dd306b77eacbb07d0e1c4eaf1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100670 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-16tdf#131456 fix typoRizal Muttaqin
Change-Id: I74eef4549c4b809778c2bd9d5522759f9c1d38f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100815 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-08-16assure pointer and position in OutlineContentVisibilityWin SetJim Raykowski
won't cause crash. Change-Id: Ic1bb2a1754c1a5a837370c7bb91bf7356e14b6bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100716 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-08-15Fix typo in codeAndrea Gelmini
Change-Id: If2a5e5533a8587c83279d61d764c201e8572f075 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100730 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-15UBSan builds now need SwTableFormula etc. RTTI in Library_mswordStephan Bergmann
..presumably since cf596c43315bb96b5e7256a82256f1ccb8c9c4d0 "tdf#133163 DOCX: export formula cells", see e.g. CppunitTest_sw_rtfexport3 failing at <https://ci.libreoffice.org/job/lo_ubsan/1728/> with > warn:sal.osl:27291:27291:sal/osl/unx/module.cxx:162: dlopen(/home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libmswordlo.so, 257): /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libmswordlo.so: undefined symbol: _ZTI17SwTableBoxFormula Change-Id: I01f8753ff82e41e84ad5d9806e3582ccd671065e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100762 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-15tdf#77794 writerfilter: compat15 - always bLayoutInCellJustin Luth
Based on observation (no documentation found), MS Word 2013 ignores the actual value of LayoutInCell and always considers it to be true. The UI shows it, but it is grayed out when CompatibilityMode == 15. The code's default value of bLayoutInCell is also true, so compatMode only needs to be checked if the property is actually set in the document. I probably could have left off the IsInTable() check, but decided to just be as safe as possible. I assume it doesn't apply, but LayoutInCell sets a IsFollowingTextFlow property - which might have meaning outside of a table in SW - I don't know. Change-Id: Ief073ea96c6c61efb3bcbbc11d114d739b04c3af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100651 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-08-14tdf#135755: Crash:right click to Manage Changes List on side barJulien Nabet
bt here: https://bugs.documentfoundation.org/attachment.cgi?id=164318&action=edit Change-Id: I0874cf9bea1e28192e94ea6125ca6ac8f5736c30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100759 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-14tdf#135457 sw: fix invalidation of SwXTextFieldMichael Stahl
This was supposed to happen from SwNodes::ChgNode() when moving to the undo nodes array. There are fields with a range that contains other fields, when the outer field's range is deleted, the contained field moves to the undo array and its position is no longer valid to be given out by SwXTextField::getAnchor(). (regression from c73b5e969b2f9abdb2b9191938ca30bec5af725d) Change-Id: I38c8b3393a777ca8dc8739b5ca4233a7f124961e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100749 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-14loplugin:simplifybool moreNoel Grandin
look for expressions like !(a && !b) which can be expanded out Change-Id: I72515a9638762b050f9a258c08da39ebfa2ef8e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-14tdf#134746 sw: fix redline hiding of at-char fly on empty paragraphsMichael Stahl
If a merged paragraph has no extents, a fly anchored at the start or at the end should be shown. (regression from 28b77c89dfcafae82cf2a6d85731b643ff9290e5) Change-Id: I78135f3c033cf08aad81c86b0ac693528e3f3f8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100543 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-14tdf#135693 rerun the callbacks on inconsistency just onceCaolán McNamara
Change-Id: I250cf11b816e91b521378c132e4ee8065956bb73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100679 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-14can use sorted_vector hereNoel Grandin
Change-Id: I5f6c1fe7de1dcd409f484a755b8e1313acc8f0c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100741 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-14inline some use-once typedefsNoel Grandin
Change-Id: Ifefdb1ad20d09e257064171e458b2eb33065f5de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100733 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-14rename xmlnmspe -> xmlnamespaceNoel Grandin
Change-Id: I8fdf9833dede6f4c9ba4bbb76b9ab9b6b419f155 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100722 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-14improve dodgy codeNoel Grandin
adding together constants like this is not safe Change-Id: I6c92b591e623fed9adcf76c08fcd1fb136f8d423 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100724 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-14rework this to make it more readableCaolán McNamara
no logic change intended Change-Id: I755de2e37bec3843500920476fc23f013103f976 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100685 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-14rename nmspmap.hxx -> namespacemap.hxxNoel Grandin
we're not in DOS anymore, Dorothy Change-Id: I79926e0d694163940ba7ebf20419724dd0a486f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100721 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-14tdf#135742 icon for More Options in Page ColumnsRizal Muttaqin
Change-Id: I83d78b6a145b68af16375baee688c372700f6b9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100719 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-08-14tdf#133163 DOCX: export formula cellsLászló Németh
as formula fields instead of exporting only cell text content. Only unmodified formula fields were exported from commit d42776e01b87f12fddbcf78101bca1e10a6e4f97 (tdf#118682 DOCX: export formula fields). Now newly added Writer formula cells or modified table formula fields imported from DOCX (which are converted to formula cells after formula editing) are exported. Change-Id: Iecec75b2a36b94c2d3aa998603ac10ea2f2b8d4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100667 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-14tdf#132726 tdf#134948 doc/rtf export: don't PostponeWritingTextJustin Luth
Since .doc and rtf don't postpone flys, they shouldn't also be postponing the text. Partially revert my LO 5.3 commits b39feae4f12b07a0fdb2c8c2a48d5aae613cd7c9/ 3ade281c1da91b7646a56227cffba8eb8818ea30 which only avoided postponing within tables for the .doc format, since this patch eliminates it completely for .doc and .rtf I think the original Synerzip LO 4.4 patch commit 80fd9fb7209cfd5c0622ee99d59e42e6db32f021 was only intended for DOCX formats. I am concerned about doing this since the implications are unclear, but I take comfort in seeing that many synerzip commits just need to be reverted, and that a number of .doc bugs are solved by doing this. The fact that few bug reports have been made since 4.4 also suggests this isn't a hugely active area. No intention to backport, and still lots of testing time available for LO 7.1. Change-Id: I9284d3cc516c480e8bb0848c17797988ffcdcd2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100175 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-08-14tdf#135736 icon for More Options in Page SizeRizal Muttaqin
Change-Id: Ibc2896acc75375d89df02563383dfbec6efff558 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100710 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-08-14tdf#131456 icon for Portrait orientation in Writer Tabbed UIRizal Muttaqin
Change-Id: I346fcf31078cc52b90a9ce39fd93a331e65957cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100689 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
generated by cgit (git 2.34.1) at 2024-08-13 14:31:45 +0000