summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2017-09-25Rename GetSelectEntryCount -> GetSelectedEntryCountSamuel Mehrbrodt
Change-Id: I405b347b404ed0acb3b6a0204e0b914a7698ce25 Reviewed-on: https://gerrit.libreoffice.org/42284 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-24tdf#106762 Base SvxColorToolBoxControl on svt::PopupWindowControllerMaxim Monastirsky
This allows us to support tearoff without breaking gtk3/wayland. SvxColorWindow no longer inherits from FloatingWindow, so several call sites need also to be changed to use DockingManager. Change-Id: I5d0bc611bbd2a8b9bfd4335212d0ae7e8fc10593
2017-09-24Map Windows code page 42 to RTL_TEXTENCODING_SYMBOLStephan Bergmann
<https://msdn.microsoft.com/en-us/library/windows/desktop/ dd374130(v=vs.85).aspx> "WideCharToMultiByte function" suggests that there now is CP_SYMBOL, "Windows 2000: Symbol code page (42)." And a little test program on Windows indicates that our RTL_TEXTENCODING_SYMBOL is working the same way as CP_SYMBOL, where MultiByteToWideChar maps 00..1F to U+0000..1F and 20..FF to U+F020..F0FF. At least CppunitTest_writerfilter_rtftok, when testing writerfilter/qa/cppunittests/rtftok/data/pass/EDB-18940-1.rtf, goes into case RTF_FCHARSET in RTFDocumentImpl::dispatchValue (writerfilter/source/rtftok/rtfdispatchvalue.cxx) with nParam matching aRTFEncodings[2] (i.e., a mapping from charset 2 to codepage 42, see writerfilter/source/rtftok/rtfcharsets.cxx), then passes 42 into rtl_getTextEncodingFromWindowsCodePage and obtains an unhelpful RTL_TEXTENCODING_DONTKNOW. testFdo72031 (sw/qa/extras/rtfexport/rtfexport2.cxx, CppunitTest_sw_rtfexport2) needed to be adapted, as the circled plus from the Symbol font is now internally represented as U+F0C5, not (somewhat bogusly) as U+00C5 (aka LATIN CAPTIAL LETTER A WITH RING ABOVE). But, when displayed with the Symobl font, the glyph that is actually shown remains the circled plus. Turns out changing rtl_getTextEncodingFromWindowsCodePage would start to make CppunitTest_sw_rtfimport fail: Sep 20 15:49:24 <sberg> vmiklos, with <https://gerrit.libreoffice.org/#/c/42477/>, testN823675 (sw/qa/extras/rtfimport/rtfimport.cxx) fails, the aFont.Name is not "Symbol"; sw/qa/extras/rtfimport/data/n823675.rtf contains a \fonttbl that specifies \f3 to have \fcharset2 (i.e., symbol font) and fontname "Symbol". However, RTFDocumentImpl::checkUnicode (writerfilter/source/rtftok/rtfdocumentimpl.cxx) converts m_aHexBuffer (containing "Symbol;") with nCurrentEncoding apparently being the encoding specified by \fcharset2 (i.e., now RTL_TEXTENCODING_SYMBOL instead of old RTL_TEXTENCODING_DONTKNOW), so the resulting OUString is garbage (instead of the byte-for-byte conversion to Unicode "Symbol;" that RTL_TEXTENCODING_DONTKNOW would do there); do you know whether such \fonttbl fontnames should actually be interpreted in the given \fcharset? Sep 20 15:49:24 <IZBot> gerrit: »Map Windows code page 42 to RTL_TEXTENCODING_SYMBOL« by Stephan Bergmann for master [NEW] Sep 20 15:51:15 <vmiklos> sberg: let me check if the spec covers that Sep 20 15:54:29 <mst_> sberg: i think the name is typically encoded in the font's encoding but probably they have to make a (likely undocumented) exception for symbol encoding Sep 20 15:57:46 <vmiklos> sberg: the spec only says that \fcharset is about the encoding of the content using that font, i don't see it described what would be the encoding of the font name itself Sep 20 15:58:51 <vmiklos> sberg: i'm not sure about if that encoding should or should not affect the encoding of the font name in general, but indeed at least for 2 (symbol encoding) you're right, Word doesn't encoding the font name with that encoding, either. Sep 20 15:59:30 <sberg> vmiklos, mst_, at the top of page 14 of Word2007RTFSpec9.docx I see "Note that runs of text marked with a particular font index (see \fN in the Font Table section) use the codepage for that font as given by \cpgN or implied by \fcharsetN, unless they use Unicode RTF described in the following section." Would that match what mst_ says? Sep 20 15:59:33 <vmiklos> so if it helps you case to handle at as e.g. ascii, just for that encoding, i think there would be no problem with that. Sep 20 16:00:07 <vmiklos> sberg: that still talks about the content using the font, not the strings (font names) in the font table itself, i think. Sep 20 16:01:17 <sberg> vmiklos, what's the control word to select such a font, also \fN? I don't see any such in n823675.rtf Sep 20 16:02:16 <mikekaganski> loircbot: e.g. \af3 Sep 20 16:02:31 <mikekaganski> sberg: ^ Sep 20 16:02:47 <mst_> 04d5a280beeeb6e056df68395dc9c3b3a674361b Sep 20 16:02:50 <IZBot> core - related: fdo#77979: writerfilter RTF import: read encoded font name - http://cgit.freedesktop.org/libreoffice/core/commit/?id=04d5a280beeeb6e056df68395dc9c3b3a674361b Sep 20 16:02:52 <mst_> sberg: ^ Sep 20 16:04:05 <sberg> mst_, thanks; so there's likely an (implicit?) exception for \fcharset2, as you say Sep 20 16:04:33 <mst_> that's most plausible, our own font code is full of exceptions for "symbol fonts" too Sep 20 16:05:19 <sberg> mikekaganski, ENOCONTEXT Sep 20 16:05:36 <mikekaganski> sberg: [17:01:16] sberg: vmiklos, what's the control word to select such a font, also \fN? I don't see any such in n823675.rtf Sep 20 16:06:32 <sberg> mikekaganski, so you say selection is done with \af3 instead of \f3? Sep 20 16:06:40 <mikekaganski> sberg: yes, in that case Sep 20 16:07:34 <mst_> i think there are several different keywords that apply fonts, but can't remember the whole list Sep 20 16:08:10 <mst_> \fN shoudl be one of them though Sep 20 16:22:18 <sberg> vmiklos, so who generated that sw/qa/extras/rtfimport/data/n823675.rtf, was it manually created and lacks a \cpgN before "Symbol"? Sep 20 16:29:17 <sberg> vmiklos, (after further reading of the RTF spec): disregard the "and lacks a \cpgN before 'Symbol'" part of my above question Sep 20 16:30:27 <mst_> sberg: i suggest not reading too much about encoding in RTF, it gets pretty lovecraftian pretty fast... Sep 20 16:32:58 <vmiklos> sberg: given how short that bugdoc is, i'm pretty sure i cut it down manually to something readable from a multi-MB real bugdoc Sep 20 16:33:07 <sberg> mst_, do you have a recommendation how I could get that "don't use symbol font encoding to read a symbol font's name" into writerfilter/source/rtftok/rtfdocumentimpl.cxx? RTFDocumentImpl::checkUnicode lacks the context to tell whether it is using m_aStates.top().nCurrentEncoding to convert a fontname, and the caller of checkUnicode (at the end of RTFDocumentImpl::resolveChars in this case) appears to lack the context, too Sep 20 16:33:12 <mst_> various Old Ones from The Time Before Unicode and their Backward Compatibility Tentacles etc. Sep 20 16:34:59 <sberg> vmiklos, anyway, that "so there's likely an (implicit?) exception for \fcharset2" hypothesis sounds sane, so we should probably implement it (if only you or mst_ can give me a good hint how...) Sep 20 16:35:13 <vmiklos> sberg: looking for a code pointer Sep 20 16:36:05 <mst_> sberg: m_aStates.top().eDestination == Destination::FONTENTRY should be the relevant check? Sep 20 16:36:17 <vmiklos> sberg: RTFDocumentImpl::text() is where the text is taken, Destination::FONTENTRY is the state on the parser stack which is a font entry in the font table. so to detect "your case" during decoding a byte array into a string, m_aStates.top().eDestination == Destination::FONTENTRY is what you want Sep 20 16:36:35 <vmiklos> ah good, two independent matching hints are promising ;) Sep 20 16:37:35 <sberg> mst_, vmiklos, ah; but what also looks dodgy is that checkUnicode operates there on "Symbol;" including the closing ";" of the full <fontinfo>, not just the <fontname> part of the <fontinfo> Sep 20 16:39:24 <vmiklos> sberg: i think we already assume that the only "token" in the font entry destination that is not bound to a control world (\foo) is the font name Sep 20 16:40:52 <vmiklos> sberg: writerfilter/source/rtftok/rtfdocumentimpl.cxx:1237 is where we simply strip away the trailing semicolon, there is no further separation between the font name and other character content inside the destination (apart from the control words and their arguments) Sep 20 16:42:18 <sberg> vmiklos, OK, thanks; I'll just pretend I haven't seen those dodgy details :) ...so I'm switching to (somewhat arbitrarily) RTL_TEXTENCODING_MS_1252 there now Change-Id: Iebd1bcecb7fa71c489798154d3356062b052775e Reviewed-on: https://gerrit.libreoffice.org/42477 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-24Improve wording for Writer compatibility optionOlivier Hallot
Change-Id: I852304204c1a95022dbd8305a892812c159a4445 Reviewed-on: https://gerrit.libreoffice.org/41544 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-09-23ofz#3005 avoid timeoutCaolán McNamara
Change-Id: Ie06504957dab6a5035c7fa3c9313f316303c4eb8 Reviewed-on: https://gerrit.libreoffice.org/42700 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23these are cast to sal_Int32 immediatelyCaolán McNamara
Change-Id: I2357ecb5fecd3c232803530fcd131d54e63b85fb Reviewed-on: https://gerrit.libreoffice.org/42695 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23want to add these together before multiply the resultCaolán McNamara
Change-Id: I5f42ed3d5ad5d64faeb06bbfaaa23d84e81963b0 Reviewed-on: https://gerrit.libreoffice.org/42694 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23coverity#1418340 Division or modulo by zeroCaolán McNamara
Change-Id: I0941f8db6b406c8ac316daef46b42e4694053410 Reviewed-on: https://gerrit.libreoffice.org/42696 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23coverity#1418338 Uncaught exceptionCaolán McNamara
Change-Id: I95248e7171910a8acedeedc092754e812103be2e Reviewed-on: https://gerrit.libreoffice.org/42693 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23Watermark: apply when new page style is createdSzymon Kłos
Change-Id: I0d0103f8cc351ec87f7c3bf936ef4725a166d315 Reviewed-on: https://gerrit.libreoffice.org/42581 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-09-23tdf#103733 Unify master doc menu and toolbars with writerYousuf Philips
Change-Id: I1f6ce6c98cd7087ccb874001c29a8532cd7ed360 Reviewed-on: https://gerrit.libreoffice.org/42108 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-09-23tdf#106781 Enable a few hidden items in writer styles toolbarYousuf Philips
Change-Id: I8c2131f31e98e1cf6c790d446ddd84b17507d0ee Reviewed-on: https://gerrit.libreoffice.org/42679 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-09-23sw: actually SetTableNode() ought to always be called before deleteMichael Stahl
Change-Id: I5e830e91ae7c773ad3945550c640a190b6504796
2017-09-23sw: fix crash on loading tdf109006-1.odtMichael Stahl
~SwDDETable() accesses its boxes' start node but that follows the SwTableNode and SwNodes::RemoveNode() counts backwards so the box nodes are all dead. This was always broken but spontaneously started to crash today. Because dtors don't have parameters, resort to a little subterfuge to ensure ~SwDDETable() finds out where it is. Change-Id: Id681005989dd1e9f2611e8c99841927a7c5f6bfa
2017-09-22Fresh run of bin/update_pch.shMike Kaganski
Change-Id: I69d4157aaf6570cecd51ea59df20556914942e06 Reviewed-on: https://gerrit.libreoffice.org/42565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-22Windows: avoid dependence on UNICODE define; prefer W functionsMike Kaganski
Change-Id: I95b90128e93f0d88ed73601bcc5a7ca9279d4cf1 Reviewed-on: https://gerrit.libreoffice.org/42560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-22ofz#3466 avoid oomCaolán McNamara
Change-Id: I79f7390dda9c087ae4bc5af9855b72e888e284a1 Reviewed-on: https://gerrit.libreoffice.org/42641 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-22lok: Don't freeze the LibreOfficeKit via the spell-checking popup menu.Jan Holesovsky
Change-Id: I045ed919daeefca612d7908dd7de50c36536c9a0 Reviewed-on: https://gerrit.libreoffice.org/42608 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/42627 Tested-by: Jenkins <ci@libreoffice.org>
2017-09-22Watermark: apply to existing styles (also not used)Szymon Kłos
Change-Id: Ic57418f3191cc3c30a348db3e784d4cfbeffae79 Reviewed-on: https://gerrit.libreoffice.org/42576 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2017-09-22ofz: don't leak in face of exceptionsCaolán McNamara
Change-Id: Ic15590a13bd3770ee5dd7db76b21c830a4fe73e2 Reviewed-on: https://gerrit.libreoffice.org/42587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-22remove confused error-handlingBjoern Michaelsen
- tracking the error state in a bool - which gets pushed by reference to subfunctions - and signals back error state from a bazzilion different location - in a long operation that is not grouped into one undo - and then haphazardly triggers an indiscriminate Undo - and in addition throws an excpetion More likely than not leaves the client with an undefined half-reverted state, which an impossible situation to properly recover. This either has to be done properly or not at all. Change-Id: I677f87e78c32f4d93c8d21e9df7130a2595da891 Reviewed-on: https://gerrit.libreoffice.org/42510 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2017-09-21EPUB export: add uno command to bypass options dialogMiklos Vajna
Similarly how this is possible with PDF. The toolbar button is hidden by default in Writer, though. Change-Id: Iaf3b61ac2160578f7eaabd194ce8932792575c29 Reviewed-on: https://gerrit.libreoffice.org/42554 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-21Clean up construction of one non-ASCII-literal OUStringStephan Bergmann
...in preparation of a change coming there soon Change-Id: I8861dbd47d0e514cd1c5dc0bb978724ae687f01c
2017-09-21Rename GetSelectEntryPos -> GetSelectedEntryPosSamuel Mehrbrodt
Change-Id: I0bd4cb463575af843c72d9c8aaf91742203532a4 Reviewed-on: https://gerrit.libreoffice.org/42283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-21Rename GetSelectEntry -> GetSelectedEntrySamuel Mehrbrodt
Change-Id: Ibb7d8c59c0e61b0e87455bd78f241d8691dd9dce Reviewed-on: https://gerrit.libreoffice.org/42282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-21attempt to fix android buildNoel Grandin
Change-Id: Ie3eede03b90db272d70e7cb383c7a69d9db0f2ae
2017-09-21TSCP: add advanced classification dialogTomaž Vajngerl
This adds a advanced classification dialog, which enables the user to manually construct a header/footer message from classification properties in cases where the user needs more control. All the text is inserted as fields into the end document and can be changed by changing the document properties. The simple classification still functions as it did before, which is what most users will want to use in this case. The BAF policy has been extended with new xml extension elements: - loext:Marking - loext:IntellectualPropertyPart - loext:IntellectualPropertyPartNumber They are used to fill the values in the advanced classification dialog. Change-Id: Ie2d638d69b8a9b0799cff9c2b785eb789f8af1d5 Reviewed-on: https://gerrit.libreoffice.org/42474 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-09-21inline lcl_ObjConnected and lcl_InHeaderOrFooterBjoern Michaelsen
- lcl_ObjConnected repeatedly fetched an invariant: pRoot - lcl_InHeaderOrFooter just checked for FLY_AT_PAGE, which was never the case in the one client of the function Change-Id: I38aa54d3d51f7dcdee015588a9043824a7703c5c Reviewed-on: https://gerrit.libreoffice.org/42509 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2017-09-20xmloff,sw: some stylistic cleanup to conditional stylesMichael Stahl
Change-Id: I1722a0b3d67a7c8740daa5a131d7800319ee2373
2017-09-20Missing dependencyStephan Bergmann
otherwise CppunitTest_sw_rtfimport failed with > ##Failure Location unknown## : Error > Test name: testFdo52052::Import > An uncaught exception of type com.sun.star.container.NoSuchElementException > - file:///.../instdir/share/config/soffice.cfg/modules/swriter/ui/pagebreakmenu.ui > > ##Failure Location unknown## : Error > Test name: testContSectionPageBreak::Import > An uncaught exception of type com.sun.star.container.NoSuchElementException > - file:///.../instdir/share/config/soffice.cfg/modules/swriter/ui/pagebreakmenu.ui > > ##Failure Location unknown## : Error > Test name: testTdf59454::Import > An uncaught exception of type com.sun.star.container.NoSuchElementException > - file:///.../instdir/share/config/soffice.cfg/modules/swriter/ui/pagebreakmenu.ui > > ##Failure Location unknown## : Error > Test name: testLndscpsxn::Import > An uncaught exception of type com.sun.star.container.NoSuchElementException > - file:///.../instdir/share/config/soffice.cfg/modules/swriter/ui/pagebreakmenu.ui > > ##Failure Location unknown## : Error > Test name: testImportHeaderFooter::Import > An uncaught exception of type com.sun.star.container.NoSuchElementException > - file:///.../instdir/share/config/soffice.cfg/modules/swriter/ui/pagebreakmenu.ui Change-Id: I10c12f4b0ab49ec747fa64cc0b5d4fca252ff590
2017-09-20unused m_sNoSubjectST/m_sDefaultAttachmentST in SwMMResultEmailDialogNoel Grandin
ever since commit ba0796b331247b27886384377c480e413c3ee83d Date: Wed Dec 23 17:43:14 2015 +0100 mailmerge: Killed the 'Save, print or send' page. Change-Id: Id77cd6beb3eaa13ead848495d9f8661c83f60975
2017-09-20no need to queue formats in header and footer ...Bjoern Michaelsen
- we can call MakeFrames on them right away - as there had been performance issues on mail merge here before, this might a bit quicker for suoer large documents. Change-Id: Idd84d7e6a962d00d59e2981f63ed9db60377fa01 Reviewed-on: https://gerrit.libreoffice.org/42442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2017-09-20tdf#112447: connect all objectsBjoern Michaelsen
- fixes regression from 575e222a1742918be052f2b716ddf57ce0008404 Change-Id: I686ce41c87e5b421e0382658404cf7bb153a4812 Reviewed-on: https://gerrit.libreoffice.org/42439 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2017-09-19add signature icon cause the icon is available (in breeez)andreas kainz
Change-Id: If221848b1ef389a1816e5aab71f784ddd932c9bc Reviewed-on: https://gerrit.libreoffice.org/42347 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-09-19Related: tdf#112211 DOCX import: fix handling of missing first ind in <w:lvl>Miklos Vajna
Usually a DOCX numbering definition has multiple levels, each level containing a <w:ind ... w:hanging="..."/> element. When this is missing, we should default to the Word default, not to the Writer one. This makes the DOCX version of tdf#106953 imported correctly, in preparation of dropping the original fix that helped RTF only. [ The DOC version of the bugdoc is still not imported correctly. ] Change-Id: Ib7fc1de55316a73188c023665a585ac7056341f7 Reviewed-on: https://gerrit.libreoffice.org/42447 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-19Word 2013 and 2016 does not honor the <w:view> setting, let's ignore it too.Jan Holesovsky
In other words, let's open documents in the non-web view even when saved with <w:view w:val="web"/>. The behavior I see in Word 2013 (and it's documented that his happens in 2016 too) is that the setting is not a document setting any more, but user's setting. Ie. regardless of what is written in the file, the .docx document opens in the Print Layout if the Word was in the Print Layout until now, and in the Web Layout if it was that mode. We handle the non-web layout much better than the web layout, so let's just default to the normal layout on load. Change-Id: Ieba7ddc280b9b79501a6b89ff21b03a86356583c Reviewed-on: https://gerrit.libreoffice.org/42414 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-09-19tdf#79877 revert to old behavior when clicking on input fields.Bernhard Widl
doubleclick on input field brings up old input fields dialog that dialog now starts at current field and has previous/next navigation Change-Id: Ie3eec38d62cbf8a8248acb4fd84731c078ebadd4 Reviewed-on: https://gerrit.libreoffice.org/42333 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-18remove boilerplate, use C++11 (convertToTable)Bjoern Michaelsen
- extract constants from loop - warn on index mismatch Change-Id: I1e03dd65a82913c8a8de6abba56a82ed0f815db4 Reviewed-on: https://gerrit.libreoffice.org/42402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2017-09-18use some C++11 and check for incomplete merges (lcl_MergeCells)Bjoern Michaelsen
Change-Id: Id58762bb4914cdbb358bfd8afb916647c964d38b Reviewed-on: https://gerrit.libreoffice.org/42399 Tested-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2017-09-18allow events to accumulate past limit if an exception is pendingCaolán McNamara
Change-Id: Ic54c31961b887e06267aba1ceb0378508d24ded0 Reviewed-on: https://gerrit.libreoffice.org/42411 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-18make fuzzer workCaolán McNamara
Change-Id: I798558260f5f975f92b702ecf6f4504738ffbbfb Reviewed-on: https://gerrit.libreoffice.org/42422 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-18through->throwCaolán McNamara
Change-Id: I0bc0fca465c0dd020f50aadfd1f5c3f61b42d7ae Reviewed-on: https://gerrit.libreoffice.org/42429 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-18ofz#3404 avoid oomCaolán McNamara
Change-Id: Ie2594905616a80c0ef9478ae9152e08047d87842 Reviewed-on: https://gerrit.libreoffice.org/42424 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-18borderline: restuctured used classesArmin Le Grand
Restructuring for more efficcient usage of helper values, some obstacles removed with that Change-Id: Ia8c4b2d4c423db9500cda507107d87913b79e23c Reviewed-on: https://gerrit.libreoffice.org/42409 Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Tested-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2017-09-18add fodt fuzzerCaolán McNamara
Change-Id: I3e4de4b9dab96f0e4bc9ca90896c2c54ae66ca20 Reviewed-on: https://gerrit.libreoffice.org/42251 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-18tdf#109118 Added new buttons into Mail Merge toolbarSerge Krot
New buttons are: - uno:ViewDataSourceBrowser - uno:AddressBookSource Change-Id: I03d475edc01885137cb792c0654e68861725e8ee Reviewed-on: https://gerrit.libreoffice.org/42334 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-18tdf#109310 ooxmlexport: write Xnote character styleJustin Luth
LibreOffice will just ignore the defined style on import (since that is statically defined by the footnote code). Microsoft Office, however, requires the character style be provided for the footnote number. It doesn't have any built-in formatting for footnotes. So, this patch is strictly for MSO's benefit. Change-Id: I6631dd0eb697589cfd3c13d7838fe14c31a71bbf Reviewed-on: https://gerrit.libreoffice.org/42035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-18related: tdf#111967 fix assertions about silly column positionsMichael Stahl
ImplLogicToPixel() is called with ~LONG_MIN value, which comes from SwView::StateTabWin() where we have: (rr) p aTabCols $12 = { nLeftMin = 1134, nLeft = 0, nRight = 4618, nRightMax = 9223372036854775807, bLastRowAllowedToChange = true, aData = std::__debug::vector of length 9, capacity 16 = {{ nPos = 387, nMin = 0, nMax = 9223372036854775807, bHidden = false }, { The problem is that the "aTabCols.GetRight() - rEntry.nMax" becomes negative, which is probably wrong, so enforce a minimum of 0. (regression from 4c60f722afdc0be5c129ce5f5ed6786d09d0051e, which removed a cast of the value to sal_uInt16, which also didn't look right to me, but perhaps wouldn't cause this assert?) Change-Id: Ia1aa2cd100ac25a8c34902cc992d54954fead284
2017-09-18sw dbmgr: fix indent of these statementsMiklos Vajna
Change-Id: I4eae19f5a724c44ec382053ace2f3fcd586fd6f3
2017-09-18sw: prefix members of SwFormatFlyCntMiklos Vajna
Change-Id: I41c611d4babe227ce298ed8d6ba3d9e05da5a82b Reviewed-on: https://gerrit.libreoffice.org/42404 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-07-13 04:13:24 +0000