summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2017-12-04Related tdf#113696 Unit test for Writer images fallback graphicSamuel Mehrbrodt
Change-Id: I2f14d6ab9a107f5b50ab0ec83019f86751dd79f6 Reviewed-on: https://gerrit.libreoffice.org/45778 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 282bc5a824d103dcf4b19c9cf83698a2334e2e34) Reviewed-on: https://gerrit.libreoffice.org/45803
2017-12-04Related tdf#72966 Provide replacement graphic also for metafilesSamuel Mehrbrodt
In 6b3cc69fd2b2de5ace68f2739eb383267d66f76f this was done for draw images, this patch also implements this for Writer images. Change-Id: I54f8142c3d22e1a356aedbcf2daf9d7a9b049423 Reviewed-on: https://gerrit.libreoffice.org/45673 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 2d3023c9713c4c7cac732a6831c69dec581a7751) Reviewed-on: https://gerrit.libreoffice.org/45800
2017-12-04Unit test for tdf#113696Samuel Mehrbrodt
Change-Id: I566cd5d38cf86547b664f0ae9a1c2f8c37edc0ca Reviewed-on: https://gerrit.libreoffice.org/45560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-on: https://gerrit.libreoffice.org/45680
2017-12-03Groupedbar full add priority functionallityandreas kainz
Change-Id: Id1bbc7da811c76be5b413b2c66da280f504d97a0 Reviewed-on: https://gerrit.libreoffice.org/45361 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit c056f4ade7efec94d2cdc19c184486d834638df2) Reviewed-on: https://gerrit.libreoffice.org/45584 Tested-by: Jenkins <ci@libreoffice.org>
2017-12-02Resolves: tdf#106322 keep original cell content when assigning number formatEike Rathke
... and content can't be parsed as number. Instead of converting 0. Change-Id: Ief0c0a0284762fc0e801d6cc598720a97d733e31 (cherry picked from commit acf7e4c0a3dc0cca986bf4d4b7a65bafe7e70abc) Reviewed-on: https://gerrit.libreoffice.org/45695 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-12-02Writer page shadow - avoid scaling stored bitmaps at all.Michael Meeks
Follow-on improvement from previous leak fix. Change-Id: Iad18da20c3ee03cbafd191ddd722f58bd45911be Reviewed-on: https://gerrit.libreoffice.org/45538 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 268d019c4b05f37e99e1da85472dc9255f186a27) Reviewed-on: https://gerrit.libreoffice.org/45661
2017-12-01Prepare for translated new AutoFormat Table Styles, tdf#101349Eike Rathke
Stored in file are resource IDs for predefined style names, user defined styles are stored with ID 0xffff and display the given name. The 16 old styles have IDs 0..15, so add strings for the 10 new styles and append those to the already existing IDs assigning them the range 16..25 Once the final autotbl.fmt file with only new styles will be available, patch that to change the 0xffff user defined to those 16..25 (0x10 to 0x19) IDs, it is the uint16 immediately following the style name (Little Endian). Order of styles should match the one in this change, if not, change the change.. Also, this eliminates the duplicated translation entries in sw/inc/strings.hrc and instead in sw/source/core/doc/DocumentStylePoolManager.cxx pulls the translations from include/svx/strings.hrc Change-Id: I7827ae22ab05901e6580ff1b9cd812db55f94f7f Reviewed-on: https://gerrit.libreoffice.org/45544 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit b56cd8050137ed4555a5aca50d4949d941e1f132) Reviewed-on: https://gerrit.libreoffice.org/45651
2017-12-01Resolves: tdf#114112 sort 'select' listCaolán McNamara
Change-Id: I0b80b2f7e8377f92a397b6557d2c3fad3e63f16a Reviewed-on: https://gerrit.libreoffice.org/45607 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-11-30ofz: fix mem leakCaolán McNamara
Change-Id: I97b6ad9b0e873ac75a8791c731a1a8a862ef01af Reviewed-on: https://gerrit.libreoffice.org/45365 Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30tdf#113880 Fix a11y issues in tabs of the image properties dialogYousuf Philips
Change-Id: Ief5b95307cefe1091854ba872c37a702fe432b20 Reviewed-on: https://gerrit.libreoffice.org/45576 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30Tile the writer surround rendering to avoid large image scaling.Michael Meeks
This also fixes a potentially large memory leak depending on zoom, and particularly with non-paginated rendering. Change-Id: Ia24e0b7baea725020f000a369708b0be3fc20c95 Reviewed-on: https://gerrit.libreoffice.org/45414 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/45466 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30tdf#65955 Bookmarks on two paragraphsSzymon Kłos
Change-Id: I61fe660ee4fc5d3f6fc86c29e07369811eb38935 Reviewed-on: https://gerrit.libreoffice.org/45434 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 76f28863e7974da5a7280b3efa8a157c114ca03c) Reviewed-on: https://gerrit.libreoffice.org/45522
2017-11-29tdf#109202: Convert images to desired format in (f)odt filterKatarina Behrens
Pass down mimetype to SvXMLGraphicHelper Change-Id: I9c81c06d2a1d6168704440094081e99d0bcbbff9 Reviewed-on: https://gerrit.libreoffice.org/41893 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 082cdbc991a2e31556bab53a5b8214cb89138354) Reviewed-on: https://gerrit.libreoffice.org/45401 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-28tdf#104035 RTF export: fix handling of absolute tab positionsMiklos Vajna
RtfAttributeOutput::ParaTabStop() assumed that they are always absolute, but WW8AttributeOutput::ParaTabStop() points out what compat setting decides if they are absolute or relative. (cherry picked from commit b5e871deb8ce390b9fa694e21b0272c7462da703) Change-Id: Iafe8f6bb8733cae38a89f6c407763b0327e894e8 Reviewed-on: https://gerrit.libreoffice.org/45412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-28ofz: check sprm boundsCaolán McNamara
and don't reuse results of previous search Change-Id: I15d55aba260377f2f43627d775adf1a01370ae3e Reviewed-on: https://gerrit.libreoffice.org/45407 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-27tdf#114023 typo of FMT_REF_ARY instead of FMT_REG_ARYCaolán McNamara
Change-Id: Id3e0588ee0f5dc0aa93270f58de1d1fd4bc9c912 Reviewed-on: https://gerrit.libreoffice.org/45327 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-25Fix a likely copypastaMatteo Casalin
All dimensions set to 0 seems to be a correct setting for an empty page. Change-Id: Idf8a587ab405ecd07b44a7c80d5d2eaf98e1c146
2017-11-24ofz#4414 set new nWwCols after verifying legal sizeCaolán McNamara
otherwise we're returning early with the now wrong nWwCols Change-Id: I2031c23ca24241fb4946b5a5a62eabc27c2bdcc2 Reviewed-on: https://gerrit.libreoffice.org/45240 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-24tdf#113938 sw: apply new default vertical orientation only during importMichael Stahl
Commit c79467ba954987f1d239c594c1e1b3af3f5515f6 changed the default vertical orientation for shapes in Writer; it turns out that at least one extension assumes the previous default. Tweak SwXShape so that the new default is used for shapes that are created during file import, otherwise the old default. Change-Id: I1dc4d3342dd53ce8e0857984456717b8ffcc97c7
2017-11-24tdf#67207: export MERGEDIELD to DOCX and DOCMike Kaganski
Also removed a hack for i119803, because proper solution is implemented. This does not export data source information yet. Unit tests for DOC and DOCX are included. RTF export is already covered in testFdo80905. Change-Id: Id4f6d53344edf474add7e885e8ae6f36618e569f Reviewed-on: https://gerrit.libreoffice.org/45193 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-24improve scoping and use a ref instead of a pointerCaolán McNamara
Change-Id: I9b2d7e57495b26c748edfe6bf5d9d04e0c8a388f Reviewed-on: https://gerrit.libreoffice.org/45239 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-24Clean up loplugin:unnecessaryparen blacklistStephan Bergmann
* rsc/source/parser/rscyacc.cxx no longer exists * writerfilter/source/rtftok/rtftokenizer.cxx appears to be just fine nowadays? * sw/source/filter/html/htmltab.cxx used redundant parentheses around a comma operator in a while condition, and I see no reason not to remove them (the result requires a---reasonable---tweak to loplugin:commaoperator, though) Change-Id: I451132c700b0ae5a43b03d704156484df897ad5c Reviewed-on: https://gerrit.libreoffice.org/45213 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-24loplugin:countusersofdefaultparams in sw (1)Noel Grandin
Change-Id: I0d14f9c375f93079aef21ca4f1132adc4e1fe06c Reviewed-on: https://gerrit.libreoffice.org/45207 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-24Fix typosAndrea Gelmini
Change-Id: If511cbcc290488cf05cc078e6674deae2c454315 Reviewed-on: https://gerrit.libreoffice.org/45209 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-24sw: remove temporary debug code in txtfrmMiklos Vajna
Change-Id: Ia1183da8c3382c8b81a2d2154215d45e4847f460 Reviewed-on: https://gerrit.libreoffice.org/45194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-24TypedWhichId for RES_CHRATR constantsNoel Grandin
Change-Id: Id6c45c237e9c8c55597d97b647b443eab9d1880a Reviewed-on: https://gerrit.libreoffice.org/45147 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-24tdf#65955 DOCX: bookmarks at the end of paragraphSzymon Kłos
End of line handling was incorrect and all bookmark tags placed at the end were exported before last text. I added additional collection to separate final marks and export them after last piece of text. Change-Id: Icc8f89164619c85405a846fda9871430c91dcbe1 Reviewed-on: https://gerrit.libreoffice.org/45168 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-23ofz#4335 verify sprmTDefTable lengthCaolán McNamara
Change-Id: I846099f98c24ef1b53f070962c7a218e3a7e35b9 Reviewed-on: https://gerrit.libreoffice.org/44959 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-23Resolves: tdf#113962 save detected filter outside file dialogCaolán McNamara
different file dialog impls work differently so store the detected filter outside the file dialog Change-Id: I144d8df06e5265fed8f11b284a2f40c17c3e09ef Reviewed-on: https://gerrit.libreoffice.org/45166 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-23ofz#3301 add bugdocMichael Stahl
Change-Id: I9a6425f5c0ed519ef7cb90e66b0d4c8e0fe700d4
2017-11-23tdf#50746 add paste unformatted to menu and context menuYousuf Philips
also unified menus and context menus in writer and calc Change-Id: I929df7a0fe2be7b8bf58cf048e53536ea89d5c9c Reviewed-on: https://gerrit.libreoffice.org/45095 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-23Make loplugin:unnecessaryparen look through implicitStephan Bergmann
...similar to how <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent" does for loplugin:simplifybool Change-Id: I23eef400af71c582d380c9bae6546ce06e8a1e18 Reviewed-on: https://gerrit.libreoffice.org/45122 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-23An anonymous GraphicObject instance suffices hereStephan Bergmann
Change-Id: I13156c3194497a2e554cdfe3a92a4ff83e0ea2f1 Reviewed-on: https://gerrit.libreoffice.org/45073 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-23put GraphicObject on stack instead of heapStephan Bergmann
Change-Id: Ia673a88a397d3a4e5c3b2ff31a60d04ea9e70d1f Reviewed-on: https://gerrit.libreoffice.org/45062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-23reduce scope of varStephan Bergmann
Change-Id: If9f4974fa1bf664b14c81e243f7dcd36abd3a1ce Reviewed-on: https://gerrit.libreoffice.org/45061 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-23use std::unique_ptrStephan Bergmann
Change-Id: I28e3f253cc8d0d35275c6aa3bcf17a93e2f0c631 Reviewed-on: https://gerrit.libreoffice.org/45060 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-23loplugin:simplifybool for negation of comparison operatorNoel Grandin
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791 Reviewed-on: https://gerrit.libreoffice.org/45068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22Make loplugin:unnecessaryparen warn about (x) ? ... : ... after allStephan Bergmann
...which had been left out because "lots of our code uses this style, which I'm loathe to bulk-fix as yet", but now in <https://gerrit.libreoffice.org/#/c/45060/1/> "use std::unique_ptr" would have caused an otherwise innocent-looking code change to trigger a loplugin:unnecessaryparen warning for pFormat = (pGrfObj) ? ... (barring a change to ignoreAllImplicit in compilerplugins/clang/unnecessaryparen.cxx similar to that in <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent", which should also have caused the warning to disappear for the modified code, IIUC). Change-Id: I8bff0cc11bbb839ef06d07b8d9237f150804fec2 Reviewed-on: https://gerrit.libreoffice.org/45088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-22replace check of eof and GetError with goodCaolán McNamara
Change-Id: I7d9f04262ab5420e9a14813fa1274bb9d01e3291 Reviewed-on: https://gerrit.libreoffice.org/45076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22drop duplicate methodCaolán McNamara
Change-Id: Idadd0a64e41cd02f5167b275081c3576a6224b12 Reviewed-on: https://gerrit.libreoffice.org/45075 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22Missing GraphicObject destruction, memory leakStephan Bergmann
...causes e.g. a leftover temp file like _anonymous_namespace___WpftWriterFilterTest__test_9m9gdo.tmp in $TMPDIR during CppunitTest_writerperfect_writer's processing of writerperfect/qa/unit/data/writer/libwps/Write_3.1.wri. The code lacking the delete was originally introduced with e3911a61e60610d32d4f41ab0361ff495bbf3f95 "INTEGRATION: CWS fwk59: #i63867# let the replacement image be imported", then heavily modified with ec8258f3b78f6bc00a108fe0bef7656b86812b7d "INTEGRATION: CWS xmlfilter06". Change-Id: Ie0830d5f358e6d81efe0bb9ef04d6a206bd27201 Reviewed-on: https://gerrit.libreoffice.org/45059 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-22RTF filter: drop now redundant astyle.optionsMiklos Vajna
I (tried to) keep the RTF filter style consistent locally with astyle in the past, but now that's redundant when we have an enforcing clang-format mechanism in place. So drop the astyle config and switch to clang-format in the RTF filter case. To minimize backport pain, do this shortly before the libreoffice-6-0 branch-off. Change-Id: I708dbeb0b5ad2afacc90029ee5abba9495f4601f
2017-11-22tdf#86087 fix relative link open on linuxSzymon Kłos
Change-Id: I6bf2d6bd50b9f1ed7a2c3f66fc18598aa7ffe3d6 Reviewed-on: https://gerrit.libreoffice.org/45053 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-22Fix typoAndrea Gelmini
Change-Id: I591214b246f7702e52f71b95cdc2255bc296224b Reviewed-on: https://gerrit.libreoffice.org/45063 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-22TypedWhichId for SDRATTR* constants (3)Noel Grandin
Change-Id: Iea72cb3a4bbf693096de46269f58259b5952eedb Reviewed-on: https://gerrit.libreoffice.org/45024 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22loplugin:simplifybool re-activate the !! warningNoel Grandin
Change-Id: Iac7d82a1c228734177be536e9a6c41803c03637b Reviewed-on: https://gerrit.libreoffice.org/45035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-21coverity warningsCaolán McNamara
Change-Id: I456210188ab96e6be03e65c94eedb348cc93a8e1 Reviewed-on: https://gerrit.libreoffice.org/45023 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-21another expected exception in initial corpusCaolán McNamara
Change-Id: I5f804cd6dd844bc82d4afadc4bb835ca0d77a53e
2017-11-21don't abort on expected exceptionCaolán McNamara
oxymoronic I know Change-Id: Ie51c3e8995c53eaaac0a3a4f6e3582c7b38da823 Reviewed-on: https://gerrit.libreoffice.org/45041 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-21add docx support to fftesterCaolán McNamara
Change-Id: Ia761e23c011c53f8f786ac336efd4b9e94fc6e35 Reviewed-on: https://gerrit.libreoffice.org/45033 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>