summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2018-02-10SwContentNode: kill SwDependprivate/Sweetshark/lessdependBjoern Michaelsen
Change-Id: I6365d42e605c27846aa688dfcc2b9d2e7e63b1e4
2018-02-10IsFormatInDTOR checkBjoern Michaelsen
Change-Id: I043e998687d22e0d443d7ffe465413f4361bd7dd
2018-02-09kill SwDepend in SwPageDescBjoern Michaelsen
Change-Id: I8c0eb038aa334d8f32c12ef0ca1af425f6c71292
2018-02-08swddetbl: kill SwDependBjoern Michaelsen
Change-Id: Ia675e57754052d219101190498d78282632f3668
2018-02-08ddefld: proper message passingBjoern Michaelsen
Change-Id: Ied02a75c3928f8c9f30dde03d0e749c228e1c5b2
2018-02-08ddefld: proper message passingBjoern Michaelsen
Change-Id: I08c35d6743a3f0786ad7cf7f506876f437f60541
2018-02-08ddefld: proper message passingBjoern Michaelsen
Change-Id: Ic6f62879339bd6373c16b57847f57445fd40f493
2018-02-08LinkAnchorSearch: use proper message passingBjoern Michaelsen
Change-Id: I33a2c2bff684b681758b1cabca5df9c600419f21
2018-02-07a11y SwDependsBjoern Michaelsen
Change-Id: Ibe53fcba2c7b3e52b68a50e66c26c559836948d2
2018-02-07SwEndNoteBjoern Michaelsen
Change-Id: Id9137ef44a0f24e4614267a5b811b8b25192ff8a
2018-02-05PageDescsBjoern Michaelsen
Change-Id: I5e36d4a8e9f9dbf19541bad495704515623d8ff5
2018-02-05worksBjoern Michaelsen
Change-Id: Iad5be71aaf348f977d90a4802ba7f017bf030c3d
2018-02-05notice modify changesBjoern Michaelsen
Change-Id: I65b704e6d4d6f6949d92891f7dfc6807208c53d3
2018-02-05remocve aAnchorCharFormatDepBjoern Michaelsen
Change-Id: Ic6a4ebacd14cec920affb922cc5b2853583e5328
2018-02-04ChangeNotifyBjoern Michaelsen
2018-02-02intermediate: Modify->SwClientNotifyBjoern Michaelsen
Change-Id: I7198ad8fc638cd138bb3687d7d5760dcff27c743
2018-02-01intermediate: unoidxBjoern Michaelsen
Change-Id: Ie159108c8cc3481c62b7938a1839eea27c238bd9
2018-02-01intermediate: unoidxBjoern Michaelsen
Change-Id: Ie09a8accfef4a7dcd3f556f2f8d053c2c02d0aae
2018-01-31intermediate: SwXTextPortionBjoern Michaelsen
Change-Id: I219f626ce51e07c581ddf49d0cf5dc66e2d6a997
2018-01-31intermediate: unoob2.cxxBjoern Michaelsen
2018-01-29intermediate: docufldBjoern Michaelsen
Change-Id: I93f6dbf4eda561d68146be714e633576394d5a75
2018-01-29intermediate: compilesBjoern Michaelsen
Change-Id: I9b6cacfcdcf82b678ff67f818cf692f9a85cc543
2018-01-26introduce SwClient::StartListeningToSameModifyAsBjoern Michaelsen
- ... as it is a common pattern Change-Id: Ie6a9b803e1e763fb0c01d808fac107df88f79460
2018-01-25more GetRegisteredIn obsoleted by StopListeningAll()Bjoern Michaelsen
Change-Id: I7d69a5112e03cec1b8ebdc389940557b4dbd1117
2018-01-25Remove SwEndNoteInfo::ReleaseCollectionBjoern Michaelsen
- obsoleted by SwClient::EndListeningAll() Change-Id: Id086a42e778b7630c44af4a6ddf2a23d77538c2b
2018-01-25introduce SwClient::EndListeningAll()Bjoern Michaelsen
- this is to reduce the use of GetRegisterdIn(), which should be an implementation detail - remove SwTOXMark::DeRegister() which did the same for a part of the class tree - remove SwUndoSetFlyFormat::DeRegisterFromFormat(), same - remove doubletracking FrameDeleteWatch::m_bDeleted, just check GetRegisteredIn() Change-Id: Id9364076759446ee5ff1898683c3ca700c1014c9
2018-01-22limit the rest of CSS1_PIXLENGTH usersCaolán McNamara
Change-Id: I59487bb337bc8821cb995fd258602ff7fb580d54 Reviewed-on: https://gerrit.libreoffice.org/48311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-22ofz#5561 Integer-overflowCaolán McNamara
Change-Id: I57660848190efff8e6354670eb68b60ed57f0094 Reviewed-on: https://gerrit.libreoffice.org/48308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-22uitest for tdf#108124Zdeněk Crhonek
Change-Id: If500712e1fddc2a65b5c2df1649231ff3b46a45b Reviewed-on: https://gerrit.libreoffice.org/47019 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-22sw: add an assert wrt. recent bug in SwHTMLParser::SplitAttrTab()Michael Stahl
Change-Id: I1fa64beb4724675c2e23bd5d4f0766f6d4cf7873
2018-01-22sw: prefix members of SwDocInfoField, SwDocStatField and SwDocStatFieldTypeMiklos Vajna
Change-Id: I8c6e618266f56148df385eb140668730d9b06ed3 Reviewed-on: https://gerrit.libreoffice.org/48293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-22crashtesting: dodgy aRect is unused anywayCaolán McNamara
assert on conversion fdo66047-1.odt to doc of too large long from Fraction Change-Id: I057eb41791eb3b454192540da5e1f1d099487839 Reviewed-on: https://gerrit.libreoffice.org/48324 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-22StartExecuteAsync doesn't need a second paramNoel Grandin
we can just use this to store a keep-alive reference in AsyncContext Change-Id: I0152aef5386aa9753b48afdfc958790f10d13560 Reviewed-on: https://gerrit.libreoffice.org/48294 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-22tdf#114523 Make inline tooltips for changes optionalheiko tietze
Tooltips on tracked changes are not shown when Show track changes is switched off; additional property introduced at Tools > Option > Writer > Changes to disable the inline tooltip completely Change-Id: I5b54895bb22d167a383b06627c69326c3c2f5b02 Reviewed-on: https://gerrit.libreoffice.org/46971 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-01-22tdf#35301 Modify Asian phonetic guide dialog.Mark Hung
* Add a new ruby position option "Right" in the Asian phonetic guide dialog. * Allow set/get RubyPosition property via XRubySelection interface. Change-Id: I306450ad32f0eff71f284c85e78497a341bc7971 Reviewed-on: https://gerrit.libreoffice.org/48209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-01-22Actually remove the now-unnecessary, bad downcastStephan Bergmann
...after 8aa37ca1b94a340c0ca3dc4edebdc501edc25cf5 "ubsan SwTableBoxFormat is really SwTableLineFormat" Change-Id: I24d092a6cb4d3642e22045acde7eeffaf908075e
2018-01-22C++17 deprecated std::shared_ptr::unique()Michael Stahl
Most of these calls are in assertions, and the ones that aren't should be guarded by SolarMutex, so the thread safety concerns that caused unique() to be deprecated don't look relevant, so use use_count(), which oddly enough isn't deprecated. Change-Id: Ia166615af6c3ce85145c391752669c7461bd35fb Reviewed-on: https://gerrit.libreoffice.org/48222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-22ofz#5535 max decimal places for rtl_math_round is 20Caolán McNamara
Change-Id: I636e086c51ceb70bdac72acfbabe99ad29003cdb Reviewed-on: https://gerrit.libreoffice.org/48268 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-22ubsan SwTableBoxFormat is really SwTableLineFormatCaolán McNamara
/sw/source/core/doc/tblrwcl.cxx:1937:29: runtime error: downcast of address 0x2b328cff7da8 which does not point to an object of type ´SwTableBoxFormat´ 0x2b328cff7da8: note: object is of type ´SwTableLineFormat´ 00 00 00 00 f0 ea dd 46 32 2b 00 00 b8 80 ff 8c 32 2b 00 00 e8 43 f5 00 90 61 00 00 58 79 65 80 ^~~~~~~~~~~~~~~~~~~~~~~ vptr for ´SwTableLineFormat´ #0 0x2b323c386daf in lcl_CopyLineToDoc(FndLine_ const&, CpyPara*) /sw/source/core/doc/tblrwcl.cxx:1937:29 Change-Id: I16f7b61a3561de3e599818aba538c72c631511ca Reviewed-on: https://gerrit.libreoffice.org/48282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-21tdf#113946 add 'topMargin' to GraphicHelpers importPatrick Jaap
The case '...topMargin' was not caught for setting a relative vertical position in GraphicHelpers. The test file demands a '7' here, which stands for 'PAGE_FRAME'. The '7' was overwritten in GraphicImport in case 'LN_CT_Anchor_positionV' by a call of 'resolve'. For a better overview a switch is inserted here. Change-Id: Ie98209fe445ecbba15c3dafe5980ca52421126f8 Reviewed-on: https://gerrit.libreoffice.org/47905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-21Fix typosAndrea Gelmini
Change-Id: Id3e707e89bd0fda4d86e02a185a16336c89e7c82 Reviewed-on: https://gerrit.libreoffice.org/48281 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-21more ScopedVclPtr for dialogsNoel Grandin
Change-Id: I0f19a0c1e312843bee0ee5c9939831918ddc2da7 Reviewed-on: https://gerrit.libreoffice.org/48198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-21tdf#35301 Formatting ruby text on right side.Mark Hung
* BuildMultiPortion(): preserve room for the ruby text by increasing the width of the last portion of the base text. This allows the ruby portion to be selected with the base text so that they seemd like attached to each other. * CalcSize(): we need to be careful because the width and height of the base text line is swapped. * PaintMultiPortion(): render the base text on top of the preserved room mentioned above, by shifting the position back. * SwRubyPortion(): RubyPortion::RIGHT is designed for horizontal writing mode only. In vertical writing mode it fallback to RubyPortion::ABOVE. Change-Id: I5291e32221b6b2fc1c3e152b3a5defe857428163 Reviewed-on: https://gerrit.libreoffice.org/48244 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-01-20Addition of focus_on_click to notebookbar ui filesMaxim Monastirsky
(automatic rewrite) Change-Id: I959b58b3b0b69de9344b0f7188594a19e8b9d4ea Reviewed-on: https://gerrit.libreoffice.org/48176 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-01-20ofz#5253 restore some sort of valid state on missing RestoreCaolán McNamara
Change-Id: Ic12e1567f5a3370d1580d8c471ee38d3069568ce Reviewed-on: https://gerrit.libreoffice.org/48217 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-20loplugin:unusedmethodsNoel Grandin
Change-Id: If00b0e659e1818c29ae39b89f8b4f7ea29d14986 Reviewed-on: https://gerrit.libreoffice.org/48185 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-20tdf#115079: check that row frame belongs to table frame to avoid segfaultJulien Nabet
A row frame may not belong to a table frame, when it is being cut, e.g., in lcl_PostprocessRowsInCells(). Its SwRowFrame::Cut() has been called; it in turn called SwLayoutFrame::Cut(), which nullified row's upper in RemoveFromLayout(), and then called Shrink() for its former upper. Regardless of whether it will be pasted back, or destroyed, currently it's not part of layout, and its height does not count. See bt https://bugs.documentfoundation.org/attachment.cgi?id=139171 Change-Id: I4010e1f246a3ebb89b3f972a03619a2775146da4 Reviewed-on: https://gerrit.libreoffice.org/48089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-19Don't create database files in $HOMEMike Kaganski
Regression from commit 46b3202bf883618f1585850191c19776861013ed Change-Id: If8e0b309274ea14e996e0dde2d1ee9b49ff0f737 Reviewed-on: https://gerrit.libreoffice.org/48173 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-19coverity#1427648 Dereference after null checkCaolán McNamara
Change-Id: Ib4be7b819a5ba68d78d98d8ae05d755898f3cad1 Reviewed-on: https://gerrit.libreoffice.org/48136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-19ofz#5483 Integer-overflowCaolán McNamara
Change-Id: If364a961f5e144cc0f3572108020c99db6febfb8 Reviewed-on: https://gerrit.libreoffice.org/48177 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>