summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2016-01-05sw: revert use of invalid (erased) iteratorMichael Stahl
(regression from commit d75b9fd582f0aa83bd2fc99028b3f83eb7171d61) Change-Id: I6e67ebfbac20b42c0ff8580b575793daec46b68d
2016-01-05tdf#94205: Use o3tl::make_unique insted of new+std::move.Sheikha AL-Hinai
Change-Id: I9ff14760479d2ac882546e2e5b74ab750ba2fa4b Reviewed-on: https://gerrit.libreoffice.org/20984 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-01-05CppunitTest_sw_uiwriter: tolerate lower than 276 in testTdf96536()Miklos Vajna
Seen on an OS X tinderbox from time to time, but not always. Change-Id: Ie6796de5095a6d3b583fa8494444f4d662db8b12
2016-01-05new loplugin rangedforcopy - use reference in range based forAndrzej Hunt
Inspired by 6e6ae9803796b120e95f6e89575e03c5fd0ed3c2 Change-Id: Ia0f264d3a6bbf076aa5080e3398683e50bc6ef01 Reviewed-on: https://gerrit.libreoffice.org/20190 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-01-05tdf#96674 drawingML import: fix handling of zero width/height linesMiklos Vajna
Change-Id: If3d9f6272031e08ab228cfa58963d60ceede2498
2016-01-05tdf#69640: Treat errors opening OLE stream gracefullyMike Kaganski
The testcase for tdf#69640 includes links (relations) to external pptx files. It demonstrates two non-fatal reasons for failure opening OLE stream: 1. it fails OStorageHelper::IsValidZipEntryFileName check, because the file path contains ":\"; 2. even if that were not the case, the required file can be absent from user's system. I suppose that intercepting the failure at the level of OOXMLOLEHandler::attribute() is the best option, because at the lower level it's unknown if this failure is fatal or not. I suppose that it could be also useful to intercept specifically failures in OStorageHelper::IsValidZipEntryFileName, checking if the file exist externally, and asking users if they want to update external links (as MSO does). Possibly it should be discussed with UX team if that should be done, and if so, do it in separate commit. Change-Id: I240a6f69abe236eb790bb406c79f3b761fb4638a Reviewed-on: https://gerrit.libreoffice.org/19963 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-01-04DOC(X) filter: BAF -> BAILS in the smart tag mappingMiklos Vajna
The filters map between a common subset of Word smart tags and Writer RDF annotations, and when doing so, they need to know what path to use for a smart tag namespace and also the other way around: what RDF types are interesting for smart tag purposes. It turns out there is BAILS specification at <http://www.tscp.org/wp-content/uploads/2013/08/TSCP_BAILSv1.pdf> that describes how to refer to BAF objects, so use that instead of our custom RDF statement / document metadata key names. Change-Id: Iac569608b05aa61547f664f2a5df7d46fe46da76
2016-01-04these fields can be static constantsNoel Grandin
Change-Id: Id56e219782d7f858cdeb26232c7aabd4f643c9d9 Reviewed-on: https://gerrit.libreoffice.org/21020 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-04sw: prefix members of SwAttrSetChgMiklos Vajna
Change-Id: Ie24194fe04dafbc447cf8a8a015316e9ba6e9ac9 Reviewed-on: https://gerrit.libreoffice.org/21071 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-01-03cppcheck: passedByValueCaolán McNamara
Change-Id: Id8b2db3b824ea40345aba99a5f24f2579c0ad630
2016-01-03loplugin:stringconstantStephan Bergmann
Change-Id: I588a9c0205e03f701b617fd1775e7f9b9b88c6b0
2016-01-04Cleanup after removing vcl::FontInfo classChris Sherlock
Change-Id: I544eac439cb7277e47a23a90c6fbc45496161c3b
2016-01-03loplugin:stringconstantStephan Bergmann
Change-Id: I60ee2ccc6090c305ade4ba16d3d298866cf89c4e
2016-01-03vcl: Excise vcl::FontInfo classChris Sherlock
This may sound crazy, but literally vcl::FontInfo serves no purpose that I can see. The inheritance chain is like this: ┌────────────────────────┐ │ │ │ vcl::Font │ │ │ └────────────────────────┘ ^ ╱ ╲ │ │ ┌────────────────────────┐ │ │ │ vcl::FontInfo │ │ │ └────────────────────────┘ ^ ╱ ╲ │ │ ┌────────────────────────┐ │ │ │ FontMetric │ │ │ └────────────────────────┘ vcl::FontInfo (which, incidentally, needs to be put into the vcl namespace due to collisions with poppler!) literally does nothing and is acting as a bridge between FontMetric and vcl::Font. Unlike a bridge though, this bridge doesn't actually *do* anything. So I'm removing it, which means one less class to deal with in the vcl fonts world. Change-Id: I32725669c9bca7fbb0846b6a062135464046e4f6 Reviewed-on: https://gerrit.libreoffice.org/21058 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-02tdf#92623 MM: add unit testJan-Marek Glogowski
Adds the missing unit test to the bugfix. Actually the original bug was a crash, so this just does some test on the resulting MM document. Change-Id: I4c9f031e57157fe5744aa8290b7503b7e1990fc7
2016-01-02tdf#96479 workaround bookmark end pos handling...Jan-Marek Glogowski
... when inserting text into a text node. Seems SwTextNode::InsertText doesn't handle bookmark end positions correctly. This is just handled correctly, if it also contains the bookmark start. This workaround simply concats the three strings to be inserted in advance, so we just have to call SwTextNode::InsertText once for the whole string. Change-Id: Iab7708b4cc4df406bdbc3a685c7410e0e797fdc4
2016-01-02fix indentBjoern Michaelsen
Change-Id: I79623024b008b60a33935942986e8a98fccc3d8d
2016-01-02make this temp override of ItemSet more explicit and scopedBjoern Michaelsen
Change-Id: I8a02be2772b8f7c0d1b13556d0c49f1b00bcc1aa
2016-01-02trying to chip away some of the memory mgmt madness hereBjoern Michaelsen
- mpItemSet is assumed to be owned by SwStyleBase_Impl - yet it can be external set to any naked pointer - ... and is (temporary, at least that is the hope) set to ItemSets owned by others Change-Id: I0cd56f5bb9f58a2e5ab09f49f66faf8a63c69f37
2016-01-02code conventions: member prefixBjoern Michaelsen
... also kill some plenking Change-Id: I03c0669239bba5f63a7dc5a078f5b4c4f2a51386
2016-01-01refactor SwXStyle::SetPropertyValues_ImplBjoern Michaelsen
- reduce scope of getConstArray variables - use m_nPropMapType directly - remove some plenking Change-Id: Id507cffe2563bf078fe5e3e2a8267f352533844e
2016-01-01remove desd codeBjoern Michaelsen
Change-Id: Ifc81677eb3331a786a964f89aa425916df6364b4
2015-12-30coverity#1346891 Unused valueCaolán McNamara
Change-Id: Id46a93a8dd1baadf062ea4e5aa471d42aa04468d
2015-12-30Kill remaining plugin bitsMaxim Monastirsky
Change-Id: Icd99757b48626ef43313e8de42c4e5462f85a958 Reviewed-on: https://gerrit.libreoffice.org/21008 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-12-29cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: Ib43e53d5b6c9c130adb765ac9b769f58060ac640
2015-12-28crashtesting: assert on export of fdo45349-3.fodt to docCaolán McNamara
set a DefaultParentBaseURL fallback from createAndInsertOLEObject Change-Id: Ibc6e800be66f966533a8304ddf72eefa2b39fb8a
2015-12-28Typo: pysical->physicalJulien Nabet
Change-Id: I73d006ee5de8294cc0dc1cf48a77c6e4466c49ae
2015-12-27Prefer switch-case to cascaded ifsMatteo Casalin
Change-Id: Ic3fdf87c3028ae6367447f168a04cdc6fd2b0559
2015-12-27Whitespace cleanupsMatteo Casalin
Change-Id: I18e7323297ef840c8a8547299450dcb93221b85e
2015-12-27Avoid comma operatorMatteo Casalin
Change-Id: I113b3b4ac54b08b6feb0d3e1d05c534e8e3fac7b
2015-12-27sal_uLong/sal_uIntPtr/sal_uInt16 to sal_uInt32Matteo Casalin
also avoid some explicit temporaries and group some checks. Change-Id: I7795b208dde53fd383b8c75f72dd9f56429aea2b
2015-12-27sal_uLong/sal_uIntPtr for ScNumFormatAbbrevMatteo Casalin
Change-Id: I45f2a43fe4295e44691ab00c93af3fca41b1dcfa
2015-12-27Fix TBs by adding some "override"Julien Nabet
Perhaps a temporary fix, but at least, it should unblock some TBs + those who use --enable-werror Change-Id: Id075e2539245a90b829f1816609dfe1ec65fe7b9
2015-12-26sw: (vba) change instances of maName to more descriptive namesChris Sherlock
Change-Id: Icb20fa909681ccb6acfc72f4243c09e9b9b4a3c2 Reviewed-on: https://gerrit.libreoffice.org/20957 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-12-25Revert "tdf#96412 Fix export text table cell UserDefinedAttributes to xml."jan iversen
This reverts commit d3e57ccf2e56a75bd4f004de53793f1742e34bc4. There is a problem with the test case, that breaks 2 tinderboxes. A simple test, detected more errors, open the document in LO 5.0.x and save it, then the test case has a problem on all platforms. Change-Id: If4d6a62ed5e7882e6e61e7d31ca0a29094df103c Reviewed-on: https://gerrit.libreoffice.org/20935 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2015-12-25remove (now) unused functionBjoern Michaelsen
Change-Id: Iddf0fce5343abeb199cb5d0c37d933d68c0e4c6a
2015-12-25refactor SwXStyle::ApplyDescriptorPropertiesBjoern Michaelsen
Change-Id: I219e75082c655a0895c75932863e596fcfccc656
2015-12-25refactor SwXStyle::getPropertySetInfoBjoern Michaelsen
Change-Id: If2ecee5c0e97c3955cffe4eb23d2bf651ec4ef2a
2015-12-25refactor SwXStyle::get/setParentStyleBjoern Michaelsen
Change-Id: Ifb578244d511af153484d14ee92c5c22c2db0a3f
2015-12-25refactor SwXStyle::isUserDefined/isInUseBjoern Michaelsen
Change-Id: I67d8408d410698f0f31738fcc30321c627307c73
2015-12-25refactor SwXStyle::get/setNameBjoern Michaelsen
Change-Id: If814b6873796fcfa4cc7a2f62711a8b20f2f7d6b
2015-12-25use local init function for conditional tooBjoern Michaelsen
Change-Id: I687161aa9295a1b815d11dd10fa83d23b010764a
2015-12-25use init helpers in ctorBjoern Michaelsen
Change-Id: If06321f5b353a09985d071290ece612fb98b34a1
2015-12-25have PROPERTY_MAP values in entries ...Bjoern Michaelsen
Change-Id: I478eb10315ee0709c43943945d500b82a8d9c8c9
2015-12-25lets have a ref to a StyleEntry from a SwXStyle tooBjoern Michaelsen
Change-Id: I368b2a6a6b5c54a962fed637c7e8cd472414be5c
2015-12-25refactor SwXStyle ctorBjoern Michaelsen
Change-Id: I306ca1b20af83519f81ca0867eb73cbbaa1874d2
2015-12-25remove GetPropImpl wrapperBjoern Michaelsen
Change-Id: I53c3f97d35621af9b6c5c0336b8c998d3fe0b270
2015-12-25remove GetBasePool wrappersBjoern Michaelsen
Change-Id: I0e7e8309c5d8873b9bde738a00579989d7b105fb
2015-12-25instead of lying with friendship, lets be honestBjoern Michaelsen
Change-Id: I0582734a0995638f45888e32c108e56ab3f28e80
2015-12-25use a proper smart pointer hereBjoern Michaelsen
Change-Id: Ic413e08bbaf38a6858926b1309618762a9ed1444
generated by cgit (git 2.34.1) at 2024-08-13 10:05:12 +0000