summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)Author
2019-01-15tdf#122455 RTF export: fix font style from list def leaking into first paraMiklos Vajna
This was a problem since RtfAttributeOutput::NumberingLevel() started to use OutputItemSet() or when m_aStyles and m_aStylesEnd was separated, but both were already like this in commit 5bbc027d5dae3472223538b13933ff821e027737 (cws-vmiklos01.diff: Better RTF export filter, 2010-09-17). If m_aStylesEnd is not consumed by NumberingLevel(), then the first run will include its contents, which is incorrect. Change-Id: Ifc93ae5f0057102fab636febae5ee2462361878e Reviewed-on: https://gerrit.libreoffice.org/66332 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-15use unique_ptr in SwPostItMgrNoel Grandin
Change-Id: Icc946b986f62d986e979e6a3f3ba0d2c28cb9adf Reviewed-on: https://gerrit.libreoffice.org/66312 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-15use unique_ptr in WW8StyleNoel Grandin
Change-Id: I01b7b42d626a29b0702cc2aa51d0fdeb75282740 Reviewed-on: https://gerrit.libreoffice.org/66320 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-15use unique_ptr in swNoel Grandin
Change-Id: I02026ffd808fa4939666c791c476cd0c0632cde3 Reviewed-on: https://gerrit.libreoffice.org/66319 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-15use unique_ptr in SwWW8ImplReader::ConstructApoNoel Grandin
Change-Id: I104168fbbd04f81d500bc9d63d4328aee0a11f24 Reviewed-on: https://gerrit.libreoffice.org/66318 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-15use unique_ptr in swNoel Grandin
Change-Id: I8c472a7d363eb308e9ec78aadd7f1f20c824447b Reviewed-on: https://gerrit.libreoffice.org/66317 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-15fix unnecessary deleteNoel Grandin
the erase on the preceding line will delete it, ever since commit a846c7106d4e4e1b8cc61e237cc2e158d037e816 Date: Wed Jul 25 12:26:15 2018 +0200 loplugin:useuniqueptr in SwGlossaryList Change-Id: I8f71bca8eebf762aeea3225d3a3b52ec2ac60e19 Reviewed-on: https://gerrit.libreoffice.org/66316 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-15simplify UCB_GetFileListOfFolderNoel Grandin
no need to use heap objects here Change-Id: Iadc35b019da7b9446ede79c96a9d8ce8c6db81ef Reviewed-on: https://gerrit.libreoffice.org/66315 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-15use unique_ptr for SwTableAutoFormatNoel Grandin
Change-Id: Ib83be524b5c15e4639a834494726501ac7aa6755 Reviewed-on: https://gerrit.libreoffice.org/66314 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-15use unique_ptr in swNoel Grandin
Change-Id: I369ef79e88a40c01f5384e2427c3dec429ea0457 Reviewed-on: https://gerrit.libreoffice.org/66311 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-15tdf#122186: Fix broken Input list after RT in DOCX formatTamás Zolnai
We should not write out the text of the field, because it confuses the import code and it's unneeded anyway. Change-Id: Id114f74c5d135e9fe6cb059e25ebf324464c8362 Reviewed-on: https://gerrit.libreoffice.org/66338 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-01-14tdf#121111 ww8export: fillstyle_NONE needs a nil backgroundJustin Luth
Without this, there is no way to cancel out an inherited background color. tdf#116071's unit test depends on this fix in order to round-trip. Change-Id: I99ad28ee87a6bea040e0ef3c712c1c911be70004 Reviewed-on: https://gerrit.libreoffice.org/64185 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-01-14ofz#12507 micro optCaolán McNamara
Change-Id: I7cdb2e371cb3e209b71659174594bf5bb687f379 Reviewed-on: https://gerrit.libreoffice.org/66284 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-14use unique_ptr in XMLPropertyHandlerFactory::CreatePropertyHandlerNoel Grandin
Change-Id: Idb33e3a23b7e6001b2c549875a16b475d3ecd470 Reviewed-on: https://gerrit.libreoffice.org/66186 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-14use unique_ptr in SwProgressNoel Grandin
Change-Id: I7a5d271b2da175e064d50e8b99460e4e024237fb Reviewed-on: https://gerrit.libreoffice.org/66188 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-14use unique_ptr in SwXMLItemSetStyleContext_Impl::ConnectPageDescNoel Grandin
Change-Id: Ie633140acbb3254fb90056a601d58843cf8116cf Reviewed-on: https://gerrit.libreoffice.org/66187 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-14use unique_ptr in CSS1ParserNoel Grandin
Change-Id: I4553233f7cf2f54a94154f41e899183490eec3e9 Reviewed-on: https://gerrit.libreoffice.org/66184 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-13ofz#12500 ubsan errorCaolán McNamara
Change-Id: I2520f77116be418a2cb8bcf3731894dc3dd4fb56 Reviewed-on: https://gerrit.libreoffice.org/66272 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-12added forgotten prefix to aDatahimajin100000
Change-Id: I9887b8abcaccec2ec5ea14b3f43375c4b684b5ea Reviewed-on: https://gerrit.libreoffice.org/66202 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-12tdf#120145 ww8import: ignoreCols if section is insertedJustin Luth
Otherwise, the column setting is duplicated both in the section and in the page style. Change-Id: I14383c646e709a3653f1054f0d4170a2963529c1 Reviewed-on: https://gerrit.libreoffice.org/66151 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-01-12Removed executable permission on (odt|cxx) filesAndrea Gelmini
Change-Id: I72da2e5b804d76205b288388a3436de07c7a23cd Reviewed-on: https://gerrit.libreoffice.org/66207 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-12make SwFormat a ::sw::BroadcastingModifyBjoern Michaelsen
- clean up SwSection..Hint: Lazily reusing the Dying HintId is evil - switch the SwChartDataSequence to SvtListener - add some description to RuntimeException Change-Id: I897a63030f207cabe4d1ba7de0c25c6c581ffd1f Reviewed-on: https://gerrit.libreoffice.org/65816 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-01-12use unique_ptr in SvXMLExportItemMapperNoel Grandin
Change-Id: I71cc6b270375164c466e22f62c568cd757204efe Reviewed-on: https://gerrit.libreoffice.org/66185 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-12use unique_ptr in SfxEventConfiguration::ConvertToMacroNoel Grandin
Change-Id: I7f96ce55b22212c38972a51c9273c9f9cd241acf Reviewed-on: https://gerrit.libreoffice.org/66183 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-12use unique_ptr in SwViewShell::PrintOrPDFExportNoel Grandin
Change-Id: I43defece1279c7c170519d3950856c888ebad224 Reviewed-on: https://gerrit.libreoffice.org/66182 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-12tdf#122658: Empty date form field is not exported correctly to DOCX fileTamás Zolnai
We need to export date format and also text content in case of empty date field. Otherwise the exported date field will be lost during import into LO Writer or MSO Word. Change-Id: I5cf65bedba010f64ca8f56262057f3cce32b0943 Reviewed-on: https://gerrit.libreoffice.org/66194 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-01-11sw: restore accidentally deleted/disabled UITestsMichael Stahl
(regression from 457acbfa304ac8bda0755c9ca8f1e1e22e490ac8) Change-Id: I2e437748d5a98c3b3eef501134ef9442f8fc3451 Reviewed-on: https://gerrit.libreoffice.org/66179 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-11tdf#122589 rtfexport: no duplicate section at document startJustin Luth
If the document starts with a real section, then RTF export should not write out \sect before the first paragraph, because there already is an implicit section. Otherwise on import it is treated as an empty paragraph. The reason this problem doesn't multiply on each round-trip is that the import process puts a PageBreak on the first paragraph, and so it follows a different code path. The ODT file does not contain a PageBreak on the first paragraph. Change-Id: I8f2d48c932587aaf162e8f7352adf12ec15645f0 Reviewed-on: https://gerrit.libreoffice.org/66017 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-01-11sw_redlinehide: fix infinite loop when deleting commentsMichael Stahl
The problem is that sw::UpdateFramesForAddDeleteRedline() sends a SwFormatFieldHintWhich::REMOVED event in order to remove any comments that may have been deleted from the document view. Unfortunately there's another listener in class FieldDocWatchingStack that is used during various SwPostItMgr::Delete* functions, which will effectively start over from scratch if it receives this event, so it is an infinite loop. Avoid this by simply ignoring any redline-deleted fields; deleting them again won't provide any benefit anyway. This can be seen with UITest deleteAllComments.DeleteAllComments.test_comment_trackchanges. (regression from 9b67b6a6d4b912f1e515d3884fa02c1be8aa6921) Change-Id: Ie1d5676d1d79a51e2e4a01a3e282f8739ff08899 Reviewed-on: https://gerrit.libreoffice.org/66178 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-01-11Replace OUStringBuffer::appendCopy with append(std::u16string_view)Stephan Bergmann
...which is more general Change-Id: I94f28f8eda887120cf5f143b4549e0339b60e6a7 Reviewed-on: https://gerrit.libreoffice.org/66155 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-11tdf#42949 Fix IWYU warnings in sw/inc/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. - Also fix .h / .hrc files - Remove a bit of duplication from the .yaml file Change-Id: I22145a79343497678e481d882544eb08e765312a Reviewed-on: https://gerrit.libreoffice.org/65878 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-11use unique_ptr in swNoel Grandin
Change-Id: I471875142391e537a4301dfe42beb8f8803ff46b Reviewed-on: https://gerrit.libreoffice.org/66036 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-11make insert-section dialog asyncNoel Grandin
Change-Id: Ia48f4103b8f346a93ebe1f2c5078f21a90884e3f Reviewed-on: https://gerrit.libreoffice.org/66065 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-11use unique_ptr in SwViewShell::ImplEndActionNoel Grandin
Change-Id: I9be790996347e191df63198de109acf973104d0d Reviewed-on: https://gerrit.libreoffice.org/66125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-11use unique_ptr in SwNodes::ExpandRangeForTableBoxNoel Grandin
Change-Id: I31cc9d6b962c116c64789d886b82ea476f4e5144 Reviewed-on: https://gerrit.libreoffice.org/66124 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-11use unique_ptr in SwXNumberingRulesNoel Grandin
Change-Id: I7daa1fbd11c62d712b2ff70714b5e5bda63d54d8 Reviewed-on: https://gerrit.libreoffice.org/66123 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-11use unique_ptr in SwXFrameNoel Grandin
Change-Id: I3671bf7ab7913a2f07eec347c1e07d036bfca4c4 Reviewed-on: https://gerrit.libreoffice.org/66122 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-11no need to allocate on heap in SwUndoSortListNoel Grandin
Change-Id: I949a9d32b18d5ccae17dee26f030173307d0b3fb Reviewed-on: https://gerrit.libreoffice.org/66121 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-11use unique_ptr in SwUndoDelSectionNoel Grandin
Change-Id: I2637872300c60f880e32b00f5f545f6145b563bf Reviewed-on: https://gerrit.libreoffice.org/66120 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-11use unique_ptr in SwLayHelperNoel Grandin
Change-Id: I6b7ee99bb38df882853e3695cd03dcc745c92318 Reviewed-on: https://gerrit.libreoffice.org/66035 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-11writerfilter: import section margins and writingModeJustin Luth
Previously, only page styles got these values. But if the section is continuous, then these properties should be transferred to the section itself. This patch relies on the commit for tdf#122456. It confirms that it is a good idea for the last section to ignore the "fake" section and keep the real section properties. Otherwise these margins would be lost on export. Change-Id: I45efb0d80fb9307a57ff560b2e1a26899155f827 Reviewed-on: https://gerrit.libreoffice.org/65975 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-01-10DocumentSettings Writer UNO API test (converted from Java test)Tomaž Vajngerl
Change-Id: Id9a691b1aae62f37ef7f865c5ed015b7c6a13976 Reviewed-on: https://gerrit.libreoffice.org/65909 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-01-10Resolves: tdf#43220 ensure old popup is destroyed on replacementCaolán McNamara
with a new one Change-Id: I0979cea429b2d1e55835ff5a65725b84b7764201 Reviewed-on: https://gerrit.libreoffice.org/66084 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-10tdf#122563 DOCX import: fix OLE size after roundtripLászló Németh
Embedded XLSX spreadsheets and other OLE objects became small in Writer after a roundtrip between LibO and MSO, caused by the empty drawing path of OLE shapes. Change-Id: I4cd39d4bcd6707cc5a3b8e40dde8c6148a20cabc Reviewed-on: https://gerrit.libreoffice.org/66053 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-01-10make table-of-contents dialog asyncNoel Grandin
Change-Id: I839eaa820952ff39818b5ed9bd06a44eec3f39d3 Reviewed-on: https://gerrit.libreoffice.org/66069 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-10use unique_ptr in SwTextNodeNoel Grandin
Change-Id: I3f263a617e0ca48cbbe894a061910f1af767bb11 Reviewed-on: https://gerrit.libreoffice.org/66037 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-10use unique_ptr in swNoel Grandin
Change-Id: I13ab934932a24f49a0e37257d397de7ed88f66bf Reviewed-on: https://gerrit.libreoffice.org/66034 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-10fix leak in SwDrawFrameFormat::GetDescriptionNoel Grandin
and simplify. ever since original code was committed in commit da12dc5adf9086d418ff0d09abee23fdd8f68cda Date: Wed Sep 8 14:20:23 2004 +0000 INTEGRATION: CWS swundo03 (1.48.34); FILE MERGED Change-Id: I9aae40eade34051219f1fe838b373e0f3317d2c6 Reviewed-on: https://gerrit.libreoffice.org/66026 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-10use unique_ptr in SwCacheNoel Grandin
Change-Id: I2b961380dcb5eb26ce517f7b56e5c32f5e6429e4 Reviewed-on: https://gerrit.libreoffice.org/66011 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-09tdf#81750 new unit test: no duplication of field contentSerge Krot
Change-Id: I53eeca0dfad9176935a70b98a19b2ce044969031 Reviewed-on: https://gerrit.libreoffice.org/66004 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
generated by cgit (git 2.34.1) at 2024-08-17 14:07:23 +0000